Re: [Mesa-dev] [PATCH 05/10] llvmpipe: implement user constant buffers

Am 11.01.2018 um 00:27 schrieb Marek Olšák: > On Thu, Jan 11, 2018 at 12:12 AM, Roland Scheidegger > wrote: >> Am 10.01.2018 um 20:49 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/llvmpipe/lp_screen.c | 2 +- >>>

[Mesa-dev] [PATCH] radv: trim buffer load result (fixes dota2)

From: Dave Airlie Running dota2 since the below commit crashes with an llvm assert. Trim the vector like the other user. This possible could also be avoided by not padding inside the load vec3->vec4. Fixes: 41c36c4549 (amd/common: use ac_build_buffer_load() for emitting UBO

Re: [Mesa-dev] [PATCH 04/21] r600/sb: add tess/compute initial state registers.

On 11 January 2018 at 12:19, Roland Scheidegger wrote: > Am 10.01.2018 um 07:48 schrieb Dave Airlie: >> From: Dave Airlie >> >> This stops them being optimised out. >> --- >> src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 5 - >> 1 file changed, 4

Re: [Mesa-dev] [PATCH 04/21] r600/sb: add tess/compute initial state registers.

Am 11.01.2018 um 03:28 schrieb Dave Airlie: > On 11 January 2018 at 12:19, Roland Scheidegger wrote: >> Am 10.01.2018 um 07:48 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This stops them being optimised out. >>> --- >>>

Re: [Mesa-dev] [PATCH] radeonsi: don't ignore pitch for imported textures

Tested-by: Dieter Nützel on RX580 with UH, UV, glmark2 and Blender 2.79 with and without nir. Dieter Am 10.01.2018 20:49, schrieb Marek Olšák: From: Marek Olšák Cc: 17.2 17.3 ---

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Evangelos Foutras changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v2 1/3] util/crc32: don't drop the const qualifier

Patches 1 and 3 are Reviewed-by: Ian Romanick On 01/09/2018 02:58 PM, Grazvydas Ignotas wrote: > Signed-off-by: Grazvydas Ignotas > --- > src/util/crc32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/crc32.c

Re: [Mesa-dev] [PATCH] st/mesa: Factorize duplicate code in st_update_framebuffer_state()

Reviewed-by: Marek Olšák Marek On Fri, Jan 5, 2018 at 5:49 PM, Guillaume Charifi wrote: > Signed-off-by: Guillaume Charifi > --- > src/mesa/state_tracker/st_atom_framebuffer.c | 18 +- > 1 file changed,

Re: [Mesa-dev] [PATCH 7/7] radeonsi/nir: add support vs double inputs

For patches 1, 4-7: Reviewed-by: Marek Olšák Marek On Mon, Jan 8, 2018 at 1:35 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] radv: don't emit unneeded vertex state.

Tested-by: Dieter Nützel Woohoo, this one shot 'smoketest' for the first time over 1200 fps on my system (RX580, Xeon X3470, 4/8, ~3 GHz, 24 GB)! Comming from ~1060-1080 fps. 6154 presents in 5.00069 seconds (FPS: 1230.63) 6183 presents in 5.00108 seconds (FPS:

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli With this patch now committed

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin: [...] > > If your hardware executes all the vertices in parallel, then a > barrier should be unnecessary. My first try for this patch did not include forcing the barrier into slot x, which in turn resulted in failing piglits, e.g.    

Re: [Mesa-dev] [PATCH 04/21] r600/sb: add tess/compute initial state registers.

Am 10.01.2018 um 07:48 schrieb Dave Airlie: > From: Dave Airlie > > This stops them being optimised out. > --- > src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #35 from fdb...@fratti.ch --- That patch fixes https://bugs.freedesktop.org/show_bug.cgi?id=104301 too, so I'm guessing this was the same issue. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #36 from Evangelos Foutras --- *** Bug 104342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [RFC 07/10] mesa: add program blob cache functionality

On 01/11/2018 12:43 AM, Jordan Justen wrote: On 2018-01-08 23:48:19, Tapani Pälli wrote: Cache set and get are called in similar fashion as what is happening with disk cache. Functionality requires ARB_get_program_binary and EGL_ANDROID_blob_cache support. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v2 3/3] util: use faster zlib's CRC32 implementaion

Reviewed-by: Marek Olšák Marek On Tue, Jan 9, 2018 at 11:58 PM, Grazvydas Ignotas wrote: > zlib provides a faster slice-by-4 CRC32 implementation than the > traditional single byte lookup one used by mesa. As most supported > platforms now link zlib

[Mesa-dev] [PATCH 1/2] ac/shader: gather more push constant info

From: Dave Airlie This gathers the min/max push consts used, and whether the shader uses indirect push constants. It also adds an init function to handle the combined shaders. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 ++

[Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

From: Dave Airlie Instead of putting the push constants into the upload buffer, if we have space in the sgprs we can upload the per-stage constants into the shaders directly. This saves a few reads from memory in the meta shaders, we should also be able to inline other

Re: [Mesa-dev] [PATCH 05/21] r600/sb: start adding GDS support

Am 10.01.2018 um 07:48 schrieb Dave Airlie: > From: Dave Airlie > > This adds support for GDS ops to sb backend. > > This seems to work for atomics and tess factor writes. > > Signed-off-by: Dave Airlie > diff --git

Re: [Mesa-dev] [PATCH 7/7] radeonsi/nir: add support vs double inputs

For the series: Tested-by: Dieter Nützel Dieter Am 08.01.2018 01:35, schrieb Timothy Arceri: --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c

[Mesa-dev] [PATCH 1/2] ac: add f64_1 to the llvm build context

--- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 07044142b0..75cc0dc63c 100644 --- a/src/amd/common/ac_llvm_build.c +++

[Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_frsq for doubles

Without this we en up with the llvm error message: "Both operands to a binary operator are not of the same type!" --- src/amd/common/ac_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH 10/10] gallium/u_threaded: don't run out of memory with staging uploads

For the series: Tested-by: Dieter Nützel on RX580 with UH, UV, glmark2 and Blender 2.79 with and without nir. Dieter Am 10.01.2018 20:49, schrieb Marek Olšák: From: Marek Olšák Cc: 17.2 17.3 ---

[Mesa-dev] [PATCH 1/2] radv: precalculate some vertex info in the binding.

From: Dave Airlie This just moves some calcs from the emission to the binding. Probably won't affect much, just reduced some time spent in binding --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- src/amd/vulkan/radv_private.h| 1 + 2 files changed, 7

[Mesa-dev] [PATCH 2/2] radv/winsys: skip padded empty buffers in chain.

From: Dave Airlie When chaining buffers if we see an empty one (just padded) skip over it. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c

[Mesa-dev] [PATCH] st/glsl_to_nir: disable io lowering to temps for tess

Lowering these to temps makes a big mess, and results in some piglit test failures. Also the radeonsi backend (the only backend to support tess) has support for indirects so there is no need to lower them anyway. Fixes the following piglit tests on radeonsi:

[Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

From: Dave Airlie This should make the merging of cmd buffers less CPU intensive, note I said *should* :) --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 47 --- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

Hi Bas, If I read it correctly, you are trying to interpret the ClipRule as a mask. You set the bit i if the ith rectangle is need to be inclusive. Am I right? IIRC, It is not a right interpretation. Where did you read the register spec? I would like to take a look. Thanks. Best Regards,

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #4 from florian.w...@googlemail.com --- I used the generated_tests/random_ubo-arb_uniform_buffer_object.py script and it generated 270 tests, and initially they all passed. That's because the tests only verify matrix values using the

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #25 from Thomas Hellström --- Created attachment 136645 --> https://bugs.freedesktop.org/attachment.cgi?id=136645=edit Patch to fix a potential problem with renderbuffer freeing There is a potential problem

Re: [Mesa-dev] [PATCH] amd/common: bump the number of available user SGPRS to 32 on GFX9

Reviewed-by: Bas Nieuwenhuizen On Mon, Jan 8, 2018 at 3:21 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Thomas Hellström changed: What|Removed |Added Attachment #136645|0 |1 is

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #28 from Thomas Hellström --- (In reply to Evangelos Foutras from comment #27) > I'm totally unfamiliar with gpu driver code but I'm wondering why the > "buf->pixmap == ie->pixmap" check isn't used anymore;

Re: [Mesa-dev] [PATCH v2 2/3] android, configure, meson: define HAVE_ZLIB

On Wednesday, 2018-01-10 00:58:33 +0200, Grazvydas Ignotas wrote: > The next change wants to use some optional zlib functionality, however > not all platforms currently use it. Based on earlier Jordan Justen's > patches and their review feedback. > > Signed-off-by: Grazvydas Ignotas

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #5 from florian.w...@googlemail.com --- Created attachment 136648 --> https://bugs.freedesktop.org/attachment.cgi?id=136648=edit Proposed patch, needs more testing I now have a patch that works for all the 270 random UBO test

Re: [Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

On Wed, 2018-01-10 at 08:54 -0800, Kenneth Graunke wrote: > On Wednesday, January 10, 2018 5:11:21 AM PST Iago Toral wrote: > > On Mon, 2018-01-08 at 13:30 -0800, Kenneth Graunke wrote: > > > Growing the batch/state buffer is a lot more dangerous than I > > > thought. > > > > > > A number of

[Mesa-dev] [Bug 104376] [ILK] Browser crashes while switching between fullscreen and windowed video on youtube.

https://bugs.freedesktop.org/show_bug.cgi?id=104376 Thomas Hellström changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Thomas Hellström changed: What|Removed |Added Assignee|i...@freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Use UW types when using V immediates

On Wed, Jan 10, 2018 at 9:55 AM, Matt Turner wrote: > Bizarre. Hope we can get more info on what's going on, but if UW makes > it work, let's do it. > > Both are: > > Reviewed-by: Matt Turner > Thanks! Based on the limited information, do you have any

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Use UW types when using V immediates

Bizarre. Hope we can get more info on what's going on, but if UW makes it work, let's do it. Both are: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Thomas Hellström changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 15/15] radeonsi: implement 32-bit pointers in user data SGPRs

On 01/10/2018 05:11 PM, Marek Olšák wrote: On Mon, Jan 8, 2018 at 10:31 PM, Samuel Pitoiset wrote: On 01/06/2018 12:12 PM, Marek Olšák wrote: From: Marek Olšák SGPRS: 2170102 -> 2158430 (-0.54 %) VGPRS: 1645656 -> 1641516 (-0.25 %)

Re: [Mesa-dev] meson: vdpau broken on r600

I'm not sure off the top of my head. I don't have an r600 anymore, but I have an SI and a nouveau machine, so I'll see if I can reproduce the problem there and fix it. Dylan Quoting Marc Dietrich (2018-01-09 02:38:33) > Hi Dylan, > > just found that vdpau does not work on r600 with meson build.

[Mesa-dev] [PATCH] meson: generate translations for driconf

Currently meson implements the same logic as SCons for translations, namely it doesn't do them. This patch changes meson to use logic more like autotools, and generate translations. To do this we have to go behind meson's back a bit, and wrap the whole thing up in a single python script. Meson

Re: [Mesa-dev] [PATCH 0/3] Meson build system

I forgot to CC you on this like you asked, Dylan Quoting Dylan Baker (2018-01-05 12:00:57) > This is a fifth iteration of the meson build system for libdrm. This > version is significantly cleaned up from the last version and uses a > style more like the build system in mesa. > > It builds all

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

Hi Christian, >> Otherwise I'm going to give it a few more days on the list and push it if nobody objects. Gentle ping ? So far the series are: Acked-by: Leo Liu Reviewed-by: Julien Isorce Thx Julien On 30 November 2017 at 14:05,

Re: [Mesa-dev] [PATCH] ac: add load_patch_vertices_in() to the abi

Reviewed-by: Samuel Pitoiset On 01/10/2018 07:28 AM, Timothy Arceri wrote: Fixes the follow test for radeonsi nir: tests/spec/arb_tessellation_shader/execution/quads.shader_test Also stops 8 other tests from crashing, they now just fail e.g.

Re: [Mesa-dev] [PATCH] util: fix NORETURN for msvc, add HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h

On 10/01/18 02:15, srol...@vmware.com wrote: From: Roland Scheidegger We've seen some problems internally due to macro redefinition. Fix this by adding HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h, and defining it for msvc. And avoid redefinition just in case. ---

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #30 from Evangelos Foutras --- (In reply to Thomas Hellström from comment #29) > Created attachment 136647 [details] [review] > Updated patch to avoid freeing renderbuffers currently in use Seems to fix my

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. --- src/amd/vulkan/radv_cmd_buffer.c | 51 +++ src/amd/vulkan/radv_device.c | 6 +

Re: [Mesa-dev] [PATCH] r600: Allow egd_tables.py to run with python3 too

On středa 10. ledna 2018 3:49:43 CET Dave Airlie wrote: > On 5 January 2018 at 01:14, Michal Srb wrote: > > From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Chv=C3=A1tal?= > > > > Makes the egd_tables.py compatible with both python 2 and 3. > > This appears to break the

Re: [Mesa-dev] r600 sb tessellation support

Am Mittwoch, den 10.01.2018, 16:48 +1000 schrieb Dave Airlie: > This is an attempt to add tessellation support to the SB backend. > > The main things needed are GDS access which is used for tess > factor storage (also used for atomic counters), and LDS access > which is needed to pass all the

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: > > > On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: >> >> Tested with a modified deferred demo and no regressions in a 1.0.2 >> mustpass run. >> --- >> src/amd/vulkan/radv_cmd_buffer.c | 51 >>

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On 01/10/2018 11:45 AM, Bas Nieuwenhuizen wrote: On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. ---

[Mesa-dev] [PATCH] anv: fix maxDescriptorSet* limits

"The maxDescriptorSet* limit is n times the corresponding maxPerStageDescriptor* limit, where n is the number of shader stages supported by the VkPhysicalDevice. If all shader stages are supported, n = 6 (vertex, tessellation control, tessellation evaluation, geometry, fragment, compute)." Fixes:

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #26 from Evangelos Foutras --- Any Mesa devs trying to repro this, please test with display compositing disabled. I posted some possibly useful printf output in [1]. I'm not sure if

[Mesa-dev] [PATCH] r600/sb: Add a NOP/EOP if the shader is optimized away completely

sb might optimize away a shader completely which results in a segfault, since in this case last_cf is NULL. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: Please, could someone take a look at this patch? Thanks in advance. This looks correct to me. Is there some dEQP/Piglit test for this situation? J.A. On Mon, 2017-12-04 at 17:35 +0100, Juan A. Suarez Romero wrote: According

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #27 from Evangelos Foutras --- (In reply to Thomas Hellström from comment #25) > Created attachment 136645 [details] [review] > Patch to fix a potential problem with renderbuffer freeing Doesn't fix it for

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #6 from Ilia Mirkin --- (In reply to florian.will from comment #5) > I now have a patch that works for all the 270 random UBO test cases > generated using Ian Romanick's useful script (and also my own simple

[Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 12 ++- src/amd/common/ac_llvm_util.c | 18 src/amd/common/ac_llvm_util.h | 6 ++

[Mesa-dev] [PATCH 2/2] amd/common: use ac_build_buffer_load() for emitting UBO loads

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 932d648082..5885c70ef8 100644 ---

Re: [Mesa-dev] [PATCH 1/2] vulkan: move anv VK_EXT_debug_report implementation to common code.

This LGTM. You are taking away the instance constructor/destructor callback but it wasn't used anyway so that's fine. If someone needs it, it can be added later. Reviewed-by: Tapani Pälli On 01/09/2018 04:04 PM, Bas Nieuwenhuizen wrote: For also using it in radv. I

[Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

anv_extensions usage from anv_icd was bringing the unwanted dependency of mako templates for the latter. We don't want that since it will force the dependency even for distributable tarballs which was not needed until now. Jason suggested this approach. Bugzilla:

[Mesa-dev] [PATCH 1/6] i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

This makes sure we flush things out such as depth writes prior to using a surface through the render cache. Besides the overhead of a hash table look-up, this function is harmless to call repeatedly with the same arguments. Cc: "17.3" ---

[Mesa-dev] [PATCH 0/6] i965: Misc sRGB and CCS fixes

This series contains the fixes required to fully re-enable CCS for sRGB render buffers. A bunch of these patches have been sent out individually or in smaller series but they sort-of all go together. Jason Ekstrand (6): i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

Re: [Mesa-dev] [PATCH] swr: Handle indirect indices in GS

Reviewed-by: Bruce Cherniak > On Jan 9, 2018, at 11:50 AM, George Kyriazis > wrote: > > BuilderSWR::swr_gs_llvm_fetch_input() (and consequently > swr_gs_llvm_fetch_input()), did not handle the case where > is_vindex_indirect or

[Mesa-dev] [PATCH 03/10] gallium: remove PIPE_CAP_TEXTURE_SHADOW_MAP

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 3 --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 - src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/i915/i915_screen.c | 1 -

[Mesa-dev] [PATCH 02/10] st/mesa: expose ARB_sync unconditionally

From: Marek Olšák All drivers support it. --- src/mesa/state_tracker/st_extensions.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 2827c59..ea49abf 100644 ---

[Mesa-dev] [PATCH 01/10] gallium: remove PIPE_CAP_TWO_SIDED_STENCIL

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 -- src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 - src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/i915/i915_screen.c | 1 -

[Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

From: Marek Olšák --- src/gallium/drivers/freedreno/freedreno_screen.c | 4 +--- src/gallium/drivers/freedreno/freedreno_state.c | 13 + 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c

[Mesa-dev] [PATCH] radeonsi: don't ignore pitch for imported textures

From: Marek Olšák Cc: 17.2 17.3 --- src/gallium/drivers/radeon/r600_texture.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

On Wed, Jan 10, 2018 at 3:33 PM, Rob Clark wrote: > On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/freedreno/freedreno_screen.c | 4 +--- >>

[Mesa-dev] [PATCH 3/6] Re-enable regular fast-clears (CCS_D) on gen9+

This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68, "i965: Disable regular fast-clears (CCS_D) on gen9+". How taht we've fixed the issue with too many different aux usages in the render cache, it should be safe to re-enable CCS_D for sRGB. Bugzilla:

[Mesa-dev] [PATCH 6/6] i965: Enable CCS_E sampling of sRGB textures as UNORM

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 0bbd661..df0df8c 100644 ---

[Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

--- src/mesa/drivers/dri/i965/brw_draw.c | 41 1 file changed, 41 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 4945dec..9fd44e4 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++

[Mesa-dev] [PATCH 4/6] i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage

This commit unifies the CCS_E and CCS_D cases. This should fix a couple of subtle issues. One is that when you use INTEL_DEBUG=norbc to disable CCS_E, we don't get the sRGB blending workaround. By unifying the code, we give CCS_D that workaround as well. The second issue fixed by this refactor

[Mesa-dev] [PATCH 2/6] i965: Track format and aux usage in the render cache

This lets us perform render cache flushes whenever a surface goes from being used with one aux+format to a different aux+format. This is the "proper" fix for https://bugs.freedesktop.org/102435. ee57b15ec764736e2d5360beaef9fb2045ed0f68 which was really just a partial revert of

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/freedreno/freedreno_screen.c | 4 +--- > src/gallium/drivers/freedreno/freedreno_state.c | 13 + > 2 files changed, 14 insertions(+), 3

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: > This seems to satisfy the sb optimizer, i.e. no regressions in the > piglits compared to disabling sb for tesselation shaders with > barriers but enabling them in general. > --- Actually, it seems this is not enough, at least for

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Wed, Jan 10, 2018 at 3:13 PM, Gert Wollny wrote: > Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: >> This seems to satisfy the sb optimizer, i.e. no regressions in the >> piglits compared to disabling sb for tesselation shaders with >> barriers but enabling

Re: [Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

On Wed, Jan 10, 2018 at 3:27 PM, Ilia Mirkin wrote: > On Wed, Jan 10, 2018 at 3:13 PM, Gert Wollny wrote: >> Am Mittwoch, den 10.01.2018, 16:36 +0100 schrieb Gert Wollny: >>> This seems to satisfy the sb optimizer, i.e. no regressions in the >>>

[Mesa-dev] [PATCH 3/3] amd/common: only load used channels when sampling buffer views

This allows to reduce the number of dwords that are loaded with buffer_load_format_xyzw. For example, when the only used channel is 1, the driver will emit buffer_load_format_x instead. Shader stats for DOW3 (with some local hacky scripts for SPIRV): 143 shaders in 143 tests Totals: SGPRS: 5344

[Mesa-dev] [PATCH 2/3] amd/common: pass the number of channels to ac_build_buffer_load_format()

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 16 src/amd/common/ac_llvm_build.h| 1 + src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 1/3] amd/common: add ac_build_buffer_load_common() helper

For both versions of llvm.amdgcn.buffer.load.{format}.*. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 61 +++--- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH 06/10] nine: assume that user constant buffers are always supported

From: Marek Olšák --- src/gallium/state_trackers/nine/device9.c| 4 - src/gallium/state_trackers/nine/device9.h| 3 - src/gallium/state_trackers/nine/nine_ff.c| 28 +- src/gallium/state_trackers/nine/nine_state.c | 125 +-- 4

[Mesa-dev] [PATCH 08/10] gallium: remove PIPE_CAP_USER_CONSTANT_BUFFERS

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 - src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/i915/i915_screen.c | 1 -

[Mesa-dev] [PATCH 07/10] st/mesa: assume that user constant buffers are always supported

From: Marek Olšák --- src/mesa/state_tracker/st_atom_constbuf.c | 19 +++ src/mesa/state_tracker/st_context.c | 2 -- src/mesa/state_tracker/st_context.h | 1 - src/mesa/state_tracker/st_pbo.c | 18 +++--- 4 files changed,

[Mesa-dev] [PATCH 09/10] gallium/u_tests: add texture_barrier and FBFETCH tests

From: Marek Olšák --- src/gallium/auxiliary/util/u_tests.c | 111 ++- 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_tests.c b/src/gallium/auxiliary/util/u_tests.c index 2548b46..cb337a2 100644

[Mesa-dev] [PATCH 05/10] llvmpipe: implement user constant buffers

From: Marek Olšák --- src/gallium/drivers/llvmpipe/lp_screen.c | 2 +- src/gallium/drivers/llvmpipe/lp_state_fs.c | 18 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 10/10] gallium/u_threaded: don't run out of memory with staging uploads

From: Marek Olšák Cc: 17.2 17.3 --- src/gallium/auxiliary/util/u_threaded_context.c | 13 + src/gallium/auxiliary/util/u_threaded_context.h | 8 2 files changed, 21 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

On Mon, 2018-01-08 at 13:30 -0800, Kenneth Graunke wrote: > Growing the batch/state buffer is a lot more dangerous than I > thought. > > A number of places emit multiple state buffer sections, and then > write > data to the returned pointer, or save a pointer to brw- > >batch.state.bo > and then

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

My last status was that Leo wanted to commit this. Leo are you still waiting for something? Christian. Am 10.01.2018 um 10:29 schrieb Julien Isorce: Hi Christian, >> Otherwise I'm going to give it a few more days on the list and push it if nobody objects. Gentle ping ? So far the series

Re: [Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

On Wed, Jan 10, 2018 at 1:57 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c| 12 ++- > src/amd/common/ac_llvm_util.c | 18 >

Re: [Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

On 01/10/2018 02:24 PM, Grazvydas Ignotas wrote: On Wed, Jan 10, 2018 at 1:57 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 12 ++-

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #31 from Thomas Hellström --- (In reply to Evangelos Foutras from comment #30) > FWIW the "buf->busy == 0" condition seems to always evaluate to true in my > tests; if I omit it and print !!buf->busy before

[Mesa-dev] [RFC PATCH 1/2] r600/sb: Set flags for GROUP_BARRIER instruction and force it into slot X

This seems to satisfy the sb optimizer, i.e. no regressions in the piglits compared to disabling sb for tesselation shaders with barriers but enabling them in general. --- The series goes on top of the r600 sb tessellation support patches. Best, Gert src/gallium/drivers/r600/sb/sb_bc.h

Re: [Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

On Wed, Jan 10, 2018 at 4:09 AM, Andres Gomez wrote: > anv_extensions usage from anv_icd was bringing the unwanted dependency > of mako templates for the latter. We don't want that since it will > force the dependency even for distributable tarballs which was not > needed

Re: [Mesa-dev] [PATCH] anv: fix maxDescriptorSet* limits

On Wed, Jan 10, 2018 at 1:35 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > "The maxDescriptorSet* limit is n times the corresponding > maxPerStageDescriptor* limit, where n is the number of shader stages > supported by the VkPhysicalDevice. If all shader stages are supported, > n

  1   2   >