Re: [Mesa-dev] [Mesa-stable] [PATCH] swr/rast: support llvm 3.9 type declarations

On Jan 24, 2018, at 11:43 AM, Emil Velikov > wrote: On 24 January 2018 at 15:30, George Kyriazis > wrote: LLVM 3.9 was not taken into in initial check-in. Fixes: 01ab218bbc

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

Quoting Marc Dietrich (2018-01-24 08:05:52) > Second hunk of fixes found by manual comparison with autotools generated > compiler flags. > > Signed-off-by: Marc Dietrich > --- > - Why do we need two version macros? > - And why do we either define DEBUG or NDEBUG? > - Also

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

On 24.01.2018 18:02, Juan A. Suarez Romero wrote: On Mon, 2018-01-22 at 08:41 +0200, Tapani Pälli wrote: On 01/19/2018 12:44 PM, Juan A. Suarez Romero wrote: Anyone could take a look at this patch? Can you pinpoint where the mentioned tests are located, which suite? Yes. It's in the

[Mesa-dev] [PATCH] swr/rast: Optimize DumpToFile output size

Modify DumpToFile to only dump the function, not the entire module. Reduces file sizes and speeds up the dumping. --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v3 06/12] util: add phys_memory.h for all memory measurements

Move the os_get_total_physical_memory function from gallium to util, simplify it (all BSDs support sysconf, no need for sysctl), use it in gallium, anv, dri/i915, dri/i965 and dri/swrast. --- src/gallium/auxiliary/os/os_misc.c | 60 --- src/gallium/auxiliary/os/os_misc.h

Re: [Mesa-dev] [PATCH v2 3/5] util: add anon_file.h for all memfd/temp file usage

On 01/19/2018 20:38, Emil Velikov wrote: On 18 January 2018 at 22:54, Greg V wrote: Move the Weston os_create_anonymous_file code from egl/wayland into util, add support for Linux memfd and FreeBSD SHM_ANON, use that code in anv instead of explicit memfd calls for

[Mesa-dev] [PATCH v3 02/12] meson: fix BSD build

Reviewed-by: Dylan Baker Reviewed-by: Eric Engestrom --- meson.build | 54 -- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v3 03/12] meson: glsl: add missing nir header dependency

--- src/compiler/glsl/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build index b0c0de810a..36edcdc535 100644 --- a/src/compiler/glsl/meson.build +++ b/src/compiler/glsl/meson.build @@ -202,7 +202,7 @@

[Mesa-dev] [PATCH v3 01/12] meson: fix missing dependencies

Reviewed-by: Emil Velikov --- src/gallium/drivers/radeonsi/meson.build | 2 +- src/mesa/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/meson.build

Re: [Mesa-dev] [PATCH v2 3/5] util: add anon_file.h for all memfd/temp file usage

On 01/24/2018 15:16, Emil Velikov wrote: On 24 January 2018 at 11:58, Greg V wrote: +#ifndef __FreeBSD__ mkstemp does exist on FreeBSD, right? If so you can drop this guard and simplify the one in os_create_anonymous_file(). The guard is there because this

[Mesa-dev] [PATCH v3 09/12] anv: remove unused Linux-specific include

--- src/intel/vulkan/anv_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c index c6b2e01c62..29583982ef 100644 --- a/src/intel/vulkan/anv_queue.c +++ b/src/intel/vulkan/anv_queue.c @@ -27,7 +27,6 @@ #include #include

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Emil Velikov (2018-01-24 03:53:35) > On 24 January 2018 at 10:39, Marc Dietrich wrote: > > Hi Dylan, > > > > Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: > >> Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") > >> Reported-by: Marc

[Mesa-dev] [PATCH v3 00/12] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

meson: updated with suggestions from review. anon_file: added a debug_name argument for anv, removed posix_fallocate and retry loops that were copy-pasted from weston, etc. SWR: since there's an environment variable KNOB_MAX_WORKER_THREADS that lets it work without topology, it's fine to build

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

On 24/01/2018 18:19, Dylan Baker wrote: Quoting Emil Velikov (2018-01-24 03:53:35) On 24 January 2018 at 10:39, Marc Dietrich wrote: Hi Dylan, Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Emil Velikov (2018-01-24 11:00:04) > On 24 January 2018 at 18:19, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-24 03:53:35) > >> On 24 January 2018 at 10:39, Marc Dietrich wrote: > >> > Hi Dylan, > >> > > >> > Am Dienstag, 23. Januar 2018,

Re: [Mesa-dev] [PATCH 3/4] i965: Replace draw_aux_buffer_disabled with draw_aux_usage

On Wednesday, January 24, 2018 2:03:41 AM PST Jason Ekstrand wrote: > Instead of keeping an array of booleans, we now hang onto an array of > isl_aux_usage enums. This means that the thing we are passing from > brw_draw.c to surface state setup is the thing that surface state setup > actually

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Wed, Jan 24, 2018 at 4:04 AM, Tomasz Figa wrote: > Hi Robert, > > On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss > wrote: >> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >> since at least 4 implementations exist, and share a

[Mesa-dev] [PATCH] configure.ac: add missing llvm dependencies to .pc files

CC: Signed-of-by: Chuck Atkins --- configure.ac | 12 1 file changed, 12 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..e1be7b78e4 100644 --- a/configure.ac +++ b/configure.ac @@ -2780,6

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

Quoting Eric Engestrom (2018-01-24 09:41:17) > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > Second hunk of fixes found by manual comparison with autotools generated > > compiler flags. > > > > Signed-off-by: Marc Dietrich > > --- > > - Why do we need two

[Mesa-dev] [PATCH v2] meson: Fix define for USE_SSE41

Before we were adding -DHAVE_SSE41 which isn't what the code is looking for, so some uses of the sse4.1 code were always being skipped. v2: Don't add any compile check for the quite old -msse4.1 option (Dylan) Fixes: 84486f6462 ("meson: Enable SSE4.1 optimizations") Reviewed-by: Dylan Baker

[Mesa-dev] [PATCH v3 05/12] meson: handle LLVM 'x.x.xgit-revision' versions

When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version becomes something like 5.0.0git-f8ab206b2176. New meson versions already handle this, but we support older versions too. Reviewed-by: Dylan Baker

[Mesa-dev] [PATCH v3 07/12] util: add anon_file.h for all memfd/temp file usage

Move the Weston os_create_anonymous_file code from egl/wayland into util, add support for Linux memfd and FreeBSD SHM_ANON, use that code in anv instead of explicit memfd calls for portability. --- configure.ac| 2 +- meson.build | 4 +-

[Mesa-dev] [PATCH v3 11/12] swr: support FreeBSD/DragonFlyBSD

--- src/gallium/drivers/swr/rasterizer/common/os.h | 3 ++- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 4 ++-- src/gallium/drivers/swr/swr_fence.cpp | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h

[Mesa-dev] [PATCH v3 10/12] anv: add MAP_POPULATE fallback define for portability

FreeBSD does not have MAP_POPULATE --- src/intel/vulkan/anv_allocator.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index 7e7e88ad77..6a8d73a437 100644 --- a/src/intel/vulkan/anv_allocator.c +++

[Mesa-dev] [PATCH v3 12/12] clover: fix build with LLVM 5

The error was: no matching constructor for initialization of 'std::vector' --- src/gallium/state_trackers/clover/llvm/metadata.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/metadata.hpp

[Mesa-dev] [PATCH v3 08/12] util: emulate futex on FreeBSD using umtx

Obtained from: FreeBSD ports Acked-by: Emil Velikov --- src/util/futex.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/util/futex.h b/src/util/futex.h index 4402893069..425e34a2cd 100644 --- a/src/util/futex.h +++ b/src/util/futex.h @@ -51,6 +51,28 @@ static

[Mesa-dev] [PATCH v3 04/12] meson: fix getting cflags from pkg-config

get_pkgconfig_variable('cflags') always returns an empty list, it's a function for getting *custom* variables. Meson does not yet support asking for cflags, so explicitly invoke pkg-config for now. --- meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

Quoting Jon Turney (2018-01-24 12:26:47) > On 24/01/2018 19:35, Dylan Baker wrote: > > v2: - Also fix drirc install path > > > > Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") > > Reported-by: Marc Dietrich > > Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH 1/2] meson: fix SSE4.1 usage in meson build

The correct define is USE_SSE4.1 as in autotools. Fixes: 84486f64626a ("meson: Enable SSE4.1 optimizations") Cc: Dylan Baker Reviewed-by: Eric Engestrom Signed-off-by: Marc Dietrich --- meson.build | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

On Wed, Jan 24, 2018 at 6:15 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:31PM -0800, Jason Ekstrand wrote: > > This pass performs an "ambiguate" operation on a CCS-compressed surface > > by manually writing zeros into the CCS. On gen8+, ISL gives us

[Mesa-dev] [PATCH v2 4/6] i965: Replace draw_aux_buffer_disabled with draw_aux_usage

Instead of keeping an array of booleans, we now hang onto an array of isl_aux_usage enums. This means that the thing we are passing from brw_draw.c to surface state setup is the thing that surface state setup actually needs instead of an input to compute what it needs. Cc:

[Mesa-dev] [PATCH v2 3/6] i965/surface_state: Drop brw_aux_surface_disabled

The only purpose of this function is to disable aux on texture surfaces when the corresponding renderbuffer has aux disabled. However, the act of disabling aux on the renderbuffer will cause it to be resolved and intel_miptree_texture_aux_usage will already check the resolved status of a texture

[Mesa-dev] [PATCH v2 1/6] i965/miptree: Take an aux_usage in prepare/finish_render

Both callers of intel_miptree_prepare/finish_render have to call intel_miptree_render_aux_usage anyway for other reasons. They may as well pass the result in instead of us calling it again. Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Iago Toral Quiroga Reviewed-by:

[Mesa-dev] [PATCH v2 6/6] i965: Stop disabling aux during texture preparation

Previously, we were handling self-dependencies by marking the render buffer and then passing disable_aux=true to prepare_texture so that it would do a resolve. This works but ends us up doing to much resolving in some cases. Specifically, if we're doing something such as mipmap generation, this

[Mesa-dev] [PATCH v2 5/6] i965/draw: Set NEW_AUX_STATE when draw aux changes

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104411 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104383 Fixes: ea0d2e98ecb369ab84e78c84709c0930ea8c293a Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Topi Pohjolainen Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH v2 0/6] i965: Fix all the CCS self-dependency issues!

This is a v2 of the series I sent out last night. The primary change in this series is the addition of patches 3 and 6. Ken was rightly concerned about the affect that 4 would have on compute. However, it turns out that the function in question was just pointless and can just be removed. The

[Mesa-dev] [PATCH v2 2/6] i965/miptree: Add an aux_disabled parameter to render_aux_usage

Only one of the callers of intel_miptree_render_aux_usage actually took brw->draw_aux_buffer_disabled into account. This was causing us to ignore draw_aux_buffer_disabled for the intel_miptree_prepare_render. This isn't a problem because the draw_aux_buffer_disabled entry was set during texture

[Mesa-dev] [PATCH 2/2] meson: fix HAVE_LLVM version define in meson build

LLVM patch level is not included in HAVE_LLVM. Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware") Cc: Dylan Baker Reviewed-by: Eric Engestrom Signed-off-by: Marc Dietrich --- meson.build | 2 +- 1

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

Hi, Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom: > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > Second hunk of fixes found by manual comparison with autotools generated > > compiler flags. > > > > Signed-off-by: Marc Dietrich > > --- >

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Jon Turney (2018-01-24 10:29:03) > On 24/01/2018 18:19, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-24 03:53:35) > >> On 24 January 2018 at 10:39, Marc Dietrich wrote: > >>> Hi Dylan, > >>> > >>> Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: >

Re: [Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Matt and I talked about whether we needed the compile check, he didn't think we did because we required a GCC that has msse4.1 support, but the HAVE vs USE is a real bug (someone else noticed that too). CC'ing Matt in case I'm miss-remembering something. Quoting Scott D Phillips (2018-01-24

Re: [Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Quoting Scott D Phillips (2018-01-24 11:13:14) > Dylan Baker writes: > > > Matt and I talked about whether we needed the compile check, he didn't > > think we > > did because we required a GCC that has msse4.1 support, but the HAVE vs USE > > is > > a real bug (someone

Re: [Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

On 24/01/2018 19:35, Dylan Baker wrote: v2: - Also fix drirc install path Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") Reported-by: Marc Dietrich Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

Quoting Marc Dietrich (2018-01-24 13:02:42) > Hi, > > Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom: > > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > > Second hunk of fixes found by manual comparison with autotools generated > > > compiler flags. > > > >

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Wed, Jan 24, 2018 at 02:32:02PM -0800, Jason Ekstrand wrote: > On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote: > > > On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > > > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > > >

[Mesa-dev] [PATCH 09/11] mesa/vbo: replace vbo_draw_method() with _mesa_set_drawing_arrays()

The arrays specified by ctx->Array._DrawArrays are used for all vertex drawing via vbo_context::draw_prims(). Different arrays are used for immediate mode, vertex arrays, display lists, etc. Changing from one to another requires updating derived/driver array state. Before, we indirectly

[Mesa-dev] [PATCH 04/11] vbo: s/_API_NOOP_H/VBO_NOOP_H/ in vbo_noop.h

--- src/mesa/vbo/vbo_noop.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_noop.h b/src/mesa/vbo/vbo_noop.h index f61cd51..8aa17ce 100644 --- a/src/mesa/vbo/vbo_noop.h +++ b/src/mesa/vbo/vbo_noop.h @@ -23,8 +23,8 @@ * OTHER DEALINGS IN THE SOFTWARE.

[Mesa-dev] [PATCH 10/11] vbo: optimize loops in bind_vertex_list(), vbo_exec_bind_arrays()

Instead of looping over 32 attributes, just scan the enabled attrib bits. This involves manipulating the 'enabled' attributes variable depending on whether we're using legacy GL or a vertex shader. We can remove the varying_inputs variable since it's the same as the new 'enabled' bitfield. ---

[Mesa-dev] [PATCH 11/11] vbo: overhaul display list vertex array setup/binding code

Do more of the vertex array setup at display list compilation time via the compile_vertex_list() function. Then, at draw time, just do final vertex array setup dependent on whether we're using fixed function or a vertex shader. This can help apps which use a lot of short display list drawing.

[Mesa-dev] [PATCH] radv: don't enable tc compat for d32s8 + 4/8 samples (v1.1)

From: Dave Airlie This seems to be broken, at least the cts tests fail. This fixes: dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_4 dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_8 2 samples seems to pass fine, amdvlk

[Mesa-dev] [Bug 104777] Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error

https://bugs.freedesktop.org/show_bug.cgi?id=104777 --- Comment #1 from Matteo Bruni --- Looking for the testcase mentioned in the regression commit I stumbled upon bug 104668. It sounds like it's the same issue. -- You are receiving this mail because: You are the QA

[Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

This patch series provides fixes for the texture_from_pixmap path when modifiers are used. All but the first and last patches are reviewed. I haven't pushed to land anything yet because ee57b15ec764736e disabled CCS for miptrees with sRGB formats and that caused TFP to always get a resolve which

[Mesa-dev] [PATCH 3/6] i965/tex_image: Pull the tex format from the renderbuffer in intelSetTexBuffer2

Reviewed-by: Kenneth Graunke Reviewed-by: Chad Versace Cc: "17.3" --- src/mesa/drivers/dri/i965/intel_tex_image.c | 34 - 1 file changed, 19 insertions(+), 15 deletions(-) diff

[Mesa-dev] [PATCH 6/6] intel/isl: Improve the documentation on get_default_aux_state

Cc: Chad Versace --- src/intel/isl/isl.h | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index e3acb0e..cf53b5a 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -1565,10

[Mesa-dev] [PATCH 2/6] i965/miptree: Loosen the format check in miptree_match_image

This function is used to determine when we need to re-allocate a miptree. Since we do nothing different in miptree allocation for sRGB vs. linear, loosening this should be safe and may lead to less copying and reallocating in some odd cases. Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH 4/6] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

The old code made a new miptree that referenced the same BO as the renderbuffer and just trusted in the memory aliasing to work. There are only two ways in which the new miptree is liable to differ from the one in the renderbuffer and neither of them matter: 1) It may have a different target.

[Mesa-dev] [PATCH 1/6] i965/state: Ignore intel_obj->_Format for depth/stencil and ETC2

We're about to start letting the intel_obj->_Format be the "real" texture format. For depth/stencil textures, this may be a combined depth stencil format. For ETC2 on gen7 and earlier, this will be the actual ETC2 format. This makes a bit more GL sense but means we have to be careful in state

[Mesa-dev] [PATCH 5/6] i965: Use finish_external instead of make_shareable in setTexBuffer2

The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT which has tighter restrictions than just "it's shared". In particular, it says that any rendering to the image while it is bound causes the contents to become undefined. The GLX_EXT_texture_from_pixmap extension provides us

Re: [Mesa-dev] [PATCH v2 13/24] anv: Only fast clear single-slice images

On Wed, Jan 24, 2018 at 4:04 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote: > > The current strategy we use for managing resolves has an issues where we > > track clear colors and the need for resolves per-LOD but we still allow >

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #9 from Dylan Baker --- Can you try building with git tip again? A patch just landed that fixes the way the meson build calculates the LLVM version string for the pre-processor. I'm not sure if that will fix

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > wrote: > > > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery > > wrote: > > > >> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason

Re: [Mesa-dev] [PATCH v3 12/12] clover: fix build with LLVM 5

Greg V writes: > The error was: no matching constructor for initialization of > 'std::vector' > --- > src/gallium/state_trackers/clover/llvm/metadata.hpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 3/4] ac/nir: set amdgpu.uniform and invariant.load for UBOs

UBOs are constants buffers. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1a52367602..07089349e2

[Mesa-dev] [PATCH 2/4] ac/nir: set amdgpu.uniform and invariant.load for push constants

Push constants are constant buffers. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH 1/4] ac/nir: set the noalias attribute on input pointers

This attribute is similar to the definition of restrict in C99 and it might help LLVM. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 4/4] ac/nir: set amdgpu.uniform and invariant.load for SSBOs

For descriptors. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 07089349e2..3d64dcf26d 100644 ---

[Mesa-dev] [Bug 104777] Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error

https://bugs.freedesktop.org/show_bug.cgi?id=104777 Bug ID: 104777 Summary: Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error Product: Mesa Version: git Hardware: All

Re: [Mesa-dev] [PATCH v3 01/12] meson: fix missing dependencies

Reviewed-by: Dylan Baker Quoting Greg V (2018-01-24 10:02:39) > Reviewed-by: Emil Velikov > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH v2 13/24] anv: Only fast clear single-slice images

On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote: > The current strategy we use for managing resolves has an issues where we > track clear colors and the need for resolves per-LOD but we still allow > resolves of only a subset of the slices in any given LOD and doing so > sets the

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr/rast: support llvm 3.9 type declarations

On Jan 24, 2018, at 11:43 AM, Emil Velikov > wrote: On 24 January 2018 at 15:30, George Kyriazis > wrote: LLVM 3.9 was not taken into in initial check-in. In addition to

[Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Before we were adding -DHAVE_SSE41 which isn't what the code is looking for, so some uses of the sse4.1 code were always being skipped. Fixes: 84486f6462 ("meson: Enable SSE4.1 optimizations") --- meson.build | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

On 24 January 2018 at 18:19, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-24 03:53:35) >> On 24 January 2018 at 10:39, Marc Dietrich wrote: >> > Hi Dylan, >> > >> > Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: >> >> Fixes:

Re: [Mesa-dev] [PATCH 0/4] i965: Fix all the CCS self-dependency issues!

On Wednesday, January 24, 2018 2:03:38 AM PST Jason Ekstrand wrote: > Yeah, right... > > However, this little series does fix at least three of them and probably a > lot more. The thing which we recently discovered is that you really need > to flush the render cache between switching aux_usage

Re: [Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Dylan Baker writes: > Matt and I talked about whether we needed the compile check, he didn't think > we > did because we required a GCC that has msse4.1 support, but the HAVE vs USE is > a real bug (someone else noticed that too). > > CC'ing Matt in case I'm

Re: [Mesa-dev] [PATCH 3/4] i965: Replace draw_aux_buffer_disabled with draw_aux_usage

On Wed, Jan 24, 2018 at 11:13 AM, Kenneth Graunke wrote: > On Wednesday, January 24, 2018 2:03:41 AM PST Jason Ekstrand wrote: > > Instead of keeping an array of booleans, we now hang onto an array of > > isl_aux_usage enums. This means that the thing we are passing from

Re: [Mesa-dev] [PATCH] mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

On Wednesday, January 24, 2018 8:38:43 AM PST Juan A. Suarez Romero wrote: > This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5. > --- > src/mesa/main/fbobject.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index

[Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

v2: - Also fix drirc install path Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") Reported-by: Marc Dietrich Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom (v1) --- src/util/meson.build | 9

[Mesa-dev] [PATCH v2] swr/rast: support llvm 3.9 type declarations

LLVM 3.9 was not taken into account in initial check-in. Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.") cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104749 Acked-by: Emil Velikov ---

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote: > On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote: > > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand > > wrote: > > > > > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery

[Mesa-dev] [PATCH] st/mesa: add some debug code in st_choose_format()

To aid in debugging gallium surface format selection issues. --- src/mesa/state_tracker/st_format.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 3f7e55e..cc72ba4 100644

Re: [Mesa-dev] [PATCH 2/2] meson: fix HAVE_LLVM version define in meson build

Someone else merged a similar patch to the first one already, but I've pushed this patch to master. Thanks! Quoting Marc Dietrich (2018-01-24 13:03:51) > LLVM patch level is not included in HAVE_LLVM. > > Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware") > Cc: Dylan

Re: [Mesa-dev] [PATCH 0/2] Small fixes for the meson build

ping Quoting Dylan Baker (2018-01-12 11:57:34) > Here's a few things I've caught as I've started trying to add the meson > build to our CI system. > > Dylan Baker (2): > meson: set proper pkg-config version for libdrm_freedreno > meson: set the minimum version correctly > >

Re: [Mesa-dev] [PATCH v3 03/12] meson: glsl: add missing nir header dependency

I think this patch is no longer necessary, since libglsl has idep_nir, which includes a dependency on nir_opcodes_h. Although I did notice it still has inc_nir, which it doesn't need... Quoting Greg V (2018-01-24 10:02:41) > --- > src/compiler/glsl/meson.build | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH v3 04/12] meson: fix getting cflags from pkg-config

Reviewed-by: Dylan Baker Quoting Greg V (2018-01-24 10:02:42) > get_pkgconfig_variable('cflags') always returns an empty list, it's a > function for getting *custom* variables. > > Meson does not yet support asking for cflags, so explicitly invoke > pkg-config for now. >

[Mesa-dev] [PATCH 08/11] vbo: s/[0]/[VERT_ATTRIB_POS]/ in recalculate_input_bindings()

--- src/mesa/vbo/vbo_exec_array.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index b11da09..43362db 100644 --- a/src/mesa/vbo/vbo_exec_array.c +++ b/src/mesa/vbo/vbo_exec_array.c @@ -369,11 +369,11 @@

[Mesa-dev] [PATCH 03/11] vbo: whitespace/formatting fixes in vbo_exec.h

--- src/mesa/vbo/vbo_exec.h | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h index f02f459..5f28e70 100644 --- a/src/mesa/vbo/vbo_exec.h +++ b/src/mesa/vbo/vbo_exec.h @@ -136,28 +136,31 @@

[Mesa-dev] [PATCH] mesa: simplify _mesa_delete_list() a bit, add some assertions

All but two cases of the switch did the same n += InstSize[n[0].opcode] instruction. Just move it after the switch. Add some sanity check assertions. --- src/mesa/main/dlist.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git

[Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

The newest version of WSI Fusion makes several glDrawPixels calls per frame. By caching more than one image, we get better performance when panning/zomming the map. --- src/mesa/state_tracker/st_cb_drawpixels.c | 192 +- src/mesa/state_tracker/st_context.c | 4

[Mesa-dev] [PATCH 01/11] vbo: s/cl/array/ in vbo_context.c

I think 'cl' used to mean client array. --- src/mesa/vbo/vbo_context.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c index dbeb687..f516c67 100644 --- a/src/mesa/vbo/vbo_context.c +++

[Mesa-dev] [PATCH 06/11] vbo: s/VBO_ATTRIB_INDEX/VBO_ATTRIB_COLOR_INDEX/

To match the VERT_ATTRIB_COLOR_INDEX name. Give a name to the previously anonymous enum of VBO_ATTRIB_x values. Update the comment on the enum. --- src/mesa/vbo/vbo_attrib.h | 21 +++-- src/mesa/vbo/vbo_attrib_tmp.h | 4 ++-- 2 files changed, 13 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH 05/11] vbo: minor clean-ups in vbo_exec.h

--- src/mesa/vbo/vbo_exec.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h index 5f28e70..dc18889 100644 --- a/src/mesa/vbo/vbo_exec.h +++ b/src/mesa/vbo/vbo_exec.h @@ -31,14 +31,15 @@ USE OR OTHER DEALINGS IN THE

[Mesa-dev] [PATCH 02/11] vbo: move, rename vp_mode enums, get_program_mode() function

Instead of NONE/ARB use FF/SHADER. Move the enum declaration to vbo_private.h where it's used. --- src/mesa/vbo/vbo_exec.h | 7 --- src/mesa/vbo/vbo_exec_array.c | 6 +++--- src/mesa/vbo/vbo_exec_draw.c | 7 --- src/mesa/vbo/vbo_private.h| 22 --

[Mesa-dev] [PATCH 07/11] vbo: add new VBO_ATTRIBS_ masks to vbo_attrib.h

These will be used in a later patch. --- src/mesa/vbo/vbo_attrib.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/vbo/vbo_attrib.h b/src/mesa/vbo/vbo_attrib.h index ba36ab7..fb178e1 100644 --- a/src/mesa/vbo/vbo_attrib.h +++ b/src/mesa/vbo/vbo_attrib.h @@ -32,6

[Mesa-dev] [Bug 104777] Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error

https://bugs.freedesktop.org/show_bug.cgi?id=104777 Matteo Bruni changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v3 00/12] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

I've gone ahead and added my rb to the remaining meson patches, added the relevant Fixes tags, and pushed them to master (except the one that I don't think is necessary now). Thanks for working on this. Dylan Quoting Greg V (2018-01-24 10:02:38) > meson: updated with suggestions from review. >

Re: [Mesa-dev] [PATCH v2 15/24] anv/cmd_buffer: Pull the undefined layout condition into the if

On Fri, Jan 19, 2018 at 03:47:32PM -0800, Jason Ekstrand wrote: > Now that this isn't a multi-case if and it's just the one case, it's a > bit clearer if the condition is just part of the if instead of being > pulled out into a boolean variable. > --- > src/intel/vulkan/genX_cmd_buffer.c | 13

Re: [Mesa-dev] [PATCH v2 3/6] i965/surface_state: Drop brw_aux_surface_disabled

On Wednesday, January 24, 2018 12:37:21 PM PST Jason Ekstrand wrote: > The only purpose of this function is to disable aux on texture surfaces > when the corresponding renderbuffer has aux disabled. However, the act > of disabling aux on the renderbuffer will cause it to be resolved and >

Re: [Mesa-dev] [PATCH] st/mesa: add some debug code in st_choose_format()

Reviewed-by: Roland Scheidegger Am 25.01.2018 um 00:19 schrieb Brian Paul: > To aid in debugging gallium surface format selection issues. > --- > src/mesa/state_tracker/st_format.c | 23 ++- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff

Re: [Mesa-dev] [PATCH v2 18/24] anv/image: Simplify some verbose commennts

On Fri, Jan 19, 2018 at 03:47:35PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH 2/3] anv/gen10: Ignore push constant packets during context restore.

On Wed, Jan 24, 2018 at 4:33 PM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > Similar to the GL driver, ignore 3DSTATE_CONSTANT_* packets when doing a > context restore. > > Signed-off-by: Rafael Antognolli > Cc: Jason Ekstrand >

  1   2   3   >