[Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-30 Thread Lucas Stach
Take into account the resource format, instead of applying a hardcoded 32bpp. This not only over-allocates 16bpp formats, but also results in a wrong stride being filled into the handle. Signed-off-by: Lucas Stach --- src/gallium/auxiliary/renderonly/renderonly.c | 3 ++-

Re: [Mesa-dev] [PATCH] r600/sb: insert the else clause when we might depart from a loop

2018-01-30 Thread Roland Scheidegger
Makes sense to me, albeit I don't really quite understand sb... Reviewed-by: Roland Scheidegger Am 30.01.2018 um 07:40 schrieb Dave Airlie: > From: Dave Airlie > > If there is a break inside the else clause and this means we > are breaking from a loop,

Re: [Mesa-dev] [PATCH 8/8] mesa: use gl_vert_attrib enum type in more places

2018-01-30 Thread Brian Paul
On 01/30/2018 01:38 AM, Gert Wollny wrote: Am Montag, den 29.01.2018, 13:42 -0700 schrieb Brian Paul: Slightly better readbility. --- src/mesa/main/arrayobj.c | 2 +- src/mesa/main/varray.c | 12 ++-- src/mesa/main/varray.h | 4 ++-- 3 files changed, 9 insertions(+), 9

Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-30 Thread Philipp Zabel
On Tue, 2018-01-30 at 15:22 +0100, Lucas Stach wrote: > Take into account the resource format, instead of applying a hardcoded > 32bpp. This not only over-allocates 16bpp formats, but also results in > a wrong stride being filled into the handle. > > Signed-off-by: Lucas Stach

[Mesa-dev] [Bug 104777] Attaching multiple shader objects for the same stage to a GLSL program triggers a linker error

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104777 --- Comment #2 from Juan A. Suarez --- I've sent a patch for review that I think should fix this issue. https://patchwork.freedesktop.org/series/37349/ -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH 3/3] radeonsi: remove DBG_PRECOMPILE

2018-01-30 Thread Marek Olšák
ping On Sat, Jan 27, 2018 at 7:01 PM, Marek Olšák wrote: > From: Marek Olšák > > it's useless and shader-db stats only report the main shader part. > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 1 - > src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 1/4] mesa: don't flag _NEW_COLOR for KHR adv.blend if prog constant doesn't change

2018-01-30 Thread Marek Olšák
From: Marek Olšák This only affects drivers that set DriverFlags.NewBlend. --- src/mesa/main/blend.c | 6 -- src/mesa/main/blend.h | 41 +++ src/mesa/main/enable.c| 14 +

[Mesa-dev] [PATCH 2/4] radeonsi: make texture_discard_cmask/eliminate functions non-static

2018-01-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeon/r600_texture.c | 20 +--- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h

[Mesa-dev] [PATCH 3/4] radeonsi: don't flush when si_eliminate_fast_color_clear is no-op

2018-01-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index a0e9129..125e7ef 100644 ---

[Mesa-dev] [PATCH 4/4] radeonsi: implement GL_KHR_blend_equation_advanced without MSAA

2018-01-30 Thread Marek Olšák
From: Marek Olšák I'm not fully convinced that the hw can do it with MSAA. Maybe without CMASK, FMASK, and with sample shading, i.e. the slowest possible way. --- docs/features.txt | 2 +- docs/relnotes/18.1.0.html |

Re: [Mesa-dev] [PATCH 7/8] mesa: rename some 'client' array functions

2018-01-30 Thread Mark Janes
This series that was just pushed to master generates ~200 assertions on all platforms, eg: piglit.spec.ext_framebuffer_multisample.formats 2 ext_framebuffer_multisample-formats: ../src/mesa/main/varray.c:1068: _mesa_enable_vertex_array_attrib: Assertion `attrib >= VERT_ATTRIB_GENERIC0' failed.

[Mesa-dev] [Bug 104863] 186 assertions in piglit

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104863 Bug ID: 104863 Summary: 186 assertions in piglit Product: Mesa Version: git Hardware: Other OS: All Status: NEW Keywords: regression Severity:

[Mesa-dev] [Bug 104863] 186 assertions in piglit

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104863 --- Comment #2 from Brian Paul --- Patch posted to mesa-dev. Please review and I'll push it. -- You are receiving this mail because: You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-30 Thread Dylan Baker
Quoting Eric Engestrom (2018-01-30 09:55:53) > > > On January 30, 2018 5:34:07 PM UTC, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-01-29 10:15:50) > > > The big comment is taken from the equivalent block in configure.ac > > > > > > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH libdrm] meson: fix libdrm_nouveau pkgconfig include directories

2018-01-30 Thread Dylan Baker
ping Quoting Dylan Baker (2018-01-25 16:14:45) > Signed-off-by: Dylan Baker > --- > > I have tested building every mesa driver against this (with and without udev!) > so I'm pretty sure that this is the last pkgbuild problem. > > I'm sure I'll be sad in a day or two...

Re: [Mesa-dev] [PATCH 7/8] mesa: rename some 'client' array functions

2018-01-30 Thread Brian Paul
On 01/30/2018 09:59 AM, Mark Janes wrote: This series that was just pushed to master generates ~200 assertions on all platforms, eg: piglit.spec.ext_framebuffer_multisample.formats 2 ext_framebuffer_multisample-formats: ../src/mesa/main/varray.c:1068: _mesa_enable_vertex_array_attrib:

Re: [Mesa-dev] [PATCH 7/8] mesa: Reduce ffvertex_prog state_key to 36 bytes.

2018-01-30 Thread Mathias Fröhlich
Hi Brian, On Monday, 29 January 2018 17:05:57 CET Brian Paul wrote: > The series looks good tome. > > Reviewed-by: Brian Paul Thanks for the review! > Can you push this or do you need me to do it? And Thanks for pushing. I used to have a git account and I assume it is still

Re: [Mesa-dev] [PATCH] mesa: remove invalid assertion in _mesa_enable_vertex_array_attrib()

2018-01-30 Thread Brian Paul
On 01/30/2018 10:35 AM, Roland Scheidegger wrote: Should the meta module not do this? The meta module is OK. It's using this function to enable vertex position, for example. In any case, Reviewed-by: Roland Scheidegger Thanks! -Brian Am 30.01.2018 um 18:14

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-30 Thread Eric Engestrom
On January 30, 2018 5:34:07 PM UTC, Dylan Baker wrote: > Quoting Eric Engestrom (2018-01-29 10:15:50) > > The big comment is taken from the equivalent block in configure.ac > > > > Signed-off-by: Eric Engestrom > > --- > > meson.build

Re: [Mesa-dev] [PATCH 8/8] mesa: use gl_vert_attrib enum type in more places

2018-01-30 Thread Gert Wollny
Am Dienstag, den 30.01.2018, 08:26 -0700 schrieb Brian Paul: > On 01/30/2018 01:38 AM, Gert Wollny wrote: > > Am Montag, den 29.01.2018, 13:42 -0700 schrieb Brian Paul: > > > Slightly better readbility. > > > --- > > > src/mesa/main/arrayobj.c | 2 +- > > > src/mesa/main/varray.c | 12

[Mesa-dev] [Bug 104863] 186 assertions in piglit

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104863 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 3/3] radeonsi: remove DBG_PRECOMPILE

2018-01-30 Thread Nicolai Hähnle
Series is: Reviewed-by: Nicolai Hähnle On 27.01.2018 19:01, Marek Olšák wrote: From: Marek Olšák it's useless and shader-db stats only report the main shader part. --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 -

Re: [Mesa-dev] [PATCH 10/11] vbo: optimize loops in bind_vertex_list(), vbo_exec_bind_arrays()

2018-01-30 Thread Mathias Fröhlich
Hi Brian, On Monday, 29 January 2018 19:24:15 CET Brian Paul wrote: > On 01/27/2018 08:01 AM, Mathias Fröhlich wrote: > > Hi Brian, > > > > The change should not change the current behavior. > > Nevertheless the current behavior as well as past your change the code has a > > corner case that

Re: [Mesa-dev] [PATCH 04/51] glsl: Print 16-bit constants

2018-01-30 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 08:41:42PM +0200, Pohjolainen, Topi wrote: > On Mon, Nov 27, 2017 at 11:40:49AM -0800, Matt Turner wrote: > > On 11/24, Topi Pohjolainen wrote: > > > --- > > > src/compiler/glsl/ir_print_visitor.cpp | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git

[Mesa-dev] [Bug 104863] 186 assertions in piglit

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104863 --- Comment #1 from Mark Janes --- 4ab7e03e1fc7ac6c7cd3a5a1c160726f2a262e66 is the first bad commit commit 4ab7e03e1fc7ac6c7cd3a5a1c160726f2a262e66 Author: Brian Paul Date: Fri Jan 26 11:03:57 2018

Re: [Mesa-dev] [PATCH] mesa: remove invalid assertion in _mesa_enable_vertex_array_attrib()

2018-01-30 Thread Roland Scheidegger
Should the meta module not do this? In any case, Reviewed-by: Roland Scheidegger Am 30.01.2018 um 18:14 schrieb Brian Paul: > The meta module passes some 0-based attrib values. Should fix Piglit > regressions reported by Mark Janes. > > Bugzilla: >

Re: [Mesa-dev] [PATCH 7/8] mesa: rename some 'client' array functions

2018-01-30 Thread Gert Wollny
Am Dienstag, den 30.01.2018, 10:14 -0700 schrieb Brian Paul: > On 01/30/2018 09:59 AM, Mark Janes wrote: > > This series that was just pushed to master generates ~200 > > assertions on > > all platforms, eg: > > > > piglit.spec.ext_framebuffer_multisample.formats 2 > > > >

[Mesa-dev] [PATCH] mesa: remove invalid assertion in _mesa_enable_vertex_array_attrib()

2018-01-30 Thread Brian Paul
The meta module passes some 0-based attrib values. Should fix Piglit regressions reported by Mark Janes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104863 --- src/mesa/main/varray.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c

Re: [Mesa-dev] [PATCH v2] meson: generate translations for driconf

2018-01-30 Thread Dylan Baker
Quoting Marc Dietrich (2018-01-27 06:36:51) > Hi Dylan, > > Am Donnerstag, 25. Januar 2018, 20:32:23 CET schrieb Dylan Baker: > > Currently meson implements the same logic as SCons for translations, > > namely it doesn't do them. This patch changes meson to use logic more > > like autotools, and

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-30 Thread Dylan Baker
Quoting Eric Engestrom (2018-01-29 10:15:50) > The big comment is taken from the equivalent block in configure.ac > > Signed-off-by: Eric Engestrom > --- > meson.build | 30 > + >

Re: [Mesa-dev] [PATCH 3/6] meson: build src/glx/apple

2018-01-30 Thread Dylan Baker
Quoting Jon Turney (2018-01-28 06:24:10) > --- > src/glx/apple/meson.build | 62 > +++ > src/glx/meson.build | 4 +++ > 2 files changed, 66 insertions(+) > create mode 100644 src/glx/apple/meson.build > > diff --git a/src/glx/apple/meson.build

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

2018-01-30 Thread Dylan Baker
Quoting Jon Turney (2018-01-28 06:24:11) > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 7e194a9f10d..8fdbaa8b8d8 100644 > --- a/meson.build > +++ b/meson.build > @@ -935,7 +935,7 @@ elif with_dri_i965 and

Re: [Mesa-dev] [PATCH 0/6] meson: build src/glx/apple

2018-01-30 Thread Dylan Baker
Quoting Jon Turney (2018-01-28 06:24:07) > This also requires my "fix osx" series to actually build > > Dylan Baker (2): > meson: find python2 on macOS > meson: set apple glx defines > > Jon Turney (4): > meson: build src/glx/apple > meson: osx doesn't have librt, so don't require it >

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-30 Thread Emil Velikov
On 29 January 2018 at 18:57, Dylan Baker wrote: > Quoting Eric Engestrom (2018-01-29 10:15:50) >> The big comment is taken from the equivalent block in configure.ac >> >> Signed-off-by: Eric Engestrom >> --- >> meson.build

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

2018-01-30 Thread Emil Velikov
Hi Jon, On 28 January 2018 at 14:24, Jon Turney wrote: > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 7e194a9f10d..8fdbaa8b8d8 100644 > --- a/meson.build > +++ b/meson.build > @@ -935,7

Re: [Mesa-dev] [PATCH] ac/llvm: bump the number of results to 8.

2018-01-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 30, 2018 at 4:59 AM, Dave Airlie wrote: > From: Dave Airlie > > This function can get access for a 64-bit dvec4, which means we > have to load 8 components. > > This fixes: > R600_DEBUG=nir

Re: [Mesa-dev] [PATCH v2 09/12] st/glsl_to_nir: copy nir compiler options to context

2018-01-30 Thread Marek Olšák
On Tue, Jan 30, 2018 at 4:55 AM, Timothy Arceri wrote: > Various nir passes may expect this to be here as does the nir > serialisation pass. > --- > src/mesa/state_tracker/st_extensions.c| 17 + > src/mesa/state_tracker/st_glsl_to_nir.cpp | 10

Re: [Mesa-dev] [PATCH v2 12/12] st/glsl_to_nir: disable io lowering and array splitting of fs inputs

2018-01-30 Thread Marek Olšák
If you fix the possible NULL function call in patch 9, the series is: Reviewed-by: Marek Olšák Marek On Tue, Jan 30, 2018 at 4:55 AM, Timothy Arceri wrote: > We need this to be able to support the interpolateAt builtins in a > sane way. It also

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-30 Thread Robert Foss
On 01/30/2018 04:16 AM, Tomasz Figa wrote: Hi Rob, On Tue, Jan 30, 2018 at 1:17 AM, Robert Foss wrote: Hey Tomasz, I'm tempted to split this work into two parts. 1) Move gbm gralloc struct Alright, if we look at this only as an attempt to converge gbm_ and

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 --- Comment #7 from Eero Tamminen --- If Padoka repos update also X server, there was X server bug 103000 that affected titlebar colors (and was recently fixed). -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Jason Ekstrand
On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > Even though the blorp pass looks a bit on the sketchy side, the end > > result in the Vulkan driver is very nice. Instead of having this weird > >

Re: [Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-01-30 Thread Matteo Bruni
2018-01-30 16:11 GMT+01:00 Juan A. Suarez Romero : > According with OpenGL GLSL 3.20 spec, section 4.3.9: > > "It is a link-time error if any particular shader interface >contains: > - two different blocks, each having no instance name, and each >having a

Re: [Mesa-dev] [PATCH v2 22/24] intel/blorp: Use isl_aux_op instead of blorp_fast_clear_op

2018-01-30 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:39PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 9 +-- > src/intel/blorp/blorp_clear.c | 10 > src/intel/blorp/blorp_genX_exec.h | 16 ++-- > src/intel/blorp/blorp_priv.h

Re: [Mesa-dev] [PATCH v2 23/24] intel/blorp: Use isl_aux_op instead of blorp_hiz_op

2018-01-30 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:40PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.c | 2 +- > src/intel/blorp/blorp.h | 19 + > src/intel/blorp/blorp_clear.c | 2 +- > src/intel/blorp/blorp_genX_exec.h

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Nanley Chery
On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery wrote: > > > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > > Even though the blorp pass looks a bit on the sketchy side, the end > > >

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Jason Ekstrand
On Tue, Jan 30, 2018 at 5:03 PM, Nanley Chery wrote: > On Tue, Jan 30, 2018 at 04:25:59PM -0800, Jason Ekstrand wrote: > > On Tue, Jan 30, 2018 at 2:54 PM, Nanley Chery > wrote: > > > > > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand

[Mesa-dev] [PATCH] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

2018-01-30 Thread Jason Ekstrand
Completely untested. --- src/intel/blorp/blorp_clear.c | 12 +++- src/intel/blorp/blorp_genX_exec.h | 6 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index dd29d9e..32ec31b 100644 ---

[Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-30 Thread Timothy Arceri
All of the current gallium nir driver use these optimisations but they do so in their backends. Having these called in the backend only can cause a number of problems: - Shader compile times are greater because the opts need to do significant passes over all shader variants. - The shader cache

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-30 Thread Timothy Arceri
I forgot to add that adding the opts also required some of the lowering passes to be called slightly earlier. On 31/01/18 12:58, Timothy Arceri wrote: All of the current gallium nir driver use these optimisations but they do so in their backends. Having these called in the backend only can

Re: [Mesa-dev] [PATCH] virgl: also remove dimension on indirect.

2018-01-30 Thread Gurchetan Singh
Any plans to merge this? This fixes Chrome not starting with Virgl. Reviewed-by: Gurchetan Singh Tested-by: Gurchetan Singh On Mon, Nov 13, 2017 at 12:53 PM, Dave Airlie wrote: > From: Dave Airlie

Re: [Mesa-dev] [PATCH] virgl: also remove dimension on indirect.

2018-01-30 Thread Dave Airlie
On 31 January 2018 at 12:04, Gurchetan Singh wrote: > Any plans to merge this? This fixes Chrome not starting with Virgl. Oops pushed now. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

2018-01-30 Thread Roland Scheidegger
FWIW the same commit also broke conform (completely - it will refuse to run even a single test due to failing mustpass). Default State test failed. State Report. (Current) <-> (Default) GL_POLYGON_MODE (State Information) GL_FILL -1 (Bad enumeration) <-> GL_FILL GL_FILL

Re: [Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

2018-01-30 Thread Dieter Nützel
Ping! Am 11.01.2018 04:53, schrieb Dave Airlie: From: Dave Airlie This should make the merging of cmd buffers less CPU intensive, note I said *should* :) --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 47 --- 1 file changed, 20

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

2018-01-30 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > Broken by f96a69f916aed40519e755d0460a83940a587 Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

2018-01-30 Thread Brian Paul
On 01/30/2018 07:25 PM, Roland Scheidegger wrote: FWIW the same commit also broke conform (completely - it will refuse to run even a single test due to failing mustpass). Default State test failed. State Report. (Current) <-> (Default) GL_POLYGON_MODE (State Information)

[Mesa-dev] [PATCH] mesa: fix broken glGet*(GL_POLYGON_MODE) query

2018-01-30 Thread Brian Paul
This reverts part of the patch which introduced the GLenum16 change. Fixes a conform regression found by Roland. Fixes: f96a69f916aed405 ("mesa: replace GLenum with GLenum16 in common structures (v4)") --- src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 4 ++-- 2

Re: [Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

2018-01-30 Thread Dave Airlie
On 31 January 2018 at 12:27, Dieter Nützel wrote: > Ping! I'm not sure this was much of a win, and if it makes things worse in some cases, then it needs a lot more investigation, so probably consider it dead for now. Dave. > > Am 11.01.2018 04:53, schrieb Dave Airlie: >>

[Mesa-dev] [PATCH] docs/features: mark EXT_semaphore(_fd) as DONE

2018-01-30 Thread Andres Rodriguez
Support for these extensions is available in radeonsi. Signed-off-by: Andres Rodriguez --- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 2e110d9994..1672460a2f 100644 ---

Re: [Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

2018-01-30 Thread Dieter Nützel
Am 12.01.2018 01:31, schrieb Dieter Nützel: Tested-by: Dieter Nützel This offer an additional 1-1,5% (~20 fps) boost with 'smoketest'. 6290 presents in 5.00045 seconds (FPS: 1257.89) 6291 presents in 5.00041 seconds (FPS: 1258.1) 6293 presents in 5.00065 seconds (FPS:

Re: [Mesa-dev] [PATCH] mesa: fix broken glGet*(GL_POLYGON_MODE) query

2018-01-30 Thread Roland Scheidegger
I wasn't sure if someone wanted to fix it by using special getter for it, but it might not be worth the trouble... Thanks! Reviewed-by: Roland Scheidegger Am 31.01.2018 um 03:35 schrieb Brian Paul: > This reverts part of the patch which introduced the GLenum16 change. >

Re: [Mesa-dev] [PATCH 1/4] mesa: don't flag _NEW_COLOR for KHR adv.blend if prog constant doesn't change

2018-01-30 Thread Ian Romanick
On 01/30/2018 07:48 AM, Marek Olšák wrote: > From: Marek Olšák > > This only affects drivers that set DriverFlags.NewBlend. > --- > src/mesa/main/blend.c | 6 -- > src/mesa/main/blend.h | 41 > +++ >

[Mesa-dev] [PATCH 1/2] svga: s/unsigned/VGPU10_OPCODE_TYPE/

2018-01-30 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 2f16935..da520be 100644 ---

[Mesa-dev] [PATCH 2/2] svga: use opcode local var to simplify some code

2018-01-30 Thread Brian Paul
--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index da520be..73aa78b 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c +++

[Mesa-dev] [PATCH 1/2] st/mesa: s/int/GLenum/ in st_glsl_to_tgsi.cpp

2018-01-30 Thread Brian Paul
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 84ed614..a1e37cf 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 2/2] st/mesa: whitespace, formatting fixes in st_glsl_to_tgsi.cpp

2018-01-30 Thread Brian Paul
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 273 ++--- 1 file changed, 169 insertions(+), 104 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index a1e37cf..c92b1d9 100644 ---

Re: [Mesa-dev] [PATCH] mesa: fix broken glGet*(GL_POLYGON_MODE) query

2018-01-30 Thread Brian Paul
On 01/30/2018 08:25 PM, Roland Scheidegger wrote: I wasn't sure if someone wanted to fix it by using special getter for it, but it might not be worth the trouble... Thanks! If someone wants to do it that way, that's fine by me. This is just simpler for the time being. -Brian

Re: [Mesa-dev] [PATCH] radv: remove predication on cache flushes

2018-01-30 Thread Dave Airlie
On 30 January 2018 at 02:26, Matthew Nicholls wrote: > This can lead to a situation where cache flushes could get conditionally > disabled while still clearing the flush_bits, and thus flushes due to > application pipeline barriers may never get executed. Thanks

[Mesa-dev] [PATCH] gallium/st/clover: remove unused PIPE_SHADER_IR_LLVM

2018-01-30 Thread Timothy Arceri
This has been unused since 100796c15c3a. --- Please note this is not even compile tested as I don't have clover 7.0.0 repo to go with my current llvm 7.0.0 setup. Any testing is appreciated. src/gallium/docs/source/screen.rst | 4 ++--

Re: [Mesa-dev] [PATCH 2/2] svga: use opcode local var to simplify some code

2018-01-30 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, January 30, 2018 7:36:27 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: use opcode

Re: [Mesa-dev] [PATCH] gallium/st/clover: remove unused PIPE_SHADER_IR_LLVM

2018-01-30 Thread Timothy Arceri
On 31/01/18 15:05, Timothy Arceri wrote: This has been unused since 100796c15c3a. --- Please note this is not even compile tested as I don't have clover > 7.0.0 repo to go with my current llvm 7.0.0 setup. Any testing is appreciated. That was meant to say clang repo.

Re: [Mesa-dev] [PATCH 2/2] st/mesa: whitespace, formatting fixes in st_glsl_to_tgsi.cpp

2018-01-30 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, January 30, 2018 7:36:43 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] st/mesa: whitespace,

[Mesa-dev] [PATCH] glsl/linker: check same name is not used in block and outside

2018-01-30 Thread Juan A. Suarez Romero
According with OpenGL GLSL 3.20 spec, section 4.3.9: "It is a link-time error if any particular shader interface contains: - two different blocks, each having no instance name, and each having a member of the same name, or - a variable outside a block, and a block with no

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

2018-01-30 Thread Andres Rodriguez
On 2018-01-29 02:02 PM, Marek Olšák wrote: On Tue, Jan 23, 2018 at 10:16 PM, Andres Rodriguez wrote: Also, the associated piglit patches: https://lists.freedesktop.org/archives/piglit/2017-December/023600.html You can just push the piglit patches if you get no review

Re: [Mesa-dev] [PATCH] ac: Use old kill intrinsics for LLVM 6.

2018-01-30 Thread Bas Nieuwenhuizen
On Tue, Jan 30, 2018 at 12:32 AM, Samuel Pitoiset wrote: > > > On 01/30/2018 12:03 AM, Bas Nieuwenhuizen wrote: >> >> llvm.amdgcn.kill is currently broken for SGPRs. The old intrinsic >> had that issue too, but did not fold the preceding comparison into >> the machine

Re: [Mesa-dev] [PATCH 11/11] vbo: overhaul display list vertex array setup/binding code

2018-01-30 Thread Mathias Fröhlich
Hi Brian, > Ah right. At one point I thought about dlist sharing, but I forgot to > address that in the end. > > I think one way to address that would be to put a mutex in the > vbo_save_vertex_list so it can only be accessed by one context at a > time. Plus, check if the calling context

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

2018-01-30 Thread Dylan Baker
Quoting Emil Velikov (2018-01-30 10:56:42) > Hi Jon, > > On 28 January 2018 at 14:24, Jon Turney wrote: > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build > > index

Re: [Mesa-dev] [GSOC] DriConf Replacement

2018-01-30 Thread Jean Hertel
Hi Axel,   >Hi all, > >Don't hesitate to recycle parts of my old try at DriConf Replacement: > >https://github.com/axeldavy/driCenter > >It had automatic detection of prime system and of the device_id. >It detected also on which card apps run, and running apps. Thanks for pointing this out.

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-30 Thread Dylan Baker
Quoting Emil Velikov (2018-01-30 10:43:06) > On 29 January 2018 at 18:57, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-01-29 10:15:50) > >> The big comment is taken from the equivalent block in configure.ac > >> > >> Signed-off-by: Eric Engestrom

[Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

2018-01-30 Thread Marek Olšák
From: Marek Olšák Broken by f96a69f916aed40519e755d0460a83940a587 --- src/mesa/main/get_hash_params.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 7cd195c..55d29e9 100644

[Mesa-dev] [PATCH 4/5] ac/nir: use ac_build_buffer_load_format for image buffer loads

2018-01-30 Thread Marek Olšák
From: Marek Olšák Please test RADV. --- src/amd/common/ac_nir_to_llvm.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 0ab16c4..428764b 100644 ---

[Mesa-dev] [PATCH 3/5] ac: add glc parameter to ac_build_buffer_load_format

2018-01-30 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 3 ++- src/amd/common/ac_llvm_build.h| 1 + src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader.c | 2 +-

[Mesa-dev] [PATCH 5/5] radeonsi: use ac_build_buffer_load_format for image buffer loads

2018-01-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c index

[Mesa-dev] [PATCH 1/5] radeonsi: remove unused si_shader_context members

2018-01-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader_internal.h | 4 src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 7 --- 2 files changed, 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_internal.h

[Mesa-dev] [PATCH 4/4] radv: repack some structures post pipeline rework.

2018-01-30 Thread Dave Airlie
From: Dave Airlie Bas's pipeline rework made me relook at the struct packing: radv_cmd_state: 984->968 radv_cmd_buffer: 2910->2896 radv_image: 1008->1000 radv_pipeline: 1640->1632 Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_private.h | 25

[Mesa-dev] [PATCH 3/4] radv: reduce vk_format_descriptions memory usage.

2018-01-30 Thread Dave Airlie
From: Dave Airlie This repacks to reduce the usage from 72->64 bytes, but also makes the descriptions static const so they don't just stay in the same unit. Signed-off-by: Dave Airlie --- src/amd/vulkan/vk_format.h| 3 ++-

[Mesa-dev] [PATCH 2/4] ac/shader: repack ac_shader_info

2018-01-30 Thread Dave Airlie
From: Dave Airlie This reduces the size from 28->24 bytes. Signed-off-by: Dave Airlie --- src/amd/common/ac_shader_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_shader_info.h

[Mesa-dev] [PATCH 1/4] shader_info: repack to avoid holes.

2018-01-30 Thread Dave Airlie
From: Dave Airlie This makes this got from 136->128 bytes. Signed-off-by: Dave Airlie --- src/compiler/shader_info.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/compiler/shader_info.h

Re: [Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

2018-01-30 Thread Nanley Chery
On Fri, Jan 19, 2018 at 05:25:41PM -0800, Jason Ekstrand wrote: > On Fri, Jan 19, 2018 at 3:47 PM, Jason Ekstrand > wrote: > > > This pass performs an "ambiguate" operation on a CCS-compressed surface > > by manually writing zeros into the CCS. On gen8+, ISL gives us a

Re: [Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

2018-01-30 Thread Jason Ekstrand
On Tue, Jan 30, 2018 at 2:24 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 05:25:41PM -0800, Jason Ekstrand wrote: > > On Fri, Jan 19, 2018 at 3:47 PM, Jason Ekstrand > > wrote: > > > > > This pass performs an "ambiguate" operation on a

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-30 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > Even though the blorp pass looks a bit on the sketchy side, the end > result in the Vulkan driver is very nice. Instead of having this weird > case where you do a fast clear and then maybe have to resolve, we just > do the

[Mesa-dev] [PATCH 2/5] radeonsi: load the right number of components for VS inputs and TBOs

2018-01-30 Thread Marek Olšák
From: Marek Olšák The supported counts are 1, 2, 4. (3=4) The following snippet loads float, vec2, vec3, and vec4: Before: buffer_load_format_x v9, v4, s[0:3], 0 idxen ; E0002000 8904 buffer_load_format_xyzw v[0:3], v5, s[8:11], 0 idxen ; E00C2000

Re: [Mesa-dev] [PATCH] mesa: fix glGet MAX_VERTEX_ATTRIB queries

2018-01-30 Thread Brian Paul
Reviewed-by: Brian Paul On 01/30/2018 02:46 PM, Marek Olšák wrote: From: Marek Olšák Broken by f96a69f916aed40519e755d0460a83940a587 --- src/mesa/main/get_hash_params.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] misc pahole repacking

2018-01-30 Thread Dave Airlie
This month's Dave hasn't got enough sleep to do real work, lets repack some structs. The format descriptions one is quite good though it reduces the radv binary data segment. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] r600/cayman: initial attempt at gl_HelperInvocation

2018-01-30 Thread Dave Airlie
From: Dave Airlie This is a cayman only patch, it doesn't appear that evergreen supports the ALU on VPM. I'll try and figure it out later. All I can say for this patch is it passes the piglit test and the CTS tests. This also disable sb for helper invocations until it

[Mesa-dev] [PATCH 3/7] glsl/tests: move utility functions in cache_test

2018-01-30 Thread Tapani Pälli
Patch moves functions higher so that we can utilize them from test_disk_cache_create which is modified by next patch. Signed-off-by: Tapani Pälli --- src/compiler/glsl/tests/cache_test.c | 70 ++-- 1 file changed, 35 insertions(+), 35

[Mesa-dev] [PATCH v3 6/7] disk cache: add callback functionality

2018-01-30 Thread Tapani Pälli
v2: add disk_cache_has_key, disk_cache_put_key support using blob cache (Nicolai, Jordan) v3: rename set_cb as put_cb to match existing naming (Timothy) Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 49 +

[Mesa-dev] [PATCH v2 5/7] disk cache: initialize cache path and index only when used

2018-01-30 Thread Tapani Pälli
This patch makes disk_cache initialize path and index lazily so that we can utilize disk_cache without a path using callback functionality introduced by next patch. v2: unmap mmap and destroy queue only if index_mmap exists Signed-off-by: Tapani Pälli ---

[Mesa-dev] [PATCH 4/7] glsl/tests: changes to test_disk_cache_create test

2018-01-30 Thread Tapani Pälli
Next patch will allow disk_cache instance to be created without path set for it, remove some test cases that assume disk_cache creation to fail with invalid path. To test if different paths work, insert put/get cycle before directory check so that path gets properly created. Signed-off-by:

[Mesa-dev] [PATCH v2 1/7] dri: add interface for EGL_ANDROID_blob_cache extension

2018-01-30 Thread Tapani Pälli
v2: move from __DRIcontext to __DRIscreen (Emil Velikov) Signed-off-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h

  1   2   >