Re: [Mesa-dev] [PATCH 1/2] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-02-09 Thread Iago Toral
On Sat, 2018-01-27 at 18:58 -0800, Caio Marcelo de Oliveira Filho wrote: > --- > > In the last chunk of the diff, should accepting stage of vertex > shader > should be conditioned on shader_viewport_index_layer? I was going to say that we should assert that shader_viewport_index_layer is supporte

Re: [Mesa-dev] [PATCH 1/2] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-02-09 Thread Iago Toral
On Fri, 2018-02-09 at 09:08 +0100, Iago Toral wrote: > On Sat, 2018-01-27 at 18:58 -0800, Caio Marcelo de Oliveira Filho > wrote: > > --- > > > > In the last chunk of the diff, should accepting stage of vertex > > shader > > should be conditioned on shader_viewport_index_layer? > > I was going to

Re: [Mesa-dev] [Mesa-maintainers] Underlinking issues in 18.0.0~rc3

2018-02-09 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Thu, 2018-02-08 at 23:58 +, Emil Velikov wrote: > On 8 February 2018 at 23:02, Igor Gnatenko > wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > I've tried to update mesa to 18.0.0~rc3 in Fedora Rawhide, but that fails >

[Mesa-dev] Underlinking issues in 18.0.0~rc3

2018-02-09 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I've tried to update mesa to 18.0.0~rc3 in Fedora Rawhide, but that fails with a lot of "undefined reference" errors. Any hints for available patch? https://kojipkgs.fedoraproject.org//work/tasks/2888/24852888/build.log - -- - -Igor Gnatenko -B

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 --- Comment #7 from Thomas Hellström --- Thanks. Sent the patch for review. If anyone wants a Tested-by: tag, please respond to the PATCH email on mesa-dev. /Thomas -- You are receiving this mail because: You are the QA Contact for the bug.__

[Mesa-dev] [PATCH] loader_dri3/glx/egl: Reinstate the loader_dri3_vtable get_dri_screen callback

2018-02-09 Thread Thomas Hellstrom
Removing this callback caused rendering corruption in some multi-screen cases, so it is reinstated but without the drawable argument which was never used by implementations and was confusing since the drawable could have been created with another screen. Cc: "17.3" mesa-sta...@lists.freedesktop.or

[Mesa-dev] GBM, KMS/DRM, triple buffering

2018-02-09 Thread Carlos Rafael Giani
I want to implement triple buffering instead of double buffering for a program that uses EGL on GBM on a KMS-enabled platform. So far, I used kmscube as an example. However, I do not see where I can specify that I want to have 3 buffers allocated instead of 2. From what I saw, I could try to c

[Mesa-dev] [Bug 104905] SpvOpFOrdEqual doesn't return correct results for NaNs

2018-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104905 --- Comment #1 from Samuel Pitoiset --- Hi Jozef, Yeah, would be nice to have a standalone case. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [PATCH demos 3/4] demos: Add missing binaries to .gitignore

2018-02-09 Thread Andreas Boll
Signed-off-by: Andreas Boll --- src/perf/.gitignore | 1 + src/tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/src/perf/.gitignore b/src/perf/.gitignore index 91d0d8b4..2180727a 100644 --- a/src/perf/.gitignore +++ b/src/perf/.gitignore @@ -3,6 +3,7 @@ drawoverhead fbobin

[Mesa-dev] [PATCH demos 4/4] egl: Install eglinfo binary

2018-02-09 Thread Andreas Boll
Signed-off-by: Andreas Boll --- I'd like to ship eglinfo inside Debian's mesa-utils-extra package and I thought other distributions could be interested in this patch as well. src/egl/opengl/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/opengl/Makefile.

[Mesa-dev] [PATCH demos 2/4] glxinfo/wglinfo: Fix typo

2018-02-09 Thread Andreas Boll
Fixes: 6eaf6ab3 "glxinfo/wglinfo: query/print more GL limits" Signed-off-by: Andreas Boll --- src/xdemos/glinfo_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index 07af9898..a61061c6 100644 --- a/src/xdemos/gli

[Mesa-dev] [PATCH demos 1/4] egl: Update .gitignore

2018-02-09 Thread Andreas Boll
There are no *_screen binaries anymore. Fixes: 66136b95 "egl: Build some OpenGL demos for Wayland" Signed-off-by: Andreas Boll --- src/egl/opengl/.gitignore| 2 -- src/egl/opengles2/.gitignore | 1 - 2 files changed, 3 deletions(-) diff --git a/src/egl/opengl/.gitignore b/src/egl/opengl/.gi

Re: [Mesa-dev] [PATCH] ac: pass struct ac_llvm_context to emit_membar()

2018-02-09 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 02/09/2018 12:39 AM, Timothy Arceri wrote: Fixes segfault in piglit test: ./bin/arb_shader_image_load_store-shader-mem-barrier --quick -auto -fbo --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 1/2] intel/compiler: fix first_component for 64-bit types on vertex inputs

2018-02-09 Thread Samuel Iglesias Gonsálvez
Series is, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 19/01/18 09:17, Iago Toral Quiroga wrote: > Divide it by two as we do for other stages. This is because the > component layout qualifier is always in 32-bit units. > > Fixes issues in a new CTS test (still WIP): > KHR-GL45.enhanced_layou

[Mesa-dev] [PATCH] radeonsi/nir: add FRAG_RESULT_COLOR to scan pass

2018-02-09 Thread Timothy Arceri
Fixes a numer of draw buffers piglit tests. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 4eda3f3c18..d42ed5edcc 100644 --- a/src/gallium/

[Mesa-dev] [PATCH] i965: prevent potentially null pointer access

2018-02-09 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin CID: 1418110 --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 1f866cf8459..3f74ee78f37 100644 --- a/src/mesa/

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-09 Thread Tomasz Figa
On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: > On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: >>> Hi Rob, >>> >>> On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss >>> wrote: > uint32_t (*get_fd)(buffer_handle_t handle,

[Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-09 Thread Lionel Landwerlin
Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" Signed-off-by: Lionel Landwerlin Cc: "18.0" --- src/mesa/drivers/dri/i965/brw_performance_query.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c b/s

[Mesa-dev] [PATCH] radeonsi/nir: add depth layout to scan pass

2018-02-09 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index d42ed5edcc..22787baec3 100644 --- a/src/gallium/drivers/radeonsi/si_shader_ni

Re: [Mesa-dev] [PATCH] st/mesa: Initialize tex_target otherwise it might be used uninitialized.

2018-02-09 Thread Michel Dänzer
On 2018-02-09 08:54 AM, Gert Wollny wrote: > The initialization of tex_target was dropped and since the value > is used uninitialized (e.g. with Unreal Editor), an assertion > fires in tgsi/tgsi_util.c:502: tgsi_util_get_texture_coord_dim: > Assertion `!"unknown texture target"' failed. > > Init

[Mesa-dev] [PATCH 00/11] TGSI: split, merge and interleave arrays

2018-02-09 Thread Gert Wollny
Dear all, this series of patches introduces array splitting, merging, and interleaving. Patch 1: Split arrays that are only accessed directly: I posted a first version off the the array splitting in patch 1 some time ago. Eric Anholt pointed out that this might be done in opt_array_splitti

[Mesa-dev] [PATCH 03/11] mesa/st: Add helper classes for array merging and interleaving

2018-02-09 Thread Gert Wollny
This class implements the live range merge and component interleave remapping logic. Signed-off-by: Gert Wollny --- src/mesa/Makefile.sources | 2 + src/mesa/meson.build | 2 + .../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 283 ++

[Mesa-dev] [PATCH 02/11] mesa/st/glsl_to_tgsi: rename lifetime to register_live_range

2018-02-09 Thread Gert Wollny
On one hand "live range" is the term used in the literature, and on the other hand a distinction is needed from the array live ranges that will be introduced later. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 ++--- .../state_tracker/st_glsl_to_tgsi_tem

[Mesa-dev] [PATCH 04/11] mesa/st/glsl_to_tgsi: Add class to hold array information

2018-02-09 Thread Gert Wollny
Implememt a class that holds the information required by the array merging and interleave algorithm, namely array ID, live range, access mask, accessed components, and the number of accessed components. Signed-off-by: Gert Wollny --- .../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 69 ++

[Mesa-dev] [PATCH 06/11] mesa/st/tests: Add unit tests for array merge helper classes.

2018-02-09 Thread Gert Wollny
Signed-off-by: Gert Wollny --- src/mesa/state_tracker/tests/Makefile.am | 20 +- src/mesa/state_tracker/tests/st_tests_common.h | 7 +- .../tests/test_glsl_to_tgsi_array_merge.cpp| 296 + 3 files changed, 317 insertions(+), 6 deletions(-) create mode

[Mesa-dev] [PATCH 05/11] mesa/st/glsl_to_tgsi: Add array merge logic

2018-02-09 Thread Gert Wollny
Add the functions that evaluate array live range merging and array interleaving based on the array information. Signed-off-by: Gert Wollny --- .../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 385 - .../state_tracker/st_glsl_to_tgsi_array_merge.h| 26 +- 2 files chan

[Mesa-dev] [PATCH 01/11] mesa/st: glsl_to_tgsi: Split arrays who's elements are only accessed directly

2018-02-09 Thread Gert Wollny
Array who's elements are only accessed directly are replaced by the according number of temporary registers. By doing so the otherwise reserved register range becomes subject to further optimizations like copy propagation and register merging. Thanks to the resulting reduced register pressure this

[Mesa-dev] [PATCH 10/11] mesa/st/glsl_to_tgsi: add array life range evaluation into tracking code

2018-02-09 Thread Gert Wollny
This adds the array live range tracking harvesting the already implemented live range tracking for temporary registers. With this patch the array live range tracking is not yet exposed, and since some tests that track reladdr access arrays, some array live range tracker instances need to be availa

[Mesa-dev] [PATCH 09/11] mesa/st/glsl_to_tgsi: add class for array access tracking

2018-02-09 Thread Gert Wollny
Add a class implementing the (rather simplified) live range evaluation for arrays. Remark: Since the class is local and not yet used, the compiler will emit some warnings about unused functions. Signed-off-by: Gert Wollny --- .../state_tracker/st_glsl_to_tgsi_temprename.cpp | 102

[Mesa-dev] [PATCH 07/11] mesa/st/glsl_to_tgsi: refactor access_record and its use

2018-02-09 Thread Gert Wollny
* rename access_record to register_merge_record because the name is more appropriate and we need to distinguish from the array access introduced later. * rename member variable acc to temp_acc * make comparison operator in register_merge_record const Signed-off-by: Gert Wollny --- .../stat

[Mesa-dev] [PATCH 08/11] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-02-09 Thread Gert Wollny
In preparation of the array live range tracking the evaluation of the read mask is moved out the register live range tracking to the enclosing call of the generalized read access tracking. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 15 ---

[Mesa-dev] [PATCH 11/11] mesa/st/glsl_to_tgsi: Expose array live range tracking and merging

2018-02-09 Thread Gert Wollny
Rename get_temp_registers_required_live_ranges to get_required_live_ranges and change its interface to also accomodate the live range tracking for arrays. Remove the placeholder arrays in this function and tie the array merging. This makes the register spilling in piglit glsl-1.30/execution/fs-

Re: [Mesa-dev] [PATCH] i965: prevent potentially null pointer access

2018-02-09 Thread Alejandro Piñeiro
Is there any reason to not add a fmt check before, so we would prevent calling isl_drm_modifier_get_info if not needed? In any case, that's a nitpick. Just in the case there is a reason, this patch: Reviewed-by: Alejandro Piñeiro On 09/02/18 10:57, Lionel Landwerlin wrote: > Signed-off-by: Lion

Re: [Mesa-dev] [PATCH 1/4] r600: add PIPE_SHADER_IR_NATIVE to supported shaders for cs

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 12:06, Timothy Arceri wrote: > --- > src/gallium/drivers/r600/r600_pipe.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/r600/r600_pipe.c > b/src/gallium/drivers/r600/r600_pipe.c > index 6c021e568d..719ab349ef 100644 > ---

Re: [Mesa-dev] [PATCH] nir: remove the abs call in is_neg_power_of_two

2018-02-09 Thread Gustaw Smolarczyk
2018-02-09 0:16 GMT+01:00 Matt Turner : > On Mon, Feb 5, 2018 at 7:16 PM, Vlad Golovkin > wrote: > > val->i32[swizzle[i]] is guaranteed to have non-positive value before the > > __is_power_of_two call, so unary minus is equivalent to abs in this case. > > --- > > src/compiler/nir/nir_search_help

Re: [Mesa-dev] [PATCH 1/4] r600: add PIPE_SHADER_IR_NATIVE to supported shaders for cs

2018-02-09 Thread Timothy Arceri
On 09/02/18 21:36, Pierre Moreau wrote: On 2018-02-09 — 12:06, Timothy Arceri wrote: --- src/gallium/drivers/r600/r600_pipe.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 6c02

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-02-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 krzys...@cybulski.info changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIX

Re: [Mesa-dev] [PATCH 2/4] clover: use PIPE_SHADER_CAP_SUPPORTED_IRS to discover IR

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 12:06, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conflicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > --- > src/gallium/state_trackers/clover/core/device.cpp | 11 +-- > 1 file changed, 9 insertions(+), 2

Re: [Mesa-dev] [PATCH] i965: prevent potentially null pointer access

2018-02-09 Thread Lionel Landwerlin
Hey Alejandro, I did that initially but then thought I could have to do it in multiple places. If you prefer the check to be in the calling function I can change it. Thanks, - Lionel On 09/02/18 10:13, Alejandro Piñeiro wrote: Is there any reason to not add a fmt check before, so we would p

Re: [Mesa-dev] [PATCH] i965: prevent potentially null pointer access

2018-02-09 Thread Alejandro Piñeiro
On 09/02/18 12:07, Lionel Landwerlin wrote: > Hey Alejandro, > > I did that initially but then thought I could have to do it in > multiple places. Ok. > If you prefer the check to be in the calling function I can change it. It is ok as it is. I was just curious. Thanks for the explanation. > >

Re: [Mesa-dev] [PATCH 2/4] clover: use PIPE_SHADER_CAP_SUPPORTED_IRS to discover IR

2018-02-09 Thread Timothy Arceri
On 09/02/18 21:54, Pierre Moreau wrote: On 2018-02-09 — 12:06, Timothy Arceri wrote: PIPE_SHADER_CAP_PREFERRED_IR was conflicting with PIPE_SHADER_IR_NIR for compute shaders, so we let clover pick the one it wants to use. --- src/gallium/state_trackers/clover/core/device.cpp | 11 +--

[Mesa-dev] [PATCH mesa] r200: remove left over dead code

2018-02-09 Thread Eric Engestrom
0aaa27f29187ffb739c7 removed the references to this array without removing the array itself Cc: Ian Romanick Fixes: 0aaa27f29187ffb739c7 "mesa: Pass the translated color logic op dd_function_table::LogicOpcode" Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/r200/r200_state.c | 20 -

Re: [Mesa-dev] [PATCH 1/3] st/mesa: don't translate blend state when it's disabled for a colorbuffer

2018-02-09 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_atom_blend.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/state_tracker/st_atom_blend.c > b/src/mesa/state_tracker/st_atom_blend.c > index f7327d6..a5f7edb 100644 > --- a/src

Re: [Mesa-dev] [PATCH mesa] r200: remove left over dead code

2018-02-09 Thread Elie Tournier
On Fri, Feb 09, 2018 at 11:42:50AM +, Eric Engestrom wrote: > 0aaa27f29187ffb739c7 removed the references to this array without > removing the array itself > > Cc: Ian Romanick > Fixes: 0aaa27f29187ffb739c7 "mesa: Pass the translated color logic op > dd_function_table::LogicOpcode" > Signed-

Re: [Mesa-dev] [PATCH demos 4/4] egl: Install eglinfo binary

2018-02-09 Thread Eric Engestrom
On Friday, 2018-02-09 10:09:01 +0100, Andreas Boll wrote: > Signed-off-by: Andreas Boll > --- > I'd like to ship eglinfo inside Debian's mesa-utils-extra package and I > thought > other distributions could be interested in this patch as well. Yes please :) Btw, I already pointed out 2/4 during

Re: [Mesa-dev] [PATCH 2/3] st/mesa: don't translate blend state when color writes are disabled

2018-02-09 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] st/mesa: generate blend state according to the number of enabled color buffers

2018-02-09 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > Non-MRT cases always translate blend state for 1 color buffer only. > MRT cases only check and translate blend state for enabled color buffers. > > This also avoids an assertion failure in translate_blend for: > > dEQP-GLES31.functional.draw_buffers

Re: [Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-09 Thread Eric Engestrom
On Friday, 2018-02-09 10:03:53 +, Lionel Landwerlin wrote: > Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" > Signed-off-by: Lionel Landwerlin > Cc: "18.0" The Fixes: tag with a commit which is in 18.0 already nominates it for backporting to that branch, you don't

Re: [Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-09 Thread Grazvydas Ignotas
Is this really sufficient? From what I read in the manpage, you can get an incomplete read instead when a signal arrives. Gražvydas On Fri, Feb 9, 2018 at 12:03 PM, Lionel Landwerlin wrote: > Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" > Signed-off-by: Lionel Landwe

Re: [Mesa-dev] [PATCH] intel/compiler: fix 64bit value prints on 32bit

2018-02-09 Thread Grazvydas Ignotas
ping On Sun, Feb 4, 2018 at 12:19 AM, Grazvydas Ignotas wrote: > Fix the following: > warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but > argument 3 has type ‘uint64_t {aka long long unsigned int}. > --- > src/intel/compiler/brw_disasm.c | 4 ++-- > src/inte

Re: [Mesa-dev] [PATCH] intel/compiler: fix 64bit value prints on 32bit

2018-02-09 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin Thanks, - Lionel On 09/02/18 12:28, Grazvydas Ignotas wrote: ping On Sun, Feb 4, 2018 at 12:19 AM, Grazvydas Ignotas wrote: Fix the following: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t {aka long long

Re: [Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-09 Thread Lionel Landwerlin
Fair, but since we're reading from sysfs, I think we should be fine. On 09/02/18 12:27, Grazvydas Ignotas wrote: Is this really sufficient? From what I read in the manpage, you can get an incomplete read instead when a signal arrives. Gražvydas On Fri, Feb 9, 2018 at 12:03 PM, Lionel Landwerli

[Mesa-dev] [PATCH 04/18] ac: move view_index to the ABI

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 29 +++-- src/amd/common/ac_shader_abi.h | 4 +++- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 7b27bef780..1d

[Mesa-dev] [PATCH 02/18] ac: move tg_size to the ABI

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 846566dc81..2b67454a73 100644 --- a/src/amd/c

[Mesa-dev] [PATCH 01/18] ac/nir: remove unused nir_to_llvm_context:{defs, phis}

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3691555208..846566dc81 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.

[Mesa-dev] [PATCH 00/18] ac/nir: cleanups and remove backlink to nir_to_llvm_context

2018-02-09 Thread Samuel Pitoiset
Hi, This series removes the backlink to nir_to_llvm_context in ac_nir_context by moving some code to the ABI. We should also rename nir_to_llvm_context to radv_shader_context, move all RADV-specific code outside of ac and remove the link to ac_nir_context, but this series is a good start. Please

[Mesa-dev] [PATCH 07/18] ac/nir: remove useless bitcast in load_tess_coord()

2018-02-09 Thread Samuel Pitoiset
nir_intrinsic_load_tess_coord always returns a v3i32. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5bd5171438..5d08e36c2d

[Mesa-dev] [PATCH 09/18] ac/nir: drop nir_to_llvm_context from emit_f2f16()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 88e3b3f68b..97b5ec90f7 100644 --- a/src/amd/common/ac_nir_

[Mesa-dev] [PATCH 08/18] ac: remove unused parameters in abi::load_tess_coord()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h | 4 +--- src/gallium/drivers/radeonsi/si_shader.c | 6 ++ 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/

[Mesa-dev] [PATCH 05/18] ac: add load_sample_mask_in() to the ABI

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 17 + src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 6 ++ 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm

[Mesa-dev] [PATCH 03/18] ac: move push_constants to the ABI

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 7 +++ src/amd/common/ac_shader_abi.h | 2 ++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 2b67454a73..7b27bef780 100644 --- a/src/am

[Mesa-dev] [PATCH 06/18] ac: add load_resource() to the ABI

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 20 +--- src/amd/common/ac_shader_abi.h | 12 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b5390ce083..5bd5

[Mesa-dev] [PATCH 12/18] ac/nir: drop nir_to_llvm_context from visit_load_push_constant()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3c7cc55eb7..d9ad62d7f6 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/sr

[Mesa-dev] [PATCH 10/18] ac/nir: drop nir_to_llvm_context from visit_load_local_invocation_index()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 97b5ec90f7..1188708020 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/

[Mesa-dev] [PATCH 15/18] ac/nir: drop nir_to_llvm_context from glsl_to_llvm_type()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b89067d6ca..273435adb6 100644 --- a/src/amd/common/ac_nir_to_

[Mesa-dev] [PATCH 13/18] ac/nir: drop nir_to_llvm_context from visit_vulkan_resource_reindex()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d9ad62d7f6..167d0f0c91 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/a

[Mesa-dev] [PATCH 11/18] ac/nir: drop nir_to_llvm_context from cast_ptr()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1188708020..3c7cc55eb7 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/co

[Mesa-dev] [PATCH 16/18] ac/nir: remove nir_to_llvm_context::builder

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 187 1 file changed, 92 insertions(+), 95 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 273435adb6..ae9e7b6c80 100644 --- a/src/amd/co

[Mesa-dev] [PATCH 14/18] ac/nir: drop nir_to_llvm_context from visit_var_atomic()

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 167d0f0c91..b89067d6ca 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/s

[Mesa-dev] [PATCH 17/18] ac/nir: remove nir_to_llvm_context::module

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ae9e7b6c80..70718853ec 100644 --- a/src/amd/common/ac_nir_to_llv

[Mesa-dev] [PATCH 18/18] ac/nir: remove backlink to nir_to_llvm_context

2018-02-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 70718853ec..024d6ba547 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_ll

Re: [Mesa-dev] [PATCH] radeonsi/nir: add depth layout to scan pass

2018-02-09 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 02/09/2018 11:09 AM, Timothy Arceri wrote: --- src/gallium/drivers/radeonsi/si_shader_nir.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c in

Re: [Mesa-dev] [PATCH 2/2] ac: convert nir_op_f2f32 src to a float

2018-02-09 Thread Samuel Pitoiset
Series is: Reviewed-by: Samuel Pitoiset On 02/09/2018 07:20 AM, Timothy Arceri wrote: Fixes the following piglit test: ./bin/arb_vertex_attrib_64bit-check-explicit-location -auto -fbo Where we would end up with the nir such as: vec1 64 ssa_11 = pack_64_2x32_split ssa_9, ssa_10

[Mesa-dev] [PATCH 0/2] appveyor: add Cygwin

2018-02-09 Thread Jon Turney
Jon Turney (2): appveyor: put build steps in a script, rather than inline in appveyor.yml appveyor: Add a Cygwin build script appveyor.yml| 40 +--- scripts/appveyor_cygwin.bat | 39 +++ scripts/appvey

[Mesa-dev] [PATCH 2/2] appveyor: Add a Cygwin build script

2018-02-09 Thread Jon Turney
v2: Use ccache build using meson, rather than autotools --- appveyor.yml| 19 ++- scripts/appveyor_cygwin.bat | 39 +++ 2 files changed, 53 insertions(+), 5 deletions(-) create mode 100644 scripts/appveyor_cygwin.bat diff --git

Re: [Mesa-dev] [PATCH] radeonsi/nir: add FRAG_RESULT_COLOR to scan pass

2018-02-09 Thread Samuel Pitoiset
On 02/09/2018 10:49 AM, Timothy Arceri wrote: Fixes a numer of draw buffers piglit tests. number --- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shad

[Mesa-dev] [PATCH 1/2] appveyor: put build steps in a script, rather than inline in appveyor.yml

2018-02-09 Thread Jon Turney
--- appveyor.yml | 29 +++-- scripts/appveyor_msvc.bat | 35 +++ 2 files changed, 38 insertions(+), 26 deletions(-) create mode 100644 scripts/appveyor_msvc.bat diff --git a/appveyor.yml b/appveyor.yml index 96eb1a67b3..cf3242b

Re: [Mesa-dev] [PATCH 4/5] ac/nir_to_llvm: add support for nir_intrinsic_shared_atomic_*

2018-02-09 Thread Samuel Pitoiset
On 02/09/2018 02:48 AM, Timothy Arceri wrote: --- src/amd/common/ac_nir_to_llvm.c | 48 +++-- 1 file changed, 42 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e7352cc7d2..db692919ce 1006

Re: [Mesa-dev] radeonsi add nir support for shared vars/atomics

2018-02-09 Thread Samuel Pitoiset
On 02/09/2018 02:48 AM, Timothy Arceri wrote: This adds the missing nir support and allows the nir backend to produce an equivalent shader to the tgsi backend for the only piglit test we have for this [1]. However the test still fails and I've so far been unable to spot the problem. [1] ./bin/

Re: [Mesa-dev] [PATCH v3 0/9] meson: fix gallium media target linkage

2018-02-09 Thread Marc Dietrich
Am Donnerstag, 8. Februar 2018, 21:55:33 CET schrieb Dylan Baker: > Hi Marc, > > Can I call that a Tested-by? I wouldn't it call tested-by because I wasn't able to decode a video (maybe different problem), but at least the tools work as they should. Marc > > Quoting Marc Dietrich (2018-02-05

[Mesa-dev] 2018 X.Org Board of Directors Elections Nomination period is NOW

2018-02-09 Thread Rob Clark
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2018 election are now open and will remain open until 23:59 UTC on 23 Feb 2018. The Board consists of directo

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-09 Thread Rob Herring
On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: > On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: >> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: >>> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: Hi Rob, On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss wrote

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
Hello Aaron, Sorry for not having reviewed the updated series… I will have a look at it over the weekend. If I understand correctly, patches 1 and 2 have been squashed together and upstreamed already, while patches 3 through 8 have not been merged yet. Is this series the latest version, or do you

Re: [Mesa-dev] [PATCH demos 2/4] glxinfo/wglinfo: Fix typo

2018-02-09 Thread Brian Paul
On Fri, Feb 9, 2018 at 2:08 AM, Andreas Boll wrote: > Fixes: 6eaf6ab3 "glxinfo/wglinfo: query/print more GL limits" > Signed-off-by: Andreas Boll > --- > src/xdemos/glinfo_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/g

Re: [Mesa-dev] [PATCH demos 3/4] demos: Add missing binaries to .gitignore

2018-02-09 Thread Brian Paul
Reviewed-by: Brian Paul On Fri, Feb 9, 2018 at 2:09 AM, Andreas Boll wrote: > Signed-off-by: Andreas Boll > --- > src/perf/.gitignore | 1 + > src/tests/.gitignore | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/perf/.gitignore b/src/perf/.gitignore > index 91d0d8b4..2180727a

Re: [Mesa-dev] [PATCH demos 1/4] egl: Update .gitignore

2018-02-09 Thread Brian Paul
Reviewed-by: Brian Paul On Fri, Feb 9, 2018 at 2:08 AM, Andreas Boll wrote: > There are no *_screen binaries anymore. > > Fixes: 66136b95 "egl: Build some OpenGL demos for Wayland" > Signed-off-by: Andreas Boll > --- > src/egl/opengl/.gitignore| 2 -- > src/egl/opengles2/.gitignore | 1 -

Re: [Mesa-dev] [PATCH] st/mesa: Initialize tex_target otherwise it might be used uninitialized.

2018-02-09 Thread Brian Paul
On Fri, Feb 9, 2018 at 3:10 AM, Michel Dänzer wrote: > On 2018-02-09 08:54 AM, Gert Wollny wrote: > > The initialization of tex_target was dropped and since the value > > is used uninitialized (e.g. with Unreal Editor), an assertion > > fires in tgsi/tgsi_util.c:502: tgsi_util_get_texture_coord_d

Re: [Mesa-dev] [PATCH 00/18] ac/nir: cleanups and remove backlink to nir_to_llvm_context

2018-02-09 Thread Bas Nieuwenhuizen
Awesome! Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 9, 2018 at 1:54 PM, Samuel Pitoiset wrote: > Hi, > > This series removes the backlink to nir_to_llvm_context in ac_nir_context > by moving some code to the ABI. > > We should also rename nir_to_llvm_context to radv_shader_context, move > all

Re: [Mesa-dev] [PATCH 10/13] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2018-02-09 Thread Marek Olšák
On Fri, Feb 9, 2018 at 3:01 AM, Brian Paul wrote: > Again, I can't research this right now, but what values in the > gl_state_index array are greater than 255? Perhaps you can add a comment > about that. And if that's not the case, gl_state_index8? I don't remember anymore, but I think I tried

Re: [Mesa-dev] [PATCH 12/13] mesa: reduce the size of gl_texture_image

2018-02-09 Thread Marek Olšák
On Fri, Feb 9, 2018 at 2:56 AM, Brian Paul wrote: > On Thu, Feb 8, 2018 at 6:18 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> 80 -> 40 bytes. >> --- >> src/mesa/main/mtypes.h | 47 >> --- >> 1 file changed, 24 insertions(+), 23 deletions(-) >>

Re: [Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

2018-02-09 Thread Daniel Stone
Hi Eric, On 8 February 2018 at 18:40, Eric Engestrom wrote: > On February 8, 2018 2:06:23 PM UTC, Daniel Stone > wrote: >> When 0b2b7191214eb moved from an if tree to a struct to map between >> wl_drm formats and EGLConfigs, it transposed the mapping between XRGB >> and ARGB. Luckily, everyone

Re: [Mesa-dev] [PATCH 05/18] egl/wayland: Add format enums to visual map

2018-02-09 Thread Daniel Stone
Hi Emil, On 8 February 2018 at 21:56, Emil Velikov wrote: > On 8 February 2018 at 14:05, Daniel Stone wrote: >> Extend the visual map from only containing names and bitmasks, to also >> carrying the three format enums we need. These are the DRIImage format >> tokens for internal allocation, Four

Re: [Mesa-dev] GBM, KMS/DRM, triple buffering

2018-02-09 Thread Daniel Stone
Hi Carlos, On 9 February 2018 at 08:33, Carlos Rafael Giani wrote: > I want to implement triple buffering instead of double buffering for a > program that uses EGL on GBM on a KMS-enabled platform. So far, I used > kmscube as an example. > > However, I do not see where I can specify that I want

Re: [Mesa-dev] [PATCH 00/18] Wayland/GBM format cleanups and 10bpc BGR

2018-02-09 Thread Daniel Stone
Hi, On 8 February 2018 at 22:47, Emil Velikov wrote: > On 8 February 2018 at 14:05, Daniel Stone wrote: >> When Ilia asked for suggestions on where to look to add 10bpc BGR >> support to the GBM and Wayland EGL backends, I had a quick look; the >> number of places the formats were duplicated and

Re: [Mesa-dev] [PATCH] loader_dri3/glx/egl: Reinstate the loader_dri3_vtable get_dri_screen callback

2018-02-09 Thread Timo Aaltonen
Thomas Hellstrom kirjoitti 09.02.2018 klo 10:37: > Removing this callback caused rendering corruption in some multi-screen cases, > so it is reinstated but without the drawable argument which was never used > by implementations and was confusing since the drawable could have been > created with ano

[Mesa-dev] [PATCH] mesa: Remove FLUSH_VERTICES from VAO state changes.

2018-02-09 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, An other splitout VAO handling improvement patch that I wanted to feed seperately. The change may be subject to discussion and following patches depend on the call signatures of some of the mesa internal vao methods that in turn depend on the outcome of this change

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Aaron Watry
No worries. I've been rebasing this series every time I've pulled mesa for the last few months, and this week is the first time I've had any real conflicts that need addressing. I'll see if I can find some time to address your comments and re-organize the commits as you suggested. Jan also had s

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 11:50, Aaron Watry wrote: > No worries. I've been rebasing this series every time I've pulled > mesa for the last few months, and this week is the first time I've had > any real conflicts that need addressing. I'll see if I can find some > time to address your comments and re-orga

Re: [Mesa-dev] GBM, KMS/DRM, triple buffering

2018-02-09 Thread Carlos Rafael Giani
Hi Daniel, thanks, I got it to work - almost. I am running this on the i.MX6 with etnaviv. I do get some flickering, however. To test if something is wrong with the page flipping, I call drmGetCap() with DRM_CAP_ASYNC_PAGE_FLIP , and it returns me 0, indicating that async page flipping is no

Re: [Mesa-dev] [PATCH v2 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

2018-02-09 Thread Boyuan Zhang
On 2018-02-08 05:13 PM, Mark Thompson wrote: On 06/02/18 20:05, James Zhu wrote: Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 1115 +++ 1 file changed, 1115 insertions(+) create mode 100644

  1   2   >