Wt., 13 lis 2018, 06:03: Matt Turner napisał(a):
> On Mon, Nov 12, 2018 at 3:07 PM Eric Anholt wrote:
> >
> > Matt Turner writes:
> >
> > > Prior to this patch sizeof(linear_header) was 20 bytes in a
> > > non-debug build on 32-bit platforms. We do some pointer arithmetic to
> > > calculate
SR#648671
On Tue, 13 Nov 2018, Dieter Nützel wrote:
> GREAT hint Tim!
>
> Yes, of course.
>
> /home/dieter> gcc --version
> gcc (SUSE Linux) 8.2.1 20181025 [gcc-8-branch revision 265488]
>
> So I have to ping SUSE to push the fix, too.
>
> Thanks a lot.
>
> Dieter
>
> Am 12.11.2018
Hello,
Thanks a lot for review.
Regards,
Andrii.
On Sat, Nov 10, 2018 at 5:38 AM Timothy Arceri
wrote:
> Nice! Series is:
>
> Reviewed-by: Timothy Arceri
>
> On 10/10/18 9:07 am, Ian Romanick wrote:
> > From: Ian Romanick
> >
> > Section 3.7 (Identifiers) of the GLSL spec says:
> >
> >
On 11/6/18 3:01 PM, Lionel Landwerlin wrote:
We could touch the macros in anv_formats.c to include VkFormat in
anv_format if that makes your life easier.
Yep, this makes sense. I'll add VkFormat there.
On 30/10/2018 05:26, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli
---
I forgot that aubinator_viewer_decoder.cpp needs to be updated too.
But updated locally and will push with the fix.
Thanks!
-
Lionel
On 08/11/2018 10:36, Lionel Landwerlin wrote:
Reviewed-by: Lionel Landwerlin
On 07/11/2018 14:50, Toni Lönnberg wrote:
The engine to which the batch was sent
I think this chunk (or the whole patch) should be cherry picked to stable.
Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV
EGLImage.
We should have BAD_MATCH instead.
-
Lionel
On 09/11/2018 10:55, Lionel Landwerlin wrote:
diff --git a/src/egl/drivers/dri2/egl_dri2.c
The host side has now landed, but because I re-worked the guest side
since Erik gave his R-B, I thought I'd ask you to take another look,
Best,
Gert
Am Mittwoch, den 12.09.2018, 11:59 +0200 schrieb Gert Wollny:
> From: Gert Wollny
>
> On the host VREND_DEBUG=guestallow must be set to let the
Hi Jason, just one thing here. Although I appreciate your interest to
understand how varyings are enumerated, I think that we are diverting
here, as in the end that would be something that I would need to solve.
I just wanted to know for the way to go.
The main question here is if we are really
On Mon, 12 Nov 2018 at 18:14, Dylan Baker wrote:
>
> Quoting Eric Engestrom (2018-11-12 09:47:22)
> > On Monday, 2018-11-12 16:56:32 +, Emil Velikov wrote:
> > > On Mon, 12 Nov 2018 at 14:24, Eric Engestrom
> > > wrote:
> > > >
> > > > These files are close to 4 years out of date; a lot's
[This time with mesa-dev@ in the list, and less typos]
Hi Rob,
On Mon, 12 Nov 2018 at 15:14, Robert Foss wrote:
> +++ b/src/gallium/drivers/virgl/virgl_screen.c
> @@ -340,7 +340,7 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap
> param)
> case PIPE_CAP_VIDEO_MEMORY:
>
https://bugs.freedesktop.org/show_bug.cgi?id=107822
--- Comment #6 from Alexander ---
I already have tested that.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
From: Andrii Simiklit
1. tools/i965_disasm.c:58:4: warning:
ignoring return value of ‘fread’,
declared with attribute warn_unused_result
fread(assembly, *end, 1, fp);
v2: - Fixed incorrect return value check.
( Eric Engestrom )
Signed-off-by: Andrii Simiklit
---
From: Andrii Simiklit
1. main/texcompress_etc.c:1314:12:
warning: ‘*((void *)+2)’ may be used uninitialized in this function
2. main/texcompress_etc.c:1354:12:
warning: ‘*((void *)+2)’ may be used uninitialized in this function
3. main/texcompress_etc.c:1293:12:
warning: ‘dst’ may be
From: Andrii Simiklit
1. nir/nir_lower_vars_to_ssa.c:691:21: warning:
unused variable ‘var’
nir_variable *var = path->path[0]->var;
v2: Changes for some part of 'may be used uninitialized'
warnings were removed, seems like it is a compiler issue.
( Eric Engestrom )
From: Andrii Simiklit
1. brw_pipe_control.c:311:34: warning:
unused variable ‘devinfo’
2. brw_program_binary.c:209:19: warning:
unused variable ‘gen_size’
3. brw_program_binary.c:216:19: warning:
unused variable ‘nir_size’
v2: Changes for unreproducible issues were removed
From: Andrii Simiklit
Fixes several compilation warnings for a release configuration
v2: the patch '1/4' was separated to '1/5' and '5/5'
( Eric Engestrom )
Andrii Simiklit (5):
intel/tools: avoid 'unused variable' warnings
compiler: avoid 'unused variable'
i965: avoid 'unused
From: Andrii Simiklit
1. tools/aub_read.c:271:31: warning: unused variable ‘end’
const uint32_t *p = data, *end = data + data_len, *next;
2. tools/aub_mem.c:292:13: warning: unused variable ‘res’
void *res = mmap((uint8_t *)bo.map + map_offset, 4096, PROT_READ,
For all the xml changes :
Reviewed-by: Lionel Landwerlin
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/13/18 1:43 PM, Lionel Landwerlin wrote:
I think this chunk (or the whole patch) should be cherry picked to stable.
Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV
EGLImage.
We should have BAD_MATCH instead.
Or should we change the reported error code in places
https://bugs.freedesktop.org/show_bug.cgi?id=32211
Danylo changed:
What|Removed |Added
CC||danylo.pilia...@gmail.com
--- Comment #12 from
Hello,
Could anyone look at the patch?
Thanks!
On 10/24/18 2:22 PM, Danylo Piliaiev wrote:
I have made a Piglit test that exercises the issue:
https://patchwork.freedesktop.org/patch/258180/
- Danil
On 9/10/18 6:21 PM, Danylo Piliaiev wrote:
Handle all cases in calculation of layers count
On 13/11/2018 12:04, Tapani Pälli wrote:
On 11/13/18 1:43 PM, Lionel Landwerlin wrote:
I think this chunk (or the whole patch) should be cherry picked to
stable.
Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV
EGLImage.
We should have BAD_MATCH instead.
Or should we
On Wed, 2018-09-12 at 11:59 +0200, Gert Wollny wrote:
> From: Gert Wollny
>
> On the host VREND_DEBUG=guestallow must be set to let the guest
> override
> the debug flags.
>
> v2: Send flag string instead of flags, this avoids the need to keep
> the flags in sync.
> v3: Only request host
Reviewed-by: Samuel Pitoiset
On 11/7/18 5:20 AM, Timothy Arceri wrote:
vkpipeline-db results:
Totals from affected shaders:
SGPRS: 28400 -> 28576 (0.62 %)
VGPRS: 27916 -> 27692 (-0.80 %)
Spilled SGPRs: 140 -> 138 (-1.43 %)
Spilled VGPRs: 0 -> 0 (0.00 %)
Private memory VGPRs: 0 -> 0 (0.00 %)
On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote:
> Quoting Erik Faye-Lund (2018-11-12 04:51:47)
> > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote:
> > > Which has the same behavior.
> >
> > Does it? I'm not so sure... IROUND_POS seems to round to nearest
> > integer depending on the
On 13/11/2018 15:43, Emil Velikov wrote:
On Tue, 13 Nov 2018 at 14:11, Lionel Landwerlin
wrote:
According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
image with a DRM format not supported should yield the BAD_MATCH
error :
"
* If is EGL_LINUX_DMA_BUF_EXT, and the
Signed-off-by: Karol Herbst
---
src/compiler/spirv/spirv_to_nir.c | 5 +-
src/compiler/spirv/vtn_alu.c | 187 +-
src/compiler/spirv/vtn_private.h | 3 +
3 files changed, 115 insertions(+), 80 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
this helps reduce the overall code changes when a bit_size parameter is
added to nir_load_system_value
Reviewed-by: Jason Ekstrand
Reviewed-by: Eric Anholt
Signed-off-by: Karol Herbst
---
src/amd/vulkan/radv_meta_buffer.c| 8
src/amd/vulkan/radv_meta_bufimage.c
this allows to replace some nir_load_system_value calls with the specific
system value constructor
Reviewed-by: Jason Ekstrand
Reviewed-by: Eric Anholt
Signed-off-by: Karol Herbst
---
src/compiler/nir/nir_builder_opcodes_h.py | 21 +++--
1 file changed, 19 insertions(+), 2
Quoting Erik Faye-Lund (2018-11-13 01:34:53)
> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote:
> > Quoting Erik Faye-Lund (2018-11-12 04:51:47)
> > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote:
> > > > Which has the same behavior.
> > >
> > > Does it? I'm not so sure... IROUND_POS
With OpenCL some system values match the address bits, but in GLSL we also
have some system values being 64 bit.
With this it is possible to adjust the builder functions so that depending
on the bit_sizes the correct bit_size is used or an additional argument is
added in case of multiple possible
this adds support for pointers from CL kernels. The basic idea here is to be
able to start a deref chain from a random ssa value and vice versa.
changes summed up:
1. derefs can start from a deref_cast
2. new ptr_as_array deref type to offset a pointer
3. derefs can end with a ssa_from_deref
the idea here is to generate an entry point stub function wrapping around the
actual kernel function and turn all parameters into shader inputs with byte
addressing instead of vec4.
This gives us several advantages:
1. calling kernel functions doesn't differ from calling any other function
2. CL
https://bugs.freedesktop.org/show_bug.cgi?id=108734
Bug ID: 108734
Summary: Regression: [bisected]
dEQP-GLES31.functional.tessellation.invariance.* start
failing on r600
Product: Mesa
Version: git
On Tuesday, 2018-11-13 14:19:31 +0200, asimiklit.w...@gmail.com wrote:
> From: Andrii Simiklit
>
> 1. main/texcompress_etc.c:1314:12:
> warning: ‘*((void *)+2)’ may be used uninitialized in this function
> 2. main/texcompress_etc.c:1354:12:
> warning: ‘*((void *)+2)’ may be used
On Tuesday, 2018-11-13 14:19:32 +0200, asimiklit.w...@gmail.com wrote:
> From: Andrii Simiklit
>
> 1. tools/i965_disasm.c:58:4: warning:
> ignoring return value of ‘fread’,
> declared with attribute warn_unused_result
> fread(assembly, *end, 1, fp);
>
> v2: - Fixed incorrect
On Tuesday, 2018-11-13 14:19:30 +0200, asimiklit.w...@gmail.com wrote:
> From: Andrii Simiklit
>
> 1. brw_pipe_control.c:311:34: warning:
> unused variable ‘devinfo’
> 2. brw_program_binary.c:209:19: warning:
> unused variable ‘gen_size’
> 3. brw_program_binary.c:216:19: warning:
>
According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
image with a DRM format not supported should yield the BAD_MATCH
error :
"
* If is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT
attribute is set to a format not supported by the EGL, EGL_BAD_MATCH
The brw_nir_opt_peephole_ffma pass is only doing what the fuse_ffma
option already does. It produces the same result as the fuse_ffma
option, which is not optimal.
This is what I get:
vec4 32 ssa_7 = fmul ssa_6, ssa_1.
vec4 32 ssa_8 = ffma ssa_5, ssa_1., ssa_7
vec4 32 ssa_10 =
On Tue, 13 Nov 2018 at 14:11, Lionel Landwerlin
wrote:
>
> According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
> image with a DRM format not supported should yield the BAD_MATCH
> error :
>
> "
>* If is EGL_LINUX_DMA_BUF_EXT, and the
> EGL_LINUX_DRM_FOURCC_EXT
>
Signed-off-by: Karol Herbst
---
src/compiler/glsl_types.cpp | 48 +
src/compiler/glsl_types.h | 10
src/compiler/nir_types.cpp | 12 ++
src/compiler/nir_types.h| 4
4 files changed, 74 insertions(+)
diff --git
We need this for OpenCL kernels because we have to apply C rules for alignment
and padding inside structs and for this we also have to know if a struct is
packed or not.
Signed-off-by: Karol Herbst
---
src/compiler/glsl_types.cpp | 17 +++--
src/compiler/glsl_types.h |
Signed-off-by: Karol Herbst
---
src/compiler/nir/nir.h| 8
src/compiler/nir/nir_clone.c | 1 +
src/compiler/nir/nir_serialize.c | 2 ++
src/compiler/spirv/spirv_to_nir.c | 15 +--
4 files changed, 24 insertions(+), 2 deletions(-)
diff --git
Not complete, mostly just adding things as I encounter them in CTS. But
not getting far enough yet to hit most of the OpenCL.std instructions.
Anyway, this is better than nothing and covers the most common builtins.
Signed-off-by: Karol Herbst
---
src/compiler/nir/meson.build | 1 +
From: Rob Clark
For cl we can have structs with 8/16/32/64 bit scalar types (as well as,
ofc, arrays/structs/etc), which are padded according to 'C' rules. So
for lowering struct deref's we need to not just consider a field's size,
but also it's alignment.
Signed-off-by: Karol Herbst
---
the naming is a bit confusing no matter how you look at it. Within OpenCL
"global" memory is memory accessible from all threads. glsl "global" memory
normally refers to shader thread private memory declared at global scope. As
we already use "shared" for memory shared across all thrads of a work
From: Rob Clark
changes by Karol:
v2: make compatible with 64 bit floats
fix isfinite
v3: use snake_case.
Signed-off-by: Karol Herbst
---
src/compiler/spirv/vtn_alu.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/compiler/spirv/vtn_alu.c
From: Rob Clark
vtn supports these, so don't squalk if user is happy with enabling
these.
Signed-off-by: Karol Herbst
---
src/compiler/shader_info.h | 3 +++
src/compiler/spirv/spirv_to_nir.c | 16 +---
src/compiler/spirv/vtn_variables.c | 6 --
3 files changed, 20
Signed-off-by: Karol Herbst
---
src/amd/vulkan/radv_meta_buffer.c | 8 ++--
src/amd/vulkan/radv_meta_bufimage.c | 16
src/amd/vulkan/radv_meta_fast_clear.c | 4 +-
src/amd/vulkan/radv_meta_resolve_cs.c | 4 +-
src/amd/vulkan/radv_query.c
This introduces new vec8 and vec16 instructions (which are the only
instructions taking more than 4 sources), in order to construct 8 and 16
component vectors.
In order to avoid fixing up the non-autogenerated nir_build_alu() sites
and making them pass 16 src args for the benefit of the two
Signed-off-by: Karol Herbst
---
src/compiler/glsl_types.h | 34 ++
src/compiler/nir_types.h | 30 +-
2 files changed, 35 insertions(+), 29 deletions(-)
diff --git a/src/compiler/glsl_types.h b/src/compiler/glsl_types.h
index
Signed-off-by: Karol Herbst
---
src/compiler/spirv/spirv_to_nir.c | 3 +++
src/compiler/spirv/vtn_private.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index 2c214324774..650eb6a977c 100644
---
From: Rob Clark
For pointers we'll need to add another caller, plus in addition a
type_align() fxn ptr. So just simplify things and pass the
lower_io_state to get_io_offset().
Signed-off-by: Karol Herbst
---
src/compiler/nir/nir_lower_io.c | 12 ++--
1 file changed, 6 insertions(+),
Signed-off-by: Karol Herbst
---
src/compiler/nir/nir.c | 4
src/compiler/nir/nir.h | 1 +
src/compiler/nir/nir_print.c | 2 ++
src/compiler/spirv/vtn_private.h | 1 +
src/compiler/spirv/vtn_variables.c | 4
5 files changed, 12 insertions(+)
diff --git
v2: fix for specialization constants as well
Signed-off-by: Karol Herbst
---
src/compiler/spirv/spirv_to_nir.c | 20
src/compiler/spirv/vtn_alu.c | 11 +++
2 files changed, 31 insertions(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
Signed-off-by: Karol Herbst
---
src/compiler/spirv/vtn_opencl.c | 59 +
1 file changed, 59 insertions(+)
diff --git a/src/compiler/spirv/vtn_opencl.c b/src/compiler/spirv/vtn_opencl.c
index 089e6168fd8..ecaca4c17bc 100644
--- a/src/compiler/spirv/vtn_opencl.c
+++
some of those patches are already reviewed, but not pushed. Just wanted to
post the patches to show the most current approach and to start discussion
on what we might want to handle differently.
There are some things I am not so happy about as well, like that bit_size
handling for system values
On Tuesday, 2018-11-13 13:37:14 +, Emil Velikov wrote:
> On Mon, 12 Nov 2018 at 18:14, Dylan Baker wrote:
> >
> > Quoting Eric Engestrom (2018-11-12 09:47:22)
> > > On Monday, 2018-11-12 16:56:32 +, Emil Velikov wrote:
> > > > On Mon, 12 Nov 2018 at 14:24, Eric Engestrom
> > > > wrote:
From: Gert Wollny
GLES 3.0 does not actually require support for EXT_framebuffer_sRGB, it
only needs support for sRGB attachments to framebuffers.
Signed-off-by: Gert Wollny
---
src/mesa/main/version.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
From: Gert Wollny
Signed-off-by: Gert Wollny
---
src/gallium/drivers/virgl/virgl_hw.h | 1 +
src/gallium/drivers/virgl/virgl_screen.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/gallium/drivers/virgl/virgl_hw.h
b/src/gallium/drivers/virgl/virgl_hw.h
index
From: Gert Wollny
Signed-off-by: Gert Wollny
---
src/mesa/main/fbobject.c | 2 +-
src/mesa/main/teximage.c | 3 +--
src/mesa/main/version.c | 5 ++---
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index
From: Gert Wollny
Use EXT_framebuffer_sRGB to expose EXT_sRGB_write_control on GLES. Remove
the checks for desktion GL in the enable calls, since EXT_framebuffer_sRGB
now also indicates support for switching the linear-sRGB color
space conversion on GLES.
Thanks to Ilia Mirkin for all the
From: Gert Wollny
Signed-off-by: Gert Wollny
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index d7e02efb54..ca369e39f2 100644
---
From: Gert Wollny
For GLES sRGB framebuffer attachemnt support is provided in two steps:
sRGB attachments like described in EXT_sRGB and GLES 3.0 that enable
linear to sRGB color space transformation automatically, and sRGB write
control that brings GLES on par with EXT_framebuffer_sRGB. Set the
From: Gert Wollny
EXT_sRGB is an (incomplete) GLES extension that provides support for sRGB
framebuffer attachments, hence it can be used to check for this support
as an alternative to EXT_framebuffer_sRGB that provies the same
functionality but also sRGB write control support.
All drivers that
From: Gert Wollny
Dear all,
based on the feedback given by Ilia I've completely reworked the series to add
internal support for EXT_sRGB as a stepstone to implement EXT_sRGB_write_control
and expose GLES 3.0 properly.
Since the series has been reworked thoroughly, most of the original patches
From: Gert Wollny
Add a new cap that indicates whether the drivers supports
enabling/disabling the conversion from linear space to sRGB
for a framebuffer attachment.
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/util/u_screen.c | 3 +++
src/gallium/docs/source/screen.rst| 3 +++
Is ARB_framebuffer_object really needed? IIRC one of the sticking
points is that it allows differently-sized render targets. Does ES3
allow that? If so, this is fine.
On Tue, Nov 13, 2018 at 12:28 PM Gert Wollny wrote:
>
> From: Gert Wollny
>
> GLES 3.0 does not actually require support for
Why not order the series such that this commit is not needed?
On Tue, Nov 13, 2018 at 12:28 PM Gert Wollny wrote:
>
> From: Gert Wollny
>
> Signed-off-by: Gert Wollny
> ---
> src/mesa/main/fbobject.c | 2 +-
> src/mesa/main/teximage.c | 3 +--
> src/mesa/main/version.c | 5 ++---
> 3 files
In the case when we had both source and mask samplers, transformations were
typically not applied correctly.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Brian Paul
---
src/gallium/state_trackers/xa/xa_renderer.c | 117
1 file changed, 49 insertions(+), 68 deletions(-)
Support Component Alpha for those composite operations that do not require
per-channel alpha blending.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Brian Paul
---
src/gallium/state_trackers/xa/xa_composite.c | 33
src/gallium/state_trackers/xa/xa_priv.h | 1 +
constify function arguments to clean up the code a bit.
Reported-by: Brian Paul
Signed-off-by: Thomas Hellstrom
Reviewed-by: Brian Paul
---
src/gallium/state_trackers/xa/xa_renderer.c | 24 ++---
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
If we can't clear all the buffers with pctx->clear() (say, for example,
because of ColorMask), push the buffers we *can* clear with pctx->clear()
first. Tilers want to see clears coming before draws to enable fast-
paths, and clearing one of the attachments with a quad-draw first
confuses that
Am 13.11.18 um 18:00 schrieb Dylan Baker:
> Quoting Erik Faye-Lund (2018-11-13 01:34:53)
>> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote:
>>> Quoting Erik Faye-Lund (2018-11-12 04:51:47)
On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote:
> Which has the same behavior.
We have a bunch of code to do this in the back-end compiler but it's
fairly specific to typed surface messages and the way we emit them.
This breaks it out into NIR were it's easier to do things a bit more
generally. It also means we can easily share the code between the bec4
and FS back-ends if
This also changes spirv_to_nir and glsl_to_nir to set them. The one
place that doesn't set them is shared memory access lowering in
nir_lower_io. That will have to be updated before any consumers of it
can effectively use these new alignments.
---
src/compiler/glsl/glsl_to_nir.cpp|
This assert won't catch all mistakes with this helper but it will at
least ensure that the top bits are all zero or all one which should help
catch bugs.
---
src/compiler/nir/nir_builder.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/nir/nir_builder.h
It messes up when trying to lower.
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/nir/nir_lower_alu_to_scalar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/nir/nir_lower_alu_to_scalar.c
b/src/compiler/nir/nir_lower_alu_to_scalar.c
index 0be3aba9456..7ef032cd164
In order to properly do all the different kinds of SSBO and SLM writes that
we have in GL and Vulkan, we have to do some lowering. The hardware
doesn't have instructions for writing a N-bit vecM with an arbitrary
write-mask. Instead, we have byte scattered messages which work on a
scalar byte,
---
src/compiler/glsl/glsl_to_nir.cpp | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
index 0479f8fcfe4..9bb0f5d4044 100644
--- a/src/compiler/glsl/glsl_to_nir.cpp
+++
From: Marek Olšák
This was missed when I added the new enum.
Cc: 18.3
---
src/gallium/drivers/radeonsi/si_get.c | 9 ++---
src/gallium/drivers/radeonsi/si_uvd.c | 3 ++-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_get.c
Am 14.11.18 um 03:02 schrieb Roland Scheidegger:
> Am 13.11.18 um 23:49 schrieb Dylan Baker:
>> Quoting Roland Scheidegger (2018-11-13 14:13:00)
>>> Am 13.11.18 um 18:00 schrieb Dylan Baker:
Quoting Erik Faye-Lund (2018-11-13 01:34:53)
> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker
On Mon, Sep 10, 2018 at 10:21 AM Danylo Piliaiev
wrote:
> Handle all cases in calculation of layers count for isl_view
> taking into account texture view and image unit.
> st_convert_image was taken as a reference.
>
> When u->Layered is true the whole level is taken with respect to
> image
Quoting Roland Scheidegger (2018-11-13 14:13:00)
> Am 13.11.18 um 18:00 schrieb Dylan Baker:
> > Quoting Erik Faye-Lund (2018-11-13 01:34:53)
> >> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote:
> >>> Quoting Erik Faye-Lund (2018-11-12 04:51:47)
> On Fri, 2018-11-09 at 10:40 -0800,
On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote:
>
> Rob Clark writes:
>
> > If we can't clear all the buffers with pctx->clear() (say, for example,
> > because of ColorMask), push the buffers we *can* clear with pctx->clear()
> > first. Tilers want to see clears coming before draws to enable
On Tue, Nov 13, 2018 at 6:50 PM Rob Clark wrote:
>
> On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt wrote:
> >
> > Rob Clark writes:
> >
> > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote:
> > >>
> > >> Rob Clark writes:
> > >>
> > >> > If we can't clear all the buffers with pctx->clear()
https://bugs.freedesktop.org/show_bug.cgi?id=102597
--- Comment #10 from Dieter Nützel ---
Code fix under way:
https://lists.freedesktop.org/archives/mesa-dev/2018-November/209473.html
With this patch mpv drops notably, apart that '--vo=opengl-hq' isn't available
any longer. Was replaced by
On Mon, Nov 12, 2018 at 8:35 AM Juan A. Suarez Romero
wrote:
>
> Hello list,
>
> The candidate for the Mesa 18.2.5 is now available. Currently we have:
> - 25 queued
> - 0 nominated (outstanding)
> - and 2 rejected patch
If it's not a big deal if would be convenient for me (for Gentoo) to
Am 14.11.18 um 03:21 schrieb Matt Turner:
> On Tue, Nov 13, 2018 at 6:03 PM Roland Scheidegger wrote:
>>
>> Am 13.11.18 um 23:49 schrieb Dylan Baker:
>>> Quoting Roland Scheidegger (2018-11-13 14:13:00)
Am 13.11.18 um 18:00 schrieb Dylan Baker:
> Quoting Erik Faye-Lund (2018-11-13
Signed-off-by: Anuj Phogat
Cc: Kenneth Graunke
Cc: Francisco Jerez
Cc: Lionel Landwerlin
---
src/intel/common/gen_l3_config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/common/gen_l3_config.c b/src/intel/common/gen_l3_config.c
index
L3 allocation table in h/w specification recommends using 4 KB
granularity for programming allocation fields in L3CNTLREG.
Signed-off-by: Anuj Phogat
Cc: Kenneth Graunke
Cc: Francisco Jerez
Cc: Lionel Landwerlin
---
src/intel/genxml/gen11.xml | 1 +
src/intel/vulkan/genX_cmd_buffer.c
Use L3 configuration table specified in h/w specification.
Signed-off-by: Anuj Phogat
Cc: Kenneth Graunke
Cc: Francisco Jerez
Cc: Lionel Landwerlin
---
src/intel/common/gen_l3_config.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
L3 allocation table in h/w specification recommends using 4 KB
granularity for programming allocation fields in L3CNTLREG.
Signed-off-by: Anuj Phogat
Cc: Kenneth Graunke
Cc: Francisco Jerez
Cc: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_defines.h | 1 +
On Tue, Nov 13, 2018 at 4:53 PM Jason Ekstrand wrote:
>
> On Mon, Sep 10, 2018 at 10:21 AM Danylo Piliaiev
> wrote:
>>
>> Handle all cases in calculation of layers count for isl_view
>> taking into account texture view and image unit.
>> st_convert_image was taken as a reference.
>>
>> When
For the series
Tested-by: Dieter Nützel
mpv drops notably, apart that '--vo=opengl-hq' isn't available any
longer. Was replaced by '--vo=gpu'.
Dieter
Am 13.11.2018 22:23, schrieb Marek Olšák:
From: Marek Olšák
There are no writes.
---
src/gallium/drivers/radeonsi/si_fence.c | 3
Rob Clark writes:
> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote:
>>
>> Rob Clark writes:
>>
>> > If we can't clear all the buffers with pctx->clear() (say, for example,
>> > because of ColorMask), push the buffers we *can* clear with pctx->clear()
>> > first. Tilers want to see clears
Am 13.11.18 um 23:49 schrieb Dylan Baker:
> Quoting Roland Scheidegger (2018-11-13 14:13:00)
>> Am 13.11.18 um 18:00 schrieb Dylan Baker:
>>> Quoting Erik Faye-Lund (2018-11-13 01:34:53)
On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote:
> Quoting Erik Faye-Lund (2018-11-12 04:51:47)
On Tue, Nov 13, 2018 at 6:03 PM Roland Scheidegger wrote:
>
> Am 13.11.18 um 23:49 schrieb Dylan Baker:
> > Quoting Roland Scheidegger (2018-11-13 14:13:00)
> >> Am 13.11.18 um 18:00 schrieb Dylan Baker:
> >>> Quoting Erik Faye-Lund (2018-11-13 01:34:53)
> On Mon, 2018-11-12 at 09:22 -0800,
Hi Marek
Sure. Thanks for writing these patches.
The looks good.
I've done some small testing:
drawoverhead numbers looks great in my eyes:
29: DrawElements ( 1 VBO, 8 UBO, 8 Tex) w/ sample mask enable change:
6.63 million (94.7%)
Hitman benchmark runs nicely, even slightly bit faster
Looks correct.
Reviewed-by: Jason Ekstrand
On Mon, Nov 12, 2018 at 2:17 AM Gert Wollny wrote:
> From: Gert Wollny
>
> Some hardware supports source mods only for float operations. Make it
> possible to skip lowering to source mods in these cases.
>
> v2: use option flags instead of a boolean
1 - 100 of 133 matches
Mail list logo
