Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-30 Thread Ian Romanick
On 11/29/2018 03:53 PM, Eric Anholt wrote: > e<#secure method=pgpmime mode=sign> > Erik Faye-Lund writes: > >> On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: >>> Jordan Justen writes: >>> This adds the "Developer's Certificate of Origin 1.1" from the Linux kernel. It

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread Lionel Landwerlin
On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit 1. tools/i965_disasm.c:58:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result fread(assembly, *end, 1, fp); v2: Fixed incorrect return value check. ( Eric

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
On Fri, Nov 30, 2018 at 1:13 PM Kristian Høgsberg wrote: > On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: > > > > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly > misleading, because it doesn't imply anything about the OpenGL ES behavior, > which is that a texture is

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-30 Thread Daniel Stone
Hi all, Thanks for the CC. I'm on a sabbatical until mid-January; I'll be around but not following the lists/etc as actively as before. Please feel free to liberally CC me (on this address, not work) or poke me on IRC if there's something I should see or could contribute to. I'll have limited time

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-30 Thread Michel Dänzer
On 2018-11-30 4:57 p.m., Daniel Stone wrote: > On Wed, 28 Nov 2018 at 17:23, Dylan Baker wrote: > >> Personally speaking, I think that better next steps for gitlab integration >> are: >> - migrate from bugzilla to gitlab issues > > This is currently held up by a mutual death grip: both AMD and

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Kristian Høgsberg
On Tue, Nov 6, 2018 at 6:26 PM Roland Scheidegger wrote: > > Am 07.11.18 um 00:03 schrieb Kristian Høgsberg: > > On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: > >> > >> Hi, > >> > >> Is there anything to be done in the nine state trackers (or other state > >> trackers). > >> > >> Nine uses

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Kristian Høgsberg
On Fri, Nov 30, 2018 at 10:17 AM Marek Olšák wrote: > > On Fri, Nov 30, 2018 at 1:13 PM Kristian Høgsberg wrote: >> >> On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: >> > >> > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly >> > misleading, because it doesn't imply

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #4 from tempel.jul...@gmail.com --- I launched "renderdoccmd capture wine64 TheForest.exe" and saved a capture via button. Stupid question now: Where is it? :) -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #6 from tempel.jul...@gmail.com --- Thanks, found it. Compressing and uploading it right now. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #8 from tempel.jul...@gmail.com --- Created attachment 142675 --> https://bugs.freedesktop.org/attachment.cgi?id=142675=edit The Forest renderdoc log part 2 -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread Eric Engestrom
On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote: > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > 1. tools/i965_disasm.c:58:4: warning: > > ignoring return value of ‘fread’, > > declared with attribute warn_unused_result > >

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #5 from

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 10:55 AM Michel Dänzer wrote: > On 2018-11-30 4:57 p.m., Daniel Stone wrote: > > On Wed, 28 Nov 2018 at 17:23, Dylan Baker wrote: > > > >> Personally speaking, I think that better next steps for gitlab > integration are: > >> - migrate from bugzilla to gitlab issues > >

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 11:27 AM Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 10:55 AM Michel Dänzer wrote: > >> On 2018-11-30 4:57 p.m., Daniel Stone wrote: >> > On Wed, 28 Nov 2018 at 17:23, Dylan Baker wrote: >> > >> >> Personally speaking, I think that better next steps for gitlab >>

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread andrey simiklit
On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom wrote: > On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote: > > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote: > > > From: Andrii Simiklit > > > > > > 1. tools/i965_disasm.c:58:4: warning: > > > ignoring return value of

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #7 from tempel.jul...@gmail.com --- Created attachment 142674 --> https://bugs.freedesktop.org/attachment.cgi?id=142674=edit The Forest renderdoc log part 1 -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Kristian Høgsberg
On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: > > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly > misleading, because it doesn't imply anything about the OpenGL ES behavior, > which is that a texture is multisampled in the cache, but single-sampled in > memory. This

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-30 Thread Eric Anholt
Ian Romanick writes: > On 11/29/2018 03:53 PM, Eric Anholt wrote: >> e<#secure method=pgpmime mode=sign> >> Erik Faye-Lund writes: >> >>> On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: Jordan Justen writes: > This adds the "Developer's Certificate of Origin 1.1" from the

Re: [Mesa-dev] Lets talk about autotools

2018-11-30 Thread Dave Airlie
On Wed., 28 Nov. 2018, 03:06 Matt Turner On Tue, Nov 27, 2018 at 1:13 AM Timo Aaltonen wrote: > > > > On 17.11.2018 6.04, Dylan Baker wrote: > > > Quoting Dylan Baker (2018-09-17 09:44:07) > > >> I feel like for !windows meson is in good enough shape at this point > that we > > >> can start

[Mesa-dev] Representing explicit memory layouts in NIR

2018-11-30 Thread Jason Ekstrand
All, This week, I've been working on trying to move UBO and SSBO access in NIR over to deref instructions. I'm hoping that this will allow us to start doing alias analysis and copy-propagation on it. The passes we have in NIR *should* be able to work with SSBOs as long as nir_compare_derefs

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > wrote: > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand > mailto:ja...@jlekstrand.net>> wrote: > >> >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 02:36 PM, Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 4:34 PM Ian Romanick > wrote: > > On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > >

Re: [Mesa-dev] [PATCH] android: amd/addrlib: update Mesa's copy of addrlib

2018-11-30 Thread Haehnle, Nicolai
We really need to reduce the number of build systems in Mesa :/ Reviewed-by: Nicolai Hähnle On 30.11.18 23:48, Mauro Rossi wrote: > Needed to fix build error in addrlib in mesa for Android > > Fixes: 776b911 ("amd/addrlib: update Mesa's copy of addrlib") > Signed-off-by: Mauro Rossi > --- >

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #9 from tempel.jul...@gmail.com --- Created attachment 142676 --> https://bugs.freedesktop.org/attachment.cgi?id=142676=edit The Forest renderdoc log part 3 -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #10 from tempel.jul...@gmail.com --- Created attachment 142679 --> https://bugs.freedesktop.org/attachment.cgi?id=142679=edit The Forest renderdoc log part 4 -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH v3 2/5] gallium: Add new PIPE_CAP_SURFACE_SAMPLE_COUNT

2018-11-30 Thread Kristian H. Kristensen
This new pipe cap and the new nr_samples field in pipe_surface lets a state tracker bind a render target with a different sample count than the resource. This allows for implementing EXT_multisampled_render_to_texture and EXT_multisampled_render_to_texture2. Signed-off-by: Kristian H. Kristensen

[Mesa-dev] [PATCH v3 4/5] freedreno/a6xx: MSAA

2018-11-30 Thread Kristian H. Kristensen
From: Rob Clark Signed-off-by: Rob Clark --- .../drivers/freedreno/a6xx/fd6_blend.c| 2 + .../drivers/freedreno/a6xx/fd6_context.c | 2 + src/gallium/drivers/freedreno/a6xx/fd6_emit.c | 12 -- src/gallium/drivers/freedreno/a6xx/fd6_gmem.c | 41 +++

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
GCN calls it overrasterization multisampling, but it's really only useful for polygon smoothing, because there is no temporary buffer. Marek On Fri, Nov 30, 2018 at 3:35 PM Rob Clark wrote: > On Fri, Nov 30, 2018 at 3:25 PM Marek Olšák wrote: > > > > Suggestions: > > -

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/29/2018 07:47 AM, Connor Abbott wrote: > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: >> >> Can you provide some context for this? Those rules are already flagged >> "inexact" (that's what the ~ means) so they won't apply to anything that's >> "precise" or "invariant". > > I

Re: [Mesa-dev] Representing explicit memory layouts in NIR

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 4:39 PM Timothy Arceri wrote: > On 1/12/18 9:11 am, Jason Ekstrand wrote: > > All, > > > > This week, I've been working on trying to move UBO and SSBO access in > > NIR over to deref instructions. I'm hoping that this will allow us to > > start doing alias analysis and

Re: [Mesa-dev] [PATCH v3 2/5] gallium: Add new PIPE_CAP_SURFACE_SAMPLE_COUNT

2018-11-30 Thread Eric Anholt
"Kristian H. Kristensen" writes: > This new pipe cap and the new nr_samples field in pipe_surface lets a > state tracker bind a render target with a different sample count than > the resource. This allows for implementing > EXT_multisampled_render_to_texture and >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 3:37 PM Bas Nieuwenhuizen wrote: > On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand > wrote: > > > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > wrote: > >> > >> On 11/29/2018 07:47 AM, Connor Abbott wrote: > >> > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand >

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 4:34 PM Ian Romanick wrote: > On 11/30/2018 01:29 PM, Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick > > wrote: > > > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > > On Thu, Nov 29, 2018 at 4:22 PM Jason

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Ian Romanick
On 11/30/2018 01:36 PM, Bas Nieuwenhuizen wrote: > On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand wrote: >> >> On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: >>> >>> On 11/29/2018 07:47 AM, Connor Abbott wrote: On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > >

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Ian Romanick
On 11/29/2018 10:38 PM, Thomas Helland wrote: > Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : >> >> On 28/11/18 6:52 pm, Thomas Helland wrote: >>> Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri >>> : This adds allows loop analysis to detect inductions varibales that

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Timothy Arceri
On 30/11/18 5:38 pm, Thomas Helland wrote: Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : On 28/11/18 6:52 pm, Thomas Helland wrote: Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : This adds allows loop analysis to detect inductions varibales that are incremented in both

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund wrote: > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The _mesa_has_S3_s3tc() helper already > verifies the API according to the extension-table. > > Signed-off-by: Erik Faye-Lund > --- >

[Mesa-dev] [PATCH v3 1/5] mesa: Add core support for EXT_multisampled_render_to_texture{, 2}

2018-11-30 Thread Kristian H. Kristensen
This also turns on EXT_multisampled_render_to_texture which is a subset of EXT_multisampled_render_to_texture2, allowing only COLOR_ATTACHMENT0. Signed-off-by: Kristian H. Kristensen --- .../EXT_multisampled_render_to_texture.xml| 34 +++ src/mapi/glapi/gen/Makefile.am

[Mesa-dev] [PATCH v3 3/5] st/mesa: Add support for EXT_multisampled_render_to_texture

2018-11-30 Thread Kristian H. Kristensen
In gallium, we model the attachment sample count as a new nr_samples field in pipe_surface. A driver can indicate support for the extension using the new pipe cap, PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE. Signed-off-by: Kristian H. Kristensen --- src/mesa/state_tracker/st_cb_fbo.c | 3 +++

[Mesa-dev] [PATCH v3 5/5] freedreno: Add support for EXT_multisampled_render_to_texture

2018-11-30 Thread Kristian H. Kristensen
There is not much to do in freedreno - tile layout and multisample state for gmem renderings is programmed based on the pfb sample count, while resolve blits take the destination sample count from the resource. Signed-off-by: Kristian H. Kristensen ---

[Mesa-dev] [PATCH v3 0/5] EXT_multisampled_render_to_texture and MSAA for a6xx

2018-11-30 Thread Kristian H. Kristensen
Here's v3 of the series. I've updated to account for most of the comments, except I went back and forth and then ultimately back again on Roladnd suggestion. It may be more intuitive to always have surf->nr_samples be the number of samples but that means we'll have to go update all state

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
Suggestions: - PIPE_CAP_TILED_BASED_MSAA_OVERSAMPLING - pipe_surface::tile_based_oversample_count I'm assuming this feature isn't possible without tile-based rendering. Marek On Fri, Nov 30, 2018 at 1:23 PM Kristian Høgsberg wrote: > On Fri, Nov 30, 2018 at 10:17 AM Marek Olšák wrote: > > >

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-30 Thread Ian Romanick
On 11/30/2018 12:07 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 11/29/2018 03:53 PM, Eric Anholt wrote: >>> e<#secure method=pgpmime mode=sign> >>> Erik Faye-Lund writes: >>> On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: > Jordan Justen writes: > >> This adds

Re: [Mesa-dev] Representing explicit memory layouts in NIR

2018-11-30 Thread Timothy Arceri
On 1/12/18 9:11 am, Jason Ekstrand wrote: All, This week, I've been working on trying to move UBO and SSBO access in NIR over to deref instructions.  I'm hoping that this will allow us to start doing alias analysis and copy-propagation on it.  The passes we have in NIR *should* be able to

[Mesa-dev] [PATCH] android: amd/addrlib: update Mesa's copy of addrlib

2018-11-30 Thread Mauro Rossi
Needed to fix build error in addrlib in mesa for Android Fixes: 776b911 ("amd/addrlib: update Mesa's copy of addrlib") Signed-off-by: Mauro Rossi --- src/amd/Android.addrlib.mk | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/amd/Android.addrlib.mk

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick wrote: > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > > mailto:erik.faye-l...@collabora.com>> > wrote: > > > > S3_s3tc is the extension that enables this functionality on desktop, > so > >

[Mesa-dev] [PATCH] android: st/mesa: fix building error due to sched_getcpu()

2018-11-30 Thread Mauro Rossi
Android has cpufeatures library but pinning of threads is not supported PIPE_OS_LINUX code path causes build error due to sched_getcpu() unavailable thus we need to avoid setting HAVE_SCHED_GETCPU for Android Fixes: 48f2160 ("st/mesa: regularly re-pin driver threads to the CCX where the app

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Ian Romanick
On 11/30/2018 03:15 PM, Marek Olšák wrote: > On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick > wrote: > > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > >

Re: [Mesa-dev] [PATCH 03/30] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
Assuming you use _mesa_has_EXT_texture_compression_s3tc in the second hunk, the series is: Reviewed-by: Marek Olšák Marek On Mon, Nov 19, 2018 at 7:15 AM Erik Faye-Lund wrote: > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Thomas Helland
I've done a couple passes over the patches now. Neatly implemented and look correct to me. With the two small nitpicks below correct this whole series is: Reviewed-by: Thomas Helland Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : > > This adds allows loop analysis to detect inductions

Re: [Mesa-dev] [PATCH v2 00/29] do not allow invalid texture-format enums

2018-11-30 Thread Matt Turner
On Fri, Nov 30, 2018 at 4:46 AM Francesco Ansanelli wrote: > Il giorno ven 30 nov 2018, 12:26 Erik Faye-Lund > ha scritto: >> >> On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote: >> > OK, so here's a v2 of this series. These are the changes since v1: >> > - Removed double-semicolons in

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Ian Romanick
On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > mailto:erik.faye-l...@collabora.com>> wrote: > > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The _mesa_has_S3_s3tc() helper already >

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
I don't plan to expose the GCN functionality. If I wanted to, I would add the sample count into the rasterizer state, because it only affects gl_SampleMaskIn. Marek On Fri, Nov 30, 2018 at 5:12 PM Rob Clark wrote: > I guess as long as it is just a single draw, it works out to the same > thing.

Re: [Mesa-dev] [PATCH] android: st/mesa: fix building error due to sched_getcpu()

2018-11-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 30, 2018 at 7:03 PM Mauro Rossi wrote: > Android has cpufeatures library but pinning of threads is not supported > PIPE_OS_LINUX code path causes build error due to sched_getcpu() > unavailable > thus we need to avoid setting HAVE_SCHED_GETCPU for

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Bas Nieuwenhuizen
On Fri, Nov 30, 2018 at 10:29 PM Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: >> >> On 11/29/2018 07:47 AM, Connor Abbott wrote: >> > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand >> > wrote: >> >> >> >> Can you provide some context for this? Those rules are

Re: [Mesa-dev] Lets talk about autotools

2018-11-30 Thread Pekka Paalanen
On Thu, 29 Nov 2018 17:44:47 + Emil Velikov wrote: > Hi all, > > I can see why people may opt to not use or maintain the autotools build. > Although I would kindly ask that we do not remove it just yet. > > In Mesa, we have different parts not used by different teams. As such > we tend to

Re: [Mesa-dev] [PATCH] docs: Document and *require* usage of Signed-off-by

2018-11-30 Thread Jordan Justen
On 2018-11-29 15:53:09, Eric Anholt wrote: > e<#secure method=pgpmime mode=sign> > Erik Faye-Lund writes: > > > On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote: > >> Jordan Justen writes: > >> > >> > This adds the "Developer's Certificate of Origin 1.1" from the > >> > Linux > >> >

Re: [Mesa-dev] Lets talk about autotools

2018-11-30 Thread Gert Wollny
Hello all, Am Donnerstag, den 29.11.2018, 17:44 + schrieb Emil Velikov: > Hi all, > > I can see why people may opt to not use or maintain the autotools > build. Although I would kindly ask that we do not remove it just yet. I second that, I think the process of removing autotools should be

Re: [Mesa-dev] [PATCH 0/2] debug feature to dump "get configs" and "chosen configs"

2018-11-30 Thread Silvestrs Timofejevs
On Fri, Nov 09, 2018 at 06:04:10PM +, Silvestrs Timofejevs wrote: > This patch series provides an easy way to see what configs > have been returned by the 'eglGetConfigs' and 'eglChooseConfig' > functions, and give an overview of config attributes. > > Silvestrs Timofejevs (2): > egl:

Re: [Mesa-dev] [PATCH v2 00/29] do not allow invalid texture-format enums

2018-11-30 Thread Erik Faye-Lund
On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote: > OK, so here's a v2 of this series. These are the changes since v1: > - Removed double-semicolons in patch #25 > - Removed default-case and questionable comment in patch #25 > - Dropped patch #30, as it would regress functionality on two

Re: [Mesa-dev] [PATCH v2 00/29] do not allow invalid texture-format enums

2018-11-30 Thread Francesco Ansanelli
Il giorno ven 30 nov 2018, 12:26 Erik Faye-Lund < erik.faye-l...@collabora.com> ha scritto: > On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote: > > OK, so here's a v2 of this series. These are the changes since v1: > > - Removed double-semicolons in patch #25 > > - Removed default-case and

Re: [Mesa-dev] [PATCH 1/3] virgl: quadruple command buffer size

2018-11-30 Thread Erik Faye-Lund
On Thu, 2018-11-29 at 18:09 -0800, Gurchetan Singh wrote: > Thanks! Gentle ping for push from committers.. Pushed, thanks :) > On Mon, Nov 26, 2018 at 11:52 AM Erik Faye-Lund > wrote: > > On Mon, 2018-11-26 at 09:54 -0800, Gurchetan Singh wrote: > > > Tested running WebGL aquarium on Nvidia

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #3 from tempel.jul...@gmail.com --- Thanks for your quick reply. I can definitely try this, but since I'm not experienced in that, I can't promise to do it before the holidays. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] miptree: test ability to use upside down miptree

2018-11-30 Thread andrey simiklit
Hello, Could somebody take a look at this patch? Thanks a lot, Andrii. On Tue, Nov 6, 2018 at 12:33 PM andrey simiklit wrote: > Hi all, > > Have somebody some suggestions for this test? > This patch is needed to test an issue (assertion in mesa) which will be > fixed by this mesa patch: >

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 Bug ID: 108914 Summary: blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-30 Thread andrey simiklit
Hello, Could you please take a look on this v4 if it is possible? Thanks, Andrii. On Wed, Nov 14, 2018 at 6:30 PM wrote: > From: Andrii Simiklit > > 1. tools/i965_disasm.c:58:4: warning: > ignoring return value of ‘fread’, > declared with attribute warn_unused_result >

[Mesa-dev] [Bug 108900] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 Eero Tamminen changed: What|Removed |Added Priority|medium |high Severity|normal

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #1 from tempel.jul...@gmail.com --- Forgot to add the used versions: mesa-git 19.0.0_devel.105999.89b4798c06 llvm-svn 8.0.0svn_r347844 But happens also with latest stable versions. -- You are receiving this mail because: You are

[Mesa-dev] [Bug 108914] blocky shadow artifacts in The Forest with DXVK, RADV_DEBUG=nohiz fixes this

2018-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108914 --- Comment #2 from Samuel Pitoiset --- Thanks for the report. Can you try to record a renderdoc capture please? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Rob Clark
On Fri, Nov 30, 2018 at 3:25 PM Marek Olšák wrote: > > Suggestions: > - PIPE_CAP_TILED_BASED_MSAA_OVERSAMPLING > - pipe_surface::tile_based_oversample_count > > I'm assuming this feature isn't possible without tile-based rendering. I guess technically an IMR could do it, with an internal

Re: [Mesa-dev] Lets talk about autotools

2018-11-30 Thread Matt Turner
On Fri, Nov 30, 2018 at 2:28 AM Gert Wollny wrote: > Am Donnerstag, den 29.11.2018, 17:44 + schrieb Emil Velikov: > > Hi all, > > > > I can see why people may opt to not use or maintain the autotools > > build. Although I would kindly ask that we do not remove it just yet. > > I second that,

Re: [Mesa-dev] Lets talk about autotools

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 2:45 PM Matt Turner wrote: > On Fri, Nov 30, 2018 at 2:28 AM Gert Wollny wrote: > > Am Donnerstag, den 29.11.2018, 17:44 + schrieb Emil Velikov: > > > Hi all, > > > > > > I can see why people may opt to not use or maintain the autotools > > > build. Although I would

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-11-30 Thread Jason Ekstrand
On Fri, Nov 30, 2018 at 3:18 PM Ian Romanick wrote: > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand > wrote: > >> > >> Can you provide some context for this? Those rules are already flagged > "inexact" (that's what the ~ means) so they won't

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Rob Clark
I guess as long as it is just a single draw, it works out to the same thing. Maybe to expose the GCN functionality we could do something like PIPE_CAP_SURFACE_SAMPLE_COUNT: 0 - unsupported 1 - msaa per draw 2 - msaa per renderpass ?? BR, -R On Fri, Nov 30, 2018 at 3:41 PM Marek