Re: [Mesa-dev] [PATCH 02/10] intel/fs: Implement quad swizzles on ICL+.

On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: > Align16 is no longer a thing, so a new implementation is provided > using Align1 instead. Not all possible swizzles can be represented > as > a single Align1 region, but some fast paths are provided for > frequently used swizzles that

Re: [Mesa-dev] [PATCH 08/10] intel/fs: Remove existing lower_conversions pass.

On Sat, 2018-12-29 at 12:39 -0800, Francisco Jerez wrote: > It's redundant with the functionality provided by lower_regioning > now. > --- > src/intel/Makefile.sources| 1 - > src/intel/compiler/brw_fs.cpp | 1 - > src/intel/compiler/brw_fs.h

[Mesa-dev] [PATCH 4/6] anv/blorp: Refactor MSAA resolves into an exportable helper function

This function is modeled after the aux_op functions except that it has a lot more parameters because it deals with two images as well as source and destination regions. --- src/intel/vulkan/anv_blorp.c | 225 ++--- src/intel/vulkan/anv_private.h | 14 ++ 2 files

[Mesa-dev] [PATCH 2/6] intel/blorp: Add two more filter modes

--- src/intel/blorp/blorp.h | 2 ++ src/intel/blorp/blorp_blit.c | 62 +--- 2 files changed, 52 insertions(+), 12 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 1e22712602d..bb83650092a 100644 --- a/src/intel/blorp/blorp.h

Re: [Mesa-dev] [PATCH] radv: skip draws with instance_count == 0

On 1/7/19 2:53 PM, Bas Nieuwenhuizen wrote: On Mon, Jan 7, 2019 at 2:45 PM Samuel Pitoiset wrote: Loosely based on RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 03/12] nir/vtn: add caps for some cl related capabilities

On Tue, Dec 4, 2018 at 12:26 PM Karol Herbst wrote: > From: Rob Clark > > vtn supports these, so don't squalk if user is happy with enabling > these. > > Signed-off-by: Karol Herbst > --- > src/compiler/shader_info.h | 3 +++ > src/compiler/spirv/spirv_to_nir.c | 17

Re: [Mesa-dev] [PATCH 1/6] vulkan: Update the XML and headers to 1.1.97

Acked-by: Samuel Pitoiset On 1/7/19 4:39 PM, Jason Ekstrand wrote: --- include/vulkan/vulkan.h | 2 +- include/vulkan/vulkan_android.h | 2 +- include/vulkan/vulkan_core.h| 155 +++- include/vulkan/vulkan_fuchsia.h | 2 +-

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote: > On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote: > > Correct a typo introduced by > > 037f68d81e1 ("glsl: apply align layout qualifier rules to block > > offsets") > > > > Cc: Timothy Arceri > > Signed-off-by: Andres Gomez > >

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

On 1/7/19 8:44 AM, Tapani Pälli wrote: > > On 1/4/19 11:56 PM, Kevin Strasser wrote: > >> While I have run this series against Piglit, I still need to sort out > >> test coverage for these formats. If anyone has pointers to existing > >> tests that would be really helpful. > > > > dEQP (EGL

[Mesa-dev] [PATCH 1/3] radv: remove unnecessary return in GetPhysicalDeviceMemoryProperties2()

This function returns nothing. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 53aed1a15db..39bd47348a9 100644 ---

[Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

A simple Vulkan extension that allows apps to query size and usage of all exposed memory heaps. The different usage values are not really accurate because they are per drm-fd, but they should be close enough. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 44

[Mesa-dev] [PATCH 2/3] radv: add two small helpers for getting VRAM and visible VRAM sizes

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 39bd47348a9..cef3a430555 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [Bug 108594] [RADV] Graphics distortion in Evil within 1 if reflections enabled

https://bugs.freedesktop.org/show_bug.cgi?id=108594 --- Comment #4 from Rhys Perry --- https://reviews.llvm.org/rL350532 seems to fix the The Evil Within issue for myself. Can you confirm that it fixes it for you? Can you also see if that commit fixes the NFS Payback issue? -- You are

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

Hi, Did you get a chance try this? If not, I might be able to try it myself as I have Intel HW. On 12/19/18 12:34 PM, Lionel Landwerlin wrote: Hey Jonathan, I'm kind of curious as to whether we can have a single expression that pretty much generates the same final code (through some of the

Re: [Mesa-dev] [PATCH 06/12] nir/spirv: handle SpvStorageClassCrossWorkgroup

This seems reasonable. However, I'd like to ask that you land patch 5 ASAP and wait a little while on landing this one. Having a at least couple weeks with the rename but without adding back in nir_var_global with a different meaning will increase the liklihood that merge conflicts will result

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

Hi Samuel, Thanks for implementing this - I've been wanting this extension for a while so it's good it's finally available. This is just reporting the total heap sizes as the budget, which is the same info we already get from the basic heap properties. The way I'd expected budget to work (and

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 Bug ID: 109242 Summary: [RADV] The Witcher 3 system freeze Product: Mesa Version: 18.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #1 from Samuel Pitoiset --- Does this is a recent regression for you? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [PATCH 1/6] vulkan: Update the XML and headers to 1.1.97

--- include/vulkan/vulkan.h | 2 +- include/vulkan/vulkan_android.h | 2 +- include/vulkan/vulkan_core.h| 155 +++- include/vulkan/vulkan_fuchsia.h | 2 +- include/vulkan/vulkan_ios.h | 2 +- include/vulkan/vulkan_macos.h | 2

[Mesa-dev] [PATCH 5/6] anv: Move resolve_subpass to genX_cmd_buffer.c

We may have to do transitions around certain kinds of resolves so it helps to have it genX code. --- src/intel/vulkan/anv_blorp.c | 66 -- src/intel/vulkan/anv_private.h | 2 - src/intel/vulkan/genX_cmd_buffer.c | 61 ++- 3 files

[Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

--- src/intel/vulkan/anv_device.c | 28 ++ src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pass.c| 37 +++- src/intel/vulkan/anv_private.h | 3 + src/intel/vulkan/genX_cmd_buffer.c | 136 + 5 files changed, 204

[Mesa-dev] [PATCH 3/6] anv: Rename has_resolve to has_color_resolve

--- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/anv_pass.c| 4 ++-- src/intel/vulkan/anv_private.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 478b8e7a3db..eee7a8c3b3c 100644 ---

[Mesa-dev] [PATCH 2/2] anv: Sort properties and features switch statements

--- src/intel/vulkan/anv_device.c | 84 +-- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 2a3919d2949..cd179e6801c 100644 --- a/src/intel/vulkan/anv_device.c +++

[Mesa-dev] [PATCH 1/2] spirv: Sort supported capabilities

--- src/amd/vulkan/radv_shader.c| 24 - src/compiler/shader_info.h | 34 - src/intel/vulkan/anv_pipeline.c | 18 ++--- src/mesa/drivers/dri/i965/brw_context.c | 10 4 files changed, 43 insertions(+), 43

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

Assuming it builds everywhere (probably best to double-check before pushing anything) Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within SPIR-V > "global" memory is memory accessible from all

Re: [Mesa-dev] [PATCH 04/12] nir/spirv: improve parsing of the memory model

On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/nir/nir.h| 8 > src/compiler/nir/nir_clone.c | 1 + > src/compiler/nir/nir_serialize.c | 2 ++ > src/compiler/spirv/spirv_to_nir.c | 26

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On 14/12/2018 19:22, Jon Turney wrote: On 14/12/2018 15:15, Emil Velikov wrote: On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote: > Correct a typo introduced by > 037f68d81e1 ("glsl: apply align layout qualifier rules to block > offsets") > > Cc: Timothy Arceri > Signed-off-by: Andres Gomez This should probably have this tag: Fixes: 037f68d81e1 "glsl: apply align

[Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

As suggested by Emil Velikov. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 10 ++ docs/releasing.html| 14 -- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: > > > > On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: > > On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli wrote: > >> > >> > >> > >> On 12/5/18 1:44 PM, Bas Nieuwenhuizen wrote: > >>> On Wed, Dec 5, 2018 at 12:37 PM Tapani Pälli > >>> wrote: >

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On Mon, Jan 7, 2019 at 11:54 AM Tapani Pälli wrote: > > > > On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: > > On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: > >> > >> > >> > >> On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: > >>> On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli > >>> wrote: >

Re: [Mesa-dev] [PATCHv2 07/10] intel/fs: Introduce regioning lowering pass.

On Sat, 2019-01-05 at 14:03 -0800, Francisco Jerez wrote: > This legalization pass is meant to handle situations where the source > or destination regioning controls of an instruction are unsupported > by > the hardware and need to be lowered away into separate instructions. > This should be more

[Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

Correct a typo introduced by 037f68d81e1 ("glsl: apply align layout qualifier rules to block offsets") Cc: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH] glsl/linker: specify proper direction in location aliasing error

The check for location aliasing was always asuming output variables but this validation is also called for input variables. Fixes: e2abb75b0e4 ("glsl/linker: validate explicit locations for SSO programs") Cc: Iago Toral Quiroga Signed-off-by: Andres Gomez ---

[Mesa-dev] [PATCH] editorconfig: Add max_line_length property

The property is supported by the most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez --- .editorconfig | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 1/7/19 1:28 PM, Bas Nieuwenhuizen wrote: On Mon, Jan 7, 2019 at 11:54 AM Tapani Pälli wrote: On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli

Re: [Mesa-dev] [PATCH] radv: skip draws with instance_count == 0

On Mon, Jan 7, 2019 at 2:45 PM Samuel Pitoiset wrote: > > Loosely based on RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c >

Re: [Mesa-dev] [PATCH] etnaviv_screen: Fix typo in cflush_all description

Am Mo., 7. Jan. 2019 um 15:00 Uhr schrieb Guido Günther : > > Signed-off-by: Guido Günther Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c

Re: [Mesa-dev] [PATCH 05/10] intel/fs: Respect CHV/BXT regioning restrictions in copy propagation pass.

On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: > Currently the visitor attempts to enforce the regioning restrictions > that apply to double-precision instructions on CHV/BXT at NIR-to-i965 > translation time. It is possible though for the copy propagation > pass > to violate this

Re: [Mesa-dev] [RFC 0/6] Enable fp16 visuals and fbconfigs

On 1/7/19 8:44 AM, Tapani Pälli wrote: Hi; On 1/4/19 11:56 PM, Kevin Strasser wrote: This series enables fp16 fbconfigs and visuals by leveraging existing off-screen rendering support. These formats can be used in conjunction with EXT_surface_SMPTE2086_metadata (not yet implemented by

Re: [Mesa-dev] NIR documentation (was: NIR constant problem for GPU which doesn't have native integer support)

Hi, On 7.1.2019 12.42, Erik Faye-Lund wrote: On Fri, 2019-01-04 at 09:40 -0600, Jason Ekstrand wrote: [...] Yeah... Patches welcome? There have been many attempts by Connor and myself to better document NIR. They all end up in /dev/null due to EBIGGERFIRES. :-( That said, if you ever want

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On Mon, Jan 7, 2019 at 1:23 PM Tapani Pälli wrote: > > > > On 1/7/19 1:28 PM, Bas Nieuwenhuizen wrote: > > On Mon, Jan 7, 2019 at 11:54 AM Tapani Pälli wrote: > >> > >> > >> > >> On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: > >>> On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli > >>> wrote: >

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

Emil, the 18.3.2 should have already happened by the 19th of December. Is there anything stopping you from going ahead with it? I've also noticed that there is a 3 weeks gap (instead of 2) from 18.3.2 to 18.3.3. I suppose you decided that due to most of the people being on XMas and New Year

[Mesa-dev] [PATCH] etnaviv_screen: Fix typo in cflush_all description

Signed-off-by: Guido Günther --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index fb51aa5f4e8..fd320232528 100644 ---

Re: [Mesa-dev] [PATCH 03/10] intel/fs: Fix bug in lower_simd_width while splitting an instruction which was already split.

On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: > This seems to be a problem in combination with the lower_regioning > pass introduced by a future commit, which can modify a SIMD-split > instruction causing its execution size to become illegal again. A > subsequent call to

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

On Fri, 2019-01-04 at 09:40 -0600, Jason Ekstrand wrote: > On Fri, Jan 4, 2019 at 4:07 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > On Thu, 2019-01-03 at 11:58 -0600, Jason Ekstrand wrote: > > > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund < > > > erik.faye-l...@collabora.com>

Re: [Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

On 1/7/19 11:56 AM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 1:05 PM Tapani Pälli wrote: On 12/5/18 2:00 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:51 PM Tapani Pälli wrote: On 12/5/18 1:44 PM, Bas Nieuwenhuizen wrote: On Wed, Dec 5, 2018 at 12:37 PM Tapani Pälli

Re: [Mesa-dev] [PATCH] radv: Implement buffer stores with less than 4 components.

Reviewed-by: Samuel Pitoiset On 12/24/18 3:43 PM, Bas Nieuwenhuizen wrote: We started using it in the btoi paths for r32g32b32, and the LLVM IR checker will complain about it because we end up with intrinsics with the wrong type extension in the name. Fixes: 593996bc02 ("radv: implement

[Mesa-dev] [PATCH] radv: skip draws with instance_count == 0

Loosely based on RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 1966098e08c..8e3f1a7f5f0 100644 ---

Re: [Mesa-dev] [PATCH 05/10] intel/fs: Respect CHV/BXT regioning restrictions in copy propagation pass.

Iago Toral writes: > On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: >> Currently the visitor attempts to enforce the regioning restrictions >> that apply to double-precision instructions on CHV/BXT at NIR-to-i965 >> translation time. It is possible though for the copy propagation >>

Re: [Mesa-dev] [RFC] clover/meson: Ignore 'svn' suffix when computing CLANG_RESOURCE_DIR

On 2019-01-07 — 11:34, Dylan Baker wrote: [snip] > I think you can just use dep_llvm.version() now, which does split the 'svn' or > 'git' off the end already. When this was written it didn't do that. Thanks, it does indeed work and feels way less hacky than my split; I’ll send a v2 shortly.

[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv

https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #14 from Brandon Wright --- (In reply to oschowa from comment #13) > With this patch applied it works correctly again, thanks! Also confirmed here. -- You are receiving this mail because: You are the QA Contact for the bug. You

Re: [Mesa-dev] [Mesa-stable] [PATCH 02/10] intel/fs: Implement quad swizzles on ICL+.

Iago Toral writes: > On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: >> Align16 is no longer a thing, so a new implementation is provided >> using Align1 instead. Not all possible swizzles can be represented >> as >> a single Align1 region, but some fast paths are provided for >>

Re: [Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > With OpenCL some system values match the address bits, but in GLSL we also > have some system values being 64 bit like subgroup masks. > > With this it is possible to adjust the builder functions so that depending > on the bit_sizes the

[Mesa-dev] [PATCH] radeonsi: Fix use of 1- or 2- component GL_DOUBLE vbo's.

With Mesa 18.1, commit be973ed21f6e, si_llvm_load_input_vs() changed the number of source 32-bit wide dword components used for fetching vertex attributes into the vertex shader from a constant 4 to a variable num_channels number, depending on input data format, with some special case handling for

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

On Mon, Jan 7, 2019 at 6:20 PM Samuel Pitoiset wrote: > > > On 1/7/19 6:06 PM, Alex Smith wrote: > > Hi Samuel, > > Thanks for implementing this - I've been wanting this extension for a while > so it's good it's finally available. > > This is just reporting the total heap sizes as the budget,

Re: [Mesa-dev] [PATCH 2/3] ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri wrote: > The following patch will use this with the radeonsi NIR backend > but I've added it to ac so we can use it with RADV in future. > > This is a NIR implementation of the tgsi function > tgsi_scan_tess_ctrl(). > --- >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Fix use of 1- or 2- component GL_DOUBLE vbo's.

Reviewed-by: Marek Olšák Marek On Mon, Jan 7, 2019 at 1:42 PM Mario Kleiner wrote: > With Mesa 18.1, commit be973ed21f6e, si_llvm_load_input_vs() > changed the number of source 32-bit wide dword components > used for fetching vertex attributes into the vertex shader > from a constant 4 to a

Re: [Mesa-dev] [PATCHv2 07/10] intel/fs: Introduce regioning lowering pass.

Iago Toral writes: > On Sat, 2019-01-05 at 14:03 -0800, Francisco Jerez wrote: >> This legalization pass is meant to handle situations where the source >> or destination regioning controls of an instruction are unsupported >> by >> the hardware and need to be lowered away into separate

[Mesa-dev] [PATCH v2] clover/meson: Ignore 'svn' suffix when computing CLANG_RESOURCE_DIR

The version exported by LLVM in its CMake configuration files can include the “svn” suffix when building a development version (for example “8.0.0svn”). However the exported clang headers are still found under “lib/clang/8.0.0/”, without the “svn” suffix. Meson takes care of removing the “svn”

[Mesa-dev] [PATCH] winsys/amdgpu: use the new BO list API

From: Marek Olšák --- I'll bump the libdrm version requirement after the libdrm patch lands. src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 74 --- 1 file changed, 25 insertions(+), 49 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

Re: [Mesa-dev] [PATCH 08/10] intel/fs: Remove existing lower_conversions pass.

Iago Toral writes: > On Sat, 2018-12-29 at 12:39 -0800, Francisco Jerez wrote: >> It's redundant with the functionality provided by lower_regioning >> now. >> --- >> src/intel/Makefile.sources| 1 - >> src/intel/compiler/brw_fs.cpp | 1 - >>

Re: [Mesa-dev] [PATCH] editorconfig: Add max_line_length property

Quoting Andres Gomez (2019-01-07 05:49:00) > The property is supported by the most of the editors, but not all: > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length > > Cc: Eric Engestrom > Cc: Eric Anholt > Signed-off-by: Andres Gomez > --- >

Re: [Mesa-dev] [PATCH 10/12] nir: add bit_size parameter to system values with multiple allowed bit sizes

First off, thank you very much for cleaning this up! On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/nir/nir_builder_opcodes_h.py | 14 -- > src/compiler/nir/nir_lower_system_values.c| 4 ++-- >

Re: [Mesa-dev] [PATCH 11/12] nir: add support for address bit sized system values

On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/amd/vulkan/radv_meta_buffer.c | 8 ++-- > src/amd/vulkan/radv_meta_bufimage.c| 28 +++--- > src/amd/vulkan/radv_meta_clear.c | 4 +- >

Re: [Mesa-dev] [PATCH 03/10] intel/fs: Fix bug in lower_simd_width while splitting an instruction which was already split.

Iago Toral writes: > On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: >> This seems to be a problem in combination with the lower_regioning >> pass introduced by a future commit, which can modify a SIMD-split >> instruction causing its execution size to become illegal again. A >>

Re: [Mesa-dev] [PATCH v2] clover/meson: Ignore 'svn' suffix when computing CLANG_RESOURCE_DIR

Quoting Pierre Moreau (2019-01-07 12:30:17) > The version exported by LLVM in its CMake configuration files can > include the \u201csvn\u201d suffix when building a development version (for > example \u201c8.0.0svn\u201d). However the exported clang headers are still > found > under

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

On 1/7/19 6:06 PM, Alex Smith wrote: Hi Samuel, Thanks for implementing this - I've been wanting this extension for a while so it's good it's finally available. This is just reporting the total heap sizes as the budget, which is the same info we already get from the basic heap properties.

Re: [Mesa-dev] [PATCH 1/2] spirv: Sort supported capabilities

This and the other patch are Reviewed-by: Caio Marcelo de Oliveira Filho On Mon, Jan 07, 2019 at 10:53:09AM -0600, Jason Ekstrand wrote: > --- > src/amd/vulkan/radv_shader.c| 24 - > src/compiler/shader_info.h | 34 - >

Re: [Mesa-dev] [PATCH 12/12] nir/spirv: handle ContractionOff execution mode

Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/spirv_info.h| 1 + > src/compiler/spirv/spirv_info_c.py | 1 + > src/compiler/spirv/spirv_to_nir.c | 9 - > src/compiler/spirv/vtn_alu.c

Re: [Mesa-dev] [RFC] clover/meson: Ignore 'svn' suffix when computing CLANG_RESOURCE_DIR

Quoting Pierre Moreau (2019-01-06 05:06:04) > The version exported by LLVM in its CMake configuration files can include > the \u201csvn\u201d suffix when building a development version (for example > \u201c8.0.0svn\u201d). However the exported clang headers are still found > under >

[Mesa-dev] [Bug 109021] Kaveri no fix perfomance

https://bugs.freedesktop.org/show_bug.cgi?id=109021 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |NOTABUG

[Mesa-dev] [Bug 109021] Kaveri no fix perfomance

https://bugs.freedesktop.org/show_bug.cgi?id=109021 --- Comment #8 from Dmitry --- OK. Then close. Hopefully pay attention to another important bug report. https://bugs.freedesktop.org/show_bug.cgi?id=109015 -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #2 from Dmitry --- Before that, there were no heavy loads, and hangs during active combat. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109140] [KBL-G][GL] KHR-GL43.compute_shader.max test failed

https://bugs.freedesktop.org/show_bug.cgi?id=109140 Hai changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 109021] Kaveri no fix perfomance

https://bugs.freedesktop.org/show_bug.cgi?id=109021 --- Comment #9 from Dmitry --- More precisely this, sorry. https://bugs.freedesktop.org/show_bug.cgi?id=109017 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

I did not but then saw someone pointed out an issue with this particular patch. I can do tomorrow. Do you have link to the updated series? Thanks, - Lionel On 07/01/2019 16:54, Jonathan Marek wrote: Hi, Did you get a chance try this? If not, I might be able to try it myself as I have Intel

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

On 8/1/19 2:51 am, Andres Gomez wrote: On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote: On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote: Correct a typo introduced by 037f68d81e1 ("glsl: apply align layout qualifier rules to block offsets") Cc: Timothy Arceri Signed-off-by:

[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv

https://bugs.freedesktop.org/show_bug.cgi?id=109204 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109151] [KBL-G][vulkan] dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_nearest_repeat failed verification.

https://bugs.freedesktop.org/show_bug.cgi?id=109151 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] meson: fix EGL/X11 build without GLX

dep_xcb and others were not set under this configuration. Signed-off-by: Chia-I Wu --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 709f77a9c7..601085e055 100644 --- a/meson.build +++ b/meson.build @@ -1361,7 +1361,7 @@ if

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: add missing parentheses in get_inst_tessfactor_writemask()

On 8/1/19 10:50 am, Bas Nieuwenhuizen wrote: I think this got fixed by https://gitlab.freedesktop.org/mesa/mesa/commit/be6cee51c06dc72ac159bd75b4201c61952515bd already? ok thanks. Hadn't pulled that one in yet. On Tue, Jan 8, 2019 at 12:28 AM Timothy Arceri wrote: Cc: Marek Olšák ---

[Mesa-dev] [shaderdb 2/2] intel_stub: update stubbing logic for newer mesa

DRI2 backend of Mesa started relying more on libdrm to open DRM devices nodes and opening multiple fds on a single node. This change keeps track of up to 10 fds so that stub works again. Signed-off-by: Lionel Landwerlin --- intel_stub.c | 98 +---

[Mesa-dev] [shaderdb 0/2] Intel fixes

We need a custom stub to run shaderdb and this was somewhat broken with newer versions of Mesa. Cheers, Lionel Landwerlin (2): run: fix uninitialized value intel_stub: update stubbing logic for newer mesa intel_stub.c | 98 +--- run.c

[Mesa-dev] [shaderdb 1/2] run: fix uninitialized value

Signed-off-by: Lionel Landwerlin --- run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.c b/run.c index 1e415c9..f3e65a3 100644 --- a/run.c +++ b/run.c @@ -837,7 +837,7 @@ main(int argc, char **argv) enum shader_type type; unsigned

Re: [Mesa-dev] [PATCH] meson: fix EGL/X11 build without GLX

Quoting Chia-I Wu (2019-01-07 12:54:19) > dep_xcb and others were not set under this configuration. > > Signed-off-by: Chia-I Wu > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 709f77a9c7..601085e055 100644 > ---

[Mesa-dev] [PATCH] ac/nir_to_llvm: add missing parentheses in get_inst_tessfactor_writemask()

Cc: Marek Olšák --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 84dbe17457..c9e11142eb 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: add missing parentheses in get_inst_tessfactor_writemask()

I think this got fixed by https://gitlab.freedesktop.org/mesa/mesa/commit/be6cee51c06dc72ac159bd75b4201c61952515bd already? On Tue, Jan 8, 2019 at 12:28 AM Timothy Arceri wrote: > > Cc: Marek Olšák > --- > src/amd/common/ac_nir_to_llvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH] freedreno/drm: sync uapi again

"pad" was missing in Mesa's msm_drm.h. sizeof(drm_msm_gem_info) remains the same, but now the compiler initializes the field to zero. Buffer allocation results in EINVAL without this for me. Cc: Rob Clark Cc: Kristian Høgsberg Signed-off-by: Chia-I Wu --- src/freedreno/drm/msm_drm.h | 1 +

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

There's no updated series yet. This patch will work on its own and the issue that was pointed out doesn't affect behavior at all. On 1/7/19 4:47 PM, Lionel Landwerlin wrote: I did not but then saw someone pointed out an issue with this particular patch. I can do tomorrow. Do you have link to

Re: [Mesa-dev] [PATCH 2/3] ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

On 8/1/19 6:43 am, Marek Olšák wrote: On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri > wrote: The following patch will use this with the radeonsi NIR backend but I've added it to ac so we can use it with RADV in future. This is a NIR implementation

Re: [Mesa-dev] [PATCH] glsl/linker: specify proper direction in location aliasing error

Reviewed-by: Timothy Arceri On 8/1/19 1:11 am, Andres Gomez wrote: The check for location aliasing was always asuming output variables but this validation is also called for input variables. Fixes: e2abb75b0e4 ("glsl/linker: validate explicit locations for SSO programs") Cc: Iago Toral

Re: [Mesa-dev] [PATCH] freedreno/drm: sync uapi again

Reviewed-by: Kristian H. Kristensen On Mon, Jan 7, 2019 at 4:27 PM Chia-I Wu wrote: > > "pad" was missing in Mesa's msm_drm.h. sizeof(drm_msm_gem_info) > remains the same, but now the compiler initializes the field to > zero. > > Buffer allocation results in EINVAL without this for me. > > Cc:

Re: [Mesa-dev] [PATCH] etnaviv: implement check_resource_capability

Hi Christian, Am Freitag, den 28.12.2018, 11:04 +0100 schrieb Christian Gmeiner: > Am Di., 18. Dez. 2018 um 19:09 Uhr schrieb Lucas Stach > : > > > > We try to avoid sharing all resources with KMS side of renderonly, as this > > adds some overhead that isn't really needed for most resources. If

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

On Sun, Dec 23, 2018 at 12:55 AM Roland Scheidegger wrote: > > Alright, I guess it should work... > > Reviewed-by: Roland Scheidegger > Thanks! Would we have anyone who could help to commit it? (I know that I was supposed to apply for commit rights, but I expect my contribution rate to be

Re: [Mesa-dev] Chromium - Application-level nouveau blacklist

On Sat, Jan 5, 2019 at 11:37 PM Jason Ekstrand wrote: > > On Sat, Jan 5, 2019 at 2:40 PM Ilia Mirkin wrote: >> >> It looks like as of Chromium 71, nouveau is completely blacklisted. > > > That's rather unfortunate. :-( The intel mesa drivers were also blacklisted > for quite some time a while

Re: [Mesa-dev] [PATCH 08/10] intel/fs: Remove existing lower_conversions pass.

On Mon, 2019-01-07 at 12:02 -0800, Francisco Jerez wrote: > Iago Toral writes: > > > On Sat, 2018-12-29 at 12:39 -0800, Francisco Jerez wrote: > > > It's redundant with the functionality provided by lower_regioning > > > now. > > > --- > > > src/intel/Makefile.sources| 1 -

Re: [Mesa-dev] [PATCH 03/10] intel/fs: Fix bug in lower_simd_width while splitting an instruction which was already split.

Iago Toral writes: > On Mon, 2019-01-07 at 11:58 -0800, Francisco Jerez wrote: >> Iago Toral writes: >> >> > On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: >> > > This seems to be a problem in combination with the >> > > lower_regioning >> > > pass introduced by a future commit,

Re: [Mesa-dev] [PATCH 03/10] intel/fs: Fix bug in lower_simd_width while splitting an instruction which was already split.

On Mon, 2019-01-07 at 11:58 -0800, Francisco Jerez wrote: > Iago Toral writes: > > > On Sat, 2018-12-29 at 12:38 -0800, Francisco Jerez wrote: > > > This seems to be a problem in combination with the > > > lower_regioning > > > pass introduced by a future commit, which can modify a SIMD-split >

Re: [Mesa-dev] Assorted bug fixes and improvements back-ported from an internal branch.

With the few changes we agreed during the review this series is: Reviewed-by: Iago Toral Quiroga Jason, just in case you didn't follow: this series adds a regioning lowering pass that will do exactly one of the things you suggested when we were discussing how to improve handling of hardware

  1   2   >