Re: [Mesa-dev] Can't get OpenGL 3.x inside VMware Workstation 12 (Ubuntu guest)

2015-11-11 Thread Thomas Hellstrom
On 11/11/2015 07:07 PM, Brian Paul wrote: > On 11/11/2015 10:44 AM, Emil Velikov wrote: >> On 11 November 2015 at 16:48, Brian Paul wrote: >>> On 11/11/2015 08:44 AM, Emil Velikov wrote: >> I have seen similar type of documents in the past, most of which going out of date very quick

Re: [Mesa-dev] Can't get OpenGL 3.x inside VMware Workstation 12 (Ubuntu guest)

2015-11-11 Thread Thomas Hellstrom
On 11/11/2015 08:51 PM, Brian Paul wrote: > On 11/11/2015 11:38 AM, Emil Velikov wrote: >> On 11 November 2015 at 18:25, Thomas Hellstrom >> wrote: >>> On 11/11/2015 07:07 PM, Brian Paul wrote: >>>> On 11/11/2015 10:44 AM, Emil Velikov wrote: >>>>&

[Mesa-dev] vdpau_interop extension oddities

2017-02-01 Thread Thomas Hellstrom
Hi, Christian, I'm looking through the mesa vdpau interop code and found something that looks strange to me: (dmabuf part) For video surfaces, it looks like vdpau exports a handle to a 2D_ARRAY texture. Later in the mesa state tracker, that handle is used to back a "fake" single slice 2D texture

Re: [Mesa-dev] vdpau_interop extension oddities

2017-02-01 Thread Thomas Hellstrom
back from me before Monday. > > Am 01.02.2017 um 15:56 schrieb Thomas Hellstrom: >> Hi, Christian, >> >> I'm looking through the mesa vdpau interop code and found something that >> looks strange to me: >> >> (dmabuf part) >> >> For video

Re: [Mesa-dev] vdpau_interop extension oddities

2017-02-01 Thread Thomas Hellstrom
Hi, Again, (No need answering while on sick leave!). On 02/01/2017 04:39 PM, Thomas Hellstrom wrote: > Hi, Christian! > > Thanks for your reply. I'll look through the code again! > > /Thomas > > > On 02/01/2017 04:22 PM, Christian König wrote: >> Hi Thomas, &g

Re: [Mesa-dev] vdpau_interop extension oddities

2017-02-01 Thread Thomas Hellstrom
On 02/01/2017 04:54 PM, Christian König wrote: > Am 01.02.2017 um 16:50 schrieb Thomas Hellstrom: >> Hi, Again, >> >> (No need answering while on sick leave!). > > Actually I'm bored, but can't concentrate on coding when my body > temperature isn't in t

[Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-21 Thread Thomas Hellstrom
A couple of fixes / improvements for things I've encountered while looking through and testing the video code in preparation for a virtual hardware video driver. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH 4/8] gallium/vl Fix brightness matrix description

2017-02-21 Thread Thomas Hellstrom
The brightness matrix doesn't actually match the procamp matrix and what's calculated in vl_csc_get_matrix. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/vl/vl_csc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 3/8] gallium/vl: Don't map vertex buffers on creation

2017-02-21 Thread Thomas Hellstrom
It will cause multiple simultaneous maps of the same vertex buffer and flushed-while-mapped warnings. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_vertex_buffers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/vl

[Mesa-dev] [PATCH 5/8] gallium/vl: Simplify usage of full range matrices

2017-02-21 Thread Thomas Hellstrom
27;s VDPAU implementation. We can also incorporate the ybias in the brightness simplifying the calculation somewhat. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/vl/vl_csc.c | 55 --- 1 file changed, 17 insertions(+), 38

[Mesa-dev] [PATCH 7/8] st/vdpau: Fix multithreading

2017-02-21 Thread Thomas Hellstrom
hat's really the best option. Signed-off-by: Thomas Hellstrom Acked-by: Sinclair Yeh --- src/gallium/state_trackers/vdpau/decode.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/decode.c b/src/gallium/state_trac

[Mesa-dev] [PATCH 6/8] gallium/vl: Parameter substitution in the csc matrix computation

2017-02-21 Thread Thomas Hellstrom
Makes the code significantly more readable. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/vl/vl_csc.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_csc.c b/src/gallium

[Mesa-dev] [PATCH 2/8] gallium/vl: Add sampler views to video filter fragment shaders

2017-02-21 Thread Thomas Hellstrom
Needed for at least the svga driver. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 5 + src/gallium/auxiliary/vl/vl_matrix_filter.c | 5 + src/gallium/auxiliary/vl/vl_median_filter.c | 5 + 3 files changed, 15

[Mesa-dev] [PATCH 1/8] gallium/vl: declare sampler views in compositor shaders

2017-02-21 Thread Thomas Hellstrom
The svga driver relies on the existence of these sampler views. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_compositor.c | 37 +++- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/vl

[Mesa-dev] [PATCH 8/8] gallium/vl: Simplify the matrix filter fragment shader

2017-02-21 Thread Thomas Hellstrom
It looks like it was partly copied from the median filter fragment shader and unnecessesarily saved a lot of temporary values. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/vl/vl_matrix_filter.c | 56 + 1 file changed, 16

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 09:56 AM, Christian König wrote: > Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: >> A couple of fixes / improvements for things I've encountered while >> looking >> through and testing the video code in preparation for a virtual >> hardware

[Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

2017-02-22 Thread Thomas Hellstrom
her we can instead do an YV12 to NV12 format conversion. Also advertize that we actually can do the getBits and putBits conversion. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- src/gallium/auxiliary/util/u_video.h | 42 + src/gallium/state_trackers/vdp

[Mesa-dev] [PATCH 2/2] st/va: Fix up YV12 to NV12 putImage conversion

2017-02-22 Thread Thomas Hellstrom
Use the utility u_copy_nv12_from_yv12 to implement this similarly to how it's been done in the VPAU state tracker. The old code mixed up planes and fields and didn't correctly handle video surfaces in interlaced format. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 03:00 PM, Christian König wrote: > Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom: >> mplayer likes putting YV12 data, and if there is a buffer format >> mismatch, >> the vdpau state tracker would try to reallocate the video surface as an >> YV12 surfac

[Mesa-dev] [PATCH 1/2] st/vdpau: Provide YV12 to NV12 putBits conversion v2

2017-02-22 Thread Thomas Hellstrom
NV12 conversion instead. Also advertize that we actually can do the getBits and putBits conversion. v2: A previous version of this patch prioritized conversion before reallocating. This has been changed to prioritize reallocating in this version. Cc: Christian König Signed-off-by: Thomas Hell

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 04:00 PM, Emil Velikov wrote: > On 22 February 2017 at 09:30, Thomas Hellstrom wrote: >> On 02/22/2017 09:56 AM, Christian König wrote: >>> Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: >>>> A couple of fixes / improvements for things I

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 04:46 PM, Christian König wrote: > Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: >> On 02/22/2017 04:00 PM, Emil Velikov wrote: >>> On 22 February 2017 at 09:30, Thomas Hellstrom >>> wrote: >>>> On 02/22/2017 09:56 AM, Christian König wrot

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

2017-02-22 Thread Thomas Hellstrom
On 02/22/2017 05:54 PM, Christian König wrote: > Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: >> On 02/22/2017 04:46 PM, Christian König wrote: >>> Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: >>>> On 02/22/2017 04:00 PM, Emil Velikov wrote: >>>

[Mesa-dev] Putbits patches

2017-02-24 Thread Thomas Hellstrom
Hi, Christian! Are you OK with the updated Putbits patches? https://lists.freedesktop.org/archives/mesa-dev/2017-February/145269.html https://lists.freedesktop.org/archives/mesa-dev/2017-February/145258.html Thanks, Thomas ___ mesa-dev mailing lis

Re: [Mesa-dev] [Mesa-stable] [PATCH] xa: add xa_surface_from_handle2

2015-08-01 Thread Thomas Hellstrom
Hi! On 08/01/2015 07:16 PM, Emil Velikov wrote: > On 22 July 2015 at 00:00, Rob Clark wrote: >> From: Rob Clark >> >> Like xa_surface_from_handle(), but takes a handle type, rather than >> hard-coding 'shared' handle. This is needed to fix bugs seen with >> xf86-video-freedreno with xrandr rota

Re: [Mesa-dev] [PATCH] xa: don't leak fences

2015-08-05 Thread Thomas Hellstrom
Hi! On 07/10/2015 01:12 PM, Marek Olšák wrote: > I wonder... do we still need XA considering that everybody can just > use glamor instead? > > Marek Just back from vacation so I late reply. In the case of VMware/vmwgfx, the rendering setup latency is huge. Glamor tries to accelerate everything.

[Mesa-dev] [PATCH] gallium/postprocess: Fix resource freeing

2016-08-30 Thread Thomas Hellstrom
The code was triggering asserts in DEBUG builds of the SVGA driver since the reference count of the resource was never decremented before destroy. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- src/gallium/auxiliary/postprocess/pp_mlaa.c | 6 ++ 1 file changed, 2 insertions

[Mesa-dev] Delayed rendering in st/vdpau

2016-10-23 Thread Thomas Hellstrom
Hi, Christian, I remember some time ago you briefly explained what the delayed rendering in st/vdpau is all about, but I can't seem to find that email. Could you point me to a description or briefly detail what it is all about, and also why it doesn't seem to be needed when vdpau uses filters? T

Re: [Mesa-dev] [PATCH 10/15] gbm: Create a DRI image for dumb buffers, too.

2013-11-20 Thread Thomas Hellstrom
Hi! As discussed also offline, this is not a good thing to do, for the following reasons: 1) The bo handle does not necessarily represent a gem object. Calling gem_flink on such a handle is illegal. 2) Dumb bos and BO_USE_RENDERING may be totally different objects. It's incorrect to assume t

Re: [Mesa-dev] [PATCH] DRI Image v7 support for gallium drivers

2013-11-20 Thread Thomas Hellstrom
On 10/08/2013 12:48 AM, christopher.halse.rog...@canonical.com wrote: This is a prerequisite for the Mir EGL platform, which I'm sure everyone is excited about. It's also necessary for Wayland hybrid graphics support. Sorry for replying this late, I just started looking at this patch series. I

Re: [Mesa-dev] [PATCH 9/9] svga/winsys: Implement surface sharing using prime fd handles

2013-11-21 Thread Thomas Hellstrom
On 11/21/2013 05:11 AM, christopher.halse.rog...@canonical.com wrote: From: Thomas Hellstrom This needs a prime-aware vmwgfx kernel module to work properly. (With additions by Christopher James Halse Rogers ) Signed-off-by: Thomas Hellstrom --- src/gallium/targets/dri-vmwgfx/target.c

Re: [Mesa-dev] [PATCH 3/9] gallium/dri2: Set winsys_handle type to KMS for stride query.

2013-11-21 Thread Thomas Hellstrom
On 11/21/2013 05:11 AM, christopher.halse.rog...@canonical.com wrote: From: Christopher James Halse Rogers Otherwise the default is TYPE_SHARED, which will flink the bo. This seems rather unnecessary for a simple stride query. Is there no way we can cache this stuff in a __DRIimage? Changing

Re: [Mesa-dev] [PATCH 0/9] DRI Image 7 support for gallium

2013-11-21 Thread Thomas Hellstrom
x for patch 3 Reviewed-by: Thomas Hellstrom ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Thomas Hellstrom
Hi, Rob It turns out that your patch st/xa: use pipe-loader to get screen, makes the xa tracker close the X server driver's drm file descriptor when XA initialization fails or when XA is closed. This breaks X for example on Ubuntu 14.10 if 3D is disabled (typically on ESX). Pretty nasty bug for

Re: [Mesa-dev] XA tracker pipe-loader woes.

2014-07-02 Thread Thomas Hellstrom
On 07/02/2014 12:50 PM, Maarten Lankhorst wrote: > op 02-07-14 12:34, Thomas Hellstrom schreef: >> Hi, Rob >> >> It turns out that your patch st/xa: use pipe-loader to get screen, >> makes the xa tracker close the X server driver's drm file descriptor when >>

[Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure

2014-07-03 Thread Thomas Hellstrom
le descriptor before handing it over to the pipe loader. This fixes freedesktop.org bugzilla bug #80645. Cc: "10.2" Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_tracker.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_t

[Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure v2

2014-07-03 Thread Thomas Hellstrom
le descriptor before handing it over to the pipe loader. This fixes freedesktop.org bugzilla bug #80645. v2: Fix CC addresses. Cc: "10.2" Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_tracker.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --gi

[Mesa-dev] Another important XA patch

2014-07-03 Thread Thomas Hellstrom
Hi, Carl, Patch st/xa: Don't close the drm fd on failure v2 causes some conflicts when backported to 10.2. Let me know if you need help resolving them, or if you want me to push a backported version to 10.2. Thanks, Thomas ___ mesa-dev mailing list mesa

[Mesa-dev] [PATCH] svga: Don't unnecessarily reemit BindGBShader commands v2

2014-07-03 Thread Thomas Hellstrom
The Linux winsys can no longer relocate shader code, so avoid reemitting BindGBShader commands. They are costly. v2: Correctly handle errors from SVGA3D_BindGBShader() Reported-by: Michael Banack Signed-off-by: Thomas Hellstrom Tested-by: Brian Paul Reviewed-by: Brian Paul Reviewed-by: Jakob

[Mesa-dev] [PATCH] svga: Don't unnecessarily reemit BindGBShader commands v2

2014-07-03 Thread Thomas Hellstrom
The Linux winsys can no longer relocate shader code, so avoid reemitting BindGBShader commands. They are costly. v2: Correctly handle errors from SVGA3D_BindGBShader() Reported-by: Michael Banack Signed-off-by: Thomas Hellstrom Tested-by: Brian Paul Reviewed-by: Brian Paul Reviewed-by: Jakob

Re: [Mesa-dev] Another important XA patch

2014-07-03 Thread Thomas Hellstrom
Hi! On 07/04/2014 04:59 AM, Carl Worth wrote: > Thomas Hellstrom writes: >> Patch st/xa: Don't close the drm fd on failure v2 causes some conflicts >> when backported to 10.2. Let me know if >> you need help resolving them, or if you want me to push a backported >

[Mesa-dev] dri2 and vtSema

2013-09-24 Thread Thomas Hellstrom
Hi! I'm not completely sure what's the correct list for this nowadays, so forgive me for crossposting. I've got an interesting problem in that when any dri2 operations are carried out while the X server is switched away, they are pushed all the way down to the kernel graphics driver, which d

Re: [Mesa-dev] [PATCH 3/9] gallium/dri2: Set winsys_handle type to KMS for stride query.

2013-11-24 Thread Thomas Hellstrom
On 11/25/2013 05:06 AM, Christopher James Halse Rogers wrote: On Thu, 2013-11-21 at 14:12 +0100, Thomas Hellstrom wrote: On 11/21/2013 05:11 AM, christopher.halse.rog...@canonical.com wrote: From: Christopher James Halse Rogers Otherwise the default is TYPE_SHARED, which will flink the bo

Re: [Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 7 (v3)

2013-11-25 Thread Thomas Hellstrom
On 11/25/2013 05:38 AM, Ben Skeggs wrote: On Mon, Nov 25, 2013 at 1:57 PM, wrote: From: Christopher James Halse Rogers http://cgit.freedesktop.org/~keithp/mesa/log/?h=dri3 Ben, Christopher's patches have apparently been on the mesa dev lists since April, with various reviews and comments,

[Mesa-dev] [PATCH] st/dri: Check for kernel support before enabling fd sharing

2013-12-17 Thread Thomas Hellstrom
The dri2 state tracker is checking for driver support before enabling dri2ImageExtension version 7. This commit adds a check that also the kernel driver supports fd sharing through prime. Note that this adds a libdrm dependency on dri2.c. Signed-off-by: Thomas Hellstrom --- src/gallium

[Mesa-dev] [PATCH] winsys/svga: Replace the query mm buffer pool with a slab pool

2014-03-31 Thread Thomas Hellstrom
This is to avoid running out of query buffer space due to winsys limitations. Reported-and-tested-by: Brian Paul Signed-off-by: Thomas Hellstrom Cc: "10.1" --- src/gallium/winsys/svga/drm/vmw_screen_pools.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) di

[Mesa-dev] [PATCH] winsys/svga: Replace the query mm buffer pool with a slab pool v2

2014-03-31 Thread Thomas Hellstrom
This is to avoid running out of query buffer space due to winsys limitations. v2: Correct email addresses. Reported-and-tested-by: Brian Paul Signed-off-by: Thomas Hellstrom Cc: "10.1" --- src/gallium/winsys/svga/drm/vmw_screen_pools.c | 14 +- 1 file changed, 9

Re: [Mesa-dev] [PATCH 0/4] XA composite and perf improvements

2014-04-01 Thread Thomas Hellstrom
On 04/01/2014 06:18 PM, Rob Clark wrote: > On Tue, Apr 1, 2014 at 12:14 PM, Zack Rusin wrote: >> - Original Message - >>> From: Rob Clark >>> >>> While still more of a stop-gap solution (until glamor) for freedreno, >>> with these few relatively simple changes I get a pretty big performan

[Mesa-dev] [PATCH] winsys/svga: Replace the query mm buffer pool with a slab pool v3

2014-04-01 Thread Thomas Hellstrom
documentation and log message. Reported-and-tested-by: Brian Paul Signed-off-by: Thomas Hellstrom Cc: "10.1" --- src/gallium/winsys/svga/drm/vmw_screen_pools.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/gallium/winsys/svga/drm/vmw_scre

Re: [Mesa-dev] [PATCH 2/4] xa: remove unneeded args

2014-04-02 Thread Thomas Hellstrom
ers/xa/xa_yuv.c > index 9c7c4d6..43f56ff 100644 > --- a/src/gallium/state_trackers/xa/xa_yuv.c > +++ b/src/gallium/state_trackers/xa/xa_yuv.c > @@ -131,7 +131,7 @@ xa_yuv_planar_blit(struct xa_context *r, > if (ret != XA_ERR_NONE) > return -XA_ERR_NORES; > > -renderer_bind_destination(r, r->srf, r->srf->width, r->srf->height); > +renderer_bind_destination(r, r->srf); > xa_yuv_bind_blend_state(r); > xa_yuv_bind_shaders(r); > xa_yuv_bind_samplers(r, yuv); Reviewed-by: Thomas Hellstrom ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] xa: scissor to help tilers

2014-04-02 Thread Thomas Hellstrom
rts, /* verts */ > r->attrs_per_vertex); /* attribs/vert > */ > r->buffer_size = 0; > + > +xa_scissor_reset(r); > } > > static INLINE void > @@ -111,6 +122,7 @@ renderer_init_state(struct xa_context

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Thomas Hellstrom
On 04/01/2014 05:04 PM, Rob Clark wrote: > From: Rob Clark > > Otherwise it will trick the gallium driver into thinking that the render > target has actually changed (due to different pipe_surface pointing to > same underlying pipe_resource). This is really badness for tiling GPUs > like adreno.

Re: [Mesa-dev] [PATCH 4/4] xa: reuse surfaces

2014-04-02 Thread Thomas Hellstrom
On 04/02/2014 04:40 PM, Rob Clark wrote: > On Wed, Apr 2, 2014 at 3:47 AM, Thomas Hellstrom > wrote: >> On 04/01/2014 05:04 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Otherwise it will trick the gallium driver into thinking that the render >>&g

Re: [Mesa-dev] [PATCH 1/4] xa: handle solid-fill src/mask

2014-04-02 Thread Thomas Hellstrom
On 04/01/2014 05:04 PM, Rob Clark wrote: > From: Rob Clark > > Add support to property handle solid-fill src and/or mask. Without this > we fallback to sw a lot for common things like text rendering. > > Signed-off-by: Rob Clark > --- > src/gallium/state_trackers/xa/xa_composite.c | 88 ---

[Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-02 Thread Thomas Hellstrom
ff-by: Thomas Hellstrom --- configure.ac |1 + src/gallium/state_trackers/xa/xa_tracker.h| 200 - src/gallium/state_trackers/xa/xa_tracker.h.in | 200 + 3 files changed, 201 insertions(+), 200 deletions(-) d

Re: [Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-03 Thread Thomas Hellstrom
On 04/03/2014 04:49 PM, Rob Clark wrote: > On Thu, Apr 3, 2014 at 2:05 AM, Thomas Hellstrom > wrote: >> The xa version number had to be set in two places. In configure.ac and in >> xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't >>

Re: [Mesa-dev] [PATCH v2 00/10] Map support for GBM bos

2014-04-04 Thread Thomas Hellstrom
NAK! No generic mmap() APIs of GBM bos, please. The reason is that this impossible to implement in an efficient way on non-coherent architectures, and once the interface is there, people will start using it and ignore the non-coherent architectures. And these will, in the end, have to implement a

Re: [Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-04 Thread Thomas Hellstrom
On 04/04/2014 12:13 PM, Emil Velikov wrote: > On 03/04/14 07:05, Thomas Hellstrom wrote: >> The xa version number had to be set in two places. In configure.ac and in >> xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't >> use mesa internal

Re: [Mesa-dev] [PATCH] svga: replace sampler assertion with conditional

2014-04-04 Thread Thomas Hellstrom
.sampler_views[i]->texture->target; > if (!svga->curr.sampler[i]->normalized_coords) { > @@ -264,7 +287,7 @@ make_fs_key(const struct svga_context *svga, > > idx = 0; > for (i = 0; i < svga->curr.num_samplers; ++i) { > - if (svga->

[Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Thomas Hellstrom
Cc: "10.1" Signed-off-by: Thomas Hellstrom --- src/gallium/winsys/svga/drm/vmwgfx_drm.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/svga/drm/vmwgfx_drm.h b/src/gallium/winsys/svga/drm/vmwgfx_drm.h index e42b3f5..73ad205 100644

[Mesa-dev] [PATCH 2/2] winsys/svga: Fix prime surface references also for guest-backed surfaces

2014-04-07 Thread Thomas Hellstrom
Implement guest-backed surface sharing using prime fds. Previously only legacy surfaces could use this functionality. Also use the vmwgfx 2.6 single-ioctl prime fd reference if available. Cc: "10.1" Signed-off-by: Thomas Hellstrom --- src/gallium/winsys/svga/drm/vmw_screen.h |

[Mesa-dev] [PATCH] st/xa: Bind destination before setting new state

2014-04-07 Thread Thomas Hellstrom
x27;t be a valid reason for the svga driver to emit partially set up state, but to avoid future uncertainties, make sure this doesn't happen anyway. Found while auditing the state tracker for inconsistent sampler state / sampler view setup. Signed-off-by: Thomas Hellstrom --- src/gallium/st

Re: [Mesa-dev] [PATCH 1/2] Revert "st/xa: Fix advertized version number and try to avoid future discrepancies"

2014-04-07 Thread Thomas Hellstrom
log message is incorrect, xa_tracker.h is an installed header and thus must include the correct defines. (see my commit message). If we don't parse it using autoconf, we need to use sed or some other tool to fix the header. Otherwise Acked-by: Thomas Hellstrom /Thomas >

Re: [Mesa-dev] [PATCH 2/2] st/xa: Move version information into a single place

2014-04-07 Thread Thomas Hellstrom
a state-tracker + targets, > and we should move the version definitions to a build system > independent file (similar to VERSION) once any of the other two > decide to join the fun. > > Cc: Thomas Hellstrom > Signed-off-by: Emil Velikov Hi! nak. The users of libxatracker expects to

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Thomas Hellstrom
On 04/07/2014 02:49 PM, Emil Velikov wrote: > On 07/04/14 10:50, Thomas Hellstrom wrote: >> Cc: "10.1" >> Signed-off-by: Thomas Hellstrom > Rather silly question: > > Why do you guys pull this header inside mesa and over using the one provided > by libdrm ?

[Mesa-dev] [PATCH] st/xa: Make sure unused samplers are set to NULL

2014-04-07 Thread Thomas Hellstrom
renderer_copy_prepare was setting the first sampler but never telling the cso code how many samplers were actually used. Fix this. Cc: "10.1" Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_renderer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

Re: [Mesa-dev] [PATCH] Partially revert "st/xa: Fix advertized version number and try to avoid future discrepancies"

2014-04-07 Thread Thomas Hellstrom
Hi! Thanks, This looks good to me. Reviewed-by: Thomas Hellstrom /Thomas On 04/07/2014 03:45 PM, Emil Velikov wrote: > This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c. > > As the header is the one defining the API/ABI and is distributed > during installation, we sho

Re: [Mesa-dev] [PATCH v3 00/11] Map support for GBM

2014-04-08 Thread Thomas Hellstrom
On 04/08/2014 10:28 PM, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Changes from previous version: > > - make it clearer that the interface is optional; No! this is still a NAK! The reason is, just like the last time, that as soon as the major drivers implement t

Re: [Mesa-dev] [PATCH 1/4] xa: handle solid-fill src/mask

2014-04-09 Thread Thomas Hellstrom
On 04/03/2014 04:07 PM, Brian Paul wrote: > On 04/02/2014 11:17 PM, Thomas Hellstrom wrote: >> On 04/01/2014 05:04 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Add support to property handle solid-fill src and/or mask. Without >>> this >>&g

Re: [Mesa-dev] [PATCH] svga: move LIST_INITHEAD(dirty_buffers) earlier in svga_context_create()

2014-04-09 Thread Thomas Hellstrom
Reviewed-by: Thomas Hellstrom On 04/09/2014 07:40 PM, Brian Paul wrote: > Fixes a crash in svga_context_flush_buffers() if we use the 'draw' module > for AA lines (when the device doesn't support that feature). We need to > initialize this list before we setup the swtnl

Re: [Mesa-dev] [PATCH v2 4/5] st/xa: handle solid-fill src/mask

2014-04-09 Thread Thomas Hellstrom
Hi, Rob! On 04/08/2014 10:48 PM, Rob Clark wrote: > From: Rob Clark > > Add support to property handle solid-fill src and/or mask. Without this > we fallback to sw a lot for common things like text rendering. > > Signed-off-by: Rob Clark > --- > src/gallium/state_trackers/xa/xa_composite.c | 1

Re: [Mesa-dev] [PATCH v2 0/5] XA composite and perf improvements and fixes

2014-04-16 Thread Thomas Hellstrom
ats.) > > Rob Clark (4): > st/xa: remove unneeded args > st/xa: scissor to help tilers > st/xa: handle solid-fill src/mask > st/xa: handle xrgb->a better > > Thomas Hellstrom (1): > st/xa: Cache render target surface > > src/gallium/state_trackers/xa/

[Mesa-dev] [PATCH] st/xa: Cache render target surface

2014-04-17 Thread Thomas Hellstrom
that is is still under investigation. Based on an idea by Rob Clark. Cc: "10.0 10.1" Signed-off-by: Thomas Hellstrom Reviewed-by: Rob Clark --- src/gallium/state_trackers/xa/xa_context.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH v2 0/5] XA composite and perf improvements and fixes

2014-04-17 Thread Thomas Hellstrom
On 04/17/2014 12:48 AM, Rob Clark wrote: > On Wed, Apr 16, 2014 at 9:09 AM, Thomas Hellstrom > wrote: >> Hi, Rob, >> >> Do you think we can push patches 1 trough 3 with a CC to stable for >> patch 3? > yes please.. you can push, or I can.. I was just waiting to

Re: [Mesa-dev] [PATCH v3 00/11] Map support for GBM

2014-04-27 Thread Thomas Hellstrom
On 04/25/2014 11:36 PM, Kristian Høgsberg wrote: > On Tue, Apr 8, 2014 at 1:49 PM, Thomas Hellstrom > wrote: >> On 04/08/2014 10:28 PM, Ander Conselvan de Oliveira wrote: >>> From: Ander Conselvan de Oliveira >>> >>> Changes from previous version: >>

[Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit "Cache render target surface"

2014-05-08 Thread Thomas Hellstrom
The mentioned commit has the nasty side-effect of turning off accelerated copies. Cc: "10.1 10.2" Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/xa/xa_contex

Re: [Mesa-dev] Mesa 10.1.2

2014-05-08 Thread Thomas Hellstrom
Carl, Unfortunately a pretty bad problem made it into the XA state tracker in 10.1.2 with commit "Cache render target surface" and it was just fixed in master with commit 9306b7c171b29ac99f837e9efcd0281caf1d332e. It makes vmware swapbuffers fall back to software. The reason it was CC'd stable was

Re: [Mesa-dev] [PATCH 2/4] targets/xa: limit the amount of exported symbols

2014-05-14 Thread Thomas Hellstrom
Hi, I'm on vacation, so I have no way of testing this until next week. /Thomas On 05/14/2014 02:04 PM, Emil Velikov wrote: > ping for the series > > If there is no objections I would like to push these over the weekend. > > Cheers, > Emil > On 09/05/14 18:10, Emil Velikov wrote: >> ping >> >> T

Re: [Mesa-dev] [PATCH 2/4] targets/xa: limit the amount of exported symbols

2014-05-21 Thread Thomas Hellstrom
Reviewed-by: Thomas Hellstrom On 05/02/2014 10:02 PM, Emil Velikov wrote: > In the presence of LLVM the final library exports every symbol from > the llvm namespace. Resolve this by using a version script (w/o the > version/name tag). > > Considering that there are only ~35 symb

[Mesa-dev] [PATCH] winsys/svga: Avoid calling drm getparam for max surface size on older kernels

2014-02-24 Thread Thomas Hellstrom
This avoids the kernel driver spewing out errors about the param not being supported. Also correct the max surface size used when the kernel does not support the query. Reported-by: Brian Paul Signed-off-by: Thomas Hellstrom Reviewed-by: Charmaine Lee Cc: "10.1" --- src/gallium/w

Re: [Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()

2019-03-07 Thread Thomas Hellstrom
On Thu, 2019-03-07 at 19:45 -0700, Brian Paul wrote: > This fixes a rendering issue where UBO updates aren't always picked > up by drawing calls. This issue effected the Webots robotics > simulator. VMware bug 2175527. > > Testing Done: Webots replay, piglit, misc Linux games > --- > src/galliu

Re: [Mesa-dev] [PATCH 3/3] winsys/svga: use new pb_usage_flags enum type

2019-03-07 Thread Thomas Hellstrom
On Tue, 2019-03-05 at 20:48 -0700, Brian Paul wrote: > And add a comment that we're implicitly converting PIPE_TRANSFER_ > flags to PB_USAGE_ flags in one place. And statically assert that > the enum values match. LGTM. Thanks for fixing this! Reviewed-by: Thomas Hellstrom

Re: [Mesa-dev] [Mesa-stable] [PATCH] xa: add xa_surface_from_handle2

2015-09-01 Thread Thomas Hellstrom
On 09/01/2015 03:49 PM, Emil Velikov wrote: > Hi all, > > On 1 August 2015 at 20:40, Thomas Hellstrom wrote: >> Hi! >> >> On 08/01/2015 07:16 PM, Emil Velikov wrote: >>> On 22 July 2015 at 00:00, Rob Clark wrote: >>>> From: Rob Clark >>>

[Mesa-dev] [PATCH] xa: add xa_surface_from_handle2 v2

2015-09-02 Thread Thomas Hellstrom
GEM handle associated with the drm_file will result in two unique handles for the same bo. Which causes all sorts of follow-on fail. v2: - Add support for for fd handles. - Avoid duplicating code. - Bump xa version minor. Signed-off-by: Rob Clark Signed-off-by: Thomas Hellstrom --- src/gallium/stat

[Mesa-dev] [PATCH] st/xa: Use PIPE_FORMAT_R8_UNORM when available

2015-09-16 Thread Thomas Hellstrom
d-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_composite.c | 40 ++-- src/gallium/state_trackers/xa/xa_tracker.c | 28 +-- 2 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/gallium/state_trackers/xa/xa_composite.c

Re: [Mesa-dev] [PATCH] st/xa: Use PIPE_FORMAT_R8_UNORM when available

2015-09-17 Thread Thomas Hellstrom
On 09/17/2015 11:34 AM, Jose Fonseca wrote: > On 16/09/15 14:04, Thomas Hellstrom wrote: >> XA has been using L8_UNORM for a8 and yuv component surfaces. >> This commit instead makes XA prefer R8_UNORM since it's assumed to >> have a >> higher availability. >>

Re: [Mesa-dev] [PATCH] st/xa: Use PIPE_FORMAT_R8_UNORM when available

2015-09-17 Thread Thomas Hellstrom
On 09/17/2015 11:53 AM, Thomas Hellstrom wrote: > On 09/17/2015 11:34 AM, Jose Fonseca wrote: >> On 16/09/15 14:04, Thomas Hellstrom wrote: >>> XA has been using L8_UNORM for a8 and yuv component surfaces. >>> This commit instead makes XA prefer R8_UNORM since it's

[Mesa-dev] [PATCH] st/xa: Fixups for PIPE_FORMAT_R8_UNORM A8 usage

2015-09-17 Thread Thomas Hellstrom
destiation. Reported-by: Jose Fonseca Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_composite.c | 34 src/gallium/state_trackers/xa/xa_renderer.c | 6 +++-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH] st/xa: Fixups for PIPE_FORMAT_R8_UNORM A8 usage v2.

2015-09-17 Thread Thomas Hellstrom
destiation. v2: Fix a copy-paste error. Reported-by: Jose Fonseca Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/xa/xa_composite.c | 34 src/gallium/state_trackers/xa/xa_renderer.c | 6 +++-- 2 files changed, 29 insertions(+), 11 deletions(-) diff

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-04-11 Thread Thomas Hellstrom
On 04/11/2016 04:31 PM, Rob Clark wrote: > On Mon, Apr 11, 2016 at 10:09 AM, Emil Velikov > wrote: >> Hi Rob, >> >> On 31 March 2016 at 04:21, Rob Herring wrote: >>> This adds GBM map and unmap functions. Unlike prior attempts, this >>> version provides a region and usage flags for the mapping.

[Mesa-dev] [PATCH] st/xa: Fix regression in xa_yuv_planar_blit()

2014-09-28 Thread Thomas Hellstrom
Commit "st/xa: scissor to help tilers" broke xa_yuv_planar_blit() and vmwgfx textured video. Fix this by implementing scissors also in the yuv draw path. Signed-off-by: Thomas Hellstrom Cc: Rob Clark Cc: "10.2 10.3" --- src/gallium/state_trackers/xa/xa_renderer.c | 11

Re: [Mesa-dev] [PATCH 2/2] xa: support for drivers which use NIR

2015-04-04 Thread Thomas Hellstrom
lgtm. Could you just add a small comment for future reference in in xa_tracker.c that the function _mesa_error_no_memory is used by NIR? Thanks, Thomas On 04/03/2015 08:07 PM, Rob Clark wrote: > From: Rob Clark > > We need to pull in libnir.la and it's dependency libglsl_util.la. Also, >

[Mesa-dev] [PATCH 1/2] winsys/svga: Fix an uninitialized return value

2016-02-25 Thread Thomas Hellstrom
Reported-by: Brian Paul Signed-off-by: Thomas Hellstrom Reviwed-by: Brian Paul Cc: "11.0 11.1" --- src/gallium/winsys/svga/drm/vmw_surface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/winsys/svga/drm/vmw_surface.c b/src/gallium/winsys/svga/drm/vmw_surfa

[Mesa-dev] [PATCH 2/2] winsys/svga: Increase the fence timeout

2016-02-25 Thread Thomas Hellstrom
If running with a software renderer backend, the timeout may be insufficient, and we don't want to release busy buffers too early. In practice, SVGA gpu lockups are extremely rare. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Cc: "11.0 11.1" --- src/gallium/

[Mesa-dev] [PATCH 1/3] gallium/vl: Fix brightness usage

2016-03-04 Thread Thomas Hellstrom
Multiplying the contrast- and brightness matrices it becomes obvious that brightness should be multiplied by contrast in the procamp matrix. Fix this. Cc: "11.0 11.1 11.2" Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/vl/vl_csc.c | 22 +++--- 1 file c

[Mesa-dev] [PATCH 3/3] gallium/vl: Parameter substitution in the csc matrix computation

2016-03-04 Thread Thomas Hellstrom
Makes the code significantly more readable. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/vl/vl_csc.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_csc.c b/src/gallium/auxiliary/vl/vl_csc.c

[Mesa-dev] [PATCH 2/3] gallium/vl: Simplify usage of full range matrices

2016-03-04 Thread Thomas Hellstrom
saturation with 1.138/1.164. Removes the need to specify separate full range matrices. We can also incorporate the ybias in the brightness simplifying the calculation somewhat. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/vl/vl_csc.c | 50 ++- 1 file

[Mesa-dev] [PATCH 2/3] gallium/vl: Simplify usage of full range matrices

2016-03-04 Thread Thomas Hellstrom
saturation with 1.138/1.164. Removes the need to specify separate full range matrices. We can also incorporate the ybias in the brightness simplifying the calculation somewhat. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/vl/vl_csc.c | 50 ++- 1 file

[Mesa-dev] [PATCH 3/3] gallium/vl: Parameter substitution in the csc matrix computation

2016-03-04 Thread Thomas Hellstrom
Makes the code significantly more readable. Signed-off-by: Thomas Hellstrom --- src/gallium/auxiliary/vl/vl_csc.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_csc.c b/src/gallium/auxiliary/vl/vl_csc.c

[Mesa-dev] [PATCH 1/3] gallium/vl: Fix brightness usage v2

2016-03-04 Thread Thomas Hellstrom
Multiplying the contrast- and brightness matrices it becomes obvious that brightness should be multiplied by contrast in the procamp matrix. Fix this. v2: Fixed a couple of typos, one of them affecting the results. Cc: "11.0 11.1 11.2" Signed-off-by: Thomas Hellstrom --- src/gallium

  1   2   3   4   >