Re: [Mesa-dev] www.mesa3d.org moving to freedesktop.org

2017-02-08 Thread Vedran Miletić
uot; warnings in your browser for a bit... > > Eventually, the pages on www.mesa3d.org <http://www.mesa3d.org> should > get automatically updated from git check-ins to the docs/ directory. > > -Brian > Great! We also got https in the process, very nice. -- Vedran Miletić vedran.m

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Vedran Miletić
cc_cache_line_size = 64; /* TC L2 line size on GCN */ > > -ws->check_vm = strstr(debug_get_option("R600_DEBUG", ""), "check_vm") != > NULL; > +if ((strstr(debug_get_option("R600_DEBUG", ""),

[Mesa-dev] pfn_notify in clCreateContext()

2017-02-24 Thread Vedran Miletić
ntext.html -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

2016-09-13 Thread Vedran Miletić
till doesn't have it in their stable package (and it's not > even in test in Bodhi). I'll try to compile my own LLVM as Edward advised. > Fedora 24 is unlikely to get LLVM 3.9 in updates. If packaged, it will come to Fedora 25 or newer. Good choice. -- Vedran Miletić vedran.m

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-09-19 Thread Vedran Miletić
On 07/28/2016 07:52 AM, Francisco Jerez wrote: > Emil Velikov writes: > >> On 6 June 2016 at 00:02, Vedran Miletić wrote: >>> On 06/04/2016 04:18 AM, Francisco Jerez wrote: >>>> >>>> Serge Martin writes: >>>> >>>>> From:

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-09-19 Thread Vedran Miletić
On 09/19/2016 07:08 PM, Vedran Miletić wrote: > On 07/28/2016 07:52 AM, Francisco Jerez wrote: >> Emil Velikov writes: >> >>> On 6 June 2016 at 00:02, Vedran Miletić wrote: >>>> On 06/04/2016 04:18 AM, Francisco Jerez wrote: >>>>> >>&g

[Mesa-dev] [PATCH v3] clover: Pass unquoted compiler arguments to Clang

2016-09-19 Thread Vedran Miletić
OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the Clang OpenCL compiler was called via a shell, the shell would split the arguments with respect to to quotes and then remove quotes before passing the arguments to the compiler. S

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2016-09-19 Thread Vedran Miletić
On 09/07/2016 06:52 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG

[Mesa-dev] [PATCH v5] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

2016-09-19 Thread Vedran Miletić
Signed-off-by: Vedran Miletić Reviewed-by[v1]: Edward O'Callaghan --- docs/envvars.html | 13 + src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 --- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a

[Mesa-dev] [PATCH v6] clover: Introduce CLOVER_EXTRA_*_OPTIONS environment variables

2016-09-28 Thread Vedran Miletić
typo * use CLOVER_EXTRA_COMPILER_OPTIONS in link stage v6: * separate in CLOVER_EXTRA_{BUILD,COMPILE,LINK}_OPTIONS * append options in cl{Build,Compile,Link}Program Signed-off-by: Vedran Miletić Reviewed-by[v1]: Edward O'Callaghan --- docs/envvars.html

Re: [Mesa-dev] [PATCH v6] clover: Introduce CLOVER_EXTRA_*_OPTIONS environment variables

2016-09-28 Thread Vedran Miletić
On 09/28/2016 04:22 PM, Edward O'Callaghan wrote: > Just drop the Rb as soon as you revise any patch please. Obviously there > was a bunch of stuff that happened and discussion.. > Indeed, v1 and v6 are quite different. Will do in the future. Regards, Vedran --

[Mesa-dev] [PATCH v4] clover: Pass unquoted compiler arguments to Clang

2016-09-28 Thread Vedran Miletić
comment Signed-off-by: Vedran Miletić --- src/gallium/state_trackers/clover/llvm/util.hpp | 39 ++--- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/util.hpp b/src/gallium/state_trackers/clover/llvm/util.hpp index 8db6f20

Re: [Mesa-dev] [PATCH v2] clover: add GetKernelArgInfo (CL 1.2)

2016-10-05 Thread Vedran Miletić
ernel > + /// argument given by \p arg. > + /// > + inline uint64_t > + get_uint_argument_metadata(const ::llvm::Function &f, > + const ::llvm::Argument &arg, > + const std::string &name) {

Re: [Mesa-dev] [PATCH v2 0/2] Add support for some of the missing CL1.2 queries

2016-10-05 Thread Vedran Miletić
m/invocation.cpp | 2 +- > .../state_trackers/clover/tgsi/compiler.cpp| 2 +- > 11 files changed, 61 insertions(+), 5 deletions(-) > Nice work. The series is Reviewed-by: Vedran Miletić -- Vedran Miletić vedran.miletic.net __

Re: [Mesa-dev] [PATCH] clover: clGetExtensionFunctionAddressForPlatform

2016-10-05 Thread Vedran Miletić
const char *p_name) { >> + return GetExtensionFunctionAddressForPlatform(d_platform, p_name); >> +} >> + >> CLOVER_ICD_API cl_int >> clIcdGetPlatformIDsKHR(cl_uint num_entries, cl_platform_id *rd_platforms, >> cl_uint *rnum_platforms) { > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Vedran Miletić -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. --- docs/envvars.html | 12 src/galliu

[Mesa-dev] [PATCH v2] clover: assert struct argument is compiled usably

2016-10-06 Thread Vedran Miletić
://reviews.llvm.org/D20168 or an equivalent patch. Signed-off-by: Vedran Miletić --- src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/common.cpp b/src/gallium/state_trackers/clover/llvm/codegen

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
On 10/06/2016 04:26 PM, Vedran Miletić wrote: > CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version > supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. > CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. > --- > do

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
On 10/06/2016 07:15 PM, Jan Vesely wrote: > On Thu, 2016-10-06 at 16:26 +0200, Vedran Miletić wrote: >> CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version >> supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for >> OpenGL. >> CLOVER_CL_C_VERSIO

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-13 Thread Vedran Miletić
On 10/07/2016 12:05 PM, Serge Martin wrote: > On Thursday 06 October 2016 16:26:21 Vedran Miletić wrote: >> CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version >> supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. >> CLOVER_CL_C_VERSION_OVER

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-13 Thread Vedran Miletić
On 10/13/2016 07:45 PM, Vedran Miletić wrote: > On 10/07/2016 12:05 PM, Serge Martin wrote: >> On Thursday 06 October 2016 16:26:21 Vedran Miletić wrote: >>> PACKAGE_VERSION #ifdef MESA_GIT_SHA1 >>> " (" MESA_GIT_SHA1 ")

[Mesa-dev] [PATCH v2] clover: Allow OpenCL version override

2016-10-13 Thread Vedran Miletić
27; ') { std::vector ss; std::istringstream iss(s); std::string t; - while (getline(iss, t, ' ')) + while (getline(iss, t, sep)) ss.push_back(t); return ss; diff --git a/src/gallium/state_trackers/clover/util/vers

[Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Vedran Miletić
older than EG will not use this capability). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513 Signed-off-by: Vedran Miletić --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/include/pipe/p_defines.h | 3 ++- src/gallium/state_trackers/clover/api

Re: [Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Vedran Miletić
On 08/29/2016 09:30 PM, Jan Vesely wrote: On Mon, 2016-08-29 at 20:13 +0200, Vedran Miletić wrote: Clover presently reports 32 as CL_DEVICE_ADDRESS_BITS, which is not correct for AMD SI and newer chip generations. This patch introduces the PIPE_COMPUTE_CAP_ADDRESS_BITS pipe capability queried

[Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

2016-08-29 Thread Vedran Miletić
Options specified via the CLOVER_COMPILER_OPTIONS shell variable are appended to the compiler options specified by the OpenCL program (if any). Signed-off-by: Vedran Miletić --- docs/envvars.html | 2 ++ src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

2016-08-31 Thread Vedran Miletić
On 08/30/2016 09:27 AM, Serge Martin wrote: > On Tuesday 30 August 2016 01:20:55 Vedran Miletić wrote: >> Options specified via the CLOVER_COMPILER_OPTIONS shell variable are >> appended to the compiler options specified by the OpenCL program (if >> any). >> >&

[Mesa-dev] [PATCH] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

2016-08-31 Thread Vedran Miletić
Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell variable are appended to the compiler and linker options specified by the OpenCL program (if any). v2: * rename to CLOVER_EXTRA_COMPILER_OPTIONS * use debug_get_option * append to linker options as well Signed-off-by: Vedran

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

2016-08-31 Thread Vedran Miletić
On 08/28/2016 04:42 PM, Niels Ole Salscheider wrote: > This is required by the OpenCL standard. > > Signed-off-by: Niels Ole Salscheider Reviewed-by: Vedran Miletić Good catch. Do we miss more defines from [1]? Regards, Vedran [1] https://www.khronos.org/registry/cl/sdk/1.1/docs/

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

2016-08-31 Thread Vedran Miletić
On 08/31/2016 12:11 PM, Vedran Miletić wrote: > Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell variable > are appended to the compiler and linker options specified by the OpenCL > program (if any). > > v2: > * rename to CLOVER_EXTRA_COMPILER_OPTIONS > *

[Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

2016-09-07 Thread Vedran Miletić
-off-by: Vedran Miletić Reviewed-by[v1]: Edward O'Callaghan --- docs/envvars.html | 9 + src/gallium/state_trackers/clover/llvm/invocation.cpp | 10 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/docs/envvars.html b

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

2016-09-07 Thread Vedran Miletić
On 09/07/2016 04:14 PM, Jan Vesely wrote: > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell >> variable >> are appended to the compiler and linker options specified by the >> OpenCL &g

[Mesa-dev] [PATCH v4] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

2016-09-07 Thread Vedran Miletić
CLOVER_EXTRA_COMPILER_OPTIONS * use debug_get_option * append to linker options as well v3: code cleanups v4: separate CLOVER_EXTRA_LINKER_OPTIONS options Signed-off-by: Vedran Miletić Reviewed-by[v1]: Edward O'Callaghan --- docs/envvars.html | 12

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

2016-09-07 Thread Vedran Miletić
On 09/07/2016 07:58 PM, Nicholas Bishop wrote: > Bump, any interest in this? > In my experience rST is much nicer to write than pure HTML, and I like how the output looks. Definitive yes on the rST instead of HTML, no strong opinion on readthedocs.org vs self-hosted. Regards, Vedran --

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

2016-10-24 Thread Vedran Miletić
('DRM', ['libdrm >= 2.4.65']) if env['x11']: env.Append(CPPPATH = env['X11_CPPPATH']) That's a large bump and 2.4.65 is just over a year old. It would be nice to support a couple more versions before. Is there an acceptable workaroun

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

2016-10-25 Thread Vedran Miletić
On 10/25/2016 04:15 AM, Michel Dänzer wrote: > On 25/10/16 11:01 AM, Michel Dänzer wrote: >> On 25/10/16 09:17 AM, Vedran Miletić wrote: >>> On 10/25/2016 01:41 AM, Vinson Lee wrote: >>>> Fix SCons build. drmDevicePtr is not available until libdrm 2.4.65. >>>

Re: [Mesa-dev] [PATCH v4] clover: Pass unquoted compiler arguments to Clang

2016-11-02 Thread Vedran Miletić
On 10/30/2016 08:16 PM, Francisco Jerez wrote: > Vedran Miletić writes: > >> OpenCL apps can quote arguments they pass to the OpenCL compiler, most >> commonly include paths containing spaces. >> >> If the Clang OpenCL compiler was called via a shell, the shell wou

Re: [Mesa-dev] [Clover] Compilations error with latest LLVM version 4.0.0svn in llvm/codegen/bitcode.cpp

2016-11-14 Thread Vedran Miletić
od.takeError()) { + std::string msg; + ::llvm::handleAllErrors(std::move(err), [&](::llvm::ErrorInfoBase &EIB) { + msg = EIB.message(); + fail(r_log, error(CL_INVALID_PROGRAM), msg.c_str()); + }); + } return std::unique_ptr<::llvm::Module>(std::move(*mod)); }

[Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Vedran Miletić
--- src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp b/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp index 8e89a49..5dcc4f8 100644 --- a

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Vedran Miletić
On 11/14/2016 04:49 PM, Tom Stellard wrote: > On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote: >> Tested-by: Dieter Nützel >> >> Thanks Vedran! >> > > Pushed, thanks! > > -Tom > Thank you! Ved

[Mesa-dev] [PATCH] clover: restore support for LLVM <= 3.9

2016-11-14 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 broke 3.9 and older versions of LLVM for Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++- src

[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-16 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-17 Thread Vedran Miletić
On 11/16/2016 11:21 PM, Vinson Lee wrote: > On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely wrote: >> On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: >>> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >>> 3.9 and older versionsin Clover.

[Mesa-dev] [PATCH v3] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9

[Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

2016-11-18 Thread Vedran Miletić
The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9

[Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

2016-11-22 Thread Vedran Miletić
: simplify using templates and lambda Signed-off-by: Vedran Miletić Reviewed-by[v2]: Jan Vesely Tested-by[v4]: Vinson Lee Tested-by[v4]: Pierre Moreau Reviewed-by: Francisco Jerez --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 +++-- src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH] radv: drop unused fields in physical device.

2016-12-13 Thread Vedran Miletić
Nice cleanup. Reviewed-by: Vedran Miletić On 12/13/2016 04:58 AM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_private.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/src/amd/vulkan/radv_pr

Re: [Mesa-dev] Documenting with Sphinx

2016-12-14 Thread Vedran Miletić
ing a different doxygen config for usage with sphinx and I'm > wondering if we should try and preserve what's already there. > > --Jason > Somewhat related effort was already discussed several months ago: https://lists.freedesktop.org/archives/mesa-dev/2016-September/128182.html V. -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [RFC PATCH] clover: Return correct CL_EVENT_REFERENCE_COUNT

2016-12-16 Thread Vedran Miletić
lease-event test. Signed-off-by: Vedran Miletić --- src/gallium/state_trackers/clover/api/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/event.cpp b/src/gallium/state_trackers/clover/api/event.cpp index 5d1a0e5..74bc4d9 1

[Mesa-dev] [PATCH] clover: Use Clang's diagnostics

2016-12-20 Thread Vedran Miletić
test. Signed-off-by: Vedran Miletić --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 675cf19..29

Re: [Mesa-dev] [RFC PATCH] clover: Return correct CL_EVENT_REFERENCE_COUNT

2016-12-20 Thread Vedran Miletić
On 12/20/2016 11:59 AM, Jan Vesely wrote: > On Fri, 2016-12-16 at 13:43 -0800, Francisco Jerez wrote: >> Vedran Miletić writes: >> >>> Current implementation of event handling keeps an extra reference to >>> the hardware event, in addition to the reference retu

[Mesa-dev] [PATCH v2] clover: Use Clang's diagnostics

2016-12-21 Thread Vedran Miletić
test. v2: fix inconsistent code formatting Signed-off-by: Vedran Miletić Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/ga

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-06-30 Thread Vedran Miletić
ead something like MAX2(0x7ff, max_const_buffer_size) Haven't tried running memory-heavy OpenCL programs, but clinfo other than const buffer size looks good. -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.o

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-06-30 Thread Vedran Miletić
On 07/01/2016 02:52 AM, Vedran Miletić wrote: Had something similar in the works, Bas did as well, but this approach is cleaner. With these changes, in si_pipe.c and r600_pipe.c, you should not return max_const_buffer_size anymore, since it can exceed int limits, but instead something like

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: add radeon_info::max_alloc_size into the winsys interface

2016-07-01 Thread Vedran Miletić
;info.gart_size); The radeon driver in kernels older than 3.17 can't allocate BOs larger than 256MB. Indeed. You should ensure DRM >= 2.40. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-07-01 Thread Vedran Miletić
On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić wrote: On 07/01/2016 01:29 AM, Marek Olšák wrote: From: Marek Olšák also fix max_global_size to take a maximum of {vram_size, gart_size} --- src

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-07-01 Thread Vedran Miletić
On 07/01/2016 02:27 PM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 1:45 PM, Vedran Miletić wrote: On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić wrote: On 07/01/2016 01:29 AM, Marek Olšák

Re: [Mesa-dev] [PATCH] gallium/radeon: add and use radeon_info::max_alloc_size (v2)

2016-07-04 Thread Vedran Miletić
Reviewed-by: Vedran Miletić On 07/01/2016 04:18 PM, Marek Olšák wrote: From: Marek Olšák v2: - squashed the patches - use INT_MAX - clamp max_const_buffer_size - check the DRM version in radeon --- src/gallium/drivers/r600/r600_pipe.c | 4 ++-- src/gallium/drivers

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-12 Thread Vedran Miletić
) to stop using generic macro names, but I don't think that's on anybody's todo list. it was just a suggestion, feel free to ignore it. Jan I love cleaning stuff like that and can provide a patch changing DEBUG to e.g. MESA_DEBUG, if that would solve the problem on Mesa's

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-12 Thread Vedran Miletić
06.06.2016 u 12:24, Vedran Miletić je napisao/la: On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/fo

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-13 Thread Vedran Miletić
k in the game; in the first run there is a very long stop (approx 1 second) the moment the character picks up the green sigil (and a few other points, I would have to check exactly), second run is all smooth. Regards, Vedran -- Vedran Miletić vedran.mileti

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-13 Thread Vedran Miletić
ps://www.khronos.org/bugzilla/show_bug.cgi?id=1514 -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-07-13 Thread Vedran Miletić
OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the Clang OpenCL compiler was called via a shell, the shell would split the arguments with respect to to quotes and then remove quotes before passing the arguments to the compiler. S

[Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

2016-07-14 Thread Vedran Miletić
Signed-off-by: Vedran Miletić --- docs/xlibdriver.html| 2 +- src/gallium/docs/source/drivers/openswr/faq.rst | 4 ++-- src/gallium/include/pipe/p_defines.h| 2 +- src/mesa/main/version.c | 2 +- 4 files changed, 5 insertions(+), 5

[Mesa-dev] [PATCH] st/nine: add missing copyright headers

2016-07-14 Thread Vedran Miletić
Few files were missing the copyright headers. This patch adds correct copyright headers according to the commit author and date. Signed-off-by: Vedran Miletić --- src/gallium/state_trackers/nine/nine_dump.c | 21 + src/gallium/state_trackers/nine/nine_dump.h | 21

Re: [Mesa-dev] [PATCH 2/2] clover: Re-order includes in invocation.cpp to fix build

2016-07-20 Thread Vedran Miletić
; +#include "llvm/compat.hpp" +#include "llvm/invocation.hpp" +#include "llvm/metadata.hpp" +#include "llvm/util.hpp" +#include "util/algorithm.hpp" + + using namespace clover; using namespace clover::llvm; The series is: Reviewed-by: Vedran Mi

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Vedran Miletić
On 07/22/2016 03:37 AM, Rob Clark wrote: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we should avoid using such generic names when it is

Re: [Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

2016-07-26 Thread Vedran Miletić
On 07/15/2016 07:27 AM, Edward O'Callaghan wrote: Reviewed-by: Edward O'Callaghan Anything I can do to get this pushed? Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

2016-07-27 Thread Vedran Miletić
On 07/26/2016 10:29 PM, Kenneth Graunke wrote: > On Tuesday, July 26, 2016 5:41:29 PM PDT Vedran Miletić wrote: >> On 07/15/2016 07:27 AM, Edward O'Callaghan wrote: >>> Reviewed-by: Edward O'Callaghan >>> >> >> Anything I can do to get this push

Re: [Mesa-dev] oldest gcc version to support ?

2016-08-04 Thread Vedran Miletić
> > (anyways, it's just for non-autoconf builds) > > If there aren't too many I would keep them. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-05-27 Thread Vedran Miletić
OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or double) quotes before passing the argument to the compiler. Since we call Clang as a library, we have to

[Mesa-dev] [PATCH] clover: Compute aligned size for scalar argument

2016-05-27 Thread Vedran Miletić
Scalar arguments are aligned to the next power of two per OpenCL 1.2 specification, Ch. 6.1.5: "A built-in data type that is not a power of two bytes in size must be aligned to the next larger power of two." We already compute size aligned to the next power of two in get_kernel_args() and store it

Re: [Mesa-dev] [PATCH 10/10] gallium/radeon: don't use the DMA ring for pipelined buffer uploads

2016-06-01 Thread Vedran Miletić
downsampling from 1200p). Wow! Tested-by: Vedran Miletić Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 6 +- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++- 2 files ch

[Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix from git_sha1.h if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 7 ++- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
Please give it some time for others to weight in before sending out v4. Sure. Sorry for multiple revisions initially. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v4] clover: Update OpenCL version string to match OpenGL

2016-06-05 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v4: dropped #ifdef guards. It would be very nice if this could be considered for 12.0 release. --- src/gallium/state_trackers/clover/api/device.cpp | 5 - src/gal

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-05 Thread Vedran Miletić
On 06/04/2016 10:13 AM, Francisco Jerez wrote: Vedran Miletić writes: OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or double) quotes before passing

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-06-05 Thread Vedran Miletić
On 06/04/2016 04:18 AM, Francisco Jerez wrote: Serge Martin writes: From: Vedran Miletić Make sure that a struct argument did not get compiled into a pointer type with the byval attribute. If we try to handle the pointer with byval, we end up with the pointer size instead of the struct size

Re: [Mesa-dev] [PATCH v1.1 2/2] clover: fix getting scalar args api size

2016-06-05 Thread Vedran Miletić
next power of two, store that in scalar arg object, and later compare that rounded value to sizeof(struct_arg_type) which user has passed via the API. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mes

Re: [Mesa-dev] [PATCH v4] clover: Update OpenCL version string to match OpenGL

2016-06-05 Thread Vedran Miletić
On 06/06/2016 12:44 AM, Vedran Miletić wrote: Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v4: dropped #ifdef guards. It would be very nice if this could be considered for 12.0 release. --- src/gallium

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-06 Thread Vedran Miletić
On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/foo bar/baz" which is going to be sent to Cl

[Mesa-dev] [PATCH v5] clover: Update OpenCL version string to match OpenGL

2016-06-06 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v5: move semicolon to same line as MESA_GIT_SHA1. v4: drop #ifdef guards. v3: add missing include. v2: change CL_DEVICE_VERSION as well. Reviewed-by: Francisco Jerez --

[Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r273191

2016-06-20 Thread Vedran Miletić
setLangDefaults() now requires PreprocessorOptions as an argument. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocatio

Re: [Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r273191

2016-06-21 Thread Vedran Miletić
On 06/21/2016 03:13 AM, Michel Dänzer wrote: On 21.06.2016 08:17, Vedran Miletić wrote: setLangDefaults() now requires PreprocessorOptions as an argument. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [BRANCH] Gallium Radeon cleanups

2016-06-22 Thread Vedran Miletić
eonsi: boolean -> bool, TRUE -> true, FALSE -> false radeonsi: make si_is_format_supported static Please review. I presume the next series will address boolean-> bool in si_state.c. This series is Reviewed-by: Vedran Miletić Marek __

Re: [Mesa-dev] [PATCH 1/4] clover: conditionally use MESA_GIT_SHA1

2016-06-22 Thread Vedran Miletić
On 06/22/2016 02:04 PM, Emil Velikov wrote: From: Emil Velikov Considering how hard/annoying it was for many peoples' workflow to properly generate the macro, it will be demoted to conditionally available with follow-up commits. Cc: mesa-sta...@lists.freedesktop.org Cc: Vedran Mileti

[Mesa-dev] [PATCH] clover: Fix compiling with LLVM >= r315871

2017-10-16 Thread Vedran Miletić
--- src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 5 +++-- src/gallium/state_trackers/clover/llvm/compat.hpp | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/common.cpp b/src/gallium/state_trackers/clover/l

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

2017-10-24 Thread Vedran Miletić
lang::LangAS::Offset; > const clang::InputKind ik_opencl = clang::IK_OpenCL; > #endif > > Thanks for improving the patch. Future-proof thinking: what if the value of clang::LangAS::Default changes from 0 to some other constant? Other than that, this patch is: Reviewed-by: Vedran Miletić Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] clover/llvm: Drop support for LLVM < 3.9.

2017-10-24 Thread Vedran Miletić
v2: remove/inline compat stuff Reviewed-by: Francisco Jerez --- .../state_trackers/clover/llvm/codegen/native.cpp | 8 +- src/gallium/state_trackers/clover/llvm/compat.hpp | 109 + .../state_trackers/clover/llvm/invocation.cpp | 22 +++-- .../state_trackers/clover/l

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

2017-10-26 Thread Vedran Miletić
26.10.2017 u 01:09, Jan Vesely je napisao/la: > On Tue, 2017-10-24 at 15:32 +0200, Vedran Miletić wrote: >> On 10/23/2017 05:24 AM, Jan Vesely wrote: >>> From: Jan Vesely >>> >>> v2: use a more generic compat function >>> >>> Bugzill

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-05-10 Thread Vedran Miletić
+ mgr()->deregisterEHFrames(Addr, LoadAddr, Size); > + } > +#endif >virtual void *getPointerToNamedFunction(const std::string &Name, >bool AbortOnFailure=true) { > return mgr()->get

Re: [Mesa-dev] AMD WX7100 screen display problem on AArch64 architecture server.

2017-12-14 Thread Vedran Miletić
Hi Lvzhihong, we usually track problems like these in Bugzilla so they do not get forgotten. I made a report for you, please CC yourself there and any details you can think of: https://bugs.freedesktop.org/show_bug.cgi?id=104266 Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Building Mesa GIT with LLVM prior to 3.9

2017-09-19 Thread Vedran Miletić
" side, but given that all drivers that Clover works with already require LLVM 3.9, I'd say yes, bump the requirement (this allows us to get rid of three quarter of #if HAVE_LLVM version checks). Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

2017-10-04 Thread Vedran Miletić
th this in mind, there a handful of dead code that we could remove. > That will come with later commits. > > Note: this drops the LLVM 3.6 build from the Travis build. LLVM 3.9 (and > later) are already covered in there. > > Cc: Vedran Miletić > Cc: Jan Vesely > Cc: Aaron Wat

[Mesa-dev] [PATCH v1] clover/llvm: Drop support for LLVM < 3.9.

2017-10-08 Thread Vedran Miletić
--- src/gallium/state_trackers/clover/llvm/compat.hpp | 59 +- .../state_trackers/clover/llvm/invocation.cpp | 2 - .../state_trackers/clover/llvm/metadata.hpp| 30 +-- 3 files changed, 2 insertions(+), 89 deletions(-) diff --git a/src/gallium/state_trac

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Vedran Miletić
On 09/19/2016 08:39 PM, Vedran Miletić wrote: > On 09/07/2016 06:52 PM, Vedran Miletić wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid using such generic names when it is >> possible to do so. >>

Re: [Mesa-dev] [PATCH] radeonsi: fix R600_DEBUG=nooptvariant

2017-01-16 Thread Vedran Miletić
struct si_shader *current = state->current; > struct si_shader *iter, *shader = NULL; > > - if (unlikely(sscreen->b.chip_class & DBG_NO_OPT_VARIANT)) { > + if (unlikely(sscreen->b.debug_flags & DBG_NO_OPT_VARIANT)) { > memset(&key->opt,

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2017-04-05 Thread Vedran Miletić
t website, not to mention easier to maintain. As for the theme, I suggest Guzzle [1] instead; RTD is very pretty, but it's also fairly common, as is Bootswatch. Guzzle is pretty and not so commonly used, as far as my anecdotal experience goes. Regards, Vedran [1] https://github.com/guzzle/guzzl

Re: [Mesa-dev] debian wheezy - r300 bug

2017-04-05 Thread Vedran Miletić
Can you find it in Freedesktop Bugzilla? Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/clover: add space between < and ::

2017-04-19 Thread Vedran Miletić
mention of the compiler and say something along the lines of: "C++11 requires space between < and :: as <: is an alternate spelling for [ (see standard documents ... and ...)." I see you caught all the occurrences. Reviewed-by: Vedran Miletić -- Vedran Miletić vedran.miletic.net

  1   2   >