Re: [Mesa-dev] Question about handling RGBA/BGRA in etnaviv driver

> > Another way that I just realized would be to convert a texture to BGRA the > > first time it's rendered to. > > > > In contrast to the shader solution that has only a one-time overhead. Is > > this a stupid idea for any reason? > We are doing something similar to convert sampled textures to

Re: [Mesa-dev] [PATCH 2/3] etnaviv: keep track of emitted loops

On Wed, Feb 08, 2017 at 12:10:24PM +0100, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Sure why not. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 6 ++ &

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

On Wed, Feb 08, 2017 at 12:10:25PM +0100, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freede

[Mesa-dev] [PATCH 1/2] etnaviv: Update hw header files

) +- common.xml( 23473 bytes, from 2016-12-11 10:32:13) Copyright (C) 2012-2016 by the following authors: - Wladimir J. van der Laan <laa...@gmail.com> diff --git a/src/gallium/drivers/etnaviv/hw/common.xml.h b/src/gallium/drivers/etnaviv/hw/common.xml.h index 8d8ef7d..0f99db2 100644 ---

[Mesa-dev] [PATCH 2/2] etnaviv: Set shader instruction area correctly for GC3000

- Use the same instruction area on GC3000 as the Vivante driver. This allows the same number of instructions on GC3000 as GC2000 instead of half. - Makes sure that the "PE to FE" stall before updating the shader code or constants is hit (which is conditional on vs_offset > 0x4000). This

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

> > >> /* shader object, for linking */ > > >> struct etna_shader { > > >> + uint32_t id; /* for debug */ > > > > > > Do you need this? It can certainly be removed from this patch, but I > > > don't know if you have other stuff building on top of this. > > > > > > > It gets used in

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

> Okay.. I will add the id member in a later patch to etna_shader > object. For the moment > I will pass it as an argument to dump_shader_info(..). Will send a V2 > of that series later the day. To be honest I think it's nonsense to change this now, if you need an id in the shader object then add

Re: [Mesa-dev] mx6q: Cannot run Cinematic demo correctly

On Tue, Mar 14, 2017 at 06:39:32PM +0100, Christian Gmeiner wrote: > > By only reverting: > > > > commit 6c89a728d9e5d072cb504453e73077564c6523d3 > > Author: Wladimir J. van der Laan <laa...@gmail.com> > > Date: Wed Dec 7 12:59:54 2016 + > > &g

Re: [Mesa-dev] [PATCH v2] etnaviv: native fence fd support

za...@pengutronix.de> Patch looks good to me, Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: address review comments > - always call etna_cmd_stream_flush2 > - remove FIXME comment about in_fence_fd storage > - simplify version check and add an ETNA_DRM

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

On Fri, Apr 14, 2017 at 11:57:21PM +0200, Christian Gmeiner wrote: > > +#define INST_OPCODE_IMADLOSAT0 0x004e > > +#define INST_OPCODE_IMADLOSAT0 0x004f > > INST_OPCODE_IMADLOSAT0 got redefined... Second one should be

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

On Sat, Apr 15, 2017 at 07:49:53AM +0200, Wladimir J. van der Laan wrote: > On Fri, Apr 14, 2017 at 11:57:21PM +0200, Christian Gmeiner wrote: > > > +#define INST_OPCODE_IMADLOSAT0 0x004e > > > +#define I

[Mesa-dev] etnaviv: When to use supertiled layout?

Hello, Currently etnaviv chooses supertiled layout always for new resources that can be rendered to, when this is available: bool want_supertiled = screen->specs.can_supertile && !DBG_ENABLED(ETNA_DBG_NO_SUPERTILE); However, etnaviv does not support render *from* supertiled textures

[Mesa-dev] [PATCH 3/3] etnaviv: SINGLE_BUFFER support on GC3000

This patch adds support for the SINGLE_BUFFER feature on GC3000 GPUs, which allows rendering to a single buffer using multiple pixel pipes. This feature is always used when it is available, which means that multi-tiled formats are no longer being used in that case, and all buffers will be normal

[Mesa-dev] [PATCH 1/3] etnaviv: Add chipMinorFeatures4 and 5

Request chipMinorFeatures bitfields 4 and 5 from the drm driver. --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) Adds two further chipminorfeatures words -

[Mesa-dev] [PATCH 2/3] etnaviv: Update includes from rnndb

) - copyright.xml ( 1597 bytes, from 2016-10-29 07:29:22) -- common.xml( 23473 bytes, from 2016-12-11 10:32:13) +- common.xml( 23473 bytes, from 2017-01-07 14:27:54) Copyright (C) 2012-2016 by the following authors: - Wladimir J. van der Laan <laa...@gmail.com> diff --git

[Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

Update to etna_viv commit 411bd69. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common.xml.h| 10 ++-- src/gallium/drivers/etnaviv/hw/isa.xml.h | 75 +

[Mesa-dev] [PATCH v2 1/3] etnaviv: Add chipMinorFeatures4 and 5

Request chipMinorFeatures bitfields 4 and 5 from the drm driver. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 src/gallium/drivers/etnaviv/etnaviv_screen.h | 4 +++- 2 files changed, 15 insertions(+), 1 de

[Mesa-dev] [PATCH v2 3/3] etnaviv: SINGLE_BUFFER support on GC3000

. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 3 ++ src/gallium/drivers/etnaviv/etnaviv_emit.c | 6 ++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 3 ++ src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 +

[Mesa-dev] [PATCH] etnaviv: Supertiled texture support on gc3000

this is just a matter of allowing it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 9 +++-- src/gallium/drivers/etnaviv/etnaviv_texture.c | 10 -- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH] etnaviv: Add support for R8_UNORM textures

R8_UNORM textures can be emulated by means of L8 and a swizzle. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c

[Mesa-dev] [PATCH v2] etnaviv: Add support for ETC2 texture compression

this for sure. (Only enabled on GC3000+ for now, as the GC2000 ETC2 decoder implementation is buggy and we don't work around that) Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c | 11 +++ src/gallium/drivers/e

[Mesa-dev] [PATCH] etnaviv: Use the correct LOG instruction on GC3000

GC3000 has a new LOG instruction, similar to the new SIN and COS instructions. Generate the new instruction sequence when appropriate; there are two occasions, as part of LIT and the generator for the LG2 instruction itself. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --

[Mesa-dev] [PATCH] etnaviv: Reset indexed rendering information when not rendering indexed

A dangling bo object would result in memory corruption while loading a level in ioquake3_opengl2. Fixes a problem introduced in 330d0607ed60fd3edca192e54b4246310f06652f. Fix suggested by Lucas Stach. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/e

Re: [Mesa-dev] [PATCH] etnaviv: Avoid duplicates in formats table

On Fri, Jul 21, 2017 at 02:43:11PM +0200, Lucas Stach wrote: > Am Freitag, den 21.07.2017, 12:49 +0200 schrieb Wladimir J. van der > Laan: > > Remove the following duplicates from the formats table: > > > > - R8G8B8A8_UNORM (V_,_T) > > - R8G8B8X8_UNORM

[Mesa-dev] [PATCH] etnaviv: Clear lbl_usage array correctly

. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c index cc6bfc9..165ab74 100644 --- a/src/g

[Mesa-dev] [PATCH 0/3] etnaviv: Support large shaders on GC3000

rom memory on demand. Small shaders will be uploaded in the usual way. This mimics the behavior of the blob. On GPUs that don't support ICACHE, this patch should make no difference. Wladimir J. van der Laan (3): etnaviv: Update headers from rnndb etnaviv: Unified uniforms support etnaviv:

[Mesa-dev] [PATCH 2/3] etnaviv: Unified uniforms support

is still fixed and hardcoded. It should make no difference on hardware that does not have unified uniform memory. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 19 +++ src/gallium/drivers/etnaviv/etnaviv_internal.

[Mesa-dev] [PATCH 1/3] etnaviv: Update headers from rnndb

Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/hw/state_3d.xml.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/etnaviv/hw/state_3d.xml.h b/src/gallium/drivers/etnaviv/hw/state_3d.xml.h

[Mesa-dev] [PATCH 3/3] etnaviv: Implement ICACHE

rom memory on demand. Small shaders will be uploaded in the usual way. This mimics the behavior of the blob. On GPUs that don't support ICACHE, this patch should make no difference. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compile

[Mesa-dev] [PATCH] etnaviv: Avoid duplicates in formats table

Remove the following duplicates from the formats table: - R8G8B8A8_UNORM (V_,_T) - R8G8B8X8_UNORM (_T,_T) - DXT3_RGBA (_T,_T) Only the first has an effect because the _T overrides the V_ initializer, the latter two were harmless duplications of the same. Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

ender target binding for them. The SPLIT formats are only supported on hardware with multiple pixel pipes. Should this be checked, or is it harmless to advertize them unconditionally? Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --

Re: [Mesa-dev] [PATCH 04/11] etnaviv: pad scanout buffer size to RS alignment

lution. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etnav

Re: [Mesa-dev] [PATCH 02/11] etnaviv: fix memory leak when BO allocation fails

On Fri, Jun 23, 2017 at 05:50:19PM +0200, Lucas Stach wrote: > The resource struct is already allocated at this point and should be > free properly. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> >

Re: [Mesa-dev] [PATCH 05/11] etnaviv: increment correct seqno for external resources

the external view seqno, instead of the base resource seqno. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 5 - > 1 file changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

On Fri, Jun 23, 2017 at 05:50:23PM +0200, Lucas Stach wrote: > This reworks the logic in etna_update_sampler_source to select the > newest resource view for updating the texture view. This should make > the logic easier to follow and fixes texture updates from imported > dma-bufs. Comment in-line

Re: [Mesa-dev] [PATCH 08/11] etnaviv: fold etna_screen_bo_get_handle into etna_resource_get_handle

ng screen specific. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 14 -- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 --- > src/gallium/drivers/etnaviv/etnaviv_screen.

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

rge performance > gains for the render to texture cases). Agreed. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> Regards, Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

deronly scanout allocated > buffers, as the linear modifier is enough to trigger correct handling > of those buffers. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/galliu

Re: [Mesa-dev] [PATCH 09/11] etnaviv: fill in modifier in etna_resource_get_handle

On Fri, Jun 23, 2017 at 05:50:26PM +0200, Lucas Stach wrote: > This allows the state trackers to know the tiling layout of the > resource and pass this through the various userspace protocols. > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Comment inline. Reviewed-by: Wlad

Re: [Mesa-dev] [PATCH 10/11] etnaviv: implement resource creation with modifier

On Fri, Jun 23, 2017 at 05:50:27PM +0200, Lucas Stach wrote: > This allows to create buffers with a specific tiling layout, which is > primarily > used by GBM to allocate the EGL back buffers with the correct tiling/modifier > for use with the scanout engines. > > Signed-off-by: Lucas Stach

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, Aug 04, 2017 at 06:54:12PM +0200, Philipp Zabel wrote: > On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote: > > On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > > > Look up BOs from the name table using the name parameter instead of >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). Good catch. Just out of interest: when is this used, what problems does this cause? Regards, Wladimir

Re: [Mesa-dev] [PATCH 1/5] etnaviv: stop oversizing buffer resources

Good catch! Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:04PM +0200, Lucas Stach wrote: > PIPE_BUFFER is a target enum, not a binding. This caused the driver to > up-align the height of buffer resources, leading to largely oversizing >

Re: [Mesa-dev] [PATCH 3/5] etnaviv: apply feature overrides in one central location

Yes, good idea to do this in one place. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:06PM +0200, Lucas Stach wrote: > This way we can just test the feature bits and don't need to spread > the debug overrides to all locations touchi

Re: [Mesa-dev] [PATCH 5/5] etnaviv: increment the resource seqno in resource_changed

Seems more straightforward, but I don't know the rationale why it was done the way it was. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> On Wed, May 10, 2017 at 06:01:08PM +0200, Lucas Stach wrote: > From: Philipp Zabel <p.za...@pengutronix.de> > > Just increme

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Check extended format availability on GPU

Hello Philipp, On Tue, May 16, 2017 at 04:33:34PM +0200, Philipp Zabel wrote: > Hi Wladimir, > > On Tue, 2017-05-16 at 10:42 +0200, Wladimir J. van der Laan wrote: > > Current information shows that both extended texture/render formats > > and texture swizzling were intro

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

On Tue, May 16, 2017 at 09:31:38PM +0200, Christian Gmeiner wrote: > Hi Wladimir. > > I started working on this topic last week and thought some time on how > to add those ext texture formats in a clean and nice way. I come up > with this patches: > >

[Mesa-dev] [PATCH 3/3] etnaviv: Check extended format availability on GPU

Current information shows that both extended texture/render formats and texture swizzling were introduced with the HALTI0 feature bit, available on GC2000/GC3000. --- src/gallium/drivers/etnaviv/etnaviv_format.c | 12 src/gallium/drivers/etnaviv/etnaviv_format.h | 3 +++

[Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

This adds support for extended texture formats through TEXTURE_FORMAT_EXT. Two of these extended formats are added: - R8_SNORM - R8G8_UNORM --- src/gallium/drivers/etnaviv/etnaviv_format.c | 49 ++- src/gallium/drivers/etnaviv/etnaviv_format.h | 3 ++

[Mesa-dev] [PATCH 2/3] etnaviv: Add support for swizzled texture formats

--- src/gallium/drivers/etnaviv/etnaviv_format.c | 50 +-- src/gallium/drivers/etnaviv/etnaviv_format.h | 3 ++ src/gallium/drivers/etnaviv/etnaviv_texture.c | 15 +--- 3 files changed, 54 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [RFC] etnaviv: flush color cache and depth cache together before resolves

On Tue, May 30, 2017 at 12:50:07PM +0200, Philipp Zabel wrote: > Before resolving a rendertarget or a depth/stencil resource into a > texture, flush both the color cache and the depth cache together. > > It is unclear whether this is necessary for the following stall to > work properly, or

Re: [Mesa-dev] [libdrm 4/4] etnaviv: support performance monitor requests

On Fri, Jun 09, 2017 at 12:27:37PM +0200, Christian Gmeiner wrote: > Add etna_cmd_stream_perf(..) to submit perform requests. > Userspace can submit pmrs via submit ioctl to sample perfmon > signals. Comment in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

On Mon, Jun 05, 2017 at 09:11:02PM +0200, Lucas Stach wrote: > Same as with the colormasks, the blend color needs to be swizzled according > to the rendertarget format. Yes, indeed. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <d...@lynxeye.de> > --- >

Re: [Mesa-dev] [libdrm 2/4] etnaviv: sync uapi header

monitor domains and their signals. Looks straightforward. Cannot find the associated kernel patch, so I could not check if the interface matches. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> &g

Re: [Mesa-dev] [libdrm 3/4] etnaviv: add permon support

On Fri, Jun 09, 2017 at 12:27:36PM +0200, Christian Gmeiner wrote: > Query all domains and their signals and provide it this information > via struct etna_perfmon and the corresponding api functions. Comments in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH] etnaviv: add rs-operations sw query

t path - should we count these too?) Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + > src/gallium/drivers/etnaviv/etnaviv_emit.c | 2

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > Passes all ext_texture_swizzle piglits. You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture formats have implicit non-identity swizzle. I do think that is necessary as those formats don't work on

Re: [Mesa-dev] [PATCH 4/4] etnaviv: add support for snorm textures

On Wed, Jun 21, 2017 at 10:36:48PM +0200, Christian Gmeiner wrote: > Based on a patch from Wladimir J. van der Laan and untested due > to lack of hardware. Binary blob emits those formats if GPU supports > HALTI1 (faked with ibvivhook). Reviewed-by: Wladimir J. van der Laan <laa.

Re: [Mesa-dev] [PATCH 1/4] etnaviv: add support for extended texture formats

On Wed, Jun 21, 2017 at 10:36:45PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- > src

Re: [Mesa-dev] [PATCH 3/4] etnaviv: add R8G8 texture support

On Wed, Jun 21, 2017 at 10:36:47PM +0200, Christian Gmeiner wrote: > Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support). Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com>

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

On Sat, Jun 24, 2017 at 10:41:58AM +0200, Christian Gmeiner wrote: > Hi > > 2017-06-22 14:39 GMT+02:00 Wladimir J. van der Laan <laa...@gmail.com>: > > On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > >> Passes all ext_texture_swizzle piglits. &g

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

> I can confirm that 11 bit stuff works on the GC2000 . I used piglit's > oes_compressed_etc2_texture-miptree_gles3 for verification. > How have you tested these formats? I rendered the example images from https://github.com/Ericsson/ETCPACK/tree/master/testing/testvectors_correct/pkm, which

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > > sure if we should advertise the broken formats (on gpus with HALTI0). FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok. Wladimir ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

> Thx - will send out updated patches the next days. I quite busy with > lot of stuff atm but > a long weekend is coming :) Yeah np I could update my patches to that too and re-send them if that is more convenient, Wladimir ___ mesa-dev mailing list

[Mesa-dev] [PATCH 4/3] etnaviv: Add support for ETC2 texture compression

Add support for ETC2 compressed textures in the etnaviv driver. These are available on GC2000+. One step closer towards GL ES 3 support. --- src/gallium/drivers/etnaviv/etnaviv_format.c | 11 +++ 1 file changed, 11 insertions(+) Mesa does not export the ETC2 formats without OpenGL ES 3,

Re: [Mesa-dev] [PATCH 1/6] etnaviv: always do cpu_fini in transfer_unmap

o do > so at a later point in time. If there is a temporary resource the fini needs > to happen before the RS uses this one as the source for the upload. > > Also remove an invalid comment about flushing CPU caches, cpu_fini takes > care of everything involved in this. Reviewed-By:

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

he coherent which you mention), so Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Am Freitag, den 19.05.2017, 11:41 +0200 schrieb Lucas Stach: > > Stolen from VC4. As we don't do any fancy reallocation tricks yet, it's > > possible to upgrade also coher

Re: [Mesa-dev] [PATCH 1/2] etnaviv: don't flush resource to self without TS

<d...@lynxeye.de> Does this take into account the case on GC2000, where there can be a texture resource that is out of date with the rendered-to resource? If so: Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.h |

Re: [Mesa-dev] [PATCH 2/6] etnaviv: slim down resource waiting

On Fri, May 19, 2017 at 11:41:08AM +0200, Lucas Stach wrote: > cpu_prep() already does all the required waiting, so the only thing that > needs to be done is flushing the commandstream, if a GPU write is pending. Looks good to me. Reviewed-By: Wladimir J. van der Laan <laa...@

Re: [Mesa-dev] glmark2 segfault on imx6

Hello Fabio, Can you get a traceback using gdb? That'd be very useful to find out where in the driver this crash happens. Regards, Wladimir On Tue, Jun 13, 2017 at 04:20:23PM -0300, Fabio Estevam wrote: > Hi, > > I am running kernel 4.11.4 with Etnaviv 17.1.2 on a imx6qsabresd board > and

Re: [Mesa-dev] [PATCH 3/6] etnaviv: honor PIPE_TRANSFER_UNSYNCHRONIZED flag

there exists a temporary resource, as those ones are > never busy. OK. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 22 ++ >

Re: [Mesa-dev] [PATCH 4/6] etnaviv: don't read back resource if transfer discards contents

rce don't matter if DISCARD_WHOLE_RESOURCE. Reviewed-By: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --

Re: [Mesa-dev] [PATCH 5/6] etnaviv: simplify transfer tiling handling

ood to me. Resource layout is explicit, and not dependent on the compressed-ness of the texture format. Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 70 > +++

Re: [Mesa-dev] [PATCH 01/11] etnaviv: fill in layer_stride for imported resources

On Fri, Jun 23, 2017 at 05:50:18PM +0200, Lucas Stach wrote: > The layer stride information is used in various parts of the driver, > so it needs to be present regardless if the driver allocated the > buffer itself or merely imported it from an external source. Reviewed-by: Wladimir J

[Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

Add support for ETC2 compressed textures in the etnaviv driver. One step closer towards GL ES 3 support. For now, treat SRGB and RGB formats the same. It looks like these are distinguished using a different bit in sampler state, and not part of the format, but I have not yet been able to confirm

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 02:54:56PM +0200, Wladimir J. van der Laan wrote: > Add support for ETC2 compressed textures in the etnaviv driver. > > One step closer towards GL ES 3 support. > > For now, treat SRGB and RGB formats the same. It looks like these are > distinguished usi

Re: [Mesa-dev] [PATCH 1/3] etnaviv: support tile aligned RS blits

On Fri, Sep 15, 2017 at 06:00:52PM +0200, Lucas Stach wrote: > The RS can blit abitrary tile aligned subregions of a resource by > adjusting the buffer offset. Thanks for doing this. Comments inline, > Signed-off-by: Lucas Stach > --- >

Re: [Mesa-dev] [PATCH 2/3] etnaviv: add resource subregion copy

On Fri, Sep 15, 2017 at 06:00:53PM +0200, Lucas Stach wrote: > This is useful if we only need to copy part of a larger resource, mostly > when using the RS engine to de-/tile on pipe transfers. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J.

Re: [Mesa-dev] [PATCH] etnaviv: fix 16bpp clears

asked off. > > I've only observed the issue with R5G6B5_UNORM surfaces, other 16bpp > formats seem to work fine. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > > Fixes: d6aa2ba2b2 (etnaviv: replace translate_clear_color with > util_pack_color) > Cc: mesa-s

[Mesa-dev] [PATCH] etnaviv: Add missing includes after 6ace0b8

Add missing includes after 6ace0b8 (etnaviv: don't enable RT full-overwrite when logicop is enabled), otherwise the etnaviv driver won't build because of missing macros. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_blend.c | 2 ++

Re: [Mesa-dev] [PATCH 1/2] etnaviv: move sw get_driver_query_info(..)

ail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_query.c| 15 +++ > src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 21 + > src/gallium/drivers/etnaviv/etnaviv_query_sw.h | 4 &

Re: [Mesa-dev] [PATCH 2/2] etnaviv: move sw query defines to etnaviv_query_sw.h

On Tue, Sep 19, 2017 at 06:16:05PM +0200, Christian Gmeiner wrote: > Also add new define ETNA_SW_QUERY_BASE. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etn

Re: [Mesa-dev] [PATCH v2 1/2] etnaviv: fix varying interpolation

_USE_POINTCOORD is a bit of a misnomer now, as it isn't > only used for pointcoords, but missing a better name I left it as-is. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: fix invalid vreg assig

Re: [Mesa-dev] [PATCH v2 2/2] etnaviv: remove flat shading workaround

nix.de> > Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

On Wed, Oct 04, 2017 at 11:44:32AM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed etnaviv change only. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/g

Re: [Mesa-dev] [PATCH 2/2] etnaviv: rework TS enable to be a derived state

> Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Keeping the TS memory config state up to date with our internal state is a good idea. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 5 +-- >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: skip unused vertex attributes when assigning VS inputs

rwrite other valid inputs otherwise. > > Fixes piglit drawpixels and a bunch of other tests using the st_draw path. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> __

Re: [Mesa-dev] [PATCH v3 1/2] etnaviv: fix varying interpolation

me cases. Regards, Wladimir > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> > Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: fix invalid vreg assignment > v3: fix missed negat

[Mesa-dev] [PATCH v2] etnaviv: Do GC3000 resolve-in-place when possible

doing i.MX6qp scanout using PRE, and when rendering to textures (though here using sampler TS would be even better). Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c

Re: [Mesa-dev] [PATCH] etnaviv: Do GC3000 resolve-in-place when possible

On Fri, Sep 29, 2017 at 06:00:13PM +0200, Wladimir J. van der Laan wrote: > If an RS blit is done with source exactly the same as destination, and > the hardware supports this, do an in-place resolve. > > This is the same as the blob does and potentially saves significant > bandw

[Mesa-dev] [PATCH 0/2] etnaviv: Support opcode bit 6 assembler, add DP2 instruction

Support opcodes with bit 6 set in assembler, then use that to add the DP2 instruction, supported with HALTI2. Wladimir J. van der Laan (2): etnaviv: Support opcodes with bit 6 set in assembler etnaviv: Add support for DP2 instruction src/gallium/drivers/etnaviv/etnaviv_asm.c | 5

[Mesa-dev] [PATCH 1/2] etnaviv: Support opcodes with bit 6 set in assembler

Support opcodes with bit 6 set in assembler, and assert that only ops 0x00..0x7f are used. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_asm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 2/2] etnaviv: Add support for DP2 instruction

A two-component dot product instruction is supported with HALTI2, use it on hardware that supports it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 3 ++- src/gallium/drivers/etnaviv/etnaviv_disasm.c | 1 + src/gallium/d

[Mesa-dev] [PATCH v2 2/2] etnaviv: Set up unknown GC3000 states

Set up new states that the blob started setting for GC3000 consistently. This makes sure that when another test or driver leaves the GPU in unpredictable state, these states are set up correctly for our rendering. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/g

[Mesa-dev] [PATCH v2 1/2] etnaviv: Fix point sprite rendering on GC3000

Setting PA_VIEWPORT_UNK state correctly is necessary to make point sprite rendering on GC3000 work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH v2 0/2] etnaviv: Set up GC3000 states, fix point sprite rendering

sprite rendering on GC3000 work. Wladimir J. van der Laan (2): etnaviv: Fix point sprite rendering on GC3000 etnaviv: Set up unknown GC3000 states src/gallium/drivers/etnaviv/etnaviv_context.c | 13 + 1 file changed, 13 insertions(+) -- 2.7.4

Re: [Mesa-dev] [PATCH] etnaviv: Set up GC3000 states, fix point sprite rendering

On Sun, Oct 01, 2017 at 01:46:05PM +0200, Christian Gmeiner wrote: > Okay.. hopefully we do not forget to remove them here when it gets > used during state emission like PE_ALPHA_COLOR_EXT0. But I > am fine with that change and will shut up. Yes, it should be removed then. Though if I understand

Re: [Mesa-dev] [PATCH] etnaviv: fix bogus flush requests in transfer handling

Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) >

[Mesa-dev] [PATCH] etnaviv: Do GC3000 resolve-in-place when possible

TS would be even better). Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 9 - src/gallium/drivers/etnaviv/etnaviv_rs.c | 16 +--- src/gallium/drivers/etnaviv/etnaviv_rs.h | 1 + 3 files changed, 22 inse

Re: [Mesa-dev] [PATCH] etnaviv: update HW headers and fix provoking vertex

cas Stach <l.st...@pengutronix.de> Thanks for figuring this one out Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com>: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 3 +- > src/gallium/drivers/etnaviv/hw/cmdstream.xml.h

  1   2   3   >