Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-05 Thread Dave Airlie
On Mon, Apr 5, 2010 at 5:24 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 1:41 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Apr 5, 2010 at 2:37 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 12:00 PM, Dave Airlie airl...@gmail.com wrote: The attached patch

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-05 Thread Chia-I Wu
On Mon, Apr 5, 2010 at 3:38 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Apr 5, 2010 at 5:24 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 1:41 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Apr 5, 2010 at 2:37 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-05 Thread Dave Airlie
On Mon, Apr 5, 2010 at 6:06 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 3:38 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Apr 5, 2010 at 5:24 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 1:41 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Apr 5, 2010 at

[Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Dave Airlie
Hey, So I was trying to fix tfp test on r300g, and ran into an issue with dri st I think. So the way TFP works we get dri2_set_tex_buffer, which then validates the attachment, but ignores the format passed in. So r300g picks up the kernel buffer from the handle and sets up the texture + texture

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Dave Airlie
On Sun, Apr 4, 2010 at 8:31 PM, Dave Airlie airl...@gmail.com wrote: Hey, So I was trying to fix tfp test on r300g, and ran into an issue with dri st I think. So the way TFP works we get dri2_set_tex_buffer, which then validates the attachment, but ignores the format passed in. So r300g

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Dave Airlie
Here's a hacky patch to demonstrate the issue, though it doesn't fix the problem I'm seeing with the test, just one less thing wrong. Here's a second patch that actually fixes the piglit tfp test for me on r300g. Dave. 0001-dri-st-add-hacky-tfp-format-override-v2.patch Description:

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Chia-I Wu
On Sun, Apr 4, 2010 at 6:31 PM, Dave Airlie airl...@gmail.com wrote: Hey, So I was trying to fix tfp test on r300g, and ran into an issue with dri st I think. So the way TFP works we get dri2_set_tex_buffer, which then validates the attachment, but ignores the format passed in. So r300g

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Dave Airlie
On Mon, Apr 5, 2010 at 12:49 PM, Chia-I Wu olva...@gmail.com wrote: On Sun, Apr 4, 2010 at 6:31 PM, Dave Airlie airl...@gmail.com wrote: Hey, So I was trying to fix tfp test on r300g, and ran into an issue with dri st I think. So the way TFP works we get dri2_set_tex_buffer, which then

Re: [Mesa3d-dev] dri2 st + tfp set tex buffer2

2010-04-04 Thread Dave Airlie
On Mon, Apr 5, 2010 at 2:37 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Apr 5, 2010 at 12:00 PM, Dave Airlie airl...@gmail.com wrote: The attached patch fixes tfp test for me (with i915g).  Could you see if r300g passes the test with the patch? The teximage callback has an internal_format