Re: [meta-intel] [PATCH] gstreamer-vaapi and libva: check for opengl feature.

[Ylinen, Mikko]

Hi,

On Thu, Dec 1, 2016 at 10:09 AM, Puustinen, Ismo 
wrote:

> > While these patches are the same, I would prefer if we had 2 distinct
> > patches for libva and gstreamer-vaapi.
>
> Ok, I'll split the patch in two.
>
> > Is this related to what Mikko found recently with gstreamer-plugins-
> > bad?  I believe there was a missing dependency there also.
>
> I think this is related, yes, but not directly. The goal in both this
> and Mikko's work is to let the DISTRO_FEATURES guide the way how
> various gstreamer components are built. At this moment it's the other
> way around (gstreamer components require various distribution features
> in order to build, pulling in too many dependencies).
>

Saul, this is a new observation Ismo made yesterday. My findings are also
about opengl but they are different. I think I'll just submit patches for
those
too.

-- Mikko
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] gstreamer-vaapi and libva: check for opengl feature.

[Puustinen, Ismo]

> While these patches are the same, I would prefer if we had 2 distinct
> patches for libva and gstreamer-vaapi.

Ok, I'll split the patch in two.

> Is this related to what Mikko found recently with gstreamer-plugins-
> bad?  I believe there was a missing dependency there also.

I think this is related, yes, but not directly. The goal in both this
and Mikko's work is to let the DISTRO_FEATURES guide the way how
various gstreamer components are built. At this moment it's the other
way around (gstreamer components require various distribution features
in order to build, pulling in too many dependencies).

Ismo
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] gstreamer-vaapi and libva: check for opengl feature.

[Wold, Saul]

On Wed, 2016-11-30 at 16:26 +0200, Ismo Puustinen wrote:
> In case "opengl" is missing from DISTRO_FEATURES, libva fails to
> satisfy
> its dependencies. The dependency check is done by BitBake when
> meta-world-pkgdata gathers information about all available packages
> during image builds, even if libva isn't included in the build. This
> patch makes libva recipe be skipped if the "opengl" DISTRO_FEATURE
> isn't
> found.
> 
> Since missing libva breaks gstreamer-vaapi-1.0 build, the same check
> is
> done in gstreamer-vaapi-1.0 recipe too.
> 
Ismo,

While these patches are the same, I would prefer if we had 2 distinct
patches for libva and gstreamer-vaapi.

Is this related to what Mikko found recently with gstreamer-plugins-
bad?  I believe there was a missing dependency there also.

Sau!

> Signed-off-by: Ismo Puustinen 
> ---
>  common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc | 4 +++-
>  common/recipes-multimedia/libva/libva_1.7.2.bb  | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
> b/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
> index 6dea9cf..59b0324 100644
> --- a/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
> +++ b/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
> @@ -16,7 +16,9 @@ SRC_URI = "https://gstreamer.freedesktop.org/src/${
> REALPN}/${REALPN}-${PV}.tar.x
>  
>  S = "${WORKDIR}/${REALPN}-${PV}"
>  
> -inherit autotools pkgconfig gtk-doc
> +inherit autotools pkgconfig gtk-doc distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES ?= "opengl"
>  
>  PACKAGES =+ "${PN}-tests"
>  
> diff --git a/common/recipes-multimedia/libva/libva_1.7.2.bb
> b/common/recipes-multimedia/libva/libva_1.7.2.bb
> index d72074d..860ab77 100644
> --- a/common/recipes-multimedia/libva/libva_1.7.2.bb
> +++ b/common/recipes-multimedia/libva/libva_1.7.2.bb
> @@ -24,7 +24,9 @@ SRC_URI[sha256sum] =
> "5dd61cf16a5648b680e6146a58064e93be11bf4e65a9e4e30f1e9cb8ec
>  
>  DEPENDS = "libdrm virtual/mesa virtual/libgles1 virtual/libgles2
> virtual/egl"
>  
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES ?= "opengl"
>  
>  EXTRA_OECONF = "--disable-dummy-driver"
>  
> -- 
> 2.9.3
> 
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

[meta-intel] [PATCH] gstreamer-vaapi and libva: check for opengl feature.

[Ismo Puustinen]

In case "opengl" is missing from DISTRO_FEATURES, libva fails to satisfy
its dependencies. The dependency check is done by BitBake when
meta-world-pkgdata gathers information about all available packages
during image builds, even if libva isn't included in the build. This
patch makes libva recipe be skipped if the "opengl" DISTRO_FEATURE isn't
found.

Since missing libva breaks gstreamer-vaapi-1.0 build, the same check is
done in gstreamer-vaapi-1.0 recipe too.

Signed-off-by: Ismo Puustinen 
---
 common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc | 4 +++-
 common/recipes-multimedia/libva/libva_1.7.2.bb  | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc 
b/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
index 6dea9cf..59b0324 100644
--- a/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
+++ b/common/recipes-multimedia/gstreamer/gstreamer-vaapi.inc
@@ -16,7 +16,9 @@ SRC_URI = 
"https://gstreamer.freedesktop.org/src/${REALPN}/${REALPN}-${PV}.tar.x
 
 S = "${WORKDIR}/${REALPN}-${PV}"
 
-inherit autotools pkgconfig gtk-doc
+inherit autotools pkgconfig gtk-doc distro_features_check
+
+REQUIRED_DISTRO_FEATURES ?= "opengl"
 
 PACKAGES =+ "${PN}-tests"
 
diff --git a/common/recipes-multimedia/libva/libva_1.7.2.bb 
b/common/recipes-multimedia/libva/libva_1.7.2.bb
index d72074d..860ab77 100644
--- a/common/recipes-multimedia/libva/libva_1.7.2.bb
+++ b/common/recipes-multimedia/libva/libva_1.7.2.bb
@@ -24,7 +24,9 @@ SRC_URI[sha256sum] = 
"5dd61cf16a5648b680e6146a58064e93be11bf4e65a9e4e30f1e9cb8ec
 
 DEPENDS = "libdrm virtual/mesa virtual/libgles1 virtual/libgles2 virtual/egl"
 
-inherit autotools pkgconfig
+inherit autotools pkgconfig distro_features_check
+
+REQUIRED_DISTRO_FEATURES ?= "opengl"
 
 EXTRA_OECONF = "--disable-dummy-driver"
 
-- 
2.9.3

-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel