Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Liu Hao
On 2017/5/2 12:04, David Grayson wrote: > Thanks for the info. > > I used "git blame" on guiddef.h and it looks like the logic has been the > same since 2007. I don't see any sign that Kai removed the > DECLSPEC_SELECTANY from the GUID declarations, as far as I know it was just > always missing. >

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread David Grayson
Thanks for the info. I used "git blame" on guiddef.h and it looks like the logic has been the same since 2007. I don't see any sign that Kai removed the DECLSPEC_SELECTANY from the GUID declarations, as far as I know it was just always missing. So the code has been the same for 10 years, but the

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Liu Hao
On 2017/5/2 3:08, David Grayson wrote: > Oops, I should have learned my lesson. Well, here it is again. I think my > original email 6 days ago was good though. I did see the patch and we had a discussion on irc. That attribute seemed to have been removed for a reason, which otherwise caused erro

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread David Grayson
Oops, I should have learned my lesson. Well, here it is again. I think my original email 6 days ago was good though. --David On Mon, May 1, 2017 at 11:47 AM, Ruben Van Boxem wrote: > Your attachment was eaten by the Sourceforge cookie monster :) > > > > 2017-05-01 18:55 GMT+02:00 David Grayso

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Ruben Van Boxem
Your attachment was eaten by the Sourceforge cookie monster :) 2017-05-01 18:55 GMT+02:00 David Grayson : > I sent a patch to this list 6 days ago that fixes a problem with the way we > use the selectany attribute. If you're getting multiple definition errors > for GUIDs, this will probably fi

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread David Grayson
I sent a patch to this list 6 days ago that fixes a problem with the way we use the selectany attribute. If you're getting multiple definition errors for GUIDs, this will probably fix it. I'll attach it again. --David On Mon, May 1, 2017 at 9:34 AM, Mateusz Mikuła wrote: > Symbols in libuuid.

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Mateusz Mikuła
Symbols in libuuid.a are definitely duplicated, tested on MSYS2, Ubuntu, Arch: nm '/usr/x86_64-w64-mingw32/lib/libuuid.a' | grep FileProtocol R CLSID_FileProtocol r .rdata$CLSID_FileProtocol 00f0 R CLSID_FileProtocol Here is disassembly of first dupli

Re: [Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Liu Hao
On 2017/5/1 21:27, Tomay wrote: > The following UUIDs are defined in both *uuid.c* and *extra-uuid.c* source > files, whitch leads to linking errors with duplicate symbols when using > *libuuid.a* > In my opinion it is practically incorrect, but you shouldn't get linker errors because the macro `I

[Mingw-w64-public] Duplicate symbols definition in between uuid.c and extra-uuid.c

2017-05-01 Thread Tomay
The following UUIDs are defined in both *uuid.c* and *extra-uuid.c* source files, whitch leads to linking errors with duplicate symbols when using *libuuid.a* // file: local: Asychronous Pluggable Protocol Handler CLSID DEFINE_GUID(CLSID_FileProtocol,0x79eac9e7,0xbaf9,0x11ce,0x8c,0x82,0,0xaa,0,0x4