Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Adrien Nader
Hi, The implication of this change would be that you need a separate toolchain to target these OSes and 5.x is not going to be abandoned tomorrow, which gives you plenty of time. I've followed the support from browsers and FF 53 which is an ESR is the last browser to support XP. Since it's recent

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Martell Malone
> > Am I mistaken in that the patch affects the CRT? In which case, defining > _WIN32_WINNT would only be useful at the point of building mingw-w64 itself > - building and maintaining our own mingw-w64 is not an option for us with > our current build pipeline, as we rely on mingw-builds currently.

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Riot
*sorry, I meant unable to build for win xp sp2 using mingw-w64. It's not a show stopper as that's a very small minority of our customers who are affected, and they're already used to everyone else dropping support for them - but it seems unnecessary to take away something that's working fine, and

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Riot
Haha, no - although I do work for a game company, I'd rather not say which on-list. Am I mistaken in that the patch affects the CRT? In which case, defining _WIN32_WINNT would only be useful at the point of building mingw-w64 itself - building and maintaining our own mingw-w64 is not an option fo

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread David Grayson
Riot, do you work for Riot Games? Anyway, in this patch, the line of code being changed is guarded by #ifndef _WIN32_WINNT. So if you define _WIN32_WINNT yourself, this patch will have no effect on you. (I'm assuming that the value of _WIN32_WINNT does not affect how the MinGW libraries are comp

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Riot
I'd like to humbly request a hold on this. If it's not broken, why fix it? I've been happy to be able to tell our customers that our software works on win XP (SP2) for a long while; and I don't see anything that's changed that should require us to end that support. When we surveyed last year, se

Re: [Mingw-w64-public] [PATCH] remove cast to int from mantissa for __mingw_printf

2017-06-12 Thread lhmouse
On 2017/6/12 23:24, Martell Malone wrote: > In this thread https://sourceforge.net/p/mingw-w64/bugs/459/ > there is a suggested fix for print with whole numbers > > The builtin __mingw_printf is inconsistent with printf on %a format. >> I think __mingw_printf is wrong, because obviously 1.0 != 0x0

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Liu Hao
On 2017/6/12 23:17, Martell Malone wrote: In that case, I think the best course of immediate action is to bump to Windows 7 as Kai suggested. If someone has the time to implement a configure option for changing this default like Ruben suggest that would be a great. Here is a patch for the former.

Re: [Mingw-w64-public] [PATCH] remove cast to int from mantissa for __mingw_printf

2017-06-12 Thread Mateusz MikuĊ‚a
All patches for mingw-64 should be signed off. -- Original Message -- Subject: [Mingw-w64-public] [PATCH] remove cast to int from mantissa for __mingw_printf Date: Mon, 12 Jun 2017 16:24:17 +0100 To: Mingw-w64-public From: Martell Malone > In this thread https://sourceforge.net/p/mingw-w6

[Mingw-w64-public] [PATCH] remove cast to int from mantissa for __mingw_printf

2017-06-12 Thread Martell Malone
In this thread https://sourceforge.net/p/mingw-w64/bugs/459/ there is a suggested fix for print with whole numbers The builtin __mingw_printf is inconsistent with printf on %a format. > I think __mingw_printf is wrong, because obviously 1.0 != 0x0p-63. vacaboja opened an issue on msys2 for this

Re: [Mingw-w64-public] Default _WIN32_WINNT version too low?

2017-06-12 Thread Martell Malone
In that case, I think the best course of immediate action is to bump to Windows 7 as Kai suggested. If someone has the time to implement a configure option for changing this default like Ruben suggest that would be a great. Here is a patch for the former. Please Review diff --git a/mingw-w64-heade