Re: [Mingw-w64-public] [PATCH] DFP: fix typos and errors caught by GCC 15

在 2024-05-18 13:25, JonY via Mingw-w64-public 写道: Attached patch OK? Looks good to me. Thanks. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH v2 1/3] headers: Use the __MINGW_(MS|GNU)_(PRINTF|SCANF) macros

在 2024-05-17 08:11, Jacek Caban 写道: Hi, The series looks good to me. LGTM, too. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] include/minwinbase: Fix enumerators of `FILE_INFO_BY_HANDLE_CLASS`

在 2024-05-17 05:09, Martin Storsjö 写道: On Wed, 15 May 2024, LIU Hao wrote: -- LGTM, thanks! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw

Re: [Mingw-w64-public] [PATCH 2/2] headers: Don't use the ms_printf/scanf and gnu_printf/scanf format attributes with clang

_args))) i.e. reserved names are to be used within standard headers. What do you think? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH 1/2] headers: Use the __MINGW_(MS|GNU)_(PRINTF|SCANF) macros

LGTM. Thanks. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] include/minwinbase: Fix enumerators of `FILE_INFO_BY_HANDLE_CLASS`

-- Best regards, LIU Hao From 69f03c142bb14924066af35ff2559f253147ed80 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Wed, 15 May 2024 22:32:10 +0800 Subject: [PATCH] include/minwinbase: Fix enumerators of `FILE_INFO_BY_HANDLE_CLASS` Closes https://github.com/mingw-w64/mingw-w64/issues/48

Re: [Mingw-w64-public] [PATCH v2 7/7] crt: Move find, stat and time aliases to def-include/msvcrt-common.def.in

regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt/libsrc: Include mfmediaengine.h in mfuuid library

-packages/issues/20806 Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/libsrc/mfuuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] Strange affect of "-std=c99" on 32-bit gcc

e precise than `double` and does not equal `0x1.fp+1023` due to the extra significant bits. x86-64 is not subject to this, as SSE registers are exact `double` and there is no excess precision. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] crt: execv*/spawnv* const-correctness

ever prefer `_execve()` because it's a Unix relic. It would not be very useful without `fork()`. And we probably should not be reproducing Unix too much. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw

Re: [Mingw-w64-public] [PATCH 2/7] crt: msvcr90d.def.in: Fix I386 symbol alias _wfindnext

(renaming) indicates that a function called `foo` exists in the DLL's source code, and it is exported as `bar`. `bar` may and may not contain an `@` suffix, as the use varies. [1] https://sourceware.org/binutils/docs/binutils/def-file-format.html -- Best regards, LIU Hao OpenPGP_sig

Re: [Mingw-w64-public] [PATCH] headers: Add tcpxcv.h

Nath --- mingw-w64-headers/include/tcpxcv.h | 92 ++ 1 file changed, 92 insertions(+) create mode 100644 mingw-w64-headers/include/tcpxcv.h Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] winpthreads: add a .gitignore

since SVN days. One advantage of SVN over Git is that it allows checking out subdirectories, so this was not an issue. Not sure about the precise reason though. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___

Re: [Mingw-w64-public] [PATCH] winpthreads: add a .gitignore

the top-level one. (BTW I don't think it's necessary; you can fork mingw-w64 as a whole, and it makes rebasing automatic and easier.) -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] winpthreads: Avoid using MemoryBarrier() in public headers with GCC/Clang

ic_seq_cst`) instead of a load-store barrier (`atomic_acq_rel`)., and the barriers are there to prevent partial writes in case of asynchronous cancellation. The patch looks correct to me. Please go ahead and apply. Thanks. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenP

Re: [Mingw-w64-public] [PATCH] winpthreads: Avoid using MemoryBarrier() in public headers with GCC/Clang

der_seq_cst) #else /* C11 */ # include # define __pthread_MemoryBarrier() \ atomic_thread_fence(memory_order_seq_cst) #endif -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-pub

Re: [Mingw-w64-public] [PATCH 6/6] crt: msvcr80.def.in: Fix __fls_getvalue@4 and __fls_setvalue@8 symbols

. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: execv*/spawnv* const-correctness

在 2024-04-19 16:00, LIU Hao 写道: The conversion from `char**` to `const char* const*` is only implicit in C++, and not in C. The POSIX prototypes have only one `const` [1]. The Microsoft variants do have double `const` [2], so I think the proposed patch may be acceptable, as long as users have

Re: [Mingw-w64-public] [PATCH] crt: execv*/spawnv* const-correctness

char* const* pp); | ~~~^~ -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix some symbols with duplicate stdcall suffixes

在 2024-04-17 05:08, Martin Storsjö 写道: Thanks, I think this one looks reasonable. Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix some symbols with duplicate stdcall suffixes

, it's probably ok to just remove them, or remove the symbols and leave comments explaining the sitaution. Well, I think this awkward DEF should be kept for backward compatibility. An updated patch is attached. -- Best regards, LIU Hao From cf60a31beaccfd85c7bde845b5003e402450b98b Mon Sep

Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix some symbols with duplicate stdcall suffixes

2.def', the only two functions which it exports have changed to __cdecl, and require an incompatible header (which doesn't exist however). Another option would be to just drop this file. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenP

Re: [Mingw-w64-public] [PATCH] crt: msvcr70.def.in: Add missing @SIZE suffixes and __CxxCallUnwindVecDtor

clang supports something? If these are functions necessary by the Microsoft compiler (random posts on Google suggest they have been there to work around the Intel division bug) and not meant to be called by users, maybe we just shouldn't provide them. -- Best regards, LIU Hao

[Mingw-w64-public] [PATCH 2/2] crt: Fix some symbols with duplicate stdcall suffixes

'msvcrt-common.def.in' to 'func.def.in' so they can be reused. Previously they were only used by 'msvcr*.def.in'. 3. 'lib32/usbd.def' was regenerated from USBD.SYS from Windows XP 32-bit. -- Best regards, LIU Hao From 357c980c8a7b472a8e115b7af942531be915242b Mon Sep 17 00:00:00 2001 From: LIU Hao

[Mingw-w64-public] [PATCH 1/2] crt/xaudio2_9: Fix export names of `X3DAudioCalculate` and `X3DAudioInitialize`

-- Best regards, LIU Hao From b8b2b024cde9fd66b2280cba7ed995771882b366 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Mon, 15 Apr 2024 23:30:50 +0800 Subject: [PATCH 1/2] crt/xaudio2_9: Fix export names of `X3DAudioCalculate` and `X3DAudioInitialize` These are not `__stdcall` functions

Re: [Mingw-w64-public] [PATCH] crt: msvcr70.def.in: Add missing @SIZE suffixes and __CxxCallUnwindVecDtor

are deduced by gendef from machine code, and are not part of the actual export name. These functions do not return and might have no meaningful RET instructions. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: msvcrt.def.in: Fix _swprintf/_vswprintf symbol aliases

to add `swprintf` as an alias to the C99 one..? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo

Re: [Mingw-w64-public] [PATCH] add PATHCCH_ENSURE_IS_EXTENDED_LENGTH_PATH to pathcch.h

在 2024-04-09 02:04, Oleg Tolmatcev 写道: Would the attached patch look good to you? Yes it looks good. Thank you. Thanks for the feedback. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw

Re: [Mingw-w64-public] [PATCH] add PATHCCH_ENSURE_IS_EXTENDED_LENGTH_PATH to pathcch.h

在 2024-04-06 18:48, Oleg Tolmatcev 写道: Hello, this is needed by PCSX2. Would the attached patch look good to you? -- Best regards, LIU Hao From 52d6399f66c73a779f9b59391db3d59d98864e36 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Mon, 8 Apr 2024 22:22:39 +0800 Subject: [PATCH] headers

Re: [Mingw-w64-public] [PATCH] crt: Do not depend on _strtoi64/_strtoui64 symbols for I386 msvcrt.dll

-w64-crt/Makefile.am | 2 ++ mingw-w64-crt/lib-common/msvcrt.def.in | 12 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) Thanks for the patch. looks good to me, too. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] crt: Cleanup _scprintf/_vscprintf for non-msvcrtos builds

--- 2 files changed, 6 insertions(+), 14 deletions(-) These three patches about _scprintf look good to me. Pushed to master now. Thanks. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] add PATHCCH_ENSURE_IS_EXTENDED_LENGTH_PATH to pathcch.h

在 2024-04-06 18:48, Oleg Tolmatcev 写道: Hello, this is needed by PCSX2. Thanks for the patch. For this change, I suggest we add all `PATHCCH_*` constants, and change them to enumerators as in Windows 10 SDK. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

version completely. Please propose an updated patch for that. In 'ucrt__snwprintf.c' there are some hacks around it. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64

Re: [Mingw-w64-public] [PATCH] Fix UB in mkstemp retry loop

在 2024-03-23 06:36, Mateusz Mikuła 写道: Signed-off-by: Mateusz Mikuła --- mingw-w64-crt/misc/mkstemp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

在 2024-03-23 18:43, Pali Rohár 写道: On Monday 11 March 2024 19:02:09 LIU Hao wrote: 在 2024-03-11 15:52, Pali Rohár 写道: I know, but I'm trying to achieve it by small steps. For _scprintf it should fix this issue as mingw library starts providing required symbol for linking object files. Or do

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

' for example. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

not solve the incompatibility. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH v2] crt: Use rand_s in the mkstemp function

/mkstemp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) This patch looks good itself. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Provide fcloseall as alias to _fcloseall

-l1-1-0.def | 1 + 2 files changed, 2 insertions(+) This patch looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] Use rand_s in mkstemp function

of `rand_s()` in 'secapi/rand_s.c' which may return `EINVAL` on Windows 2000. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

在 2024-03-03 04:55, Martin Storsjö 写道: LGTM, thanks! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

. Kind of. Prior to this patch, including 'strsafe.h' then 'windows.h' will result in errors, even those functions aren't used in any way. So I suspect such code doesn't exist. Attached is an updated patch, with the last two paragraphs rephrased. -- Best regards, LIU Hao From

Re: [Mingw-w64-public] [PATCH 1/3] crt: Add non-inline variant of UCRT _scprintf, _snprintf and _snscanf functions

在 2024-02-29 04:25, Pali Rohár 写道: On Tuesday 09 May 2023 22:29:31 LIU Hao wrote: Our conclusion is that, in order to reduce possible UCRT dependency, moving inline definitions out of headers makes sense; but the other part, such as duplication of functions, will not be accepted. Ok, so does

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

g 'strsafe.h' and getting accidental hard errors is probably unwanted. However that's already how Microsoft headers behave. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mai

Re: [Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

ringCchCopyA_or_StringCchCopyExA' collect2.exe: error: ld returned 1 exit status We may provide a local copy of the deprecated attribute in 'strsafe.h', but it would require another patch. -- Best regards, LIU Hao From 0c578c39c17b94af80dcc91b7ae16c46cda6fd37 Mon Sep 17 00:00:00 2001 From:

Re: [Mingw-w64-public] [PATCH] include/tchar: Add more macros

在 2024-02-28 06:04, Martin Storsjö 写道: On Mon, 26 Feb 2024, LIU Hao wrote: This should match latest Windows SDK except for `strtold_l()` and `wcstold_l()`. The Microsoft implementations produce 64-bit numbers that do not match the GNU ABI, and we at the moment do not have locale-aware

[Mingw-w64-public] [PATCH] include/tchar: Add more macros

-- Best regards, LIU Hao From 0b2dba1baf8698bdcdde615a8a7cdb9d567fe754 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Mon, 26 Feb 2024 23:00:13 +0800 Subject: [PATCH] include/tchar: Add more macros This should match latest Windows SDK except for `strtold_l()` and `wcstold_l()`. The Microsoft

[Mingw-w64-public] [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h'

-- Best regards, LIU Hao From f6bbea6b0530ff47da5c1abefef3182933fd8641 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Wed, 21 Feb 2024 22:51:59 +0800 Subject: [PATCH] headers: Move some macros about deprecated functions from 'strsafe.h' into 'dontuse.h' Since Windows SDK 8.0

Re: [Mingw-w64-public] [PATCH] Ignore _FORTIFY_SOURCE if __MINGW32__ is not defined

regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Ignore _FORTIFY_SOURCE if __MINGW32__ is not defined

; in the case of Cygwin, mingw-w64 headers are included but the CRT is the Cygwin CRT, so it shouldn't be defined; is that right? The patch should be sensible. Let me have a look later. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Ignore _FORTIFY_SOURCE if __MINGW32__ is not defined

this. Well, how about removing that warning, so `_FORTIFY_SOURCE=3` should be equivalent to `2` instead of `0`? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] strsafe.h cannot be included before windows.h

lpString2); which is due to this macro in : #define lstrcpyA lstrcpyA_instead_use_StringCbCopyA_or_StringCchCopyA; These macros have been moved from to since Windows SDK 8.0. Maybe we should do the same. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] gendef: Remove printing __DATE__, to improve build reproducibility

be removed for simplicity. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] __pformat_fpreg_bits: change to match __gdtoa prototype

. The v2 patch looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] __pformat_fpreg_bits: change to match __gdtoa prototype

was C++, it would have caused errors long ago. The patch looks good to me, too. Please go ahead and apply. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] [PATCH v2 8/8] winpthreads: Use GetModuleHandleA to prevent Unicode errors

+- mingw-w64-libraries/winpthreads/src/thread.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) In my opinion the W variants should be preferred. Most A functions convert their arguments to wide strings then call their W variants anyway. -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] headers: rename SymRegisterCallback64W to SymRegisterCallbackW64

/_dbg_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the fix. The patch looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Remove section attributes from declarations

在 2024/1/11 20:28, Martin Storsjö 写道: LGTM, thanks! (I didn't test it, but these attributes shouldn't indeed have any effect on a declaration.) Thanks, pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] Consider regenerating autoconf scripts with autoconf 2.72

the top directory with WANT_AUTOMAKE=1.16 WANT_AUTOCONF=2.72 autoreconf -fiv (the patch is too long to be sent over email). Done now. Committed as b4515a6935a3ab49f11c68eaefb95b2bba8c2d20. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

[Mingw-w64-public] [PATCH] crt: Remove section attributes from declarations

-- Best regards, LIU Hao From cd3802aae66bc7c8caaa2cd44473a9e9455ab136 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Mon, 8 Jan 2024 21:58:04 +0800 Subject: [PATCH] crt: Remove section attributes from declarations This patch is generated by sed -Ei '/\/s/\<_CRTALLOC\([^)]+\) +//' $(git g

Re: [Mingw-w64-public] [PATCH] headers: Add processsnapshot.h

, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: Add a noreturn attribute on RtlRestoreContext

-w64-headers/include/winnt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Looks good to me, too. I actually had a look at Wine's implementation. This function calls `NtContinue()` which is a request to replace the execution context, so it's likely not to return. -- Best regards, LIU

Re: [Mingw-w64-public] [PATCH] headers: Add the returns_twice attribute on the RtlCaptureContext function

to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: move PPROC_THREAD_ATTRIBUTE_LIST in PARTITION_APP

, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/2] crt: Replace some IDs with header files in strmiids library

在 2023/12/16 22:33, LIU Hao 写道: 在 2023/12/16 22:03, Biswapriyo Nath 写道: I shall include the uuids.h and remove the duplicates in strmiids.h. That would be similar as wine/libs/strmiids/strmiids.c. Latest patch file is attached. Thanks for the update. Pushed now. BTW, I have noticed

Re: [Mingw-w64-public] [PATCH 2/2] crt: Replace some IDs with header files in strmiids library

在 2023/12/16 22:03, Biswapriyo Nath 写道: I shall include the uuids.h and remove the duplicates in strmiids.h. That would be similar as wine/libs/strmiids/strmiids.c. Latest patch file is attached. Thanks for the update. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc

Re: [Mingw-w64-public] [PATCH 2/2] crt: Replace some IDs with header files in strmiids library

regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Fix Makefile.am error introduced in efb61884c4

在 2023/12/12 9:30, Mark Harmstone 写道: Signed-off-by: Mark Harmstone --- mingw-w64-crt/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Many thanks for these patches. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] crt: Provide dhcpcsvc6 for arm64 too

29 deletions(-) rename mingw-w64-crt/{lib64 => lib-common}/dhcpcsvc6.def (100%) delete mode 100644 mingw-w64-crt/libarm32/dhcpcsvc6.def This patch looks good to me. Send again as I just noticed I had used another account. -- Best regards, LIU Hao OpenPGP_signature.asc Description: O

Re: [Mingw-w64-public] [PATCH] crt: Provide dhcpcsvc6 for arm64 too

29 deletions(-) rename mingw-w64-crt/{lib64 => lib-common}/dhcpcsvc6.def (100%) delete mode 100644 mingw-w64-crt/libarm32/dhcpcsvc6.def This patch looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital sig

Re: [Mingw-w64-public] [PATCH] headers/ksmedia: Tiny fixes to match Windows SDK

在 2023/12/3 18:43, Martin Storsjö 写道: LGTM Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

[Mingw-w64-public] [PATCH] headers/ksmedia: Tiny fixes to match Windows SDK

MMREG`, from `STATIC_KSDATAFORMAT_SUBTYPE_IEEE_FLOAT` to `STATIC_KSDATAFORMAT_SUBTYPE_MPEG`. So probably those new GUIDs should have been defined outside that block. -- Best regards, LIU Hao From 7f54c78e35c2056a6d972261d70e8ba8fbf1191a Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Sat, 2 Dec 2

Re: [Mingw-w64-public] [PATCH 14/18] winpthreads: AC_PROG_RANLIB is obsoleted by LT_INIT

to generated files can't be reviewed or cherry-picked; and they may be overwritten anyway. So there is no necessity to include them. They will be committed separately. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH 04/18] winpthreads: Format error string with snprintf

regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: include some IEC61937 GUID

n apparent oversight; it should be `WAVE_FORMAT_DTS`. Thanks for the patches. Amended and pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-

Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub

believed those should be safe. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: cast fd to SOCKET in macros

在 2023/11/25 15:59, LIU Hao 写道: I don't think the patch is necessary. Windows socket handles are represented as `UINT_PTR` instead of plain `int`. On 64-bit Windows, storing a socket handle into `int` might cause truncation and is not safe. Also, please read this reply: https://github.com

Re: [Mingw-w64-public] [PATCH] headers: cast fd to SOCKET in macros

ned and this is cross platform code. I don't think the patch is necessary. Windows socket handles are represented as `UINT_PTR` instead of plain `int`. On 64-bit Windows, storing a socket handle into `int` might cause truncation and is not safe. -- Best regards, LIU Hao OpenPGP_signature.asc Descript

Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub

than 1.16.5 to regenerate configure? Granted, I've looked at the diff, and it does seem minor. I don't know; that was just `autoreconf` selected. I will take a look later today. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub

generated files. Usually not all files get updated, however they can be forced regenerated with `autoreconf -f`. Updated now [1]. [1] https://sourceforge.net/p/mingw-w64/mingw-w64/ci/b6de4ef -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub

the versions you've proposed. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/2] Update to latest config.guess and config.sub

| 236 +- Those files are generated by autotools automatically. Are there any reasons why we should update them by hand? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64

Re: [Mingw-w64-public] Determine whether a mingw-w64 port of gcc is UCRT or MSVCRT

ve been configured to use UCRT by default. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] winpthreads: Check GetModuleHandle return value before calling GetProcAddress

/winpthreads/src/clock.c  | 8 +--- mingw-w64-libraries/winpthreads/src/misc.c   | 4 +++- mingw-w64-libraries/winpthreads/src/thread.c | 6 -- 3 files changed, 12 insertions(+), 6 deletions(-) Ping This patch looks good to me. Sorry for overlooking. -- Best regards, LIU Hao OpenPGP_signature

Re: [Mingw-w64-public] Define __STDC_NO_THREADS__ if C11/C17 is not provided

existence of the header [2]. [1] https://gcc.godbolt.org/z/dxoTj3Eqr [2] https://gcc.gnu.org/onlinedocs/gcc-9.5.0/cpp/_005f_005fhas_005finclude.html -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64

Re: [Mingw-w64-public] Define __STDC_NO_THREADS__ if C11/C17 is not provided

ISO C seems to require it to be a predefined macro without inclusion of any headers (6.10.8 1 Predefined macro names, N1570, ISO/IEC 9899:201x), but that will have to be done in the compiler and I don't think it has something to do with the compiler. -- Best regards, LIU Hao OpenPGP_signature

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in processthreadsapi.h

--- mingw-w64-headers/include/processthreadsapi.h | 56 +-- 1 file changed, 52 insertions(+), 4 deletions(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Mark _tls_used as used for LTO

apply the attribute directly. Signed-off-by: Martin Storsjö --- mingw-w64-crt/crt/tlssup.c | 1 + 1 file changed, 1 insertion(+) This patch looks good to me, too. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Revert to our implementation of scalbn/scalbnf and ldexp on UCRT

deletions(-) This patch looks good to me. Thanks. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

unconditionally. We also notice that `QueryPerformanceCounter()` is quite fast on modern Windows; the frequency is probably not but that variable isn't gonna change hence can be static anyway. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

/onlinepubs/9699919799/functions/pthread_mutex_timedlock.html -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

()` itself. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

that clock.c also has a GetModuleHandle use which is not mine..) I'd rather check `_WIN32_WINNT` instead. Windows store apps require Windows 8 (10?) anyway and I hope we can get rid of these initialization-on-demand hacks there. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP

Re: [Mingw-w64-public] [PATCH 6/8] crt: Move fabsf and nexttowardf to libmsvcr*.a for all archs, and to libucrt*.a for x86

that this series of patches look good to me. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

在 2023-10-24 22:20, Ozkan Sezer 写道: LoadLibrary needs cleaning after, and we do link to kernel32.dll anyway. This patch looks good to me. Please go ahead and apply. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Make winpthreads work on Win98

dling uses this winpthreads module. Thanks for your opinions. I have pushed this patch to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge

Re: [Mingw-w64-public] [PATCH] Make winpthreads work on Win98

claim to support. Anyway I am not too against this patch if others agree. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] Make winpthreads work on Win98

ted otherwise. BTW I am also curious: does the CRT work well for you? I thought the Windows 98 MSVCRT.DLL (?) would have lacked some symbols. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mail

Re: [Mingw-w64-public] [PATCH] headers: Add missing symbols in ntsecapi.h

/ntsecapi.h | 131 ++- 1 file changed, 126 insertions(+), 5 deletions(-) Thanks. This patch looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw

  1   2   3   4   5   6   7   8   9   10   >