Re: [Mingw-w64-public] [PATCH] crt: Add missing __cdecl signature to ucrt functions

2022-02-20 Thread Martin Storsjö
On Sun, 20 Feb 2022, LIU Hao wrote: 在 2022-02-20 04:20, Martin Storsjö 写道: On Sat, 19 Feb 2022, Pali Rohár wrote: When assigning function pointer to variable, both function and variable should have same signature. Fix it. --- The patch looks ok to me, but I presume this is only a pedantic

Re: [Mingw-w64-public] [PATCH] crt: Add missing __cdecl signature to ucrt functions

2022-02-20 Thread LIU Hao
在 2022-02-20 04:20, Martin Storsjö 写道: On Sat, 19 Feb 2022, Pali Rohár wrote: When assigning function pointer to variable, both function and variable should have same signature. Fix it. --- The patch looks ok to me, but I presume this is only a pedantic fix with no noticeable effect other

Re: [Mingw-w64-public] [PATCH] crt: Add missing __cdecl signature to ucrt functions

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Pali Rohár wrote: When assigning function pointer to variable, both function and variable should have same signature. Fix it. --- The patch looks ok to me, but I presume this is only a pedantic fix with no noticeable effect other than that - because if no calling

[Mingw-w64-public] [PATCH] crt: Add missing __cdecl signature to ucrt functions

2022-02-18 Thread Pali Rohár
When assigning function pointer to variable, both function and variable should have same signature. Fix it. --- mingw-w64-crt/stdio/ucrt__vscprintf.c | 2 +- mingw-w64-crt/stdio/ucrt_snprintf.c | 2 +- mingw-w64-crt/stdio/ucrt_vsnprintf.c | 2 +- 3 files changed, 3 insertions(+), 3