Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2022-01-17 Thread LIU Hao
在 1/18/22 12:11 AM, Jacek Caban 写道: Not really, the file is generated from wtypes.idl, which is not shared with Wine. It, however, requires widl change, and widl is shared with Wine. Ah thanks for pointing this out. I only had a look at the commit history of 'wtypes.h' without looking at

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2022-01-17 Thread Jacek Caban
On 1/14/22 02:29, LIU Hao wrote: 在 1/13/22 10:07 PM, Jonathan Marler 写道: Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: Jacek were you able to forward this discussion to Wine?  If so do you have a link to that

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2022-01-13 Thread LIU Hao
在 1/13/22 10:07 PM, Jonathan Marler 写道: Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: Jacek were you able to forward this discussion to Wine? If so do you have a link to that discussion? Thanks. This patch applies

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2022-01-13 Thread Jonathan Marler
Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: > Jacek were you able to forward this discussion to Wine? If so do you have > a link to that discussion? Thanks. > > On Sun, Sep 5, 2021 at 9:27 AM LIU Hao wrote: > >> 在

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-10-19 Thread Jonathan Marler
Jacek were you able to forward this discussion to Wine? If so do you have a link to that discussion? Thanks. On Sun, Sep 5, 2021 at 9:27 AM LIU Hao wrote: > 在 2021-09-05 23:00, Jacek Caban 写道: > > > > They come from widl, so if we want this change, then widl needs to be > changed instead. It

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-05 Thread LIU Hao
在 2021-09-05 23:00, Jacek Caban 写道: They come from widl, so if we want this change, then widl needs to be changed instead. It looks like the reverse was done in the past: https://source.winehq.org/git/wine.git/commitdiff/0bde2bbe010c68a54f8928469e89637a2322ae44 I don't know what was the

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-05 Thread Jacek Caban
On 9/5/21 4:54 PM, LIU Hao wrote: 在 2021-09-04 23:53, JonY via Mingw-w64-public 写道: I am OK with updating them to use double quotes but have no strong preference anyway since it has been using angular brackets for a long time. So this change is okay, but... I have noticed that wtypes.h

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-05 Thread LIU Hao
在 2021-09-04 23:53, JonY via Mingw-w64-public 写道: I am OK with updating them to use double quotes but have no strong preference anyway since it has been using angular brackets for a long time. So this change is okay, but... I have noticed that wtypes.h is generated from wtypes.idl, which

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-04 Thread JonY via Mingw-w64-public
On 9/4/21 5:50 AM, LIU Hao wrote: 在 9/4/21 1:18 PM, Jonathan Marler 写道: I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this.  What reason is there

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread LIU Hao
在 9/4/21 1:18 PM, Jonathan Marler 写道: I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this. What reason is there not to change these 2 lines to fix

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread Jonathan Marler
I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this. What reason is there not to change these 2 lines to fix this issue? If you google it there

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread Biswapriyo Nath
I disagree with this change. Your project contains files with similar name in mingw-w64. You should change your project file instead of the opposite. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread Jacek Caban
Hi Jonathan, On 9/3/21 11:48 PM, Jonathan Marler wrote: Been another 4 days, anyone able to bring this patch in or review? Your patch never arrived to the mailing list, it looks like the attachment is missing. Jacek ___ Mingw-w64-public

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread Jonathan Marler
That's odd, I attached it in the first email sent Aug 25. Here's the patch inline with my email and attached again >From 2ba8f0e43213f09f85cf653a8f0a726d9873399d Mon Sep 17 00:00:00 2001 From: Jonathan Marler Date: Wed, 25 Aug 2021 10:35:19 -0600 Subject: [PATCH] wtypes.h: replace #include

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-09-03 Thread Jonathan Marler
Been another 4 days, anyone able to bring this patch in or review? On Mon, Aug 30, 2021 at 3:36 PM Jonathan Marler wrote: > Ping. The issue that this fixes is easy to reproduce. Just try to > compile any project with the mingw headers and add a file named "rpc.h" to > one of your local

Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-08-30 Thread Jonathan Marler
Ping. The issue that this fixes is easy to reproduce. Just try to compile any project with the mingw headers and add a file named "rpc.h" to one of your local include directories and you'll get a bunch of errors related to missing definitions. The 2-line patch attached to my previous message

[Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-08-25 Thread Jonathan Marler
This replaces the include style for rpc.h and rpcndr.h inside the wtypes.h header. I found this issue when trying to compile my WindowsNfs project found here: https://github.com/marler8997/WindowsNfs. This project contains a file named "Rpc.h". This broke the mingw header files because wtypes.h