Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
Hi, On Fri, 9 Jun 2023, Jameson Nash wrote: I realize I wasn't exactly clear, but upstream did make a new tarball with this fix. David has been unable to upload it yet to the main website mirror however and only has it on his site. He emailed me this: I'll try to adjust https://netlib.org/fp/gdtoa.tgz but the only file I can immediately update is https://www.ampl.com/netlib/fp/gdtoa.tgz. It's supposed to be mirrored to https://netlib.org, but the mirroring seems to have broken a few days ago. Ah, I see, thanks for the clarification! In that case, I pushed your earlier patch with the fix squashed into it. I left out the tarball from your patch though as I felt that it was out of place here, even if it's useful for tracking differences when syncing with upstream. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
I realize I wasn't exactly clear, but upstream did make a new tarball with this fix. David has been unable to upload it yet to the main website mirror however and only has it on his site. He emailed me this: > I'll try to adjust https://netlib.org/fp/gdtoa.tgz but the only file I can immediately update is https://www.ampl.com/netlib/fp/gdtoa.tgz. It's supposed to be mirrored to https://netlib.org, but the mirroring seems to have broken a few days ago. Thanks Martin! On Mon, 15 May 2023, Jameson Nash wrote: > David (the gdtoa author) got back to me and confirmed this is an upstream > bug, and that my fix attached previously was the right one. He is trying to > get that fix uploaded to the right ftp server soon. For future mingw-w64 > reference, my change-controlled copy of his current tarball is updated here > for future reference: > https://github.com/vtjnash/gdtoa/tree/91156f01f80649aa5657b55bddffc8f0ad447814 Thanks! I took your fix from https://github.com/vtjnash/mingw-w64/commit/561c763593981f7516ab57b0cae974ebdcef4de3#commitcomment-112904299 for a spin through my tests, and they now do run successfully. If there's a chance of the upstream releasing a new tarball with this fix included soon, I guess it'd be nicer to wait for that (instead of introducing more minimal desync here). If that doesn't materialize within a few weeks, I'd be fine with pushing it with your version of the fix. // Martin > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
On Mon, 15 May 2023, Jameson Nash wrote: David (the gdtoa author) got back to me and confirmed this is an upstream bug, and that my fix attached previously was the right one. He is trying to get that fix uploaded to the right ftp server soon. For future mingw-w64 reference, my change-controlled copy of his current tarball is updated here for future reference: https://github.com/vtjnash/gdtoa/tree/91156f01f80649aa5657b55bddffc8f0ad447814 Thanks! I took your fix from https://github.com/vtjnash/mingw-w64/commit/561c763593981f7516ab57b0cae974ebdcef4de3#commitcomment-112904299 for a spin through my tests, and they now do run successfully. If there's a chance of the upstream releasing a new tarball with this fix included soon, I guess it'd be nicer to wait for that (instead of introducing more minimal desync here). If that doesn't materialize within a few weeks, I'd be fine with pushing it with your version of the fix. // Martin On Thu, May 11, 2023 at 11:34 AM Jameson Nash wrote: No, I missed your message since I am not on the mailing list itself. Thanks! Whelp, you apparently found a bug introduced into gdtoa itself, since the same test program run on linux against their current code also fails with the same incorrect byte ordering of the output: gdtoa$ ./a.out got: 1.06074e-314 bits: 7ff8 I am not exactly sure of the intent here (since gdtoa doesn't use any sort of version control), so I have mostly just removed that line of the change. I will send a message to the gdoa developer also, informing him of your finding My test code is attached as a github comment on the same commit attached as a patch here. https://github.com/vtjnash/mingw-w64/commit/561c763593981f7516ab57b0cae974ebdcef4de3#commitcomment-112904299 ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
David (the gdtoa author) got back to me and confirmed this is an upstream bug, and that my fix attached previously was the right one. He is trying to get that fix uploaded to the right ftp server soon. For future mingw-w64 reference, my change-controlled copy of his current tarball is updated here for future reference: https://github.com/vtjnash/gdtoa/tree/91156f01f80649aa5657b55bddffc8f0ad447814 On Thu, May 11, 2023 at 11:34 AM Jameson Nash wrote: > No, I missed your message since I am not on the mailing list itself. > Thanks! > > Whelp, you apparently found a bug introduced into gdtoa itself, since the > same test program run on linux against their current code also fails with > the same incorrect byte ordering of the output: > > gdtoa$ ./a.out > > got: 1.06074e-314 > > bits: 7ff8 > > I am not exactly sure of the intent here (since gdtoa doesn't use any sort > of version control), so I have mostly just removed that line of the change. > I will send a message to the gdoa developer also, informing him of your > finding > > My test code is attached as a github comment on the same commit attached > as a patch here. > > https://github.com/vtjnash/mingw-w64/commit/561c763593981f7516ab57b0cae974ebdcef4de3#commitcomment-112904299 > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
No, I missed your message since I am not on the mailing list itself. Thanks! Whelp, you apparently found a bug introduced into gdtoa itself, since the same test program run on linux against their current code also fails with the same incorrect byte ordering of the output: gdtoa$ ./a.out got: 1.06074e-314 bits: 7ff8 I am not exactly sure of the intent here (since gdtoa doesn't use any sort of version control), so I have mostly just removed that line of the change. I will send a message to the gdoa developer also, informing him of your finding My test code is attached as a github comment on the same commit attached as a patch here. https://github.com/vtjnash/mingw-w64/commit/561c763593981f7516ab57b0cae974ebdcef4de3#commitcomment-112904299 On Tue, May 9, 2023 at 8:55 AM Jameson Nash wrote: > Is it okay to bump this again? > > On Wed, Mar 8, 2023 at 11:57 AM Jameson Nash wrote: > >> Alright, let's try that again! >> >> On Wed, Mar 8, 2023 at 11:54 AM Alvin Wong wrote: >> >>> Hi, it seems the mailing list software stripped your attached patch. >>> Please try resending it with a .txt file extension. (I suspect that >>> Gmail doesn't send the .patch files with the MIME type `text/plain`.) >>> >>> On 7/1/2023 11:10, Jameson Nash wrote: >>> > I noticed that gdtoa upstream appeared to have some changes that were >>> not >>> > reflected here, so I tried to copy them into mingw-w64 here. I had to >>> > partly guess at what the diff was between the old and current versions >>> > because upstream does not seem to provide version control, so this is >>> a bit >>> > hard to illustrate. For future reference, this is the content from >>> today: >>> > >>> https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5 >>> , >>> > which is also included as a tgz in the commit here for future >>> reference. I >>> > did not import any of the new features (new files) since those are not >>> > specified as part of C9x or POSIX, so they did not seem necessary. >>> > >>> > ___ >>> > Mingw-w64-public mailing list >>> > Mingw-w64-public@lists.sourceforge.net >>> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >>> >> ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
Hi Jameson, Did you see my reply on this from March 9th? See https://sourceforge.net/p/mingw-w64/mailman/message/37788047/ // Martin On Tue, 9 May 2023, Jameson Nash wrote: Is it okay to bump this again? On Wed, Mar 8, 2023 at 11:57 AM Jameson Nash wrote: Alright, let's try that again! On Wed, Mar 8, 2023 at 11:54 AM Alvin Wong wrote: Hi, it seems the mailing list software stripped your attached patch. Please try resending it with a .txt file extension. (I suspect that Gmail doesn't send the .patch files with the MIME type `text/plain`.) On 7/1/2023 11:10, Jameson Nash wrote: > I noticed that gdtoa upstream appeared to have some changes that were not > reflected here, so I tried to copy them into mingw-w64 here. I had to > partly guess at what the diff was between the old and current versions > because upstream does not seem to provide version control, so this is a bit > hard to illustrate. For future reference, this is the content from today: > https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5 , > which is also included as a tgz in the commit here for future reference. I > did not import any of the new features (new files) since those are not > specified as part of C9x or POSIX, so they did not seem necessary. > > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
Is it okay to bump this again? On Wed, Mar 8, 2023 at 11:57 AM Jameson Nash wrote: > Alright, let's try that again! > > On Wed, Mar 8, 2023 at 11:54 AM Alvin Wong wrote: > >> Hi, it seems the mailing list software stripped your attached patch. >> Please try resending it with a .txt file extension. (I suspect that >> Gmail doesn't send the .patch files with the MIME type `text/plain`.) >> >> On 7/1/2023 11:10, Jameson Nash wrote: >> > I noticed that gdtoa upstream appeared to have some changes that were >> not >> > reflected here, so I tried to copy them into mingw-w64 here. I had to >> > partly guess at what the diff was between the old and current versions >> > because upstream does not seem to provide version control, so this is a >> bit >> > hard to illustrate. For future reference, this is the content from >> today: >> > >> https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5 >> , >> > which is also included as a tgz in the commit here for future >> reference. I >> > did not import any of the new features (new files) since those are not >> > specified as part of C9x or POSIX, so they did not seem necessary. >> > >> > ___ >> > Mingw-w64-public mailing list >> > Mingw-w64-public@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
On Wed, 8 Mar 2023, Jameson Nash wrote:
Alright, let's try that again!
On Wed, Mar 8, 2023 at 11:54 AM Alvin Wong wrote:
Hi, it seems the mailing list software stripped your attached patch.
Please try resending it with a .txt file extension. (I suspect that
Gmail doesn't send the .patch files with the MIME type `text/plain`.)
On 7/1/2023 11:10, Jameson Nash wrote:
I noticed that gdtoa upstream appeared to have some changes that were not
reflected here, so I tried to copy them into mingw-w64 here. I had to
partly guess at what the diff was between the old and current versions
because upstream does not seem to provide version control, so this is a
bit
hard to illustrate. For future reference, this is the content from today:
https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5
,
which is also included as a tgz in the commit here for future reference.
I
did not import any of the new features (new files) since those are not
specified as part of C9x or POSIX, so they did not seem necessary.
Thanks for the patch.
We probably don't want to commit the tgz with the unaltered sources to our
git though - but for sorting out future incremental changes on top,
having the commit reference (as you mentioned in the cover letter) is
great - I think it'd be good to include that in the commit message
too.
Other than that, the patch looked good to me, so I gave it a spin in a
couple of testsuites.
Unfortunately, the libcxx testsuite found one failing test caused by this
patch. The root cause seems to be that strtod("nan", NULL) returns zero
instead of a valid NAN. Can you look into why that is?
// Martin
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
Hi, it seems the mailing list software stripped your attached patch. Please try resending it with a .txt file extension. (I suspect that Gmail doesn't send the .patch files with the MIME type `text/plain`.) On 7/1/2023 11:10, Jameson Nash wrote: I noticed that gdtoa upstream appeared to have some changes that were not reflected here, so I tried to copy them into mingw-w64 here. I had to partly guess at what the diff was between the old and current versions because upstream does not seem to provide version control, so this is a bit hard to illustrate. For future reference, this is the content from today: https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5, which is also included as a tgz in the commit here for future reference. I did not import any of the new features (new files) since those are not specified as part of C9x or POSIX, so they did not seem necessary. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
Bump? On Fri, Jan 6, 2023 at 10:10 PM Jameson Nash wrote: > I noticed that gdtoa upstream appeared to have some changes that were not > reflected here, so I tried to copy them into mingw-w64 here. I had to > partly guess at what the diff was between the old and current versions > because upstream does not seem to provide version control, so this is a bit > hard to illustrate. For future reference, this is the content from today: > https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5, > which is also included as a tgz in the commit here for future reference. I > did not import any of the new features (new files) since those are not > specified as part of C9x or POSIX, so they did not seem necessary. > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] [PATCH] gdtoa: Sync to match the latest version at netlib.org
I noticed that gdtoa upstream appeared to have some changes that were not reflected here, so I tried to copy them into mingw-w64 here. I had to partly guess at what the diff was between the old and current versions because upstream does not seem to provide version control, so this is a bit hard to illustrate. For future reference, this is the content from today: https://github.com/vtjnash/gdtoa/commit/a37a5e1354210f135003cc734cb097eee48e58b5, which is also included as a tgz in the commit here for future reference. I did not import any of the new features (new files) since those are not specified as part of C9x or POSIX, so they did not seem necessary. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
