Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
在 1/18/22 12:11 AM, Jacek Caban 写道: Not really, the file is generated from wtypes.idl, which is not shared with Wine. It, however, requires widl change, and widl is shared with Wine. Ah thanks for pointing this out. I only had a look at the commit history of 'wtypes.h' without looking at the IDL file. It looks like the WIDL version info got committed in a2eb3ea3aaa7c780c4b4ab30d71169f442788864. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
On 1/14/22 02:29, LIU Hao wrote: 在 1/13/22 10:07 PM, Jonathan Marler 写道: Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: Jacek were you able to forward this discussion to Wine? If so do you have a link to that discussion? Thanks. This patch applies to a file that is directly copied from wine; any changes will be overwritten. Thus it will not be accepted. I'm adding wine as CC now. The original thread is located at https://sourceforge.net/p/mingw-w64/mailman/message/37341200/. Not really, the file is generated from wtypes.idl, which is not shared with Wine. It, however, requires widl change, and widl is shared with Wine. Jonathan, see bugs.winehq.org for Wine bug reports. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
在 1/13/22 10:07 PM, Jonathan Marler 写道: Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: Jacek were you able to forward this discussion to Wine? If so do you have a link to that discussion? Thanks. This patch applies to a file that is directly copied from wine; any changes will be overwritten. Thus it will not be accepted. I'm adding wine as CC now. The original thread is located at https://sourceforge.net/p/mingw-w64/mailman/message/37341200/. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
Been 3 months since my last email, what's going on with this? On Tue, Oct 19, 2021 at 11:03 PM Jonathan Marler wrote: > Jacek were you able to forward this discussion to Wine? If so do you have > a link to that discussion? Thanks. > > On Sun, Sep 5, 2021 at 9:27 AM LIU Hao wrote: > >> 在 2021-09-05 23:00, Jacek Caban 写道: >> > >> > They come from widl, so if we want this change, then widl needs to be >> changed instead. It looks like >> > the reverse was done in the past: >> > >> > >> https://source.winehq.org/git/wine.git/commitdiff/0bde2bbe010c68a54f8928469e89637a2322ae44 >> > >> > I don't know what was the reasoning there, it seems fine to change it >> back. >> > >> > >> >> Thanks for the information. It seems that, in Windows SDK 10.0.22000.0 >> the only non-WinRT header >> that is generated from an IDL and contains `#include ` is >> 'microsoft.diagnostics.appanalysis.h'. All other non-WinRT headers use "" >> instead of <>. Please >> forward this discussion to Wine; in case of any upstream changes, we can >> backport them to mingw-w64. >> >> >> -- >> Best regards, >> LIU Hao >> >> ___ >> Mingw-w64-public mailing list >> Mingw-w64-public@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
Jacek were you able to forward this discussion to Wine? If so do you have a link to that discussion? Thanks. On Sun, Sep 5, 2021 at 9:27 AM LIU Hao wrote: > 在 2021-09-05 23:00, Jacek Caban 写道: > > > > They come from widl, so if we want this change, then widl needs to be > changed instead. It looks like > > the reverse was done in the past: > > > > > https://source.winehq.org/git/wine.git/commitdiff/0bde2bbe010c68a54f8928469e89637a2322ae44 > > > > I don't know what was the reasoning there, it seems fine to change it > back. > > > > > > Thanks for the information. It seems that, in Windows SDK 10.0.22000.0 the > only non-WinRT header > that is generated from an IDL and contains `#include ` is > 'microsoft.diagnostics.appanalysis.h'. All other non-WinRT headers use "" > instead of <>. Please > forward this discussion to Wine; in case of any upstream changes, we can > backport them to mingw-w64. > > > -- > Best regards, > LIU Hao > > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
在 2021-09-05 23:00, Jacek Caban 写道: They come from widl, so if we want this change, then widl needs to be changed instead. It looks like the reverse was done in the past: https://source.winehq.org/git/wine.git/commitdiff/0bde2bbe010c68a54f8928469e89637a2322ae44 I don't know what was the reasoning there, it seems fine to change it back. Thanks for the information. It seems that, in Windows SDK 10.0.22000.0 the only non-WinRT header that is generated from an IDL and contains `#include ` is 'microsoft.diagnostics.appanalysis.h'. All other non-WinRT headers use "" instead of <>. Please forward this discussion to Wine; in case of any upstream changes, we can backport them to mingw-w64. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
On 9/5/21 4:54 PM, LIU Hao wrote: 在 2021-09-04 23:53, JonY via Mingw-w64-public 写道: I am OK with updating them to use double quotes but have no strong preference anyway since it has been using angular brackets for a long time. So this change is okay, but... I have noticed that wtypes.h is generated from wtypes.idl, which contains no reference to or . I don't know where those includes come from. Jacek, do you have any ideas? They come from widl, so if we want this change, then widl needs to be changed instead. It looks like the reverse was done in the past: https://source.winehq.org/git/wine.git/commitdiff/0bde2bbe010c68a54f8928469e89637a2322ae44 I don't know what was the reasoning there, it seems fine to change it back. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
在 2021-09-04 23:53, JonY via Mingw-w64-public 写道: I am OK with updating them to use double quotes but have no strong preference anyway since it has been using angular brackets for a long time. So this change is okay, but... I have noticed that wtypes.h is generated from wtypes.idl, which contains no reference to or . I don't know where those includes come from. Jacek, do you have any ideas? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
On 9/4/21 5:50 AM, LIU Hao wrote: 在 9/4/21 1:18 PM, Jonathan Marler 写道: I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this. What reason is there not to change these 2 lines to fix this issue? If you google it there appears to be many projects with a header file named "rpc.h". My personal guidance for common projects is that, if header X and header Y are maintained by the same people and their relative path does not seem to vary, then "" should be preferred to <>, so this relationship is maintained when the header directory tree is copied (recursively) elsewhere. But in mingw-w64, all headers are system headers, so probably this doesn't apply any more. I suggest that we maintain the same scheme with Windows SDK headers, which is "" here. Many headers (such as windows.h) include others with <>, so Microsoft's choice for OLE headers might imply there had been some issues with <>. Thoughts? I am OK with updating them to use double quotes but have no strong preference anyway since it has been using angular brackets for a long time. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
在 9/4/21 1:18 PM, Jonathan Marler 写道: I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this. What reason is there not to change these 2 lines to fix this issue? If you google it there appears to be many projects with a header file named "rpc.h". My personal guidance for common projects is that, if header X and header Y are maintained by the same people and their relative path does not seem to vary, then "" should be preferred to <>, so this relationship is maintained when the header directory tree is copied (recursively) elsewhere. But in mingw-w64, all headers are system headers, so probably this doesn't apply any more. I suggest that we maintain the same scheme with Windows SDK headers, which is "" here. Many headers (such as windows.h) include others with <>, so Microsoft's choice for OLE headers might imply there had been some issues with <>. Thoughts? -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
I could but this project builds with MSVC and I noticed that the MSVC headers are using the same include style for these 2 particular files. Note that we only need to change these 2 lines, to fix this. What reason is there not to change these 2 lines to fix this issue? If you google it there appears to be many projects with a header file named "rpc.h". On Fri, Sep 3, 2021 at 10:49 PM Biswapriyo Nath wrote: > I disagree with this change. Your project contains files with similar > name in mingw-w64. You should change your project file instead of the > opposite. > > > ___ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
I disagree with this change. Your project contains files with similar name in mingw-w64. You should change your project file instead of the opposite. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
Hi Jonathan, On 9/3/21 11:48 PM, Jonathan Marler wrote: Been another 4 days, anyone able to bring this patch in or review? Your patch never arrived to the mailing list, it looks like the attachment is missing. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
That's odd, I attached it in the first email sent Aug 25. Here's the patch inline with my email and attached again >From 2ba8f0e43213f09f85cf653a8f0a726d9873399d Mon Sep 17 00:00:00 2001 From: Jonathan Marler Date: Wed, 25 Aug 2021 10:35:19 -0600 Subject: [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc headers This replaces the include style for rpc.h and rpcndr.h inside the wtypes.h header. I found this issue when trying to compile my WindowsNfs project found here: https://github.com/marler8997/WindowsNfs. This project contains a file named "Rpc.h". This broke the mingw header files because wtypes.h ends up including my file instead of the one in the toolchain. I also verified that if I had a file named rpcndr.h in my project then the same issue occured. By changing these 2 lines to use #include "...", projects can have files named rpc.h and rpcndr.h and include without breaking the headers. Signed-off-by: Jonathan Marler --- mingw-w64-headers/include/wtypes.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-w64-headers/include/wtypes.h b/mingw-w64-headers/include/wtypes.h index 773716df8..fd60edb01 100644 --- a/mingw-w64-headers/include/wtypes.h +++ b/mingw-w64-headers/include/wtypes.h @@ -4,8 +4,8 @@ #ifndef __REQUIRED_RPCNDR_H_VERSION__ #define __REQUIRED_RPCNDR_H_VERSION__ 475 #endif -#include -#include +#include "rpc.h" +#include "rpcndr.h" #endif #ifndef COM_NO_WINDOWS_H -- 2.25.4 On Fri, Sep 3, 2021 at 3:54 PM Jacek Caban wrote: > Hi Jonathan, > > On 9/3/21 11:48 PM, Jonathan Marler wrote: > > Been another 4 days, anyone able to bring this patch in or review? > > > Your patch never arrived to the mailing list, it looks like the > attachment is missing. > > > Jacek > > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
Been another 4 days, anyone able to bring this patch in or review? On Mon, Aug 30, 2021 at 3:36 PM Jonathan Marler wrote: > Ping. The issue that this fixes is easy to reproduce. Just try to > compile any project with the mingw headers and add a file named "rpc.h" to > one of your local include directories and you'll get a bunch of errors > related to missing definitions. The 2-line patch attached to my previous > message should fix it. > > On Wed, Aug 25, 2021 at 10:42 AM Jonathan Marler > wrote: > >> This replaces the include style for rpc.h and rpcndr.h inside the >> wtypes.h header. I found this issue when trying to compile my WindowsNfs >> project found here: https://github.com/marler8997/WindowsNfs. This >> project contains a file named "Rpc.h". This broke the mingw header files >> because wtypes.h ends up including my file instead of the one in the >> toolchain. I also verified that if I had a file named rpcndr.h in my >> project then the same issue occurred. By changing these 2 lines to use >> #include "...", projects can have files named rpc.h and rpcndr.h and >> include without breaking the headers. >> > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
Ping. The issue that this fixes is easy to reproduce. Just try to compile any project with the mingw headers and add a file named "rpc.h" to one of your local include directories and you'll get a bunch of errors related to missing definitions. The 2-line patch attached to my previous message should fix it. On Wed, Aug 25, 2021 at 10:42 AM Jonathan Marler wrote: > This replaces the include style for rpc.h and rpcndr.h inside the wtypes.h > header. I found this issue when trying to compile my WindowsNfs project > found here: https://github.com/marler8997/WindowsNfs. This project > contains a file named "Rpc.h". This broke the mingw header files because > wtypes.h ends up including my file instead of the one in the toolchain. I > also verified that if I had a file named rpcndr.h in my project then the > same issue occurred. By changing these 2 lines to use #include "...", > projects can have files named rpc.h and rpcndr.h and include > without breaking the headers. > ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc
This replaces the include style for rpc.h and rpcndr.h inside the wtypes.h header. I found this issue when trying to compile my WindowsNfs project found here: https://github.com/marler8997/WindowsNfs. This project contains a file named "Rpc.h". This broke the mingw header files because wtypes.h ends up including my file instead of the one in the toolchain. I also verified that if I had a file named rpcndr.h in my project then the same issue occurred. By changing these 2 lines to use #include "...", projects can have files named rpc.h and rpcndr.h and include without breaking the headers. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
