Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-23 Thread Daniel Schürmann
Hi Andreas, the patch looks good and can't be the issue. What is the output of aplay -l ? You may provide the clang error messages, maybe one has an idea for a fix. Kind regards, Daniel Am 22.09.2016 um 22:14 schrieb Andreas Müller: > On Thu, Sep 22, 2016 at 10:50 AM, Andreas Müller > wrote

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-22 Thread Andreas Müller
On Thu, Sep 22, 2016 at 10:50 AM, Andreas Müller wrote: > On Thu, Sep 22, 2016 at 10:40 AM, Andreas Müller > wrote: >> On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote: >>> Hi Andreas, >>> >>> The QStringBuilder() is somehow hidden. It is only invoked by the operator >>> %. >>> In all cas

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-22 Thread Andreas Müller
On Thu, Sep 22, 2016 at 10:40 AM, Andreas Müller wrote: > On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote: >> Hi Andreas, >> >> The QStringBuilder() is somehow hidden. It is only invoked by the operator >> %. >> In all cases, where % is involved, you can simply replace >> QLatin1Literal("

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-22 Thread Andreas Müller
On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote: > Hi Andreas, > > The QStringBuilder() is somehow hidden. It is only invoked by the operator > %. > In all cases, where % is involved, you can simply replace > QLatin1Literal("string") by "string". > > There is no need for testing, other tha

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-21 Thread Daniel Schürmann
Hi Andreas, The QStringBuilder() is somehow hidden. It is only invoked by the operator %. In all cases, where % is involved, you can simply replace QLatin1Literal("string") by "string". There is no need for testing, other that it compiles on your Qt 5 environment. If you decide to do a GitHub pu

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-21 Thread Andreas Müller
On Tue, Sep 20, 2016 at 11:42 AM, Daniel Schürmann wrote: > I have just filed a QT bug > https://bugreports.qt.io/browse/QTBUG-56087 > > > > 2016-09-20 11:17 GMT+02:00 Daniel Schürmann : >> >> Hi Andreas, >> >> thank you for the patch. >> >> Looking at it, I havenoticed an Qt issue: >> >> In Qt 5,

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-20 Thread Daniel Schürmann
I have just filed a QT bug https://bugreports.qt.io/browse/QTBUG-56087 2016-09-20 11:17 GMT+02:00 Daniel Schürmann : > Hi Andreas, > > thank you for the patch. > > Looking at it, I havenoticed an Qt issue: > > In Qt 5, there is > > typedef QLatin1String QLatin1Literal; > > However, I cannot fin

Re: [Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-20 Thread Daniel Schürmann
Hi Andreas, thank you for the patch. Looking at it, I havenoticed an Qt issue: In Qt 5, there is typedef QLatin1String QLatin1Literal; However, I cannot find the original template constructor: template QLatin1Literal(const char(&str)[N]) So I am afraid this solution here requires char counti

[Mixxx-devel] [PATCH 1/1] coverart.cpp: fix build

2016-09-19 Thread Andreas Müller
fixes (with gcc-6 / Qt5.7): src/library/coverart.cpp:35:44: error: no match for 'operator%' (operand types are 'QString' and 'QLatin1Literal {aka QLatin1String}') return typeToString(infoRelative.type) % QLatin1Literal(",") % ^ s