Re: [Mixxx-devel] Deere state

2015-08-03 Thread Ferran Pujol Camins
The fx section is a skinning nightmare when the 4 fx chains have the echo at the same time and all the mic and aux inputs are assigned. There's no way to make it look good. If no one complains soon, I will just implement the solution I proposed, as a band-aid: > As we don't have a polished fx wor

Re: [Mixxx-devel] Deere state

2015-08-02 Thread Sébastien Blaisot
Hey, that's really cool ! I didn't even know this was possible with the skin engine. Thanks. sb Le 02/08/2015 22:53, S.Brandt a écrit : Once you configured mic 1-4, and aux 1-4 in the Preferences> Sound Hardware, they become available in the Mic rack, and selectable in the FX section. --

Re: [Mixxx-devel] Deere state

2015-08-02 Thread S.Brandt
Once you configured mic 1-4, and aux 1-4 in the Preferences> Sound Hardware, they become available in the Mic rack, and selectable in the FX section. S.Brandt Mixxx - Free Digital DJ Mixing Software www.mixxx.org | Get Involved

Re: [Mixxx-devel] Deere state

2015-08-02 Thread Be
I just noticed Deere is missing channel VU meters :O On 07/30/2015 10:09 AM, Owen Williams wrote: > I went ahead and merged in the deere-updates skin. I took a look at it > and it's definitely an improvement, and although it has issues I think > we can open it up to the larger developer group now

Re: [Mixxx-devel] Deere state

2015-08-01 Thread Sébastien Blaisot
What an improvement ! I find Deere far more usable now. However, it would be nice if the "mic" section could show 2 mic as well as an "aux" section to control aux passthrough. I will try to add that if I have some time after my vacations. regards, sb Le 30/07/2015 17:09, Owen Williams a écri

Re: [Mixxx-devel] Deere state

2015-08-01 Thread Be
What I'd like to see is a combination of what Deere and Shade do. By default, show 2 effects units with a single effect. Like Deere, click a button to expand and show 3 effects in a chain. There could be an option to enable 2 more effects units (this could wait for a future release because I th

Re: [Mixxx-devel] Deere state

2015-08-01 Thread Ferran Pujol Camins
I've just opened PR #666 (😈). I'll push there improvements to skins that fit what we've discussed so far. It might grow a little (or not, I don't know). But I promise I'll make concise, easy to review commits that will mostly be self-contained. I'd also

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Ferran Pujol Camins
> By the way I wouldn't be opposed to hiding the pingpong knob in Echo if it makes our lives easier :) :). Heh, I was thinking the same for the send knob :) 2015-07-31 19:32 GMT+02:00 Owen Williams : > On Fri, 2015-07-31 at 19:24 +0200, Ferran Pujol Camins wrote: > > > > The skins are also incon

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Owen Williams
On Fri, 2015-07-31 at 19:24 +0200, Ferran Pujol Camins wrote: > > The skins are also inconsistent in the way they handle the fx. > Yeah this is unfortunate but we've mostly decided to let them be inconsistent for now. My hope is that people will decide that one of the approaches is best and the

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Ferran Pujol Camins
PS: if this gains consensus, I volunteer to commit the changes, 2015-07-31 19:24 GMT+02:00 Ferran Pujol Camins : > I don't care delaying some skin polishing to 1.13 or whatever :) > > But let's make 1.12 happen ASAP. For me, the biggest headache with Deere > is the fx section. Just try to put th

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Ferran Pujol Camins
I don't care delaying some skin polishing to 1.13 or whatever :) But let's make 1.12 happen ASAP. For me, the biggest headache with Deere is the fx section. Just try to put the four units with the echo effect and expand the fx section. Theres no room for all the knobs in my 1366x768 screen. The sk

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Owen Williams
On Fri, 2015-07-31 at 18:19 +0200, Daniel Schürmann wrote: > > I am trying to keep the amount of work to a minimum to expedite the > release. > > How is this related to the view menu? > Thanks to Jercaianu Adding a new view option is a 10 lines patch > around https://github.com/mixxxdj/mixxx/blo

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Daniel Schürmann
Hi Owen, > I'd urge you to spend time investigating the reported issues with our streaming capability failing > after a period of time (https://bugs.launchpad.net/mixxx/+bug/1277274). Tuukka is already working on the issue. I have no test environment for broadcast so I cannot do this. I am happy

Re: [Mixxx-devel] Deere state

2015-07-31 Thread Owen Williams
I am trying to keep the amount of work to a minimum to expedite the release. I do think we need to unify our skins better, but I don't think those issue should block the release. If we try to unify everything now there will be a lot of ripple effects between skins that will slow things down too m

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Daniel Schürmann
Hi I do not see any reason to consider the vie menu as frozen. It will limit us a lot if we are not allowed to touch the preferred section for view options. The view menu already allows to enable options depending on the skin capabilities. it is already possible to allow a feature in a single skin

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Owen Williams
I'm going to be pretty hands-off with Deere and I'm hoping other people can step up and make changes. Jus has veto authority with respect to style changes, but in general it's more important that we iterate the skin quickly to get it in shape. In other words, patches welcome :) owen On Thu, 201

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Be
If the skin options menu is removed, there should still be some way to toggle at least some of those options. IMO the most important option is toggling stacked waveforms. There is room in the bar at the top for some option buttons. The "HEAD GAIN" text is brushing up against the left edge of th

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Owen Williams
Please remember that the global view menu is frozen for 1.12. From now on any changes to Deere should be restricted to the skin files only. One option is to push the skin menu to the next version since we're not going to add it to the other skins and that would be very inconsistent. I agree with

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Be
This is waaay better now. I like the use of knobs with different colored notches. There text is more readable, but it is still a bit too small. The buttons next to knobs are also too small. "Gain" should be renamed to "Master gain" for clarity. I feel that the skin options panel is awkward. Tho

Re: [Mixxx-devel] Deere state

2015-07-30 Thread Owen Williams
I went ahead and merged in the deere-updates skin. I took a look at it and it's definitely an improvement, and although it has issues I think we can open it up to the larger developer group now. Thanks for this work! The menu is amazing. Owen On Fri, 2015-07-24 at 16:11 +0200, S.Brandt wrote:

Re: [Mixxx-devel] Deere state

2015-07-28 Thread re-cycle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'd like to echo Ferran's observations in their entirety, except the hide library concern. Hiding the library will indeed be useful on smaller screens. In addition, I'd like to comment: - - there's a lot of texture/color based inconsistency in this ve

Re: [Mixxx-devel] Deere state

2015-07-28 Thread Ferran Pujol Camins
Oh, what are the items on your TODO? I have time to work now, so please share your thoughts about what I pointed and lets see if we can agree what needs to be done. 2015-07-28 13:14 GMT+02:00 Ferran Pujol Camins : > I must say I'm impressed, you've even taken care of a wish I made time ago > to

Re: [Mixxx-devel] Deere state

2015-07-28 Thread Ferran Pujol Camins
I must say I'm impressed, you've even taken care of a wish I made time ago to hide the BPM info :) Ok, here are my thoughts. There's a lot of things, keep in mind I say all this with a constructive attitude and that this is just my personal opinion :) -I love the spinnies, they are neat and cool.

Re: [Mixxx-devel] Deere state

2015-07-26 Thread Owen Williams
The issue is that jus has half-finished work, and others will be helping to fill in the gaps. So if we merge his work to 1.12, Deere will be in a slightly broken state for a while, which is not ideal. But at this point that skin is a major blocker, so I agree that it's ok. Jus, can you post a PR

Re: [Mixxx-devel] Deere state

2015-07-25 Thread Daniel Schürmann
I think it is not required. If you need a review, just issue a normal PR against 1.12 You are able to continue and add commits to this open PR. We do the same for the LibraryConcurentRefactoring branch. Am 24.07.2015 um 16:23 schrieb Owen Williams: > How about we create a sub-branch of 1.12 and me

Re: [Mixxx-devel] Deere state

2015-07-24 Thread Owen Williams
How about we create a sub-branch of 1.12 and merge your work there, and then we can have others help out. When it's in good shape we can merge it back into 1.12. (That way 1.12 stays pristine while we are cleaning things up.) On Fri, 2015-07-24 at 16:11 +0200, S.Brandt wrote: > Hi, > Deere maint

Re: [Mixxx-devel] Deere state

2015-07-24 Thread S.Brandt
Hi, Deere maintainer here. My current dev branch: [1] Fixes (mostly) all bugs for the skin listed: [2] It merges cleanly [3], but i`ve submitted no PR yet since it is still unfinished, some items on my todo. Unfortunately, time is an major issue. Suggestion? Test the skin in its current state a

[Mixxx-devel] Deere state

2015-07-23 Thread Ferran Pujol Camins
Hello, I thought I could put some love to Deere. But before I start to commit things that may not be appropriate, I would like to know if there are any specific plans for it. Whose the maintainer? Any suggestions? -- __