I am not an expert on QString malloc optimization so please review
carefully.
Andreas Müller (1):
coverart.cpp: fix build
src/library/coverart.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
--
2.5.5
a QLatin1String}')
return coverInfoRelativeToString(info) % QLatin1Literal(",") %
^
Signed-off-by: Andreas Müller
---
src/library/coverart.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
On Tue, Sep 20, 2016 at 11:42 AM, Daniel Schürmann wrote:
> I have just filed a QT bug
> https://bugreports.qt.io/browse/QTBUG-56087
>
>
>
> 2016-09-20 11:17 GMT+02:00 Daniel Schürmann :
>>
>> Hi Andreas,
>>
>> thank you for the patch.
>>
>> Looking at it, I havenoticed an Qt issue:
>>
>> In Qt 5,
On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote:
> Hi Andreas,
>
> The QStringBuilder() is somehow hidden. It is only invoked by the operator
> %.
> In all cases, where % is involved, you can simply replace
> QLatin1Literal("string") by "string".
>
> There is no need for testing, other tha
On Thu, Sep 22, 2016 at 10:40 AM, Andreas Müller
wrote:
> On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote:
>> Hi Andreas,
>>
>> The QStringBuilder() is somehow hidden. It is only invoked by the operator
>> %.
>> In all cases, where % is involved, you can
On Thu, Sep 22, 2016 at 10:50 AM, Andreas Müller
wrote:
> On Thu, Sep 22, 2016 at 10:40 AM, Andreas Müller
> wrote:
>> On Thu, Sep 22, 2016 at 8:21 AM, Daniel Schürmann wrote:
>>> Hi Andreas,
>>>
>>> The QStringBuilder() is somehow hidden. It is only in
