Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-23 Thread Maksym Veremeyenko
23.06.14 21:52, Dan Dennedy написав(ла): On Mon, Jun 23, 2014 at 10:02 AM, Maksym Veremeyenko wrote: 23.06.14 19:44, Dan Dennedy написав(ла): On Mon, Jun 23, 2014 at 8:30 AM, Maksym Veremeyenko wrote: 22.06.14 21:26, Dan Dennedy написав(ла): [...] I do not like changing the message from "

Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-23 Thread Dan Dennedy
On Mon, Jun 23, 2014 at 10:02 AM, Maksym Veremeyenko wrote: > 23.06.14 19:44, Dan Dennedy написав(ла): >> On Mon, Jun 23, 2014 at 8:30 AM, Maksym Veremeyenko >> wrote: >>> 22.06.14 21:26, Dan Dennedy написав(ла): > [...] I do not like changing the message from "no signal" to "frame is

Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-23 Thread Maksym Veremeyenko
23.06.14 19:44, Dan Dennedy написав(ла): > On Mon, Jun 23, 2014 at 8:30 AM, Maksym Veremeyenko wrote: >> 22.06.14 21:26, Dan Dennedy написав(ла): [...] >>> I do not like changing the message from "no signal" to "frame is >>> invalid." >> >> Blackmagic's API says: >> /.../ >> bmdFrameHasNoInputSour

Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-23 Thread Dan Dennedy
On Mon, Jun 23, 2014 at 8:30 AM, Maksym Veremeyenko wrote: > 22.06.14 21:26, Dan Dennedy написав(ла): > >> On Sun, Jun 22, 2014 at 6:21 AM, Maksym Veremeyenko >> wrote: >>> >>> Hi, >>> >>> attached patch reorder mlt frame initialization to avoid additional >>> mlt_frame_close for some cases. >> >>

Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-23 Thread Maksym Veremeyenko
22.06.14 21:26, Dan Dennedy написав(ла): > On Sun, Jun 22, 2014 at 6:21 AM, Maksym Veremeyenko wrote: >> Hi, >> >> attached patch reorder mlt frame initialization to avoid additional >> mlt_frame_close for some cases. > > What problem does it solve? its avoid calling mlt_frame_close if some error

Re: [Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-22 Thread Dan Dennedy
On Sun, Jun 22, 2014 at 6:21 AM, Maksym Veremeyenko wrote: > Hi, > > attached patch reorder mlt frame initialization to avoid additional > mlt_frame_close for some cases. What problem does it solve? I do not like changing the message from "no signal" to "frame is invalid." The existing message is

[Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts

2014-06-22 Thread Maksym Veremeyenko
Hi, attached patch reorder mlt frame initialization to avoid additional mlt_frame_close for some cases. -- Maksym Veremeyenko >From 85c892311c19099189147b616ff50177988a0c97 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Sun, 22 Jun 2014 17:29