Re: [Mlt-devel] Xml output is currenty broken

2012-02-05 Thread Dan Dennedy
On Wed, Jan 25, 2012 at 9:42 PM, Brian Matherly pez4br...@yahoo.com wrote:  I can provide a patch to convert the entire module to use mlt_log() later. And here it is: https://github.com/pez4brian/mlt/commit/dc854a78f229b7218990cb742a8a507fba457842 applied -- +-DRD-+

Re: [Mlt-devel] Xml output is currenty broken

2012-01-25 Thread Dan Dennedy
On Wed, Jan 25, 2012 at 8:21 PM, Brian Matherly pez4br...@yahoo.com wrote: Dan,  I made my comments on github. Thanks Dan. Let me rework the patch and get back to you. I think I will: * Put the startElement callback back where it belongs. * Add code to bail out after the first pass if

Re: [Mlt-devel] Xml output is currenty broken

2012-01-24 Thread Dan Dennedy
On Mon, Jan 23, 2012 at 7:58 PM, Brian Matherly pez4br...@yahoo.com wrote: Dan,  I did come up with some additional error reporting so that if the xml  fails to load, at least it doesn't fail silently: https://github.com/pez4brian/mlt/commit/5fc4d19e81e658e1236da5b82457cfa8b428a705  Feel

Re: [Mlt-devel] Xml output is currenty broken

2012-01-24 Thread Brian Matherly
 I did come up with some additional error reporting so that if the xml  fails to load, at least it doesn't fail silently: snip I definitely like the contribution, but it should use mlt_log_warning() instead of fprintf(stderr). The other fprintf(stderr) you see there are simply

Re: [Mlt-devel] Xml output is currenty broken

2012-01-23 Thread Brian Matherly
I thought that I could add some sanity checking to producer_xml.c and maybe even fix broken input XML encoding. But libxml doesn't make that simple. I did come up with some additional error reporting so that if the xml fails to load, at least it doesn't fail silently:

Re: [Mlt-devel] Xml output is currenty broken

2012-01-23 Thread Brian Matherly
I thought of a new policy to add to docs/policies.txt and somewhere in doxygen comments: The standard for strings in MLT is UTF-8. Applications must provide valid UTF-8. That means, melt would be responsible for converting from environment locale's encoding to UTF-8. And melt

Re: [Mlt-devel] Xml output is currenty broken

2012-01-22 Thread Dan Dennedy
On Sun, Jan 22, 2012 at 1:36 PM, Brian Matherly pez4br...@yahoo.com wrote: JB, Creating xml files from the avformat producer is currently broken with FFmpeg's recent git. The problem comes from avformat's handler_name metadata, whose value contains invalid characters. The problem only

Re: [Mlt-devel] Xml output is currenty broken

2012-01-22 Thread Dan Dennedy
On Sun, Jan 22, 2012 at 1:48 PM, Dan Dennedy d...@dennedy.org wrote: On Sun, Jan 22, 2012 at 1:36 PM, Brian Matherly pez4br...@yahoo.com wrote: JB, Creating xml files from the avformat producer is currently broken with FFmpeg's recent git. The problem comes from avformat's handler_name