Thanks Jochen,
It’s summer holidays here and I am looking after the kids, so I will have
restricted time to work on this for a few weeks, plus I want to rework my PR
anyway, so expect a few delays to activity from me.
Best and Happy New Year
Ross
> On 6 Jan 2018, at 2:23 am, Jochen Wiedmann w
As you are a committer now, Ross, you can do the work for yourself. Should
be quicker and easier than going through a PR.
Jochen
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it,
First, thanks to all for your comments and help getting my first PR through.
I have another pull request out there ready for integration, and yet
another which I have not submitted as it really depends on the first one
going through. Should I submit the extra pull request now or wait until my
Hi,
here are others who could help on that...
apart from that of course thanks so far for the help of Jochen...and happy
holiday...
Kind regards
Karl Heinz Marbaise
On Thursday, August 24, 2017 at 5:25:55 PM UTC+2, Jochen Wiedmann wrote:
>
> On Wed, Aug 23, 2017 at 11:27 PM, Ross Lamont > wro
On Wed, Aug 23, 2017 at 11:27 PM, Ross Lamont wrote:
> I have updated git to better fit what you require:
>
> The PR only fixes one issue now, issue #16. I have described the fix in
> more detail in the PR.
Hi, Ross,
I am on vacation right now, with no Laptop, or the like. Please have
the pati
Ross Lamont writes:
> I have updated git to better fit what you require:
>
> The PR only fixes one issue now, issue #16. I have described the fix in
> more detail in the PR.
Let me quote [0]:
A project’s long-term success rests (among other things) on its
maintainability, and a mainta
Sorry, forgot to add, its pull request:
https://github.com/mojohaus/xml-maven-plugin/pull/22
On Saturday, August 12, 2017 at 7:35:22 PM UTC+10, Jochen Wiedmann wrote:
>
> On Thu, Aug 10, 2017 at 7:00 AM, Ross Lamont
>
> > What's the process around getting pull requests processed for a plugin?
Hi Jochen,
I have updated git to better fit what you require:
The PR only fixes one issue now, issue #16. I have described the fix in
more detail in the PR.
Ross
On Saturday, August 12, 2017 at 7:35:22 PM UTC+10, Jochen Wiedmann wrote:
>
> On Thu, Aug 10, 2017 at 7:00 AM, Ross Lamont
>
> > W
OK.
1. I've closed that pull request, reverted my changes to the original
commit and created a new PR.
2. The description of the new PR is clearer I think, it fixes 2 pretty
simple issues.
3. In this PR there is only 1 substantial file changed, but because test
cases in this project tend to req
On Thu, Aug 10, 2017 at 7:00 AM, Ross Lamont
> What's the process around getting pull requests processed for a plugin?
> I've made some improvements/fixes to xml-maven-plugin, and I have a few more
> to add after this lot have made it to the master.
>
> Hope I'm not being too impatient!
If you ar
Hi folks,
What's the process around getting pull requests processed for a plugin?
I've made some improvements/fixes to xml-maven-plugin, and I have a few
more to add after this lot have made it to the master.
Hope I'm not being too impatient!
Cheers
Ross Lamont
--
You received this messag
11 matches
Mail list logo
