On 17/10/14 03:52, David Nelson wrote:
...my observations have not convinced me
that such contributions would be an effective use of my time.
Did your observations include only unmerged pull requests, or did you
also happen to check how many of them get merged? The latter is
important too.
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list-
boun...@lists.ximian.com] On Behalf Of Martin Thwaites
Just to give my2cents on this.
I would just like to know that things will get looked at approved at some
point.
Getting reviewed is one thing. (Difficult
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list-
boun...@lists.ximian.com] On Behalf Of Edward Ned Harvey (mono)
Getting reviewed is one thing. (Difficult enough.) Getting approved is a
completely different thing - even more perilous.
... etc etc yadda yadda ...
This topic has been brought up in a ton of other threads I just want
to centralize the topic.
I have felt the pain many others have discussed (6-12 months for an
accept of PR, we actually had a separate distribution of mono for a
while).
Is there background on the issue?
What are the issues that
Hello Greg,
The best approach is to stay engaged in the pull requests and bring the
attention to the mailing list for us to discuss.
Long term, the ideal situation is one where we can give more people commit
rights, and review rights. But until we have developed the skills in the
community
Miguel,
In the meantime, if you need quick hacks, you can always fork Mono
and distribute your forked version with your changes.
To be fair you know the pain we deal with due to this.
For us if we had a backlog of 200 PRs this would be a wonderful
problem to have. I would immediately hire 1-2
Just to give my2cents on this.
I would just like to know that things will get looked at approved at some
point. I saw a while back that there was a flurry of activity on PR's, and
some people (possibly after direction from Miguel) whacked that list down
considerably.
Is there anything that
Long term, the ideal situation is one where we can give more people commit
rights, and review rights. But until we have developed the skills in the
community that are needed, we will continue with the current setup.
This seems to be a chicken-and-egg problem. We need to christen more
reviewers
There is no point in starting a discussion where you are going to cherry
pick facts for the sake of your argument.
As for contributing, which one of *your* pull requests have been pending
and not being reviewed?
Because we would like to provide you with the valuable feedback that you
need to
Let me add a couple of points.
First, I have noticed is that:
- Contributors do not make a habit out of checking pull requests; I
know I don't
- GitHub is too chatty, so everyone I know just filters notifications.
I suspect this is why anyone being assigned issues just ignores
Hi Miguel,
I have considered helping out by commenting on PR's, however, I've always
felt that I'm not nearly experienced enough to have my opinion/view
respected by the committer.
I definitely think forcing/gently encouraging people to create a discussion
on mailing list to ask for review would
Hi,
lastly I posted two pull requests corresponding to bugs founded in
bugzilla.
One of these has even already be closed, however nobody showed
interesting
in pulling my changes or rejecting them. Could anyone with privileges
check
it out?
One can find requests here:
12 matches
Mail list logo
