RE: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Thanks for the reviews . I removed the comment and pushed the change . Best regards, Matthias > -Original Message- > From: Langer, Christoph > Sent: Montag, 26. August 2019 16:10 > To: Chris Hegarty ; Baesken, Matthias > > Cc: net-dev@openjdk.java.net > Subject: RE: RFR [XS] : 8229706: > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX > machines > > Hi Matthias, > > looks good to me, too. And +1 for dropping the comment. > > Best regards > Christoph > > > -Original Message- > > From: net-dev On Behalf Of Chris > > Hegarty > > Sent: Freitag, 16. August 2019 13:44 > > To: Baesken, Matthias > > Cc: net-dev@openjdk.java.net > > Subject: Re: RFR [XS] : 8229706: > > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX > > machines > > > > > > > On 16 Aug 2019, at 10:51, Baesken, Matthias > > > wrote: > > > > > > Thanks alot ! > > > > > > I guess I can push this as trivial (but a second reviewer would be good > too > > ). > > > > The change looks fine. > > > > You could probably drop the comment, I don’t think that > > it’s really needed. > > > > > Best regards, Matthias > > > > > >> -Original Message- > > >> From: Daniel Fuchs > > >> ... > > >> > > >> I haven't observed any failures over 50 runs on all > > >> platforms tested. macosx is problem listed for this > > >> test so it wasn't run there - but all others platforms > > >> passed with your changes. > > > > The set of checks in the NetworkConfiguration for > > has_testableipv6address could probably be expanded to > > include macOS. The maybe the test could be removed > > from the ProblemList ( for mac ). But that is a separate > > issue, for a follow-on, verification, testing, etc. > > > > -Chris.
RE: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Hi Matthias, looks good to me, too. And +1 for dropping the comment. Best regards Christoph > -Original Message- > From: net-dev On Behalf Of Chris > Hegarty > Sent: Freitag, 16. August 2019 13:44 > To: Baesken, Matthias > Cc: net-dev@openjdk.java.net > Subject: Re: RFR [XS] : 8229706: > java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX > machines > > > > On 16 Aug 2019, at 10:51, Baesken, Matthias > wrote: > > > > Thanks alot ! > > > > I guess I can push this as trivial (but a second reviewer would be good > > too > ). > > The change looks fine. > > You could probably drop the comment, I don’t think that > it’s really needed. > > > Best regards, Matthias > > > >> -Original Message- > >> From: Daniel Fuchs > >> ... > >> > >> I haven't observed any failures over 50 runs on all > >> platforms tested. macosx is problem listed for this > >> test so it wasn't run there - but all others platforms > >> passed with your changes. > > The set of checks in the NetworkConfiguration for > has_testableipv6address could probably be expanded to > include macOS. The maybe the test could be removed > from the ProblemList ( for mac ). But that is a separate > issue, for a follow-on, verification, testing, etc. > > -Chris.
Re: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
> On 16 Aug 2019, at 10:51, Baesken, Matthias wrote: > > Thanks alot ! > > I guess I can push this as trivial (but a second reviewer would be good too > ). The change looks fine. You could probably drop the comment, I don’t think that it’s really needed. > Best regards, Matthias > >> -Original Message- >> From: Daniel Fuchs >> ... >> >> I haven't observed any failures over 50 runs on all >> platforms tested. macosx is problem listed for this >> test so it wasn't run there - but all others platforms >> passed with your changes. The set of checks in the NetworkConfiguration for has_testableipv6address could probably be expanded to include macOS. The maybe the test could be removed from the ProblemList ( for mac ). But that is a separate issue, for a follow-on, verification, testing, etc. -Chris.
RE: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Thanks alot !
I guess I can push this as trivial (but a second reviewer would be good too ).
Best regards, Matthias
> -Original Message-
> From: Daniel Fuchs
> Sent: Freitag, 16. August 2019 10:55
> To: Baesken, Matthias ; net-
> d...@openjdk.java.net
> Subject: Re: RFR [XS] : 8229706:
> java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX
> machines
>
> Hi Matthias,
>
> I haven't observed any failures over 50 runs on all
> platforms tested. macosx is problem listed for this
> test so it wasn't run there - but all others platforms
> passed with your changes.
>
> You can count me as reviewer.
>
> best regards,
>
> -- daniel
>
> On 16/08/2019 06:24, Baesken, Matthias wrote:
> >> I'll report back when I have the results:-)
> >>
> >> best regards,
> >>
> >> -- daniel
> >>
> >> On 15/08/2019 08:24, Baesken, Matthias wrote:
> >>> Hello, please review this small test adjustment .
> >>>
> >>> On some AIX machines the
> >> java/net/MulticastSocket/NoLoopbackPackets.java
> >>> test failed .
> >>>
> >>>
> >>> The IPV6 tests of NoLoopbackPackets.java e.g. for "ff02::1:1" IPV6
> >>> entry in the test are the problematic one.
> >>>
> >>> ifconfig -a on the "good" machine showed an inet6 address configured
> for
> >>> en0.
> >>> But on the machines where the test fails, an inet6 address is NOT
> >>> displayed by ifconfig -a.
> >>>
> >>>
> >>> A similar issue has been discussed for other Multicast tests ("8207404:
> >>> MulticastSocket tests failing on Aix" ), so I
> >>> adjusted the checks in the test a bit .
> >>>
> >>> Bug/webrev :
> >>>
> >>> https://bugs.openjdk.java.net/browse/JDK-8229706
> >>>
> >>> http://cr.openjdk.java.net/~mbaesken/webrevs/8229706.0/
> >>>
> >>> Best regards, Matthias
> >>>
Re: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Hi Matthias,
I haven't observed any failures over 50 runs on all
platforms tested. macosx is problem listed for this
test so it wasn't run there - but all others platforms
passed with your changes.
You can count me as reviewer.
best regards,
-- daniel
On 16/08/2019 06:24, Baesken, Matthias wrote:
I'll report back when I have the results:-)
best regards,
-- daniel
On 15/08/2019 08:24, Baesken, Matthias wrote:
Hello, please review this small test adjustment .
On some AIX machines the
java/net/MulticastSocket/NoLoopbackPackets.java
test failed .
The IPV6 tests of NoLoopbackPackets.java e.g. for "ff02::1:1" IPV6
entry in the test are the problematic one.
ifconfig -a on the "good" machine showed an inet6 address configured for
en0.
But on the machines where the test fails, an inet6 address is NOT
displayed by ifconfig -a.
A similar issue has been discussed for other Multicast tests ("8207404:
MulticastSocket tests failing on Aix" ), so I
adjusted the checks in the test a bit .
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8229706
http://cr.openjdk.java.net/~mbaesken/webrevs/8229706.0/
Best regards, Matthias
RE: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Thanks !
> -Original Message-
> From: Daniel Fuchs
> Sent: Donnerstag, 15. August 2019 19:42
> To: Baesken, Matthias ; net-
> d...@openjdk.java.net
> Subject: Re: RFR [XS] : 8229706:
> java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX
> machines
>
> Hi Matthias,
>
> On the surface I think your fix looks good.
> I have imported it and sent to our test farm.
> I'll report back when I have the results :-)
>
> best regards,
>
> -- daniel
>
> On 15/08/2019 08:24, Baesken, Matthias wrote:
> > Hello, please review this small test adjustment .
> >
> > On some AIX machines the
> java/net/MulticastSocket/NoLoopbackPackets.java
> > test failed .
> >
> >
> > The IPV6 tests of NoLoopbackPackets.java e.g. for "ff02::1:1" IPV6
> > entry in the test are the problematic one.
> >
> > ifconfig -a on the "good" machine showed an inet6 address configured for
> > en0.
> > But on the machines where the test fails, an inet6 address is NOT
> > displayed by ifconfig -a.
> >
> >
> > A similar issue has been discussed for other Multicast tests ("8207404:
> > MulticastSocket tests failing on Aix" ), so I
> > adjusted the checks in the test a bit .
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8229706
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8229706.0/
> >
> > Best regards, Matthias
> >
Re: RFR [XS] : 8229706: java/net/MulticastSocket/NoLoopbackPackets.java fails on some AIX machines
Hi Matthias,
On the surface I think your fix looks good.
I have imported it and sent to our test farm.
I'll report back when I have the results :-)
best regards,
-- daniel
On 15/08/2019 08:24, Baesken, Matthias wrote:
Hello, please review this small test adjustment .
On some AIX machines the java/net/MulticastSocket/NoLoopbackPackets.java
test failed .
The IPV6 tests of NoLoopbackPackets.java e.g. for "ff02::1:1" IPV6
entry in the test are the problematic one.
ifconfig -a on the "good" machine showed an inet6 address configured for
en0.
But on the machines where the test fails, an inet6 address is NOT
displayed by ifconfig -a.
A similar issue has been discussed for other Multicast tests ("8207404:
MulticastSocket tests failing on Aix" ), so I
adjusted the checks in the test a bit .
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8229706
http://cr.openjdk.java.net/~mbaesken/webrevs/8229706.0/
Best regards, Matthias
