Re: RFR 8145635 : Add TCP_QUICKACK socket option

On 19/10/17 10:12, Alan Bateman wrote: ... I can't recall if I brought this up already but we do have an issue to deprecate-for-removal jdk.net.Sockets? Socket and friends were rev'ed in Java 9 to add set/getOption methods so I assume the static methods on jdk.net.Sockets can go away in time.

Re: RFR 8145635 : Add TCP_QUICKACK socket option

On 19/10/2017 03:56, vyom tewari wrote: Hi All, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.7/index.html). I can't recall if I brought this up already but we do have an issue to deprecate-for-removal jdk.net.Sockets? Socket and friends were rev'ed in

Re: RFR 8145635 : Add TCP_QUICKACK socket option

> On 19 Oct 2017, at 03:56, vyom tewari wrote: > > Hi All, > > please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.7/index.html). Thanks Vyom, this update looks good to me. -Chris.

RE: RFR 8145635 : Add TCP_QUICKACK socket option

Boolean.class); > > > > Other than that you should consider it reviewed from my end. No need for > further webrev... > > > > Best regards > > Christoph > > > >> -Original Message- > >> From: net-dev [mailto:net-dev-boun...@openjdk.jav

RE: RFR 8145635 : Add TCP_QUICKACK socket option

.java.net] On Behalf Of > vyom tewari > Sent: Dienstag, 17. Oktober 2017 10:37 > To: net-dev@openjdk.java.net > Subject: Re: RFR 8145635 : Add TCP_QUICKACK socket option > > Hi Roger, > > Thanks for the review , please find the updated > webrev(http://cr.openjdk.jav

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Roger, Thanks for the review , please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.6/index.html). Thanks, Vyom On Tuesday 17 October 2017 06:35 AM, Roger Riggs wrote: Hi Vyom, A few suggestions: PlainDatagramSocketImpl.java:  - line 95/96:  I think you

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Vyom, A few suggestions: PlainDatagramSocketImpl.java:  - line 95/96:  I think you can use just forEach, the order version is not necessary.     The code will be a bit more readable if the .filter and .forEach are on a new line and don't wrap.     You can also remove the extra "(" and ")

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Chris, Thanks for review. Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.5/index.html). Thanks, Vyom On Saturday 14 October 2017 02:25 AM, Chris Hegarty wrote: Vyom, On 12 Oct 2017, at 10:01, vyom tewari wrote: Hi Roger,

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Vyom, > On 12 Oct 2017, at 10:01, vyom tewari wrote: > > Hi Roger, > > Thanks for the review, i incorporated all review comments from you > except("you can use ExtendedSocketOptions.TCP_QUICKACK to check for the > option to omit without > embedding the name.").

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Alan, thanks for pointing out, i am forwarding it to net-dev list. Vyom On Thursday 12 October 2017 03:54 PM, Alan Bateman wrote: Best to reply on net-dev as that is where the main review should be going on (seems there are at two review threads going, maybe they could unite on net-dev).

Re: RFR 8145635 : Add TCP_QUICKACK socket option

On 11/10/2017 21:08, Chris Hegarty wrote: Given that this option is specific to TCP, then the `TCP_` prefix is more appropriate. I agree. We have StandardSocketOptions.TCP_NODELAY as an example to look at. -Alan

Re: RFR 8145635 : Add TCP_QUICKACK socket option

> On 11 Oct 2017, at 10:43, vyom tewari wrote: > > Hi Chris, > > > On Wednesday 11 October 2017 12:28 AM, Chris Hegarty wrote: >> Vyom, >> >> What about suggestion 1) below, the name of the socket option? > to be consistent with SO_FLOW_SLA in

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Chris, On Wednesday 11 October 2017 12:28 AM, Chris Hegarty wrote: Vyom, What about suggestion 1) below, the name of the socket option? to be consistent with SO_FLOW_SLA in ExtendedSocketOptions.java, i choose the "SO" prefix. But I don't know the history behind the "SO" prefix  so i

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Vyom, What about suggestion 1) below, the name of the socket option? -Chris. > On 27 Sep 2017, at 09:56, vyom tewari wrote: > > Hi Chris, > > Thanks for review, please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.2/index.html). I >

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi Chris, Thanks for review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8145635/webrev0.2/index.html). I incorporated review comments from you and re-base the patch to our consolidated repo(jdk10/master). Thanks, Vyom On Monday 25 September 2017 01:57 AM, Chris

Re: RFR 8145635 : Add TCP_QUICKACK socket option

ping!! Vyom On Monday 11 September 2017 09:08 PM, vyom tewari wrote: Hi All, As jdk.net API already moved out of java.base, Please review the below code change for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8145635 Webrev:

Re: RFR 8145635 : Add TCP_QUICKACK socket option

Hi All, As jdk.net API already moved out of java.base, Please review the below code change for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8145635 Webrev: http://cr.openjdk.java.net/~vtewari/8145635/webrev0.1/index.html Thanks, Vyom On Wednesday 24 February 2016 03:16 PM, Alan

Re: RFR 8145635 : Add TCP_QUICKACK socket option

On 24/02/2016 09:16, vyom wrote: Hi All, Please review my code changes for the below issue. Bug: JDK-8145635 : Add TCP_QUICKACK socket option Webrev: http://cr.openjdk.java.net/~vtewari/8145635/webrev0.0/index.html Currently TCP_QUICKACK is only supported on Linux( since Linux 2.4.4) so i

RFR 8145635 : Add TCP_QUICKACK socket option

Hi All, Please review my code changes for the below issue. Bug: JDK-8145635 : Add TCP_QUICKACK socket option Webrev: http://cr.openjdk.java.net/~vtewari/8145635/webrev0.0/index.html Currently TCP_QUICKACK is only supported