Re: sky2: error reporting

2006-01-16 Thread Daniel Drake
Stephen Hemminger wrote: Try this, it limits the console output and attempts to handle more errors. Of course, I see no errors on my systems (that would make this problem too easy)... No luck, the output now freezes after: ACPI: PCI Interrupt :03:00.0[A] - Link [LNKB] - GSI 10 (level,

Re: PATCH: iproute2 - prio qdisc, fix priomap

2006-01-16 Thread jamal
On Mon, 2006-16-01 at 06:51 +0100, Patrick McHardy wrote: jamal wrote: On Mon, 2006-16-01 at 05:56 +0100, Patrick McHardy wrote: This is a dead horse since I ACKed the patch, but that patch is _wrong_ without the user space fix. What's wrong with this: tc qdisc add dev dummy0 root

Re: linux networking kernel layer and STREAMS

2006-01-16 Thread jamal
On Mon, 2006-16-01 at 09:21 +0100, Willem de Bruijn wrote: The reason I ended up with it was purely practical and even grew out of a single-module system. Streams fitted our use-case, which is to run code in userspace, kernelspace and on the network-card. Communicating across 3

[PATCH] WLAN acx100: OOPS fix, KERN_xxx, misc.

2006-01-16 Thread Andreas Mohr
prefixes to printk() as requested recently Note that both patches are based on acx-20060116 proper (rediffed from acx-20060113), smallish conflicts may result; apply acx-20060116_KERN_xxx.diff after acx-20060116_misc.diff. Andreas Mohr diff -urN acx-20060116.orig/acx_struct.h acx-20060116_misc

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Jiri Benc
On Fri, 13 Jan 2006 23:32:02 +0100, Johannes Berg wrote: IMHO there's not much point in allowing changes. I have a feeling that might create icky issues you don't want to have to tackle when the solution is easy by just not allowing it. Part of my thinking is that different virtual types have

Re: wireless: recap of current issues (actions)

2006-01-16 Thread Johannes Berg
On Sat, 2006-01-14 at 19:56 -0500, John W. Linville wrote: Yes, someone (Johannes? Jiri?) had the beginnings of this a few days ago, but I seem to have lost the link. Could someone repost it? http://johannes.sipsolutions.net/802.11_stacks/ Someone should start a new page to collect all the

Re: [PATCH] fix mv643xx compilation

2006-01-16 Thread Olaf Hering
2.6.16 needs ip.h and in.h. linux-2.6.15/drivers/net/mv643xx_eth.c: In function `mv643xx_eth_start_xmit': linux-2.6.15/drivers/net/mv643xx_eth.c:1159: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: dereferencing pointer to incomplete type

[PATCH 2/3] [NETFILTER] ip6tables: remove unused definitions

2006-01-16 Thread Harald Welte
[NETFILTER] ip6tables: remove unused definitions These definitions ware used for only internal use in kernel = 2.6.13, which had not introduced the unified parser of IPv6 extension header yet. Signed-off-by: Yasuyuki Kozakai [EMAIL PROTECTED] Signed-off-by: Harald Welte [EMAIL PROTECTED] ---

[PATCH 3/3] [NETFILTER] ip6tables: whitespace and indent cosmetic cleanup

2006-01-16 Thread Harald Welte
[NETFILTER] ip6tables: whitespace and indent cosmetic cleanup Signed-off-by: Yasuyuki Kozakai [EMAIL PROTECTED] Signed-off-by: Harald Welte [EMAIL PROTECTED] --- commit 663dafd271c08d6cf69ecaa1daf34380276b9945 tree 6194991675051520a186f40f587c1a55827a5081 parent

[PATCH 1/3] [NETFILTER] Makefile cleanup

2006-01-16 Thread Harald Welte
[NETFILTER] Makefile cleanup These are replaced with x_tables matches and no longer exist. Signed-off-by: Yasuyuki Kozakai [EMAIL PROTECTED] Signed-off-by: Harald Welte [EMAIL PROTECTED] --- commit 396728c2753f13781973532b4074bfdb398ad675 tree cefbd947576c9ec4511153242109a6566079ebdf parent

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Sun, Jan 15, 2006 at 09:05:33PM +0200, Samuel Ortiz wrote: Regarding 802.11d and regulatory domains, the stack should also be able to stick to one regulatory domain if asked so by userspace, whatever the APs around tell us. ...and in doing so, violate the local regulatory constraints. :)

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Sun, Jan 15, 2006 at 11:53:55AM -0800, Sam Leffler wrote: The above is a great synopsis but there is more. For example to support roaming (and sometimes for ap operation) you want to do background scanning; this ties in to power save mode if operating as a station. Opportunistic roaming

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 03:55:55PM +0100, Johannes Berg wrote: I really don't see why a plain STA mode card should be required to carry around all the code required for AP operation -- handling associations of clients, powersave management wrt. buffering, ... Sure, fragmentation From the

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Sam Leffler
Stuffed Crust wrote: On Sun, Jan 15, 2006 at 11:53:55AM -0800, Sam Leffler wrote: The above is a great synopsis but there is more. For example to support roaming (and sometimes for ap operation) you want to do background scanning; this ties in to power save mode if operating as a station.

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Sam Leffler
Stuffed Crust wrote: On Mon, Jan 16, 2006 at 03:55:55PM +0100, Johannes Berg wrote: I really don't see why a plain STA mode card should be required to carry around all the code required for AP operation -- handling associations of clients, powersave management wrt. buffering, ... Sure,

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread John W. Linville
On Mon, Jan 16, 2006 at 08:51:31PM +0200, Samuel Ortiz wrote: On Mon, 16 Jan 2006, ext Stuffed Crust wrote: On Sun, Jan 15, 2006 at 09:05:33PM +0200, Samuel Ortiz wrote: Regarding 802.11d and regulatory domains, the stack should also be able to stick to one regulatory domain if asked so

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 09:54:15AM -0800, Sam Leffler wrote: The way you implement bg scanning is to notify the ap you are going into power save mode before you leave the channel (in sta mode). Hence bg scanning and power save operation interact. That is not powersave operation -- that is

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-16 Thread Dan Williams
On Fri, 2006-01-13 at 18:09 +0100, Steffen Klassert wrote: ... I still have a patch in queue to improve usage of netif_carrier_{on,off} but I had no possibility to test yet, so I did not send. I'd be happy to test it out if you'd like. Dan Hi Dan, here is the patch for

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 09:07:52PM +0200, Samuel Ortiz wrote: That is true, thin MACs usually don't filter beacons on the same channel. But in some cases (mainly power saving), you really want to avoid receiving useless beacons and having the host woken up for each of them. You may even want

[patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Andy Gospodarek
Printing the total number of sockets used in /proc/net/sockstat is out of place in a file that is supposed to contain information related to ipv4 sockets. Removed output for total socket usage. Signed-off-by: Andy Gospodarek [EMAIL PROTECTED] --- proc.c |1 - 1 files changed, 1 deletion(-)

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Lee Revell
On Mon, 2006-01-16 at 15:04 -0500, Andy Gospodarek wrote: Printing the total number of sockets used in /proc/net/sockstat is out of place in a file that is supposed to contain information related to ipv4 sockets. Removed output for total socket usage. Um, you can't do that, it will break

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Samuel Ortiz
On Mon, 16 Jan 2006, ext Stuffed Crust wrote: You may hear another beacon when the STA is awake, you may not. BSSID filtering has nothing to do with 802.11 power save, but rather is intented to reduce the host load (interrupts, processing overhead) and thus the host power consumption. I know

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Sam Leffler
Stuffed Crust wrote: On Mon, Jan 16, 2006 at 09:54:15AM -0800, Sam Leffler wrote: The way you implement bg scanning is to notify the ap you are going into power save mode before you leave the channel (in sta mode). Hence bg scanning and power save operation interact. That is not powersave

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Samuel Ortiz
On Mon, 16 Jan 2006, ext John W. Linville wrote: On Mon, Jan 16, 2006 at 08:51:31PM +0200, Samuel Ortiz wrote: On Mon, 16 Jan 2006, ext Stuffed Crust wrote: On Sun, Jan 15, 2006 at 09:05:33PM +0200, Samuel Ortiz wrote: Regarding 802.11d and regulatory domains, the stack should also be

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Jesper Juhl
On 1/16/06, Andy Gospodarek [EMAIL PROTECTED] wrote: What userspace app will break because of this? On 1/16/06, Lee Revell [EMAIL PROTECTED] wrote: On Mon, 2006-01-16 at 15:04 -0500, Andy Gospodarek wrote: Printing the total number of sockets used in /proc/net/sockstat is out of place

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Andy Gospodarek
Jesper, Thanks for the explanation. Your reasoning makes sense. I will consider other ways to solve my current problem and post a patch that doesn't break userspace if necessary. -andy On 1/16/06, Jesper Juhl [EMAIL PROTECTED] wrote: On 1/16/06, Andy Gospodarek [EMAIL PROTECTED] wrote:

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 12:14:08PM -0800, Sam Leffler wrote: Please read what I wrote again. Station mode power save work involves communicating with the ap and managing the hardware. The first interacts with bg scanning. We haven't even talked about how to handle sta mode power save. I

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 10:16:06PM +0200, Samuel Ortiz wrote: Well, I'd rather trust a governement regulated network than my neighbour's AP ;-) In fact, some phones set their 802.11 regulatory domain based on the information they received from a somehow government regulated network, e.g. a GSM

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Jesper Juhl
On 1/16/06, Andy Gospodarek [EMAIL PROTECTED] wrote: [could you *please* not top post? It's pretty annoying] Jesper, Thanks for the explanation. Your reasoning makes sense. I will I'm glad you found it useful. consider other ways to solve my current problem and post a patch that doesn't

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-16 Thread John W. Linville
On Wed, Jan 04, 2006 at 09:33:27AM +1030, Graham Gower wrote: On 03/01/06, Patrick McHardy [EMAIL PROTECTED] wrote: Graham Gower wrote: My logs were starting to fill with messages exatcly like that mentioned here: http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread Alan Cox
On Llu, 2006-01-16 at 14:06 -0500, John W. Linville wrote: If regulators come down on someone, it seems like common sense that they would be more lenient on mobile stations complying with a misconfigured AP than they would be with a mobile station ignoring a properly configured AP? I know

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread Andy Gospodarek
On 1/16/06, Jesper Juhl [EMAIL PROTECTED] wrote: Maybe if you described your current problem someone could suggest a solution... Sure, I'd be glad to. If I add up all the entries from the procfiles (in /proc/net) on my system packet = 1 netlink = 6 raw = 0 raw6 = 0 tcp = 5 tcp6 = 3 udp = 9

[PATCH 1/1] LSM-IPsec SELinux Authorize

2006-01-16 Thread cxzhang
This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no authorization (besides the check for write permissions to SAD and SPD) is required to delete IPsec policies and security assocations with security

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-16 Thread Steffen Klassert
On Mon, Jan 16, 2006 at 02:43:30PM -0500, Dan Williams wrote: ... The patch appears to work correctly and does notice links quite a bit sooner. The only issue I noticed was that if no cable is plugged in, it starts off with the carrier on (/sys/class/net/eth0/carrier == 1) but a second later

Re: wireless: recap of current issues (configuration)

2006-01-16 Thread John W. Linville
On Mon, Jan 16, 2006 at 10:24:41PM +, Alan Cox wrote: I would expect equipment to honour the subset of configurations that meet BOTH the regulatory domain the system believes it exists within (which may change dynamically!) AND the AP advertisement. If I have told my equipment to obey

[PATCH 2/4 - 2.6.15]net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-16 Thread Shaun Pereira
Provides a 32 bit conversion function for SIOCGSTAMP diff -uprN -X dontdiff linux-2.6.15-vanilla/include/net/compat.h linux-2.6.15/include/net/compat.h --- linux-2.6.15-vanilla/include/net/compat.h 2006-01-03 14:21:10.0 +1100 +++ linux-2.6.15/include/net/compat.h 2006-01-17

[PATCH 4/4]x25: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-16 Thread Shaun Pereira
A small fix for the following error, when trying to run a 64 bit x25 server application. T2 kernel: schedule_timeout: wrong timeout value from 88164796 diff -uprN -X dontdiff linux-2.6.15-vanilla/net/x25/af_x25.c linux-2.6.15/net/x25/af_x25.c ---

[Patch 00/13] mv643xx_eth: Bug Fixes

2006-01-16 Thread Dale Farnsworth
This patch series for the Marvell mv643xx ethernet controller contains primarily bug fixes. 1. Add Dale Farnsworth as a maintainer 2. 2.6.16 needs ip.h and in.h Bug fix, from Olaf Hering [EMAIL PROTECTED] 3. Fix dma_map/dma_unmap relations Bug fix, from Paolo Galtieri [EMAIL

[Patch 02/13] mv643xx_eth: 2.6.16 needs ip.h and in.h

2006-01-16 Thread Dale Farnsworth
From: Olaf Hering [EMAIL PROTECTED] Signed-off-by: Olaf Hering [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[Patch 03/13] mv643xx_eth: Fix dma_map/dma_unmap relations

2006-01-16 Thread Dale Farnsworth
From: Paolo Galtieri [EMAIL PROTECTED] If you do a dma_map_single you must do dma_unmap_single and if you do a dma_map_page you must do a dma_unmap_page. Signed-off-by: Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 51

[Patch 05/13] mv643xx_eth: Add multicast support

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This code is adapted from code in a ppc-specific version of the driver. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 201 -- 1 file changed, 197 insertions(+), 4 deletions(-)

[Patch 06/13] mv643xx_eth: Receive buffers require 8 byte alignment

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] The Marvell mv643xx ethernet hardware requires that DMA buffers be aligned to 8-byte boundaries. This patch satisfies this requirement. Buffers allocated by dev_alloc_skb() only have 4-byte alignment when slab debugging is enabled. Also, document that the

[Patch 07/13] mv643xx_eth: Fix handling of small, unaligned fragments

2006-01-16 Thread Dale Farnsworth
From: Paul Janzen [EMAIL PROTECTED] Fix handling of small, unaligned fragments. It also solves a potential deadlock if skb_linearize() returns -ENOMEM. Signed-off-by: Paul Janzen [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 54

[Patch 08/13] mv643xx_eth: iounmap the correct SRAM buffer

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c === ---

[Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This driver has historically held a spin_lock during the entire open and stop functions and while receiving multiple packets. This is unecessarily long and holds locks during calls that may sleep. This patch reduces the size of windows where locks are

[Patch 10/13] mv643xx_eth: Request HW checksum generation only for IPv4

2006-01-16 Thread Dale Farnsworth
From: Wolfram Joost [EMAIL PROTECTED] This patch removes the NETIF_F_HW_CSUM flag to be able to use other protocols than IPv4. Hardware checksums for IPv4 should continue to work because NETIF_F_IP_CSUM is still set. The sanity-check has been enhanced to check the used protocol and to not access

[Patch 11/13] mv643xx_eth: Fix transmit skb accounting

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c === ---

[Patch 12/13] mv643xx_eth: Merge open and stop helper functions

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Move code from helper functions mv643xx_eth_real_open and mv643xx_eth_real_stop as they are no longer needed. Signed-off-by Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 109 +++--- 1 file changed,

[Patch 13/13] mv643xx_eth: Remove needless mask of extended intr register

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] All interrupts controlled by the extended mask register are also masked by a bit in the main mask register, so there is no need to directly manipulate the extended mask register. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 81

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize

2006-01-16 Thread Herbert Xu
On Mon, Jan 16, 2006 at 06:10:53PM -0500, cxzhang wrote: This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no authorization (besides the check for write permissions to SAD and SPD) is required to

[PATCH] tg3: Refine nvram locking

2006-01-16 Thread Michael Chan
Add nvram lock count so that calls to tg3_nvram_lock()/unlock() can be nested. Add error checking to all callers of tg3_nvram_lock() where appropriate. To prevent nvram lock failures after halting the firmware, it is also necessary to release firmware's nvram lock in tg3_halt_cpu(). Update

Re: [PATCH 3/4 -2.6.15]:x25: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-16 Thread Arnd Bergmann
Am Dienstag, 17. Januar 2006 00:12 schrieb Shaun Pereira: +static int compat_x25_subscr_ioctl(unsigned int cmd, + struct compat_x25_subscrip_struct __user *x25_subscr32) +{ + struct x25_subscrip_struct x25_subscr; + struct x25_neigh *nb; + struct net_device

Pull request for wireless-2.6

2006-01-16 Thread John W. Linville
The following changes since commit 4a8e4a270b89030bdeb09d2f8cef7cfe9a50e54d: Linus Torvalds: Merge git://oss.sgi.com:8090/oss/git/xfs-2.6 are found in the git repository at: git://git.tuxdriver.com/git/wireless-2.6.git Adrian Bunk: ipw2100: remove code for WIRELESS_EXT 18

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-16 Thread Graham Gower
On 17/01/06, John W. Linville [EMAIL PROTECTED] wrote: On Wed, Jan 04, 2006 at 09:33:27AM +1030, Graham Gower wrote: On 03/01/06, Patrick McHardy [EMAIL PROTECTED] wrote: Graham Gower wrote: My logs were starting to fill with messages exatcly like that mentioned here:

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 16 Jan 2006 17:33:59 -0500), Andy Gospodarek [EMAIL PROTECTED] says: On 1/16/06, Jesper Juhl [EMAIL PROTECTED] wrote: Maybe if you described your current problem someone could suggest a solution... Sure, I'd be glad to. If I add up all the

Re: Pull request for wireless-2.6

2006-01-16 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 4a8e4a270b89030bdeb09d2f8cef7cfe9a50e54d: Linus Torvalds: Merge git://oss.sgi.com:8090/oss/git/xfs-2.6 are found in the git repository at: git://git.tuxdriver.com/git/wireless-2.6.git Is it on a branch? [EMAIL PROTECTED]

Re: State of the Union: Wireless

2006-01-16 Thread Jouni Malinen
On Wed, Jan 11, 2006 at 07:25:11PM +0100, Krzysztof Halasa wrote: 3. To have a master device which isn't represented by a network device (ifconfig doesn't show it etc.) but can be accessed only by the wireless tools. Or just using sysfs, echo and cat can be best tools. The slaves (netdevs) can

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize

2006-01-16 Thread James Morris
On Mon, 16 Jan 2006, cxzhang wrote: +++ linux-2.6.15-mm3-cxzhang/net/key/af_key.c2006-01-13 18:41:02.0 -0500 @@ -1454,6 +1454,9 @@ static int pfkey_delete(struct sock *sk, if (x == NULL) return -ESRCH; +if ((err = security_xfrm_state_delete(x))) +

Re: linux networking kernel layer and STREAMS

2006-01-16 Thread David S. Miller
From: Willem de Bruijn [EMAIL PROTECTED] Date: Mon, 16 Jan 2006 09:21:18 +0100 true, it's not new. The reason I ended up with it was purely practical and even grew out of a single-module system. Streams fitted our use-case, which is to run code in userspace, kernelspace and on the