On Tue, Jan 02, 2007 at 08:39:09AM +0100, Jarek Poplawski wrote:
...
It is hard to say what kind of bug to expect
because at the same time other net_rx_action
with the same vlan dev could take place on
other processor and this inetdev_init could
do more.
Sorry! inetdev_init couldn't do more
From: Horms [EMAIL PROTECTED]
Date: Mon, 18 Dec 2006 12:11:11 +0900
I guess that this code used to be more complex, but replacing
the goto with a while seems to make things a bit more readable.
Or in other words, two fairly gratuitous goto are removed.
On a related note, I wonder if there
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Tue, 19 Dec 2006 18:57:33 +0300
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Applied, thanks Alexey.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Adrian Bunk [EMAIL PROTECTED]
Date: Mon, 18 Dec 2006 04:46:26 +0100
This patch adds proper prototypes for some functions in
include/net/irda/irda.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
...
+struct net_device;
+struct packet_type;
+
+void irda_proc_register(void);
+void
On Tue, Jan 02, 2007 at 09:23:02AM +0100, Jarek Poplawski wrote:
On Tue, Jan 02, 2007 at 08:39:09AM +0100, Jarek Poplawski wrote:
...
The main thing is the possibility of processing
skb with not entirely open source dev which isn't
expected (and checked) by receive functions.
I think the
On 02-01-2007 08:51, David Miller wrote:
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 00:55:51 +0100
On error we should start freeing resources at [i-1] not [i-2].
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
Patch applied, thanks Mariusz.
diff -upr
Hello David,
One could argue from a defensive programming perspective that
this bug comes from the fact that the ifb_init_one() loop
advances state before checking for errors ('i' is advanced before
the 'err' check due to the loop construct), and that's why the
error recovery code had to be
On Tue, Jan 02, 2007 at 12:39:53AM -0800, David Miller wrote:
From: Adrian Bunk [EMAIL PROTECTED]
Date: Mon, 18 Dec 2006 04:46:26 +0100
This patch adds proper prototypes for some functions in
include/net/irda/irda.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
...
+struct
Hello,
This patch removes redundant argument check for module_put().
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
net/netlink/af_netlink.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -upr linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c
On 1/1/07, Jan Kiszka [EMAIL PROTECTED] wrote:
Hacking a bit on rt2x00 to make it work in master and ad-hoc mode, lockdep
popped up on some hostapd ioctls, pointing out remaining inconsistencies
related to sta_lock:
1. sta_lock holders must always be protected against softirq
2.
On 1/1/07, Jan Kiszka [EMAIL PROTECTED] wrote:
Switching the interface mode with some encryption keys set and then later
touching any key, triggers an oops because ieee80211_if_reinit fails to
NULL'ify the related pointers after free'ing the key on mode change. Long
explanation, simple fix
Same problem with 2.6.19-rc3.
Apologies for the long spiel, if memory serves me correct, gzip'd
attachments are verboten.
openSUSE 10.2
Network does not get configured with acpi=noirq or acpi=off.
There may be something in dmesg that allows further analysis of the
problem.
00:0a:e4:4e:a1:42
The best way to achieve such balancing is to have the network card help
and essentially be able to select the CPU to notify while at the same
time considering:
a) avoiding any packet reordering - which restricts a flow to be
processed to a single CPU at least within a timeframe
b) be
With NAPI, if i have a few interupts it likely implies i have a huge
network load (and therefore CPU use) and would be much more happier if
you didnt start moving more interupt load to that already loaded CPU
current irqbalance accounts for napi by using the number of packets as
indicator
On Tue, 26 Dec 2006 16:44:24 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Patches are in order of severity. 1-3 are bug fixes, 4 is a cleanup
of the power state code, and 5 adds wake on lan support.
IMHO, it is bad security policy to allow wake on lan to enabled
On Mon, Jan 01, 2007 at 10:36:44 -0800, Stephen Hemminger wrote:
On Tue, 26 Dec 2006 16:44:24 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Patches are in order of severity. 1-3 are bug fixes, 4 is a cleanup
of the power state code, and 5 adds wake on lan support.
On Tuesday 02 January 2007 10:41, Sid Boyce wrote:
Same problem with 2.6.19-rc3.
Do you mean 2.6.20-rc3 still does not work?
What was the last kernel that worked properly with no cmdline parameters?
Apologies for the long spiel, if memory serves me correct, gzip'd
attachments are verboten.
* Andrew Morton [EMAIL PROTECTED] wrote:
There's a glaring bug in selinux_netlbl_inode_permission() - taking
lock_sock() inside rcu_read_lock().
Note that the bug is still in -rc3, and is easily triggerable via a
default FC6 bootup. It's fixed by the (slightly modified) patch from
Parag
IMHO, it is bad security policy to allow wake on lan to enabled by
default. The sky2 driver doesn't do WOL until enabled with ethtool.
While in general I agree with you on the security principle, this seems
like it might break working setups.
WOL is a partnership between the
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 15:39:06 +0100
All -doit handlers want a struct rtattr **, so pass down the right
type.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
This code was just trying to mirror the typing used by
struct rtnetlink_link's -doit()
I've looked at this a little too -- it'd be nice to know who holds
the write lock.
I see ip_mc_destroy_dev() is bouncing through the lock for
each multicast address, though it starts at the beginning of
the list each time. I don't see a problem with it, but it'd be
simpler if it acquired the
David Stevens wrote:
I've looked at this a little too -- it'd be nice to know who holds
the write lock.
I see ip_mc_destroy_dev() is bouncing through the lock for
each multicast address, though it starts at the beginning of
the list each time. I don't see a problem with it, but it'd be
simpler
From: Adrian Bunk [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 13:45:57 +0100
On Tue, Jan 02, 2007 at 12:39:53AM -0800, David Miller wrote:
I don't like it, even if it's correct, because it is inconsistent
with what we do in the entire rest of the networking code.
Good point.
Is it OK to
On Sunday, December 24 2006 7:25 pm, Andrew Morton wrote:
On Mon, 25 Dec 2006 05:21:24 +0800
Adam J. Richter [EMAIL PROTECTED] wrote:
Under 2.6.20-rc1 and 2.6.20-rc2, I get the following complaint
for several network programs running on my system:
[ 156.381868] BUG: sleeping
On Tuesday, January 2 2007 2:58 am, Adam J. Richter wrote:
I have not yet performed the 21 steps of
linux-2.6.20-rc3/Documentation/SubmitChecklist, which I think is a
great objectives list for future automation or some kind of community
web site. I hope to find time to make progress
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 11:49:42 +0100
Hello David,
One could argue from a defensive programming perspective that
this bug comes from the fact that the ifb_init_one() loop
advances state before checking for errors ('i' is advanced before
the
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 13:47:37 +0100
Hello,
This patch removes redundant argument check for module_put().
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev
From: Paul Moore [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 16:25:24 -0500
I'm sorry I just saw this mail (mail not sent directly to me get
shuffled off to a folder). I agree with your patch, I think
dropping and then re-taking the RCU lock is the best way to go,
although I'm curious to see
02.01.2007 22:57, Adrian Bunk wrote/a écrit:
This patch contains the scheduled removal of the eepro100 driver.
Hi, I've been using e100 for years with no problem, however more by
curiosity than necessity I'd like to know how will be handled the
devices which are (supposedly) supported by
On Wed, Dec 27, 2006 at 07:10:57PM -0500, John W. Linville wrote:
On Tue, Dec 26, 2006 at 04:39:38PM -0500, Jeff Garzik wrote:
John W. Linville wrote:
The following changes since commit
0c234ae655a45ac3ee53a25b2e56e9bb6c27d71d:
Ulrich Kunitz (1):
ieee80211softmac: Fix
The following changes since commit 669df1b478803f49a356528d290af7bf442eb3be:
Linus Torvalds (1):
Linux 2.6.20-rc3
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream-fixes
Zhu Yi (2):
ieee80211: WLAN_GET_SEQ_SEQ
The following changes since commit fe5f8e2a1c5c040209c598a28e19c55f30e1040d:
Zhu Yi (1):
ipw2100: Fix dropping fragmented small packet problem
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream
Daniel Drake (5):
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm
This patch adds support for a few more PHYs used by Apple and fixes
advertising and detecting of Pause (we were missing setting the bit in
MII_ADVERTISE and weren't testing in LPA for all PHYs). I only do it for
gigabit capable PHYs for now.
Note that I currently only advertise pause, not
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Wed, 03 Jan 2007 15:58:05 +1100
This patch adds support for a few more PHYs used by Apple and fixes
advertising and detecting of Pause (we were missing setting the bit in
MII_ADVERTISE and weren't testing in LPA for all PHYs). I only do it
Thanks for finding these bugs, although that's really strange pause
behavior you are seeing on your switches.
By default, we advertise PAUSE but not ASYM PAUSE in the tg3 driver,
and I get flow control on every switch I have here.
Yeah, that's strange. I still have the debug values at
From: Benjamin Herrenschmidt [EMAIL PROTECTED]
Date: Wed, 03 Jan 2007 16:20:14 +1100
Now, I cross-over with a TG3 and I get:
- I advertise 0x5e1 (hopefully same value)
- I read in LPA 0xc5e1 from the TG3
(and that other register tells me Rx and Tx pause can be enabled).
Does flow control
This patch adds support for a few more PHYs used by Apple and fixes
advertising and detecting of Pause (we were missing setting the bit in
MII_ADVERTISE and weren't testing in LPA for all PHYs).
Note that I currently only advertise pause, not asymetric pause. I don't
know for sure the details
subscribe netdev
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The one with only asym. support is a big Cisco Catalyst 3350 (well.. big
but not that many ports :-)
Ok, I got in the config of the switch with somebody who knows how to
speak ciscong, and it seems that it defaults to flow control desired
for send and off for receive on all ports, which means
..same problem with 2.6.20-rc3. Last worked with
2.6.19-rc6-git12, so it was 2.6.19 where it failed.
Attaching both case1 normal, case2 acpi=noirq. With acpi=noirq ethernet
doesn't get configured, route -n says it's an Unsupported operation,
ifconfig only shows for localhost, ifconfig
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
with patches available
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any
42 matches
Mail list logo
