Re: [patch 1/4] network dev read_mostly

2007-03-15 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 15 Mar 2007 07:28:35 +0100 One problem with your patch is that all read_always() of pointers are going to use 3 bytes more of code, thus raising icache pressure. 48 b8 c3 08 e8 8c afmov$0x71af8ce808c3,%rax 71 00 00 instead of

Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace: [810956e9]

Re: [patch 1/4] network dev read_mostly

2007-03-15 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 15 Mar 2007 07:28:35 +0100 One problem with your patch is that all read_always() of pointers are going to use 3 bytes more of code, thus raising icache pressure. 48 b8 c3 08 e8 8c afmov$0x71af8ce808c3,%rax 71 00

Re: fib_hash removal

2007-03-15 Thread Patrick McHardy
Jarek Poplawski wrote: On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace:

[PATCH] NAT and requests to unrouted targets

2007-03-15 Thread Martin Schiller
This patch changes the behaivor of the iptables nat module to the style before release 2.6.16 so it is possible again to use the ping -I iface target command to send icmp requests to a target for which no route exists. Signed-off-by: Martin Schiller [EMAIL PROTECTED]

Re: [PATCH] NAT and requests to unrouted targets

2007-03-15 Thread Patrick McHardy
Martin Schiller wrote: This patch changes the behaivor of the iptables nat module to the style before release 2.6.16 so it is possible again to use the ping -I iface target command to send icmp requests to a target for which no route exists. Please attach patches inline and send netfilter

Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On Thu, Mar 15, 2007 at 08:43:59AM +0100, Patrick McHardy wrote: ... On 14-03-2007 23:49, Patrick McHardy wrote: ... BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 ... Yes, Robert already sent me a patch to remove the bogus

Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On Thu, Mar 15, 2007 at 10:15:44AM +0100, Jarek Poplawski wrote: ... BTW: it seems fib_tree wasn't used too much, so probably, before killing fib_hash, fib_tree should be made Kconfig default for some time. Sorry! Let fib_tree stay out of Kconfig and make fib_trie the default. Jarek P. - To

Re: [PATCH] tcp_mem initialization

2007-03-15 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 17:25:22 -0400 The current tcp_mem initialization gives values that are really too small for systems with ~256-768 MB of memory, and also for systems with larger page sizes (ia64). This patch gives an alternate method of

Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 16:07:11 +0300 ANK says: It is rarely used, that's wy it was not noticed. But in the places, where it is used, it should be disaster. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Applied. What bug triggered that helped you

[IPROUTE] compilation problem

2007-03-15 Thread Nadia Derbey
Hi, Trying to compile iproute2 (downloaded from http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.20-070313.tar.gz) I get the following error message. gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall -I../include -DRESOLVE_HOSTNAMES -DCONFIG_GACT -DCONFIG_GACT_PROB -c -o m_ipt.o

Re: [patch 1/4] network dev read_mostly

2007-03-15 Thread Benjamin LaHaise
On Thu, Mar 15, 2007 at 12:25:16AM -0700, David Miller wrote: Could we obtain %rip relative addressing with the ELF relocation approach I mentioned? I think we can for some of the objects -- things like slab caches are good candidates if we have the initialization done at init time, which

IPsec with aes-cbc and geode-aes driver completely freezes 2.6.20.1

2007-03-15 Thread Joerg Pommnitz
Hello all, the subject line basically says it all. I was trying to offload IPsec encryption to the hardware encryption engine on my Geode LX800. The exact same setkey command works fine with software aes. In case it matters: this is with a MSEP800/A board from DIGITAL-LOGIC AG (see

Re: [patch 1/4] network dev read_mostly

2007-03-15 Thread Andi Kleen
Benjamin LaHaise [EMAIL PROTECTED] writes: On Mon, Mar 12, 2007 at 02:08:18PM -0700, Stephen Hemminger wrote: For Eric, mark packet type and network device watermarks as read mostly. The following x86-64 bits might be intersting, as they allow you to completely eliminate the memory

Re: IPsec with aes-cbc and geode-aes driver completely freezes 2.6.20.1

2007-03-15 Thread Evgeniy Polyakov
On Thu, Mar 15, 2007 at 06:45:33AM -0700, Joerg Pommnitz ([EMAIL PROTECTED]) wrote: Hello all, the subject line basically says it all. I was trying to offload IPsec encryption to the hardware encryption engine on my Geode LX800. The exact same setkey command works fine with software aes.

Re: IPsec with aes-cbc and geode-aes driver completely freezes 2.6.20.1

2007-03-15 Thread Evgeniy Polyakov
On Thu, Mar 15, 2007 at 05:15:06PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: On Thu, Mar 15, 2007 at 06:45:33AM -0700, Joerg Pommnitz ([EMAIL PROTECTED]) wrote: Hello all, the subject line basically says it all. I was trying to offload IPsec encryption to the hardware

Re: [PATCH] skge: set mac address bonding fix

2007-03-15 Thread Jeff Garzik
Stephen Hemminger wrote: When bonding does fail over it calls set_mac_address. When this happens as the result of another port going down, the phy_mutex that is common to both ports is held, so it deadlocks. Setting the address doesn't need to do anything that needs the phy_mutex, it already

RE: [PATCH] NAT and requests to unrouted targets

2007-03-15 Thread Martin Schiller
On Thursday, March 15, 2007 9:51 AM, Patrick McHardy wrote: diff -uNpr linux-2.6.19.org/net/ipv4/netfilter/ip_nat_standalone.c linux-2.6.19/net/ipv4/netfilter/ip_nat_standalone.c --- linux-2.6.19.org/net/ipv4/netfilter/ip_nat_standalone.c 2006-11-29 22:57:37.0 +0100 +++

Re: [PATCH 1/2] NetXen: Bug fix for Jumbo frames on XG card

2007-03-15 Thread Jeff Garzik
Linsys Contractor Mithlesh Thukral wrote: NetXen: Set the MTU for the right port depending upon the port number for XG cards. Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic_hw.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) applied 1-2 to

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-15 Thread Jeff Garzik
Atsushi Nemoto wrote: The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. applied to

Re: [PATCH] tc35815: Zap changelog from source code

2007-03-15 Thread Jeff Garzik
Atsushi Nemoto wrote: Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] applied to #upstream - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Tehuti Networks 10GbE Support

2007-03-15 Thread Jeff Garzik
Andy Gospodarek wrote: This patch adds support for 10GbE cards from Tehuti Networks. Support for suspend/resume isn't included yet, but that work is underway. It should apply cleanly against netdev-2.6#upstream. Signed-off-by: Andy Gospodarek [EMAIL PROTECTED] Signed-off-by: Alexander

Re: [patch 1/6] [TULIP] From: Jim Gifford [EMAIL PROTECTED], Grant Grundler [EMAIL PROTECTED], Peter Horton [EMAIL PROTECTED]

2007-03-15 Thread Jeff Garzik
Valerie Henson wrote: With Grant's help I was able to get the tulip driver to work with 64 bit MIPS. [VAL: I'm happy with the 1.5 ms max delay; it doesn't seem excessive.] Signed-off-by: Valerie Henson [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL

Re: [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx

2007-03-15 Thread Jeff Garzik
Valerie Henson wrote: Only print out debugging info for tulip_stop_rxtx if debug is on. Many cards (including at least two of my own) fail to stop properly during initialization according to this test with no apparent ill effects. Worse, it tends to spam logs when the driver doesn't work.

Re: [patch 5/6] [TULIP] Fix SytemError typo

2007-03-15 Thread Jeff Garzik
Valerie Henson wrote: Fix an annoying typo - SytemError - SystemError Signed-off-by: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/tulip/interrupt.c |4 ++-- drivers/net/tulip/tulip.h |2 +- drivers/net/tulip/winbond-840.c |2 +- 3

Re: ping DOS avoidance?

2007-03-15 Thread Rick Jones
I was just asked about something not too different, involving IIRC tnsping. It got me to looking at ip_sysctl.txt which has: icmp_ratelimit - INTEGER Limit the maximal rates for sending ICMP packets whose type matches icmp_ratemask (see below) to specific targets. 0 to

Re: [RFC] [PATCH] Network Events Connector

2007-03-15 Thread Evgeniy Polyakov
On Thu, Mar 15, 2007 at 02:05:53AM +0100, Samir Bellabes ([EMAIL PROTECTED]) wrote: Hi, Hi Samir. My comments are below. here a updated patch for the network events connector. review are welcome :) Thanks. [PATCH] Network Events Connector This patch adds a connector which reports

Re: [PATCH] tcp_mem initialization

2007-03-15 Thread John Heffner
David Miller wrote: From: John Heffner [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 17:25:22 -0400 The current tcp_mem initialization gives values that are really too small for systems with ~256-768 MB of memory, and also for systems with larger page sizes (ia64). This patch gives an alternate

Re: [PATCH 0/6] IrDA: Updates

2007-03-15 Thread Samuel Ortiz
On Thu, Mar 15, 2007 at 03:00:54AM -0700, David Miller wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 21:22:36 +0200 Some IrDA updates: - IrNET identation and bug fix. (patches 1 and 2) - IrLAP raw mode initial implementation. (patch 3) - stir4200 and irda-usb

Re: [PATCH 0/6] IrDA: Updates

2007-03-15 Thread David Miller
From: Samuel Ortiz [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 01:06:26 +0200 On Thu, Mar 15, 2007 at 03:00:54AM -0700, David Miller wrote: Please properly segregate things in the future and make sure that you submit bug fixes against net-2.6 and features against the net-2.6.22 tree. I will

[PATCHES 0/2] probably the last pre-offsetization patches

2007-03-15 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 Thanks, - Arnaldo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/2] [KBUILD]: Unifdef headers changed by the skb layer header refactorings

2007-03-15 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/Kbuild |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) From 23f9426c51157bf65d92d38b4d0bf4364c278877 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Thu, 15 Mar 2007 21:08:55

[PATCH 2/2] [SK_BUFF]: Some more layer header conversions

2007-03-15 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/core/pktgen.c | 30 ++ net/core/skbuff.c |2 +- net/ipv4/ipmr.c |3 ++- net/ipv6/xfrm6_mode_beet.c |3 ++- net/ipv6/xfrm6_mode_ro.c|

Re: [PATCH] NAT and requests to unrouted targets

2007-03-15 Thread Patrick McHardy
Martin Schiller wrote: Well, the really responsible code is the following: static unsigned int ip_nat_local_fn(unsigned int hooknum, struct sk_buff **pskb, const struct net_device *in,

[NET_SCHED 00/10]: ktime clocksource + hrtimer

2007-03-15 Thread Patrick McHardy
These patches convert the packet schedulers to use ktime as only clock source and kill off the manual clock source selection. Additionally all packet schedulers are converted to use hrtimer-based watchdogs, greatly increasing scheduling precision. I've tested HFSC, HTB, TBF and netem. CBQ is

[NET_SCHED 01/10]: Use ktime as clocksource

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: Use ktime as clocksource Get rid of the manual clock source selection mess and use ktime. Also use a scalar representation, which allows to clean up pkt_sched.h a bit more and results in less ktime_to_ns() calls in most cases. The PSCHED_US2JIFFIE/PSCHED_JIFFIE2US macros are

[NET_SCHED 06/10]: sch_cbq: use hrtimer based watchdog

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: sch_cbq: use hrtimer based watchdog Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit dc1a944b36eeddc06e7288a2eec9344252d4ccb7 tree c0bd33b0ada4fbda631c246f7fe5881cf830e932 parent b0b8ce02c1564f86f09a0ccb728327d02cf202f0 author Patrick McHardy [EMAIL PROTECTED] Fri, 16 Mar

[NET_SCHED 05/10]: sch_netem: use hrtimer based watchdog

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: sch_netem: use hrtimer based watchdog Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit b0b8ce02c1564f86f09a0ccb728327d02cf202f0 tree 54ac4c91460fa9b34542dfc5dcbd9a796b037950 parent 7acf6ee9c08fdbf5cb24b15d95432eef07506a38 author Patrick McHardy [EMAIL PROTECTED] Fri, 16

[NET_SCHED 03/10]: sch_hfsc: use hrtimer based watchdog

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: sch_hfsc: use hrtimer based watchdog Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 76728bda8872d54abd39cdc47d703384f735f7ea tree 3563cceb7028b40160616835ef29bcef2523a0fb parent 4d0baa5c06cb04a53d8c68ecc10f38a295f08d14 author Patrick McHardy [EMAIL PROTECTED] Fri, 16

[NET_SCHED 07/10]: sch_cbq: fix cbq_undelay_prio for non-active priorites

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: sch_cbq: fix cbq_undelay_prio for non-active priorites cbq_undelay_prio is supposed to return a time delta, but returns the current time for non-active priorities, causing cbq_undelay to mark the priority as active and schedule a timer for twice the current time. Signed-off-by:

[NET_SCHED 10/10]: kill jiffie conversion macros

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: kill jiffie conversion macros Now that all packet schedulers have been converted to hrtimers most users of PSCHED_JIFFIE2US and PSCHED_US2JIFFIE are gone. The remaining users use it to convert external time units to packet scheduler clock ticks, so use PSCHED_TICKS_PER_SEC instead.

[NET_SCHED 09/10]: sch_htb: use hrtimer based watchdog

2007-03-15 Thread Patrick McHardy
[NET_SCHED]: sch_htb: use hrtimer based watchdog Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit a5eaa252c5da48fef25a308ebc99b4020dad7f64 tree a609ff508f5ec9a93df1ace8f814aa0a71a5ff97 parent 2d548d3ea10cb1b49db8913fbab32811d9e7c3d0 author Patrick McHardy [EMAIL PROTECTED] Fri, 16 Mar

Re: [PATCHES 0/2] probably the last pre-offsetization patches

2007-03-15 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 00:04:22 -0300 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 Pulled, thanks a lot. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] tcp_mem initialization

2007-03-15 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Thu, 15 Mar 2007 14:39:29 -0400 The way it's coded is somewhat opaque since it has to be done with 32-bit integer arithmetic. These plots might help make the motivation behind the code a little clearer. Thanks John. I was going to write a little

Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread Alexey Kuznetsov
Hello! What bug triggered that helped you discover this? Or is it merely from a code audit? I asked the same question. :-) openvz added some another fields to skbuff and when it was found that they are lost while clone, he tried to figure out how all this works and looked for another

Re: [Devel] Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread David Miller
From: Kirill Korotaev [EMAIL PROTECTED] Date: Thu, 15 Mar 2007 13:33:12 +0300 David Miller wrote: From: Alexey Dobriyan [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 16:07:11 +0300 ANK says: It is rarely used, that's wy it was not noticed. But in the places, where it is used, it should be

Re: [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC

2007-03-15 Thread Mikael Pettersson
Valerie Henson writes: From: Guido Classen [EMAIL PROTECTED] This small patch fixes two issues with the Lite-On 82c168 PNIC adapters. I've tested it with two cards in different machines both chip rev 17 The first is the wrong register address CSR6 for writing the MII register which

Re: [patch 1/3] natsemi: Consistently use interrupt enable/disable functions

2007-03-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: The natsemi drivers include functions for enabling and disabling interrupts from the chip but these are not used in all code paths. This patch changes the code paths that touch the interrupt enable register to use the functions. In all cases this adds an extra PCI read

Re: MediaGX/GeodeGX1 requires X86_OOSTORE.

2007-03-15 Thread Lennart Sorensen
On Thu, Mar 15, 2007 at 02:39:39PM +0900, takada wrote: Hiroshi Miura posted `Geode out-of-order store enables' patch in Jun, 2003. There is http://lkml.org/lkml/2003/6/5/57 . OOSTORE was enabled at this point in time. It seems to have disappeared somewhere. I believe the patch was rejected

[git patches] net driver fixes

2007-03-15 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/natsemi.c | 58 -- drivers/net/netxen/netxen_nic.h |1 +