On Fri, Oct 19, 2007 at 09:50:14AM +0200, Jarek Poplawski wrote:
On Thu, Oct 18, 2007 at 07:48:19PM +0400, Oleg Nesterov wrote:
On 10/18, Jarek Poplawski wrote:
+/**
+ * flush_work_sync - block until a work_struct's callback has terminated
Hi,
When kernel receives a package with a wrong destination ipv4 address, it can't
increase InAddrErrors number correctly.
InAddrErrors is located in /proc/net/snmp.
This is a patch for fixing this problem.
Signed-off-by: Gui Jianfeng [EMAIL PROTECTED]
---
diff -Narup
From: Gui Jianfeng [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 14:07:07 +0800
When kernel receives a package with a wrong destination ipv4 address, it
can't increase InAddrErrors number correctly.
InAddrErrors is located in /proc/net/snmp.
This is a patch for fixing this problem.
Gui Jianfeng wrote on 10/22/2007 11:37:07 AM:
@@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s
* how the packet travels inside Linux networking.
*/
if (skb-dst == NULL) {
- if (ip_route_input(skb, iph-daddr, iph-saddr, iph-tos, dev))
- goto drop;
+
This patch introduces statistics about transformation error (or almost error)
factor at packet processing for developer.
It is not a SNMP/MIB specification from IPsec/MIPv6 but a counter
designed from current transformation source code.
Comment please.
-
To unsubscribe from this list: send the
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
net/ipv6/ah6.c |1 +
net/ipv6/esp6.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c
index 67cd066..66a9139 100644
--- a/net/ipv6/ah6.c
+++ b/net/ipv6/ah6.c
@@ -483,6 +483,7 @@
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
net/ipv4/xfrm4_input.c | 48 +++-
net/ipv4/xfrm4_output.c |4 ++-
net/ipv6/xfrm6_input.c | 56 --
net/ipv6/xfrm6_output.c |4 ++-
net/xfrm/xfrm_output.c |
This statistics is shown as /proc/net/xfrm_stat about transformation
error (or almost error) factor at packet processing for developer.
It is not a SNMP/MIB specification but a counter designed from
current transformation source code.
- Inbound errors
XfrmInError - all errors which
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
net/xfrm/Kconfig | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 577a4f8..6b5b50f 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -35,6 +35,16 @@ config
Krishna Kumar2 写道:
Gui Jianfeng wrote on 10/22/2007 11:37:07 AM:
@@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s
* how the packet travels inside Linux networking.
*/
if (skb-dst == NULL) {
- if (ip_route_input(skb, iph-daddr, iph-saddr, iph-tos, dev))
-
On Friday 19 October 2007 17:25:49 Herbert Xu wrote:
Joakim Koskela [EMAIL PROTECTED] wrote:
I'm not sure I follow. This affects the ipv6 bundling only where the
struct (fl_tunnel) has previously been used for ipv6 addresses. Not that
we are using the same block for holding the ipv4 info,
On Friday 19 October 2007 17:22:22 Herbert Xu wrote:
Please hold onto this. I've got a more generic version of this
that doesn't duplicate the inter-family logic between BEET mode
and tunnel mode.
Instead I've created a generic function that reads info from the
inner header and puts them
Krishna Kumar2 写道:
Gui Jianfeng wrote on 10/22/2007 11:37:07 AM:
@@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s
* how the packet travels inside Linux networking.
*/
if (skb-dst == NULL) {
- if (ip_route_input(skb, iph-daddr, iph-saddr, iph-tos, dev))
-
From: Gui Jianfeng [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 15:10:46 +0800
sorry for my careless, here is the correct one
Signed-off-by: Gui Jianfeng [EMAIL PROTECTED]
BTW, I would also like to say that I think a statistics correction is
totally inappropriate for the 2.4.x kernel series
On Sun, 21 Oct 2007 22:15:24 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
Sure. But the language defines that the types in question
must be 64-bit aligned, so it is legal for the compiler to
emit this code.
It's not a GCC bug.
I've confirmed this behaviour on the AVR32 arch, and
On Fri, Oct 19, 2007 at 11:55:38PM +0200, Ursula Braun wrote:
--
Remove qeth driver bug introduced by this commit:
commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
Author: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue Oct 9 01:40:57 2007 -0700
[NET]: Move hardware header operations
Hi Dave,
these are the Bluetooth patches for the 2.6.24 kernel release. Please
pull and send them to Linus.
one of the cleanup patches slipped through the net. If you already
pulled my tree, then please re-pull. I pushed it on top of it.
I think I got it all, thanks.
Please get
From: Pierre Ossman [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 09:23:50 +0200
As for other instances of unaligned accesses, is there any active
work on getting rid of those? And would you accept more patches for
fixing them? (Code complexity being the downside)
On fast paths we aren't going to
On Mon, Oct 22, 2007 at 03:09:34PM +0900, Masahide NAKAMURA wrote:
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
Thanks for catching my silly bug!
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page:
On Mon, Oct 22, 2007 at 03:11:06PM +0900, Masahide NAKAMURA wrote:
This patch introduces statistics about transformation error (or almost error)
factor at packet processing for developer.
It is not a SNMP/MIB specification from IPsec/MIPv6 but a counter
designed from current transformation
On Mon, Oct 22, 2007 at 09:55:53AM +0300, Joakim Koskela wrote:
Hi, and thanks for the feedback. True, this one affects only one level of
inter-family, and supporting more would require a lot more changes in the
bundle creation (perhaps combining both versions and taking better into
On Mon, Oct 22, 2007 at 09:59:02AM +0300, Joakim Koskela wrote:
Ok, this really sounds like a good development. Do you think it could make it
in time for 2.6.24?
Sorry, I think it's 2.6.25 material.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL
Monday 22 October 2007 17:50, Herbert Xu wrote:
On Mon, Oct 22, 2007 at 03:11:06PM +0900, Masahide NAKAMURA wrote:
This patch introduces statistics about transformation error (or almost
error)
factor at packet processing for developer.
It is not a SNMP/MIB specification from IPsec/MIPv6
From: Pierre Ossman [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 10:42:08 +0200
This seems like a rather evil layering violation.
This has a 10+ year precedence and it's why the Linux networking stack
is so fast. If you read any other driver you would have seen the
skb_reserve() call every one of
On Mon, Oct 22, 2007 at 10:09:38AM +0800, wit ([EMAIL PROTECTED]) wrote:
But this does work until I add a ifcfg-eth0 in
sysconfig/network-script with the following content:
DEVICE=eth0
ONBOOT=yes
What is the relationship between these two files? And sometimes, I see
It depends on your
We have spent some time with the problem with Alexey and there are no
guesses for now.
Is it possible to name exact version of Network Manager and all
libraries related + provide us an output of strace with full buffers
send/received from netlink. Something like
strace -v -x -s 32768 nm
On Mon, 22 Oct 2007 02:05:38 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Pierre Ossman [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 10:42:08 +0200
This seems like a rather evil layering violation.
This has a 10+ year precedence and it's why the Linux networking stack
is so fast.
From: Herbert Xu [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 16:37:20 +0800
On Mon, Oct 22, 2007 at 03:09:34PM +0900, Masahide NAKAMURA wrote:
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
Thanks for catching my silly bug!
Applied, thanks!
-
To unsubscribe from this list: send the line
Pierre Ossman a écrit :
On Mon, 22 Oct 2007 02:05:38 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Pierre Ossman [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 10:42:08 +0200
This seems like a rather evil layering violation.
This has a 10+ year precedence and it's why the
Here is a patch for the ip_map caching code part in nfs server.
I have updated the code to use Brian
Haley's ipv6_addr_v4mapped function, and corrected pointed out mistakes.
So the first patch in attachment must be applied on a vanilla kernel
before.
In case of bad formatting due to my
Here is a second missing part of the IPv6 support in NFS server code
concerning knfd syscall interface.
It updates write_getfd and write_getfd to accept IPv6 addresses.
I've updated it according to Brian's comments, and removed some unused code.
Applies on a kernel including ip_map cache
On Mon, 2007-22-10 at 15:11 +0900, Masahide NAKAMURA wrote:
This patch introduces statistics about transformation error (or almost error)
factor at packet processing for developer.
It is not a SNMP/MIB specification from IPsec/MIPv6 but a counter
designed from current transformation source
There are some pointers, that are used in protocols/drivers/etc
in this struct. E.g. br_port, macvlan_port, ec_ptr, etc. Some of
them can be simply compile out with ifdefs, some require a bit
closer look.
Here's the summary:
Compiled out in this set with appropriate ifdef:
* br_port
*
And add the forward declaration for br_handle_frame_hook in
include/linux/if_bridge.h
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
index 58e43e5..a718586 100644
--- a/include/linux/if_bridge.h
+++
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 469e04f..c41a5c4 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -703,8 +703,10 @@ struct net_device
/* bridge stuff */
struct
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index c41a5c4..504f843 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -580,7 +580,9 @@ struct net_device
void*dn_ptr;
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 504f843..472d9cc 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -579,7 +579,9 @@ struct net_device
void*ip_ptr;
And remove a BUG_TRAP from netdev_run_todo as well.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 472d9cc..e94c636 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -577,7 +577,9 @@ struct
On Mon, Oct 22, 2007 at 04:33:33PM +0400, Pavel Emelyanov wrote:
And add the forward declaration for br_handle_frame_hook in
include/linux/if_bridge.h
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -699,8 +699,10 @@ struct net_device
/* Network namespace this
Alexey Dobriyan wrote:
On Mon, Oct 22, 2007 at 04:33:33PM +0400, Pavel Emelyanov wrote:
And add the forward declaration for br_handle_frame_hook in
include/linux/if_bridge.h
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -699,8 +699,10 @@ struct net_device
/*
Hello David,
No piece of code in the kernel should live in a vacuum.
In order to improve overall code quality, every piece of
driver code should avoid assuming things about pointer
sizes and things of this nature.
I'm afraid we might be talking about orthogonal issues here. I actively
Then I got very, very lucky, since I have successfully rebooted
2.6.23.1-23.fc8 four times (zero panics) and this is the first time a
2.6.23 kernel has not panicked on me in months.
This does not fill me with confidence in the theory that the panics I've
been seeing are due to a race condition.
From: Ursula Braun [EMAIL PROTECTED]
Remove qeth bug caused by commit:
[NET]: Move hardware header operations out of netdevice.
This is the second part of the qeth header_ops patch, since
first patch sent 10/19 has been insufficient.
Nevertheless first patch is still valid and should be kept.
On 10/18/2007 01:59 PM, Kok, Auke wrote:
David Mack wrote:
It appears that the needed e100 fix made it into the Fedora
2.6.23.1-23.fc8 kernel. Boots reliably now.
Huge thanks and great work, guys.
DaveJ, I didn't push anything upstream. Can you verify this now works?
One of our users
On 10/15/07, Jay Vosburgh [EMAIL PROTECTED] wrote:
Jeff Garzik [EMAIL PROTECTED] wrote:
Jay Vosburgh wrote:
Convert bonding timers to workqueues. This converts the various
monitor functions to run in periodic work queues instead of timers. This
patch introduces the framework and
David Mack wrote:
Then I got very, very lucky, since I have successfully rebooted
2.6.23.1-23.fc8 four times (zero panics) and this is the first time a
2.6.23 kernel has not panicked on me in months.
This does not fill me with confidence in the theory that the panics I've
been seeing are
On Mon, 22 Oct 2007 04:14:57 -0700 (PDT) Matti Linnanvuori wrote:
From: Matti Linnanvuori [EMAIL PROTECTED]
Retina G.703 and G.SHDSL driver.
Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED]
---
Hi,
Just a few basic questions... I'm not reviewing any of the code parts.
Fixed Kconfig
thank you very much..
2007/10/22, Evgeniy Polyakov [EMAIL PROTECTED]:
On Mon, Oct 22, 2007 at 10:09:38AM +0800, wit ([EMAIL PROTECTED]) wrote:
But this does work until I add a ifcfg-eth0 in
sysconfig/network-script with the following content:
DEVICE=eth0
ONBOOT=yes
What is the
Nick wrote:
[ restoring CC ]
Fascinating ... Are you using chooser or NetInfo?
No I don't.
I fact I don't even know why that module got loaded.
On Mon, 2007-10-22 at 16:19 +0200, Gabriel C wrote:
Hi,
modprobing appletalk on current git gives a warning in dmesg :
[38506.600269] sysctl
Some are already declared in include/linux/netdevice.h, while
some others (xfrm ones) need to be declared.
The driver/net/rrunner.c just uses same extern as well, so
cleanup it also.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/drivers/net/rrunner.c
Inconsistent prototype and real type for functions may have
worse consequences, than those for variables, so move them
into a header.
Since they are used privately in net/core, make this file
reside in the same place.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git
Instead of ugly extern not-existing function.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/core/flow.c b/net/core/flow.c
index 0ab5234..3ed2b4b 100644
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -142,8 +142,6 @@ typedef u64 flow_compare_t;
typedef u32
On systems with noncoherent cache, allocating dma buffers
on the stack for USB IN transfers causes kernel crash,
because usb map_urb_for_dma() code calls dma_map_single(),
that invalidates data cache for DMA_FROM_DEVICE transfer direction
and causes stack data loss if transfer size is less than
In case the multiple tables config option is y, the ip_fib_local_table
is not a variable, but a macro, that calls fib_get_table(RT_TABLE_LOCAL).
Some code uses this variable *3* times in one place, thus implicitly
making 3 calls. Fix it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
We have spent some time with the problem with Alexey and there are no
guesses for now.
Is it possible to name exact version of Network Manager and all
libraries related + provide us an output of strace with full buffers
[annoyed as ever about never being cc:ed on this stuff]
On Wed, Oct 17, 2007 at 01:21:31PM -0700, Stephen Hemminger wrote:
The netpoll receive code is:
1. Not used by any in-tree features, it is used by kgdb-over-ether.
And various crashdump over network tools.
2. A nice hook for people
Michael Whyte wrote:
Hi Guys,
I'm currently writing my first bit of Linux kernel code so be gentle.
It's a driver for TI CC2420 802.15.4 radio and I'm observing strange
behavior. I am currently testing just by transferring a ~300kb file
over HTTP between two of these devices.
Into which
The dfx_bus_uninit() call is called from dfx_unregister() which is
__devexit and which is ultimately the -remove call for the device.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
It should be obvious. Please apply.
Maciej
patch-mips-2.6.23-rc5-20070904-defxx-devexit-0
diff -up
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
+ void *buf;
u16 res;
mutex_lock(dev-phy_mutex);
asix_set_sw_mii(dev);
+
+
On 10/22, Jarek Poplawski wrote:
On Fri, Oct 19, 2007 at 09:50:14AM +0200, Jarek Poplawski wrote:
On Thu, Oct 18, 2007 at 07:48:19PM +0400, Oleg Nesterov wrote:
On 10/18, Jarek Poplawski wrote:
+/**
+ * flush_work_sync - block until a work_struct's callback has
terminated
On Sun, Oct 21, 2007 at 04:21:31PM -0700, David Miller wrote:
From: Matt Carlson [EMAIL PROTECTED]
Date: Fri, 19 Oct 2007 14:36:56 -0700
This patch exports the pci_restore_msi_state() function. This function
is needed to restore the MSI state during PCI error recovery.
Signed-off-by:
On Mon, 22 Oct 2007 06:58:37 -0700 (PDT) [EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9208
Summary: Oops on sky2, delete_module causes SIGKILL
Product: Drivers
Version: 2.5
KernelVersion: linux-2.6.23-git17
Platform:
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:
On pseries there's a chance it will work for PCI error recovery, but if
so it's just lucky that firmware has left everything configured the same
way.
? The papr is quite clear that i is up to the OS to restore the msi
state
On Sun, Oct 21, 2007 at 09:45:20PM -0700, David Miller wrote:
The core issue is that the ARCH level MSI code invokes
write_msi_msg(), not the generic code, exactly because there
are platform level issues wherein the firmware is the only
legal way to write the MSI settings in PCI config
the temporary bf[127] char array is redundant, and the specified width 127 make
the output of /proc/net/route include many trailing spaces;
since most terminal's cols are less than 127, this made every fib entry occupy
two lines,
after applied this patch, the output of /proc/net/route is more
Mike Snitzer wrote:
Given that Jay rebased and posted updated bonding locking patches on
Oct 17 will you be pushing them for inclusion in 2.6.24-rc1? or
2.6.24-rcX? I don't see them queued in your netdev-2.6 tree. These
bonding locking issues have been a problem for some time and it would
be
Hello,
I'm seeing reproducible oops on 2.6.23-mm1 when trying to run tcpdump
over ppp0 interface. To reproduce I type simply:
# tcpdump -i ppp0
and wait a few seconds. I captured two oopses with a bit different stack
trace but EIP always points to packet_rcv():
(gdb) l* 0xc02d7d49
Gabriel C [EMAIL PROTECTED] writes:
Hi,
modprobing appletalk on current git gives a warning in dmesg :
[38506.600269] sysctl table check failed: /net/appletalk .3.7 procname does
not
match binary path procname
Oops. My apologies it appears I made a mistake when creating my
table to
Jeff Garzik [EMAIL PROTECTED] wrote:
[...]
I wasn't aware this brand-new code is a bug fix?
Normally brand new code needs to be posted and reviewed and committed to a
tree -before- the merge window opens.
I had thought this was going in ok, as you'd attempted to apply
it after the IPoIB
On Mon, 22 Oct 2007 20:40:18 +0200 Mariusz Kozlowski [EMAIL PROTECTED] wrote:
I'm seeing reproducible oops on 2.6.23-mm1 when trying to run tcpdump
over ppp0 interface.
Can you please test the latest Linus kernel from
ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/?
Because all
Oliver Neukum wrote:
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
+ void *buf;
u16 res;
mutex_lock(dev-phy_mutex);
Denis Cheng a écrit :
the temporary bf[127] char array is redundant, and the specified width 127 make
the output of /proc/net/route include many trailing spaces;
since most terminal's cols are less than 127, this made every fib entry occupy
two lines,
after applied this patch, the output of
It's a bit after 2.6.1 now...
Removes unnecessary if, uses 16 bit rotate left.
Performance improves ~30%
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 7c0b515..1c50f4c 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@
Eric W. Biederman wrote:
Gabriel C [EMAIL PROTECTED] writes:
Hi,
modprobing appletalk on current git gives a warning in dmesg :
[38506.600269] sysctl table check failed: /net/appletalk .3.7 procname does
not
match binary path procname
Oops. My apologies it appears I made a mistake
On Fri, Oct 19, 2007 at 05:53:08PM -0700, David Miller wrote:
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Fri, 19 Oct 2007 19:46:10 -0500
FWIW, it looks like not all that many arches do this; the output
for grep -r address_hi * is pretty thin. Then, looking at
i386/kernel/io_apic.c as
1. How can I attach my 32-bit value to the skb in the
PRE_ROUTNIG hook such that FORWARD and POST_ROUTING
hooks can later access this value from the skb ?
Can I use sk_buff-cb for that ?
2.
I want to add my custom destructor to the skb, the function
pointer to be called at skb destruction time.
Fix off-by one in remove logic that just got introduced.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
This only occurs in new post 2.6.23 code.
--- a/drivers/net/sky2.c2007-10-22 09:38:11.0 -0700
+++ b/drivers/net/sky2.c2007-10-22 12:11:22.0 -0700
@@
I'm seeing reproducible oops on 2.6.23-mm1 when trying to run tcpdump
over ppp0 interface.
Can you please test the latest Linus kernel from
ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/?
Sure.
Because all netwrking things which were in 2.6.23-mm1 are now in mainline.
So if
On 10/22/07, Yakov Lerner [EMAIL PROTECTED] wrote:
1. How can I attach my 32-bit value to the skb in the
PRE_ROUTNIG hook such that FORWARD and POST_ROUTING
hooks can later access this value from the skb ?
Can I use sk_buff-cb for that ?
In IP layer cb is used by IP as structure
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote:
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:
On pseries there's a chance it will work for PCI error recovery, but if
so it's just lucky that firmware has left everything configured the same
way.
? The papr
I'm trying to add support for the bluetooth device on Toshiba laptops
using rfkill. The device is controlled only via software and doesn't
exist at all unless enabled, at which point it appears on the USB bus.
However, doing something along the lines of:
toshiba_bluetooth_rfkill =
Plus minor formatting fixes.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
---
drivers/net/mipsnet.c | 44
1 file changed, 4 insertions(+), 40 deletions(-)
diff --git a/drivers/net/mipsnet.c b/drivers/net/mipsnet.c
index 37707a0..aafc3ce 100644
On Tue, Oct 23, 2007 at 07:24:27AM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote:
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:
On pseries there's a chance it will work for PCI error recovery, but if
so it's just
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Mon, 22 Oct 2007 14:54:52 -0500
As discussed in the other thread, I'll try to set up a patch
for an arch callback for restoring msi state.
Thank you.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
I don't know why you keep talking about powerpc laptops here ...
Well, there are Apple laptops, right? Aren't those the powermac
platform? Now, I don't know if they support MSI, but if they do,
I get the impression that they might not restore msi state correctly,
after being put into
On Mon, 2007-10-22 at 17:23 -0700, David Miller wrote:
From: [EMAIL PROTECTED] (Linas Vepstas)
Date: Mon, 22 Oct 2007 14:54:52 -0500
As discussed in the other thread, I'll try to set up a patch
for an arch callback for restoring msi state.
From what it looks like at this stage, pSeries
A quick look only:
Matti Linnanvuori [EMAIL PROTECTED] writes:
+++ linux-2.6.24/drivers/net/wan/retina.c
+ CHANGES
+ ---
+
+ v1.0.0 (JK) - May 27, 2003:
+ * Original driver.
+
+ v1.1.0 (JK) - June, 2003:
+* final Flexibilis driver
+
+ v1.2.0: NO_ARP
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 22 Oct 2007 18:36:28 -0700
On Mon, 2007-10-22 at 17:35 -0700, David Miller wrote:
Your code is rotating bit 15 down by one bit and bits 0-14 up by one
bit.
Yes, a 16 bit rotate left.
There was a discussion a few years ago:
On Mon, 2007-10-22 at 18:43 -0700, David Miller wrote:
Ok, but again did you test it?
Nope. Stephen Hemminger did in 2003.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Mon, 2007-10-22 at 17:35 -0700, David Miller wrote:
Your code is rotating bit 15 down by one bit and bits 0-14 up by one
bit.
Yes, a 16 bit rotate left.
There was a discussion a few years ago:
http://oss.sgi.com/archives/netdev/2003-10/msg00734.html
From the spec:
Implementers of DDP
On Mon, 22 Oct 2007 12:36:19 -0700
Joe Perches [EMAIL PROTECTED] wrote:
It's a bit after 2.6.1 now...
Removes unnecessary if, uses 16 bit rotate left.
Performance improves ~30%
Signed-off-by: Joe Perches [EMAIL PROTECTED]
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index
-Original Message-
From: Medve Emilian-EMMEDVE1
Sent: Monday, October 22, 2007 9:48 PM
To: David Miller
Cc: [EMAIL PROTECTED]; Li Yang-r58472;
netdev@vger.kernel.org; [EMAIL PROTECTED]
Subject: RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings
Hello David,
No
Joe Perches [EMAIL PROTECTED] wrote:
On Mon, 2007-10-22 at 18:43 -0700, David Miller wrote:
Ok, but again did you test it?
Nope. Stephen Hemminger did in 2003.
But your code differs significantly from Stephen's version.
However, if it is correct it does look like a good improvement.
So
On Mon, 2007-10-22 at 20:30 -0700, Stephen Hemminger wrote:
Corrected fast code is:
while (len--) {
sum += *data++;
sum = 1;
sum = (((sum 0x1) 16) + sum) 0x;
}
At least it is correct on the standalone
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote:
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:
On pseries there's a chance it will work for PCI error recovery, but if
so it's just lucky that firmware has left everything configured the same
way.
? The papr
On Mon, Oct 22, 2007 at 10:03:47PM +0200, Yakov Lerner wrote:
I want to add my custom destructor to the skb, the function pointer
to be called at skb destruction time. Will the following work: if I
push address of my_destructor to the
sk-buff-destructor field, and then when my_destructor
is
96 matches
Mail list logo
