From: Herbert Xu [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 09:09:29 +0800
In any case, I just looked up RFC1213 and it says:
udpInDatagrams OBJECT-TYPE
SYNTAX Counter
ACCESS read-only
STATUS mandatory
DESCRIPTION
From: Wang Chen [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 10:02:03 +0800
So if udp_queue_rcv_skb() doing sucessfully means a UDP
datagrams delivered to UDP users, the InDatagrams should be
increased in udp_queue_rcv_skb().
Otherwise it should be increased until the UDP datagrams is
actually
From: Herbert Xu [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 12:41:17 +0800
On Sun, Nov 18, 2007 at 02:40:10PM -0800, David Miller wrote:
This can be fixed, the above cannot.
That's a good point. Perhaps one way of getting that info to
the user without putting it in UDPInDatagrams is to
Although tmpl-optional is set, kernel still attempts
to create a set of SAs.
In xfrm_tmpl_resolve_one(), xfrm_state_find() is called
to find an SA. First time, there won't be an SA, so an
ACQUIRE will be sent and code then returns to
xfrm_tmpl_resolv_one() who then checks tmpl-optional.
Since
Maybe it is good idea to print some registers/etc in watchdog message?
I will try to reproduce problem with debug enabled, maybe it will be possible
to catch problem with more debug.
On Sun, 18 Nov 2007 22:00:38 +0100, Francois Romieu wrote
Denys [EMAIL PROTECTED] :
Before it happens on
The pktgen_output_ipsec() function can unlock this lock twice
due to merged error and plain paths. Remove one of the calls
to spin_unlock.
Other possible solution would be to place return 0 right
after the first unlock, but at this place the err is known
to be 0, so these solutions are the same
On Mon, Nov 19, 2007 at 02:53:50AM -0600, Joy Latten wrote:
Although tmpl-optional is set, kernel still attempts
to create a set of SAs.
Heh I made the same mistake when I first read this piece of
code too :) The optional flag isn't saying that it doesn't need
to be protected, but rather that
Hi 2 all again
This is not a bug report this time :-)
Just it is very interesting question, about using Linux shaping technologies
in serious jobs.
What i realised few days ago, many ISP's set on their STM-1(15552 bits/s)
links (over Cisco) packet buffer/queue 40 packets(for example).
It
Both try_module_get/module_put already handle the module == NULL
case, so no need in manual checking.
This patch fits both net-2.6 and net-2.6.25.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c
index 664cb8e..535abe0
Am Montag, 19. November 2007 schrieb Rusty Russell:
This fixes a potential dangling xmit problem.
We also suppress refill interrupts until we need them.
(Anthony and I have been working on performance recently, so this
is a WIP).
Signed-off-by: Rusty Russell [EMAIL PROTECTED]
Thanks
Subject: make netns cleanup to run in a separate queue
From: Benjamin Thery [EMAIL PROTECTED]
This patch adds a separate workqueue for cleaning up a network
namespace. If we use the keventd workqueue to execute cleanup_net(),
there is a problem to unregister devices in IPv6. Indeed the code
Ah, sorry. Didn't notice it's called only on boot.
Acked-By: Kirill Korotaev [EMAIL PROTECTED]
Kirill Korotaev wrote:
imho panic() is too much.
create_singlethread_workqueue() can fail e.g. due to out of memory...
Thanks,
Kirill
Daniel Lezcano wrote:
Subject: make netns cleanup to
Em Mon, Nov 19, 2007 at 12:41:17PM +0800, Herbert Xu escreveu:
On Sun, Nov 18, 2007 at 02:40:10PM -0800, David Miller wrote:
This can be fixed, the above cannot.
That's a good point. Perhaps one way of getting that info to
the user without putting it in UDPInDatagrams is to create an
This function references sk-sk_prot-xxx for many times.
It turned out, that there's so many code in it, that gcc
cannot always optimize access to sk-sk_prot's fields.
After saving the sk-sk_prot on the stack and comparing
disassembled code, it turned out that the function became
~10 bytes
Hello!
Is there a reason that the target hardware address isn't the target
hardware address?
It is bound only to the fact that linux uses protocol address
of the machine, which responds. It would be highly confusing
(more than confusing :-)), if we used our protocol address and hardware
When the abstraction functions got added, conversion was made
here incorrectly. As a result, the skb may end up pointing
to skb which got included to the probe skb and then was freed.
For it to trigger, however, transmit_skb must fail sending as
well.
Signed-off-by: Ilpo Järvinen [EMAIL
Please ignore the previous version, it had an rbtree artifact which made
it to not apply cleanly, here's the corrected version:
--
[PATCH] [TCP] MTUprobe: fix potential sk_send_head corruption
When the abstraction functions got added, conversion here was
made incorrectly. As a result, the skb
/* returns in *addr the internet address having the name ifname */
int get_ifaddr_by_name(const char *ifname, __u32 * addr)
{
struct net_device *pnet_device;
struct in_device *pin_device;
struct in_ifaddr* inet_ifaddr;
read_lock_bh(dev_base_lock);
#if
All of our options suck, we just have to choose the least sucking one
and right now to me that's decrementing the counter as much as I
empathize with the SNMP application overflow detection issue.
If the SNMP monitor detects an false overflow the error it reports
will be much
On Mon, 2007-19-11 at 12:47 +0300, Pavel Emelyanov wrote:
The pktgen_output_ipsec() function can unlock this lock twice
due to merged error and plain paths. Remove one of the calls
to spin_unlock.
Good catch.
Acked-by: Jamal Hadi Salim [EMAIL PROTECTED]
cheers,
jamal
-
To unsubscribe from
Denys,
You certainly make a very compelling case. It is always compelling if
you can translate a bug/feature into $$;-.
So in your measurements, what kind of clock sources did you use?
I think the parameters to worry about are: packet size, rate and clock
source.
I know that based on very old
A printk in the error handling code of dm9601.c was missing a newline.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/net/usb/dm9601.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
index
dm_write_async and dm_write_reg_async are almost identical.
Move common functionality to dm_write_async_helper (saves ~256b).
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/net/usb/dm9601.c | 53 +++--
1 files changed, 13 insertions(+), 40
On Mon, Nov 19, 2007 at 06:51:38PM +, David ([EMAIL PROTECTED]) wrote:
Patrick McHardy wrote:
iptables -t nat -A PREROUTING -j REDIRECT -i eth2 -p udp --dport
5061 --to-ports 5060
Also post the kernel panic log.
Please try if this patch fixes the problem.
Em Mon, Nov 19, 2007 at 03:13:44PM +0300, Pavel Emelyanov escreveu:
This function references sk-sk_prot-xxx for many times.
It turned out, that there's so many code in it, that gcc
cannot always optimize access to sk-sk_prot's fields.
After saving the sk-sk_prot on the stack and comparing
On Mon, Nov 19, 2007 at 10:24:23PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED])
wrote:
On Mon, Nov 19, 2007 at 06:51:38PM +, David ([EMAIL PROTECTED]) wrote:
Patrick McHardy wrote:
iptables -t nat -A PREROUTING -j REDIRECT -i eth2 -p udp --dport
5061 --to-ports 5060
Evgeniy Polyakov wrote:
On Mon, Nov 19, 2007 at 10:24:23PM +0300, Evgeniy Polyakov ([EMAIL
PROTECTED]) wrote:
On Mon, Nov 19, 2007 at 06:51:38PM +, David ([EMAIL PROTECTED]) wrote:
Patrick McHardy wrote:
iptables -t nat -A PREROUTING -j REDIRECT -i eth2 -p udp
This patch fixes a long boot delay in the forcedeth driver. During
initialization, the timeout for the handshake between mgmt unit and
driver can be very long. The patch reduces the timeout by eliminating a
extra loop around the timeout logic.
Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED]
Denis V. Lunev [EMAIL PROTECTED] writes:
net: consolidate net namespace related proc files creation
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Eric W. Biederman [EMAIL PROTECTED]
Looks good to me, and it looks like there are a
- Fix to aggregate vlan packets. IP offset is incremented by
4 bytes if the packet contains vlan header.
Signed-off-by: Santoshkumar Rastapur [EMAIL PROTECTED]
Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED]
---
diff -Nurp 2.0.26.8P1/drivers/net/s2io.c 2.0.26.8P2/drivers/net/s2io.c
---
- Updated the vlan tag stripping code as per Dave Johnson's patch
[EMAIL PROTECTED]
Below is the driver behaviour for vlan_tag_strip loadable paramter,
vlan_tag_strip - 0: Don't strip the vlan tag
vlan_tag_strip - 1: Always strip the vlan tag
vlan_tag_strip - 2
Remove the cal_CRC as this is basically wrappering the
ether_crc_le function, and is only being used by the
multicast hash table functions.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
Add support for ethtool operations for the DM9000.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===
--- linux-2.6.23-quilt3.orig/drivers/net/dm9000.c
+++
Reading the ID register does not always return the correct ID
from the device, so we retry several times to see if we get
a correct value.
These failures seem to be excaserbated by the speed of the
access to the chip (possibly time between issuing the address
and then the data cycle).
The writing of the data should implicitly truncate
the data to 8bits, so do not bother with the ands
in the code.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===
---
Allow the msg_enable value to be read and written by
the ethtool interface.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===
--- linux-2.6.23-quilt3.orig/drivers/net/dm9000.c
+++
When the device is open, we have to probe the PHY's MII status
periodically as there is no status change interrupt. As the
phy code is going to change to using calls which might sleep
we move to using a kthread instead of a timer.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index:
Show whether the MAC address was read from the EEPROM or
the onboard PAR registers.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt5/drivers/net/dm9000.c
===
--- linux-2.6.23-quilt5.orig/drivers/net/dm9000.c
+++
Add entry to handle the MII ioctl() calls via the
generic_mii_ioctl call.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===
--- linux-2.6.23-quilt3.orig/drivers/net/dm9000.c
+++
Add a mutex to serialise access to the chip functions from
entries such as the ethtool and the MII code. This should
reduce the amount of time the spinlock is held to protect
the address register.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
Ensure we hold the spinlock whilst the registers and being
modified even though we hold the overall lock. This should
protect against an interrupt happening whilst we are using
the device.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
Allow the platform data to specify to the DM9000 driver
that there is no posibility of an attached EEPROM on the
device, so default all reads to 0xff and ignore any
write operations.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
Use the netif_msg_*() macros to enable the debugging based
on the board's msg_enable field. The output still goes via
the dev_dbg() macros, so will be tagged and output as
appropriate.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt4/drivers/net/dm9000.c
The phy read and write routines call udelay() with the board
lock held, and with the posibility of IRQs being disabled. Since
these delays can be up to 500usec, and are only required as we
have to save the chip's address register.
To improve the behaviour, hold the lock whilst we are writing
and
This is my current proposed patch series to the DM9000
driver for both general cleanups, support for ethtool
and to make the code better.
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 bytes'
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
The srom array in the board data is only being used in the device probe
routines. The probe also only uses the first 6 bytes of an array
we spend 512ms reading 128 bytes from. Change to reading the
MAC area directly to the MAC address structure.
As a side product, we rename the read_srom_word to
The code was using a delay of 8ms, when it should have been
using the EEPROM status flag from the device to indicate the
EEPROM transaction had finished.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
Change the debug macros to use the compiler to elide any
unnecessary debug level, and to allow device configurable
debug control.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt1/drivers/net/Kconfig
===
---
Add ethtool support to access the configuration EEPROM
connected to the DM9000.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===
--- linux-2.6.23-quilt3.orig/drivers/net/dm9000.c
+++
Use the platform data to pass modifications to the flags
passed to request_irq() to alter the behaviour of the IRQ.
This can be used to specify IRQ type for the platform the
DM9000 is connected to.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.22-quilt6/drivers/net/dm9000.c
We can use sleeping functions when reading and writing the
PHY registers, so let us sleep instead of busy waiting for
the PHY.
Note, this also fixes a bug reading the PHY where only 100uS
was being used instead of 150uS
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index:
We have a perfectly good version control system, so we do not
need to duplicate change comments in the header for this code.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt2/drivers/net/dm9000.c
===
---
Move to using dev_dbg() and friends for the output of
information to the user.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.22-quilt4/drivers/net/dm9000.c
===
--- linux-2.6.22-quilt4.orig/drivers/net/dm9000.c
+++
Remove the old hack to program an initial EEPROM setting
into the DM9000 as we now have ethtool support for reading
and writing the EEPROM.
Signed-off-by: Ben Dooks [EMAIL PROTECTED]
Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
On Monday, 19 of November 2007, Pavel Machek wrote:
Hi!
I think that this worked before:
[EMAIL PROTECTED]:/proc# find . -name timer_info
find: WARNING: Hard link count is wrong for ./net: this may be a bug
in your filesystem driver. Automatically turning on find's -noleaf
option.
From: Andi Kleen [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 16:29:33 +0100
All of our options suck, we just have to choose the least sucking one
and right now to me that's decrementing the counter as much as I
empathize with the SNMP application overflow detection issue.
If
On Mon, 19 Nov 2007 20:39:10 +
Ben Dooks [EMAIL PROTECTED] wrote:
This is my current proposed patch series to the DM9000
driver for both general cleanups, support for ethtool
and to make the code better.
You could also change all instances of dev-priv with netdev_priv(dev).
--
Denys [EMAIL PROTECTED] :
Maybe it is good idea to print some registers/etc in watchdog message?
I will try to reproduce problem with debug enabled, maybe it will be possible
to catch problem with more debug.
Your customers will not necessarily like it but it could be useful to
trace the
On Mon, 5 Nov 2007 12:15:30 -0600
Kim Phillips [EMAIL PROTECTED] wrote:
Hello all,
the following patches fix RGMII timing for rev. 2.1 of the mpc8360,
according to erratum #2 (erratum text included below). Basically the
most intrusive part is the addition of two new RGMII Internal Delay
sysctl_tcp_congestion_control seems to have a bug that prevents it from
actually calling the tcp_set_default_congestion_control function. This is not
so apparent because it does not return an error and generally the /proc
interface is used to configure the default TCP congestion control algorithm.
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/3c507.c |4 ++--
drivers/net/amd8111e.c |4 ++--
drivers/net/at1700.c|2 +-
drivers/net/pppol2tp.c |2 +-
drivers/net/qla3xxx.c |2 +-
drivers/net/rrunner.c |2 +-
drivers/net/s2io.c |6
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/wan/wanxl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 8e320b7..ad8c865 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -743,7
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/wireless/b43/phy.c |2 +-
drivers/net/wireless/b43legacy/phy.c |2 +-
drivers/net/wireless/bcm43xx/bcm43xx_phy.c |2 +-
drivers/net/wireless/libertas/wext.c |2 +-
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/ixgbe/ixgbe_common.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c
index 512e3b2..b7e50bc 100644
--- a/drivers/net/ixgbe/ixgbe_common.c
+++
Kim Phillips wrote:
On Mon, 5 Nov 2007 12:15:30 -0600
Kim Phillips [EMAIL PROTECTED] wrote:
Hello all,
the following patches fix RGMII timing for rev. 2.1 of the mpc8360,
according to erratum #2 (erratum text included below). Basically the
most intrusive part is the addition of two new RGMII
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/chelsio/cxgb2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
index 2dbf8dc..3eca4e3 100644
--- a/drivers/net/chelsio/cxgb2.c
+++
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_offload.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_offload.c
b/drivers/net/cxgb3/cxgb3_offload.c
index bd25421..7086f76 100644
---
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/netxen/netxen_nic_hw.c |2 +-
drivers/net/netxen/netxen_nic_init.c |4 ++--
drivers/net/netxen/netxen_nic_main.c |6 +++---
drivers/net/netxen/netxen_nic_niu.c |4 ++--
4 files changed, 8 insertions(+), 8
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/sk98lin/skgepnmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sk98lin/skgepnmi.c b/drivers/net/sk98lin/skgepnmi.c
index b36dd9a..678659f 100644
--- a/drivers/net/sk98lin/skgepnmi.c
+++
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/bridge/netfilter/ebt_among.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge/netfilter/ebt_among.c
index 392d877..6436d30 100644
--- a/net/bridge/netfilter/ebt_among.c
+++
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/dccp/ccids/lib/loss_interval.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ccids/lib/loss_interval.c
b/net/dccp/ccids/lib/loss_interval.c
index 40ad428..d26b88d 100644
---
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/ipv6/addrconf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 1bd8d81..567664e 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -967,7 +967,7 @@ int
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/sctp/sm_statefuns.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 5ebbe80..b8bbb96 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/sunrpc/auth_gss/auth_gss.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
index 53995af..22906b8 100644
--- a/net/sunrpc/auth_gss/auth_gss.c
+++
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/irda/iriap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/irda/iriap.c b/net/irda/iriap.c
index dc5e34a..a86a5d8 100644
--- a/net/irda/iriap.c
+++ b/net/irda/iriap.c
@@ -928,7 +928,7 @@ void
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
net/ipv4/ipvs/ip_vs_core.c |2 +-
net/ipv4/netfilter/iptable_raw.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c
index 20c884a..8fba202 100644
---
Divy Le Ray wrote:
Ben Greear wrote:
This panic happens (almost?) immediately after starting TCP traffic
between
the cxgb nic on this system and another. We also got at least one crash
on a custom/tainted 2.6.20.12 kernel, but it would run for at least
a few minutes at ~1Gbps first.
I think
On Mon, Nov 19, 2007 at 12:58:14PM +0300, Pavel Emelyanov wrote:
Both try_module_get/module_put already handle the module == NULL
case, so no need in manual checking.
This patch fits both net-2.6 and net-2.6.25.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Thanks, that looks fine to
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:18 -0700
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied to net-2.6.25, but I gave the changelog a more descriptive
headline:
[NETPOLL]: Kill NETPOLL_RX_DROP, set but never tested.
Thanks.
-
To
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:17 -0700
The local_mac is managed by the network device, no need to
keep a spare copy and all the management problems that could
cause.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied to net-2.6.25, thanks!
-
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:16 -0700
Restructure code slightly to improve readability:
* dereference device once
* change obvious while() loop
* let poll_napi() handle null list itself
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:15 -0700
Use standard route for flushing queue.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied to net-2.6.25, thanks!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
It's a bad idea to call flush_scheduled_work from within a
netdev-stop because the linkwatch will occasionally take the
rtnl lock from a workqueue context, and thus that can deadlock.
This reworks things a bit in that area to avoid the problem.
Signed-off-by: Benjamin Herrenschmidt [EMAIL
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:22 -0700
--- a/drivers/net/Kconfig 2007-11-03 11:30:57.0 -0700
+++ b/drivers/net/Kconfig 2007-11-03 11:30:59.0 -0700
@@ -3118,8 +3118,8 @@ config NETCONSOLE_DYNAMIC
config NETPOLL
def_bool
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:24 -0700
This patch makes netpoll work for non-NAPI devices that call
netif_receive_skb. Devices are allowed to call netif_receive_skb
if they are receiving packets in softirq (ie in tasklet).
One side effect of this is
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:25 -0700
Get rid of rx_lock and use Read-Copy-Update to make sure
that netpoll info and rx handle are not used after free.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Please also respin this one too, thanks.
-
To
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:20 -0700
The device name was only in npinfo for netconsole target
configuration, so move it to netconsole. Netconsole only
needs the value during config, so no need to do all
the device name tracking etc..
Make
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:19 -0700
The rx_flags variable is redundant. Turning rx on/off is done
via setting the rx_np pointer.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Not all of these transformations are equivalent, and as a result
On Mon, 19 Nov 2007 19:55:15 -0800 (PST)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:23 -0700
Netpoll only works on Ethernet devices, so check during setup
rather than just failing silently later.
Signed-off-by: Stephen
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:21 -0700
The name was being stored and used only for error messages.
The same effect can be had by just passing it in where needed during
config.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
The whole world of
On Mon, 19 Nov 2007 19:47:50 -0800 (PST)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:20 -0700
The device name was only in npinfo for netconsole target
configuration, so move it to netconsole. Netconsole only
needs the
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat, 03 Nov 2007 11:43:23 -0700
Netpoll only works on Ethernet devices, so check during setup
rather than just failing silently later.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/net/core/netpoll.c 2007-11-03
This patch allows LSM modules filter incoming connections/datagrams
based on the process's security context who is attempting to pick up.
There are already hooks to filter incoming connections/datagrams
based on the socket's security context, but these hooks are not
applicable when one wants to
From: Andrew Gallatin [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 11:11:55 -0400
I've attached a patch which adds support to inet_lro for aggregating
pure acks.
I've applied this patch to net-2.6.25... but!
This needs some serious thinking. What this patch ends up doing is creating
big
Heh I made the same mistake when I first read this piece of
code too :) The optional flag isn't saying that it doesn't need
to be protected, but rather that the SA may not be present on
input. It's only used for IPComp where we may skip the IPComp
if the data is not compressible.
In other words
From: John W. Linville [EMAIL PROTECTED]
Date: Tue, 6 Nov 2007 22:08:53 -0500
Individual patches are available here:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem
...
Mattias Nissler (1):
mac80211: Accept auto txpower setting
Michael
From: Adrian Bunk [EMAIL PROTECTED]
Date: Thu, 8 Nov 2007 04:30:10 +0100
@davem:
Please look at net/ipv4/arp.c:arp_process()
Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
CONFIG_NETDEV_1=y will not be handled correctly there?
And the best solution is to nuke
On Mon, 19 Nov 2007, David Miller wrote:
From: Andi Kleen [EMAIL PROTECTED]
Date: Mon, 19 Nov 2007 16:29:33 +0100
All of our options suck, we just have to choose the least sucking one
and right now to me that's decrementing the counter as much as I
empathize with the SNMP
On Mon, 19 Nov 2007, Alexey Kuznetsov wrote:
Hello!
Is there a reason that the target hardware address isn't the target
hardware address?
It is bound only to the fact that linux uses protocol address
of the machine, which responds. It would be highly confusing
(more than confusing
From: David Stevens [EMAIL PROTECTED]
Date: Wed, 14 Nov 2007 08:53:13 -0800
Maybe I'm more used to hex, but I personally don't think those are
more readable. It replaces 1-line macroes with 4-line functions, and
I think more vgrepping to pick out the relevant constant data.
Yes, the
1 - 100 of 166 matches
Mail list logo
