Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-11 Thread Benjamin Herrenschmidt
On Sat, 2008-01-12 at 08:26 +0100, Stefan Roese wrote: > > We shouldn't make it too complicated. We can always select different > settings > in the defconfig file. My thinking here is to better wast a little > memory > with a potential performance improvement. Just me 0.02$ If it gets really c

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-11 Thread Stefan Roese
On Friday 11 January 2008, Benjamin Herrenschmidt wrote: > On Fri, 2008-01-11 at 09:48 -0800, Eugene Surovegin wrote: > > On Sat, Jan 05, 2008 at 01:38:17PM +0100, Stefan Roese wrote: > > > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > > > On Sat, 2008-01-05 at 10:50 +0100, Stefan

[PATCH 9/9] fix sparse warnings

2008-01-11 Thread Stephen Hemminger
Make FIB TRIE go through sparse checker without warnings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:35:37.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:41:57.0 -0800 @@ -653,7 +653,6 @@ static struct node *resize(str

[PATCH 7/9] printk related cleanups

2008-01-11 Thread Stephen Hemminger
printk related cleanups: * Get rid of unused printk wrappers. * Make bug checks into KERN_WARNING because KERN_DEBUG gets ignored * Turn one cryptic old message into something real * Make sure all messages have KERN_XXX --- net/ipv4/fib_frontend.c |6 ++ net/ipv4/fib_hash.c |

[PATCH 4/9] statistics improvements

2008-01-11 Thread Stephen Hemminger
Turn the unused size field into a useful counter for the number of routes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:30:28.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:30:36.0 -0800 @@ -149,10 +149,10 @@ struct tri

[PATCH 1/9] get rid of trie_init

2008-01-11 Thread Stephen Hemminger
trie_init is worthless it is just zeroing stuff that is already zero! Move the memset() down to make it obvious. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 21:56:47.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:03:47.0

[PATCH 8/9] add statistics

2008-01-11 Thread Stephen Hemminger
The FIB TRIE code has a bunch of statistics, but the code is hidden behind an ifdef that was never implemented. Since it was dead code, it was broken as well. This patch fixes that by making it a config option. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/Kconfig 2008-01-

[PATCH 5/9] use %u for unsigned printfs

2008-01-11 Thread Stephen Hemminger
Use %u instead of %d when printing unsigned values. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:30:36.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:30:46.0 -0800 @@ -2100,13 +2100,13 @@ static void trie_show_stats(str

[PATCH 2/9] get rid of unused revision element

2008-01-11 Thread Stephen Hemminger
The revision element must of been part of an earlier design, because currently it is set but never used. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:18:34.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:26:34.0 -0800 @@

[PATCH 6/9] : fib_insert_node cleanup

2008-01-11 Thread Stephen Hemminger
The only error from fib_insert_node is if memory allocation fails, so instead of passing by reference, just use the convention of returning NULL. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:04:08.0 -0800 +++ b/net/ipv4/fib_trie.c

[PATCH 0/9] FIB patches for 2.6.25

2008-01-11 Thread Stephen Hemminger
Did some work cleaning up FIB Trie today. The only real change is the output format for /proc/net/fib_triestat. -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

[PATCH 3/9] move size information to pr_debug()

2008-01-11 Thread Stephen Hemminger
The size of structures is a debug thing, not something that needs to be part of a /proc api. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-11 22:29:20.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-11 22:30:28.0 -0800 @@ -1962,8 +19

Netconf at conf.au 2008?

2008-01-11 Thread Andy Johnson
Hello, I saw somewhere (maybe in this mailing list a while ago) that there might be a Linux Kernel Developers' Netconf conference at conf.au 2008. Does anyone here know if such a thing is planned ? Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <[EMAIL PROTECTED]> says: > #define IN_MULTICAST_NET 0xF000 > > +#define IN_CLASSE(a) long int) (a)) & 0xf000) == 0xf000) > +#define IN_CLASSE_NET 0xff00 > +#

Re: questions on NAPI processing latency and dropped network packets

2008-01-11 Thread Ray Lee
On Jan 10, 2008 9:24 AM, Chris Friesen <[EMAIL PROTECTED]> wrote: > After a recent userspace app change, we've started seeing packets being > dropped by the ethernet hardware (e1000, NAPI is enabled). The > error/dropped/fifo counts are going up in ethtool: (These are perhaps too obvious, but I d

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Denys Fedoryshchenko
Sorry. that i interfere in this subject. Do you recommend CONFIG_IRQBALANCE to be enabled? If it is enabled - irq's not jumping nonstop over processors. softirqd changing this behavior. If it is disabled, irq's distributed over each processor, and in loaded systems it seems harmful. I work a l

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 17:48:57 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 11 Jan 2008 21:41:20 +0900 (JST) > > > There is no positive consesus on this draft > > at the intarea meeting in Van

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-11 Thread jamal
On Fri, 2008-11-01 at 18:42 -0200, Dzianis Kahanovich wrote: > About script example: > While I compose filter, I check flag ($TC_INDEX2MARK), tells me are patch > applied or no. If no - I use usual "-j MARK --set-mark", else I use classid to > change mark. All in ingress only. For example: > tc fi

Re: iproute2: removing primary address removes secondaries

2008-01-11 Thread David Miller
echo "1" >/proc/sys/net/ipv4/conf/all/promote_secondaries -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: questions on NAPI processing latency and dropped network packets

2008-01-11 Thread David Miller
From: "Chris Friesen" <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 08:59:26 -0600 > I'd love to work on newer kernels, but we have a commitment to our > customers to support multiple releases for a significant amount of time. And by asking here for people to dig into it for you, you are asking peo

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread David Miller
From: Vince Fuller <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 09:29:15 -0800 > I leave it up to you, the developers, to decide if you want to use these > patches. Vince, please just ignore these turkeys who are dismissing your patch and respin it against current sources as I asked of you. I'll a

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 21:41:20 +0900 (JST) > There is no positive consesus on this draft > at the intarea meeting in Vancouver, right? > > We cannot / should not enable that space until we have reached > a consensus on it. This is so incredibly

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread David Miller
From: Benny Amorsen <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 12:09:32 +0100 > David Miller <[EMAIL PROTECTED]> writes: > > > No IRQ balancing should be done at all for networking device > > interrupts, with zero exceptions. It destroys performance. > > Does irqbalanced need to be taught about

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread Rafael J. Wysocki
On Friday, 11 of January 2008, supersud501 wrote: > > Rafael J. Wysocki wrote: > >> http://bugzilla.kernel.org/show_bug.cgi?id=9721 > allright, didn't see that before, sorry, here are the results: > > kernel 2.6.23.12 acpi=off: when shutting down the system doesn't > poweroff (of course), but p

Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Johannes Berg
On Sat, 2008-01-12 at 10:01 +1100, Herbert Xu wrote: > On Fri, Jan 11, 2008 at 11:58:05PM +0100, Johannes Berg wrote: > > > > Ok. Yes, we will of course adhere to that, but I was wondering whether > > maybe the net stack assumes somewhere that a packet it got from the > > driver can be written to

Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Herbert Xu
On Fri, Jan 11, 2008 at 11:58:05PM +0100, Johannes Berg wrote: > > Ok. Yes, we will of course adhere to that, but I was wondering whether > maybe the net stack assumes somewhere that a packet it got from the > driver can be written to w/o copying. All parts of the rx stack support clone handling b

Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Johannes Berg
On Sat, 2008-01-12 at 09:31 +1100, Herbert Xu wrote: > Johannes Berg <[EMAIL PROTECTED]> wrote: > > > > Is it ok to do this? Will something freak out if we pass a cloned skb to > > netif_rx()? > > Sounds OK as long as you stick to the rules of cloned skb's, e.g., not > writing to them unless you'

[oops] 2.6.23.9

2008-01-11 Thread Andrei Popa
Linux version 2.6.23.9 vanilla Jan 7 02:24:11 eunite BUG: scheduling while atomic: mii-tool/0x0002/31658 Jan 7 02:24:11 eunite [] schedule+0x27a/0x35e Jan 7 02:24:11 eunite [] __mod_timer+0xac/0xbc Jan 7 02:24:11 eunite [] schedule_timeout+0x43/0x9f Jan 7 02:24:11 eunite [] process_timeou

Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Herbert Xu
Johannes Berg <[EMAIL PROTECTED]> wrote: > > Is it ok to do this? Will something freak out if we pass a cloned skb to > netif_rx()? Sounds OK as long as you stick to the rules of cloned skb's, e.g., not writing to them unless you've copied it. Cheers, -- Visit Openswan at http://www.openswan.org

Re: questions on NAPI processing latency and dropped network packets

2008-01-11 Thread Herbert Xu
Chris Friesen <[EMAIL PROTECTED]> wrote: > > I'd love to work on newer kernels, but we have a commitment to our > customers to support multiple releases for a significant amount of time. Since you've made the commitment, you should stick to it and resolve the issues without asking us to contribut

Re: rp_filter and ip rule break ipsec policy

2008-01-11 Thread Herbert Xu
Marco Berizzi <[EMAIL PROTECTED]> wrote: > > When I insert the rule number #601 packets to > x.y.z.214 aren't ate by xfrm anymore. This > happens when rp_filter is set to 1 on eth0. > Disabling rp_filter on eth0 resolve the problem: > xfrm eat the packets. > Is this the expected behaviour? Why shou

Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Tomas Winkler
On Jan 11, 2008 3:17 AM, Johannes Berg <[EMAIL PROTECTED]> wrote: > In 802.11n, there is a case where multiple data frames are received > aggregated into a single frame (A-MSDU). > > Currently, we copy each of these frames out into their own skb, but > because of the alignment with that etc. I star

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread supersud501
Rafael J. Wysocki wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9721 On Friday, 11 of January 2008, supersud501 wrote: Stephen Hemminger wrote: On Wed, 9 Jan 2008 16:03:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: (switched to email. Please respond via emailed reply-to-all, not

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-11 Thread Benjamin Herrenschmidt
On Fri, 2008-01-11 at 09:48 -0800, Eugene Surovegin wrote: > On Sat, Jan 05, 2008 at 01:38:17PM +0100, Stefan Roese wrote: > > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > > > Performance tests done by AMCC have shown t

TCP & hints

2008-01-11 Thread Ilpo Järvinen
Hi Stephen, Do you still remember what this is for (got added along with other TCP hint stuff)? What kind of problem you saw back then (or who saw problems)? @@ -1605,6 +1711,10 @@ static void tcp_undo_cwr(struct sock *sk, const int undo) } tcp_moderate_cwnd(tp); tp->snd

[PATCH] [ROSE] two extra tab characters removed

2008-01-11 Thread Bernard Pidoux F6BVP
Signed-off-by: Bernard Pidoux <[EMAIL PROTECTED]> --- include/net/rose.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/rose.h b/include/net/rose.h index d3ab453..0cfdc0e 100644 --- a/include/net/rose.h +++ b/include/net/rose.h @@ -86,7 +86,7 @@ struct ro

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread Rafael J. Wysocki
> http://bugzilla.kernel.org/show_bug.cgi?id=9721 On Friday, 11 of January 2008, supersud501 wrote: > > Stephen Hemminger wrote: > > On Wed, 9 Jan 2008 16:03:00 -0800 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > >> (switched to email. Please respond via emailed reply-to-all, not via the >

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread supersud501
Stephen Hemminger wrote: On Wed, 9 Jan 2008 16:03:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 9 Jan 2008 13:05:34 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.or

RFC: TIPC API, bind to two networks

2008-01-11 Thread Randy Macleod
I'd like some feedback on a change to TIPC that I plan to submit to netdev/kernel.org. At this stage, I'm interested in what people think about using the protocol parameter of the socket interface to select a TIPC stack for the socket. My co-worker, Chris Friesen, has suggested that it would be m

Re: doubt in e1000_io_write()

2008-01-11 Thread Breno Leitao
Hello Auke, On Fri, 2008-01-11 at 10:41 -0800, Kok, Auke wrote: > > Even hw structure has not been used, why it has been passed into > > e1000_io_write function? > > 2.6.12.3? why do you care? that code is probably long gone... was that > function > even used? I noticed that this also happens o

Re: Bonding : Monitoring of 4965 wireless card

2008-01-11 Thread Chris Snook
[EMAIL PROTECTED] wrote: Hi, I want to make a bond with my wireless card. The ipw driver create two interfaces (wlan0 and wmaster0). When i switch the rf_kill button, ifplug detect wlan0 unplugged but not wmaster0. If i down wlan0 (while rf_kil ), bonding detect the inactivity when i up the i

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Rick Jones
Breno Leitao wrote: On Fri, 2008-01-11 at 17:48 +0100, Eric Dumazet wrote: Breno Leitao a écrit : Take a look at the interrupt table this time: io-dolphins:~/leitao # cat /proc/interrupts | grep eth[1]*[67] 277: 151362450 13 14 13 14 15

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Breno Leitao
Hello Denys, I've installed sysstat (good tools!) and the result is very similar to the one which appears at top, take a look: 13:34:23 CPU %user %nice%sys %iowait%irq %soft %steal %idleintr/s 13:34:24 all0.000.002.720.000.25 12.130.99

Re: doubt in e1000_io_write()

2008-01-11 Thread Kok, Auke
Jeba Anandhan wrote: > Hi all, > i have doubt in e1000_io_write(). > > void > e1000_io_write(struct e1000_hw *hw, unsigned long port, uint32_t value) > { > outl(value, port); > } > > > kernel version: 2.6.12.3 > > > Even hw structure has not been used, why it has been passed into > e10

[PATCH] dm9161: add configuration for MII/RMII

2008-01-11 Thread frederic RODO
diff --git a/drivers/net/phy/davicom.c b/drivers/net/phy/davicom.c index 7ed632d..6bdc32f 100644 --- a/drivers/net/phy/davicom.c +++ b/drivers/net/phy/davicom.c @@ -37,6 +37,7 @@ #define MII_DM9161_SCR 0x10 #define MII_DM9161_SCR_INIT0x0610 +#define MII_DM9161_SCR_RMII0x0100 /

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Breno Leitao
On Fri, 2008-01-11 at 17:48 +0100, Eric Dumazet wrote: > Breno Leitao a écrit : > > Take a look at the interrupt table this time: > > > > io-dolphins:~/leitao # cat /proc/interrupts | grep eth[1]*[67] > > 277: 151362450 13 14 13 14 > >15

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-11 Thread Rick Jones
The test command is: #sudo taskset -c 7 ./netserver #sudo taskset -c 0 ./netperf -t TCP_RR -l 60 -H 127.0.0.1 -i 50,3 -I 99,5 -- -r 1,1 A couple of comments/questions on the command lines: *) netperf/netserver support CPU affinity within themselves with the global -T option to netperf. Is th

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-11 Thread Eugene Surovegin
On Sat, Jan 05, 2008 at 01:38:17PM +0100, Stefan Roese wrote: > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > > Performance tests done by AMCC have shown that 256 buffer increase the > > > performance of the Linux EMAC driv

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-11 Thread Dzianis Kahanovich
jamal wrote: Yes, I do so. But there are simple: --- if [[ $[TC_INDEX2MARK] == 0 ]] ; then ==1 c=${c//action ipt -j MARK --set-mark /flowid :} c=${c//action ipt -j MARK --set-mark 0x/flowid :} fi $c --- I didnt quiet understand what you have above. Does your script above read the flow

Re: why does promote_secondaries default to off?

2008-01-11 Thread martin f krafft
also sprach Daniel Lezcano <[EMAIL PROTECTED]> [2008.01.11.1833 +0100]: > This tweak is "recent" (2.6.16 as far as I remember), so I suppose > the reason is to not puzzled people with a changed default > behavior. Your instant and helpful responses are most appreciated! -- martin | http://maddu

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-11 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > I notice that the vendor-supplied driver doesn't have these bugs. The M in POMS stands for "my". [...] > Would you be interested in some cleanup patches ? Yes. > In particular, I think I can get rid of tx->lock entirely, or at least > take it off

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Denys Fedoryshchenko
Maybe good idea to use sysstat ? http://perso.wanadoo.fr/sebastien.godard/ For example: visp-1 ~ # mpstat -P ALL 1 Linux 2.6.24-rc7-devel (visp-1) 01/11/08 19:27:57 CPU %user %nice%sys %iowait%irq %soft %steal %idleintr/s 19:27:58 all0.000.000.0

Re: why does promote_secondaries default to off?

2008-01-11 Thread Daniel Lezcano
martin f krafft wrote: also sprach Daniel Lezcano <[EMAIL PROTECTED]> [2008.01.11.1813 +0100]: There is a tweak in /proc/sys which activate secondaries promotion when a primary is deleted. /proc/sys/net/ipv4/conf/all/promote_secondaries I think it changes the behavior to the one you wish. T

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread Vince Fuller
On Fri, Jan 11, 2008 at 12:17:02PM +0100, Andi Kleen wrote: > Vince Fuller <[EMAIL PROTECTED]> writes: > > > from Vince Fuller <[EMAIL PROTECTED]> > > > > This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 > > (aka "class-E") address space as consistent with the Internet Draft >

why does promote_secondaries default to off? (was: iproute2: removing primary address removes secondaries)

2008-01-11 Thread martin f krafft
also sprach Daniel Lezcano <[EMAIL PROTECTED]> [2008.01.11.1813 +0100]: > There is a tweak in /proc/sys which activate secondaries promotion when a > primary is deleted. > > /proc/sys/net/ipv4/conf/all/promote_secondaries > > I think it changes the behavior to the one you wish. Totally. That woul

Simple question about LARTC theory

2008-01-11 Thread slavon
Hello all. Sorry for offtopic. I subscribe only on [EMAIL PROTECTED] try send to [EMAIL PROTECTED] and get "Undelivered Mail Returned to Sender". May i do small offtop? This maillist have many people that known lartc "in code" and i hope its help for my idea. Thanks. Simple Question Legen

Re: iproute2: removing primary address removes secondaries

2008-01-11 Thread Daniel Lezcano
martin f krafft wrote: Dear list, When I add an address to an interface whose network prefix is the same as that of an address already bound to the interface, the new address becomes a secondary address. As per http://www.policyrouting.org/iproute2.doc.html: "secondary --- this address is not

iproute2: removing primary address removes secondaries

2008-01-11 Thread martin f krafft
Dear list, When I add an address to an interface whose network prefix is the same as that of an address already bound to the interface, the new address becomes a secondary address. As per http://www.policyrouting.org/iproute2.doc.html: "secondary --- this address is not used when selecting the

Re: [PATCH 1/5] spidernet: add missing initialization

2008-01-11 Thread Linas Vepstas
Hi, On 11/01/2008, Jens Osterkamp <[EMAIL PROTECTED]> wrote: > Hi Ishizaki, > > Linas has left the company and is no longer doing kernel related stuff, > so I suggest, given Jeff is ok with that, that the two of us take over > spidernet maintainership. > > Jens > > --- > > Change maintainership fo

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Eric Dumazet
Breno Leitao a écrit : On Thu, 2008-01-10 at 12:52 -0800, Brandeburg, Jesse wrote: Breno Leitao wrote: When I run netperf in just one interface, I get 940.95 * 10^6 bits/sec of transfer rate. If I run 4 netperf against 4 different interfaces, I get around 720 * 10^6 bits/sec. I

RE: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Breno Leitao
On Thu, 2008-01-10 at 12:52 -0800, Brandeburg, Jesse wrote: > Breno Leitao wrote: > > When I run netperf in just one interface, I get 940.95 * 10^6 bits/sec > > of transfer rate. If I run 4 netperf against 4 different interfaces, I > > get around 720 * 10^6 bits/sec. > > I hope this explanation ma

Re: [PROCFS] [NETNS] issue with /proc/net entries

2008-01-11 Thread Benjamin Thery
Eric W. Biederman wrote: Benjamin Thery <[EMAIL PROTECTED]> writes: Hi Eric, While testing the current network namespace stuff merged in net-2.6.25, I bumped into the following problem with the /proc/net/ entries. It doesn't always display the actual data of the current namespace, but sometime

doubt in e1000_io_write()

2008-01-11 Thread Jeba Anandhan
Hi all, i have doubt in e1000_io_write(). void e1000_io_write(struct e1000_hw *hw, unsigned long port, uint32_t value) { outl(value, port); } kernel version: 2.6.12.3 Even hw structure has not been used, why it has been passed into e1000_io_write function? Thanks Jeba -- To unsubscri

Re: questions on NAPI processing latency and dropped network packets

2008-01-11 Thread Chris Friesen
David Miller wrote: You have to be kidding, coming here for help with a nearly 4 year old kernel. I figured it couldn't hurt to ask...if I can't ask the original authors, who else is there? I'd love to work on newer kernels, but we have a commitment to our customers to support multiple rel

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-11 Thread jamal
On Fri, 2008-11-01 at 15:24 -0200, Dzianis Kahanovich wrote: > jamal wrote: > > tc qdisc add dev XXX ingress > > tc filter add dev XXX parent : protocol ip prio 5 \ > > u32 blah bleh \ > > flowid 1:12 action ipt -j mark --set-mark 13 > > Yes, I do so. But there are simple: > --- > if [[ $[T

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-11 Thread Dzianis Kahanovich
jamal wrote: To "classid x:y" = "mark=mark&x|y" ("classid :y" = "-j MARK --set-mark y", etc). --- linux-2.6.23-gentoo-r2/net/sched/Kconfig +++ linux-2.6.23-gentoo-r2.fixed/net/sched/Kconfig @@ -222,6 +222,16 @@ [..] skb->tc_index = TC_H_MIN(res.classid); +#ifdef CONFIG

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Thu, Jan 10, 2008 at 03:51:11PM -0800, Paul E. McKenney wrote: > On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote: > > Eric Dumazet wrote, On 01/09/2008 11:37 AM: > > ... > > > [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache > > ... > > > diff --git a/net/ipv4/route.

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-11 Thread Dzianis Kahanovich
Patrick McHardy wrote: --- linux-2.6.23-gentoo-r2/net/sched/sch_ingress.c +++ linux-2.6.23-gentoo-r2.fixed/net/sched/sch_ingress.c @@ -161,2 +161,5 @@ skb->tc_index = TC_H_MIN(res.classid); +#ifdef CONFIG_NET_SCH_INGRESS_TC2MARK +skb->mark = (skb->mark&(res.classid>>16)

Re: [PATCH 1/5] spidernet: add missing initialization

2008-01-11 Thread Jens Osterkamp
On Friday 11 January 2008, Ishizaki Kou wrote: > This patch fixes initialization of "aneg_count" and "medium" fields in > spider_net_card to make spidernet driver correctly sets "link status". > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Hi Ishizaki, Linas has left the company and is no l

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 12:17:02 +0100), Andi Kleen <[EMAIL PROTECTED]> says: > Vince Fuller <[EMAIL PROTECTED]> writes: > > > from Vince Fuller <[EMAIL PROTECTED]> > > > > This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 > > (aka "class-E") addre

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Fri, Jan 11, 2008 at 09:37:42PM +1100, Herbert Xu wrote: > On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote: > > > > It looks like I'm really too lazy and/or these selfdocumenting features > > of RCU are a bit overrated: one can never be sure which pointer is > > really RCU prote

handing cloned frames to netif_rx()?

2008-01-11 Thread Johannes Berg
In 802.11n, there is a case where multiple data frames are received aggregated into a single frame (A-MSDU). Currently, we copy each of these frames out into their own skb, but because of the alignment with that etc. I started to think that we could simply pass up a clone of the original skb with

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Fri, Jan 11, 2008 at 09:38:52PM +1100, Herbert Xu wrote: > On Fri, Jan 11, 2008 at 10:11:40AM +0100, Jarek Poplawski wrote: > > > > So, IOW: strictly speaking you are right, r can't change here, but I > > meant r vs. the returned value! Before the patch the returned value > > couldn't be NULL u

rp_filter and ip rule break ipsec policy

2008-01-11 Thread Marco Berizzi
Hello everybody. AFAIK ipsec policy aren't related to routing tables: if there is an ipsec policy to deliver traffic, for example, from 192.168.0.0/16 to 10.0.0.0/8, xfrm will eat the packets ignoring the routing table. Here is the ipsec gateway schema: [-] cisco ISP router default gateway

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread Andi Kleen
Vince Fuller <[EMAIL PROTECTED]> writes: > from Vince Fuller <[EMAIL PROTECTED]> > > This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 > (aka "class-E") address space as consistent with the Internet Draft > draft-fuller-240space-00.txt. Wouldn't it be wise to at least wait for

Re: e1000 performance issue in 4 simultaneous links

2008-01-11 Thread Benny Amorsen
David Miller <[EMAIL PROTECTED]> writes: > No IRQ balancing should be done at all for networking device > interrupts, with zero exceptions. It destroys performance. Does irqbalanced need to be taught about this? And how about the initial balancing, so that each network card gets assigned to one

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Herbert Xu
On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote: > > It looks like I'm really too lazy and/or these selfdocumenting features > of RCU are a bit overrated: one can never be sure which pointer is > really RCU protected without checking a few places?! So, after looking > at this rt_ca

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Herbert Xu
On Fri, Jan 11, 2008 at 10:11:40AM +0100, Jarek Poplawski wrote: > > So, IOW: strictly speaking you are right, r can't change here, but I > meant r vs. the returned value! Before the patch the returned value > couldn't be NULL unless all elements of the list were looped. After > this patch it seem

Improving performance of bonding driver (eql) using round robin alogrithm

2008-01-11 Thread Jeba Anandhan
Hi All, The existing algorithm works in eql bonding driver works based on priority of each slaves. The priority has been assigned as speed of the particular line. The current problem is, all the slaves didn't get the chance as best slave for the transmission. Will the round robin algorithm for se

Re: virtio_net and SMP guests

2008-01-11 Thread Rusty Russell
On Friday 11 January 2008 02:51:58 Christian Borntraeger wrote: > What about the following patch: Looks correct and in fact pretty orthodox. I've folded this in, thanks! Rusty. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH][ROSE][AX25] af_ax25: possible circular locking

2008-01-11 Thread Jarek Poplawski
On Thu, Jan 10, 2008 at 09:22:42PM -0800, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Sun, 30 Dec 2007 15:13:23 +0100 > > > On Sat, Dec 29, 2007 at 07:14:43PM -0800, David Miller wrote: ... > I've removed the warning and made the branch back to 'again' > unconditional a

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-11 Thread Zhang, Yanmin
On Wed, 2008-01-09 at 17:35 +0800, Zhang, Yanmin wrote: > The regression is: > 1)stoakley with 2 qual-core processors: 11%; > 2)Tulsa with 4 dual-core(+hyperThread) processors:13%; I have new update on this issue and also cc to netdev maillist. Thank David Miller for pointing me the netdev maillis

Re: [klibc] [patch] import socket defines

2008-01-11 Thread Mike Frysinger
On Friday 11 January 2008, Mike Frysinger wrote: > On Friday 11 January 2008, H. Peter Anvin wrote: > > Again, I don't particularly care about what they're named, but the whole > > point is > > > > #include > > > > if you want the subset and > > > > #include > > > > if you want the whole

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Fri, Jan 11, 2008 at 10:11:40AM +0100, Jarek Poplawski wrote: ... > So, IOW: strictly speaking you are right, r can't change here, but I > meant r vs. the returned value! Before the patch the returned value > couldn't be NULL unless all elements of the list were looped. After ...even more stric

Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)

2008-01-11 Thread Christoph Hellwig
On Thu, Jan 10, 2008 at 03:32:28PM -0800, Kok, Auke wrote: > - cleaned up largely against sparse, checkpatch largely means not completely, right? Please make sure there's no sparse warnings left at least. checkpatch is not that criticial, but it would be good to have an explanation for everythin

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote: > On Fri, Jan 11, 2008 at 11:00:20AM +1100, Herbert Xu wrote: > > On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote: > > > > > > It seems this optimization could've a side effect: if during such a > > > loop updates are

Re: [klibc] [patch] import socket defines

2008-01-11 Thread Mike Frysinger
On Friday 11 January 2008, H. Peter Anvin wrote: > Mike Frysinger wrote: > >> all this stuff is ABI constants, and the only reason glibc > >> doesn't use them is that glibc prefers to use enums over #defines. > > > > a proper libc defines things in their headers according to the POSIX > > specs rat

Re: HTB classify perfomance

2008-01-11 Thread Badalian Vyacheslav
New info. Wait some time and reset oprifile statistic (i think info abount ipt_unregister_table its get what run some script... ). That clear info after add FILTER: First PC CPU: P4 / Xeon, speed 3409.96 MHz (estimated) Counted GLOBAL_POWER_EVENTS events (time during which processor is not stop

HTB classify perfomance

2008-01-11 Thread Badalian Vyacheslav
Hello all. I N days try to tune system for best performance and see strange thing. Have N htb classes root class is HTB. param: default 7 (if not classify - go to 1:7) filters classify only mached ip. others go to HTB DEFAULT rule. run oprofile: First pc (htb and iptables compile in kernel): CP

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-11 Thread Jarek Poplawski
On Fri, Jan 11, 2008 at 11:00:20AM +1100, Herbert Xu wrote: > On Fri, Jan 11, 2008 at 12:10:42AM +0100, Jarek Poplawski wrote: > > > > It seems this optimization could've a side effect: if during such a > > loop updates are done, and r is seen !NULL during while() check, but > > NULL after rcu_dere

Re: [klibc] [patch] import socket defines

2008-01-11 Thread H. Peter Anvin
Mike Frysinger wrote: all this stuff is ABI constants, and the only reason glibc doesn't use them is that glibc prefers to use enums over #defines. a proper libc defines things in their headers according to the POSIX specs rather than relying on others to do it for them. if you want to argue