Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Tom Herbert
On Thu, May 28, 2015 at 2:44 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote: @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { }, { .key_id =

[PATCH net-next 0/2] hv_netvsc: Implement NUMA aware memory allocation

2015-05-28 Thread K. Y. Srinivasan
Allocate both receive buffer and send buffer from the NUMA node assigned to the primary channel. K. Y. Srinivasan (2): hv_netvsc: Allocate the receive buffer from the correct NUMA node hv_netvsc: Allocate the sendbuf in a NUMA aware way drivers/net/hyperv/netvsc.c | 11 +-- 1

[PATCH V2 net-next 1/2] hv_netvsc: Allocate the receive buffer from the correct NUMA node

2015-05-28 Thread K. Y. Srinivasan
Allocate the receive bufer from the NUMA node assigned to the primary channel. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- V2: Specify the tree for this patch. drivers/net/hyperv/netvsc.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[PATCH net-next 2/2] hv_netvsc: Allocate the sendbuf in a NUMA aware way

2015-05-28 Thread K. Y. Srinivasan
Allocate the send buffer in a NUMA aware way. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/netvsc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index d187965..06de98a 100644 ---

Re: iproute2: missing patches in branch net-next

2015-05-28 Thread Stephen Hemminger
On Thu, 28 May 2015 18:32:32 +0200 Daniel Borkmann dan...@iogearbox.net wrote: On 05/28/2015 06:19 PM, Stephen Hemminger wrote: On Thu, 28 May 2015 13:31:08 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Hi Stephen, some patches that were recently included in iproute2 branch

Re: iproute2: missing patches in branch net-next

2015-05-28 Thread Daniel Borkmann
On 05/29/2015 01:12 AM, Stephen Hemminger wrote: ... I will go back and recreate what is missing. Sorry for the confusion. Great thanks, no problem. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 6/9] ssb: drop unneeded goto

2015-05-28 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier l; @@ -if (...) goto l; -l: // /smpl

[RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-28 Thread Vivien Didelot
This patch adds the ndo_vlan_rx_add_vid, ndo_vlan_rx_kill_vid, and ndo_bridge_setlink wrapper operations, used to create and remove VLAN entries in a DSA switch VLAN database. The switch drivers have to implement the port_vlan_add, port_vlan_kill, and port_bridge_setlink functions, in order to

[RFC 2/3] net: dsa: mv88e6xxx: add support for VTU operations

2015-05-28 Thread Vivien Didelot
This commit implements the port_vlan_add, port_vlan_kill, and port_bridge_setlink dsa_switch_driver functions to access the VTU, and thus add support for adding, removing VLANs, and joining ports to them. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com ---

[PATCH 1/1] hv_netvsc: Allocate the receive buffer from the correct NUMA node

2015-05-28 Thread K. Y. Srinivasan
Allocate the receive bufer from the NUMA node assigned to the primary channel. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/netvsc.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH net 3/3] bna: fix soft lock-up during firmware initialization failure

2015-05-28 Thread Ivan Vecera
Bug in the driver initialization causes soft-lockup if firmware initialization timeout is reached. Polling function bfa_ioc_poll_fwinit() incorrectly calls bfa_nw_iocpf_timeout() when the timeout is reached. The problem is that bfa_nw_iocpf_timeout() calls again bfa_ioc_poll_fwinit()... etc. The

[PATCH net 2/3] bna: remove unreasonable iocpf timer start

2015-05-28 Thread Ivan Vecera
Driver starts iocpf timer prior bnad_ioceth_enable() call and this is unreasonable. This piece of code probably originates from Brocade/Qlogic out-of-box driver during initial import into upstream. This driver uses only one timer and queue to implement multiple timers and this timer is started at

[RFC 3/3] net: dsa: mv88e6352: add support for VLAN

2015-05-28 Thread Vivien Didelot
This commit adds support for the VTU operations to the mv88e6352 driver. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6352.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c index

[RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-05-28 Thread Vivien Didelot
This RFC is based on v4.1-rc3. It is meant to get a glance to the commits responsible to implement the necessary NDOs between DSA and the Marvell 88E6352 switch driver. With this support, I am able to create VLANs with (un)tagged ports, setting their default VID, from a bridge. To create a

RE: [PATCH 1/1] hv_netvsc: Allocate the receive buffer from the correct NUMA node

2015-05-28 Thread KY Srinivasan
-Original Message- From: K. Y. Srinivasan [mailto:k...@microsoft.com] Sent: Thursday, May 28, 2015 2:56 PM To: da...@davemloft.net; netdev@vger.kernel.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Cc: KY

[PATCH 5/9] wl1251: drop unneeded goto

2015-05-28 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier l; @@ -if (...) goto l; -l: // /smpl

Re: Possible issue in iproute2 package

2015-05-28 Thread Daniel Borkmann
Hi Jose, thanks for your report! On 05/28/2015 11:12 PM, Guzman Mosqueda, Jose R wrote: ... We're using iproute2 in a GNU-Linux project and I'm analyzing the code to try to find possible issues/gaps/risks. Since I'm not too familiar with the package yet I have a question about a particular

[PATCH net-next 0/3] net: systemport: misc improvements

2015-05-28 Thread Florian Fainelli
Hi David, These patches are highly inspired by changes from Petri on bcmgenet, last patch is a misc fix that I had pending for a while, but is not a candidate for 'net' at this point. Thanks! Florian Fainelli (3): net: systemport: Pre-calculate and utilize cb-bd_addr net: systemport:

RE: Request for advice on where to put Root Complex fix up code for downstream device

2015-05-28 Thread Casey Leedom
| From: Casey Leedom [lee...@chelsio.com] | Sent: Thursday, May 07, 2015 4:31 PM | | | From: Bjorn Helgaas [bhelg...@google.com] | | Sent: Thursday, May 07, 2015 4:04 PM | | | | There are a lot of fixups in drivers/pci/quirks.c. For things that have to | | be worked around either before a driver

[PATCH 2/9] ipv6: drop unneeded goto

2015-05-28 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier l; @@ -if (...) goto l; -l: // /smpl

Possible issue in iproute2 package

2015-05-28 Thread Guzman Mosqueda, Jose R
Hi all I'm Jose Guzman from a security team at Intel. We're using iproute2 in a GNU-Linux project and I'm analyzing the code to try to find possible issues/gaps/risks. Since I'm not too familiar with the package yet I have a question about a particular piece of code that could result in a memory

[PATCH 0/9] drop unneeded goto

2015-05-28 Thread Julia Lawall
These patches drop gotos that jump to a label that is at the next instruction, in the case that the label is not used elsewhere in the function. The complete semantic patch that performs this transformation is as follows: // smpl @r@ position p; identifier l; @@ if (...) goto l@p; l:

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 14:35 -0700, David Miller wrote: Bogus chunk in my local tree, didn't make it into the final commit I pushed out. Thanks for taking care of this before me ! -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread Andy Gospodarek
On Thu, May 28, 2015 at 08:40:11AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 28 May 2015 11:51:15 -0700 On Thu, 2015-05-28 at 11:42 -0700, David Miller wrote: I've applied the following to net-next, thanks for your report. [PATCH] treewide: Add missing vmalloc.h inclusion. All of these files were

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote: @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { }, { .key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS, - .offset = offsetof(struct flow_keys, addrs), +

[PATCH net-next 1/3] net: systemport: Pre-calculate and utilize cb-bd_addr

2015-05-28 Thread Florian Fainelli
There is a 1:1 mapping between the software maintained control block in priv-rx_cbs and the buffer address in priv-rx_bds, such that there is no need to keep computing the buffer address when refiling a control block. Signed-off-by: Florian Fainelli f.faine...@gmail.com ---

[PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Florian Fainelli
Currently, bcm_sysport_desc_rx() calls bcm_sysport_rx_refill() at the end of Rx packet processing loop, after the current Rx packet has already been passed to napi_gro_receive(). However, bcm_sysport_rx_refill() might fail to allocate a new Rx skb, thus leaving a hole on the Rx queue where no

[PATCH net-next 3/3] net: systemport: Add a check for oversized packets

2015-05-28 Thread Florian Fainelli
Occasionnaly we may get oversized packets from the hardware which exceed the nomimal 2KiB buffer size we allocate SKBs with. Add an early check which drops the packet to avoid invoking skb_over_panic() and move on to processing the next packet. Signed-off-by: Florian Fainelli f.faine...@gmail.com

[PATCH net 0/3] bna: misc bugfixes

2015-05-28 Thread Ivan Vecera
These patches fix several bugs found during device initialization debugging. Cc: Rasesh Mody rasesh.m...@qlogic.com Ivan Vecera (3): bna: fix firmware loading on big-endian machines bna: remove unreasonable iocpf timer start bna: fix soft lock-up during firmware initialization failure

[PATCH net 1/3] bna: fix firmware loading on big-endian machines

2015-05-28 Thread Ivan Vecera
Firmware required by bna is stored in appropriate files as sequence of LE32 integers. After loading by request_firmware() they need to be byte-swapped on big-endian arches. Without this conversion the NIC is unusable on big-endian machines. Cc: Rasesh Mody rasesh.m...@qlogic.com Signed-off-by:

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Doug Ledford
On Thu, 2015-05-28 at 22:05 +0300, Or Gerlitz wrote: On Thu, May 28, 2015 at 9:22 PM, Doug Ledford dledf...@redhat.com wrote: I don't think that is what Doug said. Indeed. There is no need to scrap things, but if the design as it stands, and the intended means of creating objects for

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 12:33 -0400, jsulli...@opensourcedevel.com wrote: Our initial testing has been single flow but the ultimate purpose is processing real time video in a complex application which ingests associated meta data, post to consumer facing cloud, does reporting back - so lots of

Connection tracking and soft lockups with certain field values

2015-05-28 Thread Andrey Korolyov
Hi, I am currently playing with SYNPROXY target to optimize SYN filtering performance and by occasion found that TCP SYN packets containing port 0 can result in a soft lockup when conntrack is enabled just by itself, given high packet ratio (I`ve reached 450kpps so far with 60b packets on a

Re: [PATCH net-next 4/4] net/mlx4_core: Make sure there are no pending async events when freeing CQ

2015-05-28 Thread Sergei Shtylyov
Hello. On 05/28/2015 06:41 PM, Or Gerlitz wrote: From: Matan Barak mat...@mellanox.com When freeing a CQ, we need to make sure there are no asynchronous events (on the ASYNC EQ) that could relate to this CQ before freeing it. This is done by introducing synchronize_irq. Signed-off-by:

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-28 Thread Alexander Duyck
On 05/28/2015 01:40 AM, Steffen Klassert wrote: On Thu, May 28, 2015 at 12:18:51AM -0700, Alexander Duyck wrote: On 05/27/2015 10:36 PM, Steffen Klassert wrote: On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: This change makes it so that we use icmpv6_send to report PMTU

[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src

[PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-28 Thread Tom Herbert
In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash. Signed-off-by: Tom Herbert t...@herbertland.com ---

[PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

2015-05-28 Thread Tom Herbert
key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Tom Herbert t...@herbertland.com --- net/core/flow_dissector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/core/flow_dissector.c

[PATCH v4 net-next 00/11] net: Increase inputs to flow_keys hashing

2015-05-28 Thread Tom Herbert
This patch set adds new fields to the flow_keys structure and hashes over these fields to get a better flow hash. In particular, these patches now include hashing over the full IPv6 addresses in order to defend against address spoofing that always results in the same hash. The new input also

[PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS

2015-05-28 Thread Tom Herbert
Add uapi define for MPLS over IP. Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Tom Herbert t...@herbertland.com --- include/uapi/linux/in.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/in.h b/include/uapi/linux/in.h index 589ced0..641338b 100644 ---

[PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure

2015-05-28 Thread Tom Herbert
This patch changes flow hashing to use jhash2 over the flow_keys structure instead just doing jhash_3words over src, dst, and ports. This method will allow us take more input into the hashing function so that we can include full IPv6 addresses, VLAN, flow labels etc. without needing to resort to

[PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-05-28 Thread Tom Herbert
Do break when we see routing flag or a non-zero version number in GRE header. Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Tom Herbert t...@herbertland.com --- net/core/flow_dissector.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-)

[PATCH v4 net-next 10/11] net: Add GRE keyid in flow_keys

2015-05-28 Thread Tom Herbert
In flow dissector if a GRE header contains a keyid this is saved in the new keyid field of flow_keys. The GRE keyid is then represented in the flow hash function input. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 24

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread David Miller
From: Stephen Rothwell s...@canb.auug.org.au Date: Thu, 28 May 2015 22:06:07 +1000 Ouch :-( The only thing I will say on this matter is that the _only_ way this problem will go away is if someone does the work necessary to get rid of that implicit vmalloc.h include that happens on all x86

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Joe Perches
On Thu, 2015-05-28 at 11:42 -0700, David Miller wrote: I've applied the following to net-next, thanks for your report. [PATCH] treewide: Add missing vmalloc.h inclusion. All of these files were only building on non-x86 because of the indirect of inclusion of vmalloc.h

Re: [PATCH net-next] bpf: allow BPF programs access skb-skb_iif and skb-dev-ifindex fields

2015-05-28 Thread Daniel Borkmann
On 05/28/2015 12:30 AM, Alexei Starovoitov wrote: classic BPF already exposes skb-dev-ifindex via SKF_AD_IFINDEX extension. Allow eBPF program to access it as well. Note that classic aborts execution of the program if 'skb-dev == NULL' (which is inconvenient for program writers), whereas eBPF

[PATCH net-next V5 10/11] net/mlx5: Ethernet resource handling files

2015-05-28 Thread Amir Vadai
This patch contains the resource handling files: - flow_table.c: This file contains the code to handle the low level API to configure hardware flow table. It is separated from the flow_table_en.c, because it will be used in the future by Raw Ethernet

[PATCH net-next V5 05/11] net/mlx5_core: Implement access functions of ptys register fields

2015-05-28 Thread Amir Vadai
From: Saeed Mahameed sae...@mellanox.com Those registers will be used by the ethtool to set/get settings. Signed-off-by: Rana Shahout ra...@mellanox.com Signed-off-by: Saeed Mahameed sae...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com ---

[PATCH net-next V5 01/11] net/mlx5_core,mlx5_ib: Do not use vmap() on coherent memory

2015-05-28 Thread Amir Vadai
As David Daney pointed in mlx4_core driver [1], mlx5_core is also misusing the DMA-API. This patch is removing the code that vmap() memory allocated by dma_alloc_coherent(). After this patch, users of this drivers might fail allocating resources on memory fragmeneted systems. This will be fixed

[PATCH net-next V5 07/11] net/mlx5_core: Modify CQ moderation parameters

2015-05-28 Thread Amir Vadai
From: Rana Shahout ra...@mellanox.com Introduce mlx5_core_modify_cq_moderation() to be used by the netdev, to set hardware coalescing. Signed-off-by: Rana Shahout ra...@mellanox.com Signed-off-by: Saeed Mahameed sae...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com ---

[PATCH net-next V5 04/11] net/mlx5_core: New device capabilities handling

2015-05-28 Thread Amir Vadai
From: Saeed Mahameed sae...@mellanox.com - Query all supported types of dev caps on driver load. - Store the Cap data outbox per cap type into driver private data. - Introduce new Macros to access/dump stored caps (using the auto generated data types). - Obsolete SW representation of dev caps

[PATCH net-next V5 11/11] net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality

2015-05-28 Thread Amir Vadai
This is the Ethernet part of the driver for the Mellanox ConnectX(R)-4 Single/Dual-Port Adapter supporting 100Gb/s with VPI. The driver extends the existing mlx5 driver with Ethernet functionality. This patch contains the driver entry points but does not include transmit and receive (see the

[PATCH net-next V5 06/11] net/mlx5_core: Implement get/set port status

2015-05-28 Thread Amir Vadai
From: Rana Shahout ra...@mellanox.com Implemet get/set port status low level functions to be exposed by the netdev. Signed-off-by: Rana Shahout ra...@mellanox.com Signed-off-by: Saeed Mahameed sae...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com ---

[PATCH net-next V5 08/11] net/mlx5_core: Set/Query port MTU commands

2015-05-28 Thread Amir Vadai
From: Saeed Mahameed sae...@mellanox.com Introduce set/Query low level functions to access MTU in hardware. To be used by the netdev. Signed-off-by: Saeed Mahameed sae...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 53

[PATCH net-next V5 09/11] net/mlx5: Ethernet Datapath files

2015-05-28 Thread Amir Vadai
en_[rt]x.c contains the data path related code specific to tx or rx. en_txrx.c contains data path code which is common for both the rx and tx, this is mainly napi related code. Below are the objects that are being used by the hardware and the driver in the data path: Channel - one channel per

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-28 Thread Jesse Gross
On Wed, May 27, 2015 at 10:57 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, May 27, 2015 at 9:16 PM, Jesse Gross je...@nicira.com wrote: On Wed, May 27, 2015 at 7:46 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, May 27, 2015 at 2:10 PM, Jesse Gross je...@nicira.com wrote: On Fri,

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
On May 28, 2015 at 1:17 PM Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-05-28 at 12:33 -0400, jsulli...@opensourcedevel.com wrote: Our initial testing has been single flow but the ultimate purpose is processing real time video in a complex application which ingests

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Jason Gunthorpe
On Thu, May 28, 2015 at 07:21:11PM +0300, Or Gerlitz wrote: Anything else except for that (you said reworking of the network scripts and NetworkManager assumptions to make it work)?? IPv6 becomes very broken, child interfaces will generate the same IPv6 addreses for radv and link local

[PATCH v4 net-next 08/11] net: Add VLAN ID to flow_keys

2015-05-28 Thread Tom Herbert
In flow_dissector set vlan_id in flow_keys when VLAN is found. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/net/flow_dissector.h

[PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys

2015-05-28 Thread Tom Herbert
We don't need to return the IPv6 address hash as part of flow keys. In general, using the IPv6 address hash is risky in a hash value since the underlying use of xor provides no entropy. If someone really needs the hash value they can get it from the full IPv6 addresses in flow keys (e.g. from

[PATCH v4 net-next 06/11] net: Add keys for TIPC address

2015-05-28 Thread Tom Herbert
Add a new flow key for TIPC addresses. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/flow_dissector.h | 10 ++ net/core/flow_dissector.c| 18 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/include/net/flow_dissector.h

[PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys

2015-05-28 Thread Tom Herbert
In flow dissector if an MPLS header contains an entropy label this is saved in the new keyid field of flow_keys. The entropy label is then represented in the flow hash function input. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/flow_dissector.h | 1 +

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Doug Ledford
On Thu, 2015-05-28 at 11:43 -0600, Jason Gunthorpe wrote: On Thu, May 28, 2015 at 07:21:11PM +0300, Or Gerlitz wrote: Anything else except for that (you said reworking of the network scripts and NetworkManager assumptions to make it work)?? IPv6 becomes very broken, child interfaces will

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-05-28 Thread Or Gerlitz
On Thu, May 28, 2015 at 9:22 PM, Doug Ledford dledf...@redhat.com wrote: I don't think that is what Doug said. Indeed. There is no need to scrap things, but if the design as it stands, and the intended means of creating objects for use in containers, is going to result in an unworkable

[PATCH net-next V5 02/11] net/mlx5_core: Set irq affinity hints

2015-05-28 Thread Amir Vadai
From: Saeed Mahameed sae...@mellanox.com Preparation for upcoming ethernet driver. - Move msix array from eq_table struct to priv since its not related to eq_table - Intorduce irq_info struct to hold all irq information - Move name from mlx5_eq to irq_info struct since it is irq property. - Set

[PATCH net-next V5 00/11] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-28 Thread Amir Vadai
Hi Dave, This patchset extends the mlx5_core driver to support Ethernet functionality. The Ethernet functionality in the mlx5 driver is integrated into the core driver and not as separated driver. The IB functionality remains in the mlx5_ib driver as before. This functionality will enable the

RE: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Rajesh Borundia
-Original Message- From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com [mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On Behalf Of Vladimir Zapolskiy Sent: Tuesday, May 26, 2015 6:20 AM To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev Cc: netdev Subject:

Re: Drops in qdisc on ifb interface

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 13:31 -0400, jsulli...@opensourcedevel.com wrote: The overall product does but the video source feeds come over a different network via UDP. There are, however, RTMP quality control feeds coming across this connection. There may also occasionally be test UDP source feeds

Re: Drops in qdisc on ifb interface

2015-05-28 Thread jsulli...@opensourcedevel.com
On May 28, 2015 at 1:49 PM Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-05-28 at 13:31 -0400, jsulli...@opensourcedevel.com wrote: The overall product does but the video source feeds come over a different network via UDP. There are, however, RTMP quality control feeds coming

[PATCH 4/4] netfilter: nf_tables: add netdev table to filter from ingress

2015-05-28 Thread Pablo Neira Ayuso
This allows us to create netdev tables that contain ingress chains. Use skb_header_pointer() as we may see shared sk_buffs at this stage. This change provides access to the existing nf_tables features from the ingress hook. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org ---

Re: [PATCH v2] README: clarify redistribution requirements covering patents

2015-05-28 Thread Luis R. Rodriguez
On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: This v2 just changes licence to license as requested by Arend. Please let me know if there is anything else needed. Luis -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[PATCH v2] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread Wang Long
Remove automatic variable 'err' in register_netevent_notifier() and return the result of atomic_notifier_chain_register() directly. Signed-off-by: Wang Long long.wangl...@huawei.com --- net/core/netevent.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 2/7] net: dsa: ar8xxx: add ethtool hw statistics support

2015-05-28 Thread Mathieu Olivari
MIB counters can now be reported through each switch port by using ethtool -S. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- drivers/net/dsa/ar8xxx.c | 106 +++ drivers/net/dsa/ar8xxx.h | 47 + 2 files changed, 146

[PATCH 6/7] net: dsa: ar8xxx: add support for second xMII interfaces through DT

2015-05-28 Thread Mathieu Olivari
This patch is adding support for port6 specific options to device tree. They can be used to setup the second xMII interface, and connect it to one of the switch port. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- drivers/net/dsa/ar8xxx.c | 50

[PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Mathieu Olivari
All switch registers can now be dumped using regmap/debugfs. \# cat /sys/kernel/debug/regmap/mdiobus/registers : 1302 0004: ... ... Signed-off-by: Mathieu Olivari math...@codeaurora.org --- drivers/net/dsa/Kconfig | 1 + drivers/net/dsa/ar8xxx.c | 60

[PATCH 7/7] Documentation: devicetree: add ar8xxx binding

2015-05-28 Thread Mathieu Olivari
Add device-tree binding for ar8xxx switch families. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- .../devicetree/bindings/net/dsa/qca-ar8xxx.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644

[PATCH 4/7] net: dsa: add QCA tag support

2015-05-28 Thread Mathieu Olivari
QCA tags are used on QCA ar8xxx switch family. This change adds support for encap/decap using 2 bytes header mode. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- include/net/dsa.h | 1 + net/dsa/Kconfig| 3 + net/dsa/Makefile | 1 + net/dsa/dsa.c | 5 ++

[PATCH 1/7] net: dsa: add new driver for ar8xxx family

2015-05-28 Thread Mathieu Olivari
This patch contains initial init registration code for QCA8337. It will detect a QCA8337 switch, if present and declared in DT/platform. Each port will be represented through a standalone net_device interface, as for other DSA switches. CPU can communicate with any of the ports by setting an IP@

Re: [PATCH] namespace: Remove no longer needed goto label in the function, ops_init

2015-05-28 Thread Eric W. Biederman
Nicholas Krause xerofo...@gmail.com writes: This removes the no longer needed goto label, cleanup in the function ops_init due to kfree being NULL pointer safe and therefore no need to avoid calling it the call to kzalloc fails inside this particular function. Your proposed change pessimizes

Re: linux-next: build failure after merge of most of the trees

2015-05-28 Thread Stephen Rothwell
Hi Eric, On Thu, 28 May 2015 08:26:51 -0700 Eric Dumazet eric.duma...@gmail.com wrote: We were alerted of this problem thanks to kbuild test robot. This fix is not a definitive one I hope. No, just something to allow me to get my tree to build so I could go to bed :-) Golden rule is that

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote: In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash.

Re: pull request (net-next): ipsec-next 2015-05-28

2015-05-28 Thread David Miller
From: Steffen Klassert steffen.klass...@secunet.com Date: Thu, 28 May 2015 08:25:47 +0200 1) Remove xfrm_queue_purge as this is the same as skb_queue_purge. 2) Optimize policy and state walk. 3) Use a sane return code if afinfo registration fails. 4) Only check fori a acquire state if

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code is arguable, but it is already used in the driver, so

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread Vladimir Zapolskiy
Hello David, On 29.05.2015 02:28, David Miller wrote: From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Ying Xue
On 05/28/2015 06:13 PM, Eric Dumazet wrote: This patch is not needed. You really should read Documentation/RCU , because it looks like you are quite confused. When we remove an element from a RCU protected list, all the objects in the chain are already ready to be caught by rcu readers.

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : All switch registers can now be dumped using regmap/debugfs. \# cat /sys/kernel/debug/regmap/mdiobus/registers : 1302 0004: ... ... ethtool has a register dump command, which should already be supported by the current code in

Re: [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support

2015-05-28 Thread Andrew Lunn
On Thu, May 28, 2015 at 06:42:15PM -0700, Mathieu Olivari wrote: This patch set adds initial support for AR8xxx switches using the DSA subsystem. It currently supports QCA8337 switch, and can be extended to other hardware in the same family. This switch was already discussed in the following

Re: [PATCH 1/7] net: dsa: add new driver for ar8xxx family

2015-05-28 Thread Andrew Lunn
+static int ar8xxx_set_pad_ctrl(struct dsa_switch *ds, int port, int mode) +{ + int reg; + + switch (port) { + case 0: + reg = AR8327_REG_PORT0_PAD_CTRL; + break; + case 6: + reg = AR8327_REG_PORT6_PAD_CTRL; + break; +

[PATCH net-next] bpf: add missing rcu protection when releasing programs from prog_array

2015-05-28 Thread Alexei Starovoitov
Normally the program attachment place (like sockets, qdiscs) takes care of rcu protection and calls bpf_prog_put() after a grace period. The programs stored inside prog_array may not be attached anywhere, so prog_array needs to take care of preserving rcu protection. Otherwise bpf_tail_call() will

Re: [PATCH] net: qlcnic: clean up sysfs error codes

2015-05-28 Thread David Miller
From: Vladimir Zapolskiy v...@mleia.com Date: Fri, 29 May 2015 04:13:46 +0300 Hello David, On 29.05.2015 02:28, David Miller wrote: From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and

Re: [PATCH net-next 1/3] net: systemport: Pre-calculate and utilize cb-bd_addr

2015-05-28 Thread Petri Gynther
On Thu, May 28, 2015 at 3:24 PM, Florian Fainelli f.faine...@gmail.com wrote: There is a 1:1 mapping between the software maintained control block in priv-rx_cbs and the buffer address in priv-rx_bds, such that there is no need to keep computing the buffer address when refiling a control

Re: [PATCH net v2] openvswitch: disable LRO

2015-05-28 Thread Pravin Shelar
On Thu, May 28, 2015 at 6:04 AM, Jiri Benc jb...@redhat.com wrote: Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the

Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

2015-05-28 Thread Eric Dumazet
On Fri, 2015-05-29 at 09:21 +0800, Ying Xue wrote: On 05/28/2015 06:13 PM, Eric Dumazet wrote: This patch is not needed. You really should read Documentation/RCU , because it looks like you are quite confused. When we remove an element from a RCU protected list, all the objects in

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Andrew Lunn
Fair enough, are there other global things besides counters that could deserve adding maybe some sort of global/master net_device to help query switch-wide information? This was discussed a while back. I like the current abstraction, all interfaces are real interfaces you can send and receive

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread long.wanglong
On 2015/5/28 22:07, Sergei Shtylyov wrote: Hello. On 5/28/2015 1:00 PM, Wang Long wrote: Remove automatic variable 'err' in register_netevent_notifier() and return the return value of atomic_notifier_chain_register() directly. s/return value/result/, in order to avoid tautology.

[PATCH 0/7] net: dsa: add QCA AR8xxx switch family support

2015-05-28 Thread Mathieu Olivari
This patch set adds initial support for AR8xxx switches using the DSA subsystem. It currently supports QCA8337 switch, and can be extended to other hardware in the same family. This switch was already discussed in the following thread: https://www.marc.info/?t=14260141744r=1w=2 Below is a

Re: [PATCH 7/7] Documentation: devicetree: add ar8xxx binding

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : Add device-tree binding for ar8xxx switch families. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- .../devicetree/bindings/net/dsa/qca-ar8xxx.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644

Re: [V5 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object

2015-05-28 Thread Mark Salter
On Wed, 2015-05-20 at 17:09 -0500, Suravee Suthikulpanit wrote: From http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf, section 6.2.17 _CCA states that ARM platforms require ACPI _CCA object to be specified for DMA-cabpable devices. Therefore, this patch specifies

[PATCH 0/4] Netfilter updates for net-next

2015-05-28 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter updates for net-next, they are: 1) default CONFIG_NETFILTER_INGRESS to y for easier compile-testing of all options. 2) Allow to bind a table to net_device. This introduces the internal NFT_AF_NEEDS_DEV flag to perform a mandatory check

  1   2   3   >