[PATCH net-next] MAINTAINERS: Add VRF entry

2015-08-25 Thread David Ahern
Add entry for new VRF device driver. Signed-off-by: David Ahern d...@cumulusnetworks.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7b528b8c73f8..65d3b389c5c0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11063,6 +11063,14 @@ S:

WARNING at net/ipv4/netfilter/ip_tables.c:530

2015-08-25 Thread Cong Wang
Hi, Florian Your commit 98d1bd802cdbc8f56868fae51edec13e86b59515 (netfilter: xtables: compute exact size needed for jumpstack) introduced the following kernel warning during boot. It looks like the if check inside mark_source_chains() isn't correct, this causes calldepth not increased as

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread Thomas Graf
On 08/23/15 at 08:01pm, David Ahern wrote: On 8/23/15 6:15 PM, Thomas Graf wrote: On 08/23/15 at 08:26am, David Ahern wrote: inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry. Similar to IP fragments handle duplicate addresses

[PATCH net-next v2 0/2] Documentation: dsa

2015-08-25 Thread Florian Fainelli
Hi all, This patch series adds some documentation about DSA as a subsystem as well as the SF2 driver since it slightly diverges from your average DSA driver ;) Florian Fainelli (2): Documentation: networking: add a DSA document Documentation: networking: dsa: Add Broadcom SF2 document

[PATCH net-next v2 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Florian Fainelli
Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch driver. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Changes in v2: - fixing incomplete sentence in the SWITCHDEV paragraph - fix spelling mistakes spotted

[PATCH net-next v2 2/2] Documentation: networking: dsa: Add Broadcom SF2 document

2015-08-25 Thread Florian Fainelli
Add a document describing the Broadcom Starfigther 2 switch hardware, its specifics, and how the driver is implemented and its specifics. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Documentation/networking/dsa/bcm_sf2.txt | 113 +++ 1 file changed, 113

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Thomas Graf
On 08/25/15 at 09:50am, Jesse Gross wrote: On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar pshe...@nicira.com wrote: Moving this device means moving all tunnels backed by this device rather than specific tunnel device. Thats why it does not look right to move such device. I agree it seems

Re: [PATCH v3 net-next 6/8] openvswitch: Use Geneve device.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: With help of tunnel metadata mode OVS can directly use Geneve devices to implement Geneve tunnels. This patch removes all of the OVS specific Geneve code and make OVS use a Geneve net_device. Basic geneve vport is still there to handle

Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-25 Thread Eric Dumazet
On Tue, 2015-08-25 at 21:17 +0530, Raghavendra K T wrote: On 08/25/2015 07:58 PM, Eric Dumazet wrote: This is a great idea, but kcalloc()/kmalloc() can fail and you'll crash the whole kernel at this point. Good catch, and my bad. Though system is in bad memory condition, since

Re: [PATCH net-next 09/13] vxlan: provide access function for vxlan socket address family

2015-08-25 Thread Jiri Benc
On Tue, 25 Aug 2015 00:34:18 +, Rustad, Mark D wrote: --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -241,3 +241,8 @@ static inline void vxlan_get_rx_port(struct net_device *netdev) } #endif #endif + +static inline unsigned short vxlan_get_sk_family(struct vxlan_sock

[PATCH net-next] vxlan: fix multiple inclusion of vxlan.h

2015-08-25 Thread Jiri Benc
The vxlan_get_sk_family inline function was added after the last #endif, making multiple inclusion of net/vxlan.h fail. Move it to the proper place. Reported-by: Mark Rustad mark.d.rus...@intel.com Fixes: 705cc62f6728c (vxlan: provide access function for vxlan socket address family)

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Jesse Gross
On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar pshe...@nicira.com wrote: On Mon, Aug 24, 2015 at 6:42 PM, Jesse Gross je...@nicira.com wrote: On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index

Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-25 Thread Raghavendra K T
On 08/25/2015 07:58 PM, Eric Dumazet wrote: On Tue, 2015-08-25 at 13:24 +0530, Raghavendra K T wrote: Docker container creation linearly increased from around 1.6 sec to 7.5 sec (at 1000 containers) and perf data showed 50% ovehead in snmp_fold_field. reason: currently __snmp6_fill_stats64

Re: [PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus

2015-08-25 Thread Raghavendra K T
On 08/25/2015 08:03 PM, Eric Dumazet wrote: On Tue, 2015-08-25 at 13:24 +0530, Raghavendra K T wrote: While creating 1000 containers, perf is showing lot of time spent in snmp_fold_field on a large cpu system. The current patch tries to improve by reordering the statistics gathering. Please

Re: [PATCH net-next 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Vivien Didelot
Hi Florian, Thanks for writing this, that's really nice to read such a documentation! Below are a couple of nitpicks. On 15-08-25 06:50:41, Florian Fainelli wrote: Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch

vxlan regression: multiple VXLANs on a single multicast group broken in kernel 4.1

2015-08-25 Thread John Nielsen
After updating the kernel on a KVM host, I discovered yesterday that I can no longer use more than one vxlan interface on a single multicast group/address. The interfaces can be created but only the first one may be brought up: # ip link add vx100 type vxlan id 100 group 239.0.0.1 dev eth0 # ip

[Patch net-next] route: fix a use-after-free

2015-08-25 Thread Cong Wang
This patch fixes the following crash: general protection fault: [#1] SMP DEBUG_PAGEALLOC CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.2.0-rc7+ #166 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 task: 88010656d280 ti: 88010657 task.ti: 88010657 RIP:

Re: [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar pshe...@nicira.com + if (family == AF_INET) + tun_dst = ip_tun_rx_dst(skb, flags, tunnel_id, md_size); + else +

Re: [PATCH v3 net-next 4/8] geneve: Make dst-port configurable.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar pshe...@nicira.com Reviewed-by: Jesse Gross je...@nicira.com Acked-by: Thomas Graf tg...@suug.ch -- To

[PATCH net-next 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Florian Fainelli
Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch driver. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Documentation/networking/dsa/dsa.txt | 584 +++ 1 file changed, 584

[PATCH net-next 0/2] Documentation: dsa

2015-08-25 Thread Florian Fainelli
Hi all, This patch series adds some documentation about DSA as a subsystem as well as the SF2 driver since it slightly diverges from your average DSA driver ;) Florian Fainelli (2): Documentation: networking: add a DSA document Documentation: networking: dsa: Add Broadcom SF2 document

[PATCH net-next 2/2] Documentation: networking: dsa: Add Broadcom SF2 document

2015-08-25 Thread Florian Fainelli
Add a document describing the Broadcom Starfigther 2 switch hardware, its specifics, and how the driver is implemented and its specifics. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Documentation/networking/dsa/bcm_sf2.txt | 113 +++ 1 file changed, 113

Re: [Question] Usage of dev_hold()/dev_put()

2015-08-25 Thread Eric Dumazet
On Tue, 2015-08-25 at 08:28 +, Zhangjie (HZ) wrote: Hi, The comment of function dev_hold() and dev_put() are really simple. Actually, I can’t find a rule to follow. Where should I call dev_hold()/dev_put()? Are they necessary during xmit or receive or only in register/release?

Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-25 Thread Eric Dumazet
On Tue, 2015-08-25 at 13:24 +0530, Raghavendra K T wrote: Docker container creation linearly increased from around 1.6 sec to 7.5 sec (at 1000 containers) and perf data showed 50% ovehead in snmp_fold_field. reason: currently __snmp6_fill_stats64 calls snmp_fold_field that walks through per

Re: [PATCH v3] MIPS: Remove all the uses of custom gpio.h

2015-08-25 Thread Linus Walleij
On Tue, Aug 4, 2015 at 10:50 AM, Alban Bedel al...@free.fr wrote: Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS machines, and each machine type provides its own gpio.h. However only a handful really implement the GPIO API, most just forward everythings to gpiolib. The

Re: [PATCH] net: phy: add locking to phy_read_mmd_indirect()/phy_write_mmd_indirect()

2015-08-25 Thread Florian Fainelli
Le 08/25/15 01:49, Russell King a écrit : The phy layer is missing locking for the above two functions - it has been observed that two threads (userspace and the phy worker thread) can race, entering the bus -write or -read functions simultaneously. This causes the FEC driver to initialise

Re: [PATCH] net: phy: add locking to phy_read_mmd_indirect()/phy_write_mmd_indirect()

2015-08-25 Thread Russell King - ARM Linux
On Tue, Aug 25, 2015 at 07:08:24AM -0700, Florian Fainelli wrote: Le 08/25/15 01:49, Russell King a écrit : The phy layer is missing locking for the above two functions - it has been observed that two threads (userspace and the phy worker thread) can race, entering the bus -write or -read

Re: [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-25 Thread Oliver Neukum
On Mon, 2015-08-24 at 23:13 +0300, Eugene Shatokhin wrote: It is needed to check EVENT_NO_RUNTIME_PM bit of dev-flags in usbnet_stop(), but its value should be read before it is cleared when dev-flags is set to 0. The problem was spotted and the fix was provided by Oliver Neukum

Re: [PATCH net-next 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Scott Feldman
On Tue, Aug 25, 2015 at 6:50 AM, Florian Fainelli f.faine...@gmail.com wrote: Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch driver. Signed-off-by: Florian Fainelli f.faine...@gmail.com [cut] +Interactions

Re: [PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus

2015-08-25 Thread Eric Dumazet
On Tue, 2015-08-25 at 13:24 +0530, Raghavendra K T wrote: While creating 1000 containers, perf is showing lot of time spent in snmp_fold_field on a large cpu system. The current patch tries to improve by reordering the statistics gathering. Please note that similar overhead was also

Re: [PATCH net v2] sctp: asconf's process should verify address parameter is in the beginning

2015-08-25 Thread Marcelo Ricardo Leitner
On Tue, Aug 25, 2015 at 08:29:24PM +0800, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by

Re: [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-25 Thread Bjørn Mork
Oliver Neukum oneu...@suse.com writes: On Mon, 2015-08-24 at 23:13 +0300, Eugene Shatokhin wrote: It is needed to check EVENT_NO_RUNTIME_PM bit of dev-flags in usbnet_stop(), but its value should be read before it is cleared when dev-flags is set to 0. Can we agree that this at least is

[PATCH net] ip6_gre: release cached dst on tunnel removal

2015-08-25 Thread Nicolas Dichtel
From: huaibin Wang huaibin.w...@6wind.com When a tunnel is deleted, the cached dst entry should be released. This problem may prevent the removal of a netns (seen with a x-netns IPv6 gre tunnel): unregister_netdevice: waiting for lo to become free. Usage count = 3 CC: Dmitry Kozlov

Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-25 Thread Raghavendra K T
On 08/25/2015 09:30 PM, Eric Dumazet wrote: On Tue, 2015-08-25 at 21:17 +0530, Raghavendra K T wrote: On 08/25/2015 07:58 PM, Eric Dumazet wrote: This is a great idea, but kcalloc()/kmalloc() can fail and you'll crash the whole kernel at this point. Good catch, and my bad. Though system

Re: [PATCH net v2] sctp: asconf's process should verify address parameter is in the beginning

2015-08-25 Thread Vlad Yasevich
On 08/25/2015 10:01 AM, Marcelo Ricardo Leitner wrote: On Tue, Aug 25, 2015 at 08:29:24PM +0800, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass

Re: use after free again...

2015-08-25 Thread Jiri Benc
On Mon, 24 Aug 2015 23:02:02 -0700, Cong Wang wrote: Hi, Jiri, In your commit 61adedf3e3f1d3f032c5a6a299978d91eff6d555 (route: move lwtunnel state to dst_entry), how the hell could the following piece be correct? :-/ It's not. I cooked a _quick_ patch to fix it. I can send it formally if

Re: [PATCH net-next 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Andrew Lunn
Hi Florian Nice document. A few typos below, but i did not get all the way to the bottom, so another email will follow. Also, maybe it would be good to mention the philosophy, that features should be configured in the usual Linux way. We use the hardware to accelerate features which Linux

Re: [PATCH net] sctp: asconf process should treat multiple address parameter as unrecognized parameter

2015-08-25 Thread Marcelo Ricardo Leitner
On Tue, Aug 25, 2015 at 08:43:10PM +0800, lucien xin wrote: On Tue, Aug 25, 2015 at 8:39 PM, lucien xin lucien@gmail.com wrote: I think it would be much better to catch this in the validation stage. If an implementation inserts multiple address parameters, we don't really know

Re: [PATCH net v2] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-25 Thread David Miller
From: Xin Long lucien@gmail.com Date: Sun, 23 Aug 2015 19:30:15 +0800 Vlad et al., please review. commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENDING state through not reseting the overall_error_count when receive a heartbeat, but the same issue also exists in SHUTDOWN_RECEIVE

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-25 Thread David Miller
From: Eugene Shatokhin eugene.shatok...@rosalab.ru Date: Mon, 24 Aug 2015 23:13:43 +0300 The race may happen when a device (e.g. YOTA 4G LTE Modem) is unplugged while the system is downloading a large file from the Net. Hardware breakpoints and Kprobes with delays were used to confirm that

Re: [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-25 Thread David Miller
From: Eugene Shatokhin eugene.shatok...@rosalab.ru Date: Mon, 24 Aug 2015 23:13:42 +0300 It is needed to check EVENT_NO_RUNTIME_PM bit of dev-flags in usbnet_stop(), but its value should be read before it is cleared when dev-flags is set to 0. The problem was spotted and the fix was

Re: [PATCH net] netlink: rx mmap: fix POLLIN condition

2015-08-25 Thread David Miller
From: Ken-ichirou MATSUZAWA chama...@gmail.com Date: Thu, 20 Aug 2015 14:54:47 +0900 Now poll() returns immediately after setting kernel current frame (ring-head) to SKIP from user space even if there are no new frames. And in a case of all frames is VALID, user space program unintensionally

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
On Aug 25, 2015, at 5:56 PM, Stephen Hemminger step...@networkplumber.org wrote: On Tue, 25 Aug 2015 17:34:55 -0700 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds a new knob that, when enabled, allows to suppress

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Tue, 25 Aug 2015 17:34:55 -0700 From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds a new knob that, when enabled, allows to suppress the installation of local fdb entries in newly created vlans. This could pose a big

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-25 Thread Nikolay Aleksandrov
On Aug 25, 2015, at 7:42 PM, David Miller da...@davemloft.net wrote: From: Nikolay Aleksandrov ra...@blackwall.org Date: Tue, 25 Aug 2015 17:34:55 -0700 From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds a new knob that, when enabled, allows to suppress the

Re: [PATCH net-next 0/9] DSA port configuration and status

2015-08-25 Thread Andrew Lunn
It looks to me like there will be at least one more revision to this series, so I'm not applying this version. Correct, and thanks. Andrew -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next] macvtap/macvlan: use IFF_NO_QUEUE

2015-08-25 Thread Jason Wang
On 08/26/2015 12:32 AM, Vlad Yasevich wrote: On 08/25/2015 07:30 AM, Jason Wang wrote: On 08/25/2015 06:17 PM, Michael S. Tsirkin wrote: On Mon, Aug 24, 2015 at 04:33:12PM +0800, Jason Wang wrote: For macvlan, switch to use IFF_NO_QUEUE instead of tx_queue_len = 0. For macvtap, after

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-25 Thread Jiri Pirko
Tue, Aug 25, 2015 at 11:25:21PM CEST, da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Mon, 24 Aug 2015 16:45:46 +0200 From: Jiri Pirko j...@mellanox.com Signed-off-by: Jiri Pirko j...@mellanox.com Signed-off-by: Ido Schimmel ido...@mellanox.com Signed-off-by: Elad Raz

[PATCH v2 net-next 2/5] net_sched: act_bpf: remove unnecessary copy

2015-08-25 Thread Alexei Starovoitov
Fix harmless typo and avoid unnecessary copy of empty 'prog' into unused 'strcut tcf_bpf_cfg old'. Fixes: f4eaed28c783 (act_bpf: fix memory leaks when replacing bpf programs) Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- net/sched/act_bpf.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 net-next 4/5] net_sched: convert rsvp to call tcf_exts_destroy from rcu callback

2015-08-25 Thread Alexei Starovoitov
Adjust destroy path of cls_rsvp to call tcf_exts_destroy() after rcu grace period. Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- net/sched/cls_rsvp.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h

[PATCH v2 net-next 0/5] act_bpf: remove spinlock in fast path

2015-08-25 Thread Alexei Starovoitov
v1 version had a race condition in cleanup path of bpf_prog. I tried to fix it by adding new callback 'cleanup_rcu' to 'struct tcf_common' and call it out of act_api cleanup path, but Daniel noticed (thanks for the idea!) that most of the classifiers already do action cleanup out of rcu callback.

[PATCH v2 net-next 3/5] net_sched: convert tcindex to call tcf_exts_destroy from rcu callback

2015-08-25 Thread Alexei Starovoitov
Adjust destroy path of cls_tcindex to call tcf_exts_destroy() after rcu grace period. Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- net/sched/cls_tcindex.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/net/sched/cls_tcindex.c

[PATCH v2 net-next 5/5] net_sched: act_bpf: remove spinlock in fast path

2015-08-25 Thread Alexei Starovoitov
Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing with extra care taken to free bpf programs after rcu grace period. Replacement of existing act_bpf (very rare) is done with synchronize_rcu() and final destruction is done from tc_action_ops-cleanup() callback that is

[PATCH v2 net-next 1/5] net_sched: make tcf_hash_destroy() static

2015-08-25 Thread Alexei Starovoitov
tcf_hash_destroy() used once. Make it static. Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- include/net/act_api.h |1 - net/sched/act_api.c |3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/net/act_api.h b/include/net/act_api.h index

Re: [PATCH net] netlink: mmap: fix status setting in skb destructor

2015-08-25 Thread David Miller
From: Ken-ichirou MATSUZAWA chama...@gmail.com Date: Thu, 20 Aug 2015 16:07:33 +0900 I don't know the intension of setting VALID status in the skb destructor. But I think it need to be set UNUSED status in case of error then release skb, or rx ring might be filled with RESERVED frames.

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-08-25 Thread Marcel Holtmann
Hi Dave, This patch series implements a L2 only interface concept which basically denies any kind of IP address configuration on these interfaces, but still allows them to be used as configuration end-points to keep using ethtool and friends. A cleaner approach might be to finally come up

Re: iproute2: Behavioural Bug?

2015-08-25 Thread Akshat Kakkar
Well if that is the case, then just an additional information (which I have initially mentioned though), if hashtable is 800, then behaviour is correct i.e. deleting only a single filter but for hash tables other than 800, the bug (if any) gets triggered. On Tue, Aug 25, 2015 at 11:38 AM, Cong

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

2015-08-25 Thread Sergei Shtylyov
On 8/25/2015 11:03 AM, Simon Horman wrote: From: Kazuya Mizuguchi kazuya.mizuguchi...@renesas.com Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH

Re: [PATCH net-next] enic: reduce ioread in devcmd2

2015-08-25 Thread Govindarajulu Varadarajan
On Tue, 25 Aug 2015, Govindarajulu Varadarajan wrote: posted_index is RO in firmware. We need not do ioread everytime to get posted index. Store posted index locally. Signed-off-by: Govindarajulu Varadarajan _gov...@gmx.com --- diff --git a/drivers/net/ethernet/cisco/enic/vnic_wq.h

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-25 Thread Richard Cochran
On Mon, Aug 24, 2015 at 08:16:51PM +, Hall, Christopher S wrote: This means: remove code changes from the PTP_SYS_OFFSET ioctl and call getsynctime64() from a new ioctl PTP_SYS_OFFSET_PRECISE. Right? Yes. And use the same type (struct ptp_sys_offset) for the new ioctl? Or should a

[PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus

2015-08-25 Thread Raghavendra K T
While creating 1000 containers, perf is showing lot of time spent in snmp_fold_field on a large cpu system. The current patch tries to improve by reordering the statistics gathering. Please note that similar overhead was also reported while creating veth pairs

[PATCH] net: compile renesas directory if NET_VENDOR_RENESAS is configured

2015-08-25 Thread Simon Horman
From: Kazuya Mizuguchi kazuya.mizuguchi...@renesas.com Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory.

[PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

2015-08-25 Thread Raghavendra K T
Docker container creation linearly increased from around 1.6 sec to 7.5 sec (at 1000 containers) and perf data showed 50% ovehead in snmp_fold_field. reason: currently __snmp6_fill_stats64 calls snmp_fold_field that walks through per cpu data of an item (iteratively for around 90 items). idea:

[PATCH RFC 1/2] net: Introduce helper functions to get the per cpu data

2015-08-25 Thread Raghavendra K T
Signed-off-by: Raghavendra K T raghavendra...@linux.vnet.ibm.com --- include/net/ip.h | 10 ++ net/ipv4/af_inet.c | 41 +++-- 2 files changed, 37 insertions(+), 14 deletions(-) diff --git a/include/net/ip.h b/include/net/ip.h index d5fe9f2..93bf12e

[PATCH net-next] enic: reduce ioread in devcmd2

2015-08-25 Thread Govindarajulu Varadarajan
posted_index is RO in firmware. We need not do ioread everytime to get posted index. Store posted index locally. Signed-off-by: Govindarajulu Varadarajan _gov...@gmx.com --- drivers/net/ethernet/cisco/enic/vnic_dev.c | 8 +--- drivers/net/ethernet/cisco/enic/vnic_wq.h | 1 + 2 files

Re: [PATCH v2 net-next] r8169: Add values missing in @get_stats64 from HW counters

2015-08-25 Thread Corinna Vinschen
On Aug 25 01:33, Francois Romieu wrote: Corinna Vinschen vinsc...@redhat.com : On Aug 22 13:23, Francois Romieu wrote: [...] Sorry, my english was really bad: the code should propagate failure when rtl8169_reset_counters and rtl8169_update_counters *simultaneously* fail.

[PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

2015-08-25 Thread Simon Horman
From: Kazuya Mizuguchi kazuya.mizuguchi...@renesas.com Currently the renesas ethernet driver directory is compiled if SH_ETH is configured rather than NET_VENDOR_RENESAS. Although incorrect that was quite harmless as until recently as SH_ETH configured the only driver in the renesas directory.

Re: iproute2: Behavioural Bug?

2015-08-25 Thread Cong Wang
On Mon, Aug 24, 2015 at 10:14 PM, Akshat Kakkar akshat.1...@gmail.com wrote: Dear Florian, There are two filters 15:2:2 and 15:2:3 and I have deleted only 15:2:3, so 15:2:2 will still be there and hence this condition destroy proto tp when all filters are gone should not be applicable over

pull-request: can 2015-08-25

2015-08-25 Thread Marc Kleine-Budde
dma flags (2015-08-23 23:00:41 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.2-20150825 for you to fetch changes up to 06b23f7fbbf26a025fd68395c7586949db586b47: can: pcan_usb: don't provide CAN FD

[PATCH] can: pcan_usb: don't provide CAN FD bittimings by non-FD adapters

2015-08-25 Thread Marc Kleine-Budde
The CAN FD data bittiming constants are provided via netlink only when there are valid CAN FD constants available in priv-data_bittiming_const. Due to the indirection of pointer assignments in the peak_usb driver the priv-data_bittiming_const never becomes NULL - not even for non-FD adapters.

Re: [net-next PATCH 1/3] drivers: net: cpsw: add am335x errata workarround for interrutps

2015-08-25 Thread Mugunthan V N
On Monday 24 August 2015 03:34 PM, Sekhar Nori wrote: Hi Mugunthan, On Wednesday 12 August 2015 03:22 PM, Mugunthan V N wrote: +static const struct of_device_id cpsw_of_mtable[] = { + { .compatible = ti,cpsw, .data = cpsw_devtype[CPSW], }, + { .compatible = ti,am335x-cpsw, .data =

Re: pull-request: can 2015-08-24

2015-08-25 Thread Marc Kleine-Budde
On 08/24/2015 11:20 AM, Marc Kleine-Budde wrote: Hello David, this is a pull request of one patch by me for the peak_usb driver. It fixes the driver, so that non FD adapters don't provide CAN FD bittimings. As there are some typos in the commit message I'll send an updated pull request.

use after free again...

2015-08-25 Thread Cong Wang
Hi, Jiri, In your commit 61adedf3e3f1d3f032c5a6a299978d91eff6d555 (route: move lwtunnel state to dst_entry), how the hell could the following piece be correct? :-/ @@ -264,6 +266,7 @@ again: kfree(dst); else kmem_cache_free(dst-ops-kmem_cachep, dst); +

Re: [PATCH ipsec-next v2] xfrm: Use VRF master index if output device is enslaved

2015-08-25 Thread David Miller
From: Steffen Klassert steffen.klass...@secunet.com Date: Fri, 21 Aug 2015 22:31:32 +0200 On Fri, Aug 21, 2015 at 02:11:21AM +0300, Nikolay Aleksandrov wrote: On Aug 21, 2015, at 1:06 AM, David Ahern d...@cumulusnetworks.com wrote: Directs route lookups to VRF table. Compiles out if

Re: [PATCHv5 net-next 04/10] dst: Add __skb_dst_copy() variation

2015-08-25 Thread Thomas Graf
On 08/24/15 at 05:32pm, Joe Stringer wrote: This variation on skb_dst_copy() doesn't require two skbs. Signed-off-by: Joe Stringer joestrin...@nicira.com Acked-by: Pravin B Shelar pshe...@nicira.com Acked-by: Thomas Graf tg...@suug.ch -- To unsubscribe from this list: send the line

[PATCH 2/6] RDS: Fix rds MR reference count in rds_rdma_unuse()

2015-08-25 Thread Santosh Shilimkar
rds_rdma_unuse() drops the mr reference count which it hasn't taken. Correct way of removing mr is to remove mr from the tree and then rdma_destroy_mr() it first, then rds_mr_put() to decrement its reference count. Whichever thread holds last reference will free the mr via rds_mr_put() This bug

[PATCH 0/6] RDS: Few more fixes

2015-08-25 Thread Santosh Shilimkar
As indicated in the earlier series [1], this is a follow-up series which addresses few issues around the RDS FMR code. With [1] and the subject series, now I can run many parallel threads with multiple sockets with N x N traffic. The stress tests has survived overnight runs. Santosh Shilimkar

Re: [PATCHv5 net-next 03/10] ipv6: Export nf_ct_frag6_gather()

2015-08-25 Thread Pravin Shelar
On Mon, Aug 24, 2015 at 5:32 PM, Joe Stringer joestrin...@nicira.com wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com Acked-by: Thomas Graf tg...@suug.ch Acked-by: Pravin B Shelar pshe...@nicira.com When I apply this patch I see empty commit msg. I think you need to add atleast a

Re: [PATCH net-next 1/1] sfc: Allow driver to cope with a lower number of VIs than it needs for RSS

2015-08-25 Thread David Miller
From: Shradha Shah ss...@solarflare.com Date: Fri, 21 Aug 2015 10:43:51 +0100 @@ -115,7 +115,7 @@ static struct workqueue_struct *reset_workqueue; * * This is only used in MSI-X interrupt mode */ -static bool separate_tx_channels; +bool separate_tx_channels; ... @@ -35,6 +35,7 @@

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: - if (ip_tunnel_collect_metadata() geneve-collect_md) { + if (ip_tunnel_collect_metadata() || gs-collect_md) { OK, what I pointed out in patch 5 is fixed here. Metadata bits look good. Acked-by: Thomas Graf tg...@suug.ch -- To

Re: [PATCH V4 net-next 0/2] net: implement SMC-R solution

2015-08-25 Thread David Miller
From: Ursula Braun ubr...@linux.vnet.ibm.com Date: Fri, 21 Aug 2015 13:30:27 +0200 this is V4 of my SMC-R patches: Since you are asking for a solution 100% in our own separate module with our own can of worms, we have to give up the transparent detection whether a communication peer can do

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-25 Thread Christophe Ricard
Hi David, Pablo, I gave try to your proposed patch. Changes in netlink_getsockopt and netlink_setsockopt are working fine. Changes in netlink_ack looks not to be addressing the correct socket. I will send an updated version in few minutes. Best Regards Christophe On 25/08/2015 06:19, David

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: + if (ip_tunnel_collect_metadata() geneve-collect_md) { + __be16 flags; + void *opts; + I think this should be || -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCHv5 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-25 Thread Thomas Graf
On 08/24/15 at 05:32pm, Joe Stringer wrote: Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the CT action specifies a helper to be used for this connection. If no helper is specified, then helpers will be automatically applied as

Re: [PATCH net-next] vxlan: fix multiple inclusion of vxlan.h

2015-08-25 Thread Cong Wang
On Tue, Aug 25, 2015 at 9:36 AM, Jiri Benc jb...@redhat.com wrote: The vxlan_get_sk_family inline function was added after the last #endif, making multiple inclusion of net/vxlan.h fail. Move it to the proper place. Or move it even further into #if IS_ENABLED(CONFIG_VXLAN) ? -- To unsubscribe

Re: vxlan regression: multiple VXLANs on a single multicast group broken in kernel 4.1

2015-08-25 Thread Marcelo Ricardo Leitner
Em 25-08-2015 14:35, John Nielsen escreveu: After updating the kernel on a KVM host, I discovered yesterday that I can no longer use more than one vxlan interface on a single multicast group/address. The interfaces can be created but only the first one may be brought up: # ip link add vx100

[PATCH 6/6] RDS: remove superfluous from rds_ib_alloc_fmr()

2015-08-25 Thread Santosh Shilimkar
Memory allocated for 'ibmr' uses kzalloc_node() which already initialises the memory to zero. There is no need to do memset() 0 on that memory. Signed-off-by: Santosh Shilimkar ssant...@kernel.org Signed-off-by: Santosh Shilimkar santosh.shilim...@oracle.com --- net/rds/ib_rdma.c | 2 -- 1 file

[PATCH 4/6] RDS: push FMR pool flush work to its own worker

2015-08-25 Thread Santosh Shilimkar
RDS FMR flush operation and also it races with connect/reconect which happes a lot with RDS. FMR flush being on common rds_wq aggrevates the problem. Lets push RDS FMR pool flush work to its own worker. Signed-off-by: Santosh Shilimkar ssant...@kernel.org Signed-off-by: Santosh Shilimkar

[PATCH 3/6] RDS: fix fmr pool dirty_count

2015-08-25 Thread Santosh Shilimkar
From: Wengang Wang wen.gang.w...@oracle.com In rds_ib_flush_mr_pool(), dirty_count accounts the clean ones which is wrong. This can lead to a negative dirty count value. Lets fix it. Signed-off-by: Wengang Wang wen.gang.w...@oracle.com Signed-off-by: Santosh Shilimkar ssant...@kernel.org

[PATCH 1/6] RDS: fix the dangling reference to rds_ib_incoming_slab

2015-08-25 Thread Santosh Shilimkar
On rds_ib_frag_slab allocation failure, ensure rds_ib_incoming_slab is not pointing to the detsroyed memory. Signed-off-by: Santosh Shilimkar ssant...@kernel.org Signed-off-by: Santosh Shilimkar santosh.shilim...@oracle.com --- net/rds/ib_recv.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-25 Thread Jesse Gross
On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index c05bc13..8eb875d 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -492,36 +813,36 @@ static int geneve_configure(struct net *net, struct

Re: [PATCH] /net/ethernet/3com/3c59x.c:Fixed coding style errors and warnings.

2015-08-25 Thread David Miller
From: Ravinder Atla rednivara...@gmail.com Date: Fri, 21 Aug 2015 20:57:05 +0530 Checks are also cleared Signed-off-by: Ravinder Atla rednivara...@gmail.com Your subject should read 3c59x: Fixed coding... rather than what you used. Also, your patch adds new coding style errors:

Re: [PATCHv5 net-next 01/10] openvswitch: Serialize acts with original netlink len

2015-08-25 Thread Thomas Graf
On 08/24/15 at 05:32pm, Joe Stringer wrote: Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original

Re: [PATCH v2 net-next] tcp: fix slow start after idle vs TSO/GSO

2015-08-25 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 21 Aug 2015 12:30:00 -0700 From: Eric Dumazet eduma...@google.com slow start after idle might reduce cwnd, but we perform this after first packet was cooked and sent. With TSO/GSO, it means that we might send a full TSO packet even if

Re: [PATCHv5 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-25 Thread Thomas Graf
On 08/24/15 at 05:32pm, Joe Stringer wrote: Allow matching and setting the ct_mark field. As with ct_state and ct_zone, these fields are populated when the CT action is executed. To write to this field, a value and mask can be specified as a nested attribute under the CT action. This data is

Re: [PATCH net-next] tcp: refine pacing rate determination

2015-08-25 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 21 Aug 2015 17:38:02 -0700 From: Eric Dumazet eduma...@google.com When TCP pacing was added back in linux-3.12, we chose to apply a fixed ratio of 200 % against current rate, to allow probing for optimal throughput even during slow start

Re: [PATCH v3 01/10] ss: rooted out ss type declarations for output formatters

2015-08-25 Thread Matthias Tafelmeier
On 08/23/2015 07:07 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2015 22:40:12 +0200 Matthias Tafelmeier matthias.tafelme...@gmx.net wrote: The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those

Re: [PATCH net-next v2 1/2] Documentation: networking: add a DSA document

2015-08-25 Thread Scott Feldman
On Tue, Aug 25, 2015 at 10:40 AM, Florian Fainelli f.faine...@gmail.com wrote: Describe how the DSA subsystem works, its design principles, limitations, and describe in details how to implement a DSA switch driver. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Changes in v2: -

Re: [PATCHv5 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-25 Thread Thomas Graf
On 08/24/15 at 05:32pm, Joe Stringer wrote: Allow matching and setting the ct_label field. As with ct_mark, this is populated by executing the CT action. The label field may be modified by specifying a label and mask nested under the CT action. It is stored as metadata attached to the

Re: WARNING at net/ipv4/netfilter/ip_tables.c:530

2015-08-25 Thread Florian Westphal
Cong Wang cw...@twopensource.com wrote: Your commit 98d1bd802cdbc8f56868fae51edec13e86b59515 (netfilter: xtables: compute exact size needed for jumpstack) introduced the following kernel warning during boot. It looks like the if check inside mark_source_chains() isn't correct, this causes

  1   2   3   >