Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

On 9/19/16, 8:15 AM, Jiri Pirko wrote: > Mon, Sep 19, 2016 at 04:59:22PM CEST, ro...@cumulusnetworks.com wrote: >> On 9/18/16, 11:14 PM, Jiri Pirko wrote: >>> Mon, Sep 19, 2016 at 01:16:17AM CEST, ro...@cumulusnetworks.com wrote: On 9/18/16, 1:00 PM, Florian Fainelli wrote: > Le

Re: [net-next PATCH] net: netlink messages for HW addr programming

Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: >On 9/19/16, 7:46 AM, Patrick Ruddy wrote: >> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: >>> On 9/15/16, 9:48 AM, Patrick Ruddy wrote: Add RTM_NEWADDR and RTM_DELADDR netlink messages with family AF_UNSPEC

Re: [net-next PATCH] net: netlink messages for HW addr programming

On 9/19/16, 7:46 AM, Patrick Ruddy wrote: > On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: >> On 9/15/16, 9:48 AM, Patrick Ruddy wrote: >>> Add RTM_NEWADDR and RTM_DELADDR netlink messages with family >>> AF_UNSPEC to indicate interest in specific unicast and multicast >>> hardware

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

On 17 August 2016 at 13:34, Rafał Miłecki wrote: > On 8 July 2016 at 01:08, Jon Mason wrote: >> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >> BGMAC_DS_MM_SHIFT; >> - if (ci->id !=

[PATCH net-next] mlxsw: spectrum: Make offloads stats functions static

The offloads stats functions are local to this file, make them static. Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]') Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 1 file changed, 4 insertions(+), 4

Re: 答复: [PATCH] sunrpc: queue work on system_power_efficient_wq

Resend behalf on Ke Wang. Thanks, Chunyan On 20 September 2016 at 10:33, Ke Wang (王科) wrote: > May I have any comments for this patch? > or > This patch can be merged directly into next release? > > Thanks, > Ke > > 发件人: Anna

Re: [PATCH v2 0/2] act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action

This is for net-next, forgot to mention. Deprecates the v1 of https://patchwork.ozlabs.org/patch/671403/

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

On Thu, Sep 15, 2016 at 09:41:33PM +0200, Mickaël Salaün wrote: > > On 15/09/2016 06:48, Alexei Starovoitov wrote: > > On Wed, Sep 14, 2016 at 09:38:16PM -0700, Andy Lutomirski wrote: > >> On Wed, Sep 14, 2016 at 9:31 PM, Alexei Starovoitov > >> wrote: > >>> On Wed,

Re: [PATCH] net: skbuff: Fix length validation in skb_vlan_pop()

Hi, On Mon, 19 Sep 2016 13:46:10 -0700 pravin shelar wrote: > On Mon, Sep 19, 2016 at 1:04 PM, Shmulik Ladkani > wrote: > > Hi Pravin, > > > > On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote: > >> > +++ b/net/core/skbuff.c >

[PATCH v4 net-next 10/16] tcp: allow congestion control module to request TSO skb segment count

Add the tso_segs_goal() function in tcp_congestion_ops to allow the congestion control module to specify the number of segments that should be in a TSO skb sent by tcp_write_xmit() and tcp_xmit_retransmit_queue(). The congestion control module can either request a particular number of segments in

[PATCH v4 net-next 12/16] tcp: export tcp_mss_to_mtu() for congestion control modules

Export tcp_mss_to_mtu(), so that congestion control modules can use this to help calculate a pacing rate. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati

[PATCH v4 net-next 00/16] tcp: BBR congestion control algorithm

tcp: BBR congestion control algorithm This patch series implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A paper with a detailed description of BBR will be published in ACM Queue, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR is

[PATCH v4 net-next 13/16] tcp: allow congestion control to expand send buffer differently

From: Yuchung Cheng Currently the TCP send buffer expands to twice cwnd, in order to allow limited transmits in the CA_Recovery state. This assumes that cwnd does not increase in the CA_Recovery. For some congestion control algorithms, like the upcoming BBR module, if the

[PATCH v4 net-next 06/16] tcp: count packets marked lost for a TCP connection

Count the number of packets that a TCP connection marks lost. Congestion control modules can use this loss rate information for more intelligent decisions about how fast to send. Specifically, this is used in TCP BBR policer detection. BBR uses a high packet loss rate as one signal in its

[PATCH v4 net-next 01/16] tcp: cdg: rename struct minmax in tcp_cdg.c to avoid a naming conflict

From: Soheil Hassas Yeganeh The upcoming change "lib/win_minmax: windowed min or max estimator" introduces a struct called minmax, which is then included in include/linux/tcp.h in the upcoming change "tcp: use windowed min filter library for TCP min_rtt estimation". This would

[PATCH v4 net-next 02/16] lib/win_minmax: windowed min or max estimator

This commit introduces a generic library to estimate either the min or max value of a time-varying variable over a recent time window. This is code originally from Kathleen Nichols. The current form of the code is from Van Jacobson. A single struct minmax_sample will track the estimated

[PATCH v4 net-next 14/16] tcp: new CC hook to set sending rate with rate_sample in any CA state

From: Yuchung Cheng This commit introduces an optional new "omnipotent" hook, cong_control(), for congestion control modules. The cong_control() function is called at the end of processing an ACK (i.e., after updating sequence numbers, the SACK scoreboard, and loss detection).

[PATCH v4 net-next 09/16] tcp: export data delivery rate

From: Yuchung Cheng This commit export two new fields in struct tcp_info: tcpi_delivery_rate: The most recent goodput, as measured by tcp_rate_gen(). If the socket is limited by the sending application (e.g., no data to send), it reports the highest measurement

[PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

This commit implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A detailed description of BBR will be published in ACM Queue, Vol. 14 No. 5, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR has significantly increased throughput and

[PATCH v4 net-next 15/16] tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88

The TCP CUBIC module already uses 64 bytes. The upcoming TCP BBR module uses 88 bytes. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati

[PATCH v4 net-next 11/16] tcp: export tcp_tso_autosize() and parameterize minimum number of TSO segments

To allow congestion control modules to use the default TSO auto-sizing algorithm as one of the ingredients in their own decision about TSO sizing: 1) Export tcp_tso_autosize() so that CC modules can use it. 2) Change tcp_tso_autosize() to allow callers to specify a minimum number of segments

[PATCH v4 net-next 08/16] tcp: track application-limited rate samples

From: Soheil Hassas Yeganeh This commit adds code to track whether the delivery rate represented by each rate_sample was limited by the application. Upon each transmit, we store in the is_app_limited field in the skb a boolean bit indicating whether there is a known "bubble

[PATCH v4 net-next 03/16] tcp: use windowed min filter library for TCP min_rtt estimation

Refactor the TCP min_rtt code to reuse the new win_minmax library in lib/win_minmax.c to simplify the TCP code. This is a pure refactor: the functionality is exactly the same. We just moved the windowed min code to make TCP easier to read and maintain, and to allow other parts of the kernel to

[PATCH v4 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

From: Eric Dumazet Revert to the tcp_skb_cb size check that tcp_init() had before commit b4772ef879a8 ("net: use common macro for assering skb->cb[] available size in protocol families"). As related commit 744d5a3e9fe2 ("net: move skb->dropcount to skb->cb[]") explains, the

[PATCH v4 net-next 04/16] net_sched: sch_fq: add low_rate_threshold parameter

From: Eric Dumazet This commit adds to the fq module a low_rate_threshold parameter to insert a delay after all packets if the socket requests a pacing rate below the threshold. This helps achieve more precise control of the sending rate with low-rate paths, especially

[PATCH v4 net-next 07/16] tcp: track data delivery rate for a TCP connection

From: Yuchung Cheng This patch generates data delivery rate (throughput) samples on a per-ACK basis. These rate samples can be used by congestion control modules, and specifically will be used by TCP BBR in later patches in this series. Key state: tp->delivered: Tracks the

[PATCH net-next] net: ethernet: mediatek: enhance with avoiding superfluous assignment inside mtk_get_ethtool_stats

From: Sean Wang data_src is unchanged inside the loop, so this patch moves the assignment to outside the loop to avoid unnecessarily assignment Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 ++- 1 file changed, 2

Re: [PATCHv2 net-next 0/2] Preparation for mv88e6390

Hi Andrew, Andrew Lunn writes: > These two patches are a couple of preparation steps for supporting the > the MV88E6390 family of chips. This is a new generation from Marvell, > and will need more feature flags than are currently available in an > unsigned long. Expand to an

Re: [PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

Hi Andrew, Andrew Lunn writes: > @@ -585,19 +601,19 @@ static void mv88e6xxx_adjust_link(struct dsa_switch > *ds, int port, > struct phy_device *phydev) > { > struct mv88e6xxx_chip *chip = ds->priv; > - u32 reg; > - int ret; > +

Re: [PATCH net 0/3] mlx5 fixes to 4.8-rc6

From: Or Gerlitz Date: Sun, 18 Sep 2016 18:20:26 +0300 > This series series has a fix from Roi to memory corruption bug in > the bulk flow counters code and two late and hopefully last fixes > from me to the new eswitch offloads code. > > Series done over net commit

Re: [PATCHv6 net-next 00/15] BPF hardware offload (cls_bpf for now)

From: Jakub Kicinski Date: Sun, 18 Sep 2016 16:09:10 +0100 > As spotted by Daniel JIT might have accessed indexes past the end > of verifier's reg_state array. This series doesn't apply cleanly to net-next, please respin. Thanks.

Re: [PATCH net-next 1/1] net sched actions police: peg drop stats for conforming traffic

From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:53:08 -0400 > From: Roman Mashak > > setting conforming action to drop is a valid policy. > When it is set we need to at least see the stats indicating it > for debugging. > > Signed-off-by: Roman Mashak

Re: [PATCH net-next 1/1] net sched: stylistic cleanups

From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 08:45:33 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH] net: hns: mark symbols static where possible

From: Baoyou Xie Date: Sun, 18 Sep 2016 17:07:25 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous > prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] >

Re: [PATCH v3 net-next 1/2] net sched ife action: add 16 bit helpers

From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:31:42 -0400 > From: Jamal Hadi Salim > > encoder and checker for 16 bits metadata > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH] phy: mark lan88xx_suspend() static

From: Baoyou Xie Date: Sun, 18 Sep 2016 16:26:34 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/phy/microchip.c:58:5: warning: no previous prototype for > 'lan88xx_suspend' [-Wmissing-prototypes] > > In fact, this function is only used in the file

Re: [PATCH v3 net-next 2/2] net sched ife action: Introduce skb tcindex metadata encap decap

From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:31:43 -0400 > From: Jamal Hadi Salim > > Sample use case of how this is encoded: > user space via tuntap (or a connected VM/Machine/container) > encodes the tcindex TLV. > > Sample use case of decoding: >

Re: [PATCH] cxgb4: mark symbols static where possible

From: Baoyou Xie Date: Sun, 18 Sep 2016 17:18:23 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:178:5: warning: no previous > prototype for 'setup_sge_queues_uld' [-Wmissing-prototypes] >

Re: [PATCH] be2net: mark symbols static where possible

From: Baoyou Xie Date: Sun, 18 Sep 2016 16:35:29 +0800 > We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/emulex/benet/be_main.c:4368:6: warning: no previous > prototype for 'be_calculate_pf_pool_rss_tables' [-Wmissing-prototypes] >

Re: [v3 PATCH 1/2] rhashtable: Add rhlist interface

On Mon, Sep 19, 2016 at 11:16:21PM +0200, Thomas Graf wrote: > > Nice, I like how this simplifies users! Is this suitable for > ILA as well? Does it have duplicate objects and use inelastic_security? If so then yes it should switch over to rhlist. Cheers, -- Email: Herbert Xu

Re: [PATCH RFC 2/6] rhashtable: Call library function alloc_bucket_locks

Tom Herbert wrote: > To allocate the array of bucket locks for the hash table we now > call library function alloc_bucket_spinlocks. This function is > based on the old alloc_bucket_locks in rhashtable and should > produce the same effect. > > Signed-off-by: Tom Herbert

Re: [PATCH 2/2] net: ethernet: broadcom: b44: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 18 Sep 2016 00:11:35 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: broadcom: bcm63xx: use phydev from struct net_device

From: Philippe Reynes Date: Sun, 18 Sep 2016 16:59:06 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: broadcom: bcm63xx: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 18 Sep 2016 16:59:07 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 18 Sep 2016 17:16:45 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: broadcom: b44: use phydev from struct net_device

From: Philippe Reynes Date: Sun, 18 Sep 2016 00:11:34 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH net-next 00/10] bnxt: update for net-next.

From: Michael Chan Date: Mon, 19 Sep 2016 03:57:59 -0400 > Misc. changes and minor bug fixes for net-next. Please review. Series applied, thanks Michael.

Re: lsm naming dilemma. Re: [RFC v3 07/22] landlock: Handle file comparisons

I'm fine giving up the Checmate name. Landlock seems easy enough to Google. I haven't gotten a chance to look through the entire patchset yet, but it does seem like they are somewhat similar. On Mon, Sep 19, 2016 at 5:12 PM, Alexei Starovoitov wrote: > On Thu, Sep

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

Hi Andrew, Andrew Lunn writes: > On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: >> An address can be loaded in the ATU with multiple ports, for instance >> when adding multiple ports to a Multicast group with "bridge mdb". >> >> The current code doesn't allow

Re: [PATCH net-next v6] gso: Support partial splitting at the frag_list pointer

From: Alexander Duyck Date: Mon, 19 Sep 2016 08:12:15 -0700 > On Mon, Sep 19, 2016 at 3:58 AM, Steffen Klassert > wrote: >> Since commit 8a29111c7 ("net: gro: allow to build full sized skb") >> gro may build buffers with a frag_list. This

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: > An address can be loaded in the ATU with multiple ports, for instance > when adding multiple ports to a Multicast group with "bridge mdb". > > The current code doesn't allow that. Add an helper to get a single entry > from the ATU,

[PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

There is a device coming soon which places its port registers somewhere different to all other Marvell switches supported so far. Add helper functions for reading/writing port registers, making it easier to handle this new device. Signed-off-by: Andrew Lunn --- v2: Call

[PATCHv2 net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

We are soon going to run out of flag bits on 32bit systems. Convert to unsigned long long. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 62 +-- 1 file

[PATCHv2 net-next 0/2] Preparation for mv88e6390

These two patches are a couple of preparation steps for supporting the the MV88E6390 family of chips. This is a new generation from Marvell, and will need more feature flags than are currently available in an unsigned long. Expand to an unsigned long long. The MV88E6390 also places its port

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

On Mon, Sep 19, 2016 at 08:29:40PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Hi Vivien > > > >> + do { > >> + err = _mv88e6xxx_atu_getnext(chip, fid, ); > >> + if (err) > >> + return err; > >> + > >> + if

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

Hi Andrew, Andrew Lunn writes: > Hi Vivien > >> +do { >> +err = _mv88e6xxx_atu_getnext(chip, fid, ); >> +if (err) >> +return err; >> + >> +if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED) >> +break;

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

Hi Vivien > + do { > + err = _mv88e6xxx_atu_getnext(chip, fid, ); > + if (err) > + return err; > + > + if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED) > + break; > + > + if (ether_addr_equal(next.mac,

lsm naming dilemma. Re: [RFC v3 07/22] landlock: Handle file comparisons

On Thu, Sep 15, 2016 at 11:25:10PM +0200, Mickaël Salaün wrote: > >> Agreed. With this RFC, the Checmate features (i.e. network helpers) > >> should be able to sit on top of Landlock. > > > > I think neither of them should be called fancy names for no technical > > reason. > > We will have only

[PATCH iproute2 net-next] iptnl: add support for collect_md flag in IPv4 and IPv6 tunnels

Signed-off-by: Alexei Starovoitov --- Stephen, please sync include/uapi/linux/if_tunnel.h from the kernel tree before applying. Thanks --- ip/link_ip6tnl.c | 10 ++ ip/link_iptnl.c | 11 +++ 2 files changed, 21 insertions(+) diff --git a/ip/link_ip6tnl.c

[PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

An address can be loaded in the ATU with multiple ports, for instance when adding multiple ports to a Multicast group with "bridge mdb". The current code doesn't allow that. Add an helper to get a single entry from the ATU, then set or clear the requested port, before loading the entry back in

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

> > It generates some slightly smaller code. > if (bbr->lt_rtt_cnt < bbr_lt_intvl_min_rtts) > - 3e7: 0f b6 c0movzbl %al,%eax > - 3ea: 83 f8 03cmp$0x3,%eax > - 3ed: 0f 86 d4 00 00 00 jbe4c7 > + 3e7: 3c 03

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On Mon, 19 Sep 2016 14:10:39 -0700 Eric Dumazet wrote: > On Mon, Sep 19, 2016 at 1:57 PM, Stephen Hemminger > wrote: > > > Looks good, but could I suggest a simple optimization. > > All these parameters are immutable in the version of BBR you

[PATCH v5 net-next 1/1] net sched actions: fix GETing actions

From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that tcf_action_destroy() will eventually delete the action from the permanent location if the refcount is zero. Example of what broke:

Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

Hi Andrew, Andrew Lunn writes: > We are soon going to run out of flag bits on 32bit systems. Convert to > unsigned long long. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot Thanks, Vivien

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

Hi Andrew, Andrew Lunn writes: > @@ -41,6 +41,11 @@ static void assert_reg_lock(struct mv88e6xxx_chip *chip) > } > } > > +static int mv88e6xxx_reg_port(struct mv88e6xxx_chip *chip, int port) > +{ > + return chip->info->port_base_addr + port; > +} > + If we really

[PATCH net-next 0/3] BPF direct packet access improvements

This set adds write support to the currently available read support for {cls,act}_bpf programs. First one is a fix for affected commit sitting in net-next and prerequisite for the second one, last patch adds a number of test cases against the verifier. For details, please see individual patches.

[PATCH net-next 1/3] bpf, verifier: enforce larger zero range for pkt on overloading stack buffs

Current contract for the following two helper argument types is: * ARG_CONST_STACK_SIZE: passed argument pair must be (ptr, >0). * ARG_CONST_STACK_SIZE_OR_ZERO: passed argument pair can be either (NULL, 0) or (ptr, >0). With 6841de8b0d03 ("bpf: allow helpers access the packet directly"),

[PATCH net-next 2/3] bpf: direct packet write and access for helpers for clsact progs

This work implements direct packet access for helpers and direct packet write in a similar fashion as already available for XDP types via commits 4acf6c0b84c9 ("bpf: enable direct packet data write for xdp progs") and 6841de8b0d03 ("bpf: allow helpers access the packet directly"), and as a

[PATCH net-next 3/3] bpf: add test cases for direct packet access

Add couple of test cases for direct write and the negative size issue, and also adjust the direct packet access test4 since it asserts that writes are not possible, but since we've just added support for writes, we need to invert the verdict to ACCEPT, of course. Summary: 133 PASSED, 0 FAILED.

[PATCH net-next 0/2] Preparation for mv88e6390

These two patches are a couple of preparation steps for supporting the the MV88E6390 family of chips. This is a new generation from Marvell, and will need more feature flags than are currently available in an unsigned long. Expand to an unsigned long long. The MV88E6390 also places its port

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

There is a device coming soon which places its port registers somewhere different to all other Marvell switches supported so far. Add helper functions for reading/writing port registers, making it easier to handle this new device. Signed-off-by: Andrew Lunn ---

[PATCH net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

We are soon going to run out of flag bits on 32bit systems. Convert to unsigned long long. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 62 +-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

On 09/19/2016 11:48 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:44:50 +0200, Daniel Borkmann wrote: On 09/19/2016 11:36 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Storing state in reserved fields of

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

On Mon, Sep 19, 2016 at 06:34:28PM +0200, Daniel Mack wrote: > Hi, > > On 09/16/2016 09:57 PM, Sargun Dhillon wrote: > > On Wed, Sep 14, 2016 at 01:13:16PM +0200, Daniel Mack wrote: > > >> I have no idea what makes you think this is limited to systemd. As I > >> said, I provided an example for

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

On Mon, 19 Sep 2016 23:44:50 +0200, Daniel Borkmann wrote: > On 09/19/2016 11:36 PM, Jakub Kicinski wrote: > > On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: > >> On 09/18/2016 05:09 PM, Jakub Kicinski wrote: > >>> Storing state in reserved fields of instructions makes > >>> it

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

On 09/19/2016 11:36 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: > Hi Jakub, > > On 09/18/2016 05:09 PM, Jakub Kicinski wrote: > > Storing state in reserved fields of instructions makes > > it impossible to run verifier on programs already > > marked as read-only. Allocate and use an array of > >

[PATCH] ip: (ipvlan) introduce L3s mode

From: Mahesh Bandewar The new mode 'l3s' can be set like - ip link add link dev type ipvlan mode l3s e.g. ip link add link eth0 dev ipvl0 type ipvlan mode l3s Also did some trivial code restructuring. Signed-off-by: Mahesh Bandewar ---

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

Hi Daniel, [auto build test ERROR on next-20160919] [cannot apply to linus/master linux/master net/master v4.8-rc7 v4.8-rc6 v4.8-rc5 v4.8-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --b

[PATCH] tcp: fix wrong checksum calculation on MTU probing

With TCP MTU probing enabled and offload TX checksumming disabled, tcp_mtu_probe() calculated the wrong checksum when a fragment being copied into the probe's SKB had an odd length. This was caused by the direct use of skb_copy_and_csum_bits() to calculate the checksum, as it pads the fragment

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

On 09/19/16 at 01:13pm, Alexei Starovoitov wrote: > as far as bpf debuggability/visibility there are various efforts on the way: > for kernel side: > - ksym for jit-ed programs > - hash sum for prog code > - compact type information for maps and various pretty printers > - data flow analysis of

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On Mon, Sep 19, 2016 at 2:17 PM, Rick Jones wrote: > > Are there better than epsilon odds of someone perhaps wanting to poke those > values as it gets exposure beyond Google? > This does not matter. A change would require patching net/ipv4/tcp_bbr.c , and the 'const'

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On 09/19/2016 02:10 PM, Eric Dumazet wrote: On Mon, Sep 19, 2016 at 1:57 PM, Stephen Hemminger wrote: Looks good, but could I suggest a simple optimization. All these parameters are immutable in the version of BBR you are submitting. Why not make the values const?

Re: [v3 PATCH 1/2] rhashtable: Add rhlist interface

On 09/19/16 at 07:00pm, Herbert Xu wrote: > The insecure_elasticity setting is an ugly wart brought out by > users who need to insert duplicate objects (that is, distinct > objects with identical keys) into the same table. > > In fact, those users have a much bigger problem. Once those >

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On Mon, Sep 19, 2016 at 1:57 PM, Stephen Hemminger wrote: > Looks good, but could I suggest a simple optimization. > All these parameters are immutable in the version of BBR you are submitting. > Why not make the values const? And eliminate the always true long-term

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

Hi Jakub, On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move

[PATCH next] ipvlan: Fix dependency issue

From: Mahesh Bandewar kbuild-build-bot reported that if NETFILTER is not selected, the build fails pointing to netfilter symbols. Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode") Signed-off-by: Mahesh Bandewar --- drivers/net/Kconfig | 1 + 1 file

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On Sun, 18 Sep 2016 18:03:53 -0400 Neal Cardwell wrote: > +static int bbr_bw_rtts = CYCLE_LEN + 2; /* win len of bw filter (in > rounds) */ > +static u32 bbr_min_rtt_win_sec = 10; /* min RTT filter window (in sec) */ > +static u32 bbr_probe_rtt_mode_ms = 200;

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

On 09/19/2016 10:35 PM, Pablo Neira Ayuso wrote: > On Mon, Sep 19, 2016 at 09:30:02PM +0200, Daniel Mack wrote: >> On 09/19/2016 09:19 PM, Pablo Neira Ayuso wrote: >>> Actually, did you look at Google's approach to this problem? They >>> want to control this at socket level, so you restrict what

[PATCH net-next 2/2] openvswitch: avoid resetting flow key while installing new flow.

since commit commit db74a3335e0f6 ("openvswitch: use percpu flow stats") flow alloc resets flow-key. So there is no need to reset the flow-key again if OVS is using newly allocated flow-key. Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 8

[PATCH net-next 1/2] openvswitch: Fix Frame-size larger than 1024 bytes warning.

There is no need to declare separate key on stack, we can just use sw_flow->key to store the key directly. This commit fixes following warning: net/openvswitch/datapath.c: In function ‘ovs_flow_cmd_new’: net/openvswitch/datapath.c:1080:1: warning: the frame size of 1040 bytes is larger than 1024

Re: [PATCH] net: skbuff: Fix length validation in skb_vlan_pop()

On Mon, Sep 19, 2016 at 1:04 PM, Shmulik Ladkani wrote: > Hi Pravin, > > On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote: >> > +++ b/net/core/skbuff.c >> > @@ -4537,7 +4537,7 @@ int skb_vlan_pop(struct sk_buff *skb) >> > } else { >> >

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

On Mon, Sep 19, 2016 at 01:13:27PM -0700, Alexei Starovoitov wrote: > On Mon, Sep 19, 2016 at 09:19:10PM +0200, Pablo Neira Ayuso wrote: [...] > > 2) This will turn the stack into a nightmare to debug I predict. If > >any process with CAP_NET_ADMIN can potentially attach bpf blobs > >via

Re: [RFC V3 PATCH 00/26] Kernel NET policy

On Mon, 12 Sep 2016 08:52:14 -0700 Eric Dumazet wrote: > On Mon, 2016-09-12 at 07:55 -0700, kan.li...@intel.com wrote: > > From: Kan Liang > > > > > > > Documentation/networking/netpolicy.txt | 157 > > > I find this patch series very

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

On Mon, Sep 19, 2016 at 09:30:02PM +0200, Daniel Mack wrote: > On 09/19/2016 09:19 PM, Pablo Neira Ayuso wrote: > > On Mon, Sep 19, 2016 at 06:44:00PM +0200, Daniel Mack wrote: > >> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c > >> index 6001e78..5dc90aa 100644 > >> ---

Re: [PATCH v2 net-next] MAINTAINERS: Add an entry for the core network DSA code

Hi Andrew, Andrew Lunn writes: > The core distributed switch architecture code currently does not have > a MAINTAINERS entry, which results in some contributions not landing > in the right peoples inbox. > > Signed-off-by: Andrew Lunn Acked-by: Vivien Didelot

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

❦ 19 septembre 2016 06:58 CEST, David Miller  : >> @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct >> net *net, >> return rt; >> } >> >> +static int ip6_nh_valid(struct rt6_info *grt, >> +struct net_device **dev, struct

Re: drr scheduler [mis]configuration question

> > At this point I'm a bit lost what I'm doing wrong. > Just in case (erhm... for sake of completness and archiving) to answer my own borderline silly question - handles and classids are in hex.

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

On Mon, Sep 19, 2016 at 09:19:10PM +0200, Pablo Neira Ayuso wrote: > On Mon, Sep 19, 2016 at 06:44:00PM +0200, Daniel Mack wrote: > > diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c > > index 6001e78..5dc90aa 100644 > > --- a/net/ipv6/ip6_output.c > > +++ b/net/ipv6/ip6_output.c > > @@

  1   2   3   >