[PATCH] rtl_bt: Update firmware for BT part of rtl8822be

2017-04-13 Thread Larry Finger
These files were supplied by Realtek. Signed-off-by: Larry Finger --- WHENCE | 3 ++- rtl_bt/rtl8822b_config.bin | Bin 32 -> 14 bytes rtl_bt/rtl8822b_fw.bin | Bin 51756 -> 51176 bytes 3 files changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH 02/22] nvmet: Make use of the new sg_map helper function

2017-04-13 Thread Christoph Hellwig
On Thu, Apr 13, 2017 at 11:06:16PM -0600, Logan Gunthorpe wrote: > Or maybe I'll just send a patch for that > separately seeing it doesn't depend on anything and is pretty simple. I > can do that next week. Yes, please just send that patch linux-nvme, we should be able to get it into 4.12.

Re: [PATCH 02/22] nvmet: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
On 13/04/17 10:59 PM, Christoph Hellwig wrote: > On Thu, Apr 13, 2017 at 04:05:15PM -0600, Logan Gunthorpe wrote: >> This is a straight forward conversion in two places. Should kmap fail, >> the code will return an INVALD_DATA error in the completion. > > It really should be using

[PATCH net-next 1/1 v3] drivers: net: rmnet: Initial implementation

2017-04-13 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 0/1 v3] drivers: net: Add support for rmnet driver

2017-04-13 Thread Subash Abhinov Kasiviswanathan
This patch adds support for the rmnet_data driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP mode.

Re: [PATCH 02/22] nvmet: Make use of the new sg_map helper function

2017-04-13 Thread Christoph Hellwig
On Thu, Apr 13, 2017 at 04:05:15PM -0600, Logan Gunthorpe wrote: > This is a straight forward conversion in two places. Should kmap fail, > the code will return an INVALD_DATA error in the completion. It really should be using nvmet_copy_from_sgl to make things safer, as we don't want to rely on

[PATCH v2 net 2/2] net: ethernet: mediatek: fix inconsistency of port number carried in TXD

2017-04-13 Thread sean.wang
From: Sean Wang Fix port inconsistency on TXD due to hardware BUG that would cause different port number is carried on the same TXD between tx_map() and tx_unmap() with the iperf test. It would cause confusing BQL logic which leads to kernel panic when dual GMAC runs

[PATCH v2 net 1/2] net: ethernet: mediatek: fix inconsistency between TXD and the used buffer

2017-04-13 Thread sean.wang
From: Sean Wang Fix inconsistency between the TXD descriptor and the used buffer that would cause unexpected logic at mtk_tx_unmap() during skb housekeeping. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 17

[PATCH v2 net 0/2] Fix crash caused by reporting inconsistent skb->len to BQL

2017-04-13 Thread sean.wang
From: Sean Wang Changes since v1: - fix inconsistent enumeration which easily causes the potential bug The series fixes kernel BUG caused by inconsistent SKB length reported into BQL. The reason for inconsistent length comes from hardware BUG which results in different

Re: [PATCH net] xfrm: calculate L4 checksums also for GSO case before encrypting packets

2017-04-13 Thread Ansis Atteka
On 13 April 2017 at 19:45, Ansis Atteka wrote: > > > > On 11 April 2017 at 00:07, Steffen Klassert > wrote: >> >> On Mon, Apr 10, 2017 at 11:42:07AM -0700, Ansis Atteka wrote: >> > Otherwise, if L4 checksum calculation is done after

repost: af_packet vs virtio (was packed ring layout proposal v2)

2017-04-13 Thread Michael S. Tsirkin
On Fri, Apr 14, 2017 at 05:42:58AM +0300, Michael S. Tsirkin wrote: > Hi all, I wanted to raise the question of similarities between virtio > and new zero copy af_packet interfaces. > > First I would like to mention that virtio device development isn't spec > limited - spec is there to help

af_packet vs virtio

2017-04-13 Thread Michael S. Tsirkin
Hi all, I wanted to raise the question of similarities between virtio and new zero copy af_packet interfaces. First I would like to mention that virtio device development isn't spec limited - spec is there to help interoperability and add peace of mind for people worried about IPR. So I tend to

Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-13 Thread Joe Perches
On Thu, 2017-04-13 at 17:48 +1000, Gavin Shan wrote: > This creates /sys/kernel/debug/ncsi//stats to dump the NCSI > packets sent and received over all packages and channels. It's useful > to diagnose NCSI problems, especially when NCSI packages and channels > aren't probed properly. The

Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-13 Thread Jakub Kicinski
Hi! On Thu, 13 Apr 2017 17:48:18 +1000, Gavin Shan wrote: > This creates /sys/kernel/debug/ncsi//stats to dump the NCSI > packets sent and received over all packages and channels. It's useful > to diagnose NCSI problems, especially when NCSI packages and channels > aren't probed properly. The

[PATCH 3/9] netfilter: helper: Add the rcu lock when call __nf_conntrack_helper_find

2017-04-13 Thread Pablo Neira Ayuso
From: Gao Feng When invoke __nf_conntrack_helper_find, it needs the rcu lock to protect the helper module which would not be unloaded. Now there are two caller nf_conntrack_helper_try_module_get and ctnetlink_create_expect which don't hold rcu lock. And the other callers left

[PATCH 7/9] netfilter: nf_ct_expect: use proper RCU list traversal/update APIs

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang We should use proper RCU list APIs to manipulate help->expectations, as we can dump the conntrack's expectations via nfnetlink, i.e. in ctnetlink_exp_ct_dump_table(), where only rcu_read_lock is acquired. So for list traversal, use

[PATCH 9/9] netfilter: ipt_CLUSTERIP: Fix wrong conntrack netns refcnt usage

2017-04-13 Thread Pablo Neira Ayuso
From: Gao Feng Current codes invoke wrongly nf_ct_netns_get in the destroy routine, it should use nf_ct_netns_put, not nf_ct_netns_get. It could cause some modules could not be unloaded. Fixes: ecb2421b5ddf ("netfilter: add and use nf_ct_netns_get/put") Signed-off-by: Gao Feng

[PATCH 1/9] netfilter: xt_TCPMSS: add more sanity tests on tcph->doff

2017-04-13 Thread Pablo Neira Ayuso
From: Eric Dumazet Denys provided an awesome KASAN report pointing to an use after free in xt_TCPMSS I have provided three patches to fix this issue, either in xt_TCPMSS or in xt_tcpudp.c. It seems xt_TCPMSS patch has the smallest possible impact. Signed-off-by: Eric

[PATCH 4/9] netfilter: ctnetlink: make it safer when checking the ct helper name

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang One CPU is doing ctnetlink_change_helper(), while another CPU is doing unhelp() at the same time. So even if help->helper is not NULL at first, the later statement strcmp(help->helper->name, ...) may still access the NULL pointer. So we must use

[PATCH 0/9] Netfilter fixes for net

2017-04-13 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Missing TCP header sanity check in TCPMSS target, from Eric Dumazet. 2) Incorrect event message type for related conntracks created via ctnetlink, from Liping Zhang. 3) Fix incorrect rcu locking when

[PATCH 8/9] netfilter: nft_hash: do not dump the auto generated seed

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang This can prevent the nft utility from printing out the auto generated seed to the user, which is unnecessary and confusing. Fixes: cb1b69b0b15b ("netfilter: nf_tables: add hash expression") Signed-off-by: Liping Zhang Signed-off-by:

[PATCH 6/9] netfilter: ctnetlink: skip dumping expect when nfct_help(ct) is NULL

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang For IPCTNL_MSG_EXP_GET, if the CTA_EXPECT_MASTER attr is specified, then the NLM_F_DUMP request will dump the expectations related to this connection tracking. But we forget to check whether the conntrack has nf_conn_help or not, so if nfct_help(ct) is

[PATCH 5/9] netfilter: make it safer during the inet6_dev->addr_list traversal

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang inet6_dev->addr_list is protected by inet6_dev->lock, so only using rcu_read_lock is not enough, we should acquire read_lock_bh(>lock) before the inet6_dev->addr_list traversal. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira

[PATCH 2/9] netfilter: ctnetlink: using bit to represent the ct event

2017-04-13 Thread Pablo Neira Ayuso
From: Liping Zhang Otherwise, creating a new conntrack via nfnetlink: # conntrack -I -p udp -s 1.1.1.1 -d 2.2.2.2 -t 10 --sport 10 --dport 20 will emit the wrong ct events(where UPDATE should be NEW): # conntrack -E [UPDATE] udp 17 10 src=1.1.1.1 dst=2.2.2.2

Re: [PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

2017-04-13 Thread Pablo Neira Ayuso
On Mon, Apr 10, 2017 at 03:50:44PM -0400, Aaron Conole wrote: > There are no in-tree callers of this function and it isn't exported. Simon, let me know if you want to take this, or just add your Signed-off-by. Thanks! > Signed-off-by: Aaron Conole > --- >

Re: [GIT 0/3] Second Round of IPVS Updates for v4.12

2017-04-13 Thread Pablo Neira Ayuso
On Fri, Apr 14, 2017 at 08:51:19AM +0900, Simon Horman wrote: > On Fri, Apr 14, 2017 at 01:01:34AM +0200, Pablo Neira Ayuso wrote: > > Hi Simon, > > > > On Mon, Apr 10, 2017 at 09:58:32AM -0700, Simon Horman wrote: > > > Hi Pablo, > > > > > > please consider these clean-ups and enhancements to

Re: [GIT 0/3] Second Round of IPVS Updates for v4.12

2017-04-13 Thread Simon Horman
On Fri, Apr 14, 2017 at 01:01:34AM +0200, Pablo Neira Ayuso wrote: > Hi Simon, > > On Mon, Apr 10, 2017 at 09:58:32AM -0700, Simon Horman wrote: > > Hi Pablo, > > > > please consider these clean-ups and enhancements to IPVS for v4.12. > > > > * Removal unused variable > > * Use kzalloc where

Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

2017-04-13 Thread Pablo Neira Ayuso
On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote: > There are no in-tree callers. @Jozsef, let me know if I should just take this to save you a pull request. Thanks. > Signed-off-by: Aaron Conole > --- > net/netfilter/ipset/ip_set_core.c | 8 > 1 file

Re: [PATCH nf-next] nf_conntrack: remove double assignment

2017-04-13 Thread Pablo Neira Ayuso
On Wed, Apr 12, 2017 at 04:32:54PM -0400, Aaron Conole wrote: > The protonet pointer will unconditionally be rewritten, so just do the > needed assignment first. Also applied, thanks.

Re: [PATCH nf-next] nf_tables: remove double return statement

2017-04-13 Thread Pablo Neira Ayuso
Applied, thanks.

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-13 Thread Florian Fainelli
On 04/13/2017 02:51 PM, Andrew Lunn wrote: >> The DT binding is in tree and provides an example of how the switch >> looks like, below is the example, but I am also adding the MDIO bus and >> the PHYs just so you can see how things wind up: >> >> switch_top@f0b0 { >> compatible =

Re: [GIT 0/3] Second Round of IPVS Updates for v4.12

2017-04-13 Thread Pablo Neira Ayuso
Hi Simon, On Mon, Apr 10, 2017 at 09:58:32AM -0700, Simon Horman wrote: > Hi Pablo, > > please consider these clean-ups and enhancements to IPVS for v4.12. > > * Removal unused variable > * Use kzalloc where appropriate > * More efficient detection of presence of NAT extension > > > The

RE: [PATCH v4] smsc95xx: Add comments to the registers definition

2017-04-13 Thread Woojung.Huh
> This chip is used by a lot of embedded devices and also by the Raspberry > Pi 1, 2 & 3 which were created to promote the study of computer > sciences. Students wanting to learn kernel / network device driver > programming through those devices can only rely on the Linux kernel > driver source to

[PATCH 15/22] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

2017-04-13 Thread Logan Gunthorpe
These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe ---

[PATCH 12/22] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper in 4 call sites

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42 +- drivers/scsi/pmcraid.c | 19

[PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c

[PATCH 03/22] libiscsi: Make use of new the sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We also propogate a possible kmap error down and create a new ISCSI_TCP_INTERNAL_ERR error type for this. Signed-off-by: Logan Gunthorpe

[PATCH 07/22] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion to the new function in two crypto drivers. Signed-off-by: Logan Gunthorpe --- crypto/shash.c| 9 ++--- drivers/crypto/caam/caamalg.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 04/22] target: Make use of the new sg_map function at 16 call sites

2017-04-13 Thread Logan Gunthorpe
Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with

[PATCH 18/22] mmc: spi: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/mmc_spi.c | 26

[PATCH 22/22] memstick: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion, but we have to WARN if unmappable memory finds its way into the sgl. Signed-off-by: Logan Gunthorpe --- drivers/memstick/host/jmb38x_ms.c | 23 ++- drivers/memstick/host/tifm_ms.c | 22 +- 2 files

[PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to the new helper, except due to the lack of error path, we have to warn if unmapable memory is ever present in the sgl. Signed-off-by: Logan Gunthorpe --- drivers/block/xen-blkfront.c | 33 +++-- 1 file changed, 27

[PATCH 19/22] mmc: tmio: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion to sg_map helper. A couple paths will WARN if the memory does not end up being mappable. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/tmio_mmc.h | 12 ++-- drivers/mmc/host/tmio_mmc_dma.c | 5 +

[PATCH 05/22] drm/i915: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a single straightforward conversion from kmap to sg_map. Signed-off-by: Logan Gunthorpe --- drivers/gpu/drm/i915/i915_gem.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c

[PATCH 01/22] scatterlist: Introduce sg_map helper functions

2017-04-13 Thread Logan Gunthorpe
This patch introduces functions which kmap the pages inside an sgl. Two variants are provided: one if an offset is required and one if the offset is zero. These functions replace a common pattern of kmap(sg_page(sg)) that is used in about 50 places within the kernel. The motivation for this work

[PATCH 00/22] Introduce common scatterlist map function

2017-04-13 Thread Logan Gunthorpe
Hi Everyone, As part of my effort to enable P2P DMA transactions with PCI cards, we've identified the need to be able to safely put IO memory into scatterlists (and eventually other spots). This probably involves a conversion from struct page to pfn_t but that migration is a ways off and those

[PATCH 08/22] crypto: chcr: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
The get_page in this area looks *highly* suspect due to there being no corresponding put_page. However, I've left that as is to avoid breaking things. I've also removed the KMAP_ATOMIC_ARGS check as it appears to be dead code that dates back to when it was first committed... Signed-off-by: Logan

[PATCH 17/22] mmc: sdhci: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion, except due to the lack of error path we have to WARN if the memory in the SGL is not mappable. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/sdhci.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-)

[PATCH 21/22] mmc: tifm_sd: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of

[PATCH 09/22] dm-crypt: Make use of the new sg_map helper in 4 call sites

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe --- drivers/md/dm-crypt.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/md/dm-crypt.c

[PATCH 20/22] mmc: sdricoh_cs: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c index

[PATCH 14/22] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe --- drivers/scsi/arcmsr/arcmsr_hba.c | 16 drivers/scsi/ips.c | 8 drivers/scsi/megaraid.c | 9 +++-- 3 files changed, 23

[PATCH 02/22] nvmet: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
This is a straight forward conversion in two places. Should kmap fail, the code will return an INVALD_DATA error in the completion. Signed-off-by: Logan Gunthorpe --- drivers/nvme/target/fabrics-cmd.c | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[PATCH 13/22] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 13 +

[PATCH 11/22] RDS: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Straightforward conversion except there's no error path, so we WARN if the sg_map fails. Signed-off-by: Logan Gunthorpe --- net/rds/ib_recv.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index

[PATCH 06/22] crypto: hifn_795x: Make use of the new sg_map helper function

2017-04-13 Thread Logan Gunthorpe
Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-13 Thread Andrew Lunn
> The DT binding is in tree and provides an example of how the switch > looks like, below is the example, but I am also adding the MDIO bus and > the PHYs just so you can see how things wind up: > > switch_top@f0b0 { > compatible = "simple-bus"; > #size-cells = <1>; >

Re: [PATCH v4 net-next RFC] net: Generic XDP

2017-04-13 Thread David Miller
From: Michael Chan Date: Thu, 13 Apr 2017 13:16:43 -0700 > On Thu, Apr 13, 2017 at 9:09 AM, David Miller wrote: >> >> --- >> >> v4: >> - Fix MAC header adjustmnet before calling prog (David Ahern) >> - Disable LRO when generic XDP is installed

Re: [PATCH v4 net-next RFC] net: Generic XDP

2017-04-13 Thread Michael Chan
On Thu, Apr 13, 2017 at 9:09 AM, David Miller wrote: > > --- > > v4: > - Fix MAC header adjustmnet before calling prog (David Ahern) > - Disable LRO when generic XDP is installed (Michael Chan) I don't see where you are disabling LRO in the patch. > - Bypass qdisc et al.

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Johannes Berg Date: Thu, 13 Apr 2017 21:22:21 +0200 > OTOH, it might depend on the frame data itself, if the program does > something like > > xdp->data[xdp->data[0] & 0xf] > > (read or write, doesn't really matter) so then the verifier would have > to take the

Re: net/ipv4: use-after-free in ip_queue_xmit

2017-04-13 Thread Cong Wang
On Thu, Apr 13, 2017 at 11:49 AM, Andrey Konovalov wrote: > On Mon, Apr 10, 2017 at 7:46 PM, Andrey Konovalov > wrote: >> On Mon, Apr 10, 2017 at 7:42 PM, Cong Wang wrote: >>> On Mon, Apr 10, 2017 at 7:40 AM, Andrey

[PATCH block-tree] net: off by one in inet6_pton()

2017-04-13 Thread Dan Carpenter
If "scope_len" is sizeof(scope_id) then we would put the NUL terminator one space beyond the end of the buffer. Fixes: b1a951fe469e ("net/utils: generic inet_pton_with_scope helper") Signed-off-by: Dan Carpenter --- This one goes through Jens' tree not through net-dev.

Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Florian Fainelli
On 04/13/2017 12:11 PM, Grygorii Strashko wrote: > Now the command: > ethtool --phy-statistics eth0 > will cause system crash with meassage "Unable to handle kernel NULL pointer > dereference at virtual address 0010" from: > > (kszphy_get_stats) from []

Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Andrew Lunn
On Thu, Apr 13, 2017 at 10:28:09PM +0300, Sergei Shtylyov wrote: > On 04/13/2017 10:11 PM, Grygorii Strashko wrote: > > >Now the command: > > ethtool --phy-statistics eth0 > >will cause system crash with meassage "Unable to handle kernel NULL pointer > >dereference at virtual address

Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Sergei Shtylyov
On 04/13/2017 10:11 PM, Grygorii Strashko wrote: Now the command: ethtool --phy-statistics eth0 will cause system crash with meassage "Unable to handle kernel NULL pointer dereference at virtual address 0010" from: (kszphy_get_stats) from [] (ethtool_get_phy_stats+0xd8/0x210)

Mac80211 - 802.11s

2017-04-13 Thread prabhu
How to get the vif of mesh stations and does the vif have separate queue structure apart from PHY queues ? I want to get the queue statistics for every mesh station that are associated.

Re: [PATCH 1/5] netlink: extended ACK reporting

2017-04-13 Thread Johannes Berg
On Thu, 2017-04-13 at 16:05 +0200, Nicolas Dichtel wrote: > Sure. It was just to mention that attribute 0 exists somewhere. > The other 0 attribute is OVS_TUNNEL_KEY_ATTR_ID. That looks like some really awkward hand-grown parsing - with all these "struct ovs_len_tbl" looking almost like a

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread Johannes Berg
On Thu, 2017-04-13 at 11:37 -0400, David Miller wrote: > If the capability is variable, it must be communicated to the user > somehow at program load time. > > We are consistently finding that there is this real need to > communicate XDP capabilities, or somehow verify that the needs > of an XDP

[PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Grygorii Strashko
Now the command: ethtool --phy-statistics eth0 will cause system crash with meassage "Unable to handle kernel NULL pointer dereference at virtual address 0010" from: (kszphy_get_stats) from [] (ethtool_get_phy_stats+0xd8/0x210) (ethtool_get_phy_stats) from []

Re: [PATCH v2] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Grygorii Strashko
On 04/13/2017 01:51 PM, Andrew Lunn wrote: On Wed, Apr 12, 2017 at 05:55:10PM -0500, Grygorii Strashko wrote: Now the command: ethtool --phy-statistics eth0 will cause system crash with meassage "Unable to handle kernel NULL pointer dereference at virtual address 0010" from:

Re: [PATCH v2] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-13 Thread Andrew Lunn
On Wed, Apr 12, 2017 at 05:55:10PM -0500, Grygorii Strashko wrote: > Now the command: > ethtool --phy-statistics eth0 > will cause system crash with meassage "Unable to handle kernel NULL pointer > dereference at virtual address 0010" from: > > (kszphy_get_stats) from []

Re: net/ipv4: use-after-free in ip_queue_xmit

2017-04-13 Thread Andrey Konovalov
On Mon, Apr 10, 2017 at 7:46 PM, Andrey Konovalov wrote: > On Mon, Apr 10, 2017 at 7:42 PM, Cong Wang wrote: >> On Mon, Apr 10, 2017 at 7:40 AM, Andrey Konovalov >> wrote: >>> Hi, >>> >>> I've got the following error

Re: [PATCH v4 3/3] VSOCK: Add virtio vsock vsockmon hooks

2017-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2017 at 05:18:11PM +0100, Stefan Hajnoczi wrote: > From: Gerard Garcia > > The virtio drivers deal with struct virtio_vsock_pkt. Add > virtio_transport_deliver_tap_pkt(pkt) for handing packets to the > vsockmon device. > > We call

[Patch net-next] kcm: remove a useless copy_from_user()

2017-04-13 Thread Cong Wang
struct kcm_clone only contains fd, and kcm_clone() only writes this struct, so there is no need to copy it from user. Cc: Tom Herbert Signed-off-by: Cong Wang --- net/kcm/kcmsock.c | 4 1 file changed, 4 deletions(-) diff --git

How to debug DMAR errors?

2017-04-13 Thread Ben Greear
Hello, I have been seeing a regular occurrence of DMAR errors, looking something like this when testing my ath10k driver/firmware under some specific loads (maximum receive of 512 byte frames in AP mode): DMAR: DRHD: handling fault status reg 3 DMAR: [DMA Read] Request device [05:00.0] fault

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-13 Thread Cong Wang
On Thu, Apr 13, 2017 at 1:06 AM, Wolfgang Bumiller wrote: > On Wed, Apr 12, 2017 at 09:27:31PM -0700, Cong Wang wrote: >> Instead of duplicating code, you can add the check >> to the module_put() next to err_mod label? I mean: > > I just realized that with module_put()

Re: [PATCH next] bonding: handle link transition from FAIL to UP correctly

2017-04-13 Thread David Miller
From: Mahesh Bandewar Date: Tue, 11 Apr 2017 22:36:00 -0700 > From: Mahesh Bandewar > > When link transitions from LINK_FAIL to LINK_UP, the commit phase is > not called. This leads to an erroneous state causing slave-link state to > get stuck in "going

Re: [PATCH v2 net-next] net: dwc-xlgmac: add the initial ethtool support

2017-04-13 Thread David Miller
From: Jie Deng Date: Wed, 12 Apr 2017 13:10:06 +0800 > It is necessary to provide ethtool support for displaying and > modifying parameters of dwc-xlgmac. > > Signed-off-by: Jie Deng > --- > v1->v2: > - remove begin() method which is

Re: [PATCH v3 0/4] TI Bluetooth serdev support

2017-04-13 Thread Marcel Holtmann
Hi Rob, > This series adds serdev support to the HCI LL protocol used on TI BT > modules and enables support on HiKey board with with the WL1835 module. > With this the custom TI UIM daemon and btattach are no longer needed. > > The series is available on this git branch[1]. This version is

Re: [PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default_advmss

2017-04-13 Thread David Miller
From: gfree.w...@foxmail.com Date: Wed, 12 Apr 2017 12:34:03 +0800 > From: Gao Feng > > 1. Don't get the metric RTAX_ADVMSS of dst. > There are two reasons. > 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss > before invoke default_advmss. > 2) The

Re: [PATCH net-next v2 0/8] rtnetlink: Cleanup user notifications for netdev events

2017-04-13 Thread David Miller
From: David Ahern Date: Tue, 11 Apr 2017 17:02:39 -0700 > Vlad's recent patch to add the event type to rtnetlink notifications > points out a number of redundant or unnecessary notifications sent to > userspace for events that are essentially internal to the kernel.

[PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

2017-04-13 Thread Matthias Kaehlcke
__ieee80211_amsdu_copy_frag intentionally initializes a pointer to array[-1] to increment it later to valid values. clang rightfully generates an array-bounds warning on the initialization statement. Initialize the pointer to array[0] and change the algorithm from increment before to increment

Re: [PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

2017-04-13 Thread David Miller
From: David Daney Date: Tue, 11 Apr 2017 14:30:52 -0700 > When debugging the JIT on an embedded platform or cross build > environment, libbfd may not be available, making it impossible to run > bpf_jit_disasm natively. > > Add an option to emit a binary image of the JIT

[PATCH net] net: vrf: Fix setting NLM_F_EXCL flag when adding l3mdev rule

2017-04-13 Thread David Ahern
Only need 1 l3mdev FIB rule. Fix setting NLM_F_EXCL in the nlmsghdr. Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") Signed-off-by: David Ahern --- drivers/net/vrf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

2017-04-13 Thread David Miller
From: Florian Fainelli Date: Mon, 10 Apr 2017 14:42:58 -0700 > A MDIO bus driver can set phy_mask to indicate which PHYs should be > probed and which should not. Right now, of_mdiobus_register() always > sets mdio->phy_mask to ~0 which means: don't probe anything yourself,

Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up

2017-04-13 Thread David Ahern
On 4/13/17 5:45 AM, Hannes Frederic Sowa wrote: > > > On Wed, Apr 12, 2017, at 20:49, David Ahern wrote: >> ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is >> set to 1, gratuitous arp requests are sent when the device is brought up. >> The same is expected when ndisc_notify

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-13 Thread David Miller
From: Niklas Cassel Date: Mon, 10 Apr 2017 20:33:29 +0200 > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid

Re: [PATCH net-next] cxgb4: save tid while creating server filter

2017-04-13 Thread David Miller
From: Ganesh Goudar Date: Mon, 10 Apr 2017 21:26:18 +0530 > Save the filter tid while creating the server filter, which is used > later to retrieve the corresponding filter instance while handling > the filter reply. > > Signed-off-by: Ganesh Goudar

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

2017-04-13 Thread David Miller
From: Daniele Palmas Date: Mon, 10 Apr 2017 17:34:23 +0200 > Telit LE920A4 uses the same pid 0x1201 of LE920, but modem > implementation is different, since it requires DTR to be set for > answering to qmi messages. > > This patch replaces QMI_FIXED_INTF with

Re: IGMP on IPv6

2017-04-13 Thread Murali Karicheri
On 03/22/2017 11:04 AM, Murali Karicheri wrote: > Hi Liu, > > I saw that you have sent patches to the list for IGMP and have a question on > IGMP on IPv6. > Hope you can clarify. I have posted the question already to the list and is > reproduced > below. Let me know if you have an answer. > >

[PATCH v4 2/3] VSOCK: Add vsockmon device

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia Add vsockmon virtual network device that receives packets from the vsock transports and exposes them to user space. Based on the nlmon device. Signed-off-by: Gerard Garcia Signed-off-by: Stefan Hajnoczi ---

[PATCH v4 3/3] VSOCK: Add virtio vsock vsockmon hooks

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia The virtio drivers deal with struct virtio_vsock_pkt. Add virtio_transport_deliver_tap_pkt(pkt) for handing packets to the vsockmon device. We call virtio_transport_deliver_tap_pkt(pkt) from net/vmw_vsock/virtio_transport.c and drivers/vhost/vsock.c

[PATCH v4 1/3] VSOCK: Add vsockmon tap functions

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia Add tap functions that can be used by the vsock transports to deliver packets to vsockmon virtual network devices. Signed-off-by: Gerard Garcia Signed-off-by: Stefan Hajnoczi --- v4: * Call synchronize_net()

Re: [RFC PATCH 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-04-13 Thread Willem de Bruijn
On Thu, Apr 13, 2017 at 11:24 AM, Keller, Jacob E wrote: > > >> -Original Message- >> From: Miroslav Lichvar [mailto:mlich...@redhat.com] >> Sent: Thursday, April 13, 2017 8:00 AM >> >> Oh, I see. I was struggling to find a good name for this option. >> >> > The

[PATCH v4 0/3] VSOCK: vsockmon virtual device to monitor AF_VSOCK sockets.

2017-04-13 Thread Stefan Hajnoczi
v4: * Add explicit reserved padding field to struct af_vsockmon_hdr and drop __attribute__((packed)) [Michael, DaveM] * Call synchronize_net() before module_put() [Michael] v3: * Hook virtio_transport.c (guest driver), not just drivers/vhost/vsock.c (host driver) * Fix DEFAULT_MTU macro

Re: [RFC PATCH 3/7] net: add option to get information about timestamped packets

2017-04-13 Thread Willem de Bruijn
On Thu, Apr 13, 2017 at 11:18 AM, Miroslav Lichvar wrote: > On Thu, Apr 13, 2017 at 10:37:07AM -0400, Willem de Bruijn wrote: >> On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar >> wrote: >> > Extend the skb_shared_hwtstamps structure with the index

[patch net-next] MAINTAINERS: rename TC entry and add couple of header files

2017-04-13 Thread Jiri Pirko
From: Jiri Pirko The section is not specific only to "TC classifiers", but applies to the whole TC subsystem. Also, add couple of forgotten headers. Signed-off-by: Jiri Pirko --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [Patch net-next v2] net_sched: move the empty tp check from ->destroy() to ->delete()

2017-04-13 Thread Cong Wang
On Thu, Apr 13, 2017 at 12:28 AM, kbuild test robot <l...@intel.com> wrote: > Hi Cong, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-move-the-empty-tp-check-from-destroy-to-delete/20170413

[PATCH v4 net-next RFC] net: Generic XDP

2017-04-13 Thread David Miller
This provides a generic SKB based non-optimized XDP path which is used if either the driver lacks a specific XDP implementation, or the user requests it via a new IFLA_XDP_FLAGS value named XDP_FLAGS_SKB_MODE. It is arguable that perhaps I should have required something like this as part of the

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Daniel Borkmann Date: Thu, 13 Apr 2017 17:57:06 +0200 > On 04/12/2017 08:54 PM, David Miller wrote: > [...] >> +static u32 netif_receive_generic_xdp(struct sk_buff *skb, >> + struct bpf_prog *xdp_prog) >> +{ >> +struct xdp_buff xdp;

  1   2   >