From: David Miller
Sent: Tuesday, April 25, 2017 7:42 AM
To: herb...@gondor.apana.org.au
Cc: Ghalam, Joe; Wichmann, Clifford; netdev@vger.kernel.org
Subject: Re: macvlan: Fix device ref leak when purging bc_queue
> Applied and queued up for -stable, thanks Herbert.
Herbert and David,
Glad to rep
From: Bert Kenward
Date: Tue, 25 Apr 2017 13:44:54 +0100
> Fixes: dd248f1bc65b ("sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC")
> Reported-by: Patrick Talbert
> Signed-off-by: Bert Kenward
Applied, thanks.
John this isn't how it works.
When you submit new versions of a patch that are part of a patch
series, you must resubmit the entire series not just the patches which
are changing.
Thanks.
On Tue, Apr 25, 2017 at 5:40 AM, Sergei Shtylyov
wrote:
> Hello.
>
> On 4/25/2017 12:50 AM, Eric Anholt wrote:
>
>> Cygnus has a single amac controller connected to the B53 switch with 2
>> PHYs. On the BCM911360_EP platform, those two PHYs are connected to
>> the external ethernet jacks.
>
>
>
On Tue, Apr 25, 2017 at 5:12 PM, Sabrina Dubroca wrote:
>> https://patchwork.ozlabs.org/patch/754861/
>
> Yes, that prevents the overflow, but now you're just dropping
> packets.
Right, it's a so-called "defense-in-depth" measure.
> I'll review that later, let's fix the overflow without
> breaki
Hi Sabrina,
On Tue, Apr 25, 2017 at 4:53 PM, Sabrina Dubroca wrote:
> Ugh, good catch :/
>
> AFAICT this patch doesn't really help, because NETIF_F_FRAGLIST
> doesn't get tested in paths that can lead to triggering this.
You're right. This fixes the xmit() path, but not the receive path,
which a
On Mon, Apr 24, 2017 at 4:00 PM, Singh, Krishneil K
wrote:
>
>
>
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
> Behalf Of Liwei Song
> Sent: Sunday, December 4, 2016 7:41 PM
> To: Kirsher, Jeffrey T
> Cc: netdev@vger.kernel.org; intel-
This is a defense-in-depth measure in response to bugs like
4d6fa57b4dab ("macsec: avoid heap overflow in skb_to_sgvec")
Signed-off-by: Jason A. Donenfeld
---
v4 fixes the commit message and moves the check into the inner-most if.
net/core/skbuff.c | 12 +++-
1 file changed, 11 insertio
During removing a bridge device, if the bridge is still up, a new mdb entry
still can be added in br_multicast_add_group() after all mdb entries are
removed in br_multicast_dev_del(). Like the path:
mld_ifc_timer_expire ->
mld_sendpack -> ...
br_multicast_rcv ->
br_multicast_ad
On 4/25/17 2:06 AM, Jakub Kicinski wrote:
> Also - is anyone working on adding proper extack support to iproute2?
> The code I have right now is a bit of a hack...
This is what I have done:
https://github.com/dsahern/iproute2/commits/ext-ack
Basically, added the parsing code and then a new r
2017-04-21, 23:14:48 +0200, Jason A. Donenfeld wrote:
> While this may appear as a humdrum one line change, it's actually quite
> important. An sk_buff stores data in three places:
>
> 1. A linear chunk of allocated memory in skb->data. This is the easiest
>one to work with, but it precludes u
From: Marc Kleine-Budde
Date: Tue, 25 Apr 2017 10:44:26 +0200
> this is a pull request of 21 patches for net-next/master.
>
> There are 4 patches by Stephane Grosjean for the PEAK PCAN-PCIe FD
> CAN-FD boards. The next 7 patches are by Mario Huettel, which add
> support for M_CAN IP version >= v
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 674c124665ca2ff1bcf81b1b92a207f71a326742
commit: e43eed6b8068f1c570551fe33bed12ef840c956b [6/19] virtio_net: allow
specifying context for rx
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-6 (Debian 6
From: Florian Westphal
Date: Tue, 25 Apr 2017 16:17:49 +0200
> I'd have less of an issue with this if we'd be talking about
> something computationally expensive, but this is about storing
> an extra value inside a struct just to avoid one "shr" in insert path...
Agreed, this shift is probably f
From: "Jason A. Donenfeld"
Date: Tue, 25 Apr 2017 16:08:05 +0200
> This is a defense-in-depth measure in response to bugs like
> 4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee.
>
> Signed-off-by: Jason A. Donenfeld
Please refer to commits in the form:
$(SHA1_ID) ("Commit header line.")
That is, 12
From: Florian Westphal
Date: Thu, 20 Apr 2017 18:08:15 +0200
> commit 4fbae7d83c98c30efc ("ipvlan: Introduce l3s mode") added
> registration of netfilter hooks via nf_register_hooks().
>
> This API provides the illusion of 'global' netfilter hooks by placing the
> hooks in all current and future
From: Herbert Xu
Date: Thu, 20 Apr 2017 20:55:12 +0800
> When a parent macvlan device is destroyed we end up purging its
> broadcast queue without dropping the device reference count on
> the packet source device. This causes the source device to linger.
>
> This patch drops that reference coun
On 04/24/2017, 08:24 PM, David Miller wrote:
> From: Jiri Slaby
> Date: Mon, 24 Apr 2017 19:51:54 +0200
>
>> For example what's the point of making the sk_load_word_positive_offset
>> label a global, callable function? Note that this is exactly the reason
>> why this particular two hunks look wei
On Tue, Apr 25, 2017 at 2:43 PM, Erez Shitrit wrote:
> On Tue, Apr 25, 2017 at 2:14 PM, Or Gerlitz wrote:
>> thanks for the info. Is this bug there since ipoib/bonding day one (and
>> hence my bug...)
>> or was indeed introduced later? if later, can you explain how
>> fc791b633515 introduced th
From: Alexander Kochetkov
Date: Thu, 20 Apr 2017 14:00:04 +0300
> The Ethernet link on an interrupt driven PHY was not coming up if the Ethernet
> cable was plugged before the Ethernet interface was brought up.
>
> The patch trigger PHY state machine to update link state if PHY was requested
>
On Tue, Apr 25, 2017 at 4:36 AM, Jason Wang wrote:
>
>
> On 2017年04月25日 01:49, Willem de Bruijn wrote:
>>
>> @@ -1371,8 +1419,10 @@ static int virtnet_close(struct net_device *dev)
>> /* Make sure refill_work doesn't re-enable napi! */
>> cancel_delayed_work_sync(&vi->refill);
>>
From: Roman Spychała
Date: Thu, 20 Apr 2017 12:04:10 +0200
> From: Roman Spychała
>
> This patch adds support for the PL-27A1 by adding the appropriate
> USB ID's. This chip is used in the goobay Active USB 3.0 Data Link
> and Unitek Y-3501 cables.
>
> Signed-off-by: Roman Spychała
Applied,
From: Daniel Borkmann
> Sent: 24 April 2017 15:41
> To: Alexander Alemayhu; netdev@vger.kernel.org
> Cc: a...@fb.com
> Subject: Re: [PATCH net-next 3/3] samples/bpf: check before defining offsetof
>
> On 04/24/2017 03:31 PM, Alexander Alemayhu wrote:
> > Fixes the following warning
> >
> > samples
> I am looking on Linux thermal framework and on how to cool down the
> system effectively when it hits thermal condition. Already existing
> cooling methods cpu_cooling and clock_cooling are good. However, I
> wanted to go further and dynamically control also a switch ports'
> speed based on therm
This is a defense-in-depth measure in response to bugs like
4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee.
Signed-off-by: Jason A. Donenfeld
---
Sorry for the completely stupid amount of churn - v1,v2,v3 in the span of
two minutes. It's just that after noticing first that nsg needs to be checked,
I al
From: Jamal Hadi Salim
Date: Tue, 25 Apr 2017 08:42:32 -0400
> So are we going to standardize these strings?
No.
> i.e what if some user has written a bash script that depends on this
> string and it gets changed later.
They can't do that.
It's free form extra information an application may o
Herbert Xu wrote:
> On Tue, Apr 25, 2017 at 01:23:56PM +0200, Florian Westphal wrote:
> >
> > What extra cost?
> >
> > The only change is that ht->nelems has to be right-shifted by one,
> > I don't think that warrants extra space in struct rhashtable, its
> > already way too large (I think we can
This is a defense-in-depth measure in response to bugs like
4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee.
Signed-off-by: Jason A. Donenfeld
---
net/core/skbuff.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f86bf69cfb8d
ATENCIÓN;
Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por
el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser
capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de
correo electrónico. Para revalidar su buzón de corre
Signed-off-by: Jason A. Donenfeld
---
drivers/net/macsec.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index dbab05afcdbe..d846f42b99ec 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -733,7 +733,12
Signed-off-by: Jason A. Donenfeld
---
net/ipv4/ah4.c | 8 ++--
net/ipv4/esp4.c | 30 --
net/ipv6/ah6.c | 8 ++--
net/ipv6/esp6.c | 31 +--
4 files changed, 53 insertions(+), 24 deletions(-)
diff --git a/net/ipv4/ah4.c b/net/ipv4
This is a defense-in-depth measure in response to bugs like
4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee.
Signed-off-by: Jason A. Donenfeld
---
net/core/skbuff.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f86bf69cfb8d..3c
Signed-off-by: Jason A. Donenfeld
---
net/rxrpc/rxkad.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index 4374e7b9c7bf..dcf46c9c3ece 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -229,7 +229,9 @@ static int rxkad
Signed-off-by: Jason A. Donenfeld
---
drivers/net/virtio_net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f36584616e7d..1709fd0b4bf7 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1081,
On 25/04/17 16:32, Mike Manning wrote:
> On 24/04/17 20:52, Nikolay Aleksandrov wrote:
>> On 24/04/17 17:09, Mike Manning wrote:
>>> Flood suppression for packets that are not unicast needs to be handled
>>> consistently by also not flooding broadcast packets. As broadcast is a
>>> special case of
Commit a149e7c7ce81 ("ipv6: sr: add support for SRH injection through
setsockopt") introduced handling of IPV6_SRCRT_TYPE_4, but at the same
time restricted it to only IPV6_SRCRT_TYPE_0 and
IPV6_SRCRT_TYPE_4. Previously, ipv6_push_exthdr() and fl6_update_dst()
would also handle other values (ie STR
On Mon, Apr 24, 2017 at 11:18:13AM -0400, Willem de Bruijn wrote:
> On Mon, Apr 24, 2017 at 5:00 AM, Miroslav Lichvar wrote:
> > Would "skb->data - skb->head -
> > skb->mac_header + skb->len" always work as the L2 length for received
> > packets at the time when the cmsg is prepared?
>
> (skb->da
On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote:
> From: Gao Feng
>
> Because the func batadv_softif_init_late allocate some resources and
> it would be invoked in register_netdevice. So we need to invoke the
> func batadv_softif_free instead of free_netdev to cleanup when
> sizeof() when applied to a pointer typed expression gives the size of the
> pointer, not that of the pointed data.
>
> Signed-off-by: Wei Yongjun
Thanks!
Acked-by: Yuval Mintz
I'd also mention that -
Fixes: b5a9ee7cf3be ("qed: Revise QM configuration")
On 24/04/17 20:52, Nikolay Aleksandrov wrote:
> On 24/04/17 17:09, Mike Manning wrote:
>> Flood suppression for packets that are not unicast needs to be handled
>> consistently by also not flooding broadcast packets. As broadcast is a
>> special case of multicast, the same kernel parameter should b
On Tue, Apr 25, 2017 at 01:23:56PM +0200, Florian Westphal wrote:
>
> What extra cost?
>
> The only change is that ht->nelems has to be right-shifted by one,
> I don't think that warrants extra space in struct rhashtable, its
> already way too large (I think we can reduce its size further).
I see
rawv6_send_hdrinc() expects that the buffer copied from the userspace
contains the IPv6 header, so if too few bytes are copied parts of the
header may remain uninitialized.
This bug has been detected with KMSAN.
Signed-off-by: Alexander Potapenko
---
For the record, the KMSAN report:
==
On Tue, Apr 25, 2017 at 10:36:28AM +0200, Waldemar Rymarkiewicz wrote:
> Hi,
>
> I am not much aware of linux networking architecture so I'd like to
> ask first before will start to dig into the code. Appreciate any
> feedback.
>
> I am looking on Linux thermal framework and on how to cool down t
From: Willem de Bruijn
Date: Mon, 24 Apr 2017 13:49:25 -0400
> Add napi for virtio-net transmit completion processing.
Series applied, thanks.
On 17-04-25 08:13 AM, Jiri Pirko wrote:
Tue, Apr 25, 2017 at 01:54:06PM CEST, j...@mojatatu.com wrote:
[..]
-#define TCAA_MAX 1
+/* tcamsg flags stored in attribute TCA_ROOT_FLAGS
+ *
+ * TCA_FLAG_LARGE_DUMP_ON user->kernel to request for larger than
TCA_ACT_MAX_PRIO
+ * actions in a dump.
> From: Gao Feng
>
> These drivers allocate kinds of resources in init routine, and free some
> resources in the destructor of net_device. It may cause memleak when some
> errors happen after register_netdevice invokes the init callback. Because
only
> the uninit callback is invoked in the error
On Mon, Apr 24, 2017 at 5:09 PM, David Ahern wrote:
> Taking down the loopback device wreaks havoc on IPv6 routing. By
> extension, taking down a VRF device wreaks havoc on its table.
>
> Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6
> FIB code while running syzkaller fuzz
On 17-04-25 07:55 AM, Simon Horman wrote:
[..]
I agree something should be done wrt BOS. If the LABEL and TC are to
be left as-is then I think a similar treatment of BOS - that is masking it
- makes sense.
I also agree with statements made earlier in the thread that it is unlikely
that the unus
Fixes: dd248f1bc65b ("sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC")
Reported-by: Patrick Talbert
Signed-off-by: Bert Kenward
---
drivers/net/ethernet/sfc/efx.h | 5 -
drivers/net/ethernet/sfc/workarounds.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a
Good stuff. Question below:
On 17-04-25 04:06 AM, Jakub Kicinski wrote:
Try to carry error messages to the user via the netlink extended
[..]
+nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
+struct netlink_ext_ack *extack)
{
/* XDP-enabled tests *
On Tue, Apr 25, 2017 at 7:04 AM, Cong Wang wrote:
> On Mon, Apr 24, 2017 at 9:47 AM, Cong Wang wrote:
>>
>> We use ipv4 dst in ip6_tunnel and cast an IPv4 neigh key as an
>> IPv6 address...
>>
>>
>> neigh = dst_neigh_lookup(skb_dst(skb),
>>
Hello
When resizing ring buffer on qemu/pcnet32 with linux-next and
CONFIG_DMA_API_DEBUG=y, I got the following trace:
[8862.793779] [ cut here ]
[ 8862.793784] WARNING: CPU: 0 PID: 26592 at
/linux-next/include/linux/dma-mapping.h:505 pcnet32_set_ringparam+0xd55/0xda0
[ 8
From: Stephane Grosjean
This patch adds a text line in the help section of the CAN_PEAK_USB
config item describing the support of the PCAN-USB X6 adapter, which is
already included in the Kernel since 4.9.
Signed-off-by: Stephane Grosjean
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/u
From: Maksim Salau
Allocate buffers on HEAP instead of STACK for local structures
that are to be sent using usb_control_msg().
Signed-off-by: Maksim Salau
Cc: linux-stable # >= v4.8
Signed-off-by: Marc Kleine-Budde
---
drivers/net/can/usb/gs_usb.c | 17 -
1 file changed, 12 i
From: Stephane Grosjean
This patch adds the support of the PCAN-Chip USB, a stamp module for
customer hardware designs, which communicates via USB 2.0 with the
hardware. The integrated CAN controller supports the protocols CAN 2.0 A/B
as well as CAN FD. The physical CAN connection is determined b
following changes since commit 38a98bceaf5f786b931d16826fbb46e73280849b:
Merge branch 'dsa-b53-58xx-fixes' (2017-04-24 18:29:11 -0400)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
tags/linux-can-fixes-for-4.11-20170425
for yo
On 2017-04-25 13:42, Andy Shevchenko wrote:
> On Tue, Apr 25, 2017 at 1:09 PM, Jan Kiszka wrote:
>> On 2017-04-25 12:07, Jan Kiszka wrote:
>>> On 2017-04-25 11:46, Andy Shevchenko wrote:
On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka
wrote:
> On 2017-04-25 09:30, Andy Shevchenko wrot
Tue, Apr 25, 2017 at 01:54:06PM CEST, j...@mojatatu.com wrote:
>From: Jamal Hadi Salim
>
>When you dump hundreds of thousands of actions, getting only 32 per
>dump batch even when the socket buffer and memory allocations allow
>is inefficient.
>
>With this change, the user will get as many as poss
From: Gao Feng
Because the func batadv_softif_init_late allocate some resources and
it would be invoked in register_netdevice. So we need to invoke the
func batadv_softif_free instead of free_netdev to cleanup when fail
to register_netdevice.
Signed-off-by: Gao Feng
---
net/batman-adv/soft-int
From: Gao Feng
These drivers allocate kinds of resources in init routine, and free
some resources in the destructor of net_device. It may cause memleak
when some errors happen after register_netdevice invokes the init
callback. Because only the uninit callback is invoked in the error
handler of r
From: Jamal Hadi Salim
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-by: Jiri Pirko
Signed-off-by: Jamal Hadi Sa
On Mon, Apr 24, 2017 at 07:07:43PM -0700, Jakub Kicinski wrote:
> On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote:
> > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote:
> > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote:
> >
> > >
> > > Hrm. maybe I am wrong.
> > > Lets say user sets all
From: Jamal Hadi Salim
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user space.
With this patch the user sp
From: Jamal Hadi Salim
Changes since v7:
-
Jamal:
Patch 1 went out twice. Resend without two copies of patch 1
changes since v6:
-
1) DaveM:
New rules for netlink messages. From now on we are going to start
checking for bits that are not used and rejecting anyth
From: Jamal Hadi Salim
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given constraints available to the kernel.
Th
From: Jamal Hadi Salim
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-by: Jiri Pirko
Signed-off-by: Jamal Hadi Sa
Grr. I gitta git my git-foo right.
Patch 1 repeated twice - I'll send v8.
cheers,
jamal
From: Jamal Hadi Salim
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-by: Jiri Pirko
Signed-off-by: Jamal Hadi Sa
From: Jamal Hadi Salim
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given constraints available to the kernel.
Th
From: Jamal Hadi Salim
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user space.
With this patch the user sp
From: Jamal Hadi Salim
changes since v6:
-
1) DaveM:
New rules for netlink messages. From now on we are going to start
checking for bits that are not used and rejecting anything we dont
understand. In the future this is going to require major changes
to user space code (tc etc).
On Tue, Apr 25, 2017 at 2:14 PM, Or Gerlitz wrote:
> On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit
> wrote:
>> On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote:
>>> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote:
From: Honggang Li
Minimal hard_header_len set by bond_compu
On Tue, Apr 25, 2017 at 1:09 PM, Jan Kiszka wrote:
> On 2017-04-25 12:07, Jan Kiszka wrote:
>> On 2017-04-25 11:46, Andy Shevchenko wrote:
>>> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote:
On 2017-04-25 09:30, Andy Shevchenko wrote:
> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka
>
On Tue, Apr 25, 2017 at 1:07 PM, Jan Kiszka wrote:
> On 2017-04-25 11:46, Andy Shevchenko wrote:
>> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote:
>>> On 2017-04-25 09:30, Andy Shevchenko wrote:
On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka wrote:
> On 2017-04-24 23:27, Andy Shevchen
From: Wei Yongjun
Fix to return error code -ENODEV from the no PHY found error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/net/ethernet/apm/xgene-v2/mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/apm/xg
Herbert Xu wrote:
> Florian Westphal wrote:
> > no users in the tree, insecure_max_entries is always set to
> > ht->p.max_size * 2 in rhtashtable_init().
> >
> > Replace only spot that uses it with a ht->p.max_size check.
>
> I'd suggest that as this needs to be computed every time we insert
>
On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit wrote:
> On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote:
>> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote:
>>> From: Honggang Li
>>>
>>> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
>>> is smaller than IPOIB_HARD_
On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote:
> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote:
>> From: Honggang Li
>>
>> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
>> is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the
>> size of headroom t
Florian Westphal wrote:
> no users in the tree, insecure_max_entries is always set to
> ht->p.max_size * 2 in rhtashtable_init().
>
> Replace only spot that uses it with a ht->p.max_size check.
I'd suggest that as this needs to be computed every time we insert
an element that you keep the value
On Tue, Apr 25, 2017 at 01:32:59PM +0300, Or Gerlitz wrote:
> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote:
> > From: Honggang Li
> >
> > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
> > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the
> > size
On 24/04/17 13:16, Guillaume Nault wrote:
> Export type of l2tpeth interfaces to userspace
> (/sys/class/net//uevent).
>
> Signed-off-by: Guillaume Nault
Acked-by: James Chapman
On 24/04/17 13:16, Guillaume Nault wrote:
> Export naming scheme used when creating l2tpeth interfaces
> (/sys/class/net//name_assign_type). This let userspace know if
> the device's name has been generated automatically or defined manually.
>
> Signed-off-by: Guillaume Nault
Acked-by: James Chapm
On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote:
> From: Honggang Li
>
> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
> is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the
> size of headroom to avoid skb_under_panic.
sounds terrible, ipoib bonding is
On Tue, Apr 25, 2017 at 05:55:55PM +0800, Honggang LI wrote:
> From: Honggang Li
>
> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
> is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the
> size of headroom to avoid skb_under_panic.
>
> [ 122.871493] ipoib_
On 2017-04-25 12:07, Jan Kiszka wrote:
> On 2017-04-25 11:46, Andy Shevchenko wrote:
>> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote:
>>> On 2017-04-25 09:30, Andy Shevchenko wrote:
On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka wrote:
> On 2017-04-24 23:27, Andy Shevchenko wrote:
>>>
On 2017-04-25 11:46, Andy Shevchenko wrote:
> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote:
>> On 2017-04-25 09:30, Andy Shevchenko wrote:
>>> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka wrote:
On 2017-04-24 23:27, Andy Shevchenko wrote:
> On Mon, Apr 24, 2017 at 10:27 PM, Jan Kisz
On Mon, Apr 24, 2017 at 09:18:39PM +0200, Andreas Kemnade wrote:
> keep tty driver until usb driver is unregistered
> rmmod hso
> produces traces like this without that:
Yeah, a blatant use-after-free.
> Signed-off-by: Andreas Kemnade
Reviewed-by: Johan Hovold
> ---
> drivers/net/usb/hso.c |
From: Honggang Li
Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which
is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the
size of headroom to avoid skb_under_panic.
[ 122.871493] ipoib_hard_header: skb->head= 8808179d9400, skb->data=
8808179d9420, skb
On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka wrote:
> On 2017-04-25 09:30, Andy Shevchenko wrote:
>> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka wrote:
>>> On 2017-04-24 23:27, Andy Shevchenko wrote:
On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka
wrote:
> The IOT2000 is industrial c
On 4/25/2017 12:50 AM, Eric Anholt wrote:
Cygnus has a single amac controller connected to the B53 switch with 2
PHYs. On the BCM911360_EP platform, those two PHYs are connected to
the external ethernet jacks.
Signed-off-by: Eric Anholt
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 60 +++
no users in the tree, insecure_max_entries is always set to
ht->p.max_size * 2 in rhtashtable_init().
Replace only spot that uses it with a ht->p.max_size check.
Signed-off-by: Florian Westphal
---
include/linux/rhashtable.h | 6 ++
lib/rhashtable.c | 6 --
2 files changed, 2
Hello.
On 4/25/2017 12:50 AM, Eric Anholt wrote:
Cygnus has a single amac controller connected to the B53 switch with 2
PHYs. On the BCM911360_EP platform, those two PHYs are connected to
the external ethernet jacks.
My spell checker trips on "amac" and "ethernet" -- perhaps they need
ca
Hello!
On 4/25/2017 12:50 AM, Eric Anholt wrote:
Cygnus is a small family of SoCs, of which we currently have
devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the
same as 58xx, just requiring a tiny bit of setup that was previously
missing.
Signed-off-by: Eric Anholt
---
Docu
On Thu, 20 Apr 2017 10:10:08 -0700
Alexei Starovoitov wrote:
> On Thu, Apr 20, 2017 at 08:10:51AM +0200, Jesper Dangaard Brouer wrote:
> > On Wed, 19 Apr 2017 19:56:13 -0700
> > Alexei Starovoitov wrote:
> >
> > > On Thu, Apr 20, 2017 at 12:51:31AM +0200, Daniel Borkmann wrote:
> > > >
> >
The driver was making changes to the skb_header without
ensuring it was writable (i.e. uncloned).
This patch also removes some boiler plate header size
checking/adjustment code as that is also handled by the
skb_cow_header function used to make header writable.
Please apply to 4.12, important fix.
On 04/25/2017 10:06 AM, Jakub Kicinski wrote:
As we propagate extended ack reporting throughout various paths in
the kernel it may happen that the same function is called with the
extended ack parameter passed as NULL. Make the NL_SET_ERR_MSG()
macro simply print the message to the logs if that
On Wed, Apr 19, 2017 at 09:47:33PM +0200, Linus Lüssing wrote:
> When trying to redirect bridged frames to the bridge device itself or
> a bridge port (brouting) via the dnat target then this currently fails:
>
> The ethernet destination of the frame is dnat'ed to the MAC address of
> the bridge d
On Tue, 2017-04-25 at 07:10 +, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.
> > org] On
> > Behalf Of Benjamin Poirier
> > Sent: Monday, April 24, 2017 12:10 PM
> > To: Neftin, Sasha
> > Cc: kirs...@f1.synalogic.ca; Stefan Priebe ;
> > netdev@vg
On 04/18/2017 06:40 PM, Florian Fainelli wrote:
> On 04/18/2017 06:23 AM, Niklas Cassel wrote:
>> On 01/04/2017 03:33 PM, Florian Fainelli wrote:
>>> On 12/02/2016 09:48 AM, Florian Fainelli wrote:
>> Peppe, any thoughts on this?
>
> I share what you say.
>
> In sum, the EEE m
On 04/25/2017 10:06 AM, Jakub Kicinski wrote:
Hi!
This series is an attempt to make XDP more user friendly by
enabling exploiting the recently added netlink extended ACK
reporting to carry messages to user space.
I made iproute2 parse the extended messages and have it showing
the errors like th
201 - 300 of 327 matches
Mail list logo
