Re: [patch net-next] team: fall back to hash if table entry is empty

Fri, Sep 08, 2017 at 04:25:12AM CEST, ha...@drivescale.com wrote: >If the hash to port mapping table does not have a valid port (i.e. when >a port goes down), fall back to the simple hashing mechanism to avoid >dropping packets. > >Signed-off-by: Jim Hanko Acked-by: Jiri

[PATCH 0/3] net: TCP/IP: A few minor cleanups

The following patch series is an ad hoc "cleanup" that I made while perusing the code (I'm not well versed in this code, so I would not be surprised if there were objections to the changes): [1] net: __sock_cmsg_send(): Remove unused parameter `msg' [2] net: inet_recvmsg(): Remove unnecessary

[PATCH v2] netfilter: xt_hashlimit: fix build error caused by 64bit division

64bit division causes build/link errors on 32bit architectures. It prints out error messages like: ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! The value of avg passed through by userspace in BYTE mode cannot exceed U32_MAX. Which means 64bit division in user2rate_bytes

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

I agree you shouldn't be using debugfs for this, but in the future, if you do write debugfs code, please take the following review into account: On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > +static int dsa_debugfs_create_port(struct dsa_switch *ds, int port) > +{ > +

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On Fri, 8 Sep 2017 00:14:51 +0200 Daniel Borkmann wrote: > + /* This is really only caused by a deliberately crappy > + * BPF program, normally we would never hit that case, > + * so no need to inform someone via tracepoints either, > + * just bail out.

Re: Use after free in __dst_destroy_metrics_generic

[ 3489.194392] __ion_alloc+0x180/0x988 I do not see the __ion_alloc function in my tree. Hi David This function seems to be defined in an Android specific change. https://android.googlesource.com/kernel/msm/+/20a5411d0115b16826f3d327b6abb0192c8a2001 -- Qualcomm Innovation Center, Inc. The

Re: [PATCH net v2] rds: Fix incorrect statistics counting

From: Håkon Bugge Date: Wed, 6 Sep 2017 18:35:51 +0200 > In rds_send_xmit() there is logic to batch the sends. However, if > another thread has acquired the lock and has incremented the send_gen, > it is considered a race and we yield. The code incrementing the >

Re: [PATCH] isdn: isdnloop: fix logic error in isdnloop_sendbuf

From: Arnd Bergmann Date: Wed, 6 Sep 2017 15:38:58 +0200 > gcc-7 found an ancient bug in the loop driver, leading to a condition that > is always false, meaning we ignore the contents of 'card->flags' here: > > drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer

Re: [PATCH net] udp: drop head states only when all skb references are gone

From: Paolo Abeni Date: Wed, 6 Sep 2017 14:44:36 +0200 > After commit 0ddf3fb2c43d ("udp: preserve skb->dst if required > for IP options processing") we clear the skb head state as soon > as the skb carrying them is first processed. > > Since the same skb can be processed

[PATCH] net:netfilter alloc xt_byteslimit_htable with wrong size

From: Zhizhou Tian struct xt_byteslimit_htable used hlist_head, but alloc memory with sizeof(struct list_head) Change-Id: I75bc60e47e0823700d4303c9d763b7995e3b7bb3 Signed-off-by: Zhizhou Tian --- net/netfilter/xt_hashlimit.c | 4 ++-- 1 file

Re: [PATCH net] ip6_gre: update mtu properly in ip6gre_err

From: Xin Long Date: Tue, 5 Sep 2017 17:26:33 +0800 > Now when probessing ICMPV6_PKT_TOOBIG, ip6gre_err only subtracts the > offset of gre header from mtu info. The expected mtu of gre device > should also subtract gre header. Otherwise, the next packets still > can't be

[patch net-next] team: fall back to hash if table entry is empty

If the hash to port mapping table does not have a valid port (i.e. when a port goes down), fall back to the simple hashing mechanism to avoid dropping packets. Signed-off-by: Jim Hanko --- drivers/net/team/team_mode_loadbalance.c | 8 +++- 1 file changed, 7

Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

From: Mike Manning Date: Mon, 4 Sep 2017 15:52:55 +0100 > Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative > addresses") incorrectly assumes that no RTM_NEWADDR are sent for > addresses in tentative state, as this does happen for the standard > IPv6

Re: [patch net] net: sched: fix memleak for chain zero

From: Jiri Pirko Date: Wed, 6 Sep 2017 13:14:19 +0200 > From: Jiri Pirko > > There's a memleak happening for chain 0. The thing is, chain 0 needs to > be always present, not created on demand. Therefore tcf_block_get upon > creation of block calls the

[PATCH] netfilter: xt_hashlimit: fix build error caused by 64bit division

64bit division causes build/link errors on 32bit architectures. It prints out error messages like: ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! The value of avg passed through by userspace in BYTE mode cannot exceed U32_MAX. Which means 64bit division in user2rate_bytes

Re: Use after free in __dst_destroy_metrics_generic

From: Subash Abhinov Kasiviswanathan Date: Thu, 07 Sep 2017 18:52:02 -0600 > [ 3489.194392] __ion_alloc+0x180/0x988 I do not see the __ion_alloc function in my tree.

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

Hi, > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode, which wasn't working after commit 8b426dc54cf4 >> ("bonding: remove hardcoded

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On Thu, Sep 7, 2017 at 5:47 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 7, 2017 at 5:39 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: >> On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov >> wrote: >>> On 7.09.2017

[PATCH net] perf/bpf: fix a clang compilation issue

clang does not support variable length array for structure member. It has the following error during compilation: kernel/trace/trace_syscalls.c:568:17: error: fields must have a constant size: 'variable length array in structure' extension will never be supported unsigned long

Re: Use after free in __dst_destroy_metrics_generic

Should be fixed by: commit ad65a2f05695aced349e308193c6e2a6b1d87112 Author: Wei Wang Date: Sat Jun 17 10:42:35 2017 -0700 ipv6: call dst_hold_safe() properly Thanks for the info Stefano. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Henrik Austad writes: > On Thu, Aug 31, 2017 at 06:26:20PM -0700, Vinicius Costa Gomes wrote: >> Hi, >> >> This patchset is an RFC on a proposal of how the Traffic Control subsystem >> can >> be used to offload the configuration of traffic shapers into network devices >> that

Re: [PATCH] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

On Fri, 8 Sep 2017 01:51:03 +0200 Adam Borowski wrote: > I assume that a blank efuse comes with all ones, thus I did not bother > recognizing other possible junk values. This matches 100% of dongles > I've seen (a single Gembird 8192eu). > > Signed-off-by: Adam Borowski

Re: [PATCH RFC 3/6] The file ksz_common.c contains common code shared by all KSZ switch drivers

Hi Tristram You patches are so badly mangled that they won't apply. So i'm guessing a bit here... What i think is you can do this in three patches: 1) Straight rename of ksz_common.c to ksz9477.c. Makefile changes to fit, no code changes. 2) Move common code back into ksz_common.c. Makefile

Re: Use after free in __dst_destroy_metrics_generic

On Thu, 07 Sep 2017 18:52:02 -0600 Subash Abhinov Kasiviswanathan wrote: > We are seeing a possible use after free in ip6_dst_destroy. > > It appears as if memory of the __DST_METRICS_PTR(old) was freed in some > path and allocated > to ion driver. ion driver has also

Use after free in __dst_destroy_metrics_generic

We are seeing a possible use after free in ip6_dst_destroy. It appears as if memory of the __DST_METRICS_PTR(old) was freed in some path and allocated to ion driver. ion driver has also freed it. Finally the memory is freed by the fib gc and crashes since it is already deallocated. Target is

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On Thu, Sep 7, 2017 at 5:39 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov > wrote: >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load

Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

> +static void ksz_port_cfg(struct ksz_device *dev, int port, int offset, u8 > bits, > + bool set) Hi Tristram As you move these functions around, it would be good to change the prefix to ksz9477_ You have similar functions in the KSZ8795 driver. It is good to keep the

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

On Thu, Sep 07, 2017 at 09:08:58PM +, tristram...@microchip.com wrote: > From: Tristram Ha Hi Tristram Another process thing you are missing. Patch subject should follow a pattern: git log --oneline drivers/net/dsa/mv88e6xxx bb0a2675f72b net: dsa: mv88e6xxx:

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov wrote: > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode,

ATENCIÓN;

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: WARN_ON() in __nf_hook_entries_try_shrink()

On Thu, 7 Sep 2017 17:01:12 -0700 Linus Torvalds wrote: > On shutdown I get this (edited down a bit to be more legible): > > Stopping firewalld - dynamic firewall daemon... > NETFILTER_CFG table=nat family=2 entries=55 > NETFILTER_CFG table=mangle family=2

WARN_ON() in __nf_hook_entries_try_shrink()

On shutdown I get this (edited down a bit to be more legible): Stopping firewalld - dynamic firewall daemon... NETFILTER_CFG table=nat family=2 entries=55 NETFILTER_CFG table=mangle family=2 entries=40 NETFILTER_CFG table=raw family=2 entries=28 NETFILTER_CFG table=security family=2

[PATCH] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

I assume that a blank efuse comes with all ones, thus I did not bother recognizing other possible junk values. This matches 100% of dongles I've seen (a single Gembird 8192eu). Signed-off-by: Adam Borowski --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 6

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded value"). > > It

Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Thu, Sep 07, 2017 at 10:29:34PM +, tristram...@microchip.com wrote: > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Thursday, September 07, 2017 2:56 PM > > To: Tristram Ha - C24268 > > Cc: muva...@gmail.com; pa...@ucw.cz;

Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

> Sorry about that. It seems my e-mail system wraps the line too soon. git send-email should solve your problems. Andrew

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

> > > Signed-off-by: Tristram Ha > > > --- > > > diff --git a/drivers/net/dsa/microchip/Makefile > > > b/drivers/net/dsa/microchip/Makefile > > > index ed335e2..0961c30 100644 > > > --- a/drivers/net/dsa/microchip/Makefile > > > +++ b/drivers/net/dsa/microchip/Makefile

Re: latest netdev net-next kernel panic

What is weird - changed in bios and enabled p-states and no panic from 30 minutes w  00:38:07 up 33 min,  2 users,  load average: 0.10, 0.13, 0.17 USER TTY    LOGIN@   IDLE   JCPU   PCPU WHAT So the problem can be related to some cpu weird stuff with c/p states or it is random. W

Re: [PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

On 9/7/17 3:14 PM, Daniel Borkmann wrote: Fixes: 97f91a7cf04f ("bpf: add bpf_redirect_map helper routine") Reported-by: Jesper Dangaard Brouer Signed-off-by: Daniel Borkmann Signed-off-by: John Fastabend ---

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

On Thu, Sep 07, 2017 at 09:17:16PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ8795 switch support with function code. > > Signed-off-by: Tristram Ha > --- > diff --git a/drivers/net/dsa/microchip/ksz8795.c >

RE: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, September 07, 2017 2:56 PM > To: Tristram Ha - C24268 > Cc: muva...@gmail.com; pa...@ucw.cz; nathan.leigh.con...@gmail.com; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; >

RE: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, September 07, 2017 2:25 PM > To: Tristram Ha - C24268 > Cc: muva...@gmail.com; pa...@ucw.cz; nathan.leigh.con...@gmail.com; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; >

RE: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, September 07, 2017 2:33 PM > To: Tristram Ha - C24268 > Cc: muva...@gmail.com; pa...@ucw.cz; nathan.leigh.con...@gmail.com; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; >

RE: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Pavel Machek > Sent: Monday, September 4, 2017 9:26 AM > To: Matthew Tan > Cc: michael.kardo...@nxp.com; Williams, Mitch A > ; linux-ker...@vger.kernel.org; >

[PATCH net] bpf: don't select potentially stale ri->map from buggy xdp progs

We can potentially run into a couple of issues with the XDP bpf_redirect_map() helper. The ri->map in the per CPU storage can become stale in several ways, mostly due to misuse, where we can then trigger a use after free on the map: i) prog A is calling bpf_redirect_map(), returning XDP_REDIRECT

Re: [PATCH iproute2 0/4] Add support for dpipe's global header formatting

On Thu, 7 Sep 2017 17:26:39 +0300 Arkadi Sharshevsky wrote: > Some dpipe's global header values need special formatting, for example > Ethernet and IP addresses. This patchset adds support for IPv4/6 and > Ethernet's special format. > > Arkadi Sharshevsky (4): >

Re: [PATCH iproute2 3/4] devlink: Update devlink UAPI file

On Thu, 7 Sep 2017 17:26:42 +0300 Arkadi Sharshevsky wrote: > Update devlink UAPI file. > > Signed-off-by: Arkadi Sharshevsky > Signed-off-by: Jiri Pirko > --- > include/linux/devlink.h | 18 ++ > 1 file changed,

Re: latest netdev net-next kernel panic

Also this panic occured about 3 minutes after traffic rise to 40G before host was working without trafic for about 30minutes - after traffic start to flow this bug start. Now i have this host without traffic and it is working for almost 1 hour :) W dniu 2017-09-07 o 23:47, Paweł Staszewski

Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Thu, Sep 07, 2017 at 09:17:10PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ8795 switch support with SPI access. > > Signed-off-by: Tristram Ha > --- > diff --git a/drivers/net/dsa/microchip/Makefile >

Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

> -- compatible: For external switch chips, compatible string must be exactly > one > - of: "microchip,ksz9477" > +- compatible: Should be "microchip,ksz9477" for KSZ9477 chip, > + "microchip,ksz8795" for KSZ8795 chip, > + "microchip,ksz8794" for KSZ8794 chip, > +

RE: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

> >>> If someone is using GPIO descriptors with GPIO disabled, i.e. calling > >>> gpiod_get() and friends, this is very likely to be a bug, and what > >>> the driver wants to do is: > >>> > >>> depends on GPIOLIB > >>> > >>> or > >>> > >>> select GPIOLIB > >>> > >>> in Kconfig. The whole

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Thu, 2017-09-07 at 18:18 +0200, Henrik Austad wrote: > On Thu, Sep 07, 2017 at 05:53:15PM +0200, Richard Cochran wrote: > > On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > > > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > > > And if you want to this driver

Re: latest netdev net-next kernel panic

Hi Eric today upgraded some host from 4.13.0-rc7+ to latest net-next from git and run some tests simulate clients traffic 40Gbit / 5Mpps mixed tcp + udp There is also bgpd running that feeds FIB with full bgp feed - about 700k prefixes (so routing tables is about 700k routes with about 300

Re: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

On Thu, Sep 07, 2017 at 09:09:30PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > The KSZ tail tag code can be used by different KSZ switch drivers. > > Signed-off-by: Tristram Ha > --- > diff --git a/net/dsa/tag_ksz.c

Re: [PATCH RFC 5/6] Switch SPI driver calls its own driver switch register function

On Thu, Sep 07, 2017 at 09:09:22PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > SPI driver calls own specific switch register function. > Shutdown callback function is added to reset switch to default state. > > Signed-off-by: Tristram Ha

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

On 09/07/2017 02:33 PM, Linus Walleij wrote: > On Thu, Sep 7, 2017 at 11:30 PM, wrote: >>> If someone is using GPIO descriptors with GPIO disabled, i.e. calling >>> gpiod_get() and friends, this is very likely to be a bug, and what >>> the driver wants to do is: >>>

Re: latest netdev net-next kernel panic

On Thu, 2017-09-07 at 23:30 +0200, Paweł Staszewski wrote: > I want to mention also here cause last trace for RIP was dst_dev_put > > https://bugzilla.kernel.org/attachment.cgi?id=258259 Can you provide a bit more context ? Thanks !

Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

On Thu, Sep 7, 2017 at 11:30 PM, wrote: >> If someone is using GPIO descriptors with GPIO disabled, i.e. calling >> gpiod_get() and friends, this is very likely to be a bug, and what >> the driver wants to do is: >> >> depends on GPIOLIB >> >> or >> >> select GPIOLIB

Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

On Thu, Sep 07, 2017 at 09:09:04PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Create new ksz9477.c file from original ksz_common.c. > > Signed-off-by: Tristram Ha > --- > diff --git a/drivers/net/dsa/microchip/ksz9477.c

latest netdev net-next kernel panic

I want to mention also here cause last trace for RIP was dst_dev_put https://bugzilla.kernel.org/attachment.cgi?id=258259

RE: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

> If someone is using GPIO descriptors with GPIO disabled, i.e. calling > gpiod_get() and friends, this is very likely to be a bug, and what > the driver wants to do is: > > depends on GPIOLIB > > or > > select GPIOLIB > > in Kconfig. The whole optional thing is mainly a leftover from when

Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

On Thu, Sep 07, 2017 at 09:08:58PM +, tristram...@microchip.com wrote: > From: Tristram Ha > > Break ksz_common.c into 2 files so that the common code can be used by other > KSZ switch drivers. > > Signed-off-by: Tristram Ha > --- >

Re: Can you help to analyze this panic issue when using VPN?

On Thu, Sep 7, 2017 at 3:18 AM, Songchuan wrote: > <4>[ 1730.085113s][pid:1928,cpu3,HeapTaskDaemon]CPU: 3 PID: 1928 Comm: > HeapTaskDaemon Tainted: GB W 4.1.18-kasan-g6e99722-dirty #1 Sorry, 4.1 is too old for upstream. As you know 4.13 is just out. Please try

[PATCH RFC 1/5] Add KSZ8795 switch driver support in Kconfig

From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig index a8b8f59..0b6225e 100644 ---

[PATCH RFC 0/5] Add DSA driver support for KSZ8795 switch

From: Tristram Ha This series of patches is to add DSA driver support for KSZ8795 switch. Previous patches for KSZ9477 have to be applied first before these. This patch set is against net-next. drivers/net/dsa/microchip/Kconfig | 18 +

[PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile index 0961c30..0d8ba48 100644 ---

[PATCH RFC 4/5] Add KSZ8795 register definitions

From: Tristram Ha Add KSZ8795 switch support with register definitions. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795.h b/drivers/net/dsa/microchip/ksz8795.h new file mode 100644 index 000..005eda5 ---

[PATCH RFC 5/5] Add KSZ8795 SPI driver

From: Tristram Ha Add KSZ8795 switch support with SPI access. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c new file mode 100644 index 000..0f9c731 ---

[PATCH RFC 3/5] Add KSZ8795 switch driver

From: Tristram Ha Add KSZ8795 switch support with function code. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c new file mode 100644 index 000..e4d4e6a ---

[PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added

From: Tristram Ha Add other KSZ switches support so that patch check does not complain. Signed-off-by: Tristram Ha --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 117 -- 1 file changed, 62 insertions(+), 55

[PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

From: Tristram Ha This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code. This patch set is against net-next. drivers/net/dsa/microchip/Makefile |2 +-

[PATCH RFC 4/6] The common header ksz_priv.h does not contain chip specific data

From: Tristram Ha The header ksz_priv.h is used by all KSZ switch drivers so chip specific data are removed and commonly used variables are added. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_priv.h

[PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers.

From: Tristram Ha Break ksz_common.c into 2 files so that the common code can be used by other KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile index

[PATCH RFC 5/6] Switch SPI driver calls its own driver switch register function

From: Tristram Ha SPI driver calls own specific switch register function. Shutdown callback function is added to reset switch to default state. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_spi.c

[PATCH RFC 3/6] The file ksz_common.c contains common code shared by all KSZ switch drivers

From: Tristram Ha The file ksz_common.c only holds common code used by all KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index

[PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers

From: Tristram Ha The KSZ tail tag code can be used by different KSZ switch drivers. Signed-off-by: Tristram Ha --- diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 010ca0a..d5faf14 100644 --- a/net/dsa/tag_ksz.c +++

[PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in ksz_common.c

From: Tristram Ha Create new ksz9477.c file from original ksz_common.c. Signed-off-by: Tristram Ha --- diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c new file mode 100644 index 000..bc722b4 ---

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

Thu, Sep 07, 2017 at 07:45:49PM CEST, xiyou.wangc...@gmail.com wrote: >On Wed, Sep 6, 2017 at 11:32 PM, Jiri Pirko wrote: >> Thu, Sep 07, 2017 at 06:26:07AM CEST, xiyou.wangc...@gmail.com wrote: >>>This patch fixes the following madness of tc filter chain: >> >> Could you avoid

Re: [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 11:34 AM, Florian Fainelli wrote: > On 09/07/2017 04:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and bandwidth >> rate limits are offloaded to the hardware. The existing mqprio

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Hi Henrik, Thanks for your feedback! I'll address some of your comments below. On Thu, 2017-09-07 at 07:34 +0200, Henrik Austad wrote: > > As for the shapers config interface: > > > >  * CBS (802.1Qav) > > > >    This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line > > is: >

[PATCH] net: tulip: Constify tulip_tbl

It looks like all users of tulip_tbl are reads, so mark this table as read-only. $ git grep tulip_tbl # edited to avoid line-wraps... interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ... interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs&~RxPollInt, ... interrupt.c:

Re: [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 09/07/2017 04:00 AM, Amritha Nambiar wrote: > The following series introduces a new hardware offload mode in > tc/mqprio where the TCs, the queue configurations and > bandwidth rate limits are offloaded to the hardware. The existing > mqprio framework is extended to configure the queue counts

Re: [Patch net v2 2/2] net_sched: fix all the madness of tc filter chain

On Wed, Sep 6, 2017 at 11:32 PM, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 06:26:07AM CEST, xiyou.wangc...@gmail.com wrote: >>This patch fixes the following madness of tc filter chain: > > Could you avoid expressive words like "madness" and such? > Please be technical. > If the

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 10:22 AM, Nambiar, Amritha wrote: On 9/7/2017 9:45 AM, Shannon Nelson wrote: [...] It would be nice to know what has changed since the last review, either summarized here or in the individual patch files. [...] For all those patch files that have changed since the last

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 9:45 AM, Shannon Nelson wrote: > On 9/7/2017 4:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and >> bandwidth rate limits are offloaded to the hardware. The existing >> mqprio

Re: Bad escapes in ip -online

On Thu, 7 Sep 2017 12:08:56 -0400 John Kodis wrote: > The -online option to the 'ip link', 'ip addr', and perhaps others is > putting out a backslash in places where a newline character should go, > as so: > > 1: lo: mtu 65536 qdisc noqueue state

Re: nfp bpf offload add/replace

On Thu, 7 Sep 2017 16:05:03 +0200, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 03:44:12PM CEST, kubak...@wp.pl wrote: > >On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: > >> Hi Kuba. > >> > >> I'm looking into cls_bpf code and nfp_net_bpf_offload function in your > >> driver. Why do you need

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 4:00 AM, Amritha Nambiar wrote: The following series introduces a new hardware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The existing mqprio framework is extended to configure the queue counts and layout

Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Luciano Coelho wrote: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new

Re: pull-request: mac80211 2017-09-07

From: Johannes Berg Date: Thu, 7 Sep 2017 09:09:38 +0200 > During my long absence some things have accumulated, but there wasn't > actually all that much that could've gone into the last cycle, and a > fix or two was taken care of by others. > > The most important

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

Linus Torvalds writes: > On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo wrote: >> >> Linus, do you want to apply this directly or should we take it via the >> normal route (wireless-drivers -> net)? If your prefer the latter when >> I'm planning

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Thu, Sep 07, 2017 at 05:53:15PM +0200, Richard Cochran wrote: > On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > > And if you want to this driver to act as a bridge, how do you accomodate > > change in network

Bad escapes in ip -online

The -online option to the 'ip link', 'ip addr', and perhaps others is putting out a backslash in places where a newline character should go, as so: 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000\link/loopback 00:00:00:00:00:00 brd

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R.

Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

On Thu, Sep 7, 2017 at 5:39 AM, Kalle Valo wrote: > > Linus, do you want to apply this directly or should we take it via the > normal route (wireless-drivers -> net)? If your prefer the latter when > I'm planning to submit this to Dave in a day or two and expecting it to >

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Thu, Sep 07, 2017 at 05:27:51PM +0200, Henrik Austad wrote: > On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > And if you want to this driver to act as a bridge, how do you accomodate > change in network requirements? (i.e. how does this work with switchdev?) To my

[PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del

Don't remove rx_napi specifically just before free_netdev(), it's supposed to be done in it and is confusing w/o tx_napi deletion. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/netcp_core.c | 1 - 1 file changed, 1 deletion(-)

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

On Thu, Sep 07, 2017 at 02:40:18PM +0200, Richard Cochran wrote: > On Thu, Sep 07, 2017 at 07:34:11AM +0200, Henrik Austad wrote: > > Also, does this mean that when you create the qdisc, you have locked the > > bandwidth for the scheduler? Meaning, if I later want to add another > > stream that

Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

Acked-by: Latchesar Ionkov On Wed, Sep 6, 2017 at 8:59 AM, Tuomas Tynkkynen wrote: > These two patches fix two hard-to-hit (but really annoying) bugs in 9p. > The first one was posted earlier in February (with one R-b), the second > is a new one. > > Both of

Re: [V2 PATCH net-next 2/2] xdp: catch invalid XDP_REDIRECT API usage

On 09/07/2017 04:13 PM, Daniel Borkmann wrote: [...] +uint64_t addr = (unsigned long)prog; And of course: s/uint64_t/u64/. Lack of context switch. ;-)

  1   2   >