Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-09 Thread Steffen Klassert
On Wed, Jan 10, 2018 at 08:42:19AM +0100, Tobias Hommel wrote: > On Tue, Jan 09, 2018 at 03:49:21PM +0100, Tobias Hommel wrote: > > On Tue, Jan 09, 2018 at 10:26:24AM +0100, Steffen Klassert wrote: > > > On Tue, Jan 09, 2018 at 10:06:51AM +0100, Tobias Hommel wrote: > > > > > > > > > > You have

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-09 Thread Tobias Hommel
On Tue, Jan 09, 2018 at 03:49:21PM +0100, Tobias Hommel wrote: > On Tue, Jan 09, 2018 at 10:26:24AM +0100, Steffen Klassert wrote: > > On Tue, Jan 09, 2018 at 10:06:51AM +0100, Tobias Hommel wrote: > > > > > > > > You have CONFIG_INET_ESP_OFFLOAD enabled, this is new maybe it > > > > still has

Re: [PATCH 04/18] arm: implement nospec_ptr()

2018-01-09 Thread Hanjun Guo
On 2018/1/10 10:04, Laura Abbott wrote: > On 01/05/2018 05:10 PM, Dan Williams wrote: >> From: Mark Rutland >> >> This patch implements nospec_ptr() for arm, following the recommended >> architectural sequences for the arm and thumb instruction sets. >> > Fedora picked up

[PATCH v2 2/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

2018-01-09 Thread Phil Reid
devm_gpiod_get_optional() can return an error in addition to a NULL ptr. Check for error and propagate that to the probe function. Check return value in probe. This will now handle EPROBE_DEFER for the reset gpio. Signed-off-by: Phil Reid ---

[PATCH v2 0/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

2018-01-09 Thread Phil Reid
Errors need to be prograted back from probe. Note: I have only compile tested the code as I don't have the hardware. Egil Hjelmeland has tested it but I haven't added at Test-by: wasn't in the standard form. Not sure if that's ok or not. Changes from v1: - rebased on

[PATCH v2 1/2] net: dsa: lan9303: make lan9303_handle_reset() a void function

2018-01-09 Thread Phil Reid
lan9303_handle_reset never returns anything other than success. So there's not need for it to return an error code. Signed-off-by: Phil Reid --- drivers/net/dsa/lan9303-core.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2 2/3] net: Add BUG_ON() to get_net()

2018-01-09 Thread Kirill Tkhai
On 09.01.2018 21:52, Eric Dumazet wrote: > On Tue, 2018-01-09 at 18:00 +0300, Kirill Tkhai wrote: >> Since people may mistakenly obtain destroying net >> from net_namespace_list and from net::netns_ids >> without checking for its net::counter, let's protect >> against such situations and insert

[PATCH net-next] tcp: make local function tcp_recv_timestamp static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: net/ipv4/tcp.c:1736:6: warning: symbol 'tcp_recv_timestamp' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp.c

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-09 Thread Steffen Klassert
On Tue, Jan 09, 2018 at 03:49:21PM +0100, Tobias Hommel wrote: > > I copied the config from my 4.14.12 sources to a fresh 4.13.16 source tree, > ran > `make olddefconfig` and built a new kernel. > The kernel config is attached as kernel-4.13.16.config. > The panic*.log files are kernel logs from

[PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-01-09 Thread Wei Yongjun
Fix to return a negative error code from the xdp_rxq_info_reg() error handling case instead of 0, as done elsewhere in this function. Fixes: 0ddf543226ac ("xdp/mlx5: setup xdp_rxq_info") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3

[PATCH V2] ipvlan: fix ipvlan MTU limits

2018-01-09 Thread liuqifa
From: Keefe Liu The MTU of ipvlan interface should not bigger than the phy device, When we run following scripts, we will find there are some problems. Step1: ip link add link eth0 name ipv1 type ipvlan mode l2 ip netns add net1 ip link set dev ipv1

[PATCH net-next] i40e: Make local function i40e_get_link_speed static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/intel/i40e/i40e_main.c:5440:5: warning: symbol 'i40e_get_link_speed' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1

Re: RFC(V3): Audit Kernel Container IDs

2018-01-09 Thread Richard Guy Briggs
On 2018-01-09 11:18, Simo Sorce wrote: > On Tue, 2018-01-09 at 07:16 -0500, Richard Guy Briggs wrote: > > Containers are a userspace concept. The kernel knows nothing of them. > > > > The Linux audit system needs a way to be able to track the container > > provenance of events and actions.

[PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: net/netfilter/core.c:380:6: warning: symbol '__nf_unregister_net_hook' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/netfilter/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next] netfilter: nf_tables: fix a typo in nf_tables_getflowtable()

2018-01-09 Thread Wei Yongjun
Fix a typo, we should check 'flowtable' instead of 'table'. Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend") Signed-off-by: Wei Yongjun --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: RFC(V3): Audit Kernel Container IDs

2018-01-09 Thread Richard Guy Briggs
On 2018-01-09 19:05, Eric W. Biederman wrote: > Please let's have a description of the problem you are trying to solve. I thought the first sentence of the second paragraph summed it up rather well. Here are the elaborated motivations: - Filter unwanted, irrelevant or unimportant messages

Re: [net-next v2 15/15] i40e: link_down_on_close private flag support

2018-01-09 Thread Jakub Kicinski
On Tue, 9 Jan 2018 08:19:30 -0800, Jeff Kirsher wrote: > From: Mariusz Stachura > > This patch introduces new ethtool private flag used for > forcing true link state. Function i40e_force_link_state that implements > this functionality was added, it sets phy_type = 0

[PATCH net-next] cxgb4vf: Fix SGE FL buffer initialization logic for 64K pages

2018-01-09 Thread Ganesh Goudar
From: Arjun Vynipadath We'd come in with SGE_FL_BUFFER_SIZE[0] and [1] both equal to 64KB and the extant logic would flag that as an error. This was already fixed in cxgb4 driver with "92ddcc7 cxgb4: Fix some small bugs in t4_sge_init_soft() when our Page Size is 64KB".

Re: A cry for help, please don't ignore!

2018-01-09 Thread Sandra Younes
Good Day, Forgive my indignation if this message comes to you as a surprise and may offend your personality for contacting you without your prior consent and writing through this channel. I came across your name and contact on the course of my personal searching when i was searching for a

Re: linux-next: build failure after merge of the net-next tree

2018-01-09 Thread Jason Wang
On 2018年01月10日 12:06, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (sparc64 defconfig) failed like this: net/socket.o: In function `tun_xdp_to_ptr': (.text+0x3180): multiple definition of `tun_xdp_to_ptr'

[PATCH bpf-next 03/14] nfp: bpf: round up the size of the stack

2018-01-09 Thread Jakub Kicinski
Kernel enforces the alignment of the bottom of the stack, NFP deals with positive offsets better so we should align the top of the stack. Round the stack size to NFP word size (4B). Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/offload.c

[PATCH bpf-next 01/14] nfp: don't try to register XDP rxq structures on control queues

2018-01-09 Thread Jakub Kicinski
Some RX rings are used for control messages, those will not have a netdev pointer in dp. Skip XDP rxq handling on those rings. Fixes: 7f1c684a8966 ("nfp: setup xdp_rxq_info") Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe

[PATCH bpf-next 12/14] nfp: bpf: add signed jump insns

2018-01-09 Thread Jakub Kicinski
From: Nic Viljoen This patch adds signed jump instructions (jsgt, jsge, jslt, jsle) to the nfp jit. As well as adding the additional required raw assembler branch mask to nfp_asm.h Signed-off-by: Nic Viljoen Reviewed-by: Jiong Wang

[PATCH bpf-next 08/14] nfp: bpf: relocate jump targets just before the load

2018-01-09 Thread Jakub Kicinski
Don't translate the program assuming it will be loaded at a given address. This will be required for sharing programs between ports of the same NIC, tail calls and subprograms. It will also make the jump targets easier to understand when dumping the program to user space. Translate the program

[PATCH bpf-next 05/14] nfp: bpf: allow disabling TC offloads when XDP active

2018-01-09 Thread Jakub Kicinski
TC BPF offload was added first, so we used to assume that the ethtool TC HW offload flag cannot be touched whenever any BPF program is loaded on the NIC. This unncessarily limits changes to the TC flag when offloaded program is XDP. Signed-off-by: Jakub Kicinski

[PATCH bpf-next 06/14] nfp: bpf: move jump resolution to jit.c

2018-01-09 Thread Jakub Kicinski
Jump target resolution should be in jit.c not offload.c. No functional changes. Signed-off-by: Jakub Kicinski Reviewed-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 23 +++

[PATCH bpf-next 07/14] nfp: bpf: add helpers for modifying branch addresses

2018-01-09 Thread Jakub Kicinski
In preparation for better handling of relocations move existing helper for setting branch offset to nfp_asm.c and add two more. Signed-off-by: Jakub Kicinski Reviewed-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 12

[PATCH bpf-next 11/14] nfp: hand over to BPF offload app at coarser granularity

2018-01-09 Thread Jakub Kicinski
Instead of having an app callback per message type hand off all offload-related handling to apps with one "rest of ndo_bpf" callback. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

[PATCH bpf-next 14/14] nfp: bpf: reuse verifier log for debug messages

2018-01-09 Thread Jakub Kicinski
From: Quentin Monnet Now that `bpf_verifier_log_write()` is exported from the verifier and makes it possible to reuse the verifier log to print messages to the standard output, use this instead of the kernel logs in the nfp driver for printing error messages

[PATCH bpf-next 13/14] bpf: export function to write into verifier log buffer

2018-01-09 Thread Jakub Kicinski
From: Quentin Monnet Rename the BPF verifier `verbose()` to `bpf_verifier_log_write()` and export it, so that other components (in particular, drivers for BPF offload) can reuse the user buffer log to dump error messages at verification time. Renaming `verbose()`

[PATCH bpf-next 10/14] nfp: bpf: use a large constant in unresolved branches

2018-01-09 Thread Jakub Kicinski
To make absolute relocated branches (branches which will be completely rewritten with br_set_offset()) distinguishable in user space dumps from normal jumps add a large offset to them. Signed-off-by: Jakub Kicinski Reviewed-by: Jiong Wang

[PATCH bpf-next 09/14] nfp: bpf: don't depend on high order allocations for program image

2018-01-09 Thread Jakub Kicinski
The translator pre-allocates a buffer of maximal program size. Due to HW/FW limitations the program buffer can't currently be longer than 128Kb, so we used to kmalloc() it, and then map for DMA directly. Now that the late branch resolution is copying the program image anyway, we can just

[PATCH bpf-next 04/14] nfp: bpf: don't allow changing MTU above BPF offload limit when active

2018-01-09 Thread Jakub Kicinski
When BPF offload is active we need may need to restrict the MTU changes more than just to the limitation of the kernel XDP datapath. Allow the BPF code to veto a MTU change. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 20

[PATCH bpf-next 02/14] nfp: fix incumbent kdoc warnings

2018-01-09 Thread Jakub Kicinski
We should use % instead of @ for documenting preprocessor defines. Add missing documentation of __NFP_REPR_TYPE_MAX. This gets rid of all remaining kdoc warnings in the driver. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h |

[PATCH bpf-next 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates

2018-01-09 Thread Jakub Kicinski
Hi! This series starts with a fix to Jesper's recent work, somehow I forgot about control rings during review. Second patch is cleaning up a vNIC header, in kdoc we should not use @ for #define constants. Aligning of the top of the stack as well as bottom (last bytes will be unused) helps the

RE: [PATCH net-next 3/3] r8169: improve runtime pm in general and suspend unused ports

2018-01-09 Thread Hayes Wang
> Heiner Kallweit [mailto:hkallwe...@gmail.com] > > Sent: Tuesday, January 09, 2018 4:39 AM > [...] > > - Change rtl8169_runtime_suspend to power down the chip if the > > interface is down. > > The original driver has done it. I don't think you have to do it again in >

Re: [PATCH net-next 00/18] ipv6: Align nexthop behaviour with IPv4

2018-01-09 Thread David Ahern
On 1/9/18 1:04 AM, Ido Schimmel wrote: > On Sun, Jan 07, 2018 at 10:20:11AM -0700, David Ahern wrote: >> One of many follow on changes that would be beneficial is to remove the >> idev dereference in the hot path to check the >> ignore_routes_with_linkdown sysctl. > > When a netdev loses its

Re: [PATCH net-next 0/4] ipv6: Add support for non-equal-cost multipath

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > This set aims to add support for IPv6 non-equal-cost multipath routes. > The first three patches convert multipath selection to use the > hash-threshold method (RFC 2992) instead of modulo-N. The same method is > employed by the IPv4 routing code since

linux-next: build failure after merge of the net-next tree

2018-01-09 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (sparc64 defconfig) failed like this: net/socket.o: In function `tun_xdp_to_ptr': (.text+0x3180): multiple definition of `tun_xdp_to_ptr' fs/compat_ioctl.o:compat_ioctl.c:(.text+0x0): first defined here net/socket.o: In function

RE: [PATCH net-next 3/3] r8169: improve runtime pm in general and suspend unused ports

2018-01-09 Thread Hayes Wang
Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Tuesday, January 09, 2018 4:39 AM [...] > - Change rtl8169_runtime_suspend to power down the chip if the > interface is down. The original driver has done it. I don't think you have to do it again in rtl8169_runtime_suspend(). [...] > -

Re: [PATCH net-next 3/4] ipv6: Use hash-threshold instead of modulo-N

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > Now that each nexthop stores its region boundary in the multipath hash > function's output space, we can use hash-threshold instead of modulo-N > in multipath selection. > > This reduces the number of checks we need to perform during lookup, as > dead and

Re: [PATCH net-next 4/4] ipv6: Add support for non-equal-cost multipath

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > The use of hash-threshold instead of modulo-N makes it trivial to add > support for non-equal-cost multipath. > > Instead of dividing the multipath hash function's output space equally > between the nexthops, each nexthop is assigned a region size which is

Re: [PATCH net-next 2/4] ipv6: Use a 31-bit multipath hash

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > The hash thresholds assigned to IPv6 nexthops are in the range of > [-1, 2^31 - 1], where a negative value is assigned to nexthops that > should not be considered during multipath selection. > > Therefore, in a similar fashion to IPv4, we need to use the

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > Before we convert IPv6 to use hash-threshold instead of modulo-N, we > first need each nexthop to store its region boundary in the hash > function's output space. > > The boundary is calculated by dividing the output space equally between > the different

[patch iproute2 v8 2/2] tc: Add batchsize feature for filter and actions

2018-01-09 Thread Chris Mi
Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this support, at most 128 commands can be accumulated before sending to kernel. Now it only works for the following successive commands: filter and actions add/delete/change/replace.

[patch iproute2 v8 0/2] tc: Add batchsize feature to batch mode

2018-01-09 Thread Chris Mi
Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this patchset, at most 128 commands can be accumulated before sending to kernel. We introduced two new functions in patch 1 to support for sending multiple messages. In patch 2, we add

[patch iproute2 v8 1/2] lib/libnetlink: Add functions rtnl_talk_msg and rtnl_talk_iov

2018-01-09 Thread Chris Mi
rtnl_talk can only send a single message to kernel. Add two functions rtnl_talk_msg and rtnl_talk_iov that can send multiple messages to kernel. rtnl_talk_msg takes struct msghdr * as argument. rtnl_talk_iov takes struct iovec * and iovlen as arguments. Signed-off-by: Chris Mi

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Linus Torvalds
On Tue, Jan 9, 2018 at 4:48 PM, Dan Williams wrote: > > I looks like there is another problem, or I'm misreading the > cleverness. I think you were misreading it. I was basically saying that this: unsigned long _mask = ~(long)(_m - 1 - _i) >> BITS_PER_LONG -

RE: [patch iproute2 v7 2/2] tc: Add batchsize feature for filter and actions

2018-01-09 Thread Chris Mi
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, January 10, 2018 12:01 AM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com; dsah...@gmail.com; > marcelo.leit...@gmail.com; p...@nwl.cc > Subject:

Re: [PATCH] ipvlan: fix ipvlan MTU limits

2018-01-09 Thread liuqifa
> On Mon, Jan 8, 2018 at 10:48 PM, wrote: > > From: Keefe Liu > > > > The MTU of ipvlan interface should not bigger than the phy device, > > When we run following scripts, we will find there are some problems. > > Step1: > > ip link add link eth0

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Alexei Starovoitov
On Tue, Jan 09, 2018 at 06:22:09PM -0800, Dan Williams wrote: > > When you came up with that tweak you noted: > > "The following: > [..] > is generic and no speculative flows." I meant 'no speculative control flow' load speculation still happens. > > > This macro doesn't prevent speculation.

Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Mike Galbraith
On Tue, 2018-01-09 at 22:26 +0100, Jesper Dangaard Brouer wrote: > > I've previously experienced that you can be affected by the scheduler > granularity, which is adjustable (with CONFIG_SCHED_DEBUG=y): > > $ grep -H . /proc/sys/kernel/sched_*_granularity_ns >

Re: [PATCH net-next V2 0/2] XDP transmission for tuntap

2018-01-09 Thread Jason Wang
On 2018年01月10日 00:06, David Miller wrote: From: Jason Wang Date: Thu, 4 Jan 2018 11:14:26 +0800 This series tries to implement XDP transmission (ndo_xdp_xmit) for tuntap. Pointer ring was used for queuing both XDP buffers and sk_buff, this is done by encoding the type

RE: [patch iproute2 v7 1/2] lib/libnetlink: Add functions rtnl_talk_msg and rtnl_talk_iov

2018-01-09 Thread Chris Mi
> -Original Message- > From: n...@orbyte.nwl.cc [mailto:n...@orbyte.nwl.cc] On Behalf Of Phil > Sutter > Sent: Wednesday, January 10, 2018 3:24 AM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com; > step...@networkplumber.org; dsah...@gmail.com; >

Re: [Patch net] tun: fix a memory leak for tfile->tx_array

2018-01-09 Thread Jason Wang
On 2018年01月10日 08:07, Cong Wang wrote: tfile->tun could be detached before we close the tun fd, via tun_detach_all(), so it should not be used to check for tfile->tx_array. Use the same logic as in tun_attach(), just test !tfile->deatched. Reported-by: Dmitry Vyukov

RE: [patch iproute2 v7 2/2] tc: Add batchsize feature for filter and actions

2018-01-09 Thread Chris Mi
> -Original Message- > From: Marcelo Ricardo Leitner [mailto:marcelo.leit...@gmail.com] > Sent: Wednesday, January 10, 2018 3:14 AM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com; > step...@networkplumber.org; dsah...@gmail.com; p...@nwl.cc >

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Dan Williams
On Tue, Jan 9, 2018 at 5:57 PM, Alexei Starovoitov wrote: > On Tue, Jan 09, 2018 at 04:48:24PM -0800, Dan Williams wrote: >> >> #define __nospec_array_ptr(base, idx, sz) \ >> ({

[PATCH net] nfp: always unmask aux interrupts at init

2018-01-09 Thread Jakub Kicinski
The link state and exception interrupts may be masked when we probe. The firmware should in theory prevent sending (and automasking) those interrupts if the device is disabled, but if my reading of the FW code is correct there are firmwares out there with race conditions in this area. The

Re: [PATCHv3 0/2] capability controlled user-namespaces

2018-01-09 Thread महेश बंडेवार
On Tue, Jan 9, 2018 at 2:28 PM, Serge E. Hallyn wrote: > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> On Mon, Jan 8, 2018 at 10:36 AM, Serge E. Hallyn wrote: >> > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): >> >> On Mon, Jan

Re: [PATCH 04/18] arm: implement nospec_ptr()

2018-01-09 Thread Laura Abbott
On 01/05/2018 05:10 PM, Dan Williams wrote: From: Mark Rutland This patch implements nospec_ptr() for arm, following the recommended architectural sequences for the arm and thumb instruction sets. Fedora picked up the series and it fails on arm: In file included from

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Alexei Starovoitov
On Tue, Jan 09, 2018 at 04:48:24PM -0800, Dan Williams wrote: > > #define __nospec_array_ptr(base, idx, sz) \ > ({ \ > union { typeof([0]) _ptr; unsigned long _bit; } __u; \ >

[PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-09 Thread William Tu
The patch adds support for configuring the erspan V2 fields for openvswitch. For compatibility reason, the previously added attribute 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS' is renamed to 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1' and deprecated, and the newly added attribute 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS'

[PATCHv2 net-next 0/2] net: erspan: add support for openvswitch

2018-01-09 Thread William Tu
The first patch refactors the originally erspan header definitions. Originally, the erspan fields are defined as a group into a __be16 field, and use mask and offset to access each field. This is more costly due to calling ntohs/htons and error-prone. The first patch changes it to use

[PATCHv2 net-next 1/2] net: erspan: use bitfield instead of mask and offset

2018-01-09 Thread William Tu
Originally the erspan fields are defined as a group into a __be16 field, and use mask and offset to access each field. This is more costly due to calling ntohs/htons. The patch changes it to use bitfields. Signed-off-by: William Tu --- include/net/erspan.h | 127

Re: [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

2018-01-09 Thread Benjamin Poirier
On 2018/01/10 01:29, rwar...@gmx.de wrote: > hallo > > any chance to get this patch into stable and 4.15 ? > > https://marc.info/?l=linux-kernel=151297726823919=2 > It was part of the last network pull request and should be included in the next mainline release as 4110e02eb45e e1000e: Fix

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Dan Williams
On Tue, Jan 9, 2018 at 4:48 PM, Dan Williams wrote: > On Mon, Jan 8, 2018 at 8:13 PM, Linus Torvalds > wrote: >> >> On Mon, Jan 8, 2018 at 7:42 PM, Dan Williams >> wrote: >> > >> > originally from Linus and

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Dan Williams
On Tue, Jan 9, 2018 at 4:54 PM, Eric W. Biederman wrote: > Dan Williams writes: [..] > Sigh. > I am not worrying about what is in the speculation window. My > assumption is that the speculation window could be infinite, as we don't > know the

Re: RFC(V3): Audit Kernel Container IDs

2018-01-09 Thread Eric W. Biederman
Please let's have a description of the problem you are trying to solve. A proposed solution without talking about the problem space is useless. Any proposed solution could potentially work. I know to these exist. There is motivation for your work. What is the motivation? What problem are you

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Eric W. Biederman
Dan Williams writes: > On Tue, Jan 9, 2018 at 8:17 AM, Eric W. Biederman > wrote: >> Dan Williams writes: > [..] >> The user controlled value condition of your patchset implies that you >> assume indirect branch

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-09 Thread Dan Williams
On Mon, Jan 8, 2018 at 8:13 PM, Linus Torvalds wrote: > > On Mon, Jan 8, 2018 at 7:42 PM, Dan Williams wrote: > > > > originally from Linus and tweaked by Alexei and I: > > Sadly, that tweak - while clever - is wrong. > > >

Dear friend

2018-01-09 Thread Charlotte Jonathan.
Dear friend I am contacting you because I am dying and I want you to adopt my daughter. In Adopting my daughter, I am willing to allocate to you my funds deposited in a bank. When I get response from you, I will give you more details. Charlotte Jonathan.

Re: [PATCH bpf-next v5 05/11] bpf: Adds field bpf_sock_ops_flags to tcp_sock

2018-01-09 Thread Lawrence Brakmo
On 1/9/18, 3:31 PM, "Eric Dumazet" wrote: On Tue, 2018-01-09 at 13:06 -0800, Lawrence Brakmo wrote: > Adds field bpf_sock_ops_flags to tcp_sock and bpf_sock_ops. Its primary > use is to determine if there should be calls to sock_ops bpf program at >

Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-09 Thread Florian Fainelli
On 01/09/2018 01:42 PM, Andrew Lunn wrote: > The internal PHYs in the mv88e6390 switch have a temperature sensor. > It uses a different register layout to other PHY currently supported. > It also has an errata, in that some reads of the sensor result in bad > values. So a number of reads need to

[Patch net] tun: fix a memory leak for tfile->tx_array

2018-01-09 Thread Cong Wang
tfile->tun could be detached before we close the tun fd, via tun_detach_all(), so it should not be used to check for tfile->tx_array. Use the same logic as in tun_attach(), just test !tfile->deatched. Reported-by: Dmitry Vyukov Fixes: 1576d9860599 ("tun: switch to use skb

Re: [bpf-next PATCH 3/7] bpf: sockmap sample, use fork() for send and recv

2018-01-09 Thread Daniel Borkmann
On 01/08/2018 07:05 PM, John Fastabend wrote: > Currently for SENDMSG tests first send completes then recv runs. This > does not work well for large data sizes and/or many iterations. So > fork the recv and send handler so that we run both send and recv. In > the future we can add a parameter to

Re: [PATCH bpf-next v5 03/11] bpf: Add write access to tcp_sock and sock fields

2018-01-09 Thread Lawrence Brakmo
On 1/9/18, 3:22 PM, "netdev-ow...@vger.kernel.org on behalf of Eric Dumazet" wrote: On Tue, 2018-01-09 at 13:06 -0800, Lawrence Brakmo wrote: > This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to > struct

linux-next: manual merge of the net-next tree with the vfs tree

2018-01-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/tipc/socket.c between commit: ade994f4f6c8 ("net: annotate ->poll() instances") from the vfs tree and commit: eb929a91b213 ("tipc: improve poll() for group member socket") from the net-next tree. I fixed it

Re: [PATCH bpf-next v5 05/11] bpf: Adds field bpf_sock_ops_flags to tcp_sock

2018-01-09 Thread Eric Dumazet
On Tue, 2018-01-09 at 13:06 -0800, Lawrence Brakmo wrote: > Adds field bpf_sock_ops_flags to tcp_sock and bpf_sock_ops. Its primary > use is to determine if there should be calls to sock_ops bpf program at > various points in the TCP code. The field is initialized to zero, > disabling the calls. A

Re: [PATCH bpf-next v5 03/11] bpf: Add write access to tcp_sock and sock fields

2018-01-09 Thread Eric Dumazet
On Tue, 2018-01-09 at 13:06 -0800, Lawrence Brakmo wrote: > This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to > struct tcp_sock or struct sock fields. This required adding a new > field "temp" to struct bpf_sock_ops_kern for temporary storage that > is used by

[PATCH iproute2] mark shell scripts +x

2018-01-09 Thread Mike Frysinger
From: Mike Frysinger This makes it easier to execute locally for testing. Signed-off-by: Mike Frysinger --- ip/ifcfg | 0 ip/routef | 0 ip/routel | 0 ip/rtpr | 0 4 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755

[PATCH iproute2] ifcfg/rtpr: convert to POSIX shell

2018-01-09 Thread Mike Frysinger
From: Mike Frysinger These files are already mostly written in POSIX shell, so convert their shebangs to /bin/sh and tweak the few bashisms in here. URL: https://crbug.com/756559 Reported-by: Pat Erley Signed-off-by: Mike Frysinger

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

2018-01-09 Thread Nikolay Aleksandrov
On 01/10/2018 01:06 AM, Cong Wang wrote: > On Tue, Jan 9, 2018 at 2:53 PM, Nikolay Aleksandrov > wrote: >> On 01/10/2018 12:47 AM, Cong Wang wrote: >>> On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov >>> wrote: [snip]>> I'm not

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

2018-01-09 Thread Cong Wang
On Tue, Jan 9, 2018 at 2:53 PM, Nikolay Aleksandrov wrote: > On 01/10/2018 12:47 AM, Cong Wang wrote: >> On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov >> wrote: >>> >>> Just for reference - this is identical to the first part of:

Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

2018-01-09 Thread Guenter Roeck
On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote: > The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") > removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to > remove the corresponding ifdef's in include/linux/netdevice.h. > > Fixes:

Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

2018-01-09 Thread Andy Gospodarek
On Wed, Jan 10, 2018 at 12:49:53AM +0200, Tal Gilboa wrote: > On 1/10/2018 12:46 AM, Florian Fainelli wrote: > > Hey Andy, > > > > On 01/09/2018 01:06 PM, Andy Gospodarek wrote: > > > From: Andy Gospodarek > > > > > > This converts the dynamic interrupt moderation library

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

2018-01-09 Thread Nikolay Aleksandrov
On 01/10/2018 12:47 AM, Cong Wang wrote: > On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov > wrote: >> >> Just for reference - this is identical to the first part of: >> https://patchwork.ozlabs.org/patch/252891/ >> >> I knew this looked familiar. :-) >> > >

Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

2018-01-09 Thread Tal Gilboa
On 1/10/2018 12:46 AM, Florian Fainelli wrote: Hey Andy, On 01/09/2018 01:06 PM, Andy Gospodarek wrote: From: Andy Gospodarek This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate

Re: WITH ALL DUE RESPECT TO YOUR PERSON

2018-01-09 Thread Lincoln Bah Bah
Dear Friend, With due respect to your person and much sincerity of purpose. I have a business proposal which I will like to handle with you. $35 million USD is involves. But be rest assured that everything is legal and risk free as I have concluded all the arrangements and the legal papers

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

2018-01-09 Thread Cong Wang
On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov wrote: > > Just for reference - this is identical to the first part of: > https://patchwork.ozlabs.org/patch/252891/ > > I knew this looked familiar. :-) > Yeah, except bonding is not even involved. Unless I

Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

2018-01-09 Thread Florian Fainelli
Hey Andy, On 01/09/2018 01:06 PM, Andy Gospodarek wrote: > From: Andy Gospodarek > > This converts the dynamic interrupt moderation library from the mlx5e > driver into a library so it can be used by any driver. The penultimate > patch in this set adds support for this new

[net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

2018-01-09 Thread Jesper Dangaard Brouer
The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to remove the corresponding ifdef's in include/linux/netdevice.h. Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") Reported-by: Guenter Roeck

Re: Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info'

2018-01-09 Thread Jesper Dangaard Brouer
On Tue, 9 Jan 2018 11:01:47 -0800 Guenter Roeck wrote: > Hi, > > commit e817f85652c ("xdp: generic XDP handling of xdp_rxq_info") results in > the following error when building m68k:m5208evb_defconfig in -next. > > net/core/dev.c: In function 'netif_get_rxqueue': >

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-09 Thread Dan Williams
On Tue, Jan 9, 2018 at 2:23 PM, Josh Poimboeuf wrote: > On Tue, Jan 09, 2018 at 01:59:04PM -0800, Dan Williams wrote: >> > Right, but what's the purpose of preventing speculation past >> > access_ok()? >> >> Caution. It's the same rationale for the nospec_array_ptr() patches.

Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

2018-01-09 Thread Nikolay Aleksandrov
On 09/01/18 23:40, Cong Wang wrote: > A vlan device with vid 0 is allow to creat by not able to be fully > cleaned up by unregister_vlan_dev() which checks for vlan_id!=0. > > Also, VLAN 0 is probably not a valid number and it is kinda > "reserved" for HW accelerating devices, but it is probably

Re: [PATCHv3 0/2] capability controlled user-namespaces

2018-01-09 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > On Mon, Jan 8, 2018 at 10:36 AM, Serge E. Hallyn wrote: > > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > >> On Mon, Jan 8, 2018 at 10:11 AM, Serge E. Hallyn wrote: > >> > Quoting

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

2018-01-09 Thread Josh Poimboeuf
On Tue, Jan 09, 2018 at 01:59:04PM -0800, Dan Williams wrote: > > Right, but what's the purpose of preventing speculation past > > access_ok()? > > Caution. It's the same rationale for the nospec_array_ptr() patches. > If we, kernel community, can identify any possible speculation past a > bounds

Re: [PATCH 31/31] aio: implement io_pgetevents

2018-01-09 Thread Arnd Bergmann
On Thu, Jan 4, 2018 at 9:00 AM, Christoph Hellwig wrote: > +} > + > +SYSCALL_DEFINE6(io_pgetevents, > + aio_context_t, ctx_id, > + long, min_nr, > + long, nr, > + struct io_event __user *, events, > + struct

[PATCH net-next 2/2 v10] net: ethernet: Add a driver for Gemini gigabit ethernet

2018-01-09 Thread Linus Walleij
The Gemini ethernet has been around for years as an out-of-tree patch used with the NAS boxen and routers built on StorLink SL3512 and SL3516, later Storm Semiconductor, later Cortina Systems. These ASICs are still being deployed and brand new off-the-shelf systems using it can easily be acquired.

[PATCH net-next 1/2 v10] net: ethernet: Add DT bindings for the Gemini ethernet

2018-01-09 Thread Linus Walleij
This adds the device tree bindings for the Gemini ethernet controller. It is pretty straight-forward, using standard bindings and modelling the two child ports as child devices under the parent ethernet controller device. Cc: devicet...@vger.kernel.org Cc: Tobias Waldvogel

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-09 Thread Pravin Shelar
On Mon, Jan 8, 2018 at 7:02 PM, Ed Swierk wrote: > On 1/6/18 10:57, Pravin Shelar wrote: >> On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk >> wrote: >>> >>> >>> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >>> >>> On Fri, Jan

  1   2   3   4   >