Re: [PATCH net-next V3 0/3] Introduce adaptive TX interrupt moderation to net DIM

On Tue, Apr 24, 2018 at 10:18:09AM -0400, David Miller wrote: > From: Tal Gilboa > Date: Tue, 24 Apr 2018 13:36:00 +0300 > > > Net DIM is a library designed for dynamic interrupt moderation. It was > > implemented and optimized with receive side interrupts in mind, since

Re: SRIOV switchdev mode BoF minutes

On Wed, Apr 18, 2018 at 09:26:34AM -0700, Jakub Kicinski wrote: > On Wed, 18 Apr 2018 11:15:29 -0400, Andy Gospodarek wrote: > > > A similar issue exists on multi-host for PFs, right? If one of the > > > hosts is down do we still show their PF repr? IMHO yes. &

Re: SRIOV switchdev mode BoF minutes

On Tue, Apr 17, 2018 at 04:19:15PM -0700, Jakub Kicinski wrote: > On Tue, 17 Apr 2018 10:47:00 -0400, Andy Gospodarek wrote: > > There is also a school of thought that the VF reps could be > > pre-allocated on the SmartNIC so that any application processing that > > traffi

Re: SRIOV switchdev mode BoF minutes

On Tue, Apr 17, 2018 at 09:46:38AM -0700, Samudrala, Sridhar wrote: > On 4/17/2018 7:47 AM, Andy Gospodarek wrote: > > On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote: > > > On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek > > > <andrew.gospoda...@broad

Re: SRIOV switchdev mode BoF minutes

On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote: > On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek > <andrew.gospoda...@broadcom.com> wrote: > > On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote: > >> > >> On 4/16/2018 5:39 AM, Andy

Re: SRIOV switchdev mode BoF minutes

On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote: > > On 4/16/2018 5:39 AM, Andy Gospodarek wrote: > > On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: > > > On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar > > > <s

Re: SRIOV switchdev mode BoF minutes

On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: > On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar > wrote: > > > I meant between PFs on 2 compute nodes. > > If the PF serves as uplink rep, it functions as a switch port -- applications > don't run on

Re: [PATCH net v2 2/6] bnxt_en: do not allow wildcard matches for L2 flows

On Wed, Apr 11, 2018 at 01:41:31PM -0700, Michael Chan wrote: > On Wed, Apr 11, 2018 at 1:31 PM, Andy Gospodarek > <andrew.gospoda...@broadcom.com> wrote: > > On Wed, Apr 11, 2018 at 11:43:14AM -0700, Jakub Kicinski wrote: > >> On Wed, 11 Apr 2018 11:50:1

Re: [PATCH net v2 2/6] bnxt_en: do not allow wildcard matches for L2 flows

On Wed, Apr 11, 2018 at 11:43:14AM -0700, Jakub Kicinski wrote: > On Wed, 11 Apr 2018 11:50:14 -0400, Michael Chan wrote: > > @@ -764,6 +788,41 @@ static bool bnxt_tc_can_offload(struct bnxt *bp, > > struct bnxt_tc_flow *flow) > > return false; > > } > > > > + /* Currently

Re: [PATCH net] net/dim: Fix int overflow

. > > Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to > include/linux") > Signed-off-by: Tal Gilboa <ta...@mellanox.com> Reviewed-by: Andy Gospodarek <go...@broadcom.com> > --- > include/linux/net_dim.h | 2 +- > 1 file changed,

Re: [PATCH net 3/3] bonding: process the err returned by dev_set_allmulti properly in bond_enslave

t;bonding: Check return of dev_set_promiscuity/allmulti") > Signed-off-by: Xin Long <lucien@gmail.com> Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > drivers/net/bonding/bond_main.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --g

Re: [PATCH net 2/3] bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave

an > improvement. Nice optimization. :-) > > Note team driver also has this issue, I will fix it in another patch. > > Fixes: 1f718f0f4f97 ("bonding: populate neighbour's private on enslave") > Reported-by: Beniamino Galvani <bgalv...@redhat.com&g

Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

quot;bonding: change the bond's vlan syncing functions with > the standard ones") > Signed-off-by: Xin Long <lucien@gmail.com> Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > drivers/net/bonding/bond_main.c | 9 + > 1 file changed, 5 insertions(+),

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

On Thu, Mar 22, 2018 at 01:10:38PM -0600, David Ahern wrote: > On 3/22/18 11:49 AM, Jiri Pirko wrote: > > Thu, Mar 22, 2018 at 04:34:07PM CET, dsah...@gmail.com wrote: > >> On 3/22/18 4:55 AM, Jiri Pirko wrote: > >>> From: Jiri Pirko > >>> > >>> This patchset resolves 2 issues

Re: [PATCH net-next] Documentation/networking: Add net DIM documentation

t; Looks like a nice summary of how to integrate it with a driver. Thanks for documenting DIM. Acked-by: Andy Gospodarek <go...@broadcom.com> > --- > Documentation/networking/net_dim.txt | 174 > +++ > 1 file changed, 174 insertions(+) > c

[PATCH net-next] bnxt_en: cleanup DIM work on device shutdown

From: Andy Gospodarek <go...@broadcom.com> Make sure to cancel any pending work that might update driver coalesce settings when taking down an interface. Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation") Signed-off-by: Andy Gospodarek <go.

Re: [PATCH][next] bnxt_en: ensure len is ininitialized to zero

On Fri, Jan 12, 2018 at 10:11:17AM -0800, Michael Chan wrote: > On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote: > > From: Colin Ian King > > > > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the > > exit return path is via label

Re: [PATCH net-next v4 00/10] net: create dynamic software irq moderation library

On Wed, Jan 10, 2018 at 12:49:53AM +0200, Tal Gilboa wrote: > On 1/10/2018 12:46 AM, Florian Fainelli wrote: > > Hey Andy, > > > > On 01/09/2018 01:06 PM, Andy Gospodarek wrote: > > > From: Andy Gospodarek <go...@broadcom.com> > > > > > >

[PATCH net-next v4 01/10] net/mlx5e: Move interrupt moderation structs to new file

From: Andy Gospodarek <go...@broadcom.com> Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: S

[PATCH net-next v4 00/10] net: create dynamic software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate patch in this set adds support for this new dynamic interrupt moderation library in the bnxt_en

[PATCH net-next v4 04/10] net/mlx5e: Move AM logic enums

From: Andy Gospodarek <go...@broadcom.com> More movement to help make this code more generic. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/m

[PATCH net-next v4 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am

From: Andy Gospodarek <go...@broadcom.com> This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Ta

[PATCH net-next v4 02/10] net/mlx5e: Move interrupt moderation forward declarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> -

[PATCH net-next v4 05/10] net/mlx5e: Move generic functions to new file

From: Andy Gospodarek <go...@broadcom.com> These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta.

[PATCH net-next v4 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux

From: Andy Gospodarek <go...@broadcom.com> This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing para

[PATCH net-next v4 08/10] net/dim: use struct net_dim_sample as arg to net_dim

From: Andy Gospodarek <go...@broadcom.com> Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Suggested-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Tal Gilboa &

[PATCH net-next v4 09/10] bnxt_en: add support for software dynamic interrupt moderation

From: Andy Gospodarek <go...@broadcom.com> This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughpu

[PATCH net-next v4 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

From: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAI

[PATCH net-next v4 06/10] net/mlx5e: Change Mellanox references in DIM code

From: Andy Gospodarek <go...@broadcom.com> Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables and add generic p

Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

On Tue, Jan 09, 2018 at 08:22:15PM +0200, Tal Gilboa wrote: > On 1/9/2018 6:06 PM, Andy Gospodarek wrote: > > On Mon, Jan 08, 2018 at 11:06:28PM -0800, Saeed Mahameed wrote: > > > > > > > > > On 01/08/2018 10:13 PM, Andy Gospodarek wrote: > > >

Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

On Mon, Jan 08, 2018 at 11:06:28PM -0800, Saeed Mahameed wrote: > > > On 01/08/2018 10:13 PM, Andy Gospodarek wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and > > NET_

[PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

From: Andy Gospodarek <go...@broadcom.com> Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables and add generic p

[PATCH net-next v3 05/10] net/mlx5e: Move generic functions to new file

From: Andy Gospodarek <go...@broadcom.com> These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta.

[PATCH net-next v3 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am

From: Andy Gospodarek <go...@broadcom.com> This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Ta

[PATCH net-next v3 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

From: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAI

[PATCH net-next v3 02/10] net/mlx5e: Move interrupt moderation forward declarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> -

[PATCH net-next v3 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux

From: Andy Gospodarek <go...@broadcom.com> This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing para

[PATCH net-next v3 01/10] net/mlx5e: Move interrupt moderation structs to new file

From: Andy Gospodarek <go...@broadcom.com> Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: S

[PATCH net-next v3 08/10] net/dim: use struct net_dim_sample as arg to net_dim

From: Andy Gospodarek <go...@broadcom.com> Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Suggested-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Tal Gilboa &

[PATCH net-next v3 09/10] bnxt_en: add support for software dynamic interrupt moderation

From: Andy Gospodarek <go...@broadcom.com> This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughpu

[PATCH net-next v3 04/10] net/mlx5e: Move AM logic enums

From: Andy Gospodarek <go...@broadcom.com> More movement to help make this code more generic. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/m

[PATCH net-next v3 00/10] net: create dynamic software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate patch in this set adds support for thiw new dynamic interrupt moderation library in the bnxt_en

Re: [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code

On Sun, Jan 07, 2018 at 11:44:48AM +0200, Tal Gilboa wrote: > > > On 1/6/2018 12:58 AM, Andy Gospodarek wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and > > NET_DIM, res

Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote: > Hi Andy, > > If you are re-doing the patch, could you modify a minor comment below? > > On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek <a...@greyhouse.net> wrote: > > > diff --git a/driv

[PATCH net-next v2 02/10] net/mlx5e: Move interrupt moderation forward declarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> -

[PATCH net-next v2 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux

From: Andy Gospodarek <go...@broadcom.com> This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing para

[PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code

From: Andy Gospodarek <go...@broadcom.com> Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables. Signed-off-by: Andy Gosp

[PATCH net-next v2 08/10] net/dim: use struct net_dim_sample as arg to net_dim

From: Andy Gospodarek <go...@broadcom.com> Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Suggested-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Tal Gilboa &

[PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

From: Andy Gospodarek <go...@broadcom.com> This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughpu

[PATCH net-next v2 00/10] net: create dynamic software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate patch in this set adds support for thiw new dynamic interrupt moderation library in the bnxt_en

[PATCH net-next v2 01/10] net/mlx5e: Move interrupt moderation structs to new file

From: Andy Gospodarek <go...@broadcom.com> Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: S

[PATCH net-next v2 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

From: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAI

[PATCH net-next v2 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am

From: Andy Gospodarek <go...@broadcom.com> This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Ta

[PATCH net-next v2 05/10] net/mlx5e: Move generic functions to new file

From: Andy Gospodarek <go...@broadcom.com> These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta.

[PATCH net-next v2 04/10] net/mlx5e: Move AM logic enums

From: Andy Gospodarek <go...@broadcom.com> More movement to help make this code more generic. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/m

Re: [net-next 06/10] net/mlx5e: change Mellanox references in DIM code

On Fri, Jan 05, 2018 at 10:04:50AM +0200, Tal Gilboa wrote: > On 1/4/2018 10:21 PM, Andy Gospodarek wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM, > MLX_AM->MLX5_AM &

Re: [net-next 06/10] net/mlx5e: change Mellanox references in DIM code

On Fri, Jan 05, 2018 at 10:04:50AM +0200, Tal Gilboa wrote: > On 1/4/2018 10:21 PM, Andy Gospodarek wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM, > MLX_AM->MLX5_AM &

Re: [net-next 00/10] net: create dynamic software irq moderation library

On Fri, Jan 05, 2018 at 10:14:43AM +0200, Tal Gilboa wrote: > Thanks Andy for your hard work. Looks great overall! > > On 1/4/2018 10:21 PM, Andy Gospodarek wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > This converts the dynamic interrupt mo

Re: [net-next 09/10] bnxt_en: add support for software dynamic interrupt moderation

On Thu, Jan 04, 2018 at 02:16:26PM -0800, Michael Chan wrote: > On Thu, Jan 4, 2018 at 12:21 PM, Andy Gospodarek <a...@greyhouse.net> wrote: > > From: Andy Gospodarek <go...@broadcom.com> > > > > This implements the changes needed for the bnxt_en driver to add

Re: [net-next 00/10] net: create dynamic software irq moderation library

On Thu, Jan 04, 2018 at 10:37:37PM +0200, Or Gerlitz wrote: > > net/mlx5e: move interrupt moderation structs to new file > > net/mlx5e: move interrupt moderation forward declarations > > net/mlx5e: remove rq references in mlx5e_rx_am > > net/mlx5e: move AM logic enums > > net/mlx5e: move

Re: [net-next 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

On Thu, Jan 04, 2018 at 02:36:54PM -0800, Stephen Hemminger wrote: > On Thu, 4 Jan 2018 15:21:30 -0500 > Andy Gospodarek <a...@greyhouse.net> wrote: > > > +DYNAMIC INTERRUPT MODERATION > > +M: Tal Gilboa <ta...@mellanox.com> > > +S: Mainained >

[net-next 01/10] net/mlx5e: move interrupt moderation structs to new file

From: Andy Gospodarek <go...@broadcom.com> Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> --- drivers/net/ethe

[net-next 03/10] net/mlx5e: remove rq references in mlx5e_rx_am

From: Andy Gospodarek <go...@broadcom.com> This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Ta

[net-next 06/10] net/mlx5e: change Mellanox references in DIM code

From: Andy Gospodarek <go...@broadcom.com> Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables. Signed-off-by: Andy Gospodar

[net-next 08/10] net/dim: use struct net_dim_sample as arg to net_dim

From: Andy Gospodarek <go...@broadcom.com> Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Suggested-by: Tal Gilboa <ta...@mellanox.com> Acked-by: Tal Gilboa &

[net-next 05/10] net/mlx5e: move generic functions to new file

From: Andy Gospodarek <go...@broadcom.com> These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta.

[net-next 02/10] net/mlx5e: move interrupt moderation forward declarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4

[net-next 09/10] bnxt_en: add support for software dynamic interrupt moderation

From: Andy Gospodarek <go...@broadcom.com> This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughpu

[net-next 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

From: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Andy Gospodarek <go...@broadcom.com> Signed-off-by: Tal Gilboa <ta...@mellanox.com> --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 753799d..769857b 100644 --- a

[net-next 04/10] net/mlx5e: move AM logic enums

From: Andy Gospodarek <go...@broadcom.com> More movement to help make this code more generic. Signed-off-by: Andy Gospodarek <go...@broadcom.com> Acked-by: Tal Gilboa <ta...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++ dr

[net-next 00/10] net: create dynamic software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This converts the dynamic interrupt moderation library from the mlx5_en driver into a library so it can be used by any driver. The penultimatepatch in this set adds support for interrupt moderation in the bnxt_en driver and the last patch c

[net-next 07/10] net: move dynamic interrupt coalescing code to include/linux

From: Andy Gospodarek <go...@broadcom.com> This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing para

Re: [PATCH v1] net: bonding: Replace mac address parsing

On Tue, Dec 19, 2017 at 08:20:44PM +0200, Andy Shevchenko wrote: > Replace sscanf() with mac_pton(). > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Nice cleanup. Thanks! Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > drivers/net

Re: [PATCH net] ipv6: Do not consider linkdown nexthops during multipath

l option to ignore routes when nexthop > link is down") > Signed-off-by: Ido Schimmel <ido...@mellanox.com> Nice find. Looks good to me, as well. Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > net/ipv6/route.c | 5 + > 1 file changed, 5 insertions(+) >

[RFC 8/9] net: move adaptive interrpt coalescing code to lib/

From: Andy Gospodarek <go...@broadcom.com> This takes the code that is not generically named to lib/. This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler

[RFC 3/9] mlx5_en: remove rq references in mlx5e_rx_am

From: Andy Gospodarek <go...@broadcom.com> This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/

[RFC 5/9] mlx5_en: move generic functions to new file

From: Andy Gospodarek <go...@broadcom.com> These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_rx_am.c. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/m

[RFC 6/9] mlx5_en: rename en_rx_am.h to net_rx_am.h

From: Andy Gospodarek <go...@broadcom.com> This is so net_rx_am.h can be easily moved out of mlx5/core. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_r

[RFC 4/9] mlx5_en: move AM logic enums

From: Andy Gospodarek <go...@broadcom.com> More movement to help make this code more generic. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c | 25 - drivers/net/ethernet/mellanox/mlx5/core/en_

[RFC 9/9] bnxt_en: add support for software adaptive interrupt moderation

From: Andy Gospodarek <go...@broadcom.com> This implements the changes needed for the bnxt_en driver to add support for adaptive interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughpu

[RFC 8/9] net: move adaptive interrupt coalescing code to lib/

From: Andy Gospodarek <go...@broadcom.com> This takes the code that is not generically named to lib/. This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler

[RFC 7/9] mlx5_en: remove Mellanox references in AM code

From: Andy Gospodarek <go...@broadcom.com> Remove all mlx5* and MLX* references to net_ and NET_, respectively in code that handles software interrupt moderation. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 7

[RFC 1/9] mlx5_en: move interrupt moderation structs to new file

From: Andy Gospodarek <go...@broadcom.com> Create new header file to prepare to move code that handles irq moderation to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 32 +- drivers/net/ethernet/mellan

[RFC 2/9] mlx5_en: move interrupt moderation forward delcarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 drivers/net/ethernet/mellanox/mlx5/cor

[RFC 2/9] mlx5_en: move interrupt moderation forward declarations

From: Andy Gospodarek <go...@broadcom.com> Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek <go...@broadcom.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 drivers/net/ethernet/mellanox/mlx5/cor

[RFC 0/9] net: create adaptive software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This RFC converts the adaptive interrupt moderation library from the mlx5_en driver into a library so it can be used by any driver. The last patch in this set adds support for interrupt moderation in the bnxt_en driver. The main purpose of thi

[RFC 0/9] net: create adaptive software irq moderation library

From: Andy Gospodarek <go...@broadcom.com> This RFC converts the adaptive interrupt moderation library from the mlx5_en driver into a library so it can be used by any driver. The last patch in this set adds support for interrupt moderation in the bnxt_en driver. The main purpose of thi

Re: [RFC 1/3] devlink: Add config parameter get/set operations

ed in order vendors to share >attributes among drivers. > > More nits inlined. > > > >Signed-off-by: Steve Lin <steven.l...@broadcom.com> > >Acked-by: Andy Gospodarek <go...@broadcom.com> > >--- > > include/net/devli

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

On Thu, Sep 28, 2017 at 1:59 AM, Waskiewicz Jr, Peter <peter.waskiewicz...@intel.com> wrote: > On 9/26/17 10:21 AM, Andy Gospodarek wrote: >> On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote: >>> On 09/25/2017 08:10 PM, Andy Gospodarek wrote: >

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote: > On 09/25/2017 08:10 PM, Andy Gospodarek wrote: > [...] > > First, thanks for this detailed description. It was helpful to read > > along with the patches. > > > > My only concern about this area bei

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

On Mon, Sep 25, 2017 at 02:25:51AM +0200, Daniel Borkmann wrote: > This work enables generic transfer of metadata from XDP into skb. The > basic idea is that we can make use of the fact that the resulting skb > must be linear and already comes with a larger headroom for supporting >

Re: [PATCH net-next] xdp: implement xdp_redirect_map for generic XDP

;) > Fixes: 24251c264798 ("samples/bpf: add option for native and skb mode for > redirect apps") > Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com> Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > net/core/filter.c | 29 +

Re: XDP redirect measurements, gotchas and tracepoints

On Tue, Aug 29, 2017 at 09:23:49AM -0700, Alexander Duyck wrote: > On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer > wrote: > > > > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck > > wrote: > > > >> My advice would be to not over

Re: XDP redirect measurements, gotchas and tracepoints

On Mon, Aug 28, 2017 at 09:14:20AM -0700, John Fastabend wrote: > On 08/28/2017 09:02 AM, Andy Gospodarek wrote: > > On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: > >> On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend > >> <john.fastab...@gmail.com>

Re: XDP redirect measurements, gotchas and tracepoints

On Fri, Aug 25, 2017 at 08:28:55AM -0700, Michael Chan wrote: > On Fri, Aug 25, 2017 at 8:10 AM, John Fastabend > wrote: > > On 08/25/2017 05:45 AM, Jesper Dangaard Brouer wrote: > >> On Thu, 24 Aug 2017 20:36:28 -0700 > >> Michael Chan wrote:

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Tue, Jul 25, 2017 at 07:34:47PM -0700, Jakub Kicinski wrote: > On Tue, 25 Jul 2017 21:48:15 -0400, Andy Gospodarek wrote: > > On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > > > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > > >

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > > > We are still in position where we can suggest uniform namin

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > We are still in position where we can suggest uniform naming > convention for ndo_get_phys_port_name(). switchdev.txt file > already contained a suggestion of how to name external ports. > Since the use of switchdev for SR-IOV

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

6dc54cf4 ("bonding: remove hardcoded value"). Otherwise this looks reasonable to me. Acked-by: Andy Gospodarek <a...@greyhouse.net> > --- > drivers/net/bonding/bond_main.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bonding

[PATCH net-next] samples/bpf: add option for native and skb mode for redirect apps

/xdp_redirect_map -S 5 6 input: 5 output: 6 map[0] (vports) = 4, map[1] (map) = 5, map[2] (count) = 0 ifindex 6:5052528 pkt/s ifindex 6:5736631 pkt/s ifindex 6:5739962 pkt/s Signed-off-by: Andy Gospodarek <a...@greyhouse.net> --- samples/bpf/xdp_redirect_map_user.

  1   2   3   4   >