Remove Host AP and Prism2 references from IEEE 802.11 crypto code. Clean
up coding style and some comments. Replace couple of kmalloc+memset with
kzalloc.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/include/net/ieee80211_crypt.h
.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
is not
present, I would assume that the drivers would do whatever they want and
in many cases I would expect this to be active scan.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
was used to probe for specific SSID(s).
If this information is not available, reporting an empty SSID sounds
like a good policy.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
IEs and interacting with roaming
and association.
Doing this also has the advantage of being able to remove all scan and
network collection logistics out of the kernel and into user space.
Agreed.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from
been modified to do
something else.
Have you actually observed that FullMAC drivers are using passive
scanning (i.e., used a wireless sniffer to see what they are doing)?
Most drivers I've looked at at this level are sending out probe request
frames..
--
Jouni Malinen
for WPA supplicant and fetching them from scan results is one convenient
mechanism. In other words, proper WPA/WPA2 validation of WPA/RSN IEs
requires that the Beacon/ProbeResp IEs are available for the current AP.
--
Jouni MalinenPGP id EFC895FA
for the cases where Beacon frame used an empty SSID (or had another SSID
in case of multi-SSID). In case scanning is moved to user space, this
process would happen in an user space application instead.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list
Please apply following two patches to Host AP driver in wireless-2.6.
The second patch (Fix EAPOL frame encryption) is a trivial bug fix for
a somewhat unfortunate bug and it could be a good candidate for a
2.6.16.x stable release ([EMAIL PROTECTED] cc'ed).
--
Jouni Malinen
-authentication.
http://hostap.epitest.fi/bugz/show_bug.cgi?id=126
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: linux-2.6.16/drivers/net/wireless/hostap/hostap_80211_tx.c
===
--- linux-2.6.16.orig/drivers/net/wireless/hostap
hostap_tx_encrypt() is used only inside hostap_80211_tx.c and there
are no plans to use it elsewhere in the future either, so let's make
it static. As a bonus, this should silence Coverity scanner from
complaining about bogus FORWARD_NULL case (CID: 274).
Signed-off-by: Jouni Malinen [EMAIL
From: Adrian Bunk [EMAIL PROTECTED]
The Coverity checker (CID: 59) noted that the call to prism2_hw_reset()
was dead code. Move prism2_hw_reset() call to a place where it is
actually executed.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index
;
memset(sta-supported_rates, 0, sizeof(sta-supported_rates));
--
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
differences. Please apply to the appropriate branch(es).
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
From: Eugene Teo [EMAIL PROTECTED]
The Coverity checker (CID: 930) spotted this double free on error path
(allocation failure). Do not free these here since generic error path
will take care of this.
Signed-off-by: Eugene Teo [EMAIL PROTECTED]
Signed-off-by: Jouni Malinen [EMAIL PROTECTED
The Coverity checker (CID: 452, 453, 454, 455, 456) spotted this
unlikely read overrun of CIS buffer. Abort if CISTPL_CONFIG or
CISTPL_MANFID would not fit in buffer.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_plx.c
The Coverity checker (CID: 58) spotted this duplicated idx != 0
validation for unicast keys in prism2_ioctl_siwencodeext().
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_ioctl.c
The Coverity checker (CID: 659, 660) spotted this resource leak on
PCI probe error path. Free private data structure if pci_enable_device()
fails.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/hostap/hostap_pci.c
On Thu, Mar 16, 2006 at 05:45:48PM +0100, Jiri Benc wrote:
On Wed, 15 Mar 2006 16:36:16 -0800, Jouni Malinen wrote:
See the patch below. Is it viable?
I'll test this with our low-level driver.
This and similar change for ieee80211_get_buffered_bc() add more
requirements for the low-level
engineered implementation clean as far as use of
proprietary information is concerned.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
info (00:11:22:33:44:55 was not added in
/proc/net/ieee80211/wlan0/sta directory). Did I understand something
incorrectly here?
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
On Wed, Mar 15, 2006 at 06:47:40PM +0100, Jiri Benc wrote:
On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote:
This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix
it?
Yes, I do. Sorry for not posting it.
This is a first part; it's just ugly and quick (but working
On Wed, Mar 15, 2006 at 06:59:53PM +0100, Jiri Benc wrote:
On Wed, 15 Mar 2006 09:40:52 -0800, Jouni Malinen wrote:
The same issue showed up with our low-level driver. How was the
low-level driver supposed to get this information with this change?
From struct ieee80211_if_conf
On Wed, Mar 15, 2006 at 07:24:05PM +0100, Jiri Benc wrote:
On Wed, 15 Mar 2006 09:52:26 -0800, Jouni Malinen wrote:
This sounds good, but I was unable to get this working. I created a WDS
link with initial peer address 00:01:02:03:04:05. This added the netdev
and STA entry correctly
added for the
low-level code as far as virtual interfaces are concerned.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
convenient.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
other fixes in a patch set, too.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 06, 2006 at 08:07:26PM +0100, Jiri Benc wrote:
On Mon, 6 Mar 2006 10:49:46 -0800, Jouni Malinen wrote:
The reason for this optimization was in even high-end CPUs starting to
run out of resources when running one radio with 2007 virtual STAs,
Yes, I'm aware of that. But I'm
On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote:
Jouni Malinen wrote :
This is used to implement radio on/off without having to change other
parts of the configuration (e.g., set interfaces down).
The airo driver use 'txpower' for that. txpower has a 'off'
option
Here's couple of patches to the Devicescape 802.11 implementation.
Please consider applying to the dscape branch of wireless-2.6 tree.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
Replace local AES implementation (net/d80211/aes.c) with calls to
Crypto API.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/net/d80211/aes.c
===
--- wireless-2.6.orig/net/d80211/aes.c
+++ /dev/null
@@ -1,564
Here's couple of patches to the Devicescape 802.11 implementation.
Please consider applying to the dscape branch of wireless-2.6 tree.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/net/d80211/ieee80211.c
===
--- wireless-2.6.orig/net/d80211/ieee80211.c
+++ wireless-2.6/net/d80211/ieee80211.c
@@ -3325,6 +3325,7 @@ void __ieee80211_rx(struct net_device *d
's' is not capitalized in Devicescape. Let's try to fix these cases
before the incorrect spelling is copied into more places.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/drivers/net/wireless/Kconfig
No need to define EXPORT_SYMTAB separatel here when this is built
inside the current kernel tree.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/net/d80211/ieee80211.c
===
--- wireless-2.6.orig/net/d80211
Add parameters for radar detection that were previously left as a
to-do item.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/include/net/d80211.h
===
--- wireless-2.6.orig/include/net/d80211.h
+++ wireless-2.6
Let's clean up some of the whitespace use (extra lines, trailing
whitespace, incorrect indentation).
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/net/d80211/ieee80211.c
===
--- wireless-2.6.orig/net/d80211
at the
same time is something that I don't see as a very strong requirement at
the moment.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
functions to ieee80211_rcv, for example.
This would certainly be easier to handle than full renaming of all
function names in net/d80211.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 30, 2006 at 10:13:16AM -0800, Jean Tourrilhes wrote:
On Fri, Jan 27, 2006 at 05:01:44PM -0800, Jouni Malinen wrote:
It is spelled very clearly on my web site :
---
# The HostAP driver is the reference implementation
On Sat, Jan 28, 2006 at 11:07:10AM -0500, Dan Williams wrote:
On Fri, 2006-01-27 at 17:01 -0800, Jouni Malinen wrote:
On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote:
1) The patch preserves the null-termination of the ESSID, it just
doesn't return the expanded length
(or whatever branch is
appropriate for this kind of change) of the wireless-2.6 tree.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: wireless-2.6/net/d80211/ieee80211.c
===
--- wireless-2.6.orig/net/d80211/ieee80211.c
+++ wireless-2.6
started using real SSID length, but was changed
in September 2004 to use len+1 after Jean explained what the
SIOCSIWESSID was designed to do..
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
or so.
This is a very old interface for a customer. I don't think it was ever
really used at Devicescape and I certainly don't see much need for it in
the current version. In other words, it could just be removed.
--
Jouni MalinenPGP id EFC895FA
for scheduling and
transmission.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 17, 2006 at 01:05:16PM +0100, Jiri Benc wrote:
On Mon, 16 Jan 2006 19:07:51 -0800, Jouni Malinen wrote:
Actually, there is a use for the master device. It can be used to
monitor what is going on over the radio from all virtual APs/STAs, e.g.,
by running Ethereal on it.
You
On Tue, Jan 17, 2006 at 02:55:31PM -0500, jamal wrote:
On Tue, 2006-17-01 at 11:42 -0800, Jouni Malinen wrote:
so if i understood correctly:
You have a master netdevice which underneath it has child netdevices?
I'm not sure what exactly child netdev means, but it sounds like
something
Ethereal on it. Isn't VLANs implemented in the same way with
the netdev added by the driver (master device). The low-level wireless
driver could do the same thing and then user space tools can add
whatever virtual interfaces are needed.
--
Jouni MalinenPGP
(volatile) download can be used to
upgrade the firmware without having to modify the flash contents. This
is also what the current Windows drivers are doing.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev
AP when merging in the
version that ipw2x00 was using needs more attention when deciding what
kind of design would allow all drivers to work with shared IEEE 802.11
stack.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line
. In that way, supplicant
doesn't even need to know about these associations being done through
the same radio and it can just handle them as it would take care of
multiple radios.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line
).
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
like swap-8-bytes-unconditionally than doing this based
on host byte order..
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
to be set UP before authentication, though.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
to know about 802.11 details
from user space.
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Debug variables and procfs dir should be ieee80211, not ipw.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/include/net/ieee80211.h
===
--- netdev-2.6.orig/include/net/ieee80211.h
+++ netdev-2.6/include/net
No need to maintain support for WIRELESS_EXT 17 since this kernel
tree is already using WIRELESS_EXT 18.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/include/net/ieee80211.h
===
--- netdev-2.6.orig/include/net
Version 0.4.4 of Host AP driver was released, so let's sync the version
number in netdev-2.6 tree.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_config.h
===
--- netdev-2.6.orig
IEEE 802.11 code has no business touching payloads of EAPOL frames.
There are some EAPOL structures defined for debugging and these were
confusingly called EAP types which they are not. Let's just remove these
before someone else starts using them in the kernel.
Signed-off-by: Jouni Malinen
hostap_cs: 0.4.1-kernel (Jouni Malinen [EMAIL PROTECTED])
pcmcia: hostap_cs: invalid hash for product string BUFFALO: is 0x1b01a57b,
should be 0x2decece3
pcmcia: see Documentation/pcmcia/devicetable.txt for details
pcmcia: hostap_cs: invalid hash for product string WLI-CF-S11G: is
0xefd5102a
that local-hw_priv is always
set (and it should have been). Fix this by setting local-hw_priv before
registering the interrupt handler.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_cs.c
without having to compile
and link the same code separately for each one.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_cs.c
===
--- netdev-2.6.orig/drivers/net/wireless/hostap
to verify whether it works or
not. Getting this out makes it easier to maintain the driver and
allows some cleanups that have been partly postponed because of this
experimental bus master/DMA code.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_wlan.h
to ieee80211-devel mailing list. The
changes here are still mainly for hostap, but there are couple of small
changes to net/ieee80211.h and the renamed define affects net/ieee80211
and ipw2200. Please let me know, if this is not suitable for the
ieee80211-devel list.
--
Jouni Malinen
-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/include/net/ieee80211.h
===
--- netdev-2.6.orig/include/net/ieee80211.h
+++ netdev-2.6/include/net/ieee80211.h
@@ -103,7 +103,7 @@ struct eapol {
#defineMAX_FRAG_THRESHOLD
Replace hostap-specific struct hostap_ieee80211_hdr with struct
ieee80211_hdr from net/ieee80211.h.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_80211.h
===
--- netdev-2.6.orig
Remove unused defines that are already available from generic kernel
header files.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_wlan.h
===
--- netdev-2.6.orig/drivers/net
Remove backwards compatibility define for WLAN_CAPABILITY_ESS now that
net/ieee80211.h defines this.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_common.h
===
--- netdev-2.6
From: Adrian Bunk [EMAIL PROTECTED]
EXPORT_SYMTAB does nothing. There's no need to define something if it
doesn't have any effect.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap.c
This set of patches updates Host AP driver in the ieee80211-wifi
branch of the netdev-2.6 git tree with changes from my CVS repository
and from additional contributed patches from the past couple of
months. Please apply to the suitable branch(es) in netdev-2.6.
--
Jouni Malinen
Add MODULE_VERSION information for the Host AP kernel modules and
update the version string to indicate which version of the external
Host AP driver is included in the kernel tree.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap.c
Added support for setting channel mask for scan requests
('iwpriv wlan0 scan_channels 0x00ff' masks scans to use channels 1-8).
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_common.h
From: Brandon Enochs [EMAIL PROTECTED]
line 129 of hostap_80211_rx.c should read:
LWNG_SETVAL(mactime, 2, 0, 4, rx_stats-mac_time);
not:
LWNG_SETVAL(mactime, 2, 0, 0, rx_stats-mac_time);
The length field is incorrect.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev
Cleaned up scan result processing by converting struct
hfa384x_scan_result into struct hfa384x_hostscan_result. This removes
special cases from result processing since the results are only used
in one, hostscan, format.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net
.. Is there
valid need to keep this header file compatible with older kernel
versions?
--
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
sinc net/ieee80211.h
is using incompatible definitions. This will be resolved in the
future by updating Host AP to use the versions that do not shift
type/stype.
Signed-off-by: Jouni Malinen [EMAIL PROTECTED]
Index: netdev-2.6/drivers/net/wireless/hostap/hostap.c
101 - 177 of 177 matches
Mail list logo
