Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Russell King - ARM Linux
On Fri, Jun 09, 2017 at 08:40:19AM +0200, Antoine Tenart wrote: > Hi Andrew, > > On Thu, Jun 08, 2017 at 06:03:31PM +0200, Andrew Lunn wrote: > > On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > > > +#define MVMDIO_XSMI_MGNT_REG 0x0 > > > +#define

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Russell King - ARM Linux
On Fri, Jun 09, 2017 at 06:22:16PM +0200, Antoine Tenart wrote: > On Fri, Jun 09, 2017 at 05:03:40PM +0200, Andrew Lunn wrote: > > > There are two busses, one generating c22 transactions and one generating > > > c45 transactions. Each bus has its own MDC/MDIO pins. > > > > O.K. That is what i

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Russell King - ARM Linux
On Fri, Jun 09, 2017 at 04:49:36PM +0200, Andrew Lunn wrote: > On Fri, Jun 09, 2017 at 04:09:22PM +0200, Antoine Tenart wrote: > > The MDIO/xMDIO registers are embedded into the network controller. The > > mvmdio driver was created at first to abstract this functionality > > outside the network

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
On Fri, Jun 09, 2017 at 05:03:40PM +0200, Andrew Lunn wrote: > > There are two busses, one generating c22 transactions and one generating > > c45 transactions. Each bus has its own MDC/MDIO pins. > > O.K. That is what i wanted to know. So we want two completely separate > device tree bindings,

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Andrew Lunn
> There are two busses, one generating c22 transactions and one generating > c45 transactions. Each bus has its own MDC/MDIO pins. O.K. That is what i wanted to know. So we want two completely separate device tree bindings, busses registered with Linux, etc. Thanks for clarification.

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Fri, Jun 09, 2017 at 04:49:36PM +0200, Andrew Lunn wrote: > On Fri, Jun 09, 2017 at 04:09:22PM +0200, Antoine Tenart wrote: > > > > The MDIO/xMDIO registers are embedded into the network controller. The > > mvmdio driver was created at first to abstract this functionality > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Andrew Lunn
On Fri, Jun 09, 2017 at 04:09:22PM +0200, Antoine Tenart wrote: > Hi Andrew, > > On Fri, Jun 09, 2017 at 03:26:24PM +0200, Andrew Lunn wrote: > > On Fri, Jun 09, 2017 at 10:25:41AM +0200, Antoine Tenart wrote: > > > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > > > > > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Fri, Jun 09, 2017 at 03:26:24PM +0200, Andrew Lunn wrote: > On Fri, Jun 09, 2017 at 10:25:41AM +0200, Antoine Tenart wrote: > > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > > > > > If I get this right, the xMDIO controller is actually a superset of the > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Andrew Lunn
On Fri, Jun 09, 2017 at 10:25:41AM +0200, Antoine Tenart wrote: > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > > This patch adds the xMDIO interface support in the mvmdio driver. This > > > interface is used in Ethernet

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > This patch adds the xMDIO interface support in the mvmdio driver. This > > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as > > of now). The xSMI interface

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Thu, Jun 08, 2017 at 06:03:31PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > > +#define MVMDIO_XSMI_MGNT_REG 0x0 > > +#define MVMDIO_XSMI_READ_VALIDBIT(29) > > +#define MVMDIO_XSMI_BUSY BIT(30) > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hello Florian, Andrew, On Thu, Jun 08, 2017 at 06:55:46PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > > This patch adds the xMDIO interface support in the mvmdio driver. This > > > interface is

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Andrew Lunn
On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > This patch adds the xMDIO interface support in the mvmdio driver. This > > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as > > of now). The xSMI interface

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Florian Fainelli
On 06/08/2017 02:26 AM, Antoine Tenart wrote: > This patch adds the xMDIO interface support in the mvmdio driver. This > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as > of now). The xSMI interface supported by this driver complies with the > IEEE 802.3 clause 45 (while

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Andrew Lunn
On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > +#define MVMDIO_XSMI_MGNT_REG 0x0 > +#define MVMDIO_XSMI_READ_VALID BIT(29) > +#define MVMDIO_XSMI_BUSYBIT(30) > +#define MVMDIO_XSMI_ADDR_REG 0x8 > +#define MVMDIO_XSMI_PHYADDR_SHIFT 16

[PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Antoine Tenart
This patch adds the xMDIO interface support in the mvmdio driver. This interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as of now). The xSMI interface supported by this driver complies with the IEEE 802.3 clause 45 (while the SMI interface complies with the clause 22). The xSMI