[PATCH net] ipv6: udp: fix UDP_MIB_IGNOREDMULTI updates

2016-03-29 Thread Eric Dumazet
From: Eric Dumazet IPv6 counters updates use a different macro than IPv4. Fixes: 36cbb2452cbaf ("udp: Increment UDP_MIB_IGNOREDMULTI for arriving unmatched multicasts") Signed-off-by: Eric Dumazet Cc: Rick Jones Cc: Willem de

Re: [PATCH] rtl8xxxu: fix uninitialized return value in ret

2016-03-29 Thread Jes Sorensen
Colin King writes: > From: Colin Ian King > > several functions are not initializing a return status in ret > resulting in garbage to be returned instead of 0 for success. > Currently, the calls to these functions are not checking the > return,

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Vivien Didelot
Hi Patrick, Two comments below. Patrick Uiterwijk writes: > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds) Since this function assumes the SMI lock is already held, its name should be prefixed with _ by convention (_mv88e6xxx_power_on_serdes). > +{ > +

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Andrew Lunn
On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote: > Hi Patrick, > > Two comments below. > > Patrick Uiterwijk writes: > > > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds) > > Since this function assumes the SMI lock is already held, its name

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-29 Thread Vivien Didelot
Patrick Uiterwijk writes: > Add versions of the phy_page_read and _write functions to > be used in a context where the SMI mutex is held. > > Signed-off-by: Patrick Uiterwijk Tested-by: Vivien Didelot

[PATCH] rtl8xxxu: fix uninitialized return value in ret

2016-03-29 Thread Colin King
From: Colin Ian King several functions are not initializing a return status in ret resulting in garbage to be returned instead of 0 for success. Currently, the calls to these functions are not checking the return, however, it seems prudent to return the correct status

[PATCH] qed: initialize return rc to avoid returning garbage

2016-03-29 Thread Colin King
From: Colin Ian King in the case where qed_slowpath_irq_req is not called, rc is not assigned and so qed_int_igu_enable will return a garbage value. Fix this by initializing rc to 0. Signed-off-by: Colin Ian King ---

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread kbuild test robot
Hi Pontus, [auto build test ERROR on wireless-drivers/master] [also build test ERROR on v4.6-rc1 next-20160329] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Misc-wcn36xx

Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

2016-03-29 Thread Gregory CLEMENT
Hi Arnd, On mar., mars 15 2016, Arnd Bergmann wrote: > A recent change to the mbus driver added a warning printk that > prints a phys_addr_t using the %x format string, which fails in > case we build with 64-bit phys_addr_t: > > drivers/bus/mvebu-mbus.c: In function

[PATCH 09/16] wcn36xx: Parse trigger_ba response properly

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 14

[PATCH 08/16] wcn36xx: Remove sta pointer in private vif struct

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/main.c| 3 ---

[PATCH 10/16] wcn36xx: Copy all members in config_sta v1 conversion

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn

[PATCH 14/16] wcn36xx: Implement multicast filtering

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Pass the multicast list to FW. This patch also adds a way to build the smd command in place. This is needed because the MC list command is too big for the stack. Signed-off-by: Pontus Fuchs [bjorn: dropped FIF_PROMISC_IN_BSS

[PATCH 11/16] wcn36xx: Use allocated self sta index instead of hard coded

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs For consistency with other code. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 05/16] wcn36xx: Use define for invalid index and fix typo

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++--

[PATCH 04/16] wcn36xx: Use consistent name for private vif

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 28

[PATCH 00/16] Misc wcn36xx fixes

2016-03-29 Thread Bjorn Andersson
As I was debugging some issues with the wcn36xx driver I found a series of patches that exists in Eugene's github tree but not in mainline. Noteworthy is the long requested feature of having working ARP support. Please apply these rebased and relocated patches. Jason Mobarak (1): wcn36xx:

[PATCH 03/16] wcn36xx: Add helper macros to cast vif to private vif and vice versa

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Makes the code a little easier to read. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++-

[PATCH 01/16] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +--

[PATCH 02/16] wcn36xx: Pad TIM PVM if needed

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs The wcn36xx FW expects a fixed size TIM PVM in the beacon template. If supplied with a shorter than expected PVM it will overwrite the IE following the TIM. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson

[PATCH 16/16] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson ---

[PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh beaconing. The field tim_off is always 0 for mesh mode, and thus pvm_len (referring to the TIM length field) and pad are both incorrectly calculated. Thus, msg_body.beacon_length is

[PATCH 12/16] wcn36xx: Clear encrypt_type when deleting bss key

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson ---

[PATCH 13/16] wcn36xx: Track association state

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++

Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

2016-03-29 Thread Arnd Bergmann
On Tuesday 29 March 2016 18:04:47 Gregory CLEMENT wrote: > > What is the status of this patch? > > Do you plan to send a second version with the title fixed as suggested > by Joe Perches? > > Also do you expect that I collect this patch in the mvebu subsystem? Right now, it's on my long-term

ss filter problem

2016-03-29 Thread Phil Sutter
Hi, I am trying to fix a bug in ss filter code, but feel quite lost right now. The issue is this: | ss -nl -f inet '( sport = :22 )' prints not only listening sockets (as requested by -l flag), but established ones as well (reproduce by opening ssh connection to 127.0.0.1 before calling above).

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread David Miller
From: Tom Herbert Date: Mon, 28 Mar 2016 21:51:17 -0700 > No, but I do expect that you support code that is already there. There > was apparently zero testing done on the original patch and it caused > one very obvious regression. So how can we have any confidence >

Re: [PATCH 1/1] ipv4: fix NULL pointer dereference in __inet_put_port()

2016-03-29 Thread David Miller
From: fanhui Date: Tue, 29 Mar 2016 14:45:53 +0800 > [] tcp_nuke_addr+0x22c/0x2a0 Do not report or fix problems in non-mainline kernels. Thank you.

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread Alexander Duyck
On Tue, Mar 29, 2016 at 2:13 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >> This patch should fix the issues seen with a recent fix to prevent >> tunnel-in-tunnel frames from being generated with GRO. The fix itself

[RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh beaconing. The field tim_off is always 0 for mesh mode, and thus pvm_len (referring to the TIM length field) and pad are both incorrectly calculated. Thus, msg_body.beacon_length is

Re: [RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
On Tue 29 Mar 14:41 PDT 2016, Bjorn Andersson wrote: > From: Jason Mobarak > > Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh > beaconing. The field tim_off is always 0 for mesh mode, and thus > pvm_len (referring to the TIM length field) and pad are

[net PATCH v2] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread Alexander Duyck
This patch should fix the issues seen with a recent fix to prevent tunnel-in-tunnel frames from being generated with GRO. The fix itself is correct for now as long as we do not add any devices that support NETIF_F_GSO_GRE_CSUM. When such a device is added it could have the potential to mess

Re: [PATCH net] bpf: make padding in bpf_tunnel_key explicit

2016-03-29 Thread Alexei Starovoitov
On Wed, Mar 30, 2016 at 12:02:00AM +0200, Daniel Borkmann wrote: > Make the 2 byte padding in struct bpf_tunnel_key between tunnel_ttl > and tunnel_label members explicit. No issue has been observed, and > gcc/llvm does padding for the old struct already, where tunnel_label > was not yet present,

[PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-29 Thread Saeed Mahameed
Currently XPS select queue decision is final and overrides/ignores all other select queue parameters such as QoS TC, RX recording. This patch makes get_xps_queue value as a hint for skb_tx_hash, which will decide whether to use this hint as is or to tweak it a little to provide the correct TXQ.

Re: [PATCH net-next v3.16]r9169: Correct Set Vlan tag

2016-03-29 Thread David Miller
From: Corcodel Marian Date: Tue, 29 Mar 2016 11:33:20 +0300 > This patch add set Vlan tag and flush CPlusCmd register because when unset > RxVlan and RxChkSum bit, whithout some explication , unwanted bits > is set, PCIDAC, PCIMulRW and others.Whithout this patch when

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread Tom Herbert
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support >

Re: [PATCH] bridge: Allow set bridge ageing time when switchdev disabled

2016-03-29 Thread Ido Schimmel
Tue, Mar 29, 2016 at 01:48:08PM IDT, yanhaishu...@cmss.chinamobile.com wrote: >When NET_SWITCHDEV=n, switchdev_port_attr_set will return -EOPNOTSUPP, >we should ignore this error code and continue to set the ageing time. > >Signed-off-by: Haishuang Yan Fixes:

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Bjorn Andersson
On Tue 29 Mar 10:01 PDT 2016, kbuild test robot wrote: > Hi Pontus, > > [auto build test ERROR on wireless-drivers/master] > [also build test ERROR on v4.6-rc1 next-20160329] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving th

[PATCH net] bpf: make padding in bpf_tunnel_key explicit

2016-03-29 Thread Daniel Borkmann
Make the 2 byte padding in struct bpf_tunnel_key between tunnel_ttl and tunnel_label members explicit. No issue has been observed, and gcc/llvm does padding for the old struct already, where tunnel_label was not yet present, so the current code works, but since it's part of uapi, make sure we

RE: [PATCH] qed: initialize return rc to avoid returning garbage

2016-03-29 Thread Yuval Mintz
> From: Colin Ian King > > in the case where qed_slowpath_irq_req is not called, rc is not assigned and > so > qed_int_igu_enable will return a garbage value. > Fix this by initializing rc to 0. > > Signed-off-by: Colin Ian King Thanks

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Vivien Didelot
Hi Andrew, Patrick, Andrew Lunn writes: > On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote: >> Hi Patrick, >> >> Two comments below. >> >> Patrick Uiterwijk writes: >> >> > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds) >>

[RFC] Add netdev all_adj_list refcnt propagation to fix panic

2016-03-29 Thread Andrew Collins
This is an RFC patch to fix a relatively easily reproducible kernel panic related to the all_adj_list handling for netdevs in recent kernels. This is more to generate discussion than anything else. I don't particularly like this approach, I'm hoping someone has a better idea. The following

Re: [net-next 02/16] i40e/i40evf: Rewrite logic for 8 descriptor per packet check

2016-03-29 Thread Jesse Brandeburg
stupid gmail... sent again to the list, sorry for duplicate (but formatted better this time) Hey Alex, this patch appears to have caused a regression (probably both i40e/i40evf). Easily reproducible running rds-stress (see the thread titled "i40e card Tx resets", the middle post by sowmini has

Re: [PATCH net-next] tcp: remove cwnd moderation after recovery

2016-03-29 Thread Stephen Hemminger
On Tue, 29 Mar 2016 17:15:52 -0700 Yuchung Cheng wrote: > For non-SACK connections, cwnd is lowered to inflight plus 3 packets > when the recovery ends. This is an optional feature in the NewReno > RFC 2582 to reduce the potential burst when cwnd is "re-opened" > after

Best way to reduce system call overhead for tun device I/O?

2016-03-29 Thread Guus Sliepen
I'm trying to reduce system call overhead when reading/writing to/from a tun device in userspace. For sockets, one can use sendmmsg()/recvmmsg(), but a tun fd is not a socket fd, so this doesn't work. I'm see several options to allow userspace to read/write multiple packets with one syscall: -

[PATCH net-next] tcp: remove cwnd moderation after recovery

2016-03-29 Thread Yuchung Cheng
For non-SACK connections, cwnd is lowered to inflight plus 3 packets when the recovery ends. This is an optional feature in the NewReno RFC 2582 to reduce the potential burst when cwnd is "re-opened" after recovery and inflight is low. This feature is questionably effective because of PRR: when

Re: [PATCH RFC net-next] net: core: Pass XPS select queue decision to skb_tx_hash

2016-03-29 Thread John Fastabend
On 16-03-29 03:24 PM, Saeed Mahameed wrote: > Currently XPS select queue decision is final and overrides/ignores all other > select queue parameters such as QoS TC, RX recording. > > This patch makes get_xps_queue value as a hint for skb_tx_hash, which will > decide > whether to use this hint as

Re: [PATCH net] team: team should sync the port's uc/mc addrs when add a port

2016-03-29 Thread Xin Long
On Tue, Mar 29, 2016 at 12:56 PM, Cong Wang wrote: > On Mon, Mar 28, 2016 at 9:42 AM, Xin Long wrote: >> There is an issue when we use mavtap over team: >> When we replug nic links from team0, the real nics's mc list will not >> include the maddr

[PATCH net-next v3.16]r9169: Correct Set Vlan tag

2016-03-29 Thread Corcodel Marian
This patch add set Vlan tag and flush CPlusCmd register because when unset RxVlan and RxChkSum bit, whithout some explication , unwanted bits is set, PCIDAC, PCIMulRW and others.Whithout this patch when run ethtool -d eth0 on "C+ Command" field missing "VLAN de-tagging" Signed-off-by:

[net-next] bond: output message before setting slave to inactive

2016-03-29 Thread Zhang Shengju
This patch moves output message before setting slave to inactive, this will print the correct status of slave device. Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-29 Thread Charles Keepax
On Mon, Mar 28, 2016 at 08:30:11PM +0300, Sergei Shtylyov wrote: > >@@ -3029,7 +3030,8 @@ static int macb_remove(struct platform_device *pdev) > > mdiobus_free(bp->mii_bus); > > > > /* Shutdown the PHY if there is a GPIO reset */ > >-

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Kalle Valo
Wei-Ning Huang writes: > "single skb allocation failure" happens when system is under heavy > memory pressure. Add __GFP_REPEAT to skb allocation call so kernel > attempts to reclaim pages and retry the allocation. > > Signed-off-by: Wei-Ning Huang

[PATCH net-next] net: hns: add support of pause frame ctrl for HNS V2

2016-03-29 Thread Yisen Zhuang
From: Lisheng The patch adds support of pause ctrl for HNS V2, and this feature is lost by HNS V1: 1) service ports can disable rx pause frame, 2) debug ports can open tx/rx pause frame. And this patch updates the REGs about the pause ctrl when updated

[PATCH 1/1] ipv4: fix NULL pointer dereference in __inet_put_port()

2016-03-29 Thread fanhui
There may be race condition when accessing inet_csk(sk)->icsk_bind_hash, which leads to a crash like this: Unable to handle kernel NULL pointer dereference at virtual address 0010 .. [] inet_put_port+0x80/0xb8 [] tcp_set_state+0xc4/0x110 [] tcp_done+0x60/0xb8 [] tcp_nuke_addr+0x22c/0x2a0

[PATCH] bridge: Allow set bridge ageing time when switchdev disabled

2016-03-29 Thread Haishuang Yan
When NET_SWITCHDEV=n, switchdev_port_attr_set will return -EOPNOTSUPP, we should ignore this error code and continue to set the ageing time. Signed-off-by: Haishuang Yan --- net/bridge/br_stp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] mwifiex: advertise low priority scan feature

2016-03-29 Thread Wei-Ning Huang
I've resent the patch here: https://patchwork.kernel.org/patch/8637861/ Thanks! Wei-Ning On Tue, Mar 22, 2016 at 12:12 PM, Wei-Ning Huang wrote: > Hi Kalle, > > Thanks for the review. I accidentally removed the s-o-b line from > akarwar in this version. > The original patch

Re: am335x: no multicast reception over VLAN

2016-03-29 Thread Grygorii Strashko
On 03/29/2016 08:21 AM, Yegor Yefremov wrote: > Hi Mugunthan, > > On Tue, Mar 29, 2016 at 6:00 AM, Mugunthan V N wrote: >> Hi Yegor >> >> On Wednesday 16 March 2016 08:35 PM, Yegor Yefremov wrote: >>> I have an am335x based board using CPSW in Dual EMAC mode. Without >>>

[PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-29 Thread Patrick Uiterwijk
Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 49 + 1 file changed, 36 insertions(+), 13

[PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
Some of the vendor-specific bootloaders set up this part of the initialization for us, so this was never added. However, since upstream bootloaders don't initialize the chip specifically, they leave the fiber MII's PDOWN flag set, which means that the CPU port doesn't connect. This patch checks

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Wei-Ning Huang
Adding some chromium devs to the thread. In, http://lxr.free-electrons.com/source/mm/page_alloc.c#L3152 The default mm retry allocation when 'order <= PAGE_ALLOC_COSTLY_ORDER' of gfp_mask contains __GFP_REPEAT. PAGE_ALLOC_COSTLY_ORDER is defined to be 3. On systems with page size = 4K, this

RE: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Amitkumar Karwar
> From: Wei-Ning Huang [mailto:wnhu...@google.com] > Sent: Tuesday, March 29, 2016 2:57 PM > To: Kalle Valo > Cc: Linux Wireless; LKML; Amitkumar Karwar; Nishant Sarmukadam; Sameer > Nanda; netdev@vger.kernel.org; Sonny Rao; Douglas Anderson > Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb

Re: [PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Sergei Shtylyov
Hello. On 3/29/2016 9:06 AM, Bjorn Andersson wrote: From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh scripts/checkpatch.pl now enforces the specific commit citing format, i.e. <12-digit SHA1> (""). beaconing. The field

Re: bpf: net/core/filter.c:2115 suspicious rcu_dereference_protected() usage!

2016-03-29 Thread Michal Kubecek
On Mon, Feb 22, 2016 at 10:31:33AM -0500, Sasha Levin wrote: > > I've hit the following warning while fuzzing with trinity inside a kvmtool > guest > running the latest -next kernel: > > [ 1343.104588] === > [ 1343.104591] [ INFO: suspicious RCU usage. ] > [

Re: am335x: no multicast reception over VLAN

2016-03-29 Thread Yegor Yefremov
On Tue, Mar 29, 2016 at 1:05 PM, Grygorii Strashko wrote: > On 03/29/2016 08:21 AM, Yegor Yefremov wrote: >> Hi Mugunthan, >> >> On Tue, Mar 29, 2016 at 6:00 AM, Mugunthan V N wrote: >>> Hi Yegor >>> >>> On Wednesday 16 March 2016 08:35 PM, Yegor

Re: am335x: no multicast reception over VLAN

2016-03-29 Thread Grygorii Strashko
On 03/29/2016 03:35 PM, Yegor Yefremov wrote: > On Tue, Mar 29, 2016 at 1:05 PM, Grygorii Strashko > wrote: >> On 03/29/2016 08:21 AM, Yegor Yefremov wrote: >>> Hi Mugunthan, >>> >>> On Tue, Mar 29, 2016 at 6:00 AM, Mugunthan V N wrote: Hi

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Eric Dumazet
On Tue, 2016-03-29 at 17:27 +0800, Wei-Ning Huang wrote: > Adding some chromium devs to the thread. > > In, http://lxr.free-electrons.com/source/mm/page_alloc.c#L3152 > > The default mm retry allocation when 'order <= > PAGE_ALLOC_COSTLY_ORDER' of gfp_mask contains __GFP_REPEAT. >

[net-next RFC 3/4] bindtoprefix: TCP/IPv6 implementation

2016-03-29 Thread Gilberto Bertin
Signed-off-by: Gilberto Bertin --- net/ipv6/inet6_connection_sock.c | 17 - net/ipv6/inet6_hashtables.c | 6 ++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c

[net-next RFC 4/4] bindtoprefix: UPD implementation

2016-03-29 Thread Gilberto Bertin
Signed-off-by: Gilberto Bertin --- net/ipv4/udp.c | 36 1 file changed, 36 insertions(+) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 95d2f19..31b9687 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -133,6 +133,23 @@

[net-next RFC 1/4] bindtoprefix: infrastructure

2016-03-29 Thread Gilberto Bertin
Signed-off-by: Gilberto Bertin --- include/net/sock.h| 20 +++ include/uapi/asm-generic/socket.h | 1 + net/core/sock.c | 111 ++ 3 files changed, 132 insertions(+) diff --git

[net-next RFC 2/4] bindtoprefix: TCP/IPv4 implementation

2016-03-29 Thread Gilberto Bertin
Signed-off-by: Gilberto Bertin --- net/ipv4/inet_connection_sock.c | 20 +++- net/ipv4/inet_hashtables.c | 9 + 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/net/ipv4/inet_connection_sock.c

[net-next RFC 0/4] SO_BINDTOPREFIX

2016-03-29 Thread Gilberto Bertin
Since the net-next window just opened, I'm resubmitting my RFC for the SO_BINDTOSUBNET patch, following Mark Smith's suggestion to rename the whole thing to a more clear SO_BINDTOPREFIX. Some arguments for and against it since the first submission: * SO_BINDTOPREFIX is an arbitrary option and can

[PATCH] sctp: avoid refreshing heartbeat timer too often

2016-03-29 Thread Marcelo Ricardo Leitner
Currently on high rate SCTP streams the heartbeat timer refresh can consume quite a lot of resources as timer updates are costly and it contains a random factor, which a) is also costly and b) invalidates mod_timer() optimization for not editing a timer to the same value. It may even cause the

[PATCH 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-03-29 Thread Marcelo Ricardo Leitner
1st patch is a preparation for the 2nd. The idea is to not call ->sk_data_ready() for every data chunk processed while processing packets but only once before releasing the socket. Marcelo Ricardo Leitner (2): sctp: compress bit-wide flags to a bitfield on sctp_sock sctp: delay calls to

[PATCH] sctp: use list_* in sctp_list_dequeue

2016-03-29 Thread Marcelo Ricardo Leitner
Use list_* helpers in sctp_list_dequeue, more readable. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/sctp.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h index

Re: [PATCH net-next v3.16]r9169: Correct Set Vlan tag

2016-03-29 Thread Eric Dumazet
On Tue, 2016-03-29 at 11:33 +0300, Corcodel Marian wrote: > This patch add set Vlan tag and flush CPlusCmd register because when unset > RxVlan and RxChkSum bit, whithout some explication , unwanted bits > is set, PCIDAC, PCIMulRW and others.Whithout this patch when run > ethtool -d eth0 on

[PATCH] sctp: flush if we can't fit another DATA chunk

2016-03-29 Thread Marcelo Ricardo Leitner
There is no point in delaying the packet if we can't fit a single byte of data on it anymore. So lets just reduce the threshold by the amount that a data chunk with 4 bytes (rounding) would use. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/output.c | 3 ++- 1

Re: [PATCH 1/2 net-next v3.16]r8169: Disable set bit multicast enable per multicast address.

2016-03-29 Thread Eric Dumazet
On Sun, 2016-03-27 at 19:31 +0300, Corcodel Marian wrote: > On Sat, 26 Mar 2016 10:18:46 -0700 > Eric Dumazet wrote: > > > On Sat, 2016-03-26 at 12:57 +0200, Corcodel Marian wrote: > > > This patch correct set bit multicast enable only once per > > > set_rx_mode

[PATCH] sctp: really allow using GFP_KERNEL on sctp_packet_transmit

2016-03-29 Thread Marcelo Ricardo Leitner
Somehow my patch for commit cea8768f333e ("sctp: allow sctp_transmit_packet and others to use gfp") missed two important chunks, which are now added. Fixes: cea8768f333e ("sctp: allow sctp_transmit_packet and others to use gfp") Signed-off-by: Marcelo Ricardo Leitner

[PATCH 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-03-29 Thread Marcelo Ricardo Leitner
It wastes space and gets worse as we add new flags, so convert bit-wide flags to a bitfield. Currently it already saves 4 bytes in sctp_sock. Note that do_auto_asconf cannot be merged, as explained in the comment before it. Signed-off-by: Marcelo Ricardo Leitner ---

[PATCH 2/2] sctp: delay calls to sk_data_ready() as much as possible

2016-03-29 Thread Marcelo Ricardo Leitner
Currently processing of multiple chunks in a single SCTP packet leads to multiple calls to sk_data_ready, causing multiple wake up signals which are costy and doesn't make it wake up any faster. With this patch it will note that the wake up is pending and will do it before leaving the state

Re: bpf: net/core/filter.c:2115 suspicious rcu_dereference_protected() usage!

2016-03-29 Thread Daniel Borkmann
[ dropping my old email address ] On 03/29/2016 02:58 PM, Michal Kubecek wrote: On Mon, Feb 22, 2016 at 10:31:33AM -0500, Sasha Levin wrote: I've hit the following warning while fuzzing with trinity inside a kvmtool guest running the latest -next kernel: [ 1343.104588]

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
Hi Vivien, On Tue, Mar 29, 2016 at 6:49 PM, Vivien Didelot wrote: > Hi Andrew, Patrick, > > Andrew Lunn writes: > >> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote: >>> Hi Patrick, >>> >>> Two comments below. >>> >>> Patrick

Re: [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Andrew Lunn
On Wed, Mar 30, 2016 at 12:58:04AM +, Patrick Uiterwijk wrote: > Hi Vivien, > > On Tue, Mar 29, 2016 at 6:49 PM, Vivien Didelot > wrote: > > Hi Andrew, Patrick, > > > > Andrew Lunn writes: > > > >> On Tue, Mar 29, 2016 at 12:23:06PM

[PATCH net-next v3 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup

2016-03-29 Thread Patrick Uiterwijk
Some of the vendor-specific bootloaders set up this part of the initialization for us, so this was never added. However, since upstream bootloaders don't initialize the chip specifically, they leave the fiber MII's PDOWN flag set, which means that the CPU port doesn't connect. This patch checks

[PATCH net-next v3 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

2016-03-29 Thread Patrick Uiterwijk
Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Tested-by: Vivien Didelot Reviewed-by: Vivien Didelot Signed-off-by: Patrick Uiterwijk

Re: ss filter problem

2016-03-29 Thread Vadim Kochan
Hi Phil, On Tue, Mar 29, 2016 at 09:32:42PM +0200, Phil Sutter wrote: > Hi, > > I am trying to fix a bug in ss filter code, but feel quite lost right > now. The issue is this: > > | ss -nl -f inet '( sport = :22 )' > > prints not only listening sockets (as requested by -l flag), but >

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-03-29 Thread Yang Yingliang
On 2016/3/30 13:34, Eric Dumazet wrote: On Tue, 2016-03-29 at 22:25 -0700, Eric Dumazet wrote: On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote: When task A hold the sk owned in tcp_sendmsg, if lots of packets arrive and the packets will be added to backlog queue. The packets will be

[net-next] bond: set mac address only if necessary

2016-03-29 Thread Zhang Shengju
Bond device gets it's mac address from the first slave device, it's not necessary to set slave device's mac address to bond if equal. Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

RE: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-29 Thread Rosen, Rami
Hi, Netanel, +into 5 levels and assignes interrupt delay value to each level. Should be: assigns +The ENA device AQ and AENQ are allocated on probe and freed ontermination. Should be: on termination. + /* commit previously loaded firmare */ Should be: firmware +static int

Re: [PATCH] ethernet: mvneta: Support netpoll

2016-03-29 Thread Ezequiel Garcia
Hi David, On 30 March 2016 at 00:09, David Miller wrote: > From: Ezequiel Garcia > Date: Mon, 28 Mar 2016 17:41:18 -0300 > >> +/* Polled functionality used by netconsole and others in non interrupt mode >> */ >> +static void

[PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-03-29 Thread Yang Yingliang
When task A hold the sk owned in tcp_sendmsg, if lots of packets arrive and the packets will be added to backlog queue. The packets will be handled in release_sock called from tcp_sendmsg. When the sk_backlog is removed from sk, the length will not decrease until all the packets in backlog queue

Re: [net-next 02/16] i40e/i40evf: Rewrite logic for 8 descriptor per packet check

2016-03-29 Thread Alexander Duyck
On Tue, Mar 29, 2016 at 7:20 PM, Alexander Duyck wrote: > On Tue, Mar 29, 2016 at 5:34 PM, Jesse Brandeburg > wrote: >> stupid gmail... sent again to the list, sorry for duplicate (but >> formatted better this time) >> >> >> Hey Alex, this

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Kalle Valo
Bjorn Andersson writes: >> All error/warnings (new ones prefixed by >>): >> >>drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key': >> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit >> >> declaration of function

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-03-29 Thread Eric Dumazet
On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote: > When task A hold the sk owned in tcp_sendmsg, if lots of packets > arrive and the packets will be added to backlog queue. The packets > will be handled in release_sock called from tcp_sendmsg. When the > sk_backlog is removed from sk, the

Re: [net-next 02/16] i40e/i40evf: Rewrite logic for 8 descriptor per packet check

2016-03-29 Thread Jeff Kirsher
On Tue, 2016-03-29 at 22:19 -0700, Alexander Duyck wrote: > Minor correction here.  This is 72 hex, which is 114 in decimal.  The > interesting bit I believe is the fact that we have both header and > payload data in the same descriptor. > > You should probably check with your hardware team on

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-03-29 Thread Eric Dumazet
On Tue, 2016-03-29 at 22:25 -0700, Eric Dumazet wrote: > On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote: > > When task A hold the sk owned in tcp_sendmsg, if lots of packets > > arrive and the packets will be added to backlog queue. The packets > > will be handled in release_sock called

Re: am335x: no multicast reception over VLAN

2016-03-29 Thread Mugunthan V N
On Tuesday 29 March 2016 06:14 PM, Grygorii Strashko wrote: > On 03/29/2016 03:35 PM, Yegor Yefremov wrote: >> On Tue, Mar 29, 2016 at 1:05 PM, Grygorii Strashko >> wrote: >>> On 03/29/2016 08:21 AM, Yegor Yefremov wrote: Hi Mugunthan, On Tue, Mar 29, 2016

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-03-29 Thread Yang Yingliang
On 2016/3/30 13:25, Eric Dumazet wrote: On Wed, 2016-03-30 at 13:16 +0800, Yang Yingliang wrote: When task A hold the sk owned in tcp_sendmsg, if lots of packets arrive and the packets will be added to backlog queue. The packets will be handled in release_sock called from tcp_sendmsg. When

Re: [net-next RFC 0/4] SO_BINDTOPREFIX

2016-03-29 Thread Eric Dumazet
On Wed, 2016-03-23 at 02:26 +, Gilberto Bertin wrote: > Since the net-next window just opened, I'm resubmitting my RFC for the > SO_BINDTOSUBNET patch, following Mark Smith's suggestion to rename the > whole thing to a more clear SO_BINDTOPREFIX. Please do not add such monolithic option. BPF

  1   2   >