[PATCH (net.git)] stmmac: fix PWRDWN into the PMT register for global unicast.

2016-09-16 Thread Giuseppe Cavallaro
MAC devices use the RWKPKTEN and MGKPKTEN bits of the PMT Control/Status register to generate power management events. So this patch is to properly set the RWKPKTEN [BIT(2)] inside the PMT register (needed in case of global unicast). Reported-by: Aditi SHARMA

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Nicolas Dichtel
Le 16/09/2016 à 09:22, Anton Aksola a écrit : > The calling of netns_map_init() before command parsing introduced > a performance issue with large number of namespaces. > > As commands such as add, del and exec do not need to iterate through > /var/run/netns it would be good not no build the

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Vadim Kochan
On Fri, Sep 16, 2016 at 12:13 PM, Nicolas Dichtel wrote: > Le 16/09/2016 à 09:22, Anton Aksola a écrit : >> The calling of netns_map_init() before command parsing introduced >> a performance issue with large number of namespaces. >> >> As commands such as add, del and

Re: [PATCH net-next v2 0/7] add enhancement into the existing reset flow

2016-09-16 Thread David Miller
From: Date: Wed, 14 Sep 2016 23:13:14 +0800 > From: Sean Wang > > Current driver only resets DMA used by descriptor rings which > can't guarantee it can recover all various kinds of fatal > errors, so the patch > 1) tries to reset the underlying

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Thu, Sep 15, 2016 at 05:45:02PM -0600, David Ahern wrote: > > > > Try to be selective in the -K , do not kill tcp sockets ? > > I am running >ss -aKw 'dev == red' > > to kill raw sockets bound to device named 'red'. Thanks David, Eric! I'll play with this option today and report the

Hello

2016-09-16 Thread Hasher Al Maktoum
Dear Friend, Your contact details came to me by recommendation, I am interested in investing in your country and I believe you have the capabilities of providing the needed assistance, solutions and advise in actualizing this, Let me know if you are willing to understake this task for me so we

Re: MDB offloading of local ipv4 multicast groups

2016-09-16 Thread John Crispin
On 15/09/2016 22:42, Ido Schimmel wrote: > On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote: >> Hi, >> >> While adding MDB support to the qca8k dsa driver I found that ipv4 mcast >> groups don't always get propagated to the dsa driver. In my setup there >> are 2 clients connected to

Re: cdc_ncm driver padding problem

2016-09-16 Thread Bjørn Mork
> ==From: Marek Brudka .. > ==The bad thing is DHCP. It seems, that cdc_ncm driver somehow consumes DHCP > ==replies. I had to manually setup wwan0 interface as well as routing > ==using the result > ==of Hayes command > == > ==AT^DHCP? > ==^DHCP: >

Re: [PATCH net-next 3/4] samples/bpf: extend test_tunnel_bpf.sh with IPIP test

2016-09-16 Thread Daniel Borkmann
Hi William, On 09/16/2016 07:16 AM, William Tu wrote: Hi Alexei, Is there a corresponding patch for iproute2? I tested this patch but fails at: + ip link add dev ipip11 type ipip external because my ip command does not support "external". Yes, like any other collect metadata backends you

[PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Anton Aksola
The calling of netns_map_init() before command parsing introduced a performance issue with large number of namespaces. As commands such as add, del and exec do not need to iterate through /var/run/netns it would be good not no build the cache before executing these commands. Example: unpatched:

Re: [PATCH] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Anton Aksola
On Thu, Sep 15, 2016 at 03:26:18PM +0200, Nicolas Dichtel wrote: [snip] > 'ip netns' (ip netns list) also need it. Thanks, I missed your other commit that introduced it. Sending an updated patch.

[PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-16 Thread Vitaly Kuznetsov
Small packet loss is reported on complex multi host network configurations including tunnels, NAT, ... My investigation led me to the following check in netback which drops packets: if (unlikely(txreq.size < ETH_HLEN)) { netdev_err(queue->vif->dev,

Re: [PATCH net-next 0/5] mlx4 misc fixes and improvements

2016-09-16 Thread Or Gerlitz
On Fri, Sep 16, 2016 at 2:21 AM, David Miller wrote: > From: Tariq Toukan > Date: Mon, 12 Sep 2016 16:20:11 +0300 > >> This patchset contains some bug fixes, a cleanup, and small improvements >> from the team to the mlx4 Eth and core drivers. >> >>

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-16 Thread David Miller
From: Sebastian Ott Date: Wed, 14 Sep 2016 13:09:24 +0200 (CEST) > If an error occurs in mlx4_init_eq_table the index used in the > err_out_unmap label is one too big which results in a panic in > mlx4_free_eq. This patch fixes the index in the error path. > >

Re: [PATCH 0/2] pull request for net: batman-adv 2016-09-14

2016-09-16 Thread David Miller
From: Simon Wunderlich Date: Wed, 14 Sep 2016 14:37:33 +0200 > here are some more bugfix patches which we would like to have integrated > into net. > > Please pull or let me know of any problem! Pulled, thanks.

Re: [PATCH net] net: ethernet: mediatek: fix module loading automatically based on MODULE_DEVICE_TABLE

2016-09-16 Thread David Miller
From: Date: Wed, 14 Sep 2016 21:29:34 +0800 > From: Sean Wang > > The device table is required to load modules based on > modaliases. After adding MODULE_DEVICE_TABLE, below entries > for example will be added to modules.alias: > alias

Re: [PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list'

2016-09-16 Thread David Miller
From: Ivan Mikhaylov Date: Wed, 14 Sep 2016 19:06:45 +0300 > for preventing race conditions within ioctl calls. > > Signed-off-by: Ivan Mikhaylov Applied.

Re: [PATCH -next] net: dsa: b53: Remove unused including

2016-09-16 Thread David Miller
From: Wei Yongjun Date: Thu, 15 Sep 2016 02:24:37 + > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] net: emac: remove .owner field for driver

2016-09-16 Thread David Miller
From: Wei Yongjun Date: Thu, 15 Sep 2016 02:26:10 + > From: Wei Yongjun > > Remove .owner field if calls are used which set it automatically. > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: Wei Yongjun

Re: [PATCH -next] net: emac: remove unnecessary dev_set_drvdata()

2016-09-16 Thread David Miller
From: Wei Yongjun Date: Thu, 15 Sep 2016 02:25:52 + > From: Wei Yongjun > > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. > >

Re: [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning

2016-09-16 Thread David Miller
From: Wei Yongjun Date: Thu, 15 Sep 2016 02:24:13 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/dsa/bcm_sf2.c:963:19: warning: > symbol 'bcm_sf2_io_ops' was not declared. Should it be static? > > Signed-off-by:

Re: [patch net-next v9 2/3] net: core: Add offload stats to if_stats_msg

2016-09-16 Thread Nikolay Aleksandrov
> On Sep 14, 2016, at 12:28 PM, Jiri Pirko wrote: > > From: Nogah Frankel > > Add a nested attribute of offload stats to if_stats_msg > named IFLA_STATS_LINK_OFFLOAD_XSTATS. > Under it, add SW stats, meaning stats only per packets that went via >

Re: [patch net-next v9 2/3] net: core: Add offload stats to if_stats_msg

2016-09-16 Thread Jiri Pirko
Fri, Sep 16, 2016 at 10:00:46AM CEST, niko...@cumulusnetworks.com wrote: > >> On Sep 14, 2016, at 12:28 PM, Jiri Pirko wrote: >> >> From: Nogah Frankel >> >> Add a nested attribute of offload stats to if_stats_msg >> named IFLA_STATS_LINK_OFFLOAD_XSTATS.

Re: [PATCH net-next] tcp: fix a stale ooo_last_skb after a replace

2016-09-16 Thread David Miller
From: Eric Dumazet Date: Tue, 13 Sep 2016 22:55:05 -0700 > From: Eric Dumazet > > When skb replaces another one in ooo queue, I forgot to also > update tp->ooo_last_skb as well, if the replaced skb was the last one > in the queue. > > To fix this,

Re: [PATCH 1/2] net/ibm/emac: add set mac addr callback

2016-09-16 Thread David Miller
From: Ivan Mikhaylov Date: Wed, 14 Sep 2016 19:06:44 +0300 > add realization for mac address set and remove dummy callback. > > Signed-off-by: Ivan Mikhaylov Applied.

Re: [PATCH v2] net: VRF: Pass original iif to ip_route_input()

2016-09-16 Thread David Miller
From: Mark Tomlinson Date: Thu, 15 Sep 2016 11:40:05 +1200 > The function ip_rcv_finish() calls l3mdev_ip_rcv(). On any VRF except > the global VRF, this replaces skb->dev with the VRF master interface. > When calling ip_route_input_noref() from here, the

Re: [PATCH] nfp: fix error return code in nfp_net_netdev_open()

2016-09-16 Thread David Miller
From: Wei Yongjun Date: Thu, 15 Sep 2016 03:45:07 + > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 73725d9dfd99 ("nfp: allocate ring SW

[iproute PATCH] tc: don't accept qdisc 'handle' greater than ffff

2016-09-16 Thread Davide Caratti
since get_qdisc_handle() truncates the input value to 16 bit, return an error and prompt "invalid qdisc ID" in case input 'handle' parameter needs more than 16 bit to be stored. Signed-off-by: Davide Caratti --- tc/tc_util.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net 0/7] 390: qeth patches

2016-09-16 Thread David Miller
From: Ursula Braun Date: Thu, 15 Sep 2016 14:39:20 +0200 > here are several fixes for the s390 qeth driver, built for net. Series applied.

Re: [PATCH V3 0/3] net-next: dsa: add QCA8K support

2016-09-16 Thread David Miller
From: John Crispin Date: Thu, 15 Sep 2016 16:26:38 +0200 > This series is based on the AR8xxx series posted by Matthieu Olivari in may > 2015. The following changes were made since then > > * fixed the nitpicks from the previous review > * updated to latest API > * turned it

[PATCHv5 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag

2016-09-16 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_HW flag. Unlike U32 and flower cls_bpf already has some netlink flags defined. Create a new attribute to be able to use the same flag values as the above. Unlike U32 and flower reject unknown flags. Signed-off-by: Jakub Kicinski

[PATCHv5 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-16 Thread Jakub Kicinski
Hi! Dave, this set depends on bitfield.h which is sitting in the pull request from Kalle. Please pull wireless-drivers-next before applying. v5: - fix names of guard defines in bpf_verfier.h. v4: - rename parser -> analyzer; - reorganize the analyzer patches a bit; - use bitfield.h

[PATCHv5 net-next 01/15] net: cls_bpf: add hardware offload

2016-09-16 Thread Jakub Kicinski
This patch adds hardware offload capability to cls_bpf classifier, similar to what have been done with U32 and flower. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- v3: - s/filter/prog/ in struct tc_cls_bpf_offload. v2: - drop

[PATCHv5 net-next 03/15] net: cls_bpf: add support for marking filters as hardware-only

2016-09-16 Thread Jakub Kicinski
Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_SW flag. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- net/sched/cls_bpf.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

RE: [PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-16 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 15 September 2016 19:13 > No functional change. Just to avoid the usage of '&~3'. ... > - max_data = (asoc->pathmtu - > - sctp_sk(asoc->base.sk)->pf->af->net_header_len - > - sizeof(struct sctphdr) - sizeof(struct sctp_data_chunk))

[PATCHv5 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-16 Thread Jakub Kicinski
Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move existing jump target. Suggested-by: Alexei Starovoitov

[PATCHv5 net-next 13/15] net: act_mirred: allow statistic updates from offloaded actions

2016-09-16 Thread Jakub Kicinski
Implement .stats_update() callback. The implementation is generic and can be reused by other simple actions if needed. Signed-off-by: Jakub Kicinski --- net/sched/act_mirred.c | 8 1 file changed, 8 insertions(+) diff --git a/net/sched/act_mirred.c

[PATCHv5 net-next 14/15] nfp: bpf: add support for legacy redirect action

2016-09-16 Thread Jakub Kicinski
Data path has redirect support so expressing redirect to the port frame came from is a trivial matter of setting the right result code. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h | 1 +

[PATCHv5 net-next 08/15] nfp: add BPF to NFP code translator

2016-09-16 Thread Jakub Kicinski
Add translator for JITing eBPF to operations which can be executed on NFP's programmable engines. Signed-off-by: Jakub Kicinski --- v4: - use bitfield.h directly. v3: - don't clone the program for the verifier (no longer needed); - temporarily add a local copy of

[PATCHv5 net-next 11/15] nfp: bpf: allow offloaded filters to update stats

2016-09-16 Thread Jakub Kicinski
Periodically poll stats and call into offloaded actions to update them. Signed-off-by: Jakub Kicinski --- v3: - add missing hunk with ethtool stats. --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 19 +++

[PATCHv5 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats

2016-09-16 Thread Jakub Kicinski
Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann --- include/net/pkt_cls.h | 1 + net/sched/cls_bpf.c | 11 +++ 2 files changed, 12 insertions(+) diff --git

[PATCHv5 net-next 09/15] nfp: bpf: add hardware bpf offload

2016-09-16 Thread Jakub Kicinski
Add hardware bpf offload on our smart NICs. Detect if capable firmware is loaded and use it to load the code JITed with just added translator onto programmable engines. This commit only supports offloading cls_bpf in legacy mode (non-direct action). Signed-off-by: Jakub Kicinski

[PATCHv5 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-16 Thread Jakub Kicinski
Advanced JIT compilers and translators may want to use eBPF verifier as a base for parsers or to perform custom checks and validations. Add ability for external users to invoke the verifier and provide callbacks to be invoked for every intruction checked. For now only add most basic callback for

[PATCH][V2] mwifiex: fix null pointer deference when adapter is null

2016-09-16 Thread Colin King
From: Colin Ian King If adapter is null the error exit path in mwifiex_shutdown_sw is to down the semaphore sem and print some debug via mwifiex_dbg. However, passing a NULL adapter to mwifiex_dbg causes a null pointer deference when accessing adapter->dev. This fix

[PATCHv5 net-next 15/15] nfp: bpf: add offload of TC direct action mode

2016-09-16 Thread Jakub Kicinski
Add offload of TC in direct action mode. We just need to provide appropriate checks in the verifier and a new outro block to translate the exit codes to what data path expects Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_bpf.h |

[PATCHv5 net-next 12/15] nfp: bpf: add packet marking support

2016-09-16 Thread Jakub Kicinski
Add missing ABI defines and eBPF instructions to allow mark to be passed on and extend prepend parsing on the RX path to pick it up from packet metadata. Signed-off-by: Jakub Kicinski --- v3: - change metadata format. ---

[PATCHv5 net-next 05/15] bpf: expose internal verfier structures

2016-09-16 Thread Jakub Kicinski
Move verifier's internal structures to a header file and prefix their names with bpf_ to avoid potential namespace conflicts. Those structures will soon be used by external analyzers. Signed-off-by: Jakub Kicinski Acked-by: Alexei Starovoitov ---

[PATCHv5 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-16 Thread Jakub Kicinski
When running as parser interpret BPF_LD | BPF_IMM | BPF_DW instructions as loading CONST_IMM with the value stored in imm. The verifier will continue not recognizing those due to concerns about search space/program complexity increase. Signed-off-by: Jakub Kicinski

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Nicolas Dichtel
Le 16/09/2016 à 11:23, Vadim Kochan a écrit : [snip] > Would it be useful to add test for this case into testsuite/ ? Yes, it's a good idea. Regards, Nicolas

[PATCH][V2] net: r6040: add in missing white space in error message text

2016-09-16 Thread Colin King
From: Colin Ian King A couple of dev_err messages span two lines and the literal string is missing a white space between words. Add the white space and join the two lines into one. Signed-off-by: Colin Ian King ---

[PATCH] net: ipv6: Failure to disable forwarding per interface via sysctl

2016-09-16 Thread Mike Manning
Disabling forwarding per interface via sysctl continues to allow forwarding. This is contrary to the sysctl documentation stating that the forwarding sysctl is per interface, whereas currently it is only the sysctl for all interfaces that has an effect on forwarding. The solution is to drop any

Re: Modification to skb->queue_mapping affecting performance

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: > This is actually the problem - if flows from different RX queues are > switched to the same RX queue in IFB, they'll use different processor > context with the same tasklet, and the processor context of different > tasklets might be the same.

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Eric Dumazet
On Fri, Sep 16, 2016 at 1:03 PM, Neal Cardwell wrote: > > Looks like 'rate' should be 'rate64'. I will include this fix in the > next version of the patch series. > > neal Oh, right you are !

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 01:55:42PM -0600, David Ahern wrote: > >> Since the display is showing sockets in addition to IPPROTO_RAW: > >> > >> $ ss -A raw > >> State Recv-Q Send-QLocal Address:Port > >> Peer Address:Port > >> UNCONN 0 0

[PATCH v4 net 1/1] net sched actions: fix GETing actions

2016-09-16 Thread Jamal Hadi Salim
From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that tcf_action_destroy() will eventually delete the action from the permanent location if the refcount is zero. Example of what broke:

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 22:36:12 +0200 Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS.

Re: [PATCHv5 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: When running as parser interpret BPF_LD | BPF_IMM | BPF_DW instructions as loading CONST_IMM with the value stored in imm. The verifier will continue not recognizing those due to concerns about search space/program complexity increase.

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: arm-simpad_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH net-next 05/14] tcp: track data delivery rate for a TCP connection

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: cris-etrax-100lx_v2_defconfig (attached as .config) compiler: cris-linux-gcc (GCC) 6.2.0 reproduce: wget

[PATCH net-next 00/14] tcp: BBR congestion control algorithm

2016-09-16 Thread Neal Cardwell
tcp: BBR congestion control algorithm This patch series implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A paper with a detailed description of BBR will be published in ACM Queue, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR is

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread David Ahern
On 9/16/16 1:00 PM, Cyrill Gorcunov wrote: > I created veth pair and bound raw socket into it. > > [root@pcs7 iproute2]# misc/ss -A raw > State Recv-Q Send-QLocal Address:Port > Peer Address:Port

[PATCHv4 next 2/3] net: Add _nf_(un)register_hooks symbols

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Add _nf_register_hooks() and _nf_unregister_hooks() calls which allow caller to hold RTNL mutex. Signed-off-by: Mahesh Bandewar CC: Pablo Neira Ayuso --- include/linux/netfilter.h | 2 ++ net/netfilter/core.c

[PATCHv4 next 3/3] ipvlan: Introduce l3s mode

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar In a typical IPvlan L3 setup where master is in default-ns and each slave is into different (slave) ns. In this setup egress packet processing for traffic originating from slave-ns will hit all NF_HOOKs in slave-ns as well as default-ns. However same is

[PATCHv4 next 0/3] IPvlan introduce l3s mode

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Same old problem with new approach especially from suggestions from earlier patch-series. First thing is that this is introduced as a new mode rather than modifying the old (L3) mode. So the behavior of the existing modes is preserved as it is and the

Re: [PATCHv5 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move existing jump

[PATCH net-next 0/2] bnx2x: page allocation failure

2016-09-16 Thread Jason Baron
Hi, While configuring ~500 multicast addrs, we ran into high order page allocation failures. They don't need to be high order, and thus I'm proposing to split them into at most PAGE_SIZE allocations. Below is a sample failure. Thanks, -Jason [1201902.617882] bnx2x:

Re: XDP_TX bug report on mlx4

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 12:17:27 -0700 Brenden Blanco wrote: > On Fri, Sep 16, 2016 at 09:03:40PM +0200, Jesper Dangaard Brouer wrote: > > Hi Brenden, > > > > I've discovered a bug with XDP_TX recycling of pages in the mlx4 driver. > > > > If I increase the number of RX and

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by:

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Eric Dumazet
On Sat, 2016-09-17 at 11:56 +0800, kbuild test robot wrote: > Hi Yuchung, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 > config: arm-nhk8815_defconfig (attached as

[PATCH net-next 1/2] bnx2x: allocate mac filtering 'mcast_list' in PAGE_SIZE increments

2016-09-16 Thread Jason Baron
Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for 'mcast_list' to be done in PAGE_SIZE

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread Vincent Bernat
❦ 16 septembre 2016 20:36 CEST, David Ahern  : >> contained a non-connected route (like a default gateway) fails while it >> was previously working: >> >> $ ip link add eth0 type dummy >> $ ip link set up dev eth0 >> $ ip addr add 2001:db8::1/64 dev eth0 >>

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread David Ahern
On 9/16/16 1:15 PM, Vincent Bernat wrote: >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index ad4a7ff301fc..48bae2ee2e18 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c >> @@ -1991,9 +1991,19 @@ static struct rt6_info *ip6_route_info_create(struct >> fib6_config *cfg) >>

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 01:47:57PM -0600, David Ahern wrote: > >> > >> I'm guessing you passed IPPROTO_RAW (255) as the protocol to socket(). If > >> you pass something > >> else (IPPROTO_ICMP for example) it won't work. > > > > True. To support IPPROTO_ICMP it need enhancement. I thought start

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: arm-nhk8815_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-16 Thread Sargun Dhillon
On Wed, Sep 14, 2016 at 01:13:16PM +0200, Daniel Mack wrote: > Hi Pablo, > > On 09/13/2016 07:24 PM, Pablo Neira Ayuso wrote: > > On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: > >> On 09/13/2016 01:56 PM, Pablo Neira Ayuso wrote: > >>> On Mon, Sep 12, 2016 at 06:12:09PM +0200,

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 13:00:50 -0700 Eric Dumazet wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > index 2040dad8611d..d414c67dfd12 100644 > > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > +++

Re: [ethtool PATCH v1] ethtool: Document ethtool advertised speeds for 1G/10G

2016-09-16 Thread John W. Linville
On Tue, Sep 06, 2016 at 04:55:11PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Man page update to include updated advertised speeds for > 1G/10G > > Signed-off-by: Vidya Sagar Ravipati Applied, thanks! -- John W.

XDP_TX bug report on mlx4

2016-09-16 Thread Jesper Dangaard Brouer
Hi Brenden, I've discovered a bug with XDP_TX recycling of pages in the mlx4 driver. If I increase the number of RX and TX queues/channels via ethtool cmd: ethtool -L mlx4p1 rx 10 tx 10 Then when running the xdp2 program, which does XDP_TX, the kernel will crash with page errors, because the

Re: [PATCH net-next 02/14] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-16 Thread Neal Cardwell
On Fri, Sep 16, 2016 at 3:21 PM, kbuild test robot wrote: > All errors (new ones prefixed by >>): > >>> net/ipv4/tcp_cdg.c:59:8: error: redefinition of 'struct minmax' > struct minmax { >^~ >In file included from include/linux/tcp.h:22:0, >

[PATCHv4 next 1/3] ipv6: Export p6_route_input_lookup symbol

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Make ip6_route_input_lookup available outside of ipv6 the module similar to ip_route_input_noref in the IPv4 world. Signed-off-by: Mahesh Bandewar --- include/net/ip6_route.h | 3 +++ net/ipv6/route.c| 7 --- 2 files

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 10:06:23AM +0300, Cyrill Gorcunov wrote: > On Thu, Sep 15, 2016 at 05:45:02PM -0600, David Ahern wrote: > > > > > > Try to be selective in the -K , do not kill tcp sockets ? > > > > I am running > >ss -aKw 'dev == red' > > > > to kill raw sockets bound to device

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread David Ahern
On 9/16/16 1:52 PM, Cyrill Gorcunov wrote: > On Fri, Sep 16, 2016 at 01:47:57PM -0600, David Ahern wrote: I'm guessing you passed IPPROTO_RAW (255) as the protocol to socket(). If you pass something else (IPPROTO_ICMP for example) it won't work. >>> >>> True. To support

[v2] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread Vincent Bernat
Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups") introduced a regression: insertion of an IPv6 route in a table not containing the appropriate connected route for the gateway but which contained a non-connected route (like a default gateway) fails while it was previously

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by:

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Brenden Blanco
On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes:

Re: Modification to skb->queue_mapping affecting performance

2016-09-16 Thread Michael Ma
2016-09-16 12:53 GMT-07:00 Eric Dumazet : > On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: > >> This is actually the problem - if flows from different RX queues are >> switched to the same RX queue in IFB, they'll use different processor >> context with the same

Re: [PATCHv5 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Advanced JIT compilers and translators may want to use eBPF verifier as a base for parsers or to perform custom checks and validations. Add ability for external users to invoke the verifier and provide callbacks to be invoked for every intruction

Re: [PATCHv5 net-next 05/15] bpf: expose internal verfier structures

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Move verifier's internal structures to a header file and prefix their names with bpf_ to avoid potential namespace conflicts. Those structures will soon be used by external analyzers. Signed-off-by: Jakub Kicinski

[PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-16 Thread Hariprasad Shenai
Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with cxgb4 driver and free them while unregistering. All the queues and the interrupts for them will be allocated during ULD probe only and freed during

Re: [PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-16 Thread 'Marcelo Ricardo Leitner'
On Fri, Sep 16, 2016 at 09:51:56AM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 15 September 2016 19:13 > > No functional change. Just to avoid the usage of '&~3'. > ... > > - max_data = (asoc->pathmtu - > > - sctp_sk(asoc->base.sk)->pf->af->net_header_len - > >

[PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread David Vrabel
Write space becoming available may race with putting the task to sleep in xprt_wait_for_buffer_space(). The existing mechanism to avoid the race does not work. This (edited) partial trace illustrates the problem: [1] rpc_task_run_action: task:43546@5 ... action=call_transmit [2]

[patch net-next v10 2/3] net: core: Add offload stats to if_stats_msg

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Add a nested attribute of offload stats to if_stats_msg named IFLA_STATS_LINK_OFFLOAD_XSTATS. Under it, add SW stats, meaning stats only per packets that went via slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CPU_HIT. Signed-off-by: Nogah Frankel

[patch net-next v10 3/3] mlxsw: spectrum: Implement offload stats ndo and expose HW stats by default

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Change the default statistics ndo to return HW statistics (like the one returned by ethtool_ops). The HW stats are collected to a cache by delayed work every 1 sec. Implement the offload stat ndo. Add a function to get SW statistics, to be called from

[patch net-next v10 0/3] return offloaded stats as default and expose original sw stats

2016-09-16 Thread Jiri Pirko
From: Jiri Pirko From: Jiri Pirko The problem we try to handle is about offloaded forwarded packets which are not seen by kernel. Let me try to draw it: port1 port2 (HW stats are counted here) \ /

[patch net-next v10 1/3] netdevice: Add offload statistics ndo

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Add a new ndo to return statistics for offloaded operation. Since there can be many different offloaded operation with many stats types, the ndo gets an attribute id by which it knows which stats are wanted. The ndo also gets a void pointer to be cast

[net-next:master 58/374] drivers/net/ethernet/amazon/ena/ena_netdev.c:3026:1-11: Use setup_timer function for function on line 3028.

2016-09-16 Thread Julia Lawall
Setup_timer could be used instead of the cvall to init_timer and the initializations of the function and data fields. julia tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 84ce3da1bfd6fd12fce3cd06691e405a36f72cde commit:

drr scheduler [mis]configuration question

2016-09-16 Thread Michal Soltys
Hi, I have hit some weird (probably missing some detail) issue with drr. Originally it was tested between two machines, then I quickly double checked between namespaces (same behaviour) - the configuration follows: # setup namespace ip netns add drrtest ip li add name left type veth peer name

[lkp] [net] 70a8118a03: BUG: workqueue leaked lock or atomic: kworker/0:1/0x00000000/28

2016-09-16 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux Christophe-JAILLET/net-inet-diag-Fix-an-error-handling/20160912-140503 commit 70a8118a03243de2aba508d79cc1a042db094191 ("net: inet: diag: Fix an error handling") in testcase: boot on test machine: qemu-system-x86_64

[lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a

2016-09-16 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux fgao-ikuai8-com/netfilter-seqadj-Fix-some-possible-panics-of-seqadj-when-mem-is-exhausted/20160902-095727 commit 68263ddb4777cc996868498e3d56f616851966d2 ("netfilter: seqadj: Fix some possible panics of seqadj when mem is

Re: [PATCH] net: ipv6: Disable forwarding per interface via sysctl

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 13:47 +0100, Mike Manning wrote: > Disabling forwarding per interface via sysctl continues to allow > forwarding. This is contrary to the sysctl documentation stating that > the forwarding sysctl is per interface, whereas currently it is only > the sysctl for all interfaces

  1   2   >