Re: [PATCH net] openvswitch: Fix skb leak in IPv6 reassembly.

From: Daniele Di Proietto Date: Mon, 28 Nov 2016 15:43:53 -0800 > If nf_ct_frag6_gather() returns an error other than -EINPROGRESS, it > means that we still have a reference to the skb. We should free it > before returning from handle_fragments, as stated in the comment

[PATCH net-next v4 3/4] bpf: BPF for lightweight tunnel infrastructure

Registers new BPF program types which correspond to the LWT hooks: - BPF_PROG_TYPE_LWT_IN => dst_input() - BPF_PROG_TYPE_LWT_OUT => dst_output() - BPF_PROG_TYPE_LWT_XMIT => lwtunnel_xmit() The separate program types are required to differentiate between the capabilities each LWT hook

Re: [PATCH net-next v3 3/4] bpf: BPF for lightweight tunnel infrastructure

On 16-11-29 09:37 PM, Alexei Starovoitov wrote: > On Tue, Nov 29, 2016 at 06:52:36PM -0800, John Fastabend wrote: >> On 16-11-29 04:15 PM, Alexei Starovoitov wrote: >>> On Tue, Nov 29, 2016 at 02:21:22PM +0100, Thomas Graf wrote: Registers new BPF program types which correspond to the LWT

Re: Receive offloads, small RCVBUF and zero TCP window

On Monday, November 28, 2016 4:14:04 PM EST Alex Sidorenko wrote: > On Monday, November 28, 2016 3:54:59 PM EST David Miller wrote: > > From: Alex Sidorenko > > Date: Mon, 28 Nov 2016 15:49:26 -0500 > > > > > Now the question is whether is is OK to have

Re: DSA vs envelope frames

> What is not really clear - what if several tagging protocols are used > together. AFAIU, things may be more complex that simple appending of > tags, e.g. EDSA tag can carry VLAN id inside. Hi Nikita At least for all current tagging protocols, the size of the tag is constant. And you cannot run

Re: [net-next 1/1] samples: bpf: Refactor test_cgrp2_attach -- use getopt, and add mode

From: Sargun Dhillon Date: Mon, 28 Nov 2016 14:52:42 -0800 > This patch modifies test_cgrp2_attach to use getopt so we can use standard > command line parsing. > > It also adds an option to run the program in detach only mode. This does > not attach a new filter at the cgroup,

[PATCH net-next 6/8] net/mlx5e: Bring back representor's ndos that were accidentally removed

The VF Representor udp tunnel ndo entries were removed by mistake, return them. Fixes: 370bad0f9a52 ('net/mlx5e: Support HW (offloaded) and SW counters for SRIOV switchdev mode') Signed-off-by: Hadar Hen Zion --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++ 1

[PATCH net-next 1/8] net/sched: Add separate check for skip_hw flag

Creating a difference between two possible cases: 1. Not offloading tc rule since the user sets 'skip_hw' flag. 2. Not offloading tc rule since the device doesn't support offloading. This patch doesn't add any new functionality. Signed-off-by: Hadar Hen Zion Reviewed-by:

[PATCH net-next 4/8] net/sched: act_mirred: Add new tc_action_ops get_dev()

Adding support to a new tc_action_ops. get_dev is a general option which allows to get the underline device when trying to offload a tc rule. In case of mirred action the returned device is the mirred (egress) device. Signed-off-by: Hadar Hen Zion Reviewed-by: Jiri Pirko

[PATCH net-next 0/8] Offloading tc rules using underline Hardware device

This series adds flower classifier support in offloading tc rules when the Software ingress device is different from the Hardware ingress device, such as when dealing with IP tunnels The first two patches are a small fixes to flower, checking the skip_hw flag wasn't set before calling the

[PATCH net-next 2/8] net/sched: cls_flower: Try to offload only if skip_hw flag isn't set

Check skip_hw flag isn't set before calling fl_hw_{replace/destroy}_filter and fl_hw_update_stats functions. Replace the call to tc_should_offload with tc_can_offload. tc_can_offload only checks if the device supports offloading, the check for skip_hw flag is done earlier in the flow.

[PATCH net-next 3/8] net/sched: cls_flower: Provide a filter to replace/destroy hardware filter functions

Instead of providing many arguments to fl_hw_{replace/destroy}_filter functions, just provide cls_fl_filter struct that includes all the relevant args. This patches doesn't add any new functionality. Signed-off-by: Hadar Hen Zion Acked-by: Jiri Pirko ---

[PATCH net-next 7/8] net/mlx5e: Save the represntor netdevice as part of the representor

Replace the representor private data to a net_device pointer holding the representor netdevice, instead of void pointer holding mlx5e_priv. It will be used by a new eswitch service function, returning the uplink representor netdevice. Signed-off-by: Hadar Hen Zion ---

Re: [WIP] net+mlx4: auto doorbell

On Wed, 2016-11-30 at 12:38 +0100, Jesper Dangaard Brouer wrote: > I've played with a somewhat similar patch (from Achiad Shochat) for > mlx5 (attached). While it gives huge improvements, the problem I ran > into was that; TX performance became a function of the TX completion > time/interrupt and

[PATCH net-next v4 1/4] route: Set orig_output when redirecting to lwt on locally generated traffic

orig_output for IPv4 was only set for dsts which hit an input route. Set it consistently for locally generated traffic as well to allow lwt to continue the dst_output() path as configured by the nexthop. Fixes: 2536862311d ("lwt: Add support to redirect dst.input") Signed-off-by: Thomas Graf

[PATCH net-next v4 4/4] bpf: Add tests and samples for LWT-BPF

Adds a series of tests to verify the functionality of attaching BPF programs at LWT hooks. Also adds a sample which collects a histogram of packet sizes which pass through an LWT hook. $ ./lwt_len_hist.sh Starting netserver with host 'IN(6)ADDR_ANY' port '12865' and family AF_UNSPEC MIGRATED TCP

RE: Aw: Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

From: Eric Dumazet > Sent: 29 November 2016 00:19 > On Mon, 2016-11-28 at 23:02 +0100, Lino Sanfilippo wrote: > > Hi Eric, > > > > On 25.11.2016 20:19, Eric Dumazet wrote: > > > On Fri, 2016-11-25 at 17:30 +0100, Lino Sanfilippo wrote: > > >> Hi, > > >> > > >> > > >> > > > >> > The READ_ONCE() are

Re: [PATCH net-next v2] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

From: Erik Nordmark Date: Mon, 28 Nov 2016 15:26:05 -0800 > Implemented RFC7527 Enhanced DAD. > IPv6 duplicate address detection can fail if there is some temporary > loopback of Ethernet frames. RFC7527 solves this by including a random > nonce in the NS messages used for

Re: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

On 11/29/2016 07:35 PM, Nikita Yushchenko wrote: > Fec driver uses Rx buffers of 2k, but programs hardware to limit > incoming frames to 1522 bytes. This raises issues when FEC device > is used with DSA (since DSA tag can make frame larger), and also > disallows manual sending and receiving larger

Re: [WIP] net+mlx4: auto doorbell

On Wed, Nov 30, 2016 at 5:44 PM, Eric Dumazet wrote: > On Wed, 2016-11-30 at 15:50 +0200, Saeed Mahameed wrote: >> On Tue, Nov 29, 2016 at 8:58 AM, Eric Dumazet wrote: >> > On Mon, 2016-11-21 at 10:10 -0800, Eric Dumazet wrote: >> > >> > >> >> Not

[PATCH net-next V2 6/7] net/mlx5e: Refactor tc del flow to accept mlx5e_tc_flow instance

From: Roi Dayan Change the function that deletes offloaded TC rule to get struct mlx5e_tc_flow instance which contains both the flow handle and flow attributes. This is a cleanup needed for downstream patches, it doesn't change any functionality. Signed-off-by: Roi Dayan

[PATCH net-next V2 4/7] net/mlx5e: Remove redundant hashtable lookup in configure flower

From: Roi Dayan We will never find a flow with the same cookie as cls_flower always allocates a new flow and the cookie is the allocated memory address. Fixes: e3a2b7ed018e ("net/mlx5e: Support offload cls_flower with drop action") Signed-off-by: Roi Dayan

[PATCH net-next V2 1/7] net/mlx5e: Implement Fragmented Work Queue (WQ)

From: Tariq Toukan Add new type of struct mlx5_frag_buf which is used to allocate fragmented buffers rather than contiguous, and make the Completion Queues (CQs) use it as they are big (default of 2MB per CQ in Striding RQ). This fixes the failures of type:

[PATCH net-next V2 7/7] net/mlx5e: Remove flow encap entry in the correct place

From: Roi Dayan Handling flow encap entry should be inside tc del flow and is only relevant for offloaded eswitch TC rules. Fixes: 11a457e9b6c1 ("net/mlx5e: Add basic TC tunnel set action for SRIOV offloads") Signed-off-by: Roi Dayan Reviewed-by: Or

[PATCH net-next V2 2/7] net/mlx5e: Move function mlx5e_create_umr_mkey

From: Tariq Toukan In next patch we are going to create a UMR MKey per RQ, we need mlx5e_create_umr_mkey declared before mlx5e_create_rq. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed ---

[PATCH net-next V2 3/7] net/mlx5e: Create UMR MKey per RQ

From: Tariq Toukan In Striding RQ implementation, we used a single UMR (User-Mode Memory Registration) memory key for all RQs. When the product of RQs number*size gets high, we hit a limitation of u16 field size in FW. Here we move to using a UMR memory key per RQ, so we

[PATCH net-next V2 5/7] net/mlx5e: Correct cleanup order when deleting offloaded TC rules

From: Roi Dayan According to the reverse unwinding principle, on delete time we should first handle deletion of the steering rule and later handle the vlan deletion from the eswitch. Fixes: 8b32580df1cb ("net/mlx5e: Add TC vlan action for SRIOV offloads") Signed-off-by: Roi

[PATCH net-next V2 0/7] Mellanox 100G mlx5 updates 2016-11-29

Hi Dave, The following series from Tariq and Roi, provides some critical fixes and updates for the mlx5e driver. >From Tariq: - Fix driver coherent memory huge allocation issues by fragmenting completion queues, in a way that is transparent to the netdev driver by providing a new buffer

Re: [Patch net-next] audit: remove useless synchronize_net()

On Wed, Nov 30, 2016 at 1:16 AM, Richard Guy Briggs wrote: > On 2016-11-29 09:14, Cong Wang wrote: >> netlink kernel socket is protected by refcount, not RCU. >> Its rcv path is neither protected by RCU. So the synchronize_net() >> is just pointless. > > If I understand

Re: [WIP] net+mlx4: auto doorbell

On Wed, 2016-11-30 at 18:27 +0200, Saeed Mahameed wrote: > > In this case, i think they should implement their own bulking (pktgen > is not a good example) > but XDP can predict if it has more packets to xmit as long as all of > them fall in the same NAPI cycle. > Others should try and do the

Re: [PATCH net-next] bpf, xdp: allow to pass flags to dev_change_xdp_fd

From: Daniel Borkmann Date: Mon, 28 Nov 2016 23:16:54 +0100 > Add an IFLA_XDP_FLAGS attribute that can be passed for setting up > XDP along with IFLA_XDP_FD, which eventually allows user space to > implement typical add/replace/delete logic for programs. Right now, >

[PATCH net-next 5/8] net/sched: cls_flower: Add offload support using egress Hardware device

In order to support hardware offloading when the device given by the tc rule is different from the Hardware underline device, extract the mirred (egress) device from the tc action when a filter is added, using the new tc_action_ops, get_dev(). Flower caches the information about the mirred device

[PATCH net-next 8/8] net/mlx5e: Support adding ingress tc rule when egress device flag is set

When ndo_setup_tc is called with an egress_dev flag set, it means that the ndo call was executed on the mirred action (egress) device and not on the ingress device. In order to support this kind of ndo_setup_tc call, and insert the correct decap rule to the hardware, the uplink device on the same

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

On 30.11.2016 11:09, Jiri Pirko wrote: > From: Ido Schimmel > > Make sure the device has a complete view of the FIB tables by invoking > their dump during module init. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko >

Re: [WIP] net+mlx4: auto doorbell

On Wed, 2016-11-30 at 15:50 +0200, Saeed Mahameed wrote: > On Tue, Nov 29, 2016 at 8:58 AM, Eric Dumazet wrote: > > On Mon, 2016-11-21 at 10:10 -0800, Eric Dumazet wrote: > > > > > >> Not sure it this has been tried before, but the doorbell avoidance could > >> be done by

Re: [PATCH net-next v5 2/3] bpf: Add new cgroup attach type to enable sock modifications

On 11/29/16 10:41 PM, Alexei Starovoitov wrote: > I don't see a complexity. It was straightforward for skb bitfields, > but if there is some unforeseen issue, it's better to tackle it now > otherwise the feature may never come and this 'infra for sockets' will > stay as 'infra for vrf only' and

Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters

On Wed, Nov 30, 2016 at 5:58 PM, Eric Dumazet wrote: > On Wed, 2016-11-30 at 15:08 +0100, Jesper Dangaard Brouer wrote: >> On Fri, 25 Nov 2016 07:46:20 -0800 Eric Dumazet >> wrote: >> >> > From: Eric Dumazet >> >> Ended up-in

Re: DSA vs. SWTICHDEV ?

> This is an embedded system with several boards in a subrack. > Each board has eth I/F connected to a switch to communicate with each other. > One of the board will also house the actual switch device and manage the > switch. > Then the normal app just communicates over the physical eth I/F like

Re: [PATCH v2] vxlan: fix a potential issue when create a new vxlan fdb entry.

From: Haishuang Yan Date: Tue, 29 Nov 2016 09:59:36 +0800 > vxlan_fdb_append may return error, so add the proper check, > otherwise it will cause memory leak. > > Signed-off-by: Haishuang Yan > > Changes in v2: > -

Re: [PATCH v2 net-next] sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver

Applied, but yes you should really rethink the Kconfig stuff. I would strongly suggest you simply make them independent Kconfig options with no attachment to eachother. No depends, no implies, nothing like that.

Re: Aw: Re: [PATCH] mlx4: give precise rx/tx bytes/packets counters

On Wed, 2016-11-30 at 15:28 +, David Laight wrote: > Are you sure?? Yes I am > Last I looked gcc seemed to convert 'foo++' to 'foo = foo + 1' before > generating any code. Your gcc might need a refresh then. > It might then optimise that back to a memory increment, but that would > also

Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters

On Wed, 2016-11-30 at 15:08 +0100, Jesper Dangaard Brouer wrote: > On Fri, 25 Nov 2016 07:46:20 -0800 Eric Dumazet > wrote: > > > From: Eric Dumazet > > Ended up-in net-next as: > > commit 40931b85113dad7881d49e8759e5ad41d30a5e6c > Author: Eric

[PATCH net-next v4 0/4] bpf: BPF for lightweight tunnel encapsulation

This series implements BPF program invocation from dst entries via the lightweight tunnels infrastructure. The BPF program can be attached to lwtunnel_input(), lwtunnel_output() or lwtunnel_xmit() and see an L3 skb as context. Programs attached to input and output are read-only. Programs attached

[PATCH net-next v4 2/4] route: Set lwtstate for local traffic and cached input dsts

A route on the output path hitting a RTN_LOCAL route will keep the dst associated on its way through the loopback device. On the receive path, the dst_input() call will thus invoke the input handler of the route created in the output path. Thus, lwt redirection for input must be done for dsts

Re: [PATCH] net: ipv4: Don't crash if passing a null sk to ip_rt_update_pmtu.

On Tue, Nov 29, 2016 at 9:56 AM, Lorenzo Colitti wrote: > Commit e2d118a1cb5e ("net: inet: Support UID-based routing in IP > protocols.") made __build_flow_key call sock_net(sk) to determine > the network namespace of the passed-in socket. This crashes if sk > is NULL. Since

Re: [PATCH net-next V2 1/7] net/mlx5e: Implement Fragmented Work Queue (WQ)

Hi, On Wed, 30 Nov 2016, Saeed Mahameed wrote: > From: Tariq Toukan > > Add new type of struct mlx5_frag_buf which is used to allocate fragmented > buffers rather than contiguous, and make the Completion Queues (CQs) use > it as they are big (default of 2MB per CQ in

Re: qed, qedi patchset submission

> "Arun" == Arun Easi writes: Arun, Arun> So far, we have been posting qedi changes split into functional Arun> blocks, for review, but was not bisectable. With Martin ok to our Arun> request to squash all patches while committing to tree, we were Arun> wondering if we

Re: [PATCH net-next v3 0/2] net: phy: broadcom: Support for PHY counters

From: Florian Fainelli Date: Tue, 29 Nov 2016 09:57:16 -0800 > This patch series adds support for reading the Broadcom PHYs internal > counters. > > Changes in v3: > > - fixed the allocation of priv->stats in bcm7xxx > > Changes in v2: > > - fixed modular build

Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume

On 11/29/2016 06:18 PM, Ivan Khoronzhuk wrote: On Tue, Nov 29, 2016 at 04:27:03PM -0600, Grygorii Strashko wrote: netif_set_real_num_tx/rx_queues() are required to be called with rtnl_lock taken, otherwise ASSERT_RTNL() warning will be triggered - which happens now during System resume from

Re: [PATCH net-next V3 0/9] liquidio VF operations

From: Raghu Vatsavayi Date: Mon, 28 Nov 2016 16:54:32 -0800 > This patchseries adds support for VF device specific operations > like mailbox, queues and register access. This V3 patchset also > has changes based on comments form earlier versions: > > 1) Removed

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

Hi Hannes, On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 11:09, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Make sure the device has a complete view of the FIB tables by invoking > > their dump during module init. > > > >

Re: [PATCH net-next 8/8] net/mlx5e: Support adding ingress tc rule when egress device flag is set

On Wed, Nov 30, 2016 at 6:36 PM, John Fastabend wrote: > I started to dig through these patches and the last series here, > >Re: [PATCH net-next 00/13] Mellanox 100G SRIOV offloads tunnel_key > set/release > Can you explain how these two are related? I'm guessing

Re: DSA vs. SWTICHDEV ?

On Wed, Nov 30, 2016 at 02:30:43PM +, Joakim Tjernlund wrote: > On Wed, 2016-11-30 at 14:52 +0100, Andrew Lunn wrote: > > On Wed, Nov 30, 2016 at 08:50:34AM +, Joakim Tjernlund wrote: > > > I am trying to wrap my head around these two "devices" and have a hard > > > time telling them

Re: [WIP] net+mlx4: auto doorbell

On Tue, 2016-11-29 at 23:28 -0800, Alexei Starovoitov wrote: > On Mon, Nov 28, 2016 at 10:58 PM, Eric Dumazet wrote: > > { > > @@ -496,8 +531,13 @@ static bool mlx4_en_process_tx_cq(struct net_device > > *dev, > > wmb(); > > > > /* we want to dirty this

Re: [PATCH net] ipv6: Allow IPv4-mapped address as next-hop

From: Erik Nordmark Date: Mon, 28 Nov 2016 15:27:05 -0800 > @@ -1995,8 +1995,11 @@ static struct rt6_info *ip6_route_info_c > It is very good, but in some (rare!) circumstances > (SIT, PtP, NBMA NOARP links) it is handy to

Re: DSA vs. SWTICHDEV ?

On Wed, 2016-11-30 at 16:25 +0100, Andrew Lunn wrote: > On Wed, Nov 30, 2016 at 02:30:43PM +, Joakim Tjernlund wrote: > > On Wed, 2016-11-30 at 14:52 +0100, Andrew Lunn wrote: > > > On Wed, Nov 30, 2016 at 08:50:34AM +, Joakim Tjernlund wrote: > > > > I am trying to wrap my head around

Re: [PATCH net 5/7] net: ethernet: stmmac: dwmac-meson8b: fix probe error path

Johan Hovold writes: > Make sure to disable clocks before returning on late probe errors. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic > Meson 8b / GXBB DWMAC") > Signed-off-by: Johan Hovold Acked-by: Kevin Hilman

Re: BUG() can be hit in tcp_collapse()

Hello, Eric, Marco, all, This is JFYI and a follow-up message. A further investigation was made to find out the Linux kernel commit which has introduced the flaw. It appeared that previous Linux kernel versions are vulnerable, down to v3.6-rc1. This fact was hidden by 'net.ipv4.tcp_fastopen'

Re: [PATCH] cpsw: ethtool: add support for nway reset

From: Yegor Yefremov Date: Wed, 30 Nov 2016 10:31:30 +0100 > Hi David, > > On Wed, Nov 30, 2016 at 1:41 AM, David Miller wrote: >> From: yegorsli...@googlemail.com >> Date: Mon, 28 Nov 2016 10:47:52 +0100 >> >>> From: Yegor Yefremov

Re: [PATCH] net: brocade: bna: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 28 Nov 2016 23:52:19 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net-next 8/8] net/mlx5e: Support adding ingress tc rule when egress device flag is set

On 16-11-30 06:41 AM, Hadar Hen Zion wrote: > When ndo_setup_tc is called with an egress_dev flag set, it means that > the ndo call was executed on the mirred action (egress) device and not > on the ingress device. > > In order to support this kind of ndo_setup_tc call, and insert the > correct

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

On 30.11.2016 17:32, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 11:09, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Make sure the device has a complete view of the FIB tables by invoking >>>

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

On 16-11-30 06:30 AM, Jakub Kicinski wrote: > [add MST] > Thanks sorry MST. I did a cut'n'paste of an old list of CC's and missed you were not on the list. [...] >> +memcpy(page_address(page) + page_off, page_address(p) + offset, *len); >> +while (--num_buf) { >> +unsigned

Re: DSA vs. SWTICHDEV ?

> Something like that. I need to run routing protocols on the switch I/Fs and > egress > pkgs on selected switch I/Fs bypassing ARP, just like DSA does with its vendor > tags. Does the switch have an equivalent tagging protocol? If you are building a tree of switches you need something like this

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 17:32, Ido Schimmel wrote: > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: > >> On 30.11.2016 11:09, Jiri Pirko wrote: > >>> From: Ido Schimmel > >>> > >>> Make

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

On Wed, Nov 30, 2016 at 11:31:56AM -0600, Grygorii Strashko wrote: > ok. Seems my assumption that ndo_open/ndo_close serialized by > rtnl_lock is incorrect. Right? No, you were right in the first place. The open/close are indeed serialized by the rtnl lock. Sorry for the noise, Richard

Re: [net-next PATCH v3 0/6] XDP for virtio_net

On Tue, Nov 29, 2016 at 12:05:20PM -0800, John Fastabend wrote: > This implements virtio_net for the mergeable buffers and big_packet > modes. I tested this with vhost_net running on qemu and did not see > any issues. For testing num_buf > 1 I added a hack to vhost driver > to only but 100 bytes

Re: [PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

On Wed, 2016-11-30 at 14:01 -0500, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Only when ICMP packets are enqueued onto the error queue, > sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err > in sock_dequeue_err_skb), a subsequent error queue

Re: [PATCH] ehea: Remove unnecessary memset of stats in netdev private data

From: Tobias Klauser Date: Tue, 29 Nov 2016 14:35:07 +0100 > The memory for netdev private data is allocated using kzalloc/vzalloc in > alloc_netdev_mqs, thus there is no need to zero the stats portion of it > again in the driver's probe function. > > In any case, the size

Re: [PATCH 0/5] cpsw: add per channel shaper configuration

From: Ivan Khoronzhuk Date: Tue, 29 Nov 2016 17:00:46 +0200 > This series is intended to allow user to set rate for per channel > shapers at cpdma level. This patchset doesn't have impact on performance. > The rate can be set with: > > echo 100 >

[PATCH] netfilter: avoid warn and OOM on vmalloc call

Hi Andrey, Please let me know how this works for you. It seems good here, though your poc may still trigger OOM through other means. Thanks, Marcelo ---8<--- Andrey Konovalov reported that this vmalloc call is based on an userspace request and that it's spewing traces, which may flood the logs

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

On 11/30/2016 03:44 AM, Richard Cochran wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> @@ -678,6 +744,9 @@ struct gbe_priv { >> int num_et_stats; >> /* Lock for updating the hwstats */ >> spinlock_t

Re: [net-next] macvtap: replace printk with netdev_err

From: Zhang Shengju Date: Tue, 29 Nov 2016 11:26:32 +0800 > This patch replaces printk() with netdev_err() for macvtap device. > > Signed-off-by: Zhang Shengju Applied, thanks.

[PATCH net-next v6 0/6] net: Add bpf support for sockets

The recently added VRF support in Linux leverages the bind-to-device API for programs to specify an L3 domain for a socket. While SO_BINDTODEVICE has been around for ages, not every ipv4/ipv6 capable program has support for it. Even for those programs that do support it, the API requires processes

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

On Wed, Nov 30, 2016 at 08:50:41AM -0800, John Fastabend wrote: > On 16-11-30 06:30 AM, Jakub Kicinski wrote: > > [add MST] > > > > Thanks sorry MST. I did a cut'n'paste of an old list of CC's and missed > you were not on the list. > > [...] > > >> + memcpy(page_address(page) + page_off,

Re: DSA vs. SWTICHDEV ?

On 11/30/2016 10:44 AM, Joakim Tjernlund wrote: > On Wed, 2016-11-30 at 10:10 -0800, Florian Fainelli wrote: >> On 11/30/2016 09:44 AM, Joakim Tjernlund wrote: >>> On Wed, 2016-11-30 at 17:55 +0100, Andrew Lunn wrote: > This is an embedded system with several boards in a subrack. > Each

Re: [PATCH net][v2] bpf: fix states equal logic for varlen access

From: Josef Bacik Date: Tue, 29 Nov 2016 12:27:09 -0500 > If we have a branch that looks something like this > > int foo = map->value; > if (condition) { > foo += blah; > } else { > foo = bar; > } > map->array[foo] = baz; > > We will incorrectly assume that the !condition

Re: [PATCH net-next] bpf: add test for the verifier equal logic bug

From: Josef Bacik Date: Tue, 29 Nov 2016 12:35:19 -0500 > This is a test to verify that > > bpf: fix states equal logic for varlen access > > actually fixed the problem. The problem was if the register we added to our > map > register was UNKNOWN in both the false and true

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 29.11.2016 18:14, Florian Fainelli wrote: > On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: >> The problem is that the HW does not provide a tx completion index. Instead >> we have to >> iterate the status descriptors until we get an invalid idx which indicates >> that there >> are no

Re: DSA vs. SWTICHDEV ?

On Wed, 2016-11-30 at 17:55 +0100, Andrew Lunn wrote: > > This is an embedded system with several boards in a subrack. > > Each board has eth I/F connected to a switch to communicate with each other. > > One of the board will also house the actual switch device and manage the > > switch. > > Then

[PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

From: Soheil Hassas Yeganeh Only when ICMP packets are enqueued onto the error queue, sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err in sock_dequeue_err_skb), a subsequent error queue read would set sk_err to the next error on the queue, or 0 if empty. As no

[PATCH 1/1] ax25: Fix segfault when receiving an iframe with net2kiss loaded

AX.25 uses sock_queue_rcv_skb() to queue an iframe received packet. This routine writes NULL to the socket buffer device structure pointer. The socket buffer is subsequently serviced by __netif_receiv_skb_core() which dereferences the device structure pointer & segfaults. The fix puts the ax25

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

On Mon, Nov 28, 2016 at 04:18:03PM -0200, Marcelo Ricardo Leitner wrote: > On Mon, Nov 28, 2016 at 07:09:25PM +0100, Florian Westphal wrote: > > Neil Horman wrote: > > > > [ trimming CCs ] > > > > > On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote: > > > >

Re: [PATCH net 1/2] Set skb->protocol properly before calling dst_output()

From: Eli Cooper Date: Tue, 29 Nov 2016 10:35:28 +0800 > When xfrm is applied to TSO/GSO packets, it follows this path: > > xfrm_output() -> xfrm_output_gso() -> skb_gso_segment() > > where skb_gso_segment() relies on skb->protocol to function properly. > > This patch

Re: BUG() can be hit in tcp_collapse()

On Wed, 2016-11-30 at 12:00 -0500, Vladis Dronov wrote: > Hello, Eric, Marco, all, > > This is JFYI and a follow-up message. > > A further investigation was made to find out the Linux kernel commit which has > introduced the flaw. It appeared that previous Linux kernel versions are >

Re: [patch net v2] net: fec: cache statistics while device is down

From: Nikita Yushchenko Date: Tue, 29 Nov 2016 09:44:51 +0300 > Execution 'ethtool -S' on fec device that is down causes OOPS on Vybrid > board: > > Unhandled fault: external abort on non-linefetch (0x1008) at 0xe0898200 > pgd = ddecc000 > [e0898200]

[PATCH net] cdc_ether: Fix handling connection notification

Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") introduced a work-around in usbnet_cdc_status() for devices that exported cdc carrier on twice on connect. Before the commit, this behavior caused the link state to be incorrect. It was assumed that all CDC Ethernet devices

Re: DSA vs. SWTICHDEV ?

On Wed, 2016-11-30 at 10:10 -0800, Florian Fainelli wrote: > On 11/30/2016 09:44 AM, Joakim Tjernlund wrote: > > On Wed, 2016-11-30 at 17:55 +0100, Andrew Lunn wrote: > > > > This is an embedded system with several boards in a subrack. > > > > Each board has eth I/F connected to a switch to

Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include

From: Alexei Starovoitov Date: Wed, 30 Nov 2016 10:16:08 -0800 > this #include is unnecessary and brings whole set of > other headers into cgroup-defs.h. Remove it. > > Fixes: 3007098494be ("cgroup: add support for eBPF programs") > Signed-off-by: Alexei Starovoitov

Re: pull-request: wireless-drivers 2016-11-29

From: Kalle Valo Date: Tue, 29 Nov 2016 16:59:44 +0200 > if there's still time here's one more patch to 3.9. I think this is good > to have in 3.9 as it fixes an issue where we were printing uninitialised > memory in mwifiex. I had this in wireless-drivers already for some

Re: [PATCH] net: ipv4: Don't crash if passing a null sk to ip_rt_update_pmtu.

From: Lorenzo Colitti Date: Wed, 30 Nov 2016 02:56:47 +0900 > Commit e2d118a1cb5e ("net: inet: Support UID-based routing in IP > protocols.") made __build_flow_key call sock_net(sk) to determine > the network namespace of the passed-in socket. This crashes if sk > is NULL. >

Re: Netperf UDP issue with connected sockets

On 11/30/2016 02:43 AM, Jesper Dangaard Brouer wrote: Notice the "fib_lookup" cost is still present, even when I use option "-- -n -N" to create a connected socket. As Eric taught us, this is because we should use syscalls "send" or "write" on a connected socket. In theory, once the data

Re: [PATCH net-next] samples/bpf: fix include path

From: Alexei Starovoitov Date: Mon, 28 Nov 2016 22:07:22 -0800 > Fix the following build error: > HOSTCC samples/bpf/test_lru_dist.o > ../samples/bpf/test_lru_dist.c:25:22: fatal error: bpf_util.h: No such file > or directory > > This is due to objtree != srctree. > Use srctree,

Re: qed, qedi patchset submission

Thanks for the response, Martin. On Wed, 30 Nov 2016, 8:45am, Martin K. Petersen wrote: > > "Arun" == Arun Easi writes: > > Arun, > > Arun> So far, we have been posting qedi changes split into functional > Arun> blocks, for review, but was not bisectable. With Martin

Re: [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization

Hi Richard, On 11/29/2016 09:50 AM, Grygorii Strashko wrote: On 11/29/2016 04:07 AM, Richard Cochran wrote: On Mon, Nov 28, 2016 at 05:03:31PM -0600, Grygorii Strashko wrote: +int cpts_register(struct cpts *cpts) { int err, i; - cpts->info = cpts_info; -

Re: [net-next PATCH v3 0/6] XDP for virtio_net

On Wed, Nov 30, 2016 at 10:41:04AM -0800, John Fastabend wrote: > On 16-11-30 10:35 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 29, 2016 at 12:05:20PM -0800, John Fastabend wrote: > >> This implements virtio_net for the mergeable buffers and big_packet > >> modes. I tested this with vhost_net

Re: [PATCH net] cxgb4: Add PCI device ID for new adapter

From: Hariprasad Shenai Date: Tue, 29 Nov 2016 17:14:52 +0530 > Signed-off-by: Hariprasad Shenai Applied.

Re: [WIP] net+mlx4: auto doorbell

On Wed, 30 Nov 2016 07:56:26 -0800 Eric Dumazet wrote: > On Wed, 2016-11-30 at 12:38 +0100, Jesper Dangaard Brouer wrote: > > I've played with a somewhat similar patch (from Achiad Shochat) for > > mlx5 (attached). While it gives huge improvements, the problem I ran > >

Re: [PATCH v2 net 0/5] l2tp: fixes for l2tp_ip and l2tp_ip6 socket handling

From: James Chapman Date: Tue, 29 Nov 2016 13:47:06 + > On 29/11/16 12:09, Guillaume Nault wrote: >> This series addresses problems found while working on commit 32c231164b76 >> ("l2tp: fix racy SOCK_ZAPPED flag check in l2tp_ip{,6}_bind()"). >> >> The first three

Re: [PATCH v2 net-next 00/11] qed*: Add XDP support

From: Yuval Mintz Date: Tue, 29 Nov 2016 16:46:59 +0200 > This patch series is intended to add XDP to the qede driver, although > it contains quite a bit of cleanups, refactorings and infrastructure > changes as well. > > The content of this series can be roughly divided

  1   2   3   4   >