Re: [PATCH] net: netfilters: Remove unnecessary parenthesis

On Tue, Mar 28, 2017 at 06:56:48PM +0530, Arushi Singhal wrote: > Rmoved parentheses on the right hand side of assignment, as they are > not required. The following coccinelle script was used to fix this > issue: > > @@ > local idexpression id; > expression e; > @@ > > id = > -( > e > -) > >

Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator

On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote: > Replace explicit NULL comparison with ! operator to simplify code. > > Signed-off-by: Arushi Singhal > --- > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++--- > net/netfilter/ipvs/ip_vs_proto.c

Re: [PATCH 0/2] ARM: am335x-icev2: Add ethernet support

From: Tony Lindgren Date: Tue, 4 Apr 2017 09:01:06 -0700 > You may need to resend the davinci_mdio.c patch alone > for Dave as he usually won't pick individual patches I > think. Correct.

Re: [Intel-wired-lan] [PATCH] igb: Allow to remove administratively set MAC on VFs

On Tue, Apr 4, 2017 at 10:16 AM, Duyck, Alexander H wrote: >> -Original Message- >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On >> Behalf Of Corinna Vinschen >> Sent: Tuesday, April 4, 2017 8:11 AM >> To:

Re: [PATCH] net: ethernet: ti: cpsw: fix race condition during open()

From: Sekhar Nori Date: Mon, 3 Apr 2017 17:34:28 +0530 > TI's cpsw driver handles both OF and non-OF case for phy > connect. Unfortunately of_phy_connect() returns NULL on > error while phy_connect() returns ERR_PTR(). > > To handle this, cpsw_slave_open() overrides the return

Re: [PATCH 1/2] bpf: remove struct bpf_prog_type_list

Oops, I really meant to send these as RFC more than anything, because I don't really understand why it's done that way :) FWIW, the bloat-o-meter looks similar in both cases, like this: add/remove: 0/11 grow/shrink: 9/1 up/down: 145/-365 (-220) function old

Re: [PATCH next] bonding: fix active-backup transition

On Mon, Apr 03, 2017 at 06:38:39PM -0700, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Earlier patch c4adfc822bf5 ("bonding: make speed, duplex setting > consistent with link state") made an attempt to keep slave state > consistent with speed and duplex settings.

Re: pull-request: wireless-drivers-next 2017-04-03

From: Kalle Valo Date: Mon, 03 Apr 2017 14:26:10 +0300 > here few really small fixes. I'm hoping this to be the last pull request > for 4.11. > > Please let me if there are any problems. Pulled, thanks. But I will warn you, you say fixes, but your Subject line and GIT

Re: [PATCH] bpf: use 'ctx' instead of 'skb' in debug message

On Tue, 2017-04-04 at 19:26 +0200, Daniel Borkmann wrote: > >    if (regs[BPF_REG_6].type != PTR_TO_CTX) { > > - verbose("at the time of BPF_LD_ABS|IND R6 != > > pointer to skb\n"); > > + verbose("at the time of BPF_LD_ABS|IND R6 != > > pointer to ctx\n"); > >   

Re: net/sctp: list double add warning in sctp_endpoint_add_asoc

On Tue, Apr 4, 2017 at 9:28 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5). > > A reproducer and .config are attached. The script is pretty

Re: [PATCH net] l2tp: fix PPP pseudo-wire auto-loading

From: Guillaume Nault Date: Mon, 3 Apr 2017 13:23:15 +0200 > PPP pseudo-wire type is 7 (11 is L2TP_PWTYPE_IP). > > Fixes: f1f39f911027 ("l2tp: auto load type modules") > Signed-off-by: Guillaume Nault Applied and queued up for -stable.

[PATCH 1/2] bpf: remove struct bpf_prog_type_list

From: Johannes Berg There's no need to have struct bpf_prog_type_list since it just contains a list_head, the type, and the ops pointer. Since the types are densely packed and not actually dynamically registered, it's much easier and smaller to have an array of type->ops

[PATCH 2/2] bpf: remove struct bpf_map_type_list

From: Johannes Berg There's no need to have struct bpf_map_type_list since it just contains a list_head, the type, and the ops pointer. Since the types are densely packed and not actually dynamically registered, it's much easier and smaller to have an array of type->ops

Re: [PATCH] bpf: use 'ctx' instead of 'skb' in debug message

On 04/04/2017 04:46 PM, Johannes Berg wrote: From: Johannes Berg The error message here should mention 'ctx' since the context is now more generic than just an skb. Signed-off-by: Johannes Berg --- kernel/bpf/verifier.c | 2 +- 1 file

RE: [Intel-wired-lan] [PATCH] igb: Allow to remove administratively set MAC on VFs

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Corinna Vinschen > Sent: Tuesday, April 4, 2017 8:11 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] igb: Allow to

[Netdev conf Announce]: Keynote by Shrijeet Mukherjee

The tech committee is pleased to announce a keynote by Shrijeet Mukherjee titled "Journey into Enterprise Networking with Linux" Shrijeet wants to make Linux networking appealing to the Enterprise users and have it appear in the core of their critical networks. Come one, come all cheers,

Re: [PATCH] bnx2x: fix spelling mistake in macros HW_INTERRUT_ASSERT_SET_*

From: Colin King Date: Mon, 3 Apr 2017 11:19:10 +0100 > From: Colin Ian King > > Trival fix, rename HW_INTERRUT_ASSERT_SET_* to HW_INTERRUPT_ASSERT_SET_* > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net] l2tp: take reference on sessions being dumped

From: Guillaume Nault Date: Mon, 3 Apr 2017 12:03:13 +0200 > Take a reference on the sessions returned by l2tp_session_find_nth() > (and rename it l2tp_session_get_nth() to reflect this change), so that > caller is assured that the session isn't going to disappear while >

Re: [PATCH] i40e: limit client interface to X722 hardware

On Tue, Apr 4, 2017 at 5:34 PM, Stefan Assmann wrote: > The client interface is meant for X722 iWARP support. Modprobing i40iw > on systems with X710/XL710 NICs currently may crash the system. just curious may or crash? and why?

RE: [PATCH] i40e: limit client interface to X722 hardware

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Stefan Assmann > Sent: Tuesday, April 04, 2017 7:35 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; Kirsher, Jeffrey T >

[PATCH net-next] sfc: don't insert mc_list on low-latency firmware if it's too long

If the mc_list is longer than 256 addresses, we enter mc_promisc mode. If we're in mc_promisc mode and the firmware doesn't support cascaded multicast, normally we also insert our mc_list, to prevent stealing by another VI. However, if the mc_list was too long, this isn't really helpful - the

Re: [PATCH 0/2] ARM: am335x-icev2: Add ethernet support

* Roger Quadros [170330 05:37]: > Hi Tony & Dave, > > On 13/03/17 15:42, Roger Quadros wrote: > > Hi, > > > > This series adds ethernet support to am335x-icev2 board. > > > > The ethernet PHYs on the board need an explicit GPIO reset pulse > > to ensure they bootstrap to the

Re: [PATCH] can: rcar_can: Do not print virtual addresses

On 04/03/2017 12:11 PM, Geert Uytterhoeven wrote: > During probe, the rcar_can driver prints: > > rcar_can e6e8.can: device registered (regs @ e08bc000, IRQ76) > > The "regs" value is a virtual address, exposing internal information, > hence stop printing it. The (useful) physical

[PATCH 1/2] can: ifi: use correct register to read rx status

From: Markus Marb The incorrect offset was used when trying to read the RXSTCMD register. Signed-off-by: Markus Marb Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/ifi_canfd/ifi_canfd.c | 2

pull-request: can 2017-04-04

Hello David, this is a pull request of two patches for net/master. The first patch by Markus Marb fixes a register read access in the ifi driver. The second patch by Geert Uytterhoeven for the rcar driver remove the printing of a kernel virtual address. regards, Marc --- The following changes

[PATCH 2/2] can: rcar_can: Do not print virtual addresses

From: Geert Uytterhoeven During probe, the rcar_can driver prints: rcar_can e6e8.can: device registered (regs @ e08bc000, IRQ76) The "regs" value is a virtual address, exposing internal information, hence stop printing it. The (useful) physical address is

pull-request: can-next 2017-03-03

:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.13-20170404 for you to fetch changes up to 57e83fb9b7468c75cb65cde1d23043553c346c6d: can: hi311x: Add Holt HI-311x CAN driver (2017-04-04 17:3

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 03/24/2017 06:20 PM, Akshay Bhat wrote: > Hi Marc, > > On 03/17/2017 05:10 PM, Akshay Bhat wrote: >> This patch adds support for the Holt HI-311x CAN controller. The HI311x >> CAN controller is capable of transmitting and receiving standard data >> frames, extended data frames and remote

Re: [Intel-wired-lan] [next-queue v6 PATCH 2/7] i40e: Introduce Port Representor netdevs and switchdev mode.

On Tue, Apr 4, 2017 at 4:58 AM, Or Gerlitz wrote: > On Mon, Apr 3, 2017 at 9:41 PM, Samudrala, Sridhar > wrote: >> On 3/30/2017 12:17 AM, Or Gerlitz wrote: >>> On Thu, Mar 30, 2017, Sridhar Samudrala wrote: > Port Representator netdevs are

Re: [oss-security] Linux kernel ping socket / AF_LLC connect() sin_family race

Hi, did anyone request a CVE yet? Ciao, Marcus On Sat, Mar 25, 2017 at 01:10:57AM +0100, Solar Designer wrote: > On Fri, Mar 24, 2017 at 03:21:06PM -0700, Eric Dumazet wrote: > > Looks easy enough to fix ? > > Oh. Probably. Thanks. Need to test, but I guess you already did? > > > diff --git

[PATCH] igb: Allow to remove administratively set MAC on VFs

Before libvirt modifies the MAC address and vlan tag for an SRIOV VF for use by a virtual machine (either using vfio device assignment or macvtap passthru mode), it saves the current MAC address and vlan tag so that it can reset them to their original value when the guest is done.

[iproute PATCH] man: ip-link: Specify min/max values for bridge slave priority and cost

The values are parsed as u16/u32, but kernel limits allowed values. Signed-off-by: Phil Sutter --- man/man8/ip-link.8.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 3f5d57c28885f..12ec330a9c38e 100644

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

On Tue, Apr 04, 2017 at 04:43:19PM +0200, Niklas Cassel wrote: > On 04/04/2017 03:32 PM, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe > > --- > > > > Changes since

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

On Tue, Apr 04, 2017 at 04:43:19PM +0200, Niklas Cassel wrote: > On 04/04/2017 03:32 PM, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe > > --- > > > > Changes since

net/ipv4: use-after-free in ipv4_mtu

Hi, I've got the following error report while fuzzing the kernel with syzkaller. On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5). Unfortunately it's not reproducible. == BUG: KASAN: use-after-free in dst_metric_raw

Re: linux-next: manual merge of the net-next tree with the net tree

On Tue, Apr 04, 2017 at 11:13:57AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/core/flow_dissector.c > > between commit: > > ac6a3722fed6 ("flow dissector: correct size of storage for ARP") > > from the net tree and

[PATCH] bpf: use 'ctx' instead of 'skb' in debug message

From: Johannes Berg The error message here should mention 'ctx' since the context is now more generic than just an skb. Signed-off-by: Johannes Berg --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

On 04/04/2017 03:32 PM, Corentin Labbe wrote: > This patch add a generic testsuite for testing ethernet network device driver. > > Signed-off-by: Corentin Labbe > --- > > Changes since v1: > - Test for starting master interface > - Changed printing format to "RESULT:

[PATCH] i40e: limit client interface to X722 hardware

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system. Adding a check which limits client interface access to the appropriate hardware. Signed-off-by: Stefan Assmann ---

Re: [PATCH v3] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

On Tue, 4 Apr 2017 20:24:59 +0900 Masami Hiramatsu wrote: > On Mon, 3 Apr 2017 12:36:22 +0200 > Alban Crequy wrote: > > > From: Alban Crequy > > > > When a kretprobe is installed on a kernel function, there is a maximum > >

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

On Tue, Apr 04, 2017 at 03:32:47PM +0200, Corentin Labbe wrote: > This patch add a generic testsuite for testing ethernet network device driver. # ip link show 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode DEFAUL0 link/loopback 00:00:00:00:00:00 brd

net/dccp: BUG in tfrc_rx_hist_sample_rtt

Hi, I've got the following error report while fuzzing the kernel with syzkaller. On commit a71c9a1c779f2499fb2afc0553e543f18aff6edf (4.11-rc5). I'm able to reproduce it by executing the attached syzkaller prog, but there's no simple C reproducer. My .config is attached. BUG: please report to

[PATCH v2] selftests: add a generic testsuite for ethernet device

This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe --- Changes since v1: - Test for starting master interface - Changed printing format to "RESULT: $netdev: line" - Use "ip link" to get device list

RE: [PATCH] bnx2x: fix spelling mistake in macros HW_INTERRUT_ASSERT_SET_*

> Trival fix, rename HW_INTERRUT_ASSERT_SET_* to > HW_INTERRUPT_ASSERT_SET_* > > Signed-off-by: Colin Ian King Thanks. Don't know if it's needed but still: Acked-by: Yuval Mintz

[PATCH v3 iproute] ip: Add support for netdev events to monitor

Add IFLA_EVENT handling so that event types can be viewed with 'monitor' command. This gives a little more information for why a given message was receivied. Signed-off-by: Vladislav Yasevich --- include/linux/if_link.h | 21 + ip/ipaddress.c |

[PATCH v2 net-next 2/2] rtnl: Add support for netdev event to link messages

When netdev events happen, a rtnetlink_event() handler will send messages for every event in it's white list. These messages contain current information about a particular device, but they do not include the iformation about which event just happened. The consumer of the message has to try to

[PATCH net-next 0/2] rtnetlink: Updates to rtnetlink_event()

This series came out of the conversation that started as a result my first attempt to add netdevice event info to netlink messages. This series converts event processing to a 'white list', where we explicitely permit events to generate netlink messages. This is meant to make people take a closer

[PATCH v2 net-next 1/2] rtnetlink: Convert rtnetlink_event to white list

The rtnetlink_event currently functions as a blacklist where we block cerntain netdev events from being sent to user space. As a result, events have been added to the system that userspace probably doesn't care about. This patch converts the implementation to the white list so that newly events

[PATCH v2 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

This series came out of the conversation that started as a result my first attempt to add netdevice event info to netlink messages. This series converts event processing to a 'white list', where we explicitely permit events to generate netlink messages. This is meant to make people take a closer

[PATCH net-next v2 1/1] net: tcp: Define the TCP_MAX_WSCALE instead of literal number 14

From: Gao Feng Define one new macro TCP_MAX_WSCALE instead of literal number '14', and use U16_MAX instead of 65535 as the max value of TCP window. There is another minor change, use rounddown(space, mss) instead of (space / mss) * mss; Signed-off-by: Gao Feng

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

On Tue, Apr 04, 2017 at 10:46:54AM +0300, Max Gurtovoy wrote: >> +if (set->nr_hw_queues > dev->num_comp_vectors) >> +goto fallback; >> + >> +for (queue = 0; queue < set->nr_hw_queues; queue++) { >> +mask = ib_get_vector_affinity(dev, first_vec + queue); >> +

Re: [PATCH] selftests: add a generic testsuite for ethernet device

On Tue, Apr 04, 2017 at 09:56:04AM +0200, Corentin Labbe wrote: > On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > > By ifnum, you mean by the order that "ip link" gives ? > > > > I've not checked if it remains in order as interfaces are hot > > plugged/unplugged. But i guess you

[PATCH net-next] net: stmmac: allow changing the MTU while the interface is running

From: Niklas Cassel Setting ethtool ops for stmmac is only allowed when the interface is up. Setting MTU (a netdev op) for stmmac is only allowed when the interface is down. It seems that the only reason why MTU cannot be changed when running is that we have not bothered

Re: [next-queue v6 PATCH 2/7] i40e: Introduce Port Representor netdevs and switchdev mode.

On Mon, Apr 3, 2017 at 9:41 PM, Samudrala, Sridhar wrote: > On 3/30/2017 12:17 AM, Or Gerlitz wrote: >> On Thu, Mar 30, 2017, Sridhar Samudrala wrote: >>> Port Representator netdevs are created for each PF and VF if the switch >>> mode is set to 'switchdev'. These

Re: [PATCH] soreuseport: use "unsigned int" in __reuseport_alloc()

On Mon, Apr 3, 2017 at 4:56 PM, Craig Gallek wrote: > On Sun, Apr 2, 2017 at 6:18 PM, Alexey Dobriyan wrote: >> Number of sockets is limited by 16-bit, so 64-bit allocation will never >> happen. >> >> 16-bit ops are the worst code density-wise on

Re: [PATCH v3] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

On Mon, 3 Apr 2017 12:36:22 +0200 Alban Crequy wrote: > From: Alban Crequy > > When a kretprobe is installed on a kernel function, there is a maximum > limit of how many calls in parallel it can catch (aka "maxactive"). A > kernel module could call

RE: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

> Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

[PATCH] net: thunderx: Switch to pci_alloc_irq_vectors

From: Thanneeru Srinivasulu Remove deprecated pci_enable_msix API in favour of it's successor pci_alloc_irq_vectors. Signed-off-by: Thanneeru Srinivasulu Signed-off-by: Sunil Goutham ---

Re: [PATCH] selftests: add a generic testsuite for ethernet device

On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > By ifnum, you mean by the order that "ip link" gives ? > > I've not checked if it remains in order as interfaces are hot > plugged/unplugged. But i guess you are running tests direct after > boot, and unplugs/replugs are unlikely? >

Re: [PATCH rfc 0/6] Automatic affinity settings for nvme over rdma

Any feedback is welcome. Hi Sagi, the patchset looks good and of course we can add support for more drivers in the future. have you run some performance testing with the nvmf initiator ? Sagi Grimberg (6): mlx5: convert to generic pci_alloc_irq_vectors mlx5: move affinity hints

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

diff --git a/block/blk-mq-rdma.c b/block/blk-mq-rdma.c new file mode 100644 index ..d402f7c93528 --- /dev/null +++ b/block/blk-mq-rdma.c @@ -0,0 +1,56 @@ +/* + * Copyright (c) 2017 Sagi Grimberg. + * + * This program is free software; you can redistribute it and/or modify it + *

Note

favorable transaction of £ 12.5 million,which will benefit both of us.

Re: [PATCH] af_key: Add lock to key dump

On Fri, Mar 31, 2017 at 03:10:20PM +0800, Yuejie Shi wrote: > A dump may come in the middle of another dump, modifying its dump > structure members. This race condition will result in NULL pointer > dereference in kernel. So add a lock to prevent that race. > > Fixes: 83321d6b9872 ("[AF_KEY]:

Re: [PATCH rfc 6/6] nvme-rdma: use intelligent affinity based queue mappings

On Sun, Apr 02, 2017 at 04:41:32PM +0300, Sagi Grimberg wrote: > Use the geneic block layer affinity mapping helper. Also, generic > nr_io_queues = min(opts->nr_io_queues, num_online_cpus()); > + nr_io_queues = min_t(unsigned int, nr_io_queues, > +

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

On Sun, Apr 02, 2017 at 04:41:31PM +0300, Sagi Grimberg wrote: > Like pci and virtio, we add a rdma helper for affinity > spreading. This achieves optimal mq affinity assignments > according to the underlying rdma device affinity maps. > > Signed-off-by: Sagi Grimberg > --- >

Re: [PATCH rfc 4/6] mlx5: support ->get_vector_affinity

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH rfc 3/6] RDMA/core: expose affinity mappings per completion vector

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH rfc 2/6] mlx5: move affinity hints assignments to generic code

> @@ -1375,7 +1375,8 @@ static void mlx5e_close_cq(struct mlx5e_cq *cq) > > static int mlx5e_get_cpu(struct mlx5e_priv *priv, int ix) > { > - return cpumask_first(priv->mdev->priv.irq_info[ix].mask); > + return cpumask_first(pci_irq_get_affinity(priv->mdev->pdev, > +

Re: [PATCH rfc 1/6] mlx5: convert to generic pci_alloc_irq_vectors

Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

RE: [PATCH -next] qed: Add a missing error code

> We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The > current code returns success. > > Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") > Signed-off-by: Dan Carpenter Thanks Acked-by: Tomer Tayar

<    1   2