Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Yury Norov Date: Tue, 6 Feb 2018 20:03:13 +0300 > On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: >> From: Yury Norov >> Date: Tue, 6 Feb 2018 19:26:23 +0300 >> >> > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread Kees Cook
On Wed, Feb 7, 2018 at 3:19 AM, David Miller wrote: > From: Kees Cook > Date: Tue, 6 Feb 2018 04:31:50 +1100 > >> On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >>> From: Kees Cook >>> Date: Fri, 2 Feb

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Daniel Borkmann
On 02/06/2018 06:03 PM, Jesper Dangaard Brouer wrote: > On Tue, 6 Feb 2018 08:00:59 -0800 Alexei Starovoitov > wrote: >> On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: >>> If clang >= 4.0.1 is missing the option '-target bpf', it will cause

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Florian Fainelli
On 02/06/2018 09:05 AM, Andrew Lunn wrote: > On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: >> On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: >>> And a DSA driver does not need to be complex. You can start simple, >>> and add more features later. >> >> I

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > > And a DSA driver does not need to be complex. You can start simple, > > and add more features later. > > I see. Would it be possible/practical to start

Re: possible deadlock in rtnl_lock (3)

2018-02-06 Thread Dmitry Vyukov
On Tue, Feb 6, 2018 at 6:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) > Merge tag 'usercopy-v4.16-rc1' of >

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
Andrew and Florian, thanks for your input. On Tue, Feb 6, 2018 at 12:05 PM, Andrew Lunn wrote: > I would NACK sysfs bin file. Do it right, or don't do it at all. On Tue, Feb 6, 2018 at 12:47 PM, Florian Fainelli wrote: > Sven, there is a standard ethtool

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Yury Norov Date: Tue, 6 Feb 2018 19:26:23 +0300 > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: >> From: Heiner Kallweit >> Date: Mon, 5 Feb 2018 07:21:32 +0100 >> >> > Recently ethtool started to give incomplete values for

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > And a DSA driver does not need to be complex. You can start simple, > and add more features later. I see. Would it be possible/practical to start with just phy_read/write, port_enable/disable in dsa_switch_ops ? And just add a

[bpf-next V2 PATCH 2/5] tools/libbpf: improve the pr_debug statements to contain section numbers

2018-02-06 Thread Jesper Dangaard Brouer
While debugging a bpf ELF loading issue, I needed to correlate the ELF section number with the failed relocation section reference. Thus, add section numbers/index to the pr_debug. In debug mode, also print section that were skipped. This helped me identify that a section (.eh_frame) was

[bpf-next V2 PATCH 0/5] tools/libbpf improvements and selftests

2018-02-06 Thread Jesper Dangaard Brouer
While playing with using libbpf for the Suricata project, we had issues LLVM >= 4.0.1 generating ELF files that could not be loaded with libbpf (tools/lib/bpf/). During the troubleshooting phase, I wrote a test program and improved the debugging output in libbpf. I turned this into a selftests

[bpf-next V2 PATCH 1/5] bpf: Sync kernel ABI header with tooling header for bpf_common.h

2018-02-06 Thread Jesper Dangaard Brouer
I recently fixed up a lot of commits that forgot to keep the tooling headers in sync. And then I forgot to do the same thing in commit cb5f7334d479 ("bpf: add comments to BPF ld/ldx sizes"). Let correct that before people notice ;-). Lawrence did partly fix/sync this for bpf.h in commit

[PATCH v1 1/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
The register map layouts used in this driver are well suited to being accessed through a regmap. This makes the driver simpler and shorter, by eliminating some spi boilerplate code. Testing: - tested on a ksz8785. - not tested on the other supported chips (ks8995, ksz8864) because I don't have

[PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
v1: starting point. is there a way to test-run this on supported devices that I don't have physical access to - (ks8995, ksz8864) ? Sven Van Asbroeck (1): spi_ks8995: use regmap to access chip registers. drivers/net/phy/spi_ks8995.c | 163

Re: [PATCH net] net: phy: Handle not having GPIO enabled in the kernel

2018-02-06 Thread David Miller
From: Andrew Lunn Date: Mon, 5 Feb 2018 19:17:23 +0100 > If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub > function, which return -ENOSYS. Handle this in the same way as > -ENOENT, i.e. assume there is no GPIO used to reset the PHYs. > > Reported-by:

Re: [PATCH net 0/3] net: erspan fixes

2018-02-06 Thread David Miller
From: William Tu Date: Mon, 5 Feb 2018 13:35:33 -0800 > The first patch fixes erspan metadata extraction issue from packet > header due to commit d350a823020e ("net: erspan: create erspan metadata > uapi header"). The commit moves the erspan 'version' in > 'struct

Re: [PATCH net v4] cls_u32: fix use after free in u32_destroy_key()

2018-02-06 Thread David Miller
From: Paolo Abeni Date: Mon, 5 Feb 2018 22:23:01 +0100 > Li Shuang reported an Oops with cls_u32 due to an use-after-free > in u32_destroy_key(). The use-after-free can be triggered with: > > dev=lo > tc qdisc add dev $dev root handle 1: htb default 10 > tc filter add dev

Re: [PATCH net] nfp: fix kdoc warnings on nested structures

2018-02-06 Thread David Miller
From: Jakub Kicinski Date: Mon, 5 Feb 2018 15:29:27 -0800 > Commit 84ce5b987783 ("scripts: kernel-doc: improve nested logic to > handle multiple identifiers") improved the handling of nested structure > definitions in scripts/kernel-doc, and changed the expected

[PATCH net] rxrpc: Fix received abort handling

2018-02-06 Thread David Howells
AF_RXRPC is incorrectly sending back to the server any abort it receives for a client connection. This is due to the final-ACK offload to the connection event processor patch. The abort code is copied into the last-call information on the connection channel and then the event processor is set.

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Eric Dumazet
On Tue, Feb 6, 2018 at 8:27 AM, Tal Gilboa wrote: > On 2/6/2018 5:52 PM, Eric Dumazet wrote: >> >> On Tue, 2018-02-06 at 15:22 +, David Laight wrote: >>> >>> From: Eric Dumazet Sent: 06 February 2018 14:20 >>> >>> >>> ... Please give exact details.

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Geert Uytterhoeven
Hi Sergei, On Tue, Feb 6, 2018 at 3:56 PM, Sergei Shtylyov wrote: > On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: >> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and >> is not present on all SoCs. >> >> Document this in the DT

Re: [PATCH v2] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-06 Thread David Miller
From: Daniel Axtens Date: Mon, 5 Feb 2018 15:02:06 +1100 > tbf_enqueue() checks the size of a packet before enqueuing it. > However, the GSO size check does not consider the GSO_BY_FRAGS > case, and so will drop GSO SCTP packets, causing a massive drop > in throughput. > > Use

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Tal Gilboa
On 2/6/2018 5:52 PM, Eric Dumazet wrote: On Tue, 2018-02-06 at 15:22 +, David Laight wrote: From: Eric Dumazet Sent: 06 February 2018 14:20 ... Please give exact details. Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little sense. We are not optimizing stack for

Re: [PATCH v3] RDS: IB: Fix null pointer issue

2018-02-06 Thread David Miller
From: Guanglei Li Date: Tue, 6 Feb 2018 10:43:21 +0800 > Scenario: > 1. Port down and do fail over > 2. Ap do rds_bind syscall ... > PID: 45659 PID: 47039 > rds_ib_laddr_check > /* create id_priv with a null event_handler */ > rdma_create_id

[PATCH iproute2 v1] ip netns: allow negative nsid

2018-02-06 Thread Christian Brauner
If the kernel receives a negative nsid it will automatically assign the next available nsid. In this case alloc_netid() will set min and max to 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as the maxium range, i.e. specific to nsids it will try to find an id in the range

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread David Miller
From: Kees Cook Date: Wed, 7 Feb 2018 05:36:02 +1100 > Making put_cmsg() inline would help quite a bit with tracking the > builtin_const-ness, and that could speed things up a little bit too. > Would you be opposed to inlining? Nope.

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

2018-02-06 Thread Kirill Tkhai
Hi, Christian, On 06.02.2018 02:24, Christian Brauner wrote: > On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: >> On 05.02.2018 18:55, Christian Brauner wrote: >>> Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK >>> it is possible for userspace to send us

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Florian Westphal
Steffen Klassert wrote: > Cc Wei Wang > > On Sun, Feb 04, 2018 at 01:21:18PM +0200, Eyal Birger wrote: > > Hi, > > > > We've encountered a non released device reference upon device > > unregistration which seems to stem from xfrm policy code. > > > > The setup

Re: [PATCH bpf] tools/bpf: fix batch-mode test failure of test_xdp_redirect.sh

2018-02-06 Thread Daniel Borkmann
On 02/06/2018 01:25 AM, Yonghong Song wrote: > The tests at tools/testing/selftests/bpf can run in patch mode, e.g., > make -C tools/testing/selftests/bpf run_tests > > With the batch mode, I experimented intermittent test failure of > test_xdp_redirect.sh. > > selftests:

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Eyal Birger
Hi Steffen, On Tue, 6 Feb 2018 09:53:38 +0100 Steffen Klassert wrote: > Cc Wei Wang > > On Sun, Feb 04, 2018 at 01:21:18PM +0200, Eyal Birger wrote: > > Hi, > > > > We've encountered a non released device reference upon device > > unregistration which seems to

Re: Potential issue with f5e64032a799 "net: phy: fix resume handling"

2018-02-06 Thread Russell King - ARM Linux
On Mon, Feb 05, 2018 at 10:48:55PM +0100, Heiner Kallweit wrote: > Am 04.02.2018 um 03:48 schrieb Florian Fainelli: > > > > > > On 02/03/2018 03:58 PM, Heiner Kallweit wrote: > >> Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > >>> On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: >

Re: [bpf PATCH v4 0/3] bpf: sockmap fixes

2018-02-06 Thread Daniel Borkmann
On 02/05/2018 07:17 PM, John Fastabend wrote: > A set of fixes for sockmap to resolve programs referencing sockmaps > and closing without deleting all entries in the map and/or not detaching > BPF programs attached to the map. Both leaving entries in the map and > not detaching programs may result

[PATCH 1/2] net, can, ifi: fix "write buffer full" error

2018-02-06 Thread Heiko Schocher
the driver reads in the ISR first the IRQpending register, and clears after that in a write *all* bits in it. It could happen that the isr register raise bits between this 2 register accesses, which leads in lost bits ... In case it clears "TX message sent successfully", the driver never sends

[PATCH 2/2] net, can, ifi: loopback Tx message in IFI block

2018-02-06 Thread Heiko Schocher
Current ifi driver reads first Rx messages, than loopback the Tx message, if the IFI_CANFD_INTERRUPT_TXFIFO_REMOVE bit is set. This can lead into the case, that Rx messages overhelm Tx messages! Fixed this in the following way: Set in the IFI_CANFD_TXFIFO_DLC register the FN value to 1, so the

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

2018-02-06 Thread Christian Brauner
On Tue, Feb 06, 2018 at 01:49:10PM +0300, Kirill Tkhai wrote: > Hi, Christian, > > On 06.02.2018 02:24, Christian Brauner wrote: > > On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: > >> On 05.02.2018 18:55, Christian Brauner wrote: > >>> Since we've added support for IFLA_IF_NETNSID

Re: [Patch net v2] xt_RATEEST: acquire xt_rateest_mutex for hash insert

2018-02-06 Thread Pablo Neira Ayuso
On Mon, Feb 05, 2018 at 02:41:45PM -0800, Cong Wang wrote: > rateest_hash is supposed to be protected by xt_rateest_mutex, > and, as suggested by Eric, lookup and insert should be atomic, > so we should acquire the xt_rateest_mutex once for both. > > So introduce a non-locking helper for internal

Re: [bpf PATCH v4 1/3] net: add a UID to use for ULP socket assignment

2018-02-06 Thread Daniel Borkmann
On 02/05/2018 07:17 PM, John Fastabend wrote: [...] > @@ -124,6 +145,34 @@ int tcp_set_ulp(struct sock *sk, const char *name) > if (!ulp_ops) > return -ENOENT; > > + if (!ulp_ops->user_visible) { > + module_put(ulp_ops->owner); > + return -ENOENT;

[PATCH net] ibmvnic: Ensure that buffers are NULL after free

2018-02-06 Thread Thomas Falcon
This change will guard against a double free in the case that the buffers were previously freed at some other time, such as during a device reset. It resolves a kernel oops that occurred when changing the VNIC device's MTU. Signed-off-by: Thomas Falcon ---

Re: [PATCH v1] r8169: switch to device-managed functions in probe (part 2)

2018-02-06 Thread kbuild test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [RFC PATCH 00/10] PTP support for DSA and mv88e6xxx driver.

2018-02-06 Thread Brandon Streiff
On 2/3/2018 3:40 PM, Andrew Lunn wrote: > This patchset adds support for using the PTP hardware in switches > supported by the mv88e6xxx driver. The code was produces in > collaboration with Brandon Streiff doing the initial implementation, > and then Richard Cochran and Andrew Lunn making further

Re: [PATCH v1] r8169: switch to device-managed functions in probe (part 2)

2018-02-06 Thread kbuild test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on next-20180206] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[PATCH net] ibmvnic: Fix rx queue cleanup for non-fatal resets

2018-02-06 Thread John Allen
At some point, a check was added to exit the polling routine during resets. This makes sense for most reset conditions, but for a non-fatal error, we expect the polling routine to continue running to properly clean up the rx queues. This patch checks if we are performing a non-fatal reset and if

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

2018-02-06 Thread Eric W. Biederman
Christian Brauner writes: > On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: >> On 05.02.2018 18:55, Christian Brauner wrote: >> > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK >> > it is possible for userspace to send

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Eyal Birger
On Tue, 6 Feb 2018 14:15:09 +0100 Florian Westphal wrote: > Steffen Klassert wrote: > > I gave the patch a quick try, but still I get this: > > > > unregister_netdevice: waiting for dummy1 to become free. Usage > > count = 2 > > Was that with

Two net_sched fixes for stable

2018-02-06 Thread Cong Wang
Hi, David Can you queue the following commits for stable? They fix a sleep-in-atomic warning reported by Roland. commit efbf78973978b0d25af59bc26c8013a942af6e64 Author: Cong Wang Date: Mon Dec 4 10:48:18 2017 -0800 net_sched: get rid of rcu_barrier() in

[PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Christophe JAILLET
'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. The modified code should behave the same, because HWTSTAMP_TX_ON is 1 and no other possible values of 'tx_type' would match the test. However, this is more future-proof, should other values be allowed one day. See 'struct

[GIT] Networking

2018-02-06 Thread David Miller
1) Fix error path in netdevsim, from Jakub Kicinski. 2) Default values listed in tcp_wmem and tcp_rmem documentation were inaccurate, from Tonghao Zhang. 3) Fix route leaks in SCTP, both for ipv4 and ipv6. From Alexey Kodanev and Tommi Rantala. 4) Fix "MASK < Y" meant to be "MASK << Y"

[PATCH net] net/ipv6: onlink nexthop checks should default to main table

2018-02-06 Thread David Ahern
Because of differences in how ipv4 and ipv6 handle fib lookups, verification of nexthops with onlink flag need to default to the main table rather than the local table used by IPv4. As it stands an address within a connected route on device 1 can be used with onlink on device 2. Updating the table

[PATCH] cxgb4: Fix error handling path in 'init_one()'

2018-02-06 Thread Christophe JAILLET
Commit baf5086840ab1 ("cxgb4: restructure VF mgmt code") has reordered some code but an error handling label has not been updated accordingly. So fix it and free 'adapter' if 't4_wait_dev_ready()' fails. Fixes: baf5086840ab1 ("cxgb4: restructure VF mgmt code") Signed-off-by: Christophe JAILLET

[PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod

2018-02-06 Thread Naresh Kamboju
test_kmod.sh reported false failure when module not present. Check test_bpf.ko is present in the path before loading it. Stop using "insmod $SRC_TREE/lib/test_bpf.ko" instead use "modprobe test_bpf" Signed-off-by: Naresh Kamboju ---

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

Re: Two net_sched fixes for stable

2018-02-06 Thread David Miller
From: Cong Wang Date: Tue, 6 Feb 2018 11:25:10 -0800 > Can you queue the following commits for stable? They fix a > sleep-in-atomic warning reported by Roland. > > commit efbf78973978b0d25af59bc26c8013a942af6e64 > Author: Cong Wang > Date:

[net] i40e: Fix the number of queues available to be mapped for use

2018-02-06 Thread Jeff Kirsher
From: Amritha Nambiar Fix the number of queues per enabled TC and report available queues to the kernel without having to limit them to the max RSS limit so they are available to be mapped for XPS. This allows a queue per processing thread available for handling

Re: [PATCH 1/1] tcp: Honor the eor bit in tcp_mtu_probe

2018-02-06 Thread kbuild test robot
Hi Ilya, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.15 next-20180206] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: Potential deadlock BUG in drivers/net/wireless/st/cw1200/sta.c (Linux 4.9)

2018-02-06 Thread Iago Abal
Hi, This still looks like a deadlock bug to me, could someone take a look as well and confirm? I will help preparing a patch if needed. Thanks, -- iago On Fri, Nov 18, 2016 at 10:58 PM, Iago Abal wrote: > Hi, > > With the help of a static bug finder (EBA - >

[PATCH net-next] sun: Add SPDX license tags to Sun network drivers

2018-02-06 Thread Shannon Nelson
Add the appropriate SPDX license tags to the Sun network drivers as outlined in Documentation/process/license-rules.rst. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/Kconfig | 1 + drivers/net/ethernet/sun/cassini.c| 1 +

[PATCH net] net/ipv6: Handle reject routes with onlink flag

2018-02-06 Thread David Ahern
Verification of nexthops with onlink flag need to handle unreachable routes. The lookup is only intended to validate the gateway address is not a local address and if the gateway resolves the egress device must match the given device. Hence, hitting any default reject route is ok. Fixes:

[bpf-next V2 PATCH 4/5] selftests/bpf: add selftest that use test_libbpf_open

2018-02-06 Thread Jesper Dangaard Brouer
This script test_libbpf.sh will be part of the 'make run_tests' invocation, but can also be invoked manually in this directory, and a verbose mode can be enabled via setting the environment variable $VERBOSE like: $ VERBOSE=yes ./test_libbpf.sh The script contains some tests that are commented

[bpf-next V2 PATCH 3/5] selftests/bpf: add test program for loading BPF ELF files

2018-02-06 Thread Jesper Dangaard Brouer
V2: Moved program into selftests/bpf from tools/libbpf This program can be used on its own for testing/debugging if a BPF ELF-object file can be loaded with libbpf (from tools/lib/bpf). If something is wrong with the ELF object, the program have a --debug mode that will display the ELF sections

[bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Jesper Dangaard Brouer
If clang >= 4.0.1 is missing the option '-target bpf', it will cause llc/llvm to create two ELF sections for "Exception Frames", with section names '.eh_frame' and '.rel.eh_frame'. The BPF ELF loader library libbpf fails when loading files with these sections. The other in-kernel BPF ELF loader

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 10:13:55AM -0500, Sven Van Asbroeck wrote: > v1: > starting point. > is there a way to test-run this on supported devices that I don't > have physical access to - (ks8995, ksz8864) ? > > Sven Van Asbroeck (1): > spi_ks8995: use regmap to access

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

2018-02-06 Thread Andrew Lunn
> Let me know if you're interested in any testing. Unfortunately I'm going > to be limited to kernel 4.4.38 though as the tegra BSP would need to be > ported in its entirety (a code-base that I don't control). Hi Dave You might be interested in: https://lkml.org/lkml/2018/2/6/24

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread Yury Norov
On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: > From: Yury Norov > Date: Tue, 6 Feb 2018 19:26:23 +0300 > > > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: > >> From: Heiner Kallweit > >> Date: Mon, 5 Feb 2018

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Jesper Dangaard Brouer
On Tue, 6 Feb 2018 08:00:59 -0800 Alexei Starovoitov wrote: > On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: > > If clang >= 4.0.1 is missing the option '-target bpf', it will cause > > llc/llvm to create two ELF sections for "Exception

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread David Miller
From: Denis Du Date: Tue, 6 Feb 2018 15:15:28 + (UTC) > How  do you think my patch? > > As you see, Krzysztof  think my patch is ok to be accepted. > But if you have a better idea to fix it,I am glad to see it. Anyway, this > issue have to be fixed. Please resubmit

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread Yury Norov
On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: > From: Heiner Kallweit > Date: Mon, 5 Feb 2018 07:21:32 +0100 > > > Recently ethtool started to give incomplete values for supported and > > advertised modes. There seems to be a regression in this commit: > >

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:41:14AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > > Rather than invest time in this driver, it would be better to look > > into writing a DSA driver. > > Thank you Andrew. I know little of DSA, but at first

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Sergei Shtylyov
On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document R8A77970

[PATCH iproute2] ip netns: allow negative nsid

2018-02-06 Thread Christian Brauner
If the kernel receives a negative nsid it will automatically assign the next available nsid. In this case alloc_netid() will set min and max to 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as the maxium range, i.e. specific to nsids it will try to find an id in the range

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Eric Dumazet
On Tue, 2018-02-06 at 15:22 +, David Laight wrote: > From: Eric Dumazet > > Sent: 06 February 2018 14:20 > > ... > > Please give exact details. > > Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little > > sense. > > We are not optimizing stack for pathological cases, sorry.

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Heiner Kallweit Date: Mon, 5 Feb 2018 07:21:32 +0100 > Recently ethtool started to give incomplete values for supported and > advertised modes. There seems to be a regression in this commit: > The bit number parameter in the calls to bitmap_to_arr32() in >

Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread David Miller
From: Wolfram Sang Date: Mon, 5 Feb 2018 21:10:01 +0100 > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. > > Signed-off-by: Wolfram Sang Applied and queued up for -stable, thanks.

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread Denis Du
Hi, David: How  do you think my patch? As you see, Krzysztof  think my patch is ok to be accepted. But if you have a better idea to fix it,I am glad to see it. Anyway, this issue have to be fixed. Denis DU On Sunday, January 28, 2018, 9:34:15 AM EST, Krzysztof Halasa

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Alexei Starovoitov
On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: > If clang >= 4.0.1 is missing the option '-target bpf', it will cause > llc/llvm to create two ELF sections for "Exception Frames", with > section names '.eh_frame' and '.rel.eh_frame'. > > The BPF ELF loader library libbpf

Re: [PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu_probe

2018-02-06 Thread David Miller
From: Ilya Lesokhin Date: Mon, 5 Feb 2018 20:18:32 +0200 > Avoid SKB coalescing if eor bit is set in one of the relevant > SKBs. > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > Signed-off-by: Ilya Lesokhin This adds a build

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > Rather than invest time in this driver, it would be better to look > into writing a DSA driver. Thank you Andrew. I know little of DSA, but at first sight it appears to be a _very_ complicated beast for a switch PHY which only

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread Denis Du
Ok, I submit it  again. In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the carrier detect still ok, but the protocol will fail. So if carrier detect ok, don't turn off protocol negotiation This patch is against the kernel version Linux 4.15-rc8 On Tuesday,

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-02-06 Thread Guillaume Nault
On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: > On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: > > On 01/25/2018 03:58 PM, Guillaume Nault wrote: > > > Hi, > > > > > > Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct > > > ethhdr"), > > >

RE: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread David Laight
From: Eric Dumazet > Sent: 06 February 2018 14:20 ... > Please give exact details. > Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little sense. > We are not optimizing stack for pathological cases, sorry. There are plenty of workloads which are not bulk data and where multiple

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread David Miller
From: Kees Cook Date: Tue, 6 Feb 2018 04:31:50 +1100 > On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >> From: Kees Cook >> Date: Fri, 2 Feb 2018 02:27:49 -0800 >> >>> @@ -343,6 +343,14 @@ struct ucred { >>> >>> extern

Re: [PATCH net 0/2] be2net: patch-set

2018-02-06 Thread David Miller
From: Suresh Reddy Date: Tue, 6 Feb 2018 08:52:40 -0500 > Hi Dave, Please consider applying these two patches to net Series applied, thank you.

Re: [PATCH iproute2] ip netns: allow negative nsid

2018-02-06 Thread Stephen Hemminger
On Tue, 6 Feb 2018 16:16:15 +0100 Christian Brauner wrote: > If the kernel receives a negative nsid it will automatically assign the > next available nsid. In this case alloc_netid() will set min and max to > 0 for ird_alloc(). And when max == 0 idr_alloc() will

[vhost:vhost 20/20] ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined!

2018-02-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 commit: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 [20/20] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT config: ia64-allmodconfig (attached as .config) compiler:

Re: [PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups

2018-02-06 Thread David Ahern
On 2/2/18 6:10 AM, Serhey Popovych wrote: > @@ -414,15 +428,18 @@ static int do_tunnels_list(struct ip_tunnel_parm *p) > fprintf(stderr, "Failed to get type of \"%s\"\n", name); > continue; > } > - if (type != ARPHRD_TUNNEL &&

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

2018-02-06 Thread Ivan Khoronzhuk
On Tue, Feb 06, 2018 at 07:17:06PM -0600, Grygorii Strashko wrote: > It was discovered that simple program which indefinitely sends 200b UDP > packets and runs on TI AM574x SoC (SMP) under RT Kernel triggers network > watchdog timeout in TI CPSW driver (<6 hours run). The network watchdog >

Re: [vhost:vhost 20/20] ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined!

2018-02-06 Thread Wei Wang
On 02/07/2018 09:26 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 commit: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 [20/20] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT config:

RE: [vhost:vhost 20/20] ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined!

2018-02-06 Thread Wang, Wei W
On Wednesday, February 7, 2018 10:52 AM, Michael S. Tsirkin wrote: > On Wed, Feb 07, 2018 at 10:25:35AM +0800, Wei Wang wrote: > > On 02/07/2018 09:26 AM, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > vhost > > > head:

qdisc_pkt_len_init: SCTP/GSO_BY_FRAGS and robustness questions

2018-02-06 Thread Daniel Axtens
Hi Marcelo and Eric, I'm working on checking code that might be impacted by GSO_BY_FRAGS - after finding that the token bucket filter qdisc code doesn't handle it properly, DaveM said I should look for other places where this might be an issue [0]. I'm currently looking at qdisc_pkt_len_init in

Re: [PATCH] atm: idt77252: Replace mdelay with usleep_range in idt77252_preset

2018-02-06 Thread Maciej W. Rozycki
On Fri, 26 Jan 2018, Jia-Ju Bai wrote: > diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c > index 0277f36..cea4bf2 100644 > --- a/drivers/atm/idt77252.c > +++ b/drivers/atm/idt77252.c > @@ -3563,7 +3563,7 @@ static int idt77252_preset(struct idt77252_dev *card) > > /* Software

[PATCH net-next] sch_netem: Bug fixing in calculating Netem interval

2018-02-06 Thread Md. Islam
In Kernel 4.15.0+, Netem does not work properly. Netem setup: tc qdisc add dev h1-eth0 root handle 1: netem delay 10ms 2ms Result: PING 172.16.101.2 (172.16.101.2) 56(84) bytes of data. 64 bytes from 172.16.101.2: icmp_seq=1 ttl=64 time=22.8 ms 64 bytes from 172.16.101.2: icmp_seq=2 ttl=64

[PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

2018-02-06 Thread Grygorii Strashko
It was discovered that simple program which indefinitely sends 200b UDP packets and runs on TI AM574x SoC (SMP) under RT Kernel triggers network watchdog timeout in TI CPSW driver (<6 hours run). The network watchdog timeout is triggered due to race between cpsw_ndo_start_xmit() and

[PATCH RFC 2/4] netlink: add generic object description infrastructure

2018-02-06 Thread Pablo Neira Ayuso
This patch allows netlink busses to provide object descriptions to userspace, in terms of supported attributes and its corresponding datatypes. Userspace sends a requests that looks like: netlink header NLA_DESC_REQ_BUS NLA_DESC_REQ_DATA Where NLA_DESC_REQ_BUS is the

[PATCH RFC 3/4] netfilter: nfnetlink: add support for netlink descriptions

2018-02-06 Thread Pablo Neira Ayuso
NETLINK_NETFILTER is shared by several netfilter subsystems, add new infrastructure to allow subsystems to register their own descriptions. Hence, nfnetlink routes description requests to the corresponding subsystem backend. Signed-off-by: Pablo Neira Ayuso ---

[PATCH RFC 1/4] netlink: add NLA_PAD definition

2018-02-06 Thread Pablo Neira Ayuso
The new generic netlink description infrastructure needs this new type to describe padding attributes. Signed-off-by: Pablo Neira Ayuso --- include/net/netlink.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/net/netlink.h b/include/net/netlink.h index

[PATCH RFC 4/4] netfilter: nf_tables: add netlink description

2018-02-06 Thread Pablo Neira Ayuso
This patch adds the netlink description for nf_tables. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 2 + include/uapi/linux/netfilter/nf_tables_desc.h | 57 net/netfilter/Makefile| 7 +-

[PATCH RFC 0/4] Netlink bus descriptions

2018-02-06 Thread Pablo Neira Ayuso
Hi, Modern messaging systems usually provide facilities that allows you to inquire about supported commands and message layouts. Netlink has no such facility so far, hence people end up probing for features, which is a bit sloppy. Sometimes there are also magic version numbers in place that gives

[Android][Kernel][TCP/IP] report of packet discarding during tcp handshaking

2018-02-06 Thread 배석진
Hello, this is bae working on samsung elec. we have a problem that packet discarded during 3-way handshaking on TCP. already looks like that Mr Dumazet try to fix the similar issue on this patch, https://android.googlesource.com/kernel/common/+/5e0724d027f0548511a2165a209572d48fe7a4c8 but

Re: [vhost:vhost 20/20] ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined!

2018-02-06 Thread Michael S. Tsirkin
On Wed, Feb 07, 2018 at 10:25:35AM +0800, Wei Wang wrote: > On 02/07/2018 09:26 AM, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 > > commit: 96bcd04462b99e2c80e09f6537770a0ca6b288d0

Re: [PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups

2018-02-06 Thread David Ahern
On 2/6/18 7:16 PM, David Ahern wrote: > On 2/2/18 6:10 AM, Serhey Popovych wrote: >> @@ -414,15 +428,18 @@ static int do_tunnels_list(struct ip_tunnel_parm *p) >> fprintf(stderr, "Failed to get type of \"%s\"\n", name); >> continue; >> } >> -

[PATCH net] tcp: tracepoint: only call trace_tcp_send_reset with full socket

2018-02-06 Thread Song Liu
tracepoint tcp_send_reset requires a full socket to work. However, it may be called when in TCP_TIME_WAIT: case TCP_TW_RST: tcp_v6_send_reset(sk, skb); inet_twsk_deschedule_put(inet_twsk(sk)); goto discard_it; To avoid this problem, this

  1   2   >