[PATCH net-next nfs 6/6] net: Convert rxrpc_net_ops

These pernet_operations modifies rxrpc_net_id-pointed per-net entities. There is external link to AF_RXRPC in fs/afs/Kconfig, but it seems there is no other pernet_operations interested in that per-net entities. Signed-off-by: Kirill Tkhai --- net/rxrpc/net_ns.c |1 +

Re: BUG: corrupted list in sctp_association_free

On Tue, Mar 13, 2018 at 02:09:09PM +0300, Dmitry Vyukov wrote: > On Tue, Mar 13, 2018 at 1:44 PM, Xin Long wrote: > > On Tue, Mar 13, 2018 at 3:34 PM, syzbot > > wrote: > >> Hello, > >> > >> syzbot hit the following

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: > Hello again, > > The fun thing is that before the commit "ip route ls all" showed all > routes, but "ip -[4|6] route ls all" showed only default. So it was > broken too, but in other way. > I see parsing of prefix was changed since my

Re: [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support

On Mon, Mar 12, 2018 at 03:30:53PM -0700, Florian Fainelli wrote: > On 03/12/2018 02:57 PM, Andrew Lunn wrote: > >> + /* attempt to find a phy-handle */ > >> + if (!(bp->phy_node = of_parse_phandle(np, "phy-handle", > >> 0))) { > >> + > >> +

[PATCH iproute2 1/1] tc: print actual action for sample action

Signed-off-by: Roman Mashak --- tc/m_sample.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tc/m_sample.c b/tc/m_sample.c index ff5ee6bd1ef6..d88846c63be3 100644 --- a/tc/m_sample.c +++ b/tc/m_sample.c @@ -163,6 +163,8 @@ static int print_sample(struct action_util *au,

RE: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

From: Daniel Micay > Sent: 10 March 2018 23:45 > > > Just wondering. Is this actually a VLA. FFT_NUM_SAMPLES was static const so > > not really going to show a lot of variation. This array will always have the > > same size on the stack. > > The issue is that unlike in C++, a `static const`

RE: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

The amount of replicated defined could also be reduced by passing > or < to a min_max() macro. So you start off with something like: #define min(x, y) __min_max(x, <, y) #define max(x, y) __min_max(x, >, y) then have: #define __min_max(x, cond, y) ((x) cond (y) ? (x) : (y)) in all its associated

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

David Miller wrote: > From: Felix Fietkau > Date: Mon, 12 Mar 2018 20:30:01 +0100 > > > It's not dead and useless. In its current state, it has a software fast > > path that significantly improves nftables routing/NAT throughput, > > especially on embedded

[PATCH v5 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version v4: - no changes v5: - no changes

[PATCH v5 5/6] staging: fsl-dpaa2/ethsw: Add README

Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106

[PATCH v5 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3c2b75..20d7bf2 100644

[PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes v4: - adjust to moving

[PATCH v5 0/6] staging: Introduce DPAA2 Ethernet Switch driver

This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set

[PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in

[PATCH v5 6/6] staging: fsl-dpaa2/ethsw: Add TODO

Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - remove fsl-mc bus driver dependency as it is out of staging

Re: [PATCH v3 net 0/5] tcp: fixes to non-SACK TCP

On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > Here is a series of fixes to issues that occur when SACK is not > enabled for a TCP connection. These are not fixes to just some > remote corner cases of recovery but many/almost all recoveries > without SACK will

Re: [PATCH 1/2] udp: Move the udp sysctl to namespace.

On Tue, Mar 13, 2018 at 7:36 PM, Paolo Abeni wrote: > Hi, > > On Tue, 2018-03-13 at 02:57 -0700, Tonghao Zhang wrote: >> This patch moves the udp_rmem_min, udp_wmem_min >> to namespace and init the udp_l3mdev_accept explicitly. > > Can you please be a little more descriptive on

RE: mmiowb() vs wmb() with write combined MMIO

> has uncovered an issue in qede NIC driver [/drivers/net/ethernet/qlogic/qede] > and > this driver is seriously broken for basic L2. That's a bit extreme. There is a race condition bug that needs fixing. > Before the series from John, driver was running fine, probably with hiding a > serious >

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> +/* For the moment, only flood setting needs to be updated */ > +static int port_bridge_join(struct net_device *netdev, > + struct net_device *upper_dev) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + struct ethsw_core *ethsw =

Re: pull request (net): ipsec 2018-03-13

From: Steffen Klassert Date: Tue, 13 Mar 2018 08:09:44 +0100 > Please pull or let me know if there are problems. Pulled, thanks!

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser Date: Mon, 12 Mar 2018 22:32:00 -0700 > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. >

[PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

For multipath routes the ONLINK flag is specified per nexthop in rtnh_flags (as opposed to rtm_flags for unicast routes). Update ip6_route_multipath_add to set fc_flags based on rtnh_flags. Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag") Signed-off-by: David Ahern

[PATCH net-next 2/2] selftests: Add multipath tests for onlink flag

Add multipath tests for onlink flag: one test with onlink added to both nexthops, then tests with onlink added to only 1 nexthop. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib-onlink-tests.sh | 92 - 1 file changed, 89 insertions(+), 3

[PATCH net-next 0/2] net/ipv6: Handle onlink flag with multipath routes

ONLINK flag is per nexthop. For multipath routes it is specified in rtnh_flags in struct rtnexthop versus rtm_flags for single path routes. Update ip6_route_multipath_add to look at rtnh_flags before the call to ip6_route_info_create. Add multipath test cases as well. David Ahern (2):

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

David Miller wrote: [ flow tables ] > Ok, that seems to constrain the exposure. > > We should talk at some point about how exposed conntrack itself is. Sure, we can do that. If you have specific scenarios (synflood, peer that opens 100k (legitimate) connections,

Re: [PATCH net-next v2] sctp: fix error return code in sctp_sendmsg_new_asoc()

From: Wei Yongjun Date: Tue, 13 Mar 2018 03:03:30 + > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote: > Actually the suggestion I had from Don Dutile was that we should be > looking at creating a pci-stub like driver specifically for those type > of devices, but without the ability to arbitrarily assign devices. > Basically we have to

[PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

Before this commit, dev_forward_skb() always cleared packet's per-network-namespace info. Even if the packet doesn't cross network namespaces. The comment above dev_forward_skb() describes that this is done because the receiving device may be in another network namespace. However, this case can

Re: [PATCH net-next 0/4] Converting pernet_operations (part #6)

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:36:33 +0300 > this series continues to review and to convert pernet_operations > to make them possible to be executed in parallel for several > net namespaces in the same time. There are sctp, tipc and rds > in this series.

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Tue, Mar 13, 2018 at 5:51 PM, Or Gerlitz wrote: Sorry ppl, I added MLNX alias (asap_direct_...@mellanox.com) which is not open to outer posts, please remove it from your replies, otherwise it will bump you back.. Or. > On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko

Re: [PATCH net-next] ibmvnic: Fix recent errata commit

From: Thomas Falcon Date: Mon, 12 Mar 2018 21:05:26 -0500 > Sorry, one of the patches I sent in an earlier series > has some dumb mistakes. One was that I had changed the > parameter for the errata workaround function but forgot > to make that change in the code that

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On Tue, Mar 13, 2018 at 1:12 AM, David Woodhouse wrote: > On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote: >> >> - .sriov_configure = ena_sriov_configure, >> +#ifdef CONFIG_PCI_IOV >> + .sriov_configure = pci_sriov_configure_simple, >> +#endif >> }; > >

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Mon, Mar 12, 2018 at 04:58:38PM -0700, Joe Perches wrote: > On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wvla, remove VLA and replace it > > with dynamic memory allocation. > > > > From a security viewpoint, the use of Variable Length Arrays can

Re: [PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

From: Subash Abhinov Kasiviswanathan Date: Mon, 12 Mar 2018 20:26:06 -0600 > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > index 6ce31e2..65b074e 100644 > ---

Re: [PATCH net] qed: Use after free in qed_rdma_free()

From: Dan Carpenter Date: Tue, 13 Mar 2018 12:09:38 +0300 > We're dereferencing "p_hwfn->p_rdma_info" but that is freed on the line > before in qed_rdma_resc_free(p_hwfn). > > Fixes: 9de506a547c0 ("qed: Free RoCE ILT Memory on rmmod qedr") > Signed-off-by: Dan

Re: [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself

On Mon, Mar 12, 2018 at 6:11 PM, Andrew Lunn wrote: >> The flag was introduced to enable hardware switch capabilities of >> drivers/net/wireless/quantenna/qtnfmac wifi driver. It does not have any >> switchdev functionality in upstream tree at this moment, and this patchset >> was

Re: [PATCH V2 net 1/1] net/smc: simplify wait when closing listen socket

From: Ursula Braun Date: Tue, 13 Mar 2018 10:41:54 +0100 > Closing of a listen socket wakes up kernel_accept() of > smc_tcp_listen_worker(), and then has to wait till smc_tcp_listen_worker() > gives up the internal clcsock. The wait logic introduced with > commit

RE: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, March 13, 2018 4:23 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; Alexander

Re: [PATCH net-next nfs 0/6] Converting pernet_operations (part #7)

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:49:05 +0300 > Hi, > > this series continues to review and to convert pernet_operations > to make them possible to be executed in parallel for several > net namespaces in the same time. There are nfs pernet_operations > in this

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> Hello Andrew, > > The current driver implementation uses only a single FDB for the switch, > so it is not possible configure multiple flooding domains to accommodate > ports partitioning. Ah, O.K. Rather than break somebodies network by wrongly flooding, it would be better to return

[PATCH net 0/1] net/iucv: fix 2018-03-13

Hi Dave, please apply one patch for af_iucv, that fixes an error path during initialization. Thanks, Julian Arvind Yadav (1): net/iucv: Free memory obtained by kzalloc net/iucv/af_iucv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.13.5

[PATCH net 1/1] net/iucv: Free memory obtained by kzalloc

From: Arvind Yadav Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav Reviewed-by: Cornelia Huck Signed-off-by: Ursula Braun Signed-off-by:

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>If a netdev has registered and is a slave of a given bond, then any tc >>rules

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

From: Florian Westphal Date: Tue, 13 Mar 2018 14:41:39 +0100 > David Miller wrote: >> From: Felix Fietkau >> Date: Mon, 12 Mar 2018 20:30:01 +0100 >> >> > It's not dead and useless. In its current state, it has a software fast >> > path that

Re: [PATCH net-next] net: Add comment about pernet_operations methods and synchronization

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:55:55 +0300 > Make locking scheme be visible for users, and provide > a comment what for we are need exit_batch() methods, > and when it should be used. > > Signed-off-by: Kirill Tkhai Applied.

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

On Tue, Mar 13, 2018 at 05:07:22PM +0200, Liran Alon wrote: > Before this commit, dev_forward_skb() always cleared packet's > per-network-namespace info. Even if the packet doesn't cross > network namespaces. > > The comment above dev_forward_skb() describes that this is done > because the

Re: linux-next: build warning after merge of the net-next tree

From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 06:46:24 -0500 > Hi Stephen, > > On 03/13/2018 01:11 AM, Stephen Rothwell wrote: >> Hi all, >> After merging the net-next tree, today's linux-next build (sparc >> defconfig) produced this warning: >> net/core/pktgen.c:

Re: net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

Randy Dunlap wrote: > From: Randy Dunlap > > Lots of the wireless driver vendor Kconfig symol help text says > "questions about cards." (2 spaces between "about" and "cards") > > Besides dropping one of those spaces, it also needs some other word

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to

Re: [PATCH net-next] cxgb4: Add HMA support

From: Arjun Vynipadath Date: Tue, 13 Mar 2018 16:24:45 +0530 > HMA(Host Memory Access) maps a part of host memory for T6-SO memfree cards. > > This commit does the following: > - Query FW to check if we have HMA support. If yes, the params will > return HMA size configured

[PATCH v4 net-next 3/6] net/ipv6: Add l3mdev check to ipv6_chk_addr_and_flags

Lookup the L3 master device for the passed in device. Only consider addresses on netdev's with the same master device. If the device is not enslaved or is NULL, then the l3mdev is NULL which means only devices not enslaved (ie, in the default domain) are considered. Signed-off-by: David Ahern

[PATCH v4 net-next 4/6] selftests: fib_tests: Use an alias for ip command

Replace 'ip -netns testns' with the alias IP. Shortens the line lengths and makes running the commands manually a bit easier. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 169 --- 1 file changed, 85 insertions(+), 84

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Tue, 2018-03-13 at 15:59 +0100, Pablo Neira Ayuso wrote: > On Mon, Mar 12, 2018 at 04:58:38PM -0700, Joe Perches wrote: > > On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wvla, remove VLA and replace it > > > with dynamic memory allocation. > > >

[PATCH v4 net-next 6/6] selftests: fib_tests: Add IPv6 nexthop spec tests

Add series of tests for valid and invalid nexthop specs for IPv6. $ TEST=fib_nexthop_test ./fib_tests.sh ... IPv6 nexthop tests TEST: Directly connected nexthop, unicast address [ OK ] TEST: Directly connected nexthop, unicast address with device [ OK ] TEST: Gateway is

[PATCH v4 net-next 5/6] selftests: fib_tests: Allow user to run a specific test

Allow a user to run just a specific fib test by setting the TEST environment variable. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH v4 net-next 2/6] net/ipv6: Change address check to always take a device argument

ipv6_chk_addr_and_flags determines if an address is a local address and optionally if it is an address on a specific device. For example, it is called by ip6_route_info_create to determine if a given gateway address is a local address. The address check currently does not consider L3 domains and

[PATCH v4 net-next 1/6] net/ipv6: Refactor gateway validation on route add

Move gateway validation code from ip6_route_info_create into ip6_validate_gw. Code move plus adjustments to handle the potential reset of dev and idev and to make checkpatch happy. Signed-off-by: David Ahern --- net/ipv6/route.c | 120

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On 03/13/2018 11:04 AM, David Woodhouse wrote: On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote: Actually the suggestion I had from Don Dutile was that we should be looking at creating a pci-stub like driver specifically for those type of devices, but without the ability to arbitrarily

[PATCH v4 net-next 0/6] net/ipv6: Address checks need to consider the L3 domain

IPv6 prohibits a local address from being used as a gateway for a route. However, it is ok for the gateway to be a local address in a different L3 domain (e.g., VRF). This allows, for example, veth pairs to connect VRFs. ip6_route_info_create calls ipv6_chk_addr_and_flags for gateway addresses to

Re: BUG_ON triggered in skb_segment

Adding additional cc's: Saeed Mahameed as this is most likely mlx5 driver related. Diptanu Gon Choudhury who initially reported the issue. On 3/13/18 1:44 AM, Steffen Klassert wrote: On Mon, Mar 12, 2018 at 11:25:09PM -0700, Eric Dumazet wrote: On 03/12/2018 11:08 PM, Yonghong Song

Re: BUG_ON triggered in skb_segment

On 03/13/2018 03:37 PM, Yonghong Song wrote: Adding additional cc's:   Saeed Mahameed as this is most likely mlx5 driver related.   Diptanu Gon Choudhury who initially reported the issue. On 3/13/18 1:44 AM, Steffen Klassert wrote: On Mon, Mar 12, 2018 at 11:25:09PM -0700, Eric Dumazet

[PATCH net-next v2 2/4] net: qualcomm: rmnet: Update copyright year to 2018

Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c| 2 +-

[PATCH net-next v2 4/4] net: qualcomm: rmnet: Implement fill_info

This is needed to query the mux_id and flags of a rmnet device. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

[PATCH net-next v2 3/4] net: qualcomm: rmnet: Remove unnecessary device assignment

Device of the de-aggregated skb is correctly assigned after inspecting the mux_id, so remove the assignment in rmnet_map_deaggregate(). Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 1 - 1 file changed, 1

Re: BUG_ON triggered in skb_segment

On 03/14/2018 12:09 AM, Alexei Starovoitov wrote: > On 3/13/18 3:47 PM, Eric Dumazet wrote: >> >> >> On 03/13/2018 03:37 PM, Yonghong Song wrote: >>> Adding additional cc's: >>>    Saeed Mahameed as this is most likely mlx5 driver related. >>>    Diptanu Gon Choudhury who initially reported the

[PATCH 2/2] hns: Clean up string operations

The driver-internal string operations are only ever used for statistics, so remove the stringset parameters and rename them accordingly. Signed-off-by: Ben Hutchings --- drivers/net/ethernet/hisilicon/hns/hnae.h | 13

Re: [PATCH 12/15] ice: Add stats and ethtool support

From: "Venkataramanan, Anirudh" Date: Tue, 13 Mar 2018 19:05:19 + > Thanks for the feedback. I am not sure I understand what's being asked > here. Do you mean to say that standard netdev stats should not be > printed when we do ethtool -S or something else?

[PATCH] pktgen: use dynamic allocation for debug print buffer

After the removal of the VLA, we get a harmless warning about a large stack frame: net/core/pktgen.c: In function 'pktgen_if_write': net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The function was previously shown to be safe

[PATCH iproute2 1/1] tc: use get_u32() in psample action to match types

Signed-off-by: Roman Mashak --- tc/m_sample.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tc/m_sample.c b/tc/m_sample.c index ff5ee6bd1ef6..dff986f5 100644 --- a/tc/m_sample.c +++ b/tc/m_sample.c @@ -65,7 +65,7 @@ static int

[pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

From: Alexander Duyck This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck ---

[PATCH net-next v2 0/4] net: qualcomm: rmnet: Updates 2018-03-12

This series contains some minor updates for rmnet driver. Patch 1 contains fixes for sparse warnings. Patch 2 updates the copyright date to 2018. Patch 3 is a cleanup in receive path. Patch 4 has the implementation of the fill_info operation. v1->v2: Remove the force casts since the data type is

[PATCH net-next v2 1/4] net: qualcomm: rmnet: Fix casting issues

Fix warnings which were reported when running with sparse (make C=1 CF=-D__CHECK_ENDIAN__) drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: warning: cast to restricted __be16 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: warning: incorrect type in assignment (different

Re: [PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

Ummm, if you change pkt_len to be a proper __be16, then you don't need these casts when passing it to ntohs(). Hi David I have fixed this now in v2. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: BUG_ON triggered in skb_segment

On 3/13/18 3:47 PM, Eric Dumazet wrote: On 03/13/2018 03:37 PM, Yonghong Song wrote: Adding additional cc's: Saeed Mahameed as this is most likely mlx5 driver related. Diptanu Gon Choudhury who initially reported the issue. On 3/13/18 1:44 AM, Steffen Klassert wrote: On Mon, Mar 12,

Re: BUG_ON triggered in skb_segment

On 03/13/2018 04:09 PM, Alexei Starovoitov wrote: we have bpf_skb_proto_6_to_4() that was used by cilium for long time. It's not clear why it's not crashing there, but we cannot just reject changing proto in bpf programs now. We have to fix whatever needs to be fixed in skb_segment (if bug is

Re: [PATCH net-next v2 2/4] net: qualcomm: rmnet: Update copyright year to 2018

On Tue, 2018-03-13 at 16:50 -0600, Subash Abhinov Kasiviswanathan wrote: > Signed-off-by: Subash Abhinov Kasiviswanathan > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- >

[PATCH net 1/2] hns: Fix string set validation in ethtool string operations

The hns driver used to assume that it would only ever be asked about ETH_SS_TEST or ETH_SS_STATS, and for any other stringset it would claim a count of 0 but if asked for names would copy over all the statistic names. This resulted in a potential heap buffer overflow. This was "fixed" some time

[PATCH v2 net 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault:

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On Tue, Mar 13, 2018 at 01:45:12PM -0700, David Ahern wrote: > On 3/13/18 1:32 AM, Leon Romanovsky wrote: > > On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: > >> On 3/12/18 8:16 AM, Steve Wise wrote: > >>> Hey all, > >>> > >>> The kernel side of this series has been merged for

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: > > Yes, this is a recurring mistake > > See commit > bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet > statistics of netdev" Thanks for the pointer, that was a useful thread to review. I

[pci PATCH v6 3/5] ena: Migrate over to unmanaged SR-IOV support

From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[pci PATCH v6 4/5] nvme: Migrate over to unmanaged SR-IOV support

From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the nvme driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

From: Alexander Duyck Add a new driver called "pci-pf-stub" to act as a "white-list" for PF devices that provide no other functionality other then acting as a means of allocating a set of VFs. For now I only have one example ID provided by Amazon in terms of devices

[PATCH net] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

There is no need for complex checking between the last consumed index and current consumed index, a simple subtraction will do. This also eliminates the possibility of a permanent transmit queue stall under the following conditions: - one CPU bursts ring->size worth of traffic (up to 256

Re: Possible tcp regression in 4.14.13..26

On 03/13/2018 02:41 PM, Timofey Titovets wrote: Hi list, We currently upgrade our servers from 4.14.13 to 4.14.26 And get some problems with random kernel oops by: [ 422.081094] BUG: unable to handle kernel NULL pointer dereference at 0038 [ 422.081254] IP: tcp_push+0x42/0x110 [

Re: [PATCH iproute2] treat "default" and "all"/"any" parameters differenty

On Tue, 2018-03-13 at 21:19 +0100, Alexander Zubkov wrote: > Debian maintainer found that basic command: > # ip route flush all > No longer worked as expected which breaks user scripts and > expectations. It no longer flushed all IPv4 routes. > > Recently behaviour of "default" prefix

[PATCH bpf-next v5 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID

test_stacktrace_build_id() is added. It accesses tracepoint urandom_read with "dd" and "urandom_read" and gathers stack traces. Then it reads the stack traces from the stackmap. urandom_read is a statically link binary that reads from /dev/urandom. test_stacktrace_build_id() calls readelf to read

[PATCH bpf-next v5 0/2] bpf stackmap with build_id+offset

Changes v4 -> v5: 1. Only allow build_id lookup in non-nmi context. Added comment and commit message to highlight this limitation. 2. Minor fix reported by kbuild test robot. Changes v3 -> v4: 1. Add fallback when build_id lookup failed. In this case, status is set to

[PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

Currently, bpf stackmap store address for each entry in the call trace. To map these addresses to user space files, it is necessary to maintain the mapping from these virtual address to symbols in the binary. Usually, the user space profiler (such as perf) has to scan /proc/pid/maps at the

Re: linux-next: build warning after merge of the net-next tree

On 03/13/2018 10:33 AM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 06:46:24 -0500 Hi Stephen, On 03/13/2018 01:11 AM, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (sparc defconfig) produced

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On Tue, 2018-03-13 at 13:45 -0700, David Ahern wrote: > On 3/13/18 1:32 AM, Leon Romanovsky wrote: > > On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: > > > On 3/12/18 8:16 AM, Steve Wise wrote: > > > > Hey all, > > > > > > > > The kernel side of this series has been merged for

[pci PATCH v6 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

From: Alexander Duyck Hardware-realized virtio_pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio_net PF and virtio_net VFs. These are hardware realizations of what has been

Re: [PATCH bpf-next v4 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

> On Mar 12, 2018, at 3:47 PM, Song Liu wrote: > > > >> On Mar 12, 2018, at 2:31 PM, Alexei Starovoitov wrote: >> >> On 3/12/18 2:12 PM, Song Liu wrote: >>> On Mar 12, 2018, at 2:00 PM, Alexei Starovoitov wrote: On 3/12/18

[PATCH v5 net-next 1/4] net: macb: Reorganize macb_mii bringup

The macb mii setup (mii_probe() and mii_init()) previously was somewhat interspersed, likely a result of organic growth and hacking. This change moves mii bus registration into mii_init and probing the bus for devices into mii_probe. Signed-off-by: Brad Mouring

[PATCH v5 net-next 2/4] net: macb: Remove redundant poll irq assignment

In phy_device's general probe, this device will already be set for phy register polling, rendering this code redundant. Signed-off-by: Brad Mouring Suggested-by: Andrew Lunn Reviewed-by: Florian Fainelli ---

[PATCH v5 net-next 0/4] net: macb: Introduce phy-handle DT functionality

Consider the situation where a macb netdev is connected through a phydev that sits on a mii bus other than the one provided to this particular netdev. This situation is what this patchset aims to accomplish through the existing phy-handle optional binding. This optional binding (as described in

[PATCH v5 net-next 3/4] net: macb: Add phy-handle DT support

This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would

[PATCH v5 net-next 4/4] Documentation: macb: Document phy-handle binding

Document the existence of the optional binding, directing to the general ethernet document that describes this binding. Signed-off-by: Brad Mouring Reviewed-by: Florian Fainelli --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed,

Possible tcp regression in 4.14.13..26

Hi list, We currently upgrade our servers from 4.14.13 to 4.14.26 And get some problems with random kernel oops by: [ 422.081094] BUG: unable to handle kernel NULL pointer dereference at 0038 [ 422.081254] IP: tcp_push+0x42/0x110 [ 422.081314] PGD 0 P4D 0 [ 422.081364] Oops: 0002

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-03-13 20:58 GMT+01:00 Vivien Didelot : > Hi Salvatore, Hi Vivien, > Salvatore Mesoraca writes: > >> dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid >> 2 VLAs[1] by using DSA_MAX_PORTS instead of

<    1   2   3   >